[jira] [Commented] (NIFI-5169) Upgrade to JsonPath 2.4.0

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488054#comment-16488054
 ] 

ASF subversion and git services commented on NIFI-5169:
---

Commit 716587d09f97cb01d685b79c010534af9aea1985 in nifi's branch 
refs/heads/master from [~mike.thomsen]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=716587d ]

NIFI-5169 This closes #2705. Upgrade to JSONPath 2.4
NIFI-5169 Added explicit checking for empty strings in JsonPath expression 
property.

Signed-off-by: joewitt 


> Upgrade to JsonPath 2.4.0
> -
>
> Key: NIFI-5169
> URL: https://issues.apache.org/jira/browse/NIFI-5169
> Project: Apache NiFi
>  Issue Type: Task
>Affects Versions: 1.6.0
>Reporter: Dennis Dahlmann
>Assignee: Mike Thomsen
>Priority: Major
>  Labels: JSON
> Fix For: 1.7.0
>
>
> A newer version (2.4.0) of JsonPath is availabel at  
> [github|[https://github.com/json-path/JsonPath].]
> With this version a currently existing bug is fixed, take this JSON
> {"Epoch timestamp [s]":"1486373924","temperature [C]":"20"}
> and try to get the value of "Epoch timestamp [s]" with $.['Epoch timestamp 
> [s]'] this will result in an empty result with version 2.0.0 which is 
> currently, but with version 2.4.0 you get the right value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-5169) Upgrade to JsonPath 2.4.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488057#comment-16488057
 ] 

ASF GitHub Bot commented on NIFI-5169:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2705


> Upgrade to JsonPath 2.4.0
> -
>
> Key: NIFI-5169
> URL: https://issues.apache.org/jira/browse/NIFI-5169
> Project: Apache NiFi
>  Issue Type: Task
>Affects Versions: 1.6.0
>Reporter: Dennis Dahlmann
>Assignee: Mike Thomsen
>Priority: Major
>  Labels: JSON
> Fix For: 1.7.0
>
>
> A newer version (2.4.0) of JsonPath is availabel at  
> [github|[https://github.com/json-path/JsonPath].]
> With this version a currently existing bug is fixed, take this JSON
> {"Epoch timestamp [s]":"1486373924","temperature [C]":"20"}
> and try to get the value of "Epoch timestamp [s]" with $.['Epoch timestamp 
> [s]'] this will result in an empty result with version 2.0.0 which is 
> currently, but with version 2.4.0 you get the right value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-5169) Upgrade to JsonPath 2.4.0

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488055#comment-16488055
 ] 

ASF subversion and git services commented on NIFI-5169:
---

Commit 716587d09f97cb01d685b79c010534af9aea1985 in nifi's branch 
refs/heads/master from [~mike.thomsen]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=716587d ]

NIFI-5169 This closes #2705. Upgrade to JSONPath 2.4
NIFI-5169 Added explicit checking for empty strings in JsonPath expression 
property.

Signed-off-by: joewitt 


> Upgrade to JsonPath 2.4.0
> -
>
> Key: NIFI-5169
> URL: https://issues.apache.org/jira/browse/NIFI-5169
> Project: Apache NiFi
>  Issue Type: Task
>Affects Versions: 1.6.0
>Reporter: Dennis Dahlmann
>Assignee: Mike Thomsen
>Priority: Major
>  Labels: JSON
> Fix For: 1.7.0
>
>
> A newer version (2.4.0) of JsonPath is availabel at  
> [github|[https://github.com/json-path/JsonPath].]
> With this version a currently existing bug is fixed, take this JSON
> {"Epoch timestamp [s]":"1486373924","temperature [C]":"20"}
> and try to get the value of "Epoch timestamp [s]" with $.['Epoch timestamp 
> [s]'] this will result in an empty result with version 2.0.0 which is 
> currently, but with version 2.4.0 you get the right value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-5169) Upgrade to JsonPath 2.4.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488056#comment-16488056
 ] 

ASF GitHub Bot commented on NIFI-5169:
--

Github user joewitt commented on the issue:

https://github.com/apache/nifi/pull/2705
  
+1 merged to master


> Upgrade to JsonPath 2.4.0
> -
>
> Key: NIFI-5169
> URL: https://issues.apache.org/jira/browse/NIFI-5169
> Project: Apache NiFi
>  Issue Type: Task
>Affects Versions: 1.6.0
>Reporter: Dennis Dahlmann
>Assignee: Mike Thomsen
>Priority: Major
>  Labels: JSON
> Fix For: 1.7.0
>
>
> A newer version (2.4.0) of JsonPath is availabel at  
> [github|[https://github.com/json-path/JsonPath].]
> With this version a currently existing bug is fixed, take this JSON
> {"Epoch timestamp [s]":"1486373924","temperature [C]":"20"}
> and try to get the value of "Epoch timestamp [s]" with $.['Epoch timestamp 
> [s]'] this will result in an empty result with version 2.0.0 which is 
> currently, but with version 2.4.0 you get the right value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-5169) Upgrade to JsonPath 2.4.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487246#comment-16487246
 ] 

ASF GitHub Bot commented on NIFI-5169:
--

Github user MikeThomsen commented on the issue:

https://github.com/apache/nifi/pull/2705
  
@mattyb149 @ottobackwards did a review on this one and approved (but isn't 
a committer). His judgment is usually spot on if you want to sign off.


> Upgrade to JsonPath 2.4.0
> -
>
> Key: NIFI-5169
> URL: https://issues.apache.org/jira/browse/NIFI-5169
> Project: Apache NiFi
>  Issue Type: Task
>Affects Versions: 1.6.0
>Reporter: Dennis Dahlmann
>Assignee: Mike Thomsen
>Priority: Major
>  Labels: JSON
> Fix For: 1.7.0
>
>
> A newer version (2.4.0) of JsonPath is availabel at  
> [github|[https://github.com/json-path/JsonPath].]
> With this version a currently existing bug is fixed, take this JSON
> {"Epoch timestamp [s]":"1486373924","temperature [C]":"20"}
> and try to get the value of "Epoch timestamp [s]" with $.['Epoch timestamp 
> [s]'] this will result in an empty result with version 2.0.0 which is 
> currently, but with version 2.4.0 you get the right value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-5169) Upgrade to JsonPath 2.4.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487169#comment-16487169
 ] 

ASF GitHub Bot commented on NIFI-5169:
--

Github user MikeThomsen commented on the issue:

https://github.com/apache/nifi/pull/2705
  
@joewitt @ottobackwards gave it a +1 and travis likes it. Can you merge?


> Upgrade to JsonPath 2.4.0
> -
>
> Key: NIFI-5169
> URL: https://issues.apache.org/jira/browse/NIFI-5169
> Project: Apache NiFi
>  Issue Type: Task
>Affects Versions: 1.6.0
>Reporter: Dennis Dahlmann
>Assignee: Mike Thomsen
>Priority: Major
>  Labels: JSON
> Fix For: 1.7.0
>
>
> A newer version (2.4.0) of JsonPath is availabel at  
> [github|[https://github.com/json-path/JsonPath].]
> With this version a currently existing bug is fixed, take this JSON
> {"Epoch timestamp [s]":"1486373924","temperature [C]":"20"}
> and try to get the value of "Epoch timestamp [s]" with $.['Epoch timestamp 
> [s]'] this will result in an empty result with version 2.0.0 which is 
> currently, but with version 2.4.0 you get the right value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-5169) Upgrade to JsonPath 2.4.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476333#comment-16476333
 ] 

ASF GitHub Bot commented on NIFI-5169:
--

Github user ottobackwards commented on the issue:

https://github.com/apache/nifi/pull/2705
  
LGTM, +1  FWIW


> Upgrade to JsonPath 2.4.0
> -
>
> Key: NIFI-5169
> URL: https://issues.apache.org/jira/browse/NIFI-5169
> Project: Apache NiFi
>  Issue Type: Task
>Affects Versions: 1.6.0
>Reporter: Dennis Dahlmann
>Assignee: Mike Thomsen
>Priority: Major
>  Labels: JSON
> Fix For: 1.7.0
>
>
> A newer version (2.4.0) of JsonPath is availabel at  
> [github|[https://github.com/json-path/JsonPath].]
> With this version a currently existing bug is fixed, take this JSON
> {"Epoch timestamp [s]":"1486373924","temperature [C]":"20"}
> and try to get the value of "Epoch timestamp [s]" with $.['Epoch timestamp 
> [s]'] this will result in an empty result with version 2.0.0 which is 
> currently, but with version 2.4.0 you get the right value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-5169) Upgrade to JsonPath 2.4.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476324#comment-16476324
 ] 

ASF GitHub Bot commented on NIFI-5169:
--

Github user MikeThomsen commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2705#discussion_r188393536
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractJsonPathProcessor.java
 ---
@@ -112,10 +111,10 @@ static String getResultRepresentation(Object 
jsonPathResult, String defaultValue
 public ValidationResult validate(final String subject, final 
String input, final ValidationContext context) {
 String error = null;
 if (isStale(subject, input)) {
-if (JsonPathExpressionValidator.isValidExpression(input)) {
+try {
 JsonPath compiledJsonPath = JsonPath.compile(input);
 cacheComputedValue(subject, input, compiledJsonPath);
--- End diff --

I should have a `isBlank` check there, so good catch.


> Upgrade to JsonPath 2.4.0
> -
>
> Key: NIFI-5169
> URL: https://issues.apache.org/jira/browse/NIFI-5169
> Project: Apache NiFi
>  Issue Type: Task
>Affects Versions: 1.6.0
>Reporter: Dennis Dahlmann
>Assignee: Mike Thomsen
>Priority: Major
>  Labels: JSON
> Fix For: 1.7.0
>
>
> A newer version (2.4.0) of JsonPath is availabel at  
> [github|[https://github.com/json-path/JsonPath].]
> With this version a currently existing bug is fixed, take this JSON
> {"Epoch timestamp [s]":"1486373924","temperature [C]":"20"}
> and try to get the value of "Epoch timestamp [s]" with $.['Epoch timestamp 
> [s]'] this will result in an empty result with version 2.0.0 which is 
> currently, but with version 2.4.0 you get the right value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-5169) Upgrade to JsonPath 2.4.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475810#comment-16475810
 ] 

ASF GitHub Bot commented on NIFI-5169:
--

Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2705#discussion_r188281072
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractJsonPathProcessor.java
 ---
@@ -112,10 +111,10 @@ static String getResultRepresentation(Object 
jsonPathResult, String defaultValue
 public ValidationResult validate(final String subject, final 
String input, final ValidationContext context) {
 String error = null;
 if (isStale(subject, input)) {
-if (JsonPathExpressionValidator.isValidExpression(input)) {
+try {
 JsonPath compiledJsonPath = JsonPath.compile(input);
 cacheComputedValue(subject, input, compiledJsonPath);
--- End diff --

This throws an IllegalArgumentException if the input is null, and an 
InvalidPathException if the compile is wrong.  Maybe we should catch the 
explicit exception?  This is a nit I know.


> Upgrade to JsonPath 2.4.0
> -
>
> Key: NIFI-5169
> URL: https://issues.apache.org/jira/browse/NIFI-5169
> Project: Apache NiFi
>  Issue Type: Task
>Affects Versions: 1.6.0
>Reporter: Dennis Dahlmann
>Assignee: Mike Thomsen
>Priority: Major
>  Labels: JSON
> Fix For: 1.7.0
>
>
> A newer version (2.4.0) of JsonPath is availabel at  
> [github|[https://github.com/json-path/JsonPath].]
> With this version a currently existing bug is fixed, take this JSON
> {"Epoch timestamp [s]":"1486373924","temperature [C]":"20"}
> and try to get the value of "Epoch timestamp [s]" with $.['Epoch timestamp 
> [s]'] this will result in an empty result with version 2.0.0 which is 
> currently, but with version 2.4.0 you get the right value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-5169) Upgrade to JsonPath 2.4.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475768#comment-16475768
 ] 

ASF GitHub Bot commented on NIFI-5169:
--

GitHub user MikeThomsen opened a pull request:

https://github.com/apache/nifi/pull/2705

NIFI-5169 Upgrade to JSONPath 2.4

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MikeThomsen/nifi NIFI-5169

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2705.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2705


commit fae557a2273c440b7c59483a2dfb2f0c062821b7
Author: Mike Thomsen 
Date:   2018-05-15T09:49:45Z

NIFI-5169 Upgrade to JSONPath 2.4




> Upgrade to JsonPath 2.4.0
> -
>
> Key: NIFI-5169
> URL: https://issues.apache.org/jira/browse/NIFI-5169
> Project: Apache NiFi
>  Issue Type: Task
>Affects Versions: 1.6.0
>Reporter: Dennis Dahlmann
>Assignee: Mike Thomsen
>Priority: Major
>  Labels: JSON
> Fix For: 1.7.0
>
>
> A newer version (2.4.0) of JsonPath is availabel at  
> [github|[https://github.com/json-path/JsonPath].]
> With this version a currently existing bug is fixed, take this JSON
> {"Epoch timestamp [s]":"1486373924","temperature [C]":"20"}
> and try to get the value of "Epoch timestamp [s]" with $.['Epoch timestamp 
> [s]'] this will result in an empty result with version 2.0.0 which is 
> currently, but with version 2.4.0 you get the right value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)