[jira] [Commented] (NIFI-5665) Upgrade io.netty dependencies
[ https://issues.apache.org/jira/browse/NIFI-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648390#comment-16648390 ] ASF GitHub Bot commented on NIFI-5665: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/3067 > Upgrade io.netty dependencies > - > > Key: NIFI-5665 > URL: https://issues.apache.org/jira/browse/NIFI-5665 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.7.0 >Reporter: Nathan Gough >Assignee: Nathan Gough >Priority: Major > Fix For: 1.8.0 > > > The io.netty dependencies are a few years old, and should be upgraded for the > latest features and bug fixes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5665) Upgrade io.netty dependencies
[ https://issues.apache.org/jira/browse/NIFI-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648389#comment-16648389 ] ASF GitHub Bot commented on NIFI-5665: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/3067 Thanks @thenatog! This has been merged to master. > Upgrade io.netty dependencies > - > > Key: NIFI-5665 > URL: https://issues.apache.org/jira/browse/NIFI-5665 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.7.0 >Reporter: Nathan Gough >Assignee: Nathan Gough >Priority: Major > Fix For: 1.8.0 > > > The io.netty dependencies are a few years old, and should be upgraded for the > latest features and bug fixes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5665) Upgrade io.netty dependencies
[ https://issues.apache.org/jira/browse/NIFI-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648387#comment-16648387 ] ASF subversion and git services commented on NIFI-5665: --- Commit 5eb5e96b1621d87bf8cca96d18a2c36177a1f54e in nifi's branch refs/heads/master from thenatog [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=5eb5e96 ] NIFI-5665 - Changed netty versions to more closely match the original netty dependency version. NIFI-5665 - Fixed version for nifi-spark-bundle. NIFI-5665 - Fixing copy and paste error. This closes #3067 > Upgrade io.netty dependencies > - > > Key: NIFI-5665 > URL: https://issues.apache.org/jira/browse/NIFI-5665 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.7.0 >Reporter: Nathan Gough >Assignee: Nathan Gough >Priority: Major > Fix For: 1.8.0 > > > The io.netty dependencies are a few years old, and should be upgraded for the > latest features and bug fixes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5665) Upgrade io.netty dependencies
[ https://issues.apache.org/jira/browse/NIFI-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648384#comment-16648384 ] ASF subversion and git services commented on NIFI-5665: --- Commit 5eb5e96b1621d87bf8cca96d18a2c36177a1f54e in nifi's branch refs/heads/master from thenatog [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=5eb5e96 ] NIFI-5665 - Changed netty versions to more closely match the original netty dependency version. NIFI-5665 - Fixed version for nifi-spark-bundle. NIFI-5665 - Fixing copy and paste error. This closes #3067 > Upgrade io.netty dependencies > - > > Key: NIFI-5665 > URL: https://issues.apache.org/jira/browse/NIFI-5665 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.7.0 >Reporter: Nathan Gough >Assignee: Nathan Gough >Priority: Major > Fix For: 1.8.0 > > > The io.netty dependencies are a few years old, and should be upgraded for the > latest features and bug fixes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5665) Upgrade io.netty dependencies
[ https://issues.apache.org/jira/browse/NIFI-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648386#comment-16648386 ] ASF subversion and git services commented on NIFI-5665: --- Commit 5eb5e96b1621d87bf8cca96d18a2c36177a1f54e in nifi's branch refs/heads/master from thenatog [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=5eb5e96 ] NIFI-5665 - Changed netty versions to more closely match the original netty dependency version. NIFI-5665 - Fixed version for nifi-spark-bundle. NIFI-5665 - Fixing copy and paste error. This closes #3067 > Upgrade io.netty dependencies > - > > Key: NIFI-5665 > URL: https://issues.apache.org/jira/browse/NIFI-5665 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.7.0 >Reporter: Nathan Gough >Assignee: Nathan Gough >Priority: Major > Fix For: 1.8.0 > > > The io.netty dependencies are a few years old, and should be upgraded for the > latest features and bug fixes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5665) Upgrade io.netty dependencies
[ https://issues.apache.org/jira/browse/NIFI-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648015#comment-16648015 ] ASF GitHub Bot commented on NIFI-5665: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/3067 Will review... > Upgrade io.netty dependencies > - > > Key: NIFI-5665 > URL: https://issues.apache.org/jira/browse/NIFI-5665 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.7.0 >Reporter: Nathan Gough >Assignee: Nathan Gough >Priority: Major > Fix For: 1.8.0 > > > The io.netty dependencies are a few years old, and should be upgraded for the > latest features and bug fixes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5665) Upgrade io.netty dependencies
[ https://issues.apache.org/jira/browse/NIFI-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648014#comment-16648014 ] Matt Gilman commented on NIFI-5665: --- I should be able to help review this. > Upgrade io.netty dependencies > - > > Key: NIFI-5665 > URL: https://issues.apache.org/jira/browse/NIFI-5665 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.7.0 >Reporter: Nathan Gough >Assignee: Nathan Gough >Priority: Major > Fix For: 1.8.0 > > > The io.netty dependencies are a few years old, and should be upgraded for the > latest features and bug fixes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5665) Upgrade io.netty dependencies
[ https://issues.apache.org/jira/browse/NIFI-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648001#comment-16648001 ] Joseph Witt commented on NIFI-5665: --- is there anyone available that can review this? Trying to help Jeff get a clear path to a 1.8.0 > Upgrade io.netty dependencies > - > > Key: NIFI-5665 > URL: https://issues.apache.org/jira/browse/NIFI-5665 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.7.0 >Reporter: Nathan Gough >Assignee: Nathan Gough >Priority: Major > Fix For: 1.8.0 > > > The io.netty dependencies are a few years old, and should be upgraded for the > latest features and bug fixes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5665) Upgrade io.netty dependencies
[ https://issues.apache.org/jira/browse/NIFI-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647973#comment-16647973 ] ASF GitHub Bot commented on NIFI-5665: -- GitHub user thenatog opened a pull request: https://github.com/apache/nifi/pull/3067 NIFI-5665 - Setting zookeeper's io.netty:netty transitive dependency … …version to 3.10.6.Final. NIFI-5665 - Setting all transitive io.netty dependencies to 3.10.6.Final. NIFI-5665 - Added comments. NIFI-5665 - Missed zookeeper in some spots. NIFI-5665 - Reverted Flume version. The netty version contained was not listed explicitly as vulnerable. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/thenatog/nifi NIFI-5665-rebased2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/3067.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3067 commit fbfeb695d610c02a36f207396e2d5cd0f07ec477 Author: thenatog Date: 2018-10-08T16:58:20Z NIFI-5665 - Setting zookeeper's io.netty:netty transitive dependency version to 3.10.6.Final. NIFI-5665 - Setting all transitive io.netty dependencies to 3.10.6.Final. NIFI-5665 - Added comments. NIFI-5665 - Missed zookeeper in some spots. NIFI-5665 - Reverted Flume version. The netty version contained was not listed explicitly as vulnerable. > Upgrade io.netty dependencies > - > > Key: NIFI-5665 > URL: https://issues.apache.org/jira/browse/NIFI-5665 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.7.0 >Reporter: Nathan Gough >Assignee: Nathan Gough >Priority: Major > Fix For: 1.8.0 > > > The io.netty dependencies are a few years old, and should be upgraded for the > latest features and bug fixes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
