[jira] [Commented] (NIFI-5686) Test failure in TestStandardProcessScheduler
[
https://issues.apache.org/jira/browse/NIFI-5686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650655#comment-16650655
]
ASF subversion and git services commented on NIFI-5686:
---
Commit 32db43b3069b3c982b9c96576c11b447c229b360 in nifi's branch
refs/heads/master from [~markap14]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=32db43b ]
NIFI-5686: Updated StandardProcessScheduler so that if it fails to schedule a
Reporting Task, it re-schedules the @OnScheduled task instead of looping and
calling Thread.sleep. As it was, the single-threaded Process Scheduler was,
when calling ProcessScheduler.unschedule(), the unschedule task was not
executing because the schedule task was using the only thread. But switching
the logic to schedule the task for later and return, instead of calling
Thread.sleep and looping, we are able to avoid blocking the one thread in the
thread pool. Also, performed some trivial code cleanup and updated erroneous
links in Java-docs.
NIFI-5686: Fixed unit test in TestSocketLoadBalancedFlowFileQueue; renamed
TestProcessorLifecycle to ProcessorLifecycleIT as it is testing integration
between many components and largely focuses on high numbers of concurrent tasks
to see if it can trigger any threading bugs that may get introduced
NIFI-5686: Extended unit test timeouts
Signed-off-by: Matthew Burgess
This closes #3062
> Test failure in TestStandardProcessScheduler
>
>
> Key: NIFI-5686
> URL: https://issues.apache.org/jira/browse/NIFI-5686
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Major
> Fix For: 1.8.0
>
>
> The {{testReportingTaskDoesntKeepRunningAfterStop}} test in
> {{TestStandardProcessScheduler}} now fails. This was \{{@Ignore}} d in
> NIFI-5666 but should be addressed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5686) Test failure in TestStandardProcessScheduler
[
https://issues.apache.org/jira/browse/NIFI-5686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650657#comment-16650657
]
ASF subversion and git services commented on NIFI-5686:
---
Commit 32db43b3069b3c982b9c96576c11b447c229b360 in nifi's branch
refs/heads/master from [~markap14]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=32db43b ]
NIFI-5686: Updated StandardProcessScheduler so that if it fails to schedule a
Reporting Task, it re-schedules the @OnScheduled task instead of looping and
calling Thread.sleep. As it was, the single-threaded Process Scheduler was,
when calling ProcessScheduler.unschedule(), the unschedule task was not
executing because the schedule task was using the only thread. But switching
the logic to schedule the task for later and return, instead of calling
Thread.sleep and looping, we are able to avoid blocking the one thread in the
thread pool. Also, performed some trivial code cleanup and updated erroneous
links in Java-docs.
NIFI-5686: Fixed unit test in TestSocketLoadBalancedFlowFileQueue; renamed
TestProcessorLifecycle to ProcessorLifecycleIT as it is testing integration
between many components and largely focuses on high numbers of concurrent tasks
to see if it can trigger any threading bugs that may get introduced
NIFI-5686: Extended unit test timeouts
Signed-off-by: Matthew Burgess
This closes #3062
> Test failure in TestStandardProcessScheduler
>
>
> Key: NIFI-5686
> URL: https://issues.apache.org/jira/browse/NIFI-5686
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Major
> Fix For: 1.8.0
>
>
> The {{testReportingTaskDoesntKeepRunningAfterStop}} test in
> {{TestStandardProcessScheduler}} now fails. This was \{{@Ignore}} d in
> NIFI-5666 but should be addressed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5686) Test failure in TestStandardProcessScheduler
[
https://issues.apache.org/jira/browse/NIFI-5686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650654#comment-16650654
]
ASF GitHub Bot commented on NIFI-5686:
--
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/3062
+1 LGTM, ran full build with unit tests, tried on a live instance with
reporting tasks and various other flows. Thanks for the improvement! Merging to
master
> Test failure in TestStandardProcessScheduler
>
>
> Key: NIFI-5686
> URL: https://issues.apache.org/jira/browse/NIFI-5686
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Major
> Fix For: 1.8.0
>
>
> The {{testReportingTaskDoesntKeepRunningAfterStop}} test in
> {{TestStandardProcessScheduler}} now fails. This was \{{@Ignore}} d in
> NIFI-5666 but should be addressed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5686) Test failure in TestStandardProcessScheduler
[
https://issues.apache.org/jira/browse/NIFI-5686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650658#comment-16650658
]
ASF GitHub Bot commented on NIFI-5686:
--
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/3062
> Test failure in TestStandardProcessScheduler
>
>
> Key: NIFI-5686
> URL: https://issues.apache.org/jira/browse/NIFI-5686
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Major
> Fix For: 1.8.0
>
>
> The {{testReportingTaskDoesntKeepRunningAfterStop}} test in
> {{TestStandardProcessScheduler}} now fails. This was \{{@Ignore}} d in
> NIFI-5666 but should be addressed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5686) Test failure in TestStandardProcessScheduler
[
https://issues.apache.org/jira/browse/NIFI-5686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650656#comment-16650656
]
ASF subversion and git services commented on NIFI-5686:
---
Commit 32db43b3069b3c982b9c96576c11b447c229b360 in nifi's branch
refs/heads/master from [~markap14]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=32db43b ]
NIFI-5686: Updated StandardProcessScheduler so that if it fails to schedule a
Reporting Task, it re-schedules the @OnScheduled task instead of looping and
calling Thread.sleep. As it was, the single-threaded Process Scheduler was,
when calling ProcessScheduler.unschedule(), the unschedule task was not
executing because the schedule task was using the only thread. But switching
the logic to schedule the task for later and return, instead of calling
Thread.sleep and looping, we are able to avoid blocking the one thread in the
thread pool. Also, performed some trivial code cleanup and updated erroneous
links in Java-docs.
NIFI-5686: Fixed unit test in TestSocketLoadBalancedFlowFileQueue; renamed
TestProcessorLifecycle to ProcessorLifecycleIT as it is testing integration
between many components and largely focuses on high numbers of concurrent tasks
to see if it can trigger any threading bugs that may get introduced
NIFI-5686: Extended unit test timeouts
Signed-off-by: Matthew Burgess
This closes #3062
> Test failure in TestStandardProcessScheduler
>
>
> Key: NIFI-5686
> URL: https://issues.apache.org/jira/browse/NIFI-5686
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Major
> Fix For: 1.8.0
>
>
> The {{testReportingTaskDoesntKeepRunningAfterStop}} test in
> {{TestStandardProcessScheduler}} now fails. This was \{{@Ignore}} d in
> NIFI-5666 but should be addressed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5686) Test failure in TestStandardProcessScheduler
[
https://issues.apache.org/jira/browse/NIFI-5686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648253#comment-16648253
]
ASF GitHub Bot commented on NIFI-5686:
--
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/3062
@joewitt thanks, I've pushed another commit.
> Test failure in TestStandardProcessScheduler
>
>
> Key: NIFI-5686
> URL: https://issues.apache.org/jira/browse/NIFI-5686
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Major
> Fix For: 1.8.0
>
>
> The {{testReportingTaskDoesntKeepRunningAfterStop}} test in
> {{TestStandardProcessScheduler}} now fails. This was \{{@Ignore}} d in
> NIFI-5666 but should be addressed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5686) Test failure in TestStandardProcessScheduler
[
https://issues.apache.org/jira/browse/NIFI-5686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648006#comment-16648006
]
ASF GitHub Bot commented on NIFI-5686:
--
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/3062
@markap14 at least one relevant to this change test appears brittle and
possible another...
[ERROR] Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
10.413 s <<< FAILURE! - in
org.apache.nifi.controller.queue.clustered.TestSocketLoadBalancedFlowFileQueue
[ERROR]
testChangeInClusterTopologyTriggersRebalanceOnlyOnRemovedNodeIfNecessary(org.apache.nifi.controller.queue.clustered.TestSocketLoadBalancedFlowFileQueue)
Time elapsed: 10.008 s <<< ERROR!
org.junit.runners.model.TestTimedOutException: test timed out after 1
milliseconds
at
org.apache.nifi.controller.queue.clustered.TestSocketLoadBalancedFlowFileQueue.testChangeInClusterTopologyTriggersRebalanceOnlyOnRemovedNodeIfNecessary(TestSocketLoadBalancedFlowFileQueue.java:363)
[ERROR] Tests run: 15, Failures: 1, Errors: 0, Skipped: 2, Time elapsed:
37.795 s <<< FAILURE! - in
org.apache.nifi.controller.scheduling.TestProcessorLifecycle
[ERROR]
validateProcessorCanBeStoppedWhenOnTriggerThrowsException(org.apache.nifi.controller.scheduling.TestProcessorLifecycle)
Time elapsed: 21.061 s <<< FAILURE!
java.lang.AssertionError
at
org.apache.nifi.controller.scheduling.TestProcessorLifecycle.assertCondition(TestProcessorLifecycle.java:120)
at
org.apache.nifi.controller.scheduling.TestProcessorLifecycle.validateProcessorCanBeStoppedWhenOnTriggerThrowsException(TestProcessorLifecycle.java:498)
> Test failure in TestStandardProcessScheduler
>
>
> Key: NIFI-5686
> URL: https://issues.apache.org/jira/browse/NIFI-5686
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Major
> Fix For: 1.8.0
>
>
> The {{testReportingTaskDoesntKeepRunningAfterStop}} test in
> {{TestStandardProcessScheduler}} now fails. This was \{{@Ignore}} d in
> NIFI-5666 but should be addressed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-5686) Test failure in TestStandardProcessScheduler
[
https://issues.apache.org/jira/browse/NIFI-5686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646649#comment-16646649
]
ASF GitHub Bot commented on NIFI-5686:
--
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/3062
NIFI-5686: Updated StandardProcessScheduler so that if it fails to sc…
…hedule a Reporting Task, it re-schedules the @OnScheduled task instead of
looping and calling Thread.sleep. As it was, the single-threaded Process
Scheduler was, when calling ProcessScheduler.unschedule(), the unschedule task
was not executing because the schedule task was using the only thread. But
switching the logic to schedule the task for later and return, instead of
calling Thread.sleep and looping, we are able to avoid blocking the one thread
in the thread pool. Also, performed some trivial code cleanup and updated
erroneous links in Java-docs.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI- where is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-5686
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3062.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3062
commit c14092db13cdc2a26da451b61c6d6c8d4903fd1a
Author: Mark Payne
Date: 2018-10-11T15:45:41Z
NIFI-5686: Updated StandardProcessScheduler so that if it fails to schedule
a Reporting Task, it re-schedules the @OnScheduled task instead of looping and
calling Thread.sleep. As it was, the single-threaded Process Scheduler was,
when calling ProcessScheduler.unschedule(), the unschedule task was not
executing because the schedule task was using the only thread. But switching
the logic to schedule the task for later and return, instead of calling
Thread.sleep and looping, we are able to avoid blocking the one thread in the
thread pool. Also, performed some trivial code cleanup and updated erroneous
links in Java-docs.
> Test failure in TestStandardProcessScheduler
>
>
> Key: NIFI-5686
> URL: https://issues.apache.org/jira/browse/NIFI-5686
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Major
> Fix For: 1.8.0
>
>
> The {{testReportingTaskDoesntKeepRunningAfterStop}} test in
> {{TestStandardProcessScheduler}} now fails. This was {{@Ignore}}d in
> NIFI-5666 but should be addressed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
