[jira] [Commented] (NIFI-6490) MergeRecord properties MIN_RECORDS and MAX_RECORDS should accept variable registry expression language

2019-07-31 Thread Alessandro D'Armiento (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896898#comment-16896898
 ] 

Alessandro D'Armiento commented on NIFI-6490:
-

[~ijokarumawak] Thank you very much! I'm glad this was helpful!

> MergeRecord properties MIN_RECORDS and MAX_RECORDS should accept variable 
> registry expression language
> --
>
> Key: NIFI-6490
> URL: https://issues.apache.org/jira/browse/NIFI-6490
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.9.2
>Reporter: Alessandro D'Armiento
>Assignee: Alessandro D'Armiento
>Priority: Minor
> Fix For: 1.10.0
>
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> h2. Current Situation
> MergeRecords allows two attributes MIN_RECORDS and MAX_RECORDS to define how 
> many records a merged bin can contain. 
> These properties, however, do not support expression language and cannot be 
> inserted from variables.
> h2. Improvement Proposal
> Accept variable registry in these properties



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (NIFI-6490) MergeRecord properties MIN_RECORDS and MAX_RECORDS should accept variable registry expression language

2019-07-31 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896860#comment-16896860
 ] 

ASF subversion and git services commented on NIFI-6490:
---

Commit 1d22e8a86d001540bb86d017a9139393778628cb in nifi's branch 
refs/heads/master from Alessandro D'Armiento
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=1d22e8a ]

NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS

Unified unit tests

Added custom validation cases for MIN_RECORDS and MAX_RECORDS enforcing they 
are greater than zero.
While MIN_RECORDS > 0 can fail individually, MAX_RECORDS > 0 validator cannot 
fail without having also at least another validation step (either the 
MIN_RECORDS > 0 or the MAX_RECORDS > MIN_RECORDS) to fail, since MIN_RECORDS is 
a required property with default value 1

This closes #3607.

Signed-off-by: Koji Kawamura 


> MergeRecord properties MIN_RECORDS and MAX_RECORDS should accept variable 
> registry expression language
> --
>
> Key: NIFI-6490
> URL: https://issues.apache.org/jira/browse/NIFI-6490
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.9.2
>Reporter: Alessandro D'Armiento
>Priority: Minor
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> h2. Current Situation
> MergeRecords allows two attributes MIN_RECORDS and MAX_RECORDS to define how 
> many records a merged bin can contain. 
> These properties, however, do not support expression language and cannot be 
> inserted from variables.
> h2. Improvement Proposal
> Accept variable registry in these properties



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)