Re: [PR] MINIFICPP-2274 Ship Markdown docs in binary packages [nifi-minifi-cpp]

[via GitHub]

arpadboda closed pull request #1709: MINIFICPP-2274 Ship Markdown docs in 
binary packages
URL: https://github.com/apache/nifi-minifi-cpp/pull/1709


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINIFICPP-2274 Ship Markdown docs in binary packages [nifi-minifi-cpp]

[via GitHub]

szaszm commented on code in PR #1709:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1709#discussion_r1426440875


##
CMakeLists.txt:
##
@@ -422,8 +422,12 @@ if(WIN32)
 
 file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/conf/" DESTINATION 
"${CMAKE_CURRENT_BINARY_DIR}/conf/")
 file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/LICENSE" DESTINATION 
"${CMAKE_CURRENT_BINARY_DIR}")
-file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/README.md" DESTINATION 
"${CMAKE_CURRENT_BINARY_DIR}")
+#file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/README.md" DESTINATION 
"${CMAKE_CURRENT_BINARY_DIR}")

Review Comment:
   removed the line in 
[13090d3](https://github.com/apache/nifi-minifi-cpp/pull/1709/commits/13090d370c39c1713add87d037cb388b3d8b4307)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINIFICPP-2274 Ship Markdown docs in binary packages [nifi-minifi-cpp]

[via GitHub]

szaszm commented on code in PR #1709:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1709#discussion_r1426258158


##
CMakeLists.txt:
##
@@ -422,8 +422,12 @@ if(WIN32)
 
 file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/conf/" DESTINATION 
"${CMAKE_CURRENT_BINARY_DIR}/conf/")
 file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/LICENSE" DESTINATION 
"${CMAKE_CURRENT_BINARY_DIR}")
-file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/README.md" DESTINATION 
"${CMAKE_CURRENT_BINARY_DIR}")
+#file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/README.md" DESTINATION 
"${CMAKE_CURRENT_BINARY_DIR}")

Review Comment:
   I guess the thinking behind this was that if this is ever changed, the 
README needs special handling. But I can certainly just remove the line, I 
don't really have a strong argument against it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINIFICPP-2274 Ship Markdown docs in binary packages [nifi-minifi-cpp]

[via GitHub]

martinzink commented on code in PR #1709:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1709#discussion_r1425873524


##
CMakeLists.txt:
##
@@ -422,8 +422,12 @@ if(WIN32)
 
 file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/conf/" DESTINATION 
"${CMAKE_CURRENT_BINARY_DIR}/conf/")
 file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/LICENSE" DESTINATION 
"${CMAKE_CURRENT_BINARY_DIR}")
-file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/README.md" DESTINATION 
"${CMAKE_CURRENT_BINARY_DIR}")
+#file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/README.md" DESTINATION 
"${CMAKE_CURRENT_BINARY_DIR}")

Review Comment:
   Why the comment, should we just remove this line?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org