Re: [PR] NIFI-12271: Fix PutAzureBlobStorage - FileResourceService - FileNotFo… [nifi]

[via GitHub]

exceptionfactory closed pull request #7930: NIFI-12271: Fix PutAzureBlobStorage 
- FileResourceService - FileNotFo…
URL: https://github.com/apache/nifi/pull/7930


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] NIFI-12271: Fix PutAzureBlobStorage - FileResourceService - FileNotFo… [nifi]

[via GitHub]

Lehel44 commented on code in PR #7930:
URL: https://github.com/apache/nifi/pull/7930#discussion_r1373349767


##
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureBlobStorage_v12.java:
##
@@ -231,6 +231,7 @@ public void onTrigger(final ProcessContext context, final 
ProcessSession session
 getLogger().error("Failed to create blob on Azure Blob Storage", 
e);
 flowFile = session.penalize(flowFile);
 session.transfer(flowFile, REL_FAILURE);
+session.getProvenanceReporter().send(flowFile, "/error/" + 
blobName);

Review Comment:
   That was something I forgot to remove. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] NIFI-12271: Fix PutAzureBlobStorage - FileResourceService - FileNotFo… [nifi]

[via GitHub]

exceptionfactory commented on code in PR #7930:
URL: https://github.com/apache/nifi/pull/7930#discussion_r1371904153


##
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureBlobStorage_v12.java:
##
@@ -231,6 +231,7 @@ public void onTrigger(final ProcessContext context, final 
ProcessSession session
 getLogger().error("Failed to create blob on Azure Blob Storage", 
e);
 flowFile = session.penalize(flowFile);
 session.transfer(flowFile, REL_FAILURE);
+session.getProvenanceReporter().send(flowFile, "/error/" + 
blobName);

Review Comment:
   The general purpose of provenance event reporting is to track successful 
operations as opposed to errors, so creating this event does not seem like the 
right approach. Is there a particular reason for this addition?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org