Re: [PR] NIFI-13323 Removed the instantiation of Object arrays for arguments in ComponentLog log in the HashAttribute and PostHttp Processors. [nifi]
exceptionfactory commented on PR #8903:
URL: https://github.com/apache/nifi/pull/8903#issuecomment-2145580852
> @exceptionfactory In `PutElasticsearchHttp` on line 252 `logger.error("No
value for index in for {}, transferring to failure", id_attribute, file);`
there is only one parameter (`{}`) specified in the logging statement yet there
are two parameter arguments ( `id_attribute, file`) given.
>
> should the log statement be `logger.error("No value for index in {} for
{}, transferring to failure", id_attribute, file);` ?
@dan-s1 On further consideration, I'm not sure it is worth back-porting this
change. Especially for this type of syntax change, there is very little value
in bringing it over, given the current focus on getting 2.0 finalized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13323 Removed the instantiation of Object arrays for arguments in ComponentLog log in the HashAttribute and PostHttp Processors. [nifi]
dan-s1 commented on PR #8903:
URL: https://github.com/apache/nifi/pull/8903#issuecomment-2145550691
@exceptionfactory In `PutElasticsearchHttp` on line 252
`logger.error("No value for index in for {}, transferring to failure",
id_attribute, file);`
there is only one parameter (`{}`) specified in the logging statement yet
there are two parameter arguments ( `id_attribute, file`) given. Can you please
advise where does the other parameter in the logging statement go? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13323 Removed the instantiation of Object arrays for arguments in ComponentLog log in the HashAttribute and PostHttp Processors. [nifi]
exceptionfactory commented on PR #8903: URL: https://github.com/apache/nifi/pull/8903#issuecomment-2145386908 > @exceptionfactory I just thought a review of ~300 files may be too big for one review. I see, thanks for the consideration. It is large, but we have had larger, and for something like this, it seems acceptable to bundle the changes together. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13323 Removed the instantiation of Object arrays for arguments in ComponentLog log in the HashAttribute and PostHttp Processors. [nifi]
dan-s1 commented on PR #8903: URL: https://github.com/apache/nifi/pull/8903#issuecomment-2145375919 @exceptionfactory I just thought a review of ~300 files may be too big for one review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13323 Removed the instantiation of Object arrays for arguments in ComponentLog log in the HashAttribute and PostHttp Processors. [nifi]
exceptionfactory commented on PR #8903: URL: https://github.com/apache/nifi/pull/8903#issuecomment-2145350760 > @exceptionfactory I have made the changes to the 1.x branch to remove the instantiated Object arrays in log statements. I want to just make sure this PR is not to big as in addition to the two files already done I ended up changing 296 files (so in total this PR will be changes to 298 files). Please advise. @dan-s1, I'm not quite following the concern. If you have the changes required for the 1.x branch, I would go ahead and push them to this branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13323 Removed the instantiation of Object arrays for arguments in ComponentLog log in the HashAttribute and PostHttp Processors. [nifi]
dan-s1 commented on PR #8903: URL: https://github.com/apache/nifi/pull/8903#issuecomment-2142998036 @exceptionfactory I have made the changes to the 1.x branch to remove the instantiated Object arrays in log statements. I want to just make sure this PR is not to big as in addition to the two files already done I ended up changing 296 files (so in total this PR will be changes to 298 files). Please advise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13323 Removed the instantiation of Object arrays for arguments in ComponentLog log in the HashAttribute and PostHttp Processors. [nifi]
dan-s1 commented on PR #8903: URL: https://github.com/apache/nifi/pull/8903#issuecomment-2140944177 @exceptionfactory I wanted to restart the MacOS build as the failure seems unrelated to the code I changed but there is no icon for me on the right hand side of that build when I navigate to under checks that would allow me to restart it. Please advise. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
