[jira] [Commented] (OPENNLP-1567) OpenNLP Models: Provide a Finder / Loader Implementation
[ https://issues.apache.org/jira/browse/OPENNLP-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854154#comment-17854154 ] ASF GitHub Bot commented on OPENNLP-1567: - kinow commented on code in PR #606: URL: https://github.com/apache/opennlp/pull/606#discussion_r1635321056 ## LICENSE: ## @@ -303,3 +303,27 @@ The following license applies to the SLF4J API: LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. + +The following license applies to classgraph: + +The MIT License (MIT) + +Copyright (c) 2019 Luke Hutchison + +Permission is hereby granted, free of charge, to any person obtaining a copy +of this software and associated documentation files (the "Software"), to deal +in the Software without restriction, including without limitation the rights +to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +copies of the Software, and to permit persons to whom the Software is +furnished to do so, subject to the following conditions: + +The above copyright notice and this permission notice shall be included in all +copies or substantial portions of the Software. + +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE +SOFTWARE. Review Comment: I am not sure, but probably doesn't hurt having it listed in NOTICE. > OpenNLP Models: Provide a Finder / Loader Implementation > > > Key: OPENNLP-1567 > URL: https://issues.apache.org/jira/browse/OPENNLP-1567 > Project: OpenNLP > Issue Type: New Feature >Reporter: Richard Zowalla >Assignee: Richard Zowalla >Priority: Major > Fix For: 2.3.4, 2.4.0 > > > as the title says -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OPENNLP-1567) OpenNLP Models: Provide a Finder / Loader Implementation
[ https://issues.apache.org/jira/browse/OPENNLP-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854112#comment-17854112 ] ASF GitHub Bot commented on OPENNLP-1567: - kinow commented on code in PR #606: URL: https://github.com/apache/opennlp/pull/606#discussion_r1635163209 ## LICENSE: ## @@ -303,3 +303,27 @@ The following license applies to the SLF4J API: LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. + +The following license applies to classgraph: + +The MIT License (MIT) + +Copyright (c) 2019 Luke Hutchison + +Permission is hereby granted, free of charge, to any person obtaining a copy +of this software and associated documentation files (the "Software"), to deal +in the Software without restriction, including without limitation the rights +to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +copies of the Software, and to permit persons to whom the Software is +furnished to do so, subject to the following conditions: + +The above copyright notice and this permission notice shall be included in all +copies or substantial portions of the Software. + +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE +SOFTWARE. Review Comment: Isn't this change required only in NOTICE? > OpenNLP Models: Provide a Finder / Loader Implementation > > > Key: OPENNLP-1567 > URL: https://issues.apache.org/jira/browse/OPENNLP-1567 > Project: OpenNLP > Issue Type: New Feature >Reporter: Richard Zowalla >Assignee: Richard Zowalla >Priority: Major > Fix For: 2.3.4, 2.4.0 > > > as the title says -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OPENNLP-1567) OpenNLP Models: Provide a Finder / Loader Implementation
[ https://issues.apache.org/jira/browse/OPENNLP-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853993#comment-17853993 ] ASF GitHub Bot commented on OPENNLP-1567: - rzo1 opened a new pull request, #606: URL: https://github.com/apache/opennlp/pull/606 Thank you for contributing to Apache OpenNLP. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with OPENNLP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder? - [x] Have you written or updated unit tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder? - [x] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: This adds a proof-of-conept implementation as a separate module (due to the addtional dependendy for classpath scanning) to load models from JAR files. If we are fine with the design, we can do a first model release afterwards ;-) > OpenNLP Models: Provide a Finder / Loader Implementation > > > Key: OPENNLP-1567 > URL: https://issues.apache.org/jira/browse/OPENNLP-1567 > Project: OpenNLP > Issue Type: New Feature >Reporter: Richard Zowalla >Assignee: Richard Zowalla >Priority: Major > Fix For: 2.3.4, 2.4.0 > > > as the title says -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OPENNLP-1567) OpenNLP Models: Provide a Finder / Loader Implementation
Richard Zowalla created OPENNLP-1567: Summary: OpenNLP Models: Provide a Finder / Loader Implementation Key: OPENNLP-1567 URL: https://issues.apache.org/jira/browse/OPENNLP-1567 Project: OpenNLP Issue Type: New Feature Reporter: Richard Zowalla Assignee: Richard Zowalla Fix For: 2.3.4, 2.4.0 as the title says -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (OPENNLP-1557) OpenNLP Models: Create Model Jars on-the-fly
[ https://issues.apache.org/jira/browse/OPENNLP-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Richard Zowalla resolved OPENNLP-1557. -- Resolution: Fixed > OpenNLP Models: Create Model Jars on-the-fly > > > Key: OPENNLP-1557 > URL: https://issues.apache.org/jira/browse/OPENNLP-1557 > Project: OpenNLP > Issue Type: New Feature > Components: Models >Reporter: Richard Zowalla >Assignee: Richard Zowalla >Priority: Major > Fix For: 2.3.4, 2.4.0 > > > Aim of this issue is to distribute [Models Download - Apache > OpenNLP|https://opennlp.apache.org/models.html] via Maven artifacts. -- This message was sent by Atlassian Jira (v8.20.10#820010)
