[jira] [Commented] (OPENNLP-1568) opennlp command fails when invoked from outside $OPENNLP_HOME/bin directory
[
https://issues.apache.org/jira/browse/OPENNLP-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17862524#comment-17862524
]
ASF GitHub Bot commented on OPENNLP-1568:
-
rzo1 commented on code in PR #607:
URL: https://github.com/apache/opennlp/pull/607#discussion_r1661109712
##
opennlp-brat-annotator/src/main/bin/brat-annotation-service:
##
@@ -21,6 +21,28 @@
#may be inadvertantly placed in any output files if
#output redirection is used.
+# determine OPENNLP_HOME - $0 may be a symlink to OpenNLP's home
+PRG="$0"
+
+while [ -h "$PRG" ] ; do
+ ls=`ls -ld "$PRG"`
+ link=`expr "$ls" : '.*-> \(.*\)$'`
+ if expr "$link" : '/.*' > /dev/null; then
+PRG="$link"
+ else
+PRG="`dirname "$PRG"`/$link"
+ fi
+done
Review Comment:
Yep, specific to Linux.
> opennlp command fails when invoked from outside $OPENNLP_HOME/bin directory
> ---
>
> Key: OPENNLP-1568
> URL: https://issues.apache.org/jira/browse/OPENNLP-1568
> Project: OpenNLP
> Issue Type: Bug
> Components: Command Line Interface
>Affects Versions: 2.3.3
> Environment: Linux/Bash
>Reporter: Alexander Veit
>Priority: Major
> Fix For: 2.3.4
>
>
> Try to run the opennlp command from outside $OPENNLP_HOME/bin directory.
> It fails with an error message similar to
>
> {noformat}
> 2024-06-15T22:44:04.900344345Z main ERROR Reconfiguration failed:
> No configuration found for '4f2410ac' at 'null' in 'null'{noformat}
>
> The error is caused by the relative path in
> {code:java}
> -Dlog4j.configurationFile=../conf/log4j2.xml {code}
> of the opennlp script.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OPENNLP-1583) Reduce compiler warnings in opennlp-tools
[ https://issues.apache.org/jira/browse/OPENNLP-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17862518#comment-17862518 ] ASF GitHub Bot commented on OPENNLP-1583: - rzo1 merged PR #626: URL: https://github.com/apache/opennlp/pull/626 > Reduce compiler warnings in opennlp-tools > - > > Key: OPENNLP-1583 > URL: https://issues.apache.org/jira/browse/OPENNLP-1583 > Project: OpenNLP > Issue Type: Improvement >Affects Versions: 2.3.3 >Reporter: Martin Wiesner >Assignee: Martin Wiesner >Priority: Minor > Fix For: 2.3.4 > > > We still have a bunch of compiler warnings. Those should be reduced to and > kept at a minimum. > Aims: > - Get rid of most of them, as best as possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OPENNLP-1584) FeatureGeneratorUtil shall detect German umlauts with dot as 'cp'
[ https://issues.apache.org/jira/browse/OPENNLP-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17862521#comment-17862521 ] ASF GitHub Bot commented on OPENNLP-1584: - rzo1 merged PR #628: URL: https://github.com/apache/opennlp/pull/628 > FeatureGeneratorUtil shall detect German umlauts with dot as 'cp' > - > > Key: OPENNLP-1584 > URL: https://issues.apache.org/jira/browse/OPENNLP-1584 > Project: OpenNLP > Issue Type: Improvement > Components: Name Finder >Affects Versions: 2.3.3 >Reporter: Martin Wiesner >Assignee: Martin Wiesner >Priority: Minor > Fix For: 2.3.4 > > Original Estimate: 0.25h > Remaining Estimate: 0.25h > > German names, such as Änne, Özlem, or Ümit, should be recognized in their > abbreviated short form (Ä., Ü., Ö.) by the FeatureGeneratorUtil class. > Atm, recognition fails, as the Pattern "capPeriod" only takes regular, > capitalized letters into account. This can be fixed easily. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OPENNLP-1568) opennlp command fails when invoked from outside $OPENNLP_HOME/bin directory
[
https://issues.apache.org/jira/browse/OPENNLP-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17862520#comment-17862520
]
ASF GitHub Bot commented on OPENNLP-1568:
-
rzo1 merged PR #607:
URL: https://github.com/apache/opennlp/pull/607
> opennlp command fails when invoked from outside $OPENNLP_HOME/bin directory
> ---
>
> Key: OPENNLP-1568
> URL: https://issues.apache.org/jira/browse/OPENNLP-1568
> Project: OpenNLP
> Issue Type: Bug
> Components: Command Line Interface
>Affects Versions: 2.3.3
> Environment: Linux/Bash
>Reporter: Alexander Veit
>Priority: Major
> Fix For: 2.3.4
>
>
> Try to run the opennlp command from outside $OPENNLP_HOME/bin directory.
> It fails with an error message similar to
>
> {noformat}
> 2024-06-15T22:44:04.900344345Z main ERROR Reconfiguration failed:
> No configuration found for '4f2410ac' at 'null' in 'null'{noformat}
>
> The error is caused by the relative path in
> {code:java}
> -Dlog4j.configurationFile=../conf/log4j2.xml {code}
> of the opennlp script.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OPENNLP-1568) opennlp command fails when invoked from outside $OPENNLP_HOME/bin directory
[
https://issues.apache.org/jira/browse/OPENNLP-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17862519#comment-17862519
]
ASF GitHub Bot commented on OPENNLP-1568:
-
rzo1 commented on PR #607:
URL: https://github.com/apache/opennlp/pull/607#issuecomment-2200245765
Thanks @veita
@kinow I merged it know because it is a valid improvement. We can discuss /
adjust edge cases with realpath etc, if needed in another iteration.
> opennlp command fails when invoked from outside $OPENNLP_HOME/bin directory
> ---
>
> Key: OPENNLP-1568
> URL: https://issues.apache.org/jira/browse/OPENNLP-1568
> Project: OpenNLP
> Issue Type: Bug
> Components: Command Line Interface
>Affects Versions: 2.3.3
> Environment: Linux/Bash
>Reporter: Alexander Veit
>Priority: Major
> Fix For: 2.3.4
>
>
> Try to run the opennlp command from outside $OPENNLP_HOME/bin directory.
> It fails with an error message similar to
>
> {noformat}
> 2024-06-15T22:44:04.900344345Z main ERROR Reconfiguration failed:
> No configuration found for '4f2410ac' at 'null' in 'null'{noformat}
>
> The error is caused by the relative path in
> {code:java}
> -Dlog4j.configurationFile=../conf/log4j2.xml {code}
> of the opennlp script.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (OPENNLP-1585) Reduce creation of String objects for prefixes in several FeatureGenerator classes
[ https://issues.apache.org/jira/browse/OPENNLP-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Richard Zowalla resolved OPENNLP-1585. -- Resolution: Fixed > Reduce creation of String objects for prefixes in several FeatureGenerator > classes > -- > > Key: OPENNLP-1585 > URL: https://issues.apache.org/jira/browse/OPENNLP-1585 > Project: OpenNLP > Issue Type: Improvement > Components: Machine Learning, Name Finder >Affects Versions: 2.3.3 >Reporter: Martin Wiesner >Assignee: Martin Wiesner >Priority: Minor > Fix For: 2.3.4 > > > Several FeatureGenerator classes, create unnecessary string objects. This > results in a large object overhead at runtime, during model training for > instance. > Aims: > - Reduce object creations by introducing constants for "constant" prefixes -- This message was sent by Atlassian Jira (v8.20.10#820010)
