[jira] [Commented] (OPENNLP-1555) TokenizerME should detect multi-dot abbreviations

2024-04-28 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/OPENNLP-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841646#comment-17841646
 ] 

ASF GitHub Bot commented on OPENNLP-1555:
-

mawiesne opened a new pull request, #599:
URL: https://github.com/apache/opennlp/pull/599

   Thank you for contributing to Apache OpenNLP.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
in the commit message?
   
   - [x] Does your PR title start with OPENNLP- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [x] Has your PR been rebased against the latest commit within the target 
branch (typically main)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [x] Have you ensured that the full suite of tests is executed via mvn 
clean install at the root opennlp folder?
   - [x] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file in opennlp folder?
   - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found in opennlp folder?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions for 
build issues and submit an update to your PR as soon as possible.
   




> TokenizerME should detect multi-dot abbreviations
> -
>
> Key: OPENNLP-1555
> URL: https://issues.apache.org/jira/browse/OPENNLP-1555
> Project: OpenNLP
>  Issue Type: Improvement
>  Components: Tokenizer
>Affects Versions: 2.1.0, 2.2.0, 2.3.0, 2.3.1, 2.3.2, 2.3.3
>Reporter: Martin Wiesner
>Assignee: Martin Wiesner
>Priority: Minor
> Fix For: 2.3.4
>
>
> TokenizerME should detect and handle multi-dot abbreviations correctly. 
> Currently, this is not handled correctly. For instance,
> German: "z.B." = "zum Beispiel" (for example) or, 
> Dutch: "e.v." = "en volgende" (and following)
> are not tokenized correctly and extra tokens are returned. NOTE: no 
> whitespaces in between the dots in the above examples.
> Aims:
>  * Fix the detection / handling of abbreviations for multi-dot abbreviations
>  * Provide test cases that cover these cases



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OPENNLP-1555) TokenizerME should detect multi-dot abbreviations

2024-05-02 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/OPENNLP-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842864#comment-17842864
 ] 

ASF GitHub Bot commented on OPENNLP-1555:
-

mawiesne merged PR #599:
URL: https://github.com/apache/opennlp/pull/599




> TokenizerME should detect multi-dot abbreviations
> -
>
> Key: OPENNLP-1555
> URL: https://issues.apache.org/jira/browse/OPENNLP-1555
> Project: OpenNLP
>  Issue Type: Improvement
>  Components: Tokenizer
>Affects Versions: 2.1.0, 2.2.0, 2.3.0, 2.3.1, 2.3.2, 2.3.3
>Reporter: Martin Wiesner
>Assignee: Martin Wiesner
>Priority: Minor
> Fix For: 2.3.4
>
>
> TokenizerME should detect and handle multi-dot abbreviations correctly. 
> Currently, this is not handled correctly. For instance,
> German: "z.B." = "zum Beispiel" (for example) or, 
> Dutch: "e.v." = "en volgende" (and following)
> are not tokenized correctly and extra tokens are returned. NOTE: no 
> whitespaces in between the dots in the above examples.
> Aims:
>  * Fix the detection / handling of abbreviations for multi-dot abbreviations
>  * Provide test cases that cover these cases



--
This message was sent by Atlassian Jira
(v8.20.10#820010)