[Bug 123169] New: 'Find Replace' looses cell selection after unsuccessful Find All

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123169

Bug ID: 123169
Issue Type: DEFECT
   Summary: 'Find  Replace' looses cell selection after
unsuccessful Find All
   Product: Calc
   Version: 3.4.0
  Hardware: PC
OS: Windows 7
Status: UNCONFIRMED
  Severity: normal
  Priority: P3
 Component: ui
  Assignee: issues@openoffice.apache.org
  Reporter: rainerbielefeld_ooo...@bielefeldundbuss.de
CC: issues@openoffice.apache.org

Steps how to reproduce with  AOO 4.1.0-Dev – English  UI / German locale -
[AOO410m1(Build:9750)  -  Rev. 1516435  2013-08-24] on German WIN7 Home
Premium (64bit), own separate user profile:

1. Open  Attachment 81339 for Bug 123047
2. control+f to open 'Find  Replace' dialog
3. click More Options
4. Select 'Search in Values'
5.  Type a into 'Search For' pane 
6. [Find all]
   As expected Search key not found message appears
7. [ok]
   Bug: cell selection disappears   :-(

Additional info
---
a) Competitors:
 a1) LibreOffice 4: Seledtion will not be lost
 a2) SoftMaker FreeOffice: Selection will not be lost
 a3) Calligra: I have difficulties to understand how it works, but it seems 
 thatCalligra has no such find all function
 a4) Gnumeric 1.10.14 
 Works completely different. Here selection will be lost after
 SUCCESSFUL search
b) The bug is very annoying if you want to try different search key strings 
   one by one.
c) That never worked correctly in OOo, already reproducible in OOo 1.1.5
d) I think this problem already has been reported in
   Bug 73542 - Calc loses selection when find  replace over a selection
   what has been closed -  may be I misunderstood that report?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 35093] Find (and replace) on selected cells is misleading

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=35093

Rainer Bielefeld rainerbielefeld_ooo...@bielefeldundbuss.de changed:

   What|Removed |Added

 CC||non-migra...@openoffice.org

--- Comment #14 from Rainer Bielefeld 
rainerbielefeld_ooo...@bielefeldundbuss.de ---
*** Bug 9327 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 9327] Column selection with find and replace

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=9327

Rainer Bielefeld rainerbielefeld_ooo...@bielefeldundbuss.de changed:

   What|Removed |Added

 Status|CLOSED  |RESOLVED
 CC||rainerbielefeld_ooo_qa@biel
   ||efeldundbuss.de
 Resolution|IRREPRODUCIBLE  |DUPLICATE

--- Comment #4 from Rainer Bielefeld 
rainerbielefeld_ooo...@bielefeldundbuss.de ---


*** This bug has been marked as a duplicate of bug 35093 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.


[Bug 114841] Find Replace current selection only (Calc Spreadsheet)

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=114841

Rainer Bielefeld rainerbielefeld_ooo...@bielefeldundbuss.de changed:

   What|Removed |Added

 CC||rainerbielefeld_ooo_qa@biel
   ||efeldundbuss.de

--- Comment #8 from Rainer Bielefeld 
rainerbielefeld_ooo...@bielefeldundbuss.de ---


*** This bug has been marked as a duplicate of bug 35093 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 35093] Find (and replace) on selected cells is misleading

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=35093

Rainer Bielefeld rainerbielefeld_ooo...@bielefeldundbuss.de changed:

   What|Removed |Added

 CC||kls...@web.de

--- Comment #15 from Rainer Bielefeld 
rainerbielefeld_ooo...@bielefeldundbuss.de ---
*** Bug 112334 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 35093] Find (and replace) on selected cells is misleading

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=35093

Rainer Bielefeld rainerbielefeld_ooo...@bielefeldundbuss.de changed:

   What|Removed |Added

 CC||3loma...@gmail.com

--- Comment #16 from Rainer Bielefeld 
rainerbielefeld_ooo...@bielefeldundbuss.de ---
*** Bug 114841 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 112334] behaviour find replace

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=112334

Rainer Bielefeld rainerbielefeld_ooo...@bielefeldundbuss.de changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 CC||rainerbielefeld_ooo_qa@biel
   ||efeldundbuss.de
 Resolution|--- |DUPLICATE

--- Comment #4 from Rainer Bielefeld 
rainerbielefeld_ooo...@bielefeldundbuss.de ---
.

*** This bug has been marked as a duplicate of bug 35093 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 73542] Calc loses selection when find replace over a selection

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=73542

Rainer Bielefeld rainerbielefeld_ooo...@bielefeldundbuss.de changed:

   What|Removed |Added

 CC||rainerbielefeld_ooo_qa@biel
   ||efeldundbuss.de

--- Comment #6 from Rainer Bielefeld 
rainerbielefeld_ooo...@bielefeldundbuss.de ---
I do not consider this one fixed, but may be I do not understand all details of
the report? I submitted Bug 123169 - 'Find  Replace' looses cell selection
after unsuccessful Find All

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.


[Bug 46871] AutoCorrect - Non-localisable key names in Accept with listbox

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=46871

--- Comment #9 from oooforum ooofo...@free.fr ---
Created attachment 81437
  -- https://issues.apache.org/ooo/attachment.cgi?id=81437action=edit
System Linux x64

In the dialogbox, key name Space is not translated in french by Espace

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.


[Bug 46871] AutoCorrect - Non-localisable key names in Accept with listbox

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=46871

--- Comment #10 from oooforum ooofo...@free.fr ---
Created attachment 81438
  -- https://issues.apache.org/ooo/attachment.cgi?id=81438action=edit
System MacOS X

Each item is replaced by a specific symbol

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.


[Bug 120856] spelling error in tooltip line style (german: Linienstil)

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=120856

--- Comment #3 from SVN Robot svn...@dev.null.org ---
jsc committed SVN revision 1519594 into trunk:
#120856# update translation for German, e.g. correct speling errors

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


[Bug 120856] spelling error in tooltip line style (german: Linienstil)

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=120856

--- Comment #4 from SVN Robot svn...@dev.null.org ---
jsc committed SVN revision 1519596 into branches/AOO401:
#120856# merge updated translation for German

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


[Bug 123111] Vietnamese (vi) translation update for OpenOffice 4.0.1

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123111

--- Comment #5 from SVN Robot svn...@dev.null.org ---
jsc committed SVN revision 1519599 into branches/AOO401:
#123111# merge translation for Vietnamese

-- 
You are receiving this mail because:
You are watching all bug changes.


[Bug 122889] Viewing two colorised object who are grouped are not the same as in AOO 3.4.1.

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=122889

Armin Le Grand armin.le.gr...@me.com changed:

   What|Removed |Added

   Keywords|regression  |

--- Comment #13 from Armin Le Grand armin.le.gr...@me.com ---
ALG: @sevalav: Okay, thanks for cheking and trying to find out! If this is not
reproducible with other files (at best with a way to create this files), please
change your file and think about removing the regression keyword. Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 123170] New: create an autotest suitable for demonstrating OpenOffice

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123170

Bug ID: 123170
Issue Type: FEATURE
   Summary: create an autotest suitable for demonstrating
OpenOffice
   Product: qa
   Version: 4.0.0
  Hardware: All
OS: All
Status: CONFIRMED
  Severity: normal
  Priority: P3
 Component: testscripts
  Assignee: issues@openoffice.apache.org
  Reporter: h...@apache.org
CC: issues@openoffice.apache.org, o...@mechtilde.de

Mechtilde suggested that we could employ the autotest framework for
demonstrating various OpenOffice aspects.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 123168] Update bundled Spanish (ES) dictionary for Apache OpenOffice 4.0.1

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123168

j...@apache.org changed:

   What|Removed |Added

 CC||j...@apache.org
 Issue Type|DEFECT  |TASK
  Flags|4.0.1_release_blocker?  |4.0.1_release_blocker+

--- Comment #1 from j...@apache.org ---
approve showstopper request

-- 
You are receiving this mail because:
You are watching all bug changes.


[Bug 123048] line skew parameter is not read from file for connectors in OO draw

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123048

Armin Le Grand armin.le.gr...@me.com changed:

   What|Removed |Added

  Flags|4.0.1_release_blocker+  |4.0.1_release_blocker?
   Target Milestone|4.0.1   |4.1.0

--- Comment #18 from Armin Le Grand armin.le.gr...@me.com ---
@Joe: As long as the flag is not on '+' I see the fix targeted to AOO410. *If*
the flag is given, I change it when comitting to AOO401 usually.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.


4.0.1_release_blocker granted: [Bug 123168] Update bundled Spanish (ES) dictionary for Apache OpenOffice 4.0.1

2013-09-03 Thread bugzilla
j...@apache.org has granted rgb rgb...@apache.org's request for
4.0.1_release_blocker:
Bug 123168: Update bundled Spanish (ES) dictionary for Apache OpenOffice 4.0.1
https://issues.apache.org/ooo/show_bug.cgi?id=123168


--- Additional Comments from j...@apache.org
approve showstopper request


4.0.1_release_blocker requested: [Bug 123048] line skew parameter is not read from file for connectors in OO draw

2013-09-03 Thread bugzilla
Armin Le Grand armin.le.gr...@me.com has asked  for 4.0.1_release_blocker:
Bug 123048: line skew parameter is not read from file for connectors in OO draw
https://issues.apache.org/ooo/show_bug.cgi?id=123048


--- Additional Comments from Armin Le Grand armin.le.gr...@me.com
@Joe: As long as the flag is not on '+' I see the fix targeted to AOO410. *If*
the flag is given, I change it when comitting to AOO401 usually.


[Bug 122820] exported image size ignores settings

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=122820

j...@apache.org changed:

   What|Removed |Added

   Target Milestone|4.1.0   |4.0.1

--- Comment #10 from j...@apache.org ---
set target

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.


4.0.1_release_blocker granted: [Bug 122735] misspelled words in sidebar calc - rev. 1502185

2013-09-03 Thread bugzilla
j...@apache.org has granted brinzing oliver.brinz...@gmx.de's request for
4.0.1_release_blocker:
Bug 122735: misspelled words in sidebar calc -  rev. 1502185
https://issues.apache.org/ooo/show_bug.cgi?id=122735


--- Additional Comments from j...@apache.org
approve showstopper request

[Bug 122735] misspelled words in sidebar calc - rev. 1502185

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=122735

j...@apache.org changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
  Flags|4.0.1_release_blocker?  |4.0.1_release_blocker+

--- Comment #4 from j...@apache.org ---
approve showstopper request

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


[Bug 122735] misspelled words in sidebar calc - rev. 1502185

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=122735

j...@apache.org changed:

   What|Removed |Added

   Target Milestone|--- |4.0.1

--- Comment #5 from j...@apache.org ---
set target milestone

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


[Bug 120856] spelling error in tooltip line style (german: Linienstil)

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=120856

j...@apache.org changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 CC||j...@apache.org
 Resolution|--- |FIXED
   Target Milestone|--- |4.0.1
  Flags|4.0.1_release_blocker?  |4.0.1_release_blocker+

--- Comment #5 from j...@apache.org ---
approve showstopper request

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


4.0.1_release_blocker granted: [Bug 120856] spelling error in tooltip line style (german: Linienstil)

2013-09-03 Thread bugzilla
j...@apache.org has granted brinzing oliver.brinz...@gmx.de's request for
4.0.1_release_blocker:
Bug 120856: spelling error in tooltip line style (german: Linienstil)
https://issues.apache.org/ooo/show_bug.cgi?id=120856


--- Additional Comments from j...@apache.org
approve showstopper request


[Bug 123048] line skew parameter is not read from file for connectors in OO draw

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123048

j...@apache.org changed:

   What|Removed |Added

  Flags|4.0.1_release_blocker?  |4.0.1_release_blocker+

--- Comment #19 from j...@apache.org ---
approve showstopper request again

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.


4.0.1_release_blocker granted: [Bug 123048] line skew parameter is not read from file for connectors in OO draw

2013-09-03 Thread bugzilla
j...@apache.org has granted Armin Le Grand armin.le.gr...@me.com's request for
4.0.1_release_blocker:
Bug 123048: line skew parameter is not read from file for connectors in OO draw
https://issues.apache.org/ooo/show_bug.cgi?id=123048


--- Additional Comments from j...@apache.org
approve showstopper request again


[Bug 123098] spelling error in menu Daten - Pivot Table

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123098

j...@apache.org changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
   Target Milestone|--- |4.0.1

--- Comment #5 from j...@apache.org ---
set target milestone

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


[Bug 123045] Änderungen Datensatz statt Aufzeichnen

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123045

j...@apache.org changed:

   What|Removed |Added

   Target Milestone|--- |4.0.1

--- Comment #8 from j...@apache.org ---
set target milestone

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


[Bug 123003] Text invisible while editing in particular old documents

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123003

j...@apache.org changed:

   What|Removed |Added

   Target Milestone|4.1.0   |4.0.1

--- Comment #15 from j...@apache.org ---
set target milestone

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 123048] line skew parameter is not read from file for connectors in OO draw

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123048

j...@apache.org changed:

   What|Removed |Added

   Target Milestone|4.1.0   |4.0.1

--- Comment #20 from j...@apache.org ---
set target milestone

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.


[Bug 123171] New: Enhancement of Graph application

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123171

Bug ID: 123171
Issue Type: DEFECT
   Summary: Enhancement of Graph application
   Product: Impress
   Version: 4.0.0
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: P3
 Component: viewing
  Assignee: issues@openoffice.apache.org
  Reporter: pascal_coin...@hotmail.fr
CC: issues@openoffice.apache.org

Created attachment 81439
  -- https://issues.apache.org/ooo/attachment.cgi?id=81439action=edit
Graphs in Impress and Excel

Possibility to put a grid on the secondary axis

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 123172] New: several SVT autotests timeout when run as buildbot steps

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123172

Bug ID: 123172
Issue Type: DEFECT
   Summary: several SVT autotests timeout when run as buildbot
steps
   Product: qa
   Version: 4.0.0
  Hardware: All
OS: All
Status: CONFIRMED
  Severity: normal
  Priority: P3
 Component: testscripts
  Assignee: h...@apache.org
  Reporter: h...@apache.org
CC: issues@openoffice.apache.org

A couple of SVT autotests are not yet suitable for being run as a buildbot step
because they repeat running individual test cases hundreds of times without
providing any output. Buildbots expect regular output and the timeout for this
is configurable. The default value of 1200 seconds is already quite high and
should neither be increased by orders of magnitude or nor should it be
disabled, as hang detection is  a valuable test.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.


[Bug 122820] exported image size ignores settings

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=122820

--- Comment #11 from Armin Le Grand armin.le.gr...@me.com ---
ALG: Added to AOO401, done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.


[Bug 123048] line skew parameter is not read from file for connectors in OO draw

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123048

--- Comment #21 from Armin Le Grand armin.le.gr...@me.com ---
ALG: Checked and committed to AOO401, changed target, done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.


[Bug 122820] exported image size ignores settings

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=122820

--- Comment #12 from SVN Robot svn...@dev.null.org ---
alg committed SVN revision 1519619 into branches/AOO401:
i122820 Corrected graphics creation, allow bigger limits if directly requested

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.


[Bug 123048] line skew parameter is not read from file for connectors in OO draw

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123048

--- Comment #22 from SVN Robot svn...@dev.null.org ---
alg committed SVN revision 1519625 into branches/AOO401:
i123048 Corrected connector layout after reload

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.


[Bug 123172] several SVT autotests timeout when run as buildbot steps

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123172

--- Comment #1 from SVN Robot svn...@dev.null.org ---
hdu committed SVN revision 1519626 into trunk:
#i123172# emit regular infos in long running SVT autotests

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.


[Bug 123129] Anchor line for comments is too fine for viewing

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123129

Armin Le Grand armin.le.gr...@me.com changed:

   What|Removed |Added

   Assignee|iss...@openoffice.apache.or |armin.le.gr...@me.com
   |g   |

--- Comment #10 from Armin Le Grand armin.le.gr...@me.com ---
ALG: Corrected owner

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 122982] Copying spreadsheet into another document in bit map format has disappeared in Version 4. Worked on Version 3.

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=122982

--- Comment #14 from Armin Le Grand armin.le.gr...@me.com ---
ALG: Corrected owner

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 123003] Text invisible while editing in particular old documents

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123003

--- Comment #16 from Armin Le Grand armin.le.gr...@me.com ---
ALG: Corrected owner

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 122923] Bad performance showing ODF with page size foreground pictures

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=122923

Armin Le Grand armin.le.gr...@me.com changed:

   What|Removed |Added

   Assignee|iss...@openoffice.apache.or |armin.le.gr...@me.com
   |g   |

--- Comment #16 from Armin Le Grand armin.le.gr...@me.com ---
ALG: Corrected owner

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 122982] Copying spreadsheet into another document in bit map format has disappeared in Version 4. Worked on Version 3.

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=122982

Armin Le Grand armin.le.gr...@me.com changed:

   What|Removed |Added

   Assignee|iss...@openoffice.apache.or |armin.le.gr...@me.com
   |g   |

--- Comment #15 from Armin Le Grand armin.le.gr...@me.com ---
ALG: Corrected owner

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 123003] Text invisible while editing in particular old documents

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123003

Armin Le Grand armin.le.gr...@me.com changed:

   What|Removed |Added

   Assignee|iss...@openoffice.apache.or |armin.le.gr...@me.com
   |g   |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 122920] Image pasted from certain browsers is black

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=122920

Armin Le Grand armin.le.gr...@me.com changed:

   What|Removed |Added

   Assignee|iss...@openoffice.apache.or |armin.le.gr...@me.com
   |g   |

--- Comment #25 from Armin Le Grand armin.le.gr...@me.com ---
ALG: Corrected owner

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 123017] Text selection highlighting disappears

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123017

Armin Le Grand armin.le.gr...@me.com changed:

   What|Removed |Added

   Assignee|iss...@openoffice.apache.or |armin.le.gr...@me.com
   |g   |

--- Comment #4 from Armin Le Grand armin.le.gr...@me.com ---
ALG: Corrected owner

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 122921] Old Impress files cannot be edited in Impress 4.0.0

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=122921

Armin Le Grand armin.le.gr...@me.com changed:

   What|Removed |Added

   Assignee|iss...@openoffice.apache.or |armin.le.gr...@me.com
   |g   |

--- Comment #3 from Armin Le Grand armin.le.gr...@me.com ---
ALG: Corrected owner

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 122842] Using 'DuckCapture' Screen capture tool (control c and paste to Writer doc). Shows black box.

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=122842

Armin Le Grand armin.le.gr...@me.com changed:

   What|Removed |Added

   Assignee|iss...@openoffice.apache.or |armin.le.gr...@me.com
   |g   |

--- Comment #9 from Armin Le Grand armin.le.gr...@me.com ---
ALG: Corrected owner

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 123172] several SVT autotests timeout when run as buildbot steps

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123172

--- Comment #2 from SVN Robot svn...@dev.null.org ---
hdu committed SVN revision 1519643 into trunk:
#i123172# speedup autotest mouse dragging

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.


[Bug 122985] Slow working with photos

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=122985

Armin Le Grand armin.le.gr...@me.com changed:

   What|Removed |Added

   Assignee|iss...@openoffice.apache.or |armin.le.gr...@me.com
   |g   |

--- Comment #9 from Armin Le Grand armin.le.gr...@me.com ---
ALG: Already speeded up stuff for rendering and conversion to Gdiplus::Bitmap
in task #122923#, this should bring it back to comparable speeds as before.

Still I took a look at JPEGReader::Read. To mention before: Nothing was changed
there, but it uses ca. 17% of it's time to read the jpeg and the *rest* to get
it to a Bitmap as content. This is because SetPixel() calls are used and jpeg's
imported format is RGB while the 24bit bitmap uses GBR internally. There is no
GBR import format available from the jpeg importer unfortunately.
Tried to use CopyScanline at BitmapWriteAccess using BMP_FORMAT_24BIT_TC_RGB.
This works but is not much faster as SetPixel() since the internal format
conversion is not very fast.
But using BMP_FORMAT_24BIT_TC_BGR and first 'switching' all 1st and 3rd bytes
in a loop makes it much faster. With this additional speedup for jpeg we sould
be better than before. Preparing checking this in.

Also took a look at the swap stuff in current GraphicObjects; these all get
swapped out after 5000ms (5 seconds), independent of the time set in
tools/options/memory/Remove_from_memory_after setting. This seems wrong and
makes switching pages very slow since loading has to reoccur often. Taking a
look...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 121312] Slow database access with Java 7

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=121312

andreas.gr...@newsales.de changed:

   What|Removed |Added

 CC||andreas.gr...@newsales.de

--- Comment #5 from andreas.gr...@newsales.de ---
This issue keeps me on the very very old Java 1.6.022!

Please fix this issue - it's open since months and months. I'm working with
OpenSuse 12.3!

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


[Bug 121519] OpenOffice crashes when disconnecting the remote desktop session

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=121519

Comfine GmbH i...@comfine.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #8 from Comfine GmbH i...@comfine.de ---
*** This bug has been confirmed by popular vote. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 121519] OpenOffice crashes when disconnecting the remote desktop session

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=121519

Comfine GmbH i...@comfine.de changed:

   What|Removed |Added

 CC||i...@comfine.de

--- Comment #9 from Comfine GmbH i...@comfine.de ---
is there somebody who is working on this bug? Would be great to see this fixed!
we use the RDP-Connection everyday, and if somebody is in front in the store, i
do connect to my rdp-connection from our pos and everytime my
openoffice-document crashes - i need this document all day long, cause we log
our work in this document - so this is happening to me multiple times a
day...and everytime with the crash ..this is indeed, as rendman said, extremely
painful.

but, by the way: thanks to the communicty for this AWESOME PEACE OF FREE
OpenSource Software

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 122985] Slow working with photos

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=122985

--- Comment #10 from Armin Le Grand armin.le.gr...@me.com ---
AG: Checked what happens when not setting a swap time at all; idea was that the
GraphicManager (which at least reads the timeout from the settings in
GraphicObject::ImplSetGraphicManager and sets it at the global GraphicCache)
would then swap out all GraphicObjects after the given time, but this does not
work. Reading the setting itself and set it instead of the 5000ms works well;
still has its weaknesses since it *tests* for swap out every e.g. 10 minutes
(if set so), also no 'touch' when the graphic is used to reset the timer is
there (what would be normal for a cache). What to do...?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.


[Bug 122985] Slow working with photos

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=122985

--- Comment #11 from Armin Le Grand armin.le.gr...@me.com ---
ALG: Checked svtools jpeg load changes on linux to be on the safe side, all
works well and is faster, too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.


[Bug 123173] New: Manual break doesn't work when printing a print range

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123173

Bug ID: 123173
Issue Type: DEFECT
   Summary: Manual break doesn't work when printing a print range
   Product: Calc
   Version: 4.0.0
  Hardware: PC
OS: Windows XP
Status: UNCONFIRMED
  Severity: normal
  Priority: P3
 Component: printing
  Assignee: issues@openoffice.apache.org
  Reporter: rg...@cox.net
CC: issues@openoffice.apache.org

Created attachment 81440
  -- https://issues.apache.org/ooo/attachment.cgi?id=81440action=edit
Calc file showing manual page breaks with print range defined

I defined a print range to only print specific columns (to fit one page wide),
with as many rows as are filled in with data. I edited the print range to
specify row 1 to be repeated on each page. I inserted manual row breaks to
break the pages at specific points. I can view page breaks, and confirm that
they are where I want. In print preview, the pages are not broken at the points
specified by the manual row breaks. When I print, the pages are not broken at
the points specified by the manual row breaks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 123174] New: General Internet error has occurred.

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123174

Bug ID: 123174
Issue Type: DEFECT
   Summary: General Internet error has occurred.
   Product: Writer
   Version: 4.0.0
  Hardware: PC
OS: Windows 7
Status: UNCONFIRMED
  Severity: minor
  Priority: P3
 Component: viewing
  Assignee: issues@openoffice.apache.org
  Reporter: knowtrash2...@gmail.com
CC: issues@openoffice.apache.org

When viewing a document with some sort of active links, this error titled
OpenOffice 4.0.0 shows General Internet error has occurred., when the
internet is not connected.

So as i scroll down the document for the first time, the error appears, and
okay is clicked. It is not repeated for this opening of the file. However, as i
scroll down to more of the active links, the error reappears for each active
link that i come across, with the need to click OK on each one.

It is more of a nuance, it just needs ignore it or to gray out any active
links, not report an error. 
It is not an error, i wanted the internet off. The condition needs to be
handled gracefully with out user intervention.

Firefox/Win7/mycompany is not allowing attachments at the moment. But file
PREP-Sew-130902-Necchi-EHowStuff.odt maybe available another way or by home
computer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 123174] General Internet error has occurred.

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123174

knowtrash2...@gmail.com changed:

   What|Removed |Added

 CC||knowtrash2...@gmail.com

--- Comment #1 from knowtrash2...@gmail.com ---
i was cutting and pasting from E-How.
the active links came from the articles.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 114581] Page break doesn't work if Scaling different from Reduce/enlarged printout

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=114581

Regina Henschel rb.hensc...@t-online.de changed:

   What|Removed |Added

 CC||rg...@cox.net

--- Comment #8 from Regina Henschel rb.hensc...@t-online.de ---
*** Bug 123173 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 123173] Manual break doesn't work when printing a print range

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123173

Regina Henschel rb.hensc...@t-online.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||rb.hensc...@t-online.de
 Resolution|--- |DUPLICATE

--- Comment #1 from Regina Henschel rb.hensc...@t-online.de ---
You have set an automatic distribution of the content to 11 pages in height in
your page format. This automatic has precedence over the manual page breaks.
Erase this entry so that the height field is empty. Then your document will
break at the manual row breaks. If the page, which is given by the manual row
breaks is too high for the given paper format, an additional break is inserted
automatically for this page.

*** This bug has been marked as a duplicate of bug 114581 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 107711] Disable Export/Save to Word 95/Word 6.0 By Default

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=107711

Yuhong Bao yuhongbao_...@hotmail.com changed:

   What|Removed |Added

 CC||yuhongbao_...@hotmail.com

--- Comment #4 from Yuhong Bao yuhongbao_...@hotmail.com ---
Except this bug is about removing *save* support for Word 6.0/95, not open
support. AFAIK if it is so incomplete that tables are lost, it should be either
be fixed or removed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 123143] Updating styles does not properly update the bundled styles

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123143

--- Comment #3 from eric.edwards@outlook.com ---
I see where I was a little ambiguous in my earlier steps.  What follows is a
detailed way of recreating the error.  In other bug reports I have included
files, but since this process requires a template, a child document, and then
saving over the template again, I think a zip file of the documents would
require a bunch of steps anyway.  If you are unable to reproduce using the
following steps, I'd be happy to upload a series of screenshots of me going
through them.

Anyway, here we go, in 28 simple steps:

1. Select File-New-Drawing
2. Select the rectangle button and draw a rectangle in the upper-left corner.
3. While the rectangle is selected, double-click Default in the Styles and
Formatting box to set that as the style.
4. Right click on the Default style in the Styles and Formatting box and select
modify.
5. In the Area tab change the fill color to Orange 1.
6. Select the rectangle button and draw a rectangle under the first one.
7. With the second rectangle selected, select the New Style from Selection
button in the Styles and Formatting box.
8. Name the style Custom and select OK.
9. Right click on the Custom style in the Styles and Formatting box and select
modify.
10. In the Area tab change the fill color to Green 1.
11. Select the rectangle button and draw a rectangle under the second one.
12. With the third rectangle selected, double-click Dimension Line in the
Styles and Formatting box to set that as the style.
13. Select File-Templates-Save and save it as Test Style.
14. Close the drawing, discarding it.
15. Select File-New-Templates and Documents.
16. Select the Test Style template and press okay.
17. Select the rectangle button and draw a rectangle under the third one.
18. With the fourth rectangle selected, double-click on Text body in the Styles
and Formatting box.
19. Save the drawing as Test Style Drawing.odg
20. Close the drawing.
21. Select File-New-Templates and Documents.
22. Select the Test Style template and press okay.
23. Select the third box and delete it.
24. Select File-Templates-Save and save it as Test Style.
25. Confirm that yes you do want to overwrite the old template.
26. Close the drawing.
27. Select File-Open and open Test Style Drawing.odg
28. You should now be prompted to update styles.  Select Update Styles.

There are other ways to recreate this error as well, I just wanted it to be
clear that the custom style did not change, only the bundled style.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 123177] New: erro de formulas

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123177

Bug ID: 123177
Issue Type: DEFECT
   Summary: erro de formulas
   Product: Calc
   Version: 4.0.0
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: P3
 Component: configuration
  Assignee: issues@openoffice.apache.org
  Reporter: michell...@unimeduberaba.com.br
CC: issues@openoffice.apache.org

Created attachment 81443
  -- https://issues.apache.org/ooo/attachment.cgi?id=81443action=edit
eu fiz errado nãolocalizo o erro

eu fiz a formulaerrada do excel para passar para criação web numa aplicação XML
de conversao de valores de um site de cotação.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123175] New: Procv excel

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123175

Bug ID: 123175
Issue Type: DEFECT
   Summary: Procv excel
   Product: Calc
   Version: 4.0.0
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: P3
 Component: configuration
  Assignee: issues@openoffice.apache.org
  Reporter: michell...@unimeduberaba.com.br
CC: issues@openoffice.apache.org

Created attachment 81441
  -- https://issues.apache.org/ooo/attachment.cgi?id=81441action=edit
o erro nao encontrado

procv com erro

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 123176] New: Procv excel

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123176

Bug ID: 123176
Issue Type: DEFECT
   Summary: Procv excel
   Product: Calc
   Version: 4.0.0
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: P3
 Component: configuration
  Assignee: issues@openoffice.apache.org
  Reporter: michell...@unimeduberaba.com.br
CC: issues@openoffice.apache.org

procv com erro

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 123176] Procv excel

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123176

--- Comment #1 from michellesi michell...@unimeduberaba.com.br ---
Created attachment 81442
  -- https://issues.apache.org/ooo/attachment.cgi?id=81442action=edit
erro ecel

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 123178] New: Time values not adding up correctly

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123178

Bug ID: 123178
Issue Type: DEFECT
   Summary: Time values not adding up correctly
   Product: Calc
   Version: 4.0.0
  Hardware: PC
OS: Windows XP
Status: UNCONFIRMED
  Severity: minor
  Priority: P3
 Component: editing
  Assignee: issues@openoffice.apache.org
  Reporter: vistaenniscl...@gmail.com
CC: issues@openoffice.apache.org

Created attachment 81444
  -- https://issues.apache.org/ooo/attachment.cgi?id=81444action=edit
See above in the description...straight forward.

See the attachment: This is a simple time sheet that I have been using for more
than two years. It has two weeks of data. The time is entered in hours and
minutes. One of the weeks added up correctly and the other did not. The format
for the cells has not changed. I have used this sheet a couple of times since I
put in release 4.0.0.
What could cause this. By the way, I took a fresh copy of the master for this
sheet and put in the same data...same result so that it is not a one in a
million I/O error or dirty hard drive sector.
...Howard

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 123143] Updating styles does not properly update the bundled styles

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123143

--- Comment #4 from Rainer Bielefeld 
rainerbielefeld_ooo...@bielefeldundbuss.de ---
I followed the steps. The menu item mentioned in step 13 did not exist for me
with 3.4.1, I added an Item to the menu what leads me to 'Templates - New
Template' dialog (With 4.0.0 the mentioned menu item does exist).

All observations reproducible with server installation of  AOO 3.4.1 – German
UI / German locale [AOO341m1(Build:9593) - Rev.1372282] on German WIN7 Home
Premium (64bit), own separate user profile.

But:

What the heck is the problem? Nothing unexpected for me.

@eric.edwards.msb
Please contribute a more precise summary due to
http://wiki.openoffice.org/wiki/QA/HowToFileIssue#Reporting%20a%20New%20Bug#Principles
Additionally to your step by step instruction please describe precisely what
you expect, why you expect that (cite help or similar) and why you think what
you observe is a a bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123179] New: Add Favicon to AOO Website

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123179

Bug ID: 123179
Issue Type: ENHANCEMENT
   Summary: Add Favicon to AOO Website
   Product: Infrastructure
   Version: current
  Hardware: All
   URL: http://www.openoffice.org/
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: P3
 Component: Website general issues
  Assignee: issues@openoffice.apache.org
  Reporter: rainerbielefeld_ooo...@bielefeldundbuss.de
CC: issues@openoffice.apache.org

Steps how to reproduce:
1. Open http://www.openoffice.org/
2. In different browser tab open http://wiki.openoffice.org/wiki/Main_Page
3. Compare! My results with Seamonkey 2.19
   Wiki: as expected AOO icon (blue circle with white seagulls) shown in
 Browser TAB and URL pane
   Website: no favicon

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 123074] cannot save download

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123074

Rainer Bielefeld rainerbielefeld_ooo...@bielefeldundbuss.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||rainerbielefeld_ooo_qa@biel
   ||efeldundbuss.de
 Resolution|--- |IRREPRODUCIBLE

--- Comment #2 from Rainer Bielefeld 
rainerbielefeld_ooo...@bielefeldundbuss.de ---
Closing issue due to reporter's inactivity.

@reporter: You can get help from the public users mailing list
us...@openoffice.org or on the forum at
http://user.services.openoffice.org/en/forum/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.


[Bug 122900] PDF import of SCAN with combined picture + text contents: Some text wrongly in foreground

2013-09-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=122900

Rainer Bielefeld rainerbielefeld_ooo...@bielefeldundbuss.de changed:

   What|Removed |Added

 CC||rainerbielefeld_ooo_qa@biel
   ||efeldundbuss.de

--- Comment #6 from Rainer Bielefeld 
rainerbielefeld_ooo...@bielefeldundbuss.de ---
Created attachment 81445
  -- https://issues.apache.org/ooo/attachment.cgi?id=81445action=edit
Sample document

Steps how to reproduce with  AOO 4.1.0-Dev – English  UI / German locale -
[AOO410m1(Build:9750)  -  Rev. 1516435  2013-08-24] on German WIN7 Home
Premium (64bit), own separate user profile:

0. Install Extension PDF Import for Apache OpenOffice
   http://extensions.openoffice.org/en/project/pdf-import-apache-openoffice
   if not already installed for your OOo
1. From AOO Start Center, open attached sample document (PDF)
   Expected: all OCR text behind the full page picture
   Actual: at the most bottom most right visible text line E-Mail: I see 
   some textbox text in front of the picture, what will become
invisible
   when I bring the picture to the most foreground (click somewhere
into
   a white area in the middle of the document, when full page picture
is
   selected, menu 'Modify - Arrange - Bring to Front')
   All real ocr text should be behind picture

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.