[Bug 123870] CRASH when open Particular.xls with chart
https://issues.apache.org/ooo/show_bug.cgi?id=123870 fanyuz...@gmail.com changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #15 from fanyuz...@gmail.com --- Change status per Shao Zhi Zhao's comment 14 -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes.
[Bug 123870] CRASH when open Particular.xls with chart
https://issues.apache.org/ooo/show_bug.cgi?id=123870 --- Comment #14 from zhaoshzh --- fixed on AOO410m1(build:9750) - rev:1566593 -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes.
[Bug 123870] CRASH when open Particular.xls with chart
https://issues.apache.org/ooo/show_bug.cgi?id=123870 fanyuz...@gmail.com changed: What|Removed |Added CC||fanyuz...@gmail.com QA Contact||aoo.zhaos...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes.
[Bug 123870] CRASH when open Particular.xls with chart
https://issues.apache.org/ooo/show_bug.cgi?id=123870 Armin Le Grand changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED Target Milestone|--- |4.1.0 --- Comment #13 from Armin Le Grand --- Okay, done. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes.
[Bug 123870] CRASH when open Particular.xls with chart
https://issues.apache.org/ooo/show_bug.cgi?id=123870 --- Comment #12 from SVN Robot --- "alg" committed SVN revision 1559272 into trunk: i123870 corrected import values on xml import with chart, avoid uninitialized... -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes.
[Bug 123870] CRASH when open Particular.xls with chart
https://issues.apache.org/ooo/show_bug.cgi?id=123870 --- Comment #11 from Armin Le Grand --- This works well and produces the correct result (cheched with MS stuff). Preparing commit... -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes.
[Bug 123870] CRASH when open Particular.xls with chart
https://issues.apache.org/ooo/show_bug.cgi?id=123870 --- Comment #10 from Armin Le Grand --- Constructor did not work, it is used in various union constructs and does not simply allow a user-defined one; added a method InitMembers instead and use that at the according places. Also exchanged the assertion in getRangeFromToken to not check for relative flags (happens too often to really be wrong), but for validity of ranges of absolute values. Checking this solution... -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes.
[Bug 123870] CRASH when open Particular.xls with chart
https://issues.apache.org/ooo/show_bug.cgi?id=123870 --- Comment #9 from Armin Le Grand --- Tried different solutions: - Added correctors to ScRefTokenHelper::getRangeFromToken to do CalcAbsIfRel if needed. Works, but I do not want to change that data. It hets called in running office, too, with relative entries but the absolute get used. Thus, adding an assertion there. - Added initializers for the members of ScSingleRefData and ScComplexRefData in ExcelToSc8::ConvertExternName and ExcelToSc8::Convert. Also works, but shows that a initializing constructor would work sell, too. - Added constructor to ScSingleRefData (will also work for ScComplexRefData whcih has two ScSingleRefData as members), this is probably the best thing to do. Checking that solution... -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes.
[Bug 123870] CRASH when open Particular.xls with chart
https://issues.apache.org/ooo/show_bug.cgi?id=123870 --- Comment #8 from Armin Le Grand --- In ScSingleRefData the flags for relative col/row are set in the dangerous case, thus the absolute values nCol/nRow should not even be used, but they get used. There is also ScSingleRefData::CalcAbsIfRel which probably should be used on the instance before usage, it needs a const ScAddress&. This i snot available at the place where it goers wrong, so this should probably be appied before and relative to something that makes sense... -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes.
[Bug 123870] CRASH when open Particular.xls with chart
https://issues.apache.org/ooo/show_bug.cgi?id=123870 --- Comment #7 from Armin Le Grand --- ScSingleRefData has no constructor, so its not easy to see where it gets constructed. This also means that the members are not initialized (which may already be the problem). Who is writing classes like this..? -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes.
[Bug 123870] CRASH when open Particular.xls with chart
https://issues.apache.org/ooo/show_bug.cgi?id=123870 --- Comment #6 from Armin Le Grand --- The ScSingleRefData the data is copied from is already wrong. Lets see where this is created... -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes.
[Bug 123870] CRASH when open Particular.xls with chart
https://issues.apache.org/ooo/show_bug.cgi?id=123870 Armin Le Grand changed: What|Removed |Added CC||armin.le.gr...@me.com --- Comment #5 from Armin Le Grand --- Taking a look. In StartEndListening::operator() a ScRange is created which has a nCol (column) set to -27541. This is later used as index to an array which crashes. Resetting it to null makes the load work (it's actually not the load but a XclImpChart::Convert which also sets the listeners to the corresponding chart cells). Thus, ScRefTokenHelper::getRangeFromToken makes something wrong. Checking... -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes.
[Bug 123870] CRASH when open Particular.xls with chart
https://issues.apache.org/ooo/show_bug.cgi?id=123870 --- Comment #4 from Rainer Bielefeld --- Created attachment 82126 --> https://issues.apache.org/ooo/attachment.cgi?id=82126&action=edit Test Kit Attached Test Kit contains 3 Documents (h) Mytest_NoGood_LibO4132.ods Has been createded from reporter's sample document using LibO 3.1.4.2 (i) Mytest_NoGood_LibO4132.xls Has been createded from Mytest_NoGood_LibO4132.ods sample document using LibO 3.1.4.2 AOO 4.1 will crash opening that document (k) Mytest_NoGood_LibO4132OOO410.xls Has been createded from Mytest_NoGood_LibO4132.ods sample document using AOO 4.1 AOO 4.1 will NOT crash opening that document (l) May be differences between both .xls help to find the vulnerability in AOO (m) Both .xls look fine in MS EXCEL Viewer -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes.
[Bug 123870] CRASH when open Particular.xls with chart
https://issues.apache.org/ooo/show_bug.cgi?id=123870 Rainer Bielefeld changed: What|Removed |Added Summary|CRASH when open |CRASH when open |Particular.xls |Particular.xls with chart -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes.
