[Bug 49155] Unwanted top distance after insertion of a caption for a graphic
https://issues.apache.org/ooo/show_bug.cgi?id=49155 --- Comment #13 from SVN Robot --- "orw" committed SVN revision 1544170 into trunk: 49155: improve vertical position of graphic object when a caption is applied -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
[Bug 49155] Unwanted top distance after insertion of a caption for a graphic
https://issues.apache.org/ooo/show_bug.cgi?id=49155 --- Comment #12 from Ariel Constenla-Haile --- (In reply to Oliver-Rainer Wittmann from comment #10) > Comment on attachment 81756 [details] > Patch with proposed fix > > patch looks good - I will integrate it into trunk for the next release. > Ariel: Is this ok for you that I initiate the 'svn commit'? yes, please do so. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
[Bug 49155] Unwanted top distance after insertion of a caption for a graphic
https://issues.apache.org/ooo/show_bug.cgi?id=49155 Oliver-Rainer Wittmann changed: What|Removed |Added Status|ACCEPTED|RESOLVED Resolution|--- |FIXED Target Milestone|--- |4.1.0 --- Comment #14 from Oliver-Rainer Wittmann --- applied patch on trunk for next release --> solved -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
[Bug 49155] Unwanted top distance after insertion of a caption for a graphic
https://issues.apache.org/ooo/show_bug.cgi?id=49155 Oliver-Rainer Wittmann changed: What|Removed |Added Status|CONFIRMED |ACCEPTED --- Comment #11 from Oliver-Rainer Wittmann --- Allowing caption above has been reported by bug 24445. Unfortunately, allowing caption above needs more effort, which I do not have available now. Thus, just applying Ariel's suggestion without considering 'caption above'. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
[Bug 49155] Unwanted top distance after insertion of a caption for a graphic
https://issues.apache.org/ooo/show_bug.cgi?id=49155 Oliver-Rainer Wittmann changed: What|Removed |Added Attachment #81756||review+ Flags|| --- Comment #10 from Oliver-Rainer Wittmann --- Comment on attachment 81756 --> https://issues.apache.org/ooo/attachment.cgi?id=81756 Patch with proposed fix patch looks good - I will integrate it into trunk for the next release. Ariel: Is this ok for you that I initiate the 'svn commit'? Additionally, I will try to enable 'above' option for graphic captions and drawing captions -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
review granted: [Bug 49155] Unwanted top distance after insertion of a caption for a graphic : [Attachment 81756] Patch with proposed fix
Oliver-Rainer Wittmann has granted review: Bug 49155: Unwanted top distance after insertion of a caption for a graphic https://issues.apache.org/ooo/show_bug.cgi?id=49155 Attachment 81756: Patch with proposed fix https://issues.apache.org/ooo/attachment.cgi?id=81756&action=edit --- Additional Comments from Oliver-Rainer Wittmann patch looks good - I will integrate it into trunk for the next release. Ariel: Is this ok for you that I initiate the 'svn commit'? Additionally, I will try to enable 'above' option for graphic captions and drawing captions
[Bug 49155] Unwanted top distance after insertion of a caption for a graphic
https://issues.apache.org/ooo/show_bug.cgi?id=49155 --- Comment #9 from Oliver-Rainer Wittmann --- (In reply to Ariel Constenla-Haile from comment #8) > Ping orw. Can you take a look at the patch? Yes, I will - it is already on my todo list. Unfortunately, I did not find the time to have a review earlier, because I am busy with solving bug 33737. I hope I will have time next week. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
[Bug 49155] Unwanted top distance after insertion of a caption for a graphic
https://issues.apache.org/ooo/show_bug.cgi?id=49155 --- Comment #8 from Ariel Constenla-Haile --- Ping orw. Can you take a look at the patch? -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
[Bug 49155] Unwanted top distance after insertion of a caption for a graphic
https://issues.apache.org/ooo/show_bug.cgi?id=49155 --- Comment #7 from Ariel Constenla-Haile --- Note that the code was not taking into account the position of the caption (specified in bBefore) and was setting vertical orientation as css::text::VertOrientation::TOP. The fix takes this into account, although in practice the caption is always inserted bellow, because changing the position is disabled in the dialogues' code IMPL_LINK( SwCaptionOptPage, ShowEntryHdl, SvxCheckListBox *, EMPTYARG ) sw/source/ui/config/optload.cxx SwCaptionDialog::SwCaptionDialog( Window *pParent, SwView &rV ) sw/source/ui/config/optload.cxx This code could be enabled, it will allow inserting the caption "Above", what is part of another bug requesting this; but enabling it shows some problems (the frame hight is smaller than the graphic's), so this has to be fixed in a separated bug. Any way, taking into account bBefore in this bug is harmless. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
[Bug 49155] Unwanted top distance after insertion of a caption for a graphic
https://issues.apache.org/ooo/show_bug.cgi?id=49155 --- Comment #6 from Ariel Constenla-Haile --- Created attachment 81756 --> https://issues.apache.org/ooo/attachment.cgi?id=81756&action=edit Patch with proposed fix The patch takes Andreas' suggestion, changing the relative vertical orientation. Note that there was a bug in the way SwFmtVertOrient and SwFmtHoriOrient where constructed: in both cases, the orientation is the second parameter of the constructor (sw/inc/fmtornt.hxx) SwFmtVertOrient( SwTwips nY = 0, sal_Int16 eVert = com::sun::star::text::VertOrientation::NONE, sal_Int16 eRel = com::sun::star::text::RelOrientation::PRINT_AREA ); SwFmtHoriOrient( SwTwips nX = 0, sal_Int16 eHori = com::sun::star::text::HoriOrientation::NONE, sal_Int16 eRel = com::sun::star::text::RelOrientation::PRINT_AREA, sal_Bool bPos = sal_False ); but the code was omitting the first parameter. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
[Bug 49155] Unwanted top distance after insertion of a caption for a graphic
https://issues.apache.org/ooo/show_bug.cgi?id=49155 Ariel Constenla-Haile changed: What|Removed |Added Latest|--- |4.0.1 Confirmation on|| -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
[Bug 49155] Unwanted top distance after insertion of a caption for a graphic
https://issues.apache.org/ooo/show_bug.cgi?id=49155 Rob Weir changed: What|Removed |Added Target Milestone|4.2.0 |--- -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
