[Issue 125203] Showing wrong frame color since version 4.0.0

[bugzilla]

https://bz.apache.org/ooo/show_bug.cgi?id=125203

Peter  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED
 CC||pe...@apache.org

--- Comment #13 from Peter  ---
I think we can set this to confirmed.

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 125203] Showing wrong frame color since version 4.0.0

[bugzilla]

https://bz.apache.org/ooo/show_bug.cgi?id=125203

Muhammed Ibrahim  changed:

   What|Removed |Added

 CC||aminmuhamma...@gmail.com

--- Comment #12 from Muhammed Ibrahim  ---

Using a MacBook with MacOS High Sierra, I was able to reproduce this bug using
the file shared i.e. "The odt file that show this bug". I viewed the said file
on a Mac Version of Open Office 3.4.0 and the frame colour was black as
expected. And on viewing the same file on Open Office 4.1.6, the frame colour
was black just as reported.

I then attempted to reproduce this issue by creating a frame using Open Office
Writer 3.4.0 and view on Open Office Writer 4.1.6.

I created an odt file with a black frame using the following procedure:
 - Create a new file in Open Office Writer
 - Insert > Frame > Borders > Set All Four Borders > Line Style 2.50pt > OK
 - Save file

I opened the saved file on Open Office Writer 4.1.6 and was still able to view
the correct colour of the frame.

Based on these, i recommend that another file be shared and possibly share a
procedure for creating the said frame in order to reproduce this bug.

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 125203] Showing wrong frame color since version 4.0.0

[bugzilla]

https://bz.apache.org/ooo/show_bug.cgi?id=125203

--- Comment #11 from Juan Jose Torrez  ---
Created attachment 86111
  --> https://bz.apache.org/ooo/attachment.cgi?id=86111=edit
Screenshoot OO 4.1.3

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 125203] Showing wrong frame color since version 4.0.0

[bugzilla]

https://bz.apache.org/ooo/show_bug.cgi?id=125203

Juan Jose Torrez  changed:

   What|Removed |Added

 CC||juanjo.16071...@gmail.com

--- Comment #10 from Juan Jose Torrez  ---
Created attachment 86110
  --> https://bz.apache.org/ooo/attachment.cgi?id=86110=edit
Screenshoot OO 3.0.0

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 125203] Showing wrong frame color since version 4.0.0

[bugzilla]

https://issues.apache.org/ooo/show_bug.cgi?id=125203

Armin Le Grand armin.le.gr...@me.com changed:

   What|Removed |Added

   Assignee|iss...@openoffice.apache.or |armin.le.gr...@me.com
   |g   |

--- Comment #7 from Armin Le Grand armin.le.gr...@me.com ---
Grepping to keep in sight

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

[Issue 125203] Showing wrong frame color since version 4.0.0

[bugzilla]

https://issues.apache.org/ooo/show_bug.cgi?id=125203

--- Comment #6 from Armin Le Grand armin.le.gr...@me.com ---
Currently no svg:stroke-color is written when not set as hard attribute at draw
objects in writer (aka auto styles e.g. style:name=gr1). Also draw objects in
writer have no parent (aka style:parent-style-name). Also the pool defaults are
not written.
This is different from e.g. draw/impress where the auto-style and the parent
style are used and the graphic style 'default' exists holding the pool
defaults.
Writer and Calc have no styles for Drawinglayer GraphicObjects and thus only
auto-styles exist (containing the hard attributes). Both have also no pool
defaults as default graphic style.
Addendum: Calc has in styles a 'style:default-style style:family=graphic'
but with no name and I see no usage of it in the XML file. It does not contain
a whole set of graphic defaults.

What to do? At runtime the color for the line of graphic objects if not set as
hard attribute comes from the pool default. This is the value that has changed.
It is not represented in the files.

(a) Re-establish the different default for different apps
- file exchange between pre-AOO400 and current will work again
- still no representation in the files
- files created between AOO400 and now will show another line color

(b) Set the old defaults as hard attributes at import time
- file exchange between pre-AOO400 and current will work again
- next save will save the line color in the auto-style
- files created between AOO400 and now will show another line color

Since the color is not in the file it is implicit and depends on the AOO
version the file was saved with (argh). (b) may include a dynamic adaption at
load time to avoid the 3rd point.

Future: Styles for GraphicObjects should be implemented in Writer and Calc, but
that's no easy task. On load time the line color for default style will need to
be adapted dependent on AOO version which had file written and on auto-styles
already containing a color...

I would prefer (b) but this is no simple task, thus not sure for AOO411. Maybe
just live with a small (not much bugs seen for this) defect in file exchange
between pre-AOO400 versions and now. Another argument for this: If the object
outline had to have a defined color it was set by the user, is part of the auto
styles and the problem does not occur. In other words: Only if line color is
not touched will you see a change from black to gray.

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

[Issue 125203] Showing wrong frame color since version 4.0.0

[bugzilla]

https://issues.apache.org/ooo/show_bug.cgi?id=125203

--- Comment #3 from Armin Le Grand armin.le.gr...@me.com ---
The background is that traditionally Writer has *no* styles for Drawinglayer
objects at all, thus only the SfxItemPool containing the defaults for the items
has any effect. Thus there currently cannot be any style:parent-style-name in
writer files. This could be added, but would need the core implementation, UI
adaptions and all filter adaptions. Most of the difficulty comes from
Darw/Impress and Writer handling DrawingLayer object styles differently, thus
my opt for even thinking about this would be to start by unifying/cleaing up
style handling in draw/impress...
The result is indeed that the unification of the Drawinglayer SfxItemSet
defaults for 4.0 lead to changes. The unification tried to avoid that each app
changes 'some' defaults in the usage of the SfxItemPool for draw object which
leads to other problems (copying draw objects beween apps and others).
The question is how to fix that - one possibility being to add e.g. the old
default at load time as hard attribute. Suggestions?

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

[Issue 125203] Showing wrong frame color since version 4.0.0

[bugzilla]

https://issues.apache.org/ooo/show_bug.cgi?id=125203

--- Comment #4 from Ariel Constenla-Haile arie...@apache.org ---
(In reply to Armin Le Grand from comment #3).
 The question is how to fix that - one possibility being to add e.g. the old
 default at load time as hard attribute. Suggestions?

The other way around is also affected:

- In Writer 4.* draw an hexagon from the Basic Shapes toolbar, line color is
gray, fill color is blue classic

- open the document with OOo 3.*, the line color is black, the fill color is
blue 8.

If what you see in Writer is what you get when you store the document, looks
like it should also store all attributes.

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

[Issue 125203] Showing wrong frame color since version 4.0.0

[bugzilla]

https://issues.apache.org/ooo/show_bug.cgi?id=125203

--- Comment #5 from Ariel Constenla-Haile arie...@apache.org ---
Created attachment 83651
  -- https://issues.apache.org/ooo/attachment.cgi?id=83651action=edit
Screenshot of Fedora 20's default office suite

(In reply to Ariel Constenla-Haile from comment #4)
 The other way around is also affected:
 
 - In Writer 4.* draw an hexagon from the Basic Shapes toolbar, line color is
 gray, fill color is blue classic
 
 - open the document with OOo 3.*, the line color is black, the fill color is
 blue 8.

And if I open the document with another word processor, the one that comes by
default with Fedora 20, the hexagon looks with yes another fill and line
colors.

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

[Issue 125203] Showing wrong frame color since version 4.0.0

[bugzilla]

https://issues.apache.org/ooo/show_bug.cgi?id=125203

--- Comment #1 from Ariel Constenla-Haile arie...@apache.org ---
This is likely due to the enhancement made for bug 121448
See bug 122109 and bug 122583

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

[Issue 125203] Showing wrong frame color since version 4.0.0

[bugzilla]

https://issues.apache.org/ooo/show_bug.cgi?id=125203

Ariel Constenla-Haile arie...@apache.org changed:

   What|Removed |Added

 CC||armin.le.gr...@me.com
 OS|Linux32 |All
   Severity|critical|normal

--- Comment #2 from Ariel Constenla-Haile arie...@apache.org ---
The draw:rect has draw:style-name=gr2
The style gr2 has no svg:stroke-color, thus OpenOffice displays the new
default.

In Draw this bug is likely not to happen (despite bug 122109) because all
automatic graphic styles have a default parent style, and the definition of
this parent style includes the stroke color, and this information is all stored
in the file.

The lack of a style:parent-style-name in Writer's graphic styles looks like a
bug.
Setting Armin on cc.

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.