[GitHub] [openwhisk-runtime-dotnet] kamyker commented on issue #26: Raw requests to skip JObject conversion

2019-11-27 Thread GitBox 
kamyker commented on issue #26: Raw requests to skip JObject conversion
URL: 
https://github.com/apache/openwhisk-runtime-dotnet/issues/26#issuecomment-559297610
 
 
   Then same definition as AWS has:
   `public async Task Main(Stream stream)`
   
   That's probably even faster than string as Stream can be directly assigned 
to HttpResponse.Body


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-runtime-dotnet] rabbah commented on issue #26: Raw requests to skip JObject conversion

2019-11-27 Thread GitBox 
rabbah commented on issue #26: Raw requests to skip JObject conversion
URL: 
https://github.com/apache/openwhisk-runtime-dotnet/issues/26#issuecomment-559295710
 
 
   Indeed - that would be cleaner. It would be nicer if the output was also a 
stream/symmetric. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-runtime-dotnet] kamyker commented on issue #26: Raw requests to skip JObject conversion

2019-11-27 Thread GitBox 
kamyker commented on issue #26: Raw requests to skip JObject conversion
URL: 
https://github.com/apache/openwhisk-runtime-dotnet/issues/26#issuecomment-559295328
 
 
   I guess HttpRequest is not needed just body of it - HttpRequest.InputStream
   `public async Task Main(Stream request)`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-runtime-dotnet] rabbah commented on issue #25: Async task

2019-11-27 Thread GitBox 
rabbah commented on issue #25: Async task
URL: 
https://github.com/apache/openwhisk-runtime-dotnet/pull/25#issuecomment-559288316
 
 
   @shawnallen85 I approved the PR but please update the change logs to remove 
"future" release which hasn't happened yet. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-runtime-dotnet] rabbah commented on a change in pull request #25: Async task

2019-11-27 Thread GitBox 
rabbah commented on a change in pull request #25: Async task
URL: 
https://github.com/apache/openwhisk-runtime-dotnet/pull/25#discussion_r351538987
 
 

 ##
 File path: core/dotnet2.2/CHANGELOG.md
 ##
 @@ -23,3 +23,15 @@
 ## 1.13
 Changes:
 - Initial release
+
+## 1.14
 
 Review comment:
   @shawnallen85 we need to remove these change notes until there is an actual 
release of the runtime.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-runtime-dotnet] rabbah commented on a change in pull request #25: Async task

2019-11-27 Thread GitBox 
rabbah commented on a change in pull request #25: Async task
URL: 
https://github.com/apache/openwhisk-runtime-dotnet/pull/25#discussion_r351539211
 
 

 ##
 File path: core/dotnet3.0/CHANGELOG.md
 ##
 @@ -23,3 +23,12 @@
 ## 1.14 (next Apache release)
 
 Review comment:
   same - it's better to wait until the actual release vote.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-runtime-dotnet] rabbah commented on issue #25: Async task

2019-11-27 Thread GitBox 
rabbah commented on issue #25: Async task
URL: 
https://github.com/apache/openwhisk-runtime-dotnet/pull/25#issuecomment-559287860
 
 
   Thanks @kamyker!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-runtime-dotnet] kamyker commented on issue #25: Async task

2019-11-27 Thread GitBox 
kamyker commented on issue #25: Async task
URL: 
https://github.com/apache/openwhisk-runtime-dotnet/pull/25#issuecomment-559287136
 
 
   Looks good


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-runtime-dotnet] rabbah commented on a change in pull request #25: Async task

2019-11-27 Thread GitBox 
rabbah commented on a change in pull request #25: Async task
URL: 
https://github.com/apache/openwhisk-runtime-dotnet/pull/25#discussion_r351535064
 
 

 ##
 File path: core/dotnet2.2/CHANGELOG.md
 ##
 @@ -23,3 +23,15 @@
 ## 1.13
 Changes:
 - Initial release
+
+## 1.14
+Changes:
+- Support for async methods. Example:
+
+```csharp
+public async Task MainAsync(JObject args)
+{
+await Task.Delay(10); // Just do a delay to have an async/await 
process occur.
+return (args);
 
 Review comment:
    that's how much `c#` i know :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-runtime-dotnet] rabbah commented on issue #26: Raw requests to skip JObject conversion

2019-11-27 Thread GitBox 
rabbah commented on issue #26: Raw requests to skip JObject conversion
URL: 
https://github.com/apache/openwhisk-runtime-dotnet/issues/26#issuecomment-559283977
 
 
   In general the downside of this approach is breaking the openwhisk json 
in/json out abstraction. Worse directly exposing the http request object while 
performant breaks the "serverless" abstraction. It would be better to pass in a 
streamable buffer for i/o. We have moved toward something similar with a piped 
approach for function i/o.
   
   You can certainly do this with a custom dotnet runtime. I think this would 
be worthwhile to also raise on the Apache OpenWhisk dev list.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-runtime-dotnet] kamyker commented on a change in pull request #25: Async task

2019-11-27 Thread GitBox 
kamyker commented on a change in pull request #25: Async task
URL: 
https://github.com/apache/openwhisk-runtime-dotnet/pull/25#discussion_r351534538
 
 

 ##
 File path: core/dotnet2.2/CHANGELOG.md
 ##
 @@ -23,3 +23,15 @@
 ## 1.13
 Changes:
 - Initial release
+
+## 1.14
+Changes:
+- Support for async methods. Example:
+
+```csharp
+public async Task MainAsync(JObject args)
+{
+await Task.Delay(10); // Just do a delay to have an async/await 
process occur.
+return (args);
 
 Review comment:
   no, no, Task.Run is only used in sync methods


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-runtime-dotnet] rabbah commented on issue #22: Add async/await support

2019-11-27 Thread GitBox 
rabbah commented on issue #22: Add async/await support
URL: 
https://github.com/apache/openwhisk-runtime-dotnet/issues/22#issuecomment-559283354
 
 
   @kamyker are you able to review this PR 
https://github.com/apache/openwhisk-runtime-dotnet/pull/25 which adds async 
support?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-runtime-dotnet] rabbah commented on a change in pull request #25: Async task

2019-11-27 Thread GitBox 
rabbah commented on a change in pull request #25: Async task
URL: 
https://github.com/apache/openwhisk-runtime-dotnet/pull/25#discussion_r351533784
 
 

 ##
 File path: core/dotnet2.2/CHANGELOG.md
 ##
 @@ -23,3 +23,15 @@
 ## 1.13
 Changes:
 - Initial release
+
+## 1.14
+Changes:
+- Support for async methods. Example:
+
+```csharp
+public async Task MainAsync(JObject args)
+{
+await Task.Delay(10); // Just do a delay to have an async/await 
process occur.
+return (args);
 
 Review comment:
   shouldn't there be a Task.run somewhere for the awaitable method?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] rabbah commented on issue #4593: Change ContainerPool buffer processing

2019-11-27 Thread GitBox 
rabbah commented on issue #4593: Change ContainerPool buffer processing 
URL: https://github.com/apache/openwhisk/pull/4593#issuecomment-559282377
 
 
   I've gone through this change once. I think it's sound but want to make a 
second pass.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-runtime-dotnet] kamyker edited a comment on issue #22: Add async/await support

2019-11-27 Thread GitBox 
kamyker edited a comment on issue #22: Add async/await support
URL: 
https://github.com/apache/openwhisk-runtime-dotnet/issues/22#issuecomment-559230796
 
 
   Btw if someone needs async before this feature is available (for ex. in IBM) 
it's possible to instead:
   `var result = await SomeAsyncFunc();`
   do:
   `var result = SomeAsyncFunc().GetAwaiter().GetResult();`
   Not very efficient as it will use new thread and can prob deadlock in very 
high usage scenarios but  fine in my use case.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-runtime-dotnet] kamyker edited a comment on issue #22: Add async/await support

2019-11-27 Thread GitBox 
kamyker edited a comment on issue #22: Add async/await support
URL: 
https://github.com/apache/openwhisk-runtime-dotnet/issues/22#issuecomment-559230796
 
 
   Btw if someone needs async before this feature is available (for ex. in IBM) 
it's possible to instead:
   `var result = await SomeAsyncFunc();`
   do:
   `var result = SomeAsyncFunc().GetAwaiter().GetResult();`
   Not very efficient as it will use new thread and can prob deadlock in very 
high usage scenarios but I fine in my use case.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-runtime-dotnet] kamyker commented on issue #22: Add async/await support

2019-11-27 Thread GitBox 
kamyker commented on issue #22: Add async/await support
URL: 
https://github.com/apache/openwhisk-runtime-dotnet/issues/22#issuecomment-559230796
 
 
   Btw if someone needs async before this feature is available (for ex. in IBM) 
it's possible to instead:
   `var result = await SomeAsyncFunc();`
   do:
   `var result = SomeAsyncFunc().GetAwaiter().GetResult();`
   Not very efficient as it will use new thread and can prob deadlock in very 
high usage scenarios.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] markusthoemmes commented on issue #4736: Update pureconfig to version 0.11.1.

2019-11-27 Thread GitBox 
markusthoemmes commented on issue #4736: Update pureconfig to version 0.11.1.
URL: https://github.com/apache/openwhisk/pull/4736#issuecomment-559139635
 
 
   @chetanmeh finally did it! This is ready to review now. I'll update the PR 
against the mesos actor to only bump to 0.11 as well.
   
   0.12 is a different beast entirely.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] codecov-io edited a comment on issue #4736: Update pureconfig to version 0.11.1.

2019-11-27 Thread GitBox 
codecov-io edited a comment on issue #4736: Update pureconfig to version 0.11.1.
URL: https://github.com/apache/openwhisk/pull/4736#issuecomment-559129805
 
 
   # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4736?src=pr=h1) 
Report
   > Merging 
[#4736](https://codecov.io/gh/apache/openwhisk/pull/4736?src=pr=desc) into 
[master](https://codecov.io/gh/apache/openwhisk/commit/0f8ee7d9a400da61cbafce77b393678d22c179df?src=pr=desc)
 will **decrease** coverage by `5.31%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/openwhisk/pull/4736/graphs/tree.svg?width=650=l0YmsiSAso=150=pr)](https://codecov.io/gh/apache/openwhisk/pull/4736?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #4736  +/-   ##
   =
   - Coverage   83.61%   78.3%   -5.32% 
   =
 Files 198 198  
 Lines88308830  
 Branches  619 611   -8 
   =
   - Hits 73836914 -469 
   - Misses   14471916 +469
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/openwhisk/pull/4736?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...che/openwhisk/core/yarn/YARNContainerFactory.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUveWFybi9ZQVJOQ29udGFpbmVyRmFjdG9yeS5zY2FsYQ==)
 | `87.5% <ø> (ø)` | :arrow_up: |
   | 
[...pache/openwhisk/core/entity/ConcurrencyLimit.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L0NvbmN1cnJlbmN5TGltaXQuc2NhbGE=)
 | `94.11% <ø> (+5.88%)` | :arrow_up: |
   | 
[...org/apache/openwhisk/core/entity/MemoryLimit.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L01lbW9yeUxpbWl0LnNjYWxh)
 | `93.75% <ø> (ø)` | :arrow_up: |
   | 
[...openwhisk/common/tracing/OpenTracingProvider.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi90cmFjaW5nL09wZW5UcmFjaW5nUHJvdmlkZXIuc2NhbGE=)
 | `21.15% <ø> (ø)` | :arrow_up: |
   | 
[...whisk/connector/kafka/KafkaConsumerConnector.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYUNvbnN1bWVyQ29ubmVjdG9yLnNjYWxh)
 | `59.15% <ø> (ø)` | :arrow_up: |
   | 
[...abase/ArtifactWithFileStorageActivationStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvQXJ0aWZhY3RXaXRoRmlsZVN0b3JhZ2VBY3RpdmF0aW9uU3RvcmUuc2NhbGE=)
 | `91.66% <ø> (ø)` | :arrow_up: |
   | 
[...a/org/apache/openwhisk/core/entity/TimeLimit.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1RpbWVMaW1pdC5zY2FsYQ==)
 | `95.65% <ø> (ø)` | :arrow_up: |
   | 
[...sk/core/containerpool/logging/SplunkLogStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9sb2dnaW5nL1NwbHVua0xvZ1N0b3JlLnNjYWxh)
 | `84.61% <ø> (ø)` | :arrow_up: |
   | 
[.../containerpool/logging/ElasticSearchLogStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9sb2dnaW5nL0VsYXN0aWNTZWFyY2hMb2dTdG9yZS5zY2FsYQ==)
 | `96.15% <ø> (ø)` | :arrow_up: |
   | 
[...e/loadBalancer/ShardingContainerPoolBalancer.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvbG9hZEJhbGFuY2VyL1NoYXJkaW5nQ29udGFpbmVyUG9vbEJhbGFuY2VyLnNjYWxh)
 | `88.7% <ø> (ø)` | :arrow_up: |
   | ... and [83 
more](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/openwhisk/pull/4736?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/openwhisk/pull/4736?src=pr=footer). 
Last update 
[0f8ee7d...140aa24](https://codecov.io/gh/apache/openwhisk/pull/4736?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

[GitHub] [openwhisk] codecov-io commented on issue #4736: Update pureconfig to version 0.11.1.

2019-11-27 Thread GitBox 
codecov-io commented on issue #4736: Update pureconfig to version 0.11.1.
URL: https://github.com/apache/openwhisk/pull/4736#issuecomment-559129805
 
 
   # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4736?src=pr=h1) 
Report
   > Merging 
[#4736](https://codecov.io/gh/apache/openwhisk/pull/4736?src=pr=desc) into 
[master](https://codecov.io/gh/apache/openwhisk/commit/0f8ee7d9a400da61cbafce77b393678d22c179df?src=pr=desc)
 will **decrease** coverage by `5.31%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/openwhisk/pull/4736/graphs/tree.svg?width=650=l0YmsiSAso=150=pr)](https://codecov.io/gh/apache/openwhisk/pull/4736?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #4736  +/-   ##
   =
   - Coverage   83.61%   78.3%   -5.32% 
   =
 Files 198 198  
 Lines88308830  
 Branches  619 611   -8 
   =
   - Hits 73836914 -469 
   - Misses   14471916 +469
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/openwhisk/pull/4736?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...che/openwhisk/core/yarn/YARNContainerFactory.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUveWFybi9ZQVJOQ29udGFpbmVyRmFjdG9yeS5zY2FsYQ==)
 | `87.5% <ø> (ø)` | :arrow_up: |
   | 
[...pache/openwhisk/core/entity/ConcurrencyLimit.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L0NvbmN1cnJlbmN5TGltaXQuc2NhbGE=)
 | `94.11% <ø> (+5.88%)` | :arrow_up: |
   | 
[...org/apache/openwhisk/core/entity/MemoryLimit.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L01lbW9yeUxpbWl0LnNjYWxh)
 | `93.75% <ø> (ø)` | :arrow_up: |
   | 
[...openwhisk/common/tracing/OpenTracingProvider.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi90cmFjaW5nL09wZW5UcmFjaW5nUHJvdmlkZXIuc2NhbGE=)
 | `21.15% <ø> (ø)` | :arrow_up: |
   | 
[...whisk/connector/kafka/KafkaConsumerConnector.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYUNvbnN1bWVyQ29ubmVjdG9yLnNjYWxh)
 | `59.15% <ø> (ø)` | :arrow_up: |
   | 
[...abase/ArtifactWithFileStorageActivationStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvQXJ0aWZhY3RXaXRoRmlsZVN0b3JhZ2VBY3RpdmF0aW9uU3RvcmUuc2NhbGE=)
 | `91.66% <ø> (ø)` | :arrow_up: |
   | 
[...a/org/apache/openwhisk/core/entity/TimeLimit.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1RpbWVMaW1pdC5zY2FsYQ==)
 | `95.65% <ø> (ø)` | :arrow_up: |
   | 
[...sk/core/containerpool/logging/SplunkLogStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9sb2dnaW5nL1NwbHVua0xvZ1N0b3JlLnNjYWxh)
 | `84.61% <ø> (ø)` | :arrow_up: |
   | 
[.../containerpool/logging/ElasticSearchLogStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9sb2dnaW5nL0VsYXN0aWNTZWFyY2hMb2dTdG9yZS5zY2FsYQ==)
 | `96.15% <ø> (ø)` | :arrow_up: |
   | 
[...e/loadBalancer/ShardingContainerPoolBalancer.scala](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvbG9hZEJhbGFuY2VyL1NoYXJkaW5nQ29udGFpbmVyUG9vbEJhbGFuY2VyLnNjYWxh)
 | `88.7% <ø> (ø)` | :arrow_up: |
   | ... and [83 
more](https://codecov.io/gh/apache/openwhisk/pull/4736/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/openwhisk/pull/4736?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/openwhisk/pull/4736?src=pr=footer). 
Last update 
[0f8ee7d...140aa24](https://codecov.io/gh/apache/openwhisk/pull/4736?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

[GitHub] [openwhisk] markusthoemmes closed pull request #4734: Update gradle wrapper to 6.0.1.

2019-11-27 Thread GitBox 
markusthoemmes closed pull request #4734: Update gradle wrapper to 6.0.1.
URL: https://github.com/apache/openwhisk/pull/4734
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] markusthoemmes commented on issue #4734: Update gradle wrapper to 6.0.1.

2019-11-27 Thread GitBox 
markusthoemmes commented on issue #4734: Update gradle wrapper to 6.0.1.
URL: https://github.com/apache/openwhisk/pull/4734#issuecomment-559032082
 
 
   Gonna close this for now, might revisit at a later stage.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-wskdeploy] alvarolopez commented on issue #1057: Support Description field in corresponding entities

2019-11-27 Thread GitBox 
alvarolopez commented on issue #1057: Support Description field in 
corresponding entities
URL: 
https://github.com/apache/openwhisk-wskdeploy/pull/1057#issuecomment-558993968
 
 
   @mrutkows I forgot to reply to you: we're fine with not storing the 
description at server-side, but having it as part of the schema so that every 
action can include a description. Many thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services