[GitHub] [openwhisk] sciabarracom commented on pull request #5361: GitHub action [WIP]

[GitBox]

sciabarracom commented on PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#issuecomment-1345177195

   Yes I see in the scripts there is a "box-upload.py" script uploading them to 
a wired-in path.
   I am going to add also s3 upload so if you provide your keys it will upload 
to s3 instead.
   
   -- 
 Michele Sciabarra
 ***@***.***
   
   
   - Original message -
   From: Dominic Kim ***@***.***>
   To: apache/openwhisk ***@***.***>
   Cc: Subscribed ***@***.***>
   Subject: Re: [apache/openwhisk] GitHub action [WIP] (PR #5361)
   Date: Saturday, December 10, 2022 1:10 AM
   
   
   
   
   Logs are uploaded to IBM Bluemix.
   
https://github.com/apache/openwhisk/blob/master/tools/travis/box-upload.py#L46
   
   
   We need to see if this is still valid.
   I also have no access to the logs.
   
   @dgrove-oss , could you confirm if we can 
still use Bluemix to upload logs?
   
   
   —
   Reply to this email directly, view it on GitHub 
, or 
unsubscribe 
.
   You are receiving this because you are subscribed to this thread.Message ID: 
***@***.***>
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action [WIP]

[GitBox]

msciabarra commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1045018310


##
.github/workflows/performance.yaml:
##
@@ -0,0 +1,71 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+name: Performance Tests
+on:
+  push:
+
+env:
+  # uncomment this to enable an ngrok access to the vm on test failure
+  # enabling this you will get an ssh command to access the vm, active for one 
hour
+  #NGROK_DEBUG: yes
+  # you need to add as secrets an ngrok token and a password to access the 
terminal 
+  NGROK_TOKEN: ${{ secrets.NGROK_TOKEN }}

Review Comment:
   Yes but the NGROK account is free for one connection.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action [WIP]

[GitBox]

msciabarra commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1045018230


##
.github/workflows/unit.yaml:
##
@@ -0,0 +1,62 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+name: Unit Tests
+on:
+  push:
+
+env:
+  # uncomment this to enable an ngrok access to the vm on test failure
+  # enabling this you will get an ssh command to access the vm, active for one 
hour
+  #NGROK_DEBUG: yes

Review Comment:
   Yes. I already made it optional and you can enable it triggering it 
explicitly.
   You can run it on your fork.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [openwhisk] style95 commented on issue #5359: Misleading error reporting of a working docker action in cold starts?

[GitBox]

style95 commented on issue #5359:
URL: https://github.com/apache/openwhisk/issues/5359#issuecomment-1344966068

   > Does Openwhisk try to /init before the server inside the container is up
   
   AFAIK, there is no such case with the standard OW runtimes.
   How much time does it take for your server to be up?
   
   IIRC, OW does not check if those two endpoints are available before calling 
them.
   But there are also some runtimes that bootup takes some time like java but 
no error happened so far.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [openwhisk] style95 commented on pull request #5361: GitHub action [WIP]

[GitBox]

style95 commented on PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#issuecomment-1344958772

   Logs are uploaded to IBM Bluemix.
   
https://github.com/apache/openwhisk/blob/master/tools/travis/box-upload.py#L46
   
   We need to see if this is still valid.
   I also have no access to the logs.
   
   @dgrove-oss, could you confirm if we can still use Bluemix to upload logs?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [openwhisk] style95 commented on a diff in pull request #5361: GitHub action [WIP]

[GitBox]

style95 commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1044937654


##
.github/workflows/unit.yaml:
##
@@ -0,0 +1,62 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+name: Unit Tests
+on:
+  push:
+
+env:
+  # uncomment this to enable an ngrok access to the vm on test failure
+  # enabling this you will get an ssh command to access the vm, active for one 
hour
+  #NGROK_DEBUG: yes

Review Comment:
   Can we make this selectively enabled in the core repo by those who have 
permission?
   IIRC, Travis does not enable the debug mode by default because secrets can 
be revealed.
   (Though I am not sure there are any secrets with GHA too.)
   If there are any, then we may need to keep them safe.



##
.github/workflows/performance.yaml:
##
@@ -0,0 +1,71 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+name: Performance Tests
+on:
+  push:
+
+env:
+  # uncomment this to enable an ngrok access to the vm on test failure
+  # enabling this you will get an ssh command to access the vm, active for one 
hour
+  #NGROK_DEBUG: yes
+  # you need to add as secrets an ngrok token and a password to access the 
terminal 
+  NGROK_TOKEN: ${{ secrets.NGROK_TOKEN }}

Review Comment:
   Does this imply those who need debugging should sign up for Ngrok?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org