[GitHub] [openwhisk] msciabarra commented on pull request #5361: GitHub action

2022-12-12 Thread GitBox


msciabarra commented on PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#issuecomment-1347870420

   Now I have unit, multiruntime and standalone test passing and system only 
failing one test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [openwhisk] msciabarra commented on pull request #5361: GitHub action

2022-12-12 Thread GitBox


msciabarra commented on PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#issuecomment-1347200248

   I fixed the error in the aws storage renaming a secret to AWS_BUCKET, and 
the error in system forcing a corresponding java version. I had to "slightly" 
update the version of openj9 used to use one that can be actually downloaded 
(11.0.8 -> 11.0.12)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [openwhisk-runtime-docker] dgrove-oss closed pull request #96: Icontrol 1

2022-12-12 Thread GitBox


dgrove-oss closed pull request #96: Icontrol 1
URL: https://github.com/apache/openwhisk-runtime-docker/pull/96


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

2022-12-12 Thread GitBox


msciabarra commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1046228883


##
ansible/group_vars/all:
##
@@ -551,5 +551,3 @@ scheduler:
 throttlingFraction: "{{ scheduler_queue_throttlingFraction | default(0.9) 
}}"
 durationBufferSize: "{{ scheduler_queue_durationBufferSize | default(10) 
}}"
   deployment_ignore_error: "{{ scheduler_deployment_ignore_error | 
default('False') }}"
-  dataManagementService:

Review Comment:
   Yes. It gives a duplicate warning.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [openwhisk] bdoyle0182 commented on a diff in pull request #5361: GitHub action

2022-12-12 Thread GitBox


bdoyle0182 commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1046227267


##
ansible/group_vars/all:
##
@@ -551,5 +551,3 @@ scheduler:
 throttlingFraction: "{{ scheduler_queue_throttlingFraction | default(0.9) 
}}"
 durationBufferSize: "{{ scheduler_queue_durationBufferSize | default(10) 
}}"
   deployment_ignore_error: "{{ scheduler_deployment_ignore_error | 
default('False') }}"
-  dataManagementService:

Review Comment:
   is this intended to be removed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [openwhisk] msciabarra commented on pull request #5361: GitHub action

2022-12-12 Thread GitBox


msciabarra commented on PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#issuecomment-1346157570

   The workflow does not run and it is not visibile until it is available on 
the default branch so it shoud be merged. However currently the do not run 
unless you trigger them manually or push a tag. So we can test them merging and 
triggering manually. Or you can merge them in a fork as I am doing here 
(https://github.com/msciabarra/openwhisk/)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [openwhisk] style95 commented on pull request #5361: GitHub action

2022-12-12 Thread GitBox


style95 commented on PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#issuecomment-1346147920

   How can we test this change?
   It seems the GitHub workflow is not running on this repo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org