[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action
msciabarra commented on code in PR #5361: URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1050460516 ## tests/src/test/scala/org/apache/openwhisk/core/containerpool/v2/test/ActivationClientProxyTests.scala: ## @@ -15,6 +15,7 @@ * limitations under the License. */ +/* Review Comment: it was an attempt to pass the travis build to merge... but looks like it does not work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [openwhisk] style95 commented on a diff in pull request #5361: GitHub action
style95 commented on code in PR #5361: URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1050367320 ## tools/github/setup.sh: ## @@ -0,0 +1,79 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +#if [[ $TEST_SUITE =~ Dummy ]] Review Comment: Can we control whether to run these dummy tests like this?  Also, there is the same code block, so can we delete these comments? https://github.com/apache/openwhisk/pull/5361/files#diff-fc5257f5200a46b6baab3ca657b694cc84dc77e3a5f9d71062b25fce994c02b4R70 ## tests/src/test/scala/org/apache/openwhisk/core/containerpool/v2/test/ActivationClientProxyTests.scala: ## @@ -15,6 +15,7 @@ * limitations under the License. */ +/* Review Comment: Why is this test commented? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action
msciabarra commented on code in PR #5361: URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1050363178 ## tools/github/setup.sh: ## @@ -0,0 +1,79 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +#if [[ $TEST_SUITE =~ Dummy ]] Review Comment: it is already there...if you launvh the dummy build and enable ngrok in a few second you get an ssh command to get into the vm with everythingalready setup to build and test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [openwhisk] dgrove-oss merged pull request #5364: drop travis from required checks to merge a PR
dgrove-oss merged PR #5364: URL: https://github.com/apache/openwhisk/pull/5364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [openwhisk] style95 commented on a diff in pull request #5361: GitHub action
style95 commented on code in PR #5361: URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1050254416 ## tools/github/setup.sh: ## @@ -0,0 +1,79 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +#if [[ $TEST_SUITE =~ Dummy ]] Review Comment: I love this idea to skip tests for debugging. How about making this as an input as well just like debugging enablement option so that users can easily trigger this feature without changing any code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [openwhisk] style95 commented on a diff in pull request #5361: GitHub action
style95 commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1050253894
##
tools/github/setup.sh:
##
@@ -0,0 +1,79 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+#if [[ $TEST_SUITE =~ Dummy ]]
+#then echo skipping setup ; exit 0
+#fi
+
+# retries a command for five times and exits with the non-zero exit if even
after
+# the retries the command did not succeed.
+function retry() {
+ local exitcode=0
+ for i in {1..5};
+ do
+exitcode=0
+"$@" && break || exitcode=$? && echo "$i. attempt failed. Will retry
$((5-i)) more times!" && sleep 1;
+ done
+ if [ $exitcode -ne 0 ]; then
+exit $exitcode
+ fi
+}
+
+# setup docker to listen in port 4243
+sudo systemctl stop docker
+sudo sed -i -e 's!/usr/bin/dockerd -H fd://!/usr/bin/dockerd -H
tcp://0.0.0.0:4243 -H fd://!' /lib/systemd/system/docker.service
Review Comment:
Thank you for confirming that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action
msciabarra commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1049618814
##
tools/github/setup.sh:
##
@@ -0,0 +1,79 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+#if [[ $TEST_SUITE =~ Dummy ]]
+#then echo skipping setup ; exit 0
+#fi
+
+# retries a command for five times and exits with the non-zero exit if even
after
+# the retries the command did not succeed.
+function retry() {
+ local exitcode=0
+ for i in {1..5};
+ do
+exitcode=0
+"$@" && break || exitcode=$? && echo "$i. attempt failed. Will retry
$((5-i)) more times!" && sleep 1;
+ done
+ if [ $exitcode -ne 0 ]; then
+exit $exitcode
+ fi
+}
+
+# setup docker to listen in port 4243
+sudo systemctl stop docker
+sudo sed -i -e 's!/usr/bin/dockerd -H fd://!/usr/bin/dockerd -H
tcp://0.0.0.0:4243 -H fd://!' /lib/systemd/system/docker.service
Review Comment:
I tried to run tests without this change but some tests (coverage tests)
fails.
So I would keep the open door for Docker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
