[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action [WIP]
msciabarra commented on code in PR #5361:
URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1045018310
##
.github/workflows/performance.yaml:
##
@@ -0,0 +1,71 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+name: Performance Tests
+on:
+ push:
+
+env:
+ # uncomment this to enable an ngrok access to the vm on test failure
+ # enabling this you will get an ssh command to access the vm, active for one
hour
+ #NGROK_DEBUG: yes
+ # you need to add as secrets an ngrok token and a password to access the
terminal
+ NGROK_TOKEN: ${{ secrets.NGROK_TOKEN }}
Review Comment:
Yes but the NGROK account is free for one connection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action [WIP]
msciabarra commented on code in PR #5361: URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1045018230 ## .github/workflows/unit.yaml: ## @@ -0,0 +1,62 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +name: Unit Tests +on: + push: + +env: + # uncomment this to enable an ngrok access to the vm on test failure + # enabling this you will get an ssh command to access the vm, active for one hour + #NGROK_DEBUG: yes Review Comment: Yes. I already made it optional and you can enable it triggering it explicitly. You can run it on your fork. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
