[GitHub] [openwhisk] msciabarra commented on pull request #5366: making optional logs upload and slack notification, and showing test results in the job run

2022-12-20 Thread GitBox


msciabarra commented on PR #5366:
URL: https://github.com/apache/openwhisk/pull/5366#issuecomment-1360396541

   forget about this - I misunderstood a few things - restarting the patch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [openwhisk] msciabarra commented on pull request #5366: making optional logs upload and slack notification, and showing test results in the job run

2022-12-20 Thread GitBox


msciabarra commented on PR #5366:
URL: https://github.com/apache/openwhisk/pull/5366#issuecomment-1360374551

   Hi I made a few changes, mostly I made the s3 test skipped it the bucket is 
not available, fixed a compilation error and now the build works. Can you merge?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [openwhisk] msciabarra commented on pull request #5366: making optional logs upload and slack notification, and showing test results in the job run

2022-12-19 Thread GitBox


msciabarra commented on PR #5366:
URL: https://github.com/apache/openwhisk/pull/5366#issuecomment-1357544635

   Yes true. AWS S3 tests are NOW failing, and I guess this is happening simply 
because someone removed the AWS_BUCKET secret that was there before. I used the 
bucket to upload logs there and I am sure he was not happy.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org