[GitHub] [openwhisk] sciabarracom commented on pull request #5367: fixes to use different secrets, show the results in the log
sciabarracom commented on PR #5367: URL: https://github.com/apache/openwhisk/pull/5367#issuecomment-1362418878 > BTW, if we change the variable, how can we test the S3 uploading tests? we cannot test it anyway and they are not tested with travis - secrets are not passed to pull requests (otherwise it would be trivial to grab them, just make a pull request that dumps and writes them somewhere) you can test them only locally and if you have all the expected environment variables, what I did wrong was to use the environment variables that activated the tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [openwhisk] sciabarracom commented on pull request #5367: fixes to use different secrets, show the results in the log
sciabarracom commented on PR #5367: URL: https://github.com/apache/openwhisk/pull/5367#issuecomment-1360909057 My github actions pass the AWS_ACCESS_ID secrets to the build but since they are pull requests they are empty. This enables some tests and make some of them fail. So I changed the name of the variables used to upload logs. Furthermore I made optional the upload of logs and slack notification and printed the results of the tes in the job run for inspection. Now all test pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
