[GitHub] [openwhisk-catalog] fribechi commented on a change in pull request #321: Enhance github webhook endpoint to allow github enterprise api usage

[GitBox]

fribechi commented on a change in pull request #321:
URL: https://github.com/apache/openwhisk-catalog/pull/321#discussion_r636685288



##
File path: packages/github/manifest.yaml
##
@@ -55,11 +55,18 @@ project:
 "required": true,
 "description": "A comma-separated list",
 "doclink": 
"https://developer.github.com/webhooks/#events;
+},
+{
+"name": "baseUrl",
+"required": false,
+"description": "github Api endpoint",

Review comment:
   Modified




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [openwhisk-catalog] fribechi commented on a change in pull request #321: Enhance github webhook endpoint to allow github enterprise api usage

[GitBox]

fribechi commented on a change in pull request #321:
URL: https://github.com/apache/openwhisk-catalog/pull/321#discussion_r636273724



##
File path: packages/github/README.md
##
@@ -38,6 +38,7 @@ The `/whisk.system/github/webhook` feed configures a service 
to fire a trigger w
 - `repository`: The GitHub repository.
 - `accessToken`: Your GitHub personal access token.
 - `events`: The [GitHub event 
type](https://developer.github.com/v3/activity/events/types/) of interest.
+- `githubApi`: The GitHub api endpoint. Default value is 'api.github.com'. 

Review comment:
   I changed in baseUrl




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org