[GitHub] rabbah commented on issue #2567: Openwhisk Local Installation on Ubuntu 14 Failed !!! Please help

2017-08-08 Thread git
rabbah commented on issue #2567: Openwhisk Local Installation on Ubuntu 14 
Failed !!! Please help
URL: 
https://github.com/apache/incubator-openwhisk/issues/2567#issuecomment-321144036
 
 
   check that your /tmp/nginx directory is not owned by root - if it is delete 
it and redeploy nginx.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] lzbj opened a new pull request #310: Support both manifest.yaml and manifest.yml

2017-08-08 Thread git
lzbj opened a new pull request #310: Support both manifest.yaml and manifest.yml
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/310
 
 
   Mitigate same variable copy around.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ningyougang opened a new pull request #2594: Fix bug on ansible variable db_prefix

2017-08-08 Thread git
ningyougang opened a new pull request #2594: Fix bug on ansible variable 
db_prefix
URL: https://github.com/apache/incubator-openwhisk/pull/2594
 
 
   if `ansible node` and `target node` is not the same node, it will have 
problem.
   ```
   - include: db/recreateDb.yml
 vars:
   dbName: "{{ db.whisk.auth }}"
   forceRecreation: False
   ```
   the `db.whisk.auth` reference varaible : `db_prefix`, the `db_prefix` value 
is `ansible node`'s  `{{ ansible_user_id|lower }}_{{ ansible_hostname|lower }}_`
   
   ```
   - name: (re)start controller
 docker_container:
   name: controller{{ groups['controllers'].index(inventory_hostname) }}
   env:
  "DB_WHISK_AUTHS": "{{ db.whisk.auth }}"
  ...
  ...
```
   But above ansible task's  `db.whisk.auth`'s `db_prefix` value is `controller 
node`'s  `{{ ansible_user_id|lower }}_{{ ansible_hostname|lower }}_`
   
   So if `ansible node` is not same as `controller node`, the controller's ENV 
`DB_WHISK_AUTHS` will reference a `not exist auth db address`. 
   So it is better to write the `db_prefix` value to hardcode to keep the 
default running env well.
   If you don't like the `db_prefix` value, can change it what you like.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] mhamann commented on issue #253: Api v2 management allows swagger config to have basepath and path both set to /

2017-08-08 Thread git
mhamann commented on issue #253: Api v2 management allows swagger config to 
have basepath and path both set to /
URL: 
https://github.com/apache/incubator-openwhisk-apigateway/issues/253#issuecomment-321139021
 
 
   When it comes to the typical REST API, I don't know how often this scenario 
occurs. The HTML use case is the most compelling, given that you typically want 
a home document.
   
   Obviously, this is a use case for Whisk itself, but is it one for the API 
gateway? Would someone typically front an HTML page with the gateway?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] spattewar commented on issue #2567: Openwhisk Local Installation on Ubuntu 14 Failed !!! Please help

2017-08-08 Thread git
spattewar commented on issue #2567: Openwhisk Local Installation on Ubuntu 14 
Failed !!! Please help
URL: 
https://github.com/apache/incubator-openwhisk/issues/2567#issuecomment-321137650
 
 
   @devbv
   
   There are no logs under the nginx folder under wsklogs. Will the above 
command check the same logs file?
   
   Thank you
   Regards 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] houshengbo opened a new pull request #2593: Add BaseWsk class for Wsk and WskRest to inherit

2017-08-08 Thread git
houshengbo opened a new pull request #2593: Add BaseWsk class for Wsk and 
WskRest to inherit
URL: https://github.com/apache/incubator-openwhisk/pull/2593
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] devbv commented on issue #2567: Openwhisk Local Installation on Ubuntu 14 Failed !!! Please help

2017-08-08 Thread git
devbv commented on issue #2567: Openwhisk Local Installation on Ubuntu 14 
Failed !!! Please help
URL: 
https://github.com/apache/incubator-openwhisk/issues/2567#issuecomment-321125197
 
 
   @spattewar 
   
   consul did
   1) store environment variables
   2) check health of invokers
   
   but now it is removed and a controller maintains membership of invoker 
itself.
   
   Openwhisk use https for secure connection and you just failed with that.
   Check nginx logs by command 'docker logs nginx -f'
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] devbv commented on issue #2567: Openwhisk Local Installation on Ubuntu 14 Failed !!! Please help

2017-08-08 Thread git
devbv commented on issue #2567: Openwhisk Local Installation on Ubuntu 14 
Failed !!! Please help
URL: 
https://github.com/apache/incubator-openwhisk/issues/2567#issuecomment-321125197
 
 
   @spattewar 
   
   consul did
   1) store environment variables
   2) check health of invokers
   but now it is removed and a controller maintain membership of invoker itself.
   
   Openwhisk use https for secure connection and you just failed with that.
   Check nginx logs by command 'docker logs nginx -f'
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] spattewar commented on issue #2567: Openwhisk Local Installation on Ubuntu 14 Failed !!! Please help

2017-08-08 Thread git
spattewar commented on issue #2567: Openwhisk Local Installation on Ubuntu 14 
Failed !!! Please help
URL: 
https://github.com/apache/incubator-openwhisk/issues/2567#issuecomment-321123249
 
 
   @devbv  @rabbah 
   I am trying to create action by giving the command below and it is not 
creating
   root@guruvirtues-HP-EliteBook-8560w-SN717UP-ABA:~/openwhisk# bin/wsk action 
create hello bin/hello.js
   error: Unable to create action 'hello': Put 
https://172.17.0.1/api/v1/namespaces/_/actions/hello?overwrite=false: 
proxyconnect tcp: dial tcp 172.17.0.1:443: getsockopt: connection refused
   
   this is my docker ps command output
   CONTAINER IDIMAGECOMMAND  
CREATED STATUS PORTS
  NAMES
   7cfdf9111f5bnginx:1.11   "nginx -g 'daemon off"   13 
hours agoRestarting (1) 6 minutes ago   0.0.0.0:80->80/tcp, 
0.0.0.0:443->443/tcp, 0.0.0.0:8443->8443/tcp   nginx
   033b2de24debwhisk/invoker:latest "/bin/sh -c 'exec /in"   13 
hours agoUp About an hour   0.0.0.0:12001->8080/tcp 
   invoker0
   9e53d3bb7804whisk/controller:latest  "/bin/sh -c 'controll"   13 
hours agoUp About an hour   0.0.0.0:10001->8080/tcp 
   controller0
   3c3e465ce800ches/kafka:0.10.2.1  "/start.sh"  13 
hours agoUp About an hour   7203/tcp, 
0.0.0.0:9092->9092/tcp   kafka
   cd9d55150b91zookeeper:3.4"/docker-entrypoint.s"   13 
hours agoUp About an hour   2888/tcp, 
0.0.0.0:2181->2181/tcp, 3888/tcp zookeeper
   c1b48a3c3d76openwhisk/apigateway:0.8.2   "/usr/local/bin/dumb-"   13 
hours agoUp About an hour   80/tcp, 8423/tcp, 
0.0.0.0:9000->9000/tcp, 0.0.0.0:9001->8080/tcp   apigateway
   2835875673aeredis:3.2"docker-entrypoint.sh"   13 
hours agoUp About an hour   0.0.0.0:6379->6379/tcp  
   redis
   5b7549d135bccouchdb:1.6  "tini -- /docker-entr"   13 
hours agoUp About an hour   0.0.0.0:5984->5984/tcp  
   couchdb
   
   Is it issue with nginx? I think it is not able to connect or relay. Please 
help. This seems to be the last step.
   
   thank you again for the time and help
   regards
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] underwoodb-sd-ibm commented on issue #2424: Allow optional leading slash in CLI commands

2017-08-08 Thread git
underwoodb-sd-ibm commented on issue #2424: Allow optional leading slash in CLI 
commands
URL: 
https://github.com/apache/incubator-openwhisk/pull/2424#issuecomment-321119586
 
 
   PG2 1922 - Passed
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] houshengbo opened a new pull request #2592: Rename CliActivationResponse & CliActivation, and change them from inner classes to classes

2017-08-08 Thread git
houshengbo opened a new pull request #2592: Rename CliActivationResponse & 
CliActivation, and change them from inner classes to classes
URL: https://github.com/apache/incubator-openwhisk/pull/2592
 
 
   This PR renames the class CliActivation and CliActivationResponse
   and makes them available to be accessed from another package, because
   REST call can use both of the classes as well.
   
   This PR is the necessary step of test case refactor for rest implementation.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] pritidesai commented on issue #298: Fix Parameter Resolution (both schema) & documentation for the triggerrule use case

2017-08-08 Thread git
pritidesai commented on issue #298: Fix Parameter Resolution (both schema) & 
documentation for the triggerrule use case
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/298#issuecomment-321086884
 
 
   Matt, I have tested your changes and have uploaded test cases here (marked 
it as WIP as adding more test cases):
   
   https://github.com/apache/incubator-openwhisk-wskdeploy/pull/308
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] drcariel commented on issue #2568: Set a User-Agent header in wsk cli requests

2017-08-08 Thread git
drcariel commented on issue #2568: Set a User-Agent header in wsk cli requests
URL: 
https://github.com/apache/incubator-openwhisk/issues/2568#issuecomment-321080828
 
 
   os.Setenv/os.Getenv was the easiest way for me to get access to the build 
version since it was intentionally excluded from the available Config
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] drcariel commented on issue #2568: Set a User-Agent header in wsk cli requests

2017-08-08 Thread git
drcariel commented on issue #2568: Set a User-Agent header in wsk cli requests
URL: 
https://github.com/apache/incubator-openwhisk/issues/2568#issuecomment-321080165
 
 
   Got some code @ https://github.com/apache/incubator-openwhisk/pull/2591 if 
you wanna check it out
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] drcariel opened a new pull request #2591: User-Agent CLI/version header

2017-08-08 Thread git
drcariel opened a new pull request #2591: User-Agent CLI/version header
URL: https://github.com/apache/incubator-openwhisk/pull/2591
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] misl commented on issue #2590: Feature request: Allow java action entrypoint method name to be configurable

2017-08-08 Thread git
misl commented on issue #2590: Feature request: Allow java action entrypoint 
method name to be configurable
URL: 
https://github.com/apache/incubator-openwhisk/issues/2590#issuecomment-321078302
 
 
   I was able to add support, but since I am new to openwhisk. I have not yet 
been able to test it locally. Once confirmed locally I will issue a pull 
request.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] misl opened a new issue #2590: Feature request: Allow java action entrypoint method name to be configurable

2017-08-08 Thread git
misl opened a new issue #2590: Feature request: Allow java action entrypoint 
method name to be configurable
URL: https://github.com/apache/incubator-openwhisk/issues/2590
 
 
   Looking at the 'wsk' I initially expected the entrypoint method name for 
java actions already to be configurable:
   
 --main stringthe name of the action entry point (function 
or fully-qualified method name when applicable)
   
   It mentions fully qualified method name. So I tried using:
   
   $> wsk action create ... --main my.package.path.ActionClass#methodName
   
   Even though this command is accepted. Invoking the action result in an 
error. 
   After a quick look at the source code 
https://github.com/apache/incubator-openwhisk/blob/master/core/javaAction/proxy/src/main/java/openwhisk/java/action/JarLoader.java
 line 61 . I noticed the method name 'main' is hardcoded.
   
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ert78gb commented on issue #64: chore: Ignore .idea directory from git

2017-08-08 Thread git
ert78gb commented on issue #64: chore: Ignore .idea directory from git
URL: 
https://github.com/apache/incubator-openwhisk-client-js/pull/64#issuecomment-321074594
 
 
   could I add .nvmrc file to the repo or is it same user settings?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rabbah commented on a change in pull request #2424: Allow optional leading slash in CLI commands

2017-08-08 Thread git
rabbah commented on a change in pull request #2424: Allow optional leading 
slash in CLI commands
URL: 
https://github.com/apache/incubator-openwhisk/pull/2424#discussion_r132013941
 
 

 ##
 File path: tests/src/test/scala/system/basic/WskBasicTests.scala
 ##
 @@ -75,6 +75,34 @@ class WskBasicTests
 stderr should include(errormsg)
 }
 
+it should "allow a 3 part Fully Qualified Name (FQN) without a leading 
'/'" in withAssetCleaner(wskprops) {
+(wp, assetHelper) =>
+val guestNamespace = wsk.namespace.whois()
+val packageName = "packageName3ptFQN"
+val actionName = "actionName3ptFQN"
+val triggerName = "triggerName3ptFQN"
+val ruleName = "ruleName3ptFQN"
+val fullQualifiedName = 
s"${guestNamespace}/${packageName}/${actionName}"
+// Used for action and rule creation below
+assetHelper.withCleaner(wsk.pkg, packageName) {
+(pkg, _) => pkg.create(packageName)
+}
+assetHelper.withCleaner(wsk.trigger, triggerName) {
+(trigger, _) => trigger.create(triggerName)
+}
+// Test action and rule creation where action name is 3 part FQN 
w/out leading slash
+assetHelper.withCleaner(wsk.action, fullQualifiedName) {
+(action, _) => action.create(fullQualifiedName, defaultAction)
+}
+assetHelper.withCleaner(wsk.rule, ruleName) {
+(rule, _) =>
+rule.create(ruleName, trigger = triggerName, action = 
fullQualifiedName)
+}
+
+wsk.action.invoke(fullQualifiedName).stdout should include(s"ok: 
invoked /$fullQualifiedName")
+wsk.action.get(fullQualifiedName).stdout should include(s"ok: got 
action ${packageName}/${actionName}")
 
 Review comment:
   Sounds like different pr. 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] dubeejw opened a new pull request #2435: Ensure Action Update Creates a Web Action (Review)

2017-08-08 Thread git
dubeejw opened a new pull request #2435: Ensure Action Update Creates a Web 
Action (Review)
URL: https://github.com/apache/incubator-openwhisk/pull/2435
 
 
   Closes https://github.com/apache/incubator-openwhisk/issues/2428
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] dubeejw closed pull request #2435: Ensure Action Update Creates a Web Action (Review)

2017-08-08 Thread git
dubeejw closed pull request #2435: Ensure Action Update Creates a Web Action 
(Review)
URL: https://github.com/apache/incubator-openwhisk/pull/2435
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ert78gb closed pull request #64: chore: Ignore .idea directory from git

2017-08-08 Thread git
ert78gb closed pull request #64: chore: Ignore .idea directory from git
URL: https://github.com/apache/incubator-openwhisk-client-js/pull/64
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] markusthoemmes commented on issue #2589: Add the fundamental framework of REST invocation for test cases to re?

2017-08-08 Thread git
markusthoemmes commented on issue #2589: Add the fundamental framework of REST 
invocation for test cases to re?
URL: 
https://github.com/apache/incubator-openwhisk/pull/2589#issuecomment-321054268
 
 
   Close #2480 ?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] underwoodb-sd-ibm commented on issue #2424: Allow optional leading slash in CLI commands

2017-08-08 Thread git
underwoodb-sd-ibm commented on issue #2424: Allow optional leading slash in CLI 
commands
URL: 
https://github.com/apache/incubator-openwhisk/pull/2424#issuecomment-321053827
 
 
   PG2 1922
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] underwoodb-sd-ibm commented on a change in pull request #2424: Allow optional leading slash in CLI commands

2017-08-08 Thread git
underwoodb-sd-ibm commented on a change in pull request #2424: Allow optional 
leading slash in CLI commands
URL: 
https://github.com/apache/incubator-openwhisk/pull/2424#discussion_r132003908
 
 

 ##
 File path: tests/src/test/scala/system/basic/WskBasicTests.scala
 ##
 @@ -75,6 +75,34 @@ class WskBasicTests
 stderr should include(errormsg)
 }
 
+it should "allow a 3 part Fully Qualified Name (FQN) without a leading 
'/'" in withAssetCleaner(wskprops) {
+(wp, assetHelper) =>
+val guestNamespace = wsk.namespace.whois()
+val packageName = "packageName3ptFQN"
+val actionName = "actionName3ptFQN"
+val triggerName = "triggerName3ptFQN"
+val ruleName = "ruleName3ptFQN"
+val fullQualifiedName = 
s"${guestNamespace}/${packageName}/${actionName}"
+// Used for action and rule creation below
+assetHelper.withCleaner(wsk.pkg, packageName) {
+(pkg, _) => pkg.create(packageName)
+}
+assetHelper.withCleaner(wsk.trigger, triggerName) {
+(trigger, _) => trigger.create(triggerName)
+}
+// Test action and rule creation where action name is 3 part FQN 
w/out leading slash
+assetHelper.withCleaner(wsk.action, fullQualifiedName) {
+(action, _) => action.create(fullQualifiedName, defaultAction)
+}
+assetHelper.withCleaner(wsk.rule, ruleName) {
+(rule, _) =>
+rule.create(ruleName, trigger = triggerName, action = 
fullQualifiedName)
+}
+
+wsk.action.invoke(fullQualifiedName).stdout should include(s"ok: 
invoked /$fullQualifiedName")
+wsk.action.get(fullQualifiedName).stdout should include(s"ok: got 
action ${packageName}/${actionName}")
 
 Review comment:
   I'm not sure why there is a difference in outputs between invoke and get, 
but there is one. Invoke prints the FQN, while get only prints the entity name 
(pkg/action). I suppose it is inconsistent - is this something that should be 
brought up in a new issue? Or do you think this is something that should have 
been covered in this PR?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] houshengbo opened a new pull request #2589: Add the fundamental framework of REST invocation for test cases to re?

2017-08-08 Thread git
houshengbo opened a new pull request #2589: Add the fundamental framework of 
REST invocation for test cases to re?
URL: https://github.com/apache/incubator-openwhisk/pull/2589
 
 
   ?place wsk binary
   
   Almost all the test cases in OpenWhisk are currently running based
   on the wsk CLI binary. In order to separate the CLI out of OpenWhisk
   core repository, we need to call REST API of OpenWhisk to access
   OpenWhisk services instead of calling the wsk CLI binary command.
   
   This PR adds the basic REST implementation for all the test cases
   to use. One basic principle is to keep the changes to the existing
   test cases as few as possible, so we add WskRest.scala as an equivalent
   class to Wsk.scala and WskRestTestHelpers.scala as an equivalent file
   to WskTestHelpers.scala for REST.
   
   All the replacement of binary with REST will happen in an increamental 
fashion.
   This PR only changes one existing test case in WskActionTests.scala, and
   reimplements it in WskRestActionTests.scala. All the other test cases can 
follow
   the same way to change the test cases one by one. New changes may be 
necessary
   to the basic REST implementation as well in future to accommodate the test 
cases.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rabbah commented on issue #2424: Allow optional leading slash in CLI commands

2017-08-08 Thread git
rabbah commented on issue #2424: Allow optional leading slash in CLI commands
URL: 
https://github.com/apache/incubator-openwhisk/pull/2424#issuecomment-321045065
 
 
   need to rebase.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rabbah commented on a change in pull request #2424: Allow optional leading slash in CLI commands

2017-08-08 Thread git
rabbah commented on a change in pull request #2424: Allow optional leading 
slash in CLI commands
URL: 
https://github.com/apache/incubator-openwhisk/pull/2424#discussion_r131997230
 
 

 ##
 File path: tests/src/test/scala/system/basic/WskBasicTests.scala
 ##
 @@ -75,6 +75,34 @@ class WskBasicTests
 stderr should include(errormsg)
 }
 
+it should "allow a 3 part Fully Qualified Name (FQN) without a leading 
'/'" in withAssetCleaner(wskprops) {
+(wp, assetHelper) =>
+val guestNamespace = wsk.namespace.whois()
+val packageName = "packageName3ptFQN"
+val actionName = "actionName3ptFQN"
+val triggerName = "triggerName3ptFQN"
+val ruleName = "ruleName3ptFQN"
+val fullQualifiedName = 
s"${guestNamespace}/${packageName}/${actionName}"
+// Used for action and rule creation below
+assetHelper.withCleaner(wsk.pkg, packageName) {
+(pkg, _) => pkg.create(packageName)
+}
+assetHelper.withCleaner(wsk.trigger, triggerName) {
+(trigger, _) => trigger.create(triggerName)
+}
+// Test action and rule creation where action name is 3 part FQN 
w/out leading slash
+assetHelper.withCleaner(wsk.action, fullQualifiedName) {
+(action, _) => action.create(fullQualifiedName, defaultAction)
+}
+assetHelper.withCleaner(wsk.rule, ruleName) {
+(rule, _) =>
+rule.create(ruleName, trigger = triggerName, action = 
fullQualifiedName)
+}
+
+wsk.action.invoke(fullQualifiedName).stdout should include(s"ok: 
invoked /$fullQualifiedName")
+wsk.action.get(fullQualifiedName).stdout should include(s"ok: got 
action ${packageName}/${actionName}")
 
 Review comment:
   should the CLI always print fully qualified names with leading slash? note 
line 102 vs 103.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] pritidesai opened a new issue #309: Switch to yaml.UnmarshalStrict()

2017-08-08 Thread git
pritidesai opened a new issue #309: Switch to yaml.UnmarshalStrict()
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/309
 
 
   
[manifest_parser.Unmarshal()](https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/parsers/manifest_parser.go#L61)
 method is using 
[yaml.Unmarshal()](https://github.com/go-yaml/yaml/blob/v2/yaml.go#L90). 
Evaluate and change it to call 
[yaml.UnmarshalStrict()](https://github.com/go-yaml/yaml/blob/v2/yaml.go#L86).
   
   Notice a test case in 
[manifest_parser_test.go](https://github.com/apache/incubator-openwhisk-wskdeploy/pull/308/files#diff-d2c21d01a5f4cb82e4fa482087e7f6a2R201)
 (PR # 308):
   
   When a manifest_parser.Unmarshal() is initiated with invalid manifest data 
(package section is missing):
   
   ```
 actions:
   helloNodejs:
 location: actions/hello.js
 runtime: nodejs:6
   helloJava:
 location: actions/hello.java`
   ```
   manifest_parser.Unmarshal() does not report any error even though `Package` 
section is missing. 
   
   We should report error in case of a required YAML members are not specified 
in manifest file.
   
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rabbah commented on a change in pull request #2490: CLI summaries for actions without annotations

2017-08-08 Thread git
rabbah commented on a change in pull request #2490: CLI summaries for actions 
without annotations
URL: 
https://github.com/apache/incubator-openwhisk/pull/2490#discussion_r131995766
 
 

 ##
 File path: tests/src/test/scala/system/basic/WskBasicTests.scala
 ##
 @@ -410,6 +487,97 @@ class WskBasicTests
 stdout should include regex (s"(?i)action /$ns/$name: Action 
description\\s*\\(parameters: paramName1, paramName2\\)")
 }
 
+it should "create, and get an action summary without a description and/or 
defined parameters" in withAssetCleaner(wskprops) {
+(wp, assetHelper) =>
+val actNameNoParams = "actionNoParams"
+val actNameNoDesc = "actionNoDesc"
+val actNameNoDescOrParams = "actionNoDescOrParams"
+val desc = "Action description"
+val descFromParamsResp = "Returns a result based on parameters"
+val annotsNoParams = Map(
+"description" -> JsString(desc)
+)
+val annotsNoDesc = Map(
+"parameters" -> JsArray(
+JsObject(
+"name" -> JsString("paramName1"),
+"description" -> JsString("Parameter description 1")),
+JsObject(
+"name" -> JsString("paramName2"),
+"description" -> JsString("Parameter description 2"
+
+assetHelper.withCleaner(wsk.action, actNameNoDesc) {
+(action, _) =>
+action.create(actNameNoDesc, defaultAction, annotations = 
annotsNoDesc)
+}
+assetHelper.withCleaner(wsk.action, actNameNoParams) {
+(action, _) =>
+action.create(actNameNoParams, defaultAction, annotations 
= annotsNoParams)
+}
+assetHelper.withCleaner(wsk.action, actNameNoDescOrParams) {
+(action, _) =>
+action.create(actNameNoDescOrParams, defaultAction)
+}
+
+val stdoutNoDesc = wsk.action.get(actNameNoDesc, summary = 
true).stdout
+val stdoutNoParams = wsk.action.get(actNameNoParams, summary = 
true).stdout
+val stdoutNoDescOrParams = wsk.action.get(actNameNoDescOrParams, 
summary = true).stdout
+val ns_regex_list = wsk.namespace.list().stdout.trim.replace('\n', 
'|')
 
 Review comment:
   same as above.
   there's others, i trust you'll address all instances.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] mdeuser commented on issue #2568: Set a User-Agent header in wsk cli requests

2017-08-08 Thread git
mdeuser commented on issue #2568: Set a User-Agent header in wsk cli requests
URL: 
https://github.com/apache/incubator-openwhisk/issues/2568#issuecomment-321043176
 
 
   i like the latter.  we'll want the cli version included to distinguish 
between various builds..
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rabbah commented on a change in pull request #2490: CLI summaries for actions without annotations

2017-08-08 Thread git
rabbah commented on a change in pull request #2490: CLI summaries for actions 
without annotations
URL: 
https://github.com/apache/incubator-openwhisk/pull/2490#discussion_r131995281
 
 

 ##
 File path: docs/packages.md
 ##
 @@ -59,10 +65,12 @@ Several packages are registered with OpenWhisk. You can 
get a list of packages i
   ```
   ```
   action /whisk.system/cloudant/read: Read document from database
- (params: dbname includeDoc id)
+ (parameters: *apihost, *bluemixServiceName, *dbname, *host, *id, params, 
*password, *username)
 
 Review comment:
   i'd remove `bluemixServiceName` here.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] dubeejw commented on issue #2490: CLI summaries for actions without annotations

2017-08-08 Thread git
dubeejw commented on issue #2490: CLI summaries for actions without annotations
URL: 
https://github.com/apache/incubator-openwhisk/pull/2490#issuecomment-321042187
 
 
   @csantanapr, want to merge?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)

2017-08-08 Thread git
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action 
(Review)
URL: 
https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-321041935
 
 
   Rebased for API experimental removal conflicts.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] pritidesai opened a new pull request #308: WIP: Unit test manifest_parser.go

2017-08-08 Thread git
pritidesai opened a new pull request #308: WIP: Unit test manifest_parser.go
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/308
 
 
   Adding bunch of unit tests to validate manifest_parser.Unmarshal(), 
manifest_parser.ParseManifest(), manifest_parser.ComposeActions()
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] drcariel commented on issue #2568: Set a User-Agent header in wsk cli requests

2017-08-08 Thread git
drcariel commented on issue #2568: Set a User-Agent header in wsk cli requests
URL: 
https://github.com/apache/incubator-openwhisk/issues/2568#issuecomment-321033233
 
 
   Do we have a preferred value for the User-Agent Header? Keep it simple?
   
   ```User-Agent: CLI```
   
   or more complicated?
   
   ```User-Agent: OpenWhisk-CLI /  ```
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] drcariel commented on issue #2568: Set a User-Agent header in wsk cli requests

2017-08-08 Thread git
drcariel commented on issue #2568: Set a User-Agent header in wsk cli requests
URL: 
https://github.com/apache/incubator-openwhisk/issues/2568#issuecomment-321033233
 
 
   Do we have a preferred value for the User-Agent Header? Keep it simple?
   
   ```User-Agent: OpenWhisk-CLI```
   
   or more complicated?
   
   ```User-Agent: OpenWhisk-CLI /  ```
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] drcariel commented on issue #2568: Set a User-Agent header in wsk cli requests

2017-08-08 Thread git
drcariel commented on issue #2568: Set a User-Agent header in wsk cli requests
URL: 
https://github.com/apache/incubator-openwhisk/issues/2568#issuecomment-321033233
 
 
   Do we have a preferred value for the User-Agent Header? Keep it simple?
   
   ```User-Agent: CLI```
   
   or more complicated?
   
   ```User-Agent:  /  ```
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] underwoodb-sd-ibm commented on issue #2490: CLI summaries for actions without annotations

2017-08-08 Thread git
underwoodb-sd-ibm commented on issue #2490: CLI summaries for actions without 
annotations
URL: 
https://github.com/apache/incubator-openwhisk/pull/2490#issuecomment-321029681
 
 
   PG3 980 - Passed
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rabbah closed pull request #2547: CLI Experimental api removal

2017-08-08 Thread git
rabbah closed pull request #2547: CLI Experimental api removal
URL: https://github.com/apache/incubator-openwhisk/pull/2547
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] josecvega opened a new issue #2588: Vagrant OpenWhisk Nginx container

2017-08-08 Thread git
josecvega opened a new issue #2588: Vagrant OpenWhisk Nginx container
URL: https://github.com/apache/incubator-openwhisk/issues/2588
 
 
   ## Environment details:
   
   * vagrant (1.9.5) with virtualbox(5.1.22 r115126) running on Mac OS Sierra 
(10.12.6)
   
   ## Steps to reproduce the issue:
   
   1.   git clone --depth=1 https://github.com/apache/incubator-openwhisk.git 
openwhisk
   2.   cd openwhish/tools/vagrant
   3.   ./hello
   4.   vagrant ssh
   3.   create Javascript file names hello.js
   5.   wsk action create hello hello.js
   
   
   ## Provide the expected results and outputs:
   
   ```
   ok: created action hello
   ```
   
   
   ## Provide the actual results and outputs:
   
   ```
   error: Unable to create action 'hello': Put 
https://192.168.33.13/api/v1/namespaces/guest/actions/hello?overwrite=false: 
dial tcp 192.168.33.13:443: getsockopt: connection refused
   ```
   
   ## Additional information you deem important:
   * nginx container does not appear to be running
   ```
   9a6896827eb1nginx:1.11   "nginx -g 'daemon off"  
 14 hours agoRestarting (1) 3 minutes ago   0.0.0.0:80->80/tcp, 
0.0.0.0:443->443/tcp, 0.0.0.0:8443->8443/tcp   nginx
   
   
   * can't attach nginx container
   ```
   docker attach 9a6896827eb1
   2017/08/08 15:56:42 [emerg] 1#1: open() "/etc/nginx/nginx.conf" failed (2: 
No such file or directory)
   nginx: [emerg] open() "/etc/nginx/nginx.conf" failed (2: No such file or 
directory)
   ```
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] josecvega closed issue #2588: Vagrant OpenWhisk Nginx container

2017-08-08 Thread git
josecvega closed issue #2588: Vagrant OpenWhisk Nginx container
URL: https://github.com/apache/incubator-openwhisk/issues/2588
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] jthomas commented on issue #62: Update readme.md to fix bug w/ retrieve

2017-08-08 Thread git
jthomas commented on issue #62: Update readme.md to fix bug w/ retrieve
URL: 
https://github.com/apache/incubator-openwhisk-client-js/pull/62#issuecomment-321006557
 
 
   cc @csantanapr 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] jthomas commented on issue #64: chore: Ignore .idea directory from git

2017-08-08 Thread git
jthomas commented on issue #64: chore: Ignore .idea directory from git
URL: 
https://github.com/apache/incubator-openwhisk-client-js/pull/64#issuecomment-321006329
 
 
   @ert78gb I understand this is a tiny change but I don't think it's desirable 
to start adding lots of editor-specific files to the main `.gitignore`. 
Developers are free to add these in for their own configuration locally.
   
   I'm not sure why `package.lock.json` is in there.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] hsane2001 commented on issue #2220: Ansible error while deploying to distributed environment

2017-08-08 Thread git
hsane2001 commented on issue #2220: Ansible error while deploying to 
distributed environment
URL: 
https://github.com/apache/incubator-openwhisk/issues/2220#issuecomment-321005518
 
 
   @fernandodelaiglesia -> I hit the same issue where Consul would hang on 
coming up in the native environment, I resolved it when I unset PROXY variables 
in my environment.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] jthomas commented on issue #65: feat: Support version when create / update action

2017-08-08 Thread git
jthomas commented on issue #65: feat: Support version when create / update 
action
URL: 
https://github.com/apache/incubator-openwhisk-client-js/pull/65#issuecomment-321005463
 
 
   Thanks, this LGTM. 
   
   @csantanapr review & merge? So I can release on NPM.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] josecvega opened a new issue #2588: Vagrant OpenWhisk Nginx container

2017-08-08 Thread git
josecvega opened a new issue #2588: Vagrant OpenWhisk Nginx container
URL: https://github.com/apache/incubator-openwhisk/issues/2588
 
 
   ## Environment details:
   
   * vagrant (1.9.5) with virtualbox(5.1.22 r115126) running on Mac OS Sierra 
(19.12.6)
   
   ## Steps to reproduce the issue:
   
   1.   git clone --depth=1 https://github.com/apache/incubator-openwhisk.git 
openwhisk
   2.   cd openwhish/tools/vagrant
   3.   ./hello
   4.   vagrant ssh
   3.   create Javascript file names hello.js
   5.   wsk action create hello hello.js
   
   
   ## Provide the expected results and outputs:
   
   ```
   ok: created action hello
   ```
   
   
   ## Provide the actual results and outputs:
   
   ```
   error: Unable to create action 'hello': Put 
https://192.168.33.13/api/v1/namespaces/guest/actions/hello?overwrite=false: 
dial tcp 192.168.33.13:443: getsockopt: connection refused
   ```
   
   ## Additional information you deem important:
   * nginx container does not appear to be running
   ```
   9a6896827eb1nginx:1.11   "nginx -g 'daemon off"  
 14 hours agoRestarting (1) 3 minutes ago   0.0.0.0:80->80/tcp, 
0.0.0.0:443->443/tcp, 0.0.0.0:8443->8443/tcp   nginx
   
   
   * can't attach nginx container
   ```
   docker attach 9a6896827eb1
   2017/08/08 15:56:42 [emerg] 1#1: open() "/etc/nginx/nginx.conf" failed (2: 
No such file or directory)
   nginx: [emerg] open() "/etc/nginx/nginx.conf" failed (2: No such file or 
directory)
   ```
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] tleyden opened a new issue #23: Pick up environment parameters to configure the authentication credentials, platform endpoint and namespace.

2017-08-08 Thread git
tleyden opened a new issue #23: Pick up environment parameters to configure the 
authentication credentials, platform endpoint and namespace. 
URL: https://github.com/apache/incubator-openwhisk-client-go/issues/23
 
 
   
   From https://github.com/apache/incubator-openwhisk-client-js:
   
   > This client library can use environment parameters to automatically 
configure the authentication credentials, platform endpoint and namespace.
   
   Is that true for incubator-openwhisk-client-go as well?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] underwoodb-sd-ibm commented on issue #2490: CLI summaries for actions without annotations

2017-08-08 Thread git
underwoodb-sd-ibm commented on issue #2490: CLI summaries for actions without 
annotations
URL: 
https://github.com/apache/incubator-openwhisk/pull/2490#issuecomment-320998316
 
 
   PG3 980
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] tleyden opened a new issue #22: Example is broken: whisk.NewClient(http.DefaultClient, nil)

2017-08-08 Thread git
tleyden opened a new issue #22: Example is broken: 
whisk.NewClient(http.DefaultClient, nil)
URL: https://github.com/apache/incubator-openwhisk-client-go/issues/22
 
 
   From the README example:
   
   ```
   client, _ := whisk.NewClient(http.DefaultClient, nil)
   action, resp, err := client.Actions.List("hello")
   ```
   
   But this breaks, since inside the `NewClient()` code it calls `if 
config.Insecure {..}` on a nil config, which panics with `panic: runtime error: 
invalid memory address or nil pointer dereference`
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] markusthoemmes opened a new pull request #2587: Make LoadbalancerData leaner.

2017-08-08 Thread git
markusthoemmes opened a new pull request #2587: Make LoadbalancerData leaner.
URL: https://github.com/apache/incubator-openwhisk/pull/2587
 
 
   LoadbalancerData keeps a lot of data it doesn't need. Upon fetching a copy 
of this data, it creates copies which can be expensive, the more user are in 
the system.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)

2017-08-08 Thread git
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action 
(Review)
URL: 
https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320978156
 
 
   @mdeuser, anything else on this one?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] spattewar commented on issue #2569: 1 million per second event processing using openwhisk ??

2017-08-08 Thread git
spattewar commented on issue #2569: 1 million per second event processing using 
openwhisk ??
URL: 
https://github.com/apache/incubator-openwhisk/issues/2569#issuecomment-320976933
 
 
   @perryibm 
   Perry very useful information. 
   In our scenario it is not a burst of events but rather a continuous thing. 
Note that we are trying to handle the max scenario. So there could be 1M/second 
events happening through lot of devices which will then come to a openwhisk 
cluster, which will handle all of them. It is not clear at this point what 
different types of events would we have and how much processing for each type 
is required. there could be event that needs to be just transferred to kafka 
and further to internal database. Others might have some processing to do.
   
   So do you thing depending upon the system power and memory it is possible to 
setup an openwhisk cluster that can handle 1M/sec events? I am not sure how we 
can setup this cluster up but we are trying to gauge if openwhisk can support 
our scenario.
   
   thanks again for your time and help.
   regards
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] tysonnorris commented on a change in pull request #2584: SPI for Loadbalancer

2017-08-08 Thread git
tysonnorris commented on a change in pull request #2584: SPI for Loadbalancer
URL: 
https://github.com/apache/incubator-openwhisk/pull/2584#discussion_r131931484
 
 

 ##
 File path: 
core/controller/src/main/scala/whisk/core/loadBalancer/LoadBalancerService.scala
 ##
 @@ -77,16 +82,32 @@ trait LoadBalancer {
  */
 def publish(action: ExecutableWhiskAction, msg: 
ActivationMessage)(implicit transid: TransactionId): 
Future[Future[Either[ActivationId, WhiskActivation]]]
 
+/**
+ * Return a message indicating the health of the containers and/or 
container pool in general
+ * @return a Future[String] representing the heal response that will be 
sent to the client
+ */
+def getHealthResponse: Future[String]
 
 Review comment:
   done
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] tysonnorris commented on a change in pull request #2584: SPI for Loadbalancer

2017-08-08 Thread git
tysonnorris commented on a change in pull request #2584: SPI for Loadbalancer
URL: 
https://github.com/apache/incubator-openwhisk/pull/2584#discussion_r131931453
 
 

 ##
 File path: 
common/scala/src/main/scala/whisk/core/database/CouchDbStoreProvider.scala
 ##
 @@ -36,10 +38,17 @@ class CouchDbStoreProvider extends ArtifactStoreProvider {
 require(config.dbProvider == "Cloudant" || config.dbProvider == 
"CouchDB", "Unsupported db.provider: " + config.dbProvider)
 assume(Set(config.dbProtocol, config.dbHost, config.dbPort, 
config.dbUsername, config.dbPassword, name(config)).forall(_.nonEmpty), "At 
least one expected property is missing")
 
-new CouchDbRestStore[D](config.dbProtocol, config.dbHost, 
config.dbPort.toInt, config.dbUsername, config.dbPassword, name(config))
+val storeName = name(config)
+stores.get(storeName) match {
 
 Review comment:
   great thanks!
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] spattewar commented on issue #2567: Openwhisk Local Installation on Ubuntu 14 Failed !!! Please help

2017-08-08 Thread git
spattewar commented on issue #2567: Openwhisk Local Installation on Ubuntu 14 
Failed !!! Please help
URL: 
https://github.com/apache/incubator-openwhisk/issues/2567#issuecomment-320973977
 
 
   @devbv 
   Thank you for your response. I ran teardown.yml and then deleted the 
openwhisk folder and then followed all the steps as mentioned in my issue 
comment. All went well and this time I was also able to run the postdeploy.yml 
successfully. As you said there is no consul running now. So is there a change 
in the openwhisk architecture? Who is doing the role of the consul?
   
   Now I need to use wsk to create an action and run it. I am still confused on 
how to connect to openwhisk now, Does it allow secured connection? Do I need to 
do any steps to allow the secured connection.
   
   thank you for your time and help.
   regards
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] underwoodb-sd-ibm commented on a change in pull request #2424: Allow optional leading slash in CLI commands

2017-08-08 Thread git
underwoodb-sd-ibm commented on a change in pull request #2424: Allow optional 
leading slash in CLI commands
URL: 
https://github.com/apache/incubator-openwhisk/pull/2424#discussion_r131925910
 
 

 ##
 File path: tests/src/test/scala/system/basic/WskBasicTests.scala
 ##
 @@ -75,6 +75,40 @@ class WskBasicTests
 stderr should include(errormsg)
 }
 
+it should "accept a 3 part Fully Qualified Name without a leading '/'" in {
+val auth: Seq[String] = Seq("--auth", wskprops.authKey)
+val guestNamespace = wskprops.namespace
+val packageName = "packageName3ptFQN"
+val actionName = "actionName3ptFQN"
+val triggerName = "triggerName3ptFQN"
+val ruleName = "ruleName3ptFQN"
+val fullQualifiedName = 
s"${guestNamespace}/${packageName}/${actionName}"
+val validArgs: Seq[Seq[String]] = Seq(
+Seq("package", "create", packageName),
+Seq("action", "create", fullQualifiedName, defaultAction.get),
+Seq("action", "update", fullQualifiedName, defaultAction.get),
+Seq("action", "invoke", fullQualifiedName),
+Seq("trigger", "create", triggerName),
 
 Review comment:
   No problem - sorry for the test being confusing. I'll try to rewrite it 
based on the suggestions here to make it easier to read/understand.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] andrewnet commented on issue #2548: The logs in activation is not complete

2017-08-08 Thread git
andrewnet commented on issue #2548: The logs in activation is not complete
URL: 
https://github.com/apache/incubator-openwhisk/issues/2548#issuecomment-320953988
 
 
   Hi, just want to follow up on the progress of this defect and see if there 
is any update? Thanks.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] duynguyen commented on issue #28: [docker-compose] Create jenkins job that runs when a new a new commits lands in core openwhisk

2017-08-08 Thread git
duynguyen commented on issue #28: [docker-compose] Create jenkins job that runs 
when a new a new commits lands in core openwhisk
URL: 
https://github.com/apache/incubator-openwhisk-devtools/issues/28#issuecomment-309518140
 
 
   @csantanapr which jenkins image do you use to run the job? I want to run it 
to test my script.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] duynguyen commented on issue #2117: couchdb-snapshot docker image is missing `subjects` and `whisks` DBs

2017-08-08 Thread git
duynguyen commented on issue #2117: couchdb-snapshot docker image is missing 
`subjects` and `whisks` DBs
URL: 
https://github.com/apache/incubator-openwhisk/issues/2117#issuecomment-320939096
 
 
   I've got the jenkins job working on my local setup.
   Before a PR can be opened for it, we need to know where the dependency files 
are located: `Dockerfile`, `init.sh` and `import.sh` from #1928.
   @ddragosd wdyt? would you proceed with #1928 with those 3 files only?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rabbah closed pull request #2582: Use non-blocking techniques when interfacing to Kafka.

2017-08-08 Thread git
rabbah closed pull request #2582: Use non-blocking techniques when interfacing 
to Kafka.
URL: https://github.com/apache/incubator-openwhisk/pull/2582
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] markusthoemmes commented on issue #2582: Use non-blocking techniques when interfacing to Kafka.

2017-08-08 Thread git
markusthoemmes commented on issue #2582: Use non-blocking techniques when 
interfacing to Kafka.
URL: 
https://github.com/apache/incubator-openwhisk/pull/2582#issuecomment-320928563
 
 
   PG1 1920 ? 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] RSulzmann opened a new issue #122: cloudant package : create and delete trigger should should verify creation or deletion

2017-08-08 Thread git
RSulzmann opened a new issue #122: cloudant package : create and delete trigger 
should should verify creation or deletion
URL: https://github.com/apache/incubator-openwhisk-package-cloudant/issues/122
 
 
   
https://github.com/apache/incubator-openwhisk-package-cloudant/blob/master/actions/changesWebAction.js
   The functions **createTrigger** and **deleteTrigger** should guarantee on 
return, that the trigger is created or deleted.
   
   Our test code based on this package cannot check the existence of the 
trigger and we get sometimes errors when the creation or deletion is processed 
delayed.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] codecov-io commented on issue #65: feat: Support version when create / update action

2017-08-08 Thread git
codecov-io commented on issue #65: feat: Support version when create / update 
action
URL: 
https://github.com/apache/incubator-openwhisk-client-js/pull/65#issuecomment-320595097
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/65?src=pr=h1)
 Report
   > Merging 
[#65](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/65?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk-client-js/commit/d4b69d77fb2647ea97ff1eb9e7b295bedfc8f428?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/65/graphs/tree.svg?width=650=150=pr=j2mPEx0Tkq)](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/65?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master  #65  +/-   ##
   ==
   + Coverage   99.37%   99.37%   +<.01% 
   ==
 Files  14   14  
 Lines 318  320   +2 
   ==
   + Hits  316  318   +2 
 Misses  22
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/65?src=pr=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[lib/actions.js](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/65?src=pr=tree#diff-bGliL2FjdGlvbnMuanM=)
 | `100% <100%> (?)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/65?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/65?src=pr=footer).
 Last update 
[d4b69d7...8cd1de2](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/65?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ert78gb commented on issue #65: feat: Support version when create / update action

2017-08-08 Thread git
ert78gb commented on issue #65: feat: Support version when create / update 
action
URL: 
https://github.com/apache/incubator-openwhisk-client-js/pull/65#issuecomment-320889231
 
 
   I added and set the code snippet language for syntax highlight
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] markusthoemmes commented on a change in pull request #2584: SPI for Loadbalancer

2017-08-08 Thread git
markusthoemmes commented on a change in pull request #2584: SPI for Loadbalancer
URL: 
https://github.com/apache/incubator-openwhisk/pull/2584#discussion_r131842596
 
 

 ##
 File path: 
core/controller/src/main/scala/whisk/core/loadBalancer/LoadBalancerService.scala
 ##
 @@ -77,16 +82,32 @@ trait LoadBalancer {
  */
 def publish(action: ExecutableWhiskAction, msg: 
ActivationMessage)(implicit transid: TransactionId): 
Future[Future[Either[ActivationId, WhiskActivation]]]
 
+/**
+ * Return a message indicating the health of the containers and/or 
container pool in general
+ * @return a Future[String] representing the heal response that will be 
sent to the client
+ */
+def getHealthResponse: Future[String]
 
 Review comment:
   This should not be a `String` but rather a `JsObject` . It needs to contain 
the health of each invoker specifically.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] markusthoemmes commented on a change in pull request #2584: SPI for Loadbalancer

2017-08-08 Thread git
markusthoemmes commented on a change in pull request #2584: SPI for Loadbalancer
URL: 
https://github.com/apache/incubator-openwhisk/pull/2584#discussion_r131842341
 
 

 ##
 File path: 
common/scala/src/main/scala/whisk/core/database/CouchDbStoreProvider.scala
 ##
 @@ -36,10 +38,17 @@ class CouchDbStoreProvider extends ArtifactStoreProvider {
 require(config.dbProvider == "Cloudant" || config.dbProvider == 
"CouchDB", "Unsupported db.provider: " + config.dbProvider)
 assume(Set(config.dbProtocol, config.dbHost, config.dbPort, 
config.dbUsername, config.dbPassword, name(config)).forall(_.nonEmpty), "At 
least one expected property is missing")
 
-new CouchDbRestStore[D](config.dbProtocol, config.dbHost, 
config.dbPort.toInt, config.dbUsername, config.dbPassword, name(config))
+val storeName = name(config)
+stores.get(storeName) match {
 
 Review comment:
   There's `getOrElseUpdate` on scala's maps. You can use it like this:
   
   ```scala
   storeName.getOrElseUpdate(storeName, new 
CouchDbRestStore[D](config.dbProtocol, config.dbHost, config.dbPort.toInt, 
config.dbUsername, config.dbPassword, storeName))
   ```
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services