[GitHub] cbickel closed pull request #2664: Apply prereqs serially to prevent installation conflicts.
cbickel closed pull request #2664: Apply prereqs serially to prevent installation conflicts. URL: https://github.com/apache/incubator-openwhisk/pull/2664 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lzbj commented on a change in pull request #366: Support more runtime types from bluemix host info.
lzbj commented on a change in pull request #366: Support more runtime types
from bluemix host info.
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/366#discussion_r134910486
##
File path: tests/src/integration/common/wskdeploy.go
##
@@ -47,17 +47,17 @@ func (wskdeploy *Wskdeploy) RunCommand(s ...string)
([]byte, error) {
}
func (wskdeploy *Wskdeploy) Deploy(manifestPath string, deploymentPath string)
([]byte, error) {
- return wskdeploy.RunCommand("-m", manifestPath, "-d", deploymentPath)
+ return wskdeploy.RunCommand("-i ", "false", "-m", manifestPath, "-d",
deploymentPath)
Review comment:
ok, got it, correct, I'll update the code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] houshengbo opened a new pull request #384: Fail the travis build as early as possible
houshengbo opened a new pull request #384: Fail the travis build as early as possible URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/384 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lzbj commented on a change in pull request #262: Adjust the code to reflect latest API gateway version.
lzbj commented on a change in pull request #262: Adjust the code to reflect latest API gateway version. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/262#discussion_r134910320 ## File path: tests/src/integration/apigateway/manifest.yml ## @@ -0,0 +1,18 @@ +package: + name: book club + version: 1.0 + license: Apache-2.0 + apis: # new top-level key for defining groups of named APIs Review comment: @mrutkows , just review the manifest file, no worry about other code, it's not finished yet. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lzbj commented on issue #262: Adjust the code to reflect latest API gateway version.
lzbj commented on issue #262: Adjust the code to reflect latest API gateway version. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/262#issuecomment-324508805 Ok, I didn't notice that, but no worry, I think the master branch code needs some updates, as well as the unitary tests, it based on some wrong branch of code and tested some un used function return values. Just want to confirm with you the manifest I updated about the api definition is correct. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ningyougang commented on issue #2662: Add judge condition for invoker deployment
ningyougang commented on issue #2662: Add judge condition for invoker deployment
URL:
https://github.com/apache/incubator-openwhisk/pull/2662#issuecomment-324501518
@markusthoemmes
Can we implement a recreate behavior like we have for all our
components?
answer: if use `recreate` feature, because `invoker` is special, it will
cause problem.
as you know `user's action containers are created by invoker`, if use
`recreate`, those action containers will be removed when `invoker` is recreated.
So i think the best way to `redeploy invoker` using `-e mode=clean` first
and `-e mode=deploy`.
another thing, current, we use `shell script` to deploy invoker, it seems
not support `recreate`(docker_container module supports it)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ningyougang commented on issue #2662: Add judge condition for invoker deployment
ningyougang commented on issue #2662: Add judge condition for invoker deployment
URL:
https://github.com/apache/incubator-openwhisk/pull/2662#issuecomment-324501518
@markusthoemmes
Can we implement a recreate behavior like we have for all our
components?
answer: if use `recreate` feature, because `invoker` is special, it will
cause problem.
as you know `user's action container is created by invoker`, if use
`recreate`, those action containers will be removed when `invoker` is recreated.
So i think the best way to `redeploy invoker` using `-e mode=clean` first
and `-e mode=deploy`.
another thing, current, we use `shell script` to deploy invoker, it seems
not support `recreate`(docker_container module supports it)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ningyougang commented on issue #2662: Add judge condition for invoker deployment
ningyougang commented on issue #2662: Add judge condition for invoker deployment
URL:
https://github.com/apache/incubator-openwhisk/pull/2662#issuecomment-324501518
@markusthoemmes
Can we implement a recreate behavior like we have for all our
components?
answer: if use `recreate` feature, because `invoker` is special, it will
cause problem.
as you know `user's action container is created by invoker`, if use
`recreate`, those action containers will be removed when `invoker` is recreated.
So i think the best way to `redeploy invoker` using `-e mode=clean` first
and `-e mode=deploy`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ningyougang commented on issue #2662: Add judge condition for invoker deployment
ningyougang commented on issue #2662: Add judge condition for invoker deployment
URL:
https://github.com/apache/incubator-openwhisk/pull/2662#issuecomment-324501518
@markusthoemmes
Can we implement a recreate behavior like we have for all our
components?
answer: if use `recreate` feature, because `invoker` is special, it will
cause problem.
as you know `user's action container is created by invoker`, if use
`recreate`, those action containers will be removed when `invoker` is stoped.
So i think the best way to `redeploy invoker` using `-e mode=clean` first
and `-e mode=deploy`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ningyougang commented on issue #2662: Add judge condition for invoker deployment
ningyougang commented on issue #2662: Add judge condition for invoker deployment URL: https://github.com/apache/incubator-openwhisk/pull/2662#issuecomment-324501518 @markusthoemmes Can we implement a recreate behavior like we have for all our components? answer: if use `recreate` feature, because `invoker` is special, it will cause problem. as you know `user's action container is created by invoker`, if use `recreate`, those action containers will be removed when `invoker` is stoped. So i think the best way to `redeploy invoker` using `-e mode=clean` first and `-e mode=deploy`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ningyougang commented on issue #2662: Add judge condition for invoker deployment
ningyougang commented on issue #2662: Add judge condition for invoker deployment URL: https://github.com/apache/incubator-openwhisk/pull/2662#issuecomment-324501518 @markusthoemmes Can we implement a recreate behavior like we have for all our components? answer: if use `recreate` feature, because `invoker` is special, it will cause problem. as you know `user's action container is created by invoker`, if use `recreate`, those action containers will be removed when `invoker` is stoped. So i think the best way to `redeploy invoker` using `-e mode=clean` first and `-e mode=deploy`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #57: removed the experimental from API Url.
csantanapr commented on issue #57: removed the experimental from API Url. URL: https://github.com/apache/incubator-openwhisk-client-js/pull/57#issuecomment-324500704 This is resolved now by #67 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #57: removed the experimental from API Url.
csantanapr closed pull request #57: removed the experimental from API Url. URL: https://github.com/apache/incubator-openwhisk-client-js/pull/57 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #63: style: add .editorconfig, eslint and reformat js file
csantanapr commented on issue #63: style: add .editorconfig, eslint and reformat js file URL: https://github.com/apache/incubator-openwhisk-client-js/pull/63#issuecomment-324500642 Did you already submitted an ICLA to Apache? https://github.com/apache/incubator-openwhisk-client-js/blob/master/CONTRIBUTING.md#contributor-license-agreement This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #65: feat: Support version when create / update action
csantanapr closed pull request #65: feat: Support version when create / update action URL: https://github.com/apache/incubator-openwhisk-client-js/pull/65 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #52: Deprecate "experimental" API Gateway
csantanapr closed issue #52: Deprecate "experimental" API Gateway URL: https://github.com/apache/incubator-openwhisk-client-js/issues/52 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #67: Remove "experimental" API Gateway support.
csantanapr closed pull request #67: Remove "experimental" API Gateway support. URL: https://github.com/apache/incubator-openwhisk-client-js/pull/67 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on a change in pull request #366: Support more runtime types from bluemix host info.
pritidesai commented on a change in pull request #366: Support more runtime
types from bluemix host info.
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/366#discussion_r134899296
##
File path: tests/src/integration/common/wskdeploy.go
##
@@ -47,17 +47,17 @@ func (wskdeploy *Wskdeploy) RunCommand(s ...string)
([]byte, error) {
}
func (wskdeploy *Wskdeploy) Deploy(manifestPath string, deploymentPath string)
([]byte, error) {
- return wskdeploy.RunCommand("-m", manifestPath, "-d", deploymentPath)
+ return wskdeploy.RunCommand("-i ", "false", "-m", manifestPath, "-d",
deploymentPath)
Review comment:
@lzbj I think the intent here was to disable interactive mode, but now like
Matt is saying it is disabled by default, so you don't need this flag "-i" here
at all. If you specify "-i" now on wskdeploy CMD line, interactive mode is
turned on.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] pritidesai commented on a change in pull request #375: Make interative mode able to set to false
pritidesai commented on a change in pull request #375: Make interative mode
able to set to false
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/375#discussion_r134898915
##
File path: deployers/servicedeployer.go
##
@@ -119,7 +119,7 @@ func (deployer *ServiceDeployer) ConstructDeploymentPlan()
error {
manifestReader.InitRootPackage(manifestParser, manifest)
- if deployer.IsDefault == true && !utils.Flags.WithinOpenWhisk {
Review comment:
@lionelvillard had added this flag to indicate that the wskdeploy is being
run as an OpenWhisk action itself. If it is being run as an OpenWhisk action
than skip this whole block of execution where wskdeploy is reading and
inspecting project directory where action files are located, reading content of
the action files and setting exec.Code of an ActionRecord. Hope this helps. We
cannot set exec.Code this way if wskdeploy is running as an OpenWhisk action as
none of the directory structure is accessible in cloud. But than I am trying to
figure out myself what is the use of having wskdeploy run as an OpenWhisk
action.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mrutkows commented on issue #365: Bluemix Stage 1 errors creating triggers
mrutkows commented on issue #365: Bluemix Stage 1 errors creating triggers URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/365#issuecomment-324490169 @zachschultz @daisy-ycguo Daisy, did you test this with BlueWhisk or local OpenWhisk? You steps indicate "Have a clean OpenWhisk environment" this implies local (not Bluemix OpenWhisk unless you mean the account has not Actions/Triggers/Rules, etc.)? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #360: Validate integration tests are running as part of Travis build
mrutkows commented on issue #360: Validate integration tests are running as part of Travis build URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/360#issuecomment-324488938 WIP PR: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/372 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #374: Interactive mode should be configurable
mrutkows commented on issue #374: Interactive mode should be configurable URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/374#issuecomment-324488020 fixed in https://github.com/apache/incubator-openwhisk-wskdeploy/pull/375 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #374: Interactive mode should be configurable
mrutkows closed issue #374: Interactive mode should be configurable URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/374 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed pull request #379: Remove the explicit api keys to access kafka service
mrutkows closed pull request #379: Remove the explicit api keys to access kafka service URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/379 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed issue #125: remove step to set namespace from the docs
houshengbo closed issue #125: remove step to set namespace from the docs URL: https://github.com/apache/incubator-openwhisk-package-cloudant/issues/125 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #126: update doc to remove the namespace step for CLI no need it anymore
houshengbo closed pull request #126: update doc to remove the namespace step for CLI no need it anymore URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/126 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #126: update doc to remove the namespace set for CLI no need it anymore
csantanapr opened a new pull request #126: update doc to remove the namespace set for CLI no need it anymore URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/126 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai opened a new issue #383: Delete openwhisk credentials from manifest and deployment files
pritidesai opened a new issue #383: Delete openwhisk credentials from manifest and deployment files URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/383 We have few integration tests with manifest and deployment files which have hardcoded credentials including api host and api key. Please remove these credentials from the yaml files. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai opened a new issue #382: Rename manifest and deployment files under tests/dat/...
pritidesai opened a new issue #382: Rename manifest and deployment files under tests/dat/... URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/382 We have bunch of manifest and deployment files under https://github.com/apache/incubator-openwhisk-wskdeploy/tree/master/tests/dat: ``` deploy1.yaml deploy2.yaml deploy3.yaml deploy4.yaml deployment.yaml manifest1.yaml manifest3.yaml manifest4.yaml manifest5.yaml manifest6.yaml ``` Rename these files to something meaningful and update the test cases which are using these files. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai opened a new issue #381: Move manifest.yml and manifest.yaml out of integration test
pritidesai opened a new issue #381: Move manifest.yml and manifest.yaml out of integration test URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/381 Integration tests should not have manifest.yaml and manifest.yml files. Please move them to https://github.com/apache/incubator-openwhisk-wskdeploy/tree/master/tests/dat and convert the following integration tests into unit tests: TestSupportManifestYamlPath TestSupportManifestYmlPath TestSupportManifestYamlDeployment TestSupportManifestYmlDeployment Our integration tests should define manifest and deployment of any legit application. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai opened a new issue #380: Add unit tests to verify that wskdeploy is able to load credentials
pritidesai opened a new issue #380: Add unit tests to verify that wskdeploy is able to load credentials URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/380 We have a plan to follow precedence order of setting whisk credentials: - API host for the OpenWhisk deployment - API key for the subject invoking the action - Namespace for the activation Here is the precedence order: (1) Deployment/Manifest file (2) whisk properties / wskprops file (3) Environment variables Add verification in wskdeploy to verify that these credentials are being set before it attempts to run deployment/undeployment. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new issue #125: remove step to set namespace from the docs
csantanapr opened a new issue #125: remove step to set namespace from the docs URL: https://github.com/apache/incubator-openwhisk-package-cloudant/issues/125 Now the feed action takes the namespace from the env variable in the action `process.env.__OW_NAMESPACE` there is no requirement for the whisk client to send the namespace. Also now that openwhisk has a unique api key per namespace, user can't switch to a different namespace with the same key, and this is why all clients should be configured with namespace `_` and the identity is retrieve using api key. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #379: Remove the explicit api keys to access kafka service
houshengbo commented on issue #379: Remove the explicit api keys to access kafka service URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/379#issuecomment-324449176 @daisy-ycguo @lzbj Please be advised that do not put valid keys of other services in the repos. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #379: Remove the explicit api keys to access kafka service
houshengbo commented on issue #379: Remove the explicit api keys to access kafka service URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/379#issuecomment-324449176 @daisy-ycguo @lzbj Please be advised that do not put valid keys in the repos. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #379: Remove the explicit api keys to access kafka service
houshengbo opened a new pull request #379: Remove the explicit api keys to access kafka service URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/379 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zachschultz commented on issue #305: Wondering why triggers are updated with overwrite set to false
zachschultz commented on issue #305: Wondering why triggers are updated with overwrite set to false URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/305#issuecomment-324447025 @mrutkows let me build a wskdeploy with that PR included to test if it works This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zachschultz commented on issue #365: Bluemix Stage 1 errors creating triggers
zachschultz commented on issue #365: Bluemix Stage 1 errors creating triggers
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/365#issuecomment-32913
@daisy-ycguo thank you! For some reason, now I am able to get the triggers
and rules working when I push data to cloudant/message-hub, however when I run
wskdeploy for the message-hub blueprint I'm still getting the extra action that
looks like this:
```
Error creating trigger: {
"name": "StatusCodeError",
"statusCode": 500,
"message": "500 - \"Error: Document update conflict.\"",
"error": "Error: Document update conflict.",
"options": {
"method": "PUT",
"url":
"https://10.121.10.111/api/v1/web/whisk.system/messagingWeb/messageHubFeedWeb.http";,
"rejectUnauthorized": false,
"json": true,
"body": {
// REST OF PERSONAL DATA OMITTED (USER/PASS/etc.)
"triggerName": "/zachary.schultz_ow/message-received-trigger",
},
"headers": {
"Content-Type": "application/json",
"Accept": "text/plain",
"User-Agent": "whisk"
},
"simple": true,
"resolveWithFullResponse": false,
"transform2xxOnly": false
},
"response": {
"statusCode": 500,
"body": "Error: Document update conflict.",
"headers": {
"server": "nginx/1.11.13",
"date": "Wed, 23 Aug 2017 19:49:56 GMT",
"content-type": "text/plain",
"content-length": "32",
"connection": "close",
"access-control-allow-origin": "*",
"access-control-allow-methods": "OPTIONS, GET, DELETE, POST, PUT,
HEAD, PATCH",
"access-control-allow-headers": "Authorization, Content-Type"
},
"request": {
"uri": {
"protocol": "https:",
"slashes": true,
"auth": null,
"host": "10.121.10.111",
"port": 443,
"hostname": "10.121.10.111",
"hash": null,
"search": null,
"query": null,
"pathname":
"/api/v1/web/whisk.system/messagingWeb/messageHubFeedWeb.http",
"path":
"/api/v1/web/whisk.system/messagingWeb/messageHubFeedWeb.http",
"href":
"https://10.121.10.111/api/v1/web/whisk.system/messagingWeb/messageHubFeedWeb.http";
},
"method": "PUT",
"headers": {
"Content-Type": "application/json",
"Accept": "text/plain",
"User-Agent": "whisk",
"content-length": 707
}
}
}
}
```
Everything seems to work though, but I am still getting that message
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mrutkows commented on issue #305: Wondering why triggers are updated with overwrite set to false
mrutkows commented on issue #305: Wondering why triggers are updated with overwrite set to false URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/305#issuecomment-324429472 @zachschultz can u verify if PR 337 allows this issue to be resolved? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on a change in pull request #366: Support more runtime types from bluemix host info.
mrutkows commented on a change in pull request #366: Support more runtime types
from bluemix host info.
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/366#discussion_r134838424
##
File path: tests/src/integration/common/wskdeploy.go
##
@@ -47,17 +47,17 @@ func (wskdeploy *Wskdeploy) RunCommand(s ...string)
([]byte, error) {
}
func (wskdeploy *Wskdeploy) Deploy(manifestPath string, deploymentPath string)
([]byte, error) {
- return wskdeploy.RunCommand("-m", manifestPath, "-d", deploymentPath)
+ return wskdeploy.RunCommand("-i ", "false", "-m", manifestPath, "-d",
deploymentPath)
Review comment:
Just merged
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/375, we now have
the flag "UserInteractive" (default to false), but need to verify on this issue
if it had the desired effect.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] zachschultz commented on issue #305: Wondering why triggers are updated with overwrite set to false
zachschultz commented on issue #305: Wondering why triggers are updated with overwrite set to false URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/305#issuecomment-324426120 Hi @daisy-ycguo, thanks for the PR! What was happening for us was that if we changed our manifest.yaml file to change the trigger in any way, no updates were actually propagating through because of the `overwrite=false` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed pull request #375: Make interative mode able to set to false
mrutkows closed pull request #375: Make interative mode able to set to false URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/375 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on a change in pull request #375: Make interative mode able to set to false
mrutkows commented on a change in pull request #375: Make interative mode able
to set to false
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/375#discussion_r134835273
##
File path: deployers/servicedeployer.go
##
@@ -119,7 +119,7 @@ func (deployer *ServiceDeployer) ConstructDeploymentPlan()
error {
manifestReader.InitRootPackage(manifestParser, manifest)
- if deployer.IsDefault == true && !utils.Flags.WithinOpenWhisk {
Review comment:
I am curious as why we were testing "WithinOpenWhisk" here in the first
place...
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ert78gb commented on issue #65: feat: Support version when create / update action
ert78gb commented on issue #65: feat: Support version when create / update action URL: https://github.com/apache/incubator-openwhisk-client-js/pull/65#issuecomment-324414192 I resolved the conflict pls merge or close my PR-s. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #65: feat: Support version when create / update action
codecov-io commented on issue #65: feat: Support version when create / update action URL: https://github.com/apache/incubator-openwhisk-client-js/pull/65#issuecomment-320595097 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/65?src=pr&el=h1) Report > Merging [#65](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/65?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk-client-js/commit/6f4a9fdf91d898ab6b604b8eb92310f43391ec23?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/65?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #65 +/- ## == + Coverage 99.37% 99.37% +<.01% == Files 14 14 Lines 318 320 +2 == + Hits 316 318 +2 Misses 22 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/65?src=pr&el=tree) | Coverage ? | | |---|---|---| | [lib/actions.js](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/65?src=pr&el=tree#diff-bGliL2FjdGlvbnMuanM=) | `100% <100%> (?)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/65?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/65?src=pr&el=footer). Last update [6f4a9fd...52b2df3](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/65?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #2544: Allow CLI to Save Code from Action (Review)
dubeejw commented on issue #2544: Allow CLI to Save Code from Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2544#issuecomment-324409729 @mdeuser, @csantanapr, needs review. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #2544: Allow CLI to Save Code from Action (Review)
dubeejw commented on issue #2544: Allow CLI to Save Code from Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2544#issuecomment-324409648 PG4 720. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed pull request #377: Allow trigger update when creating triggers
mrutkows closed pull request #377: Allow trigger update when creating triggers URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/377 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on a change in pull request #377: Allow trigger update when creating triggers
mrutkows commented on a change in pull request #377: Allow trigger update when creating triggers URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/377#discussion_r134787180 ## File path: deployers/servicedeployer.go ## @@ -412,7 +412,7 @@ func (deployer *ServiceDeployer) createFeedAction(trigger *whisk.Trigger, feedNa Publish: &pub, } - _, _, err := deployer.Client.Triggers.Insert(t, false) + _, _, err := deployer.Client.Triggers.Insert(t, true) Review comment: Defaulting to override=true as the default matches all the other Insert() calls for all other entities. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tysonnorris commented on issue #2663: Simplify Spi implementations.
tysonnorris commented on issue #2663: Simplify Spi implementations. URL: https://github.com/apache/incubator-openwhisk/pull/2663#issuecomment-324369051 Looks good - Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #378: Overwrite (true) should be a configurable option
mrutkows commented on issue #378: Overwrite (true) should be a configurable option URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/378#issuecomment-324359459 At the time of this issue being opened here are all the places we hardcoded the default: Matt$ grep -r "Insert" . *.g ./deployers/servicedeployer.go: _, _, err := deployer.Client.Packages.Insert(packa, true) ./deployers/servicedeployer.go: _, _, err := deployer.Client.Packages.Insert(packa, true) ./deployers/servicedeployer.go: _, _, err := deployer.Client.Triggers.Insert(trigger, true) ./deployers/servicedeployer.go: _, _, err := deployer.Client.Triggers.Insert(t, false) ./deployers/servicedeployer.go: _, _, err := deployer.Client.Rules.Insert(rule, true) ./deployers/servicedeployer.go: _, _, err := deployer.Client.Actions.Insert(action, true) ./deployers/servicedeployer.go: _, _, err := deployer.Client.Apis.Insert(api, nil, true) Binary file ./wskdeploy matches This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new issue #378: Overwrite (true) should be a configurable option
mrutkows opened a new issue #378: Overwrite (true) should be a configurable option URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/378 Perhaps "overwrite=true" should be our default behavior, but we should give user a command line option to turn this off for all entities. See issue where we changed default behavior for Triggers (as an example). https://github.com/apache/incubator-openwhisk-wskdeploy/pull/377 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #2544: Allow CLI to Save Code from Action (Review)
dubeejw commented on issue #2544: Allow CLI to Save Code from Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2544#issuecomment-323453201 TODO: - ~~Handle `sequence` as kind~~ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #262: Adjust the code to reflect latest API gateway version.
mrutkows commented on issue #262: Adjust the code to reflect latest API gateway version. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/262#issuecomment-324355802 @lzbj Build error in Travis... ``` $ make build Installing dependencies go get -d -t ./... Testing go test ./... -tags=unit ?github.com/apache/incubator-openwhisk-wskdeploy [no test files] # github.com/apache/incubator-openwhisk-wskdeploy/parsers parsers/manifest_parser_test.go:497: assignment count mismatch: 3 = 2 parsers/manifest_parser_test.go:543: assignment count mismatch: 3 = 2 parsers/manifest_parser_test.go:562: assignment count mismatch: 3 = 2 parsers/manifest_parser_test.go:647: assignment count mismatch: 3 = 2 parsers/manifest_parser_test.go:727: assignment count mismatch: 3 = 2 parsers/manifest_parser_test.go:815: assignment count mismatch: 3 = 2 ok github.com/apache/incubator-openwhisk-wskdeploy/cmd 0.008s ok github.com/apache/incubator-openwhisk-wskdeploy/deployers 0.010s FAIL github.com/apache/incubator-openwhisk-wskdeploy/parsers [build failed] ? github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/common [no test files] ok github.com/apache/incubator-openwhisk-wskdeploy/utils 0.968s ?github.com/apache/incubator-openwhisk-wskdeploy/wski18n [no test files] make: *** [test] Error 2 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #262: Adjust the code to reflect latest API gateway version.
mrutkows commented on issue #262: Adjust the code to reflect latest API gateway version. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/262#issuecomment-324355802 @lzbj Build error... ``` $ make build Installing dependencies go get -d -t ./... Testing go test ./... -tags=unit ?github.com/apache/incubator-openwhisk-wskdeploy [no test files] # github.com/apache/incubator-openwhisk-wskdeploy/parsers parsers/manifest_parser_test.go:497: assignment count mismatch: 3 = 2 parsers/manifest_parser_test.go:543: assignment count mismatch: 3 = 2 parsers/manifest_parser_test.go:562: assignment count mismatch: 3 = 2 parsers/manifest_parser_test.go:647: assignment count mismatch: 3 = 2 parsers/manifest_parser_test.go:727: assignment count mismatch: 3 = 2 parsers/manifest_parser_test.go:815: assignment count mismatch: 3 = 2 ok github.com/apache/incubator-openwhisk-wskdeploy/cmd 0.008s ok github.com/apache/incubator-openwhisk-wskdeploy/deployers 0.010s FAIL github.com/apache/incubator-openwhisk-wskdeploy/parsers [build failed] ? github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/common [no test files] ok github.com/apache/incubator-openwhisk-wskdeploy/utils 0.968s ?github.com/apache/incubator-openwhisk-wskdeploy/wski18n [no test files] make: *** [test] Error 2 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on a change in pull request #2591: User-Agent CLI/version header
dubeejw commented on a change in pull request #2591: User-Agent CLI/version header URL: https://github.com/apache/incubator-openwhisk/pull/2591#discussion_r134762726 ## File path: tools/cli/go-whisk/whisk/client.go ## @@ -47,6 +47,7 @@ const ( DoNotProcessTimeOut = false ExitWithErrorOnTimeout = true ExitWithSuccessOnTimeout = false +UserAgent = "OpenWhisk-CLI/" Review comment: Agreed. `go-whisk` does not know that it is part of a CLI. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes closed pull request #2592: Make the result of response consistent for both Wsk CLI and REST
markusthoemmes closed pull request #2592: Make the result of response consistent for both Wsk CLI and REST URL: https://github.com/apache/incubator-openwhisk/pull/2592 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes opened a new pull request #2664: Apply prereqs serially to prevent installation conflicts.
markusthoemmes opened a new pull request #2664: Apply prereqs serially to prevent installation conflicts. URL: https://github.com/apache/incubator-openwhisk/pull/2664 Using the same host for different "machines" seems to cause trouble when trying to concurrently install packages. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #2661: Add tests to check ha of controller
markusthoemmes commented on a change in pull request #2661: Add tests to check
ha of controller
URL:
https://github.com/apache/incubator-openwhisk/pull/2661#discussion_r134739982
##
File path: tests/src/test/scala/ha/ShootComponentsTests.scala
##
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package ha
+
+import java.io.File
+import java.time.Instant
+
+import scala.concurrent.Future
+import scala.concurrent.duration.DurationInt
+import scala.util.Try
+
+import org.junit.runner.RunWith
+import org.scalatest.FlatSpec
+import org.scalatest.Matchers
+import org.scalatest.concurrent.ScalaFutures
+import org.scalatest.junit.JUnitRunner
+
+import akka.http.scaladsl.Http
+import akka.http.scaladsl.model.HttpRequest
+import akka.http.scaladsl.model.StatusCodes
+import akka.http.scaladsl.unmarshalling.Unmarshal
+import akka.stream.ActorMaterializer
+import common.TestUtils
+import common.WaitFor
+import common.WhiskProperties
+import common.Wsk
+import common.WskActorSystem
+import common.WskProps
+import common.WskTestHelpers
+import whisk.core.WhiskConfig
+import whisk.utils.retry
+
+@RunWith(classOf[JUnitRunner])
+class ShootComponentsTests
+extends FlatSpec
+with Matchers
+with WaitFor
+with WskTestHelpers
+with ScalaFutures
+with WskActorSystem {
+
+implicit val wskprops = WskProps()
+val wsk = new Wsk
+val defaultAction = Some(TestUtils.getTestActionFilename("hello.js"))
+val python = WhiskProperties.python
Review comment:
Unused.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on issue #2663: Simplify Spi implementations.
markusthoemmes commented on issue #2663: Simplify Spi implementations. URL: https://github.com/apache/incubator-openwhisk/pull/2663#issuecomment-324314498 @tysonnorris would you do me the honors? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes opened a new pull request #2663: Simplify Spi implementations.
markusthoemmes opened a new pull request #2663: Simplify Spi implementations. URL: https://github.com/apache/incubator-openwhisk/pull/2663 Using `object`s instead of a hollow class as the "factory" for an Spi makes them being singleton by default, which reduces boilerplate to implement an Spi. The `Dependencies` object is not used anywhere and there might be better alternatives which we can decide on once the need of them comes up. For now, the Spi's interfaces are relatively tightly coupled to their current default implementations anyway. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #2632: Use the stale parameter on listing activations
markusthoemmes commented on a change in pull request #2632: Use the stale parameter on listing activations URL: https://github.com/apache/incubator-openwhisk/pull/2632#discussion_r134729543 ## File path: common/scala/src/main/scala/whisk/core/database/ArtifactStore.scala ## @@ -28,6 +28,14 @@ import whisk.common.Logging import whisk.common.TransactionId import whisk.core.entity.DocInfo +abstract class StaleParameter(val value: Option[String]) + Review comment: Ugh, right. Should've looked up the whole pattern. Only relevant if you want to match against them and have the compiler check for an incomplete match. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #2632: Use the stale parameter on listing activations
rabbah commented on a change in pull request #2632: Use the stale parameter on listing activations URL: https://github.com/apache/incubator-openwhisk/pull/2632#discussion_r134728525 ## File path: common/scala/src/main/scala/whisk/core/database/ArtifactStore.scala ## @@ -28,6 +28,14 @@ import whisk.common.Logging import whisk.common.TransactionId import whisk.core.entity.DocInfo +abstract class StaleParameter(val value: Option[String]) + Review comment: Could have sealed this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #2632: Use the stale parameter on listing activations
rabbah commented on a change in pull request #2632: Use the stale parameter on
listing activations
URL:
https://github.com/apache/incubator-openwhisk/pull/2632#discussion_r134729025
##
File path: common/scala/src/main/scala/whisk/core/entity/WhiskStore.scala
##
@@ -205,12 +208,13 @@ object WhiskEntityQueries {
def listEntitiesInNamespace[A <: WhiskEntity](
db: ArtifactStore[A],
namespace: EntityPath,
-includeDocs: Boolean)(
+includeDocs: Boolean,
+stale: StaleParameter = StaleParameter.No)(
implicit transid: TransactionId): Future[Map[String,
List[JsObject]]] = {
implicit val ec = db.executionContext
val startKey = List(namespace.toString)
val endKey = List(namespace.toString, TOP)
-db.query(viewname(ENTITIES), startKey, endKey, 0, 0, includeDocs,
descending = true, reduce = false) map {
+db.query(viewname(ENTITIES), startKey, endKey, 0, 0, includeDocs,
descending = true, reduce = false, stale = stale) map {
Review comment:
I would have used just stale instead of stale = stale; since the name is
indicative vs just a Boolean.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on issue #2662: Add judge condition for invoker deployment
markusthoemmes commented on issue #2662: Add judge condition for invoker deployment URL: https://github.com/apache/incubator-openwhisk/pull/2662#issuecomment-324305304 Can we implement a recreate behavior like we have for all our components? We should somehow use ansible's capabilities to detect changed components and leave those alone that can live unchanged. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes closed pull request #2632: Use the stale parameter on listing activations
markusthoemmes closed pull request #2632: Use the stale parameter on listing activations URL: https://github.com/apache/incubator-openwhisk/pull/2632 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cbickel commented on issue #2624: Add cache invalidation between controllers
cbickel commented on issue #2624: Add cache invalidation between controllers URL: https://github.com/apache/incubator-openwhisk/pull/2624#issuecomment-323926734 PG3#1026 is ? PG4#717 is ? (23.08.2017) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cbickel commented on issue #2624: Add cache invalidation between controllers
cbickel commented on issue #2624: Add cache invalidation between controllers URL: https://github.com/apache/incubator-openwhisk/pull/2624#issuecomment-323926734 PG3#1026 is ? PG4#717 is ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cbickel commented on issue #2661: Add tests to check ha of controller
cbickel commented on issue #2661: Add tests to check ha of controller URL: https://github.com/apache/incubator-openwhisk/pull/2661#issuecomment-324302436 PG3#1031 is ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ningyougang opened a new pull request #2662: Add judge condition for invoker deployment
ningyougang opened a new pull request #2662: Add judge condition for invoker deployment URL: https://github.com/apache/incubator-openwhisk/pull/2662 If invokers have been deployed success. Then, it will report error when execute `ansible-playbook -i environments/ invoker.yml ` again. because the invoker0 or invoker1 alreay exist, so below errors will appear. ``` TASK [invoker : start invoker using docker cli] * ... ... You have to remove (or rename) that container to be able to reuse that name..\nSee 'docker run --help'.", "stderr_lines": ["docker: Error response from daemon: Conflict. The name \"/invoker0\" is already in use by container 1de4dc7d6ca3234d1b6590061e637c48367f9076766f767ef9271d1848e08620. You have to remove (or rename) that container to be able to reuse that name..", "See 'docker run --help'."], "stdout": "", "stdout_lines": []} [FAILED] ``` So it is necessary to add the `judge condition` that whether the invoker has been deployed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lzbj commented on issue #262: Adjust the code to reflect latest API gateway version.
lzbj commented on issue #262: Adjust the code to reflect latest API gateway version. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/262#issuecomment-324281667 @mrutkows , yes, rebased. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on issue #2632: Use the stale parameter on listing activations
markusthoemmes commented on issue #2632: Use the stale parameter on listing activations URL: https://github.com/apache/incubator-openwhisk/pull/2632#issuecomment-324264729 A few nits. Travis will suffice for the fixes. Very well done ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #2632: Use the stale parameter on listing activations
markusthoemmes commented on a change in pull request #2632: Use the stale
parameter on listing activations
URL:
https://github.com/apache/incubator-openwhisk/pull/2632#discussion_r134692402
##
File path: common/scala/src/main/scala/whisk/core/entity/WhiskStore.scala
##
@@ -337,9 +348,10 @@ trait WhiskEntityQueries[T] {
limit: Int,
docs: Boolean = false,
since: Option[Instant] = None,
-upto: Option[Instant] = None)(
+upto: Option[Instant] = None,
+stale: StaleParameter)(
Review comment:
Default param?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #2632: Use the stale parameter on listing activations
markusthoemmes commented on a change in pull request #2632: Use the stale
parameter on listing activations
URL:
https://github.com/apache/incubator-openwhisk/pull/2632#discussion_r134692362
##
File path: common/scala/src/main/scala/whisk/core/entity/WhiskStore.scala
##
@@ -259,11 +266,12 @@ object WhiskEntityQueries {
limit: Int,
since: Option[Instant] = None,
upto: Option[Instant] = None,
+stale: StaleParameter,
Review comment:
Should this have a default value?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #2632: Use the stale parameter on listing activations
markusthoemmes commented on a change in pull request #2632: Use the stale
parameter on listing activations
URL:
https://github.com/apache/incubator-openwhisk/pull/2632#discussion_r134692316
##
File path: common/scala/src/main/scala/whisk/core/entity/WhiskStore.scala
##
@@ -243,11 +249,12 @@ object WhiskEntityQueries {
limit: Int,
since: Option[Instant] = None,
upto: Option[Instant] = None,
+stale: StaleParameter,
Review comment:
Should this have a default value?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #2632: Use the stale parameter on listing activations
markusthoemmes commented on a change in pull request #2632: Use the stale
parameter on listing activations
URL:
https://github.com/apache/incubator-openwhisk/pull/2632#discussion_r134692157
##
File path: common/scala/src/main/scala/whisk/core/database/ArtifactStore.scala
##
@@ -28,6 +28,11 @@ import whisk.common.Logging
import whisk.common.TransactionId
import whisk.core.entity.DocInfo
+abstract class StaleParameter(val value: Option[String])
+case object StaleOk extends StaleParameter(Some("ok"))
+case object StaleUpdateAfter extends StaleParameter(Some("update_after"))
+case object NoStale extends StaleParameter(None)
Review comment:
Awesome!!
One nit: You can wrap the implementations into a companion object like:
```scala
object StaleParameter {
case object Ok extends StaleParameter(Some("ok"))
case object UpdateAfter extends StaleParameter(Some("update_after"))
case object None extends StaleParameter(None)
}
```
I think that makes scoping a bit easier and its best practice.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #2632: Use the stale parameter on listing activations
markusthoemmes commented on a change in pull request #2632: Use the stale parameter on listing activations URL: https://github.com/apache/incubator-openwhisk/pull/2632#discussion_r134691857 ## File path: common/scala/src/main/scala/whisk/core/database/CouchDbRestClient.scala ## @@ -174,6 +174,7 @@ class CouchDbRestClient(protocol: String, host: String, port: Int, username: Str endKey: List[Any] = Nil, skip: Option[Int] = None, limit: Option[Int] = None, +stale: Option[String] = None, Review comment: Shouldn't this be `StaleParameter`? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cbickel opened a new pull request #2661: Add tests to check ha of controller
cbickel opened a new pull request #2661: Add tests to check ha of controller URL: https://github.com/apache/incubator-openwhisk/pull/2661 Add a test, that checks, that the hot standby controller is used as expected. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo commented on issue #305: Wondering why triggers are updated with overwrite set to false
daisy-ycguo commented on issue #305: Wondering why triggers are updated with overwrite set to false URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/305#issuecomment-324245683 @zachschultz There is a PR #377 to address this issue. But I'm very curious to your case. I think in your case, `message-received-trigger` is a feed trigger created based on an existing system feed: `whisk.system/messaging/messageHubFeed`. What's the new value you want to update the `source` of the `message-received-trigger`? I think, the original author thought feed trigger should not be updated. That's why he/she used 'false' in this case. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo commented on issue #305: Wondering why triggers are updated with overwrite set to false
daisy-ycguo commented on issue #305: Wondering why triggers are updated with overwrite set to false URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/305#issuecomment-324245683 @zachschultz There is a PR #377 to address this issue. But I'm very curious to your case. I think in your case, `message-received-trigger` is a feed trigger created based on an existing system feed: `whisk.system/messaging/messageHubFeed`. What's the new value you want to update the `source` of the `message-received-trigger`? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo commented on issue #305: Wondering why triggers are updated with overwrite set to false
daisy-ycguo commented on issue #305: Wondering why triggers are updated with overwrite set to false URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/305#issuecomment-324245683 @zachschultz There is a PR #377 to address this issue. But I'm very curious to your case. What's the new value you want to update the `source` of the `message-received-trigger`? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo opened a new pull request #377: Allow trigger update when creating triggers
daisy-ycguo opened a new pull request #377: Allow trigger update when creating triggers URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/377 When creating a feed trigger, set 'overwrite=true' Address issue #305 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
