[GitHub] cbickel commented on a change in pull request #2835: Move batching to CouchDbRestStore
cbickel commented on a change in pull request #2835: Move batching to
CouchDbRestStore
URL:
https://github.com/apache/incubator-openwhisk/pull/2835#discussion_r143120982
##
File path:
common/scala/src/main/scala/whisk/core/database/CouchDbRestStore.scala
##
@@ -61,6 +67,13 @@ class CouchDbRestStore[DocumentAbstraction <:
DocumentSerializer](
private val client: CouchDbRestClient =
new CouchDbRestClient(dbProtocol, dbHost, dbPort.toInt, dbUsername,
dbPassword, dbName)
+ // This the the amount of allowed parallel requests for each entity, before
batching starts. If there are already maxOpenDbRequests
+ // and more documents need to be stored, then all arriving documents will be
put into batches (if enabled) to avoid a long queue.
+ private val maxOpenDbRequests =
system.settings.config.getInt("akka.http.host-connection-pool.max-open-requests")
/ 2
+
+ private val batcher: Batcher[JsObject, Either[ArtifactStoreException,
DocInfo]] =
+new Batcher(500, maxOpenDbRequests)(put(_)(TransactionId.unknown))
Review comment:
Why do you think it should be configurable? Do you have a scenario in mind,
where you want to configure this size?
Btw: It is only the maximum allowed batch size.
When I was chatting with Cloudant developpers a while ago, we were talking
about such bulk requests. The scenario was a bit different, but very similar
(write documents as fast as possible into a database with _bulk). This person
suggested a batch size of 500.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ddragosd commented on a change in pull request #2828: option to use docker pause/unpause instead of docker-runc pause/unpause
ddragosd commented on a change in pull request #2828: option to use docker
pause/unpause instead of docker-runc pause/unpause
URL:
https://github.com/apache/incubator-openwhisk/pull/2828#discussion_r143121191
##
File path:
core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerContainer.scala
##
@@ -60,6 +61,7 @@ object DockerContainer {
network: String = "bridge",
dnsServers: Seq[String] = Seq(),
name: Option[String] = None,
+ useRunc: Boolean = true,
Review comment:
WDYT about making `config` an implicit param to avoid method signature
changes downstream ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ddragosd closed pull request #2796: Check if runc exists before using it ( WIP to fix #2788 )
ddragosd closed pull request #2796: Check if runc exists before using it ( WIP to fix #2788 ) URL: https://github.com/apache/incubator-openwhisk/pull/2796 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd commented on issue #2796: Check if runc exists before using it ( WIP to fix #2788 )
ddragosd commented on issue #2796: Check if runc exists before using it ( WIP to fix #2788 ) URL: https://github.com/apache/incubator-openwhisk/pull/2796#issuecomment-334676631 closing in favor of #2828 using a specific option to select whether to use `runc` or not, b/c auto-discovery is not straight forward. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd commented on a change in pull request #2821: Move java runtime into it's own repo
ddragosd commented on a change in pull request #2821: Move java runtime into
it's own repo
URL:
https://github.com/apache/incubator-openwhisk/pull/2821#discussion_r143122131
##
File path: core/javaAction/Dockerfile
##
@@ -1,38 +1 @@
-FROM buildpack-deps:trusty-curl
-
-ENV DEBIAN_FRONTEND noninteractive
-
-RUN locale-gen en_US.UTF-8
-ENV LANG en_US.UTF-8
-ENV LANGUAGE en_US:en
-ENV LC_ALL en_US.UTF-8
-
-ENV VERSION 8
-ENV UPDATE 131
-ENV BUILD 11
-
-ENV JAVA_HOME /usr/lib/jvm/java-${VERSION}-oracle
-ENV JRE_HOME ${JAVA_HOME}/jre
-
-RUN curl --silent --location --retry 3 --cacert
/etc/ssl/certs/GeoTrust_Global_CA.pem \
- --header "Cookie: oraclelicense=accept-securebackup-cookie;" \
-
http://download.oracle.com/otn-pub/java/jdk/"${VERSION}"u"${UPDATE}"-b"${BUILD}"/d54c1d3a095b4ff2b6607d096fa80163/server-jre-"${VERSION}"u"${UPDATE}"-linux-x64.tar.gz
\
- | tar xz -C /tmp && \
- mkdir -p /usr/lib/jvm && mv /tmp/jdk1.${VERSION}.0_${UPDATE} "${JAVA_HOME}"
&& \
- apt-get autoclean && apt-get --purge -y autoremove && \
- rm -rf /tmp/* /var/tmp/*
-
-RUN update-alternatives --install "/usr/bin/java" "java"
"${JRE_HOME}/bin/java" 1 && \
- update-alternatives --install "/usr/bin/javac" "javac"
"${JAVA_HOME}/bin/javac" 1 && \
- update-alternatives --set java "${JRE_HOME}/bin/java" && \
- update-alternatives --set javac "${JAVA_HOME}/bin/javac"
-
-ADD proxy /javaAction
-
-RUN rm -rf /javaAction/.classpath /javaAction/.gitignore /javaAction/.gradle
/javaAction/.project /javaAction/.settings /javaAction/Dockerfile
/javaAction/build
-
-RUN cd /javaAction; ./gradlew oneJar
-
-RUN rm -rf /javaAction/src
-
-CMD ["java", "-jar", "/javaAction/build/libs/javaAction-all.jar"]
+FROM openwhisk/java8action:1.0.0
Review comment:
?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] cbickel opened a new pull request #2838: Add check to controller and invoker that required databases exist
cbickel opened a new pull request #2838: Add check to controller and invoker that required databases exist URL: https://github.com/apache/incubator-openwhisk/pull/2838 This PR adds a check to the deployment playbooks of the controller and the invoker to check if all reuqired databases exist. Otherwise the deployment will fail. PG3#1170 is running. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #2832: Do not cache invalidate when adding a DB attachment
dubeejw commented on issue #2832: Do not cache invalidate when adding a DB attachment URL: https://github.com/apache/incubator-openwhisk/pull/2832#issuecomment-334659040 PG4 854 ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on a change in pull request #2828: option to use docker pause/unpause instead of docker-runc pause/unpause
dgrove-oss commented on a change in pull request #2828: option to use docker
pause/unpause instead of docker-runc pause/unpause
URL:
https://github.com/apache/incubator-openwhisk/pull/2828#discussion_r143187762
##
File path:
core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerContainer.scala
##
@@ -60,6 +61,7 @@ object DockerContainer {
network: String = "bridge",
dnsServers: Seq[String] = Seq(),
name: Option[String] = None,
+ useRunc: Boolean = true,
Review comment:
i originally made it an implicit and @rabbah requested that it not be an
implicit, so I reworked.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #2828: option to use docker pause/unpause instead of docker-runc pause/unpause
rabbah commented on a change in pull request #2828: option to use docker
pause/unpause instead of docker-runc pause/unpause
URL:
https://github.com/apache/incubator-openwhisk/pull/2828#discussion_r143191088
##
File path:
core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerContainer.scala
##
@@ -60,6 +61,7 @@ object DockerContainer {
network: String = "bridge",
dnsServers: Seq[String] = Seq(),
name: Option[String] = None,
+ useRunc: Boolean = true,
Review comment:
an implicit boolean is suspect. I think @ddragosd was perhaps thinking about
config as in whisk config? I prefer the explicit parameter here. Is there an
implication to the other container factories of concerns?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dgrove-oss commented on issue #2689: first stage of support for dynamic invoker id assignment
dgrove-oss commented on issue #2689: first stage of support for dynamic invoker id assignment URL: https://github.com/apache/incubator-openwhisk/pull/2689#issuecomment-334764041 2 comments in favor of merging on dev list and no objections. Good to go? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #596: publish to docker
houshengbo closed pull request #596: publish to docker URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/596 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alexsong93 opened a new pull request #258: Allow periods in managed url paths
alexsong93 opened a new pull request #258: Allow periods in managed url paths URL: https://github.com/apache/incubator-openwhisk-apigateway/pull/258 @mhamann This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] beemarie commented on issue #597: On tagged releases of wskdeploy, publish new docker image to openwhisk/wskdeploy
beemarie commented on issue #597: On tagged releases of wskdeploy, publish new docker image to openwhisk/wskdeploy URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/597#issuecomment-334835887 This can be closed, but I don't see my invite for contributor access. Can you resend it @mrutkows ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] beemarie commented on issue #597: On tagged releases of wskdeploy, publish new docker image to openwhisk/wskdeploy
beemarie commented on issue #597: On tagged releases of wskdeploy, publish new docker image to openwhisk/wskdeploy URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/597#issuecomment-334835887 This can be closed, but I don't see my invite for access. Can you resend it @mrutkows ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mhamann closed pull request #258: Allow periods in managed url paths
mhamann closed pull request #258: Allow periods in managed url paths URL: https://github.com/apache/incubator-openwhisk-apigateway/pull/258 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #597: On tagged releases of wskdeploy, publish new docker image to openwhisk/wskdeploy
houshengbo commented on issue #597: On tagged releases of wskdeploy, publish new docker image to openwhisk/wskdeploy URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/597#issuecomment-334870491 This issue is fixed by https://github.com/apache/incubator-openwhisk-wskdeploy/pull/596. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed issue #597: On tagged releases of wskdeploy, publish new docker image to openwhisk/wskdeploy
houshengbo closed issue #597: On tagged releases of wskdeploy, publish new docker image to openwhisk/wskdeploy URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/597 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd commented on a change in pull request #2828: option to use docker pause/unpause instead of docker-runc pause/unpause
ddragosd commented on a change in pull request #2828: option to use docker
pause/unpause instead of docker-runc pause/unpause
URL:
https://github.com/apache/incubator-openwhisk/pull/2828#discussion_r143300386
##
File path:
core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerContainer.scala
##
@@ -60,6 +61,7 @@ object DockerContainer {
network: String = "bridge",
dnsServers: Seq[String] = Seq(),
name: Option[String] = None,
+ useRunc: Boolean = true,
Review comment:
no implications to other container factories I believe. I just thought we
can keep the PR smaller, but if it makes more sense to be explicit with this
flag, ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubeejw commented on a change in pull request #2835: Move batching to CouchDbRestStore
dubeejw commented on a change in pull request #2835: Move batching to
CouchDbRestStore
URL:
https://github.com/apache/incubator-openwhisk/pull/2835#discussion_r143312484
##
File path: common/scala/src/main/scala/whisk/core/entity/WhiskStore.scala
##
@@ -130,8 +131,8 @@ object WhiskActivationStore {
dbPort -> null,
dbActivations -> null)
- def datastore(config: WhiskConfig)(implicit system: ActorSystem, logging:
Logging) =
-SpiLoader.get[ArtifactStoreProvider].makeStore[WhiskActivation](config,
_.dbActivations)
+ def datastore(config: WhiskConfig)(implicit system: ActorSystem, logging:
Logging, materializer: ActorMaterializer) =
Review comment:
Why not batch `WhiskEntityStore` as well?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubeejw commented on a change in pull request #2835: Move batching to CouchDbRestStore
dubeejw commented on a change in pull request #2835: Move batching to
CouchDbRestStore
URL:
https://github.com/apache/incubator-openwhisk/pull/2835#discussion_r143312652
##
File path:
common/scala/src/main/scala/whisk/core/database/CouchDbRestStore.scala
##
@@ -61,6 +67,13 @@ class CouchDbRestStore[DocumentAbstraction <:
DocumentSerializer](
private val client: CouchDbRestClient =
new CouchDbRestClient(dbProtocol, dbHost, dbPort.toInt, dbUsername,
dbPassword, dbName)
+ // This the the amount of allowed parallel requests for each entity, before
batching starts. If there are already maxOpenDbRequests
+ // and more documents need to be stored, then all arriving documents will be
put into batches (if enabled) to avoid a long queue.
+ private val maxOpenDbRequests =
system.settings.config.getInt("akka.http.host-connection-pool.max-open-requests")
/ 2
+
+ private val batcher: Batcher[JsObject, Either[ArtifactStoreException,
DocInfo]] =
+new Batcher(500, maxOpenDbRequests)(put(_)(TransactionId.unknown))
Review comment:
Was thinking the value might change per deployment. Should at least add a
comment stating why it's set to 500 here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ddragosd commented on issue #2815: WIP: adding api host param
ddragosd commented on issue #2815: WIP: adding api host param URL: https://github.com/apache/incubator-openwhisk/pull/2815#issuecomment-334899607 @narinearraul is this PR still WIP, or the other actions in the catalog are now using `__OW_API_HOST` env var ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
