[GitHub] xingzhou commented on issue #68: Update counchdb image init script to avoid python package installatio?
xingzhou commented on issue #68: Update counchdb image init script to avoid python package installatio? URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/68#issuecomment-336332271 yeap, @jcrossley3. /cc @dgrove-oss, your opinion on this? Besides, also found a related open SSL issue during launching the latest couchdb image, can be addressed by upgrading the system pyopenssl package as: ``` sudo pip install -U pyopenssl ``` will update this patch to include this as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #601: Add Json support for Input parameters
mrutkows commented on issue #601: Add Json support for Input parameters URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/601#issuecomment-336331757 @pritidesai that's debug trace I added early July, it will be commented out before WIP is removed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alexkli commented on issue #20: "wsk activation list" should show more information about activations
alexkli commented on issue #20: "wsk activation list" should show more information about activations URL: https://github.com/apache/incubator-openwhisk/issues/20#issuecomment-336290679 ? to this feature This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] abaruni commented on a change in pull request #217: Add ability to get trigger configuration and status
abaruni commented on a change in pull request #217: Add ability to get trigger
configuration and status
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/pull/217#discussion_r144410648
##
File path: action/lib/common.js
##
@@ -130,6 +130,30 @@ function deleteTrigger(endpoint, params, actionName) {
});
}
+function getTrigger(endpoint, params, actionName) {
+var options = {
+method: 'GET',
+url: getWebActionURL(endpoint, actionName),
+rejectUnauthorized: false,
Review comment:
not entirely sure though
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] abaruni commented on a change in pull request #217: Add ability to get trigger configuration and status
abaruni commented on a change in pull request #217: Add ability to get trigger
configuration and status
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/pull/217#discussion_r144410595
##
File path: action/lib/common.js
##
@@ -130,6 +130,30 @@ function deleteTrigger(endpoint, params, actionName) {
});
}
+function getTrigger(endpoint, params, actionName) {
+var options = {
+method: 'GET',
+url: getWebActionURL(endpoint, actionName),
+rejectUnauthorized: false,
Review comment:
not entirely sure. i think it might have something to do with accepting
self-signed certs https://github.com/request/request-promise/issues/225
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] abaruni commented on a change in pull request #217: Add ability to get trigger configuration and status
abaruni commented on a change in pull request #217: Add ability to get trigger
configuration and status
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/pull/217#discussion_r144409384
##
File path: tests/src/test/scala/system/packages/MessageHubFeedTests.scala
##
@@ -274,6 +274,67 @@ class MessageHubFeedTests
assert(matchingActivations.length == 0)
}
+ it should "return correct status and configuration" in
withAssetCleaner(wskprops) {
+val currentTime = s"${System.currentTimeMillis}"
+
+(wp, assetHelper) =>
+ val triggerName = s"/_/dummyMessageHubTrigger-$currentTime"
+ println(s"Creating trigger ${triggerName}")
+
+ val username = kafkaUtils.getAsJson("user")
+ val password = kafkaUtils.getAsJson("password")
+ val admin_url = kafkaUtils.getAsJson("kafka_admin_url")
+ val brokers = kafkaUtils.getAsJson("brokers")
+
+ createTrigger(assetHelper, triggerName, parameters = Map(
+"user" -> username,
+"password" -> password,
+"api_key" -> kafkaUtils.getAsJson("api_key"),
+"kafka_admin_url" -> admin_url,
+"kafka_brokers_sasl" -> brokers,
+"topic" -> topic.toJson,
+"isBinaryKey" -> false.toJson,
+"isBinaryValue" -> false.toJson
+ ))
+
+ val run = wsk.action.invoke(actionName, parameters = Map(
Review comment:
shouldn't that be a test for testing the action itself? i.e. failing with a
bad auth key is functionality that is inherent to invoking the action itself,
not invoking the action with the parameter `lifecycleEvent` set to `READ`. i'm
all for having this test if it doesn't exist for the provider already. but a
separate issue should be opened as it doesn't specifically relate to this
functionality. i.e. an action should never be able to be invoked without proper
authKey
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] abaruni commented on a change in pull request #217: Add ability to get trigger configuration and status
abaruni commented on a change in pull request #217: Add ability to get trigger
configuration and status
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/pull/217#discussion_r144408689
##
File path: tests/src/test/scala/system/packages/MessageHubFeedTests.scala
##
@@ -274,6 +274,67 @@ class MessageHubFeedTests
assert(matchingActivations.length == 0)
}
+ it should "return correct status and configuration" in
withAssetCleaner(wskprops) {
+val currentTime = s"${System.currentTimeMillis}"
+
+(wp, assetHelper) =>
+ val triggerName = s"/_/dummyMessageHubTrigger-$currentTime"
+ println(s"Creating trigger ${triggerName}")
+
+ val username = kafkaUtils.getAsJson("user")
+ val password = kafkaUtils.getAsJson("password")
+ val admin_url = kafkaUtils.getAsJson("kafka_admin_url")
+ val brokers = kafkaUtils.getAsJson("brokers")
+
+ createTrigger(assetHelper, triggerName, parameters = Map(
+"user" -> username,
+"password" -> password,
+"api_key" -> kafkaUtils.getAsJson("api_key"),
+"kafka_admin_url" -> admin_url,
+"kafka_brokers_sasl" -> brokers,
+"topic" -> topic.toJson,
+"isBinaryKey" -> false.toJson,
+"isBinaryValue" -> false.toJson
+ ))
+
+ val run = wsk.action.invoke(actionName, parameters = Map(
+"triggerName" -> triggerName.toJson,
+"lifecycleEvent" -> "READ".toJson,
+"authKey" -> wp.authKey.toJson
+ ))
+
+ withActivation(wsk.activation, run) {
+activation =>
+ activation.response.success shouldBe true
+
+ inside (activation.response.result) {
+case Some(result) =>
+ val config =
result.getFields("config").head.asInstanceOf[JsObject].fields
+ val status =
result.getFields("status").head.asInstanceOf[JsObject].fields
+
+ config should contain("brokers" -> brokers)
Review comment:
and i would still have to test fields individually for status as i cannot
know the value of the dateChanged field
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] abaruni commented on a change in pull request #217: Add ability to get trigger configuration and status
abaruni commented on a change in pull request #217: Add ability to get trigger
configuration and status
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/pull/217#discussion_r144408526
##
File path: tests/src/test/scala/system/packages/MessageHubFeedTests.scala
##
@@ -274,6 +274,67 @@ class MessageHubFeedTests
assert(matchingActivations.length == 0)
}
+ it should "return correct status and configuration" in
withAssetCleaner(wskprops) {
+val currentTime = s"${System.currentTimeMillis}"
+
+(wp, assetHelper) =>
+ val triggerName = s"/_/dummyMessageHubTrigger-$currentTime"
+ println(s"Creating trigger ${triggerName}")
+
+ val username = kafkaUtils.getAsJson("user")
+ val password = kafkaUtils.getAsJson("password")
+ val admin_url = kafkaUtils.getAsJson("kafka_admin_url")
+ val brokers = kafkaUtils.getAsJson("brokers")
+
+ createTrigger(assetHelper, triggerName, parameters = Map(
+"user" -> username,
+"password" -> password,
+"api_key" -> kafkaUtils.getAsJson("api_key"),
+"kafka_admin_url" -> admin_url,
+"kafka_brokers_sasl" -> brokers,
+"topic" -> topic.toJson,
+"isBinaryKey" -> false.toJson,
+"isBinaryValue" -> false.toJson
+ ))
+
+ val run = wsk.action.invoke(actionName, parameters = Map(
+"triggerName" -> triggerName.toJson,
+"lifecycleEvent" -> "READ".toJson,
+"authKey" -> wp.authKey.toJson
+ ))
+
+ withActivation(wsk.activation, run) {
+activation =>
+ activation.response.success shouldBe true
+
+ inside (activation.response.result) {
+case Some(result) =>
+ val config =
result.getFields("config").head.asInstanceOf[JsObject].fields
+ val status =
result.getFields("status").head.asInstanceOf[JsObject].fields
+
+ config should contain("brokers" -> brokers)
Review comment:
that would work except for the fact the trigger name as returned is not
equal to the trigger name passed in
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] abaruni commented on a change in pull request #217: Add ability to get trigger configuration and status
abaruni commented on a change in pull request #217: Add ability to get trigger
configuration and status
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/pull/217#discussion_r144407283
##
File path: action/kafkaFeedWeb.js
##
@@ -61,6 +61,35 @@ function main(params) {
resolve(common.webResponse(statusCode, body));
});
+} else if (params.__ow_method === "get") {
+const triggerURL = common.getTriggerURL(params.authKey,
params.endpoint, params.triggerName);
+
+return common.verifyTriggerAuth(triggerURL)
+.then(() => {
+db = new Database(params.DB_URL, params.DB_NAME);
+return db.getTrigger(params.triggerName);
+})
+.then((triggerDoc) => {
+var body = {
+config: {
+triggerName: triggerDoc.triggerName,
+topic: triggerDoc.topic,
+isJSONData: triggerDoc.isJSONData,
+isBinaryValue: triggerDoc.isBinaryValue,
+isBinaryKey: triggerDoc.isBinaryKey,
+isMessageHub: triggerDoc.isMessageHub,
+brokers: triggerDoc.brokers,
+kafka_admin_url: triggerDoc.kafka_admin_url,
+username: triggerDoc.username,
+password: triggerDoc.password
Review comment:
we will likely add flags in the future to adjust what is returned.
@csantanapr wants to get this initial work out before focusing on that as this
is highly desirable
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] abaruni commented on a change in pull request #217: Add ability to get trigger configuration and status
abaruni commented on a change in pull request #217: Add ability to get trigger
configuration and status
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/pull/217#discussion_r144407001
##
File path: action/kafkaFeedWeb.js
##
@@ -61,6 +61,35 @@ function main(params) {
resolve(common.webResponse(statusCode, body));
});
+} else if (params.__ow_method === "get") {
+const triggerURL = common.getTriggerURL(params.authKey,
params.endpoint, params.triggerName);
+
+return common.verifyTriggerAuth(triggerURL)
+.then(() => {
+db = new Database(params.DB_URL, params.DB_NAME);
+return db.getTrigger(params.triggerName);
+})
+.then((triggerDoc) => {
+var body = {
+config: {
+triggerName: triggerDoc.triggerName,
+topic: triggerDoc.topic,
+isJSONData: triggerDoc.isJSONData,
+isBinaryValue: triggerDoc.isBinaryValue,
+isBinaryKey: triggerDoc.isBinaryKey,
+isMessageHub: triggerDoc.isMessageHub,
+brokers: triggerDoc.brokers,
+kafka_admin_url: triggerDoc.kafka_admin_url,
+username: triggerDoc.username,
+password: triggerDoc.password
Review comment:
at this point in time yes. the user needs to be authenticated. this is no
different than fetching the service credentials for your instance of message
hub from bluemix
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] abaruni commented on a change in pull request #217: Add ability to get trigger configuration and status
abaruni commented on a change in pull request #217: Add ability to get trigger
configuration and status
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/pull/217#discussion_r144406862
##
File path: action/kafkaFeedWeb.js
##
@@ -61,6 +61,35 @@ function main(params) {
resolve(common.webResponse(statusCode, body));
});
+} else if (params.__ow_method === "get") {
Review comment:
you'll notice the code between messageHubFeedWeb.js and kafkaFeedWeb.js is
entirely duplicated. i think it's definitely fair to get rid of the
duplication. but i don't this this is the the place to do it. it should be done
under a different issue/epic
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubeejw commented on a change in pull request #217: Add ability to get trigger configuration and status
dubeejw commented on a change in pull request #217: Add ability to get trigger
configuration and status
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/pull/217#discussion_r144405919
##
File path: tests/src/test/scala/system/packages/MessageHubFeedTests.scala
##
@@ -274,6 +274,67 @@ class MessageHubFeedTests
assert(matchingActivations.length == 0)
}
+ it should "return correct status and configuration" in
withAssetCleaner(wskprops) {
+val currentTime = s"${System.currentTimeMillis}"
+
+(wp, assetHelper) =>
+ val triggerName = s"/_/dummyMessageHubTrigger-$currentTime"
+ println(s"Creating trigger ${triggerName}")
+
+ val username = kafkaUtils.getAsJson("user")
+ val password = kafkaUtils.getAsJson("password")
+ val admin_url = kafkaUtils.getAsJson("kafka_admin_url")
+ val brokers = kafkaUtils.getAsJson("brokers")
+
+ createTrigger(assetHelper, triggerName, parameters = Map(
+"user" -> username,
+"password" -> password,
+"api_key" -> kafkaUtils.getAsJson("api_key"),
+"kafka_admin_url" -> admin_url,
+"kafka_brokers_sasl" -> brokers,
+"topic" -> topic.toJson,
+"isBinaryKey" -> false.toJson,
+"isBinaryValue" -> false.toJson
+ ))
+
+ val run = wsk.action.invoke(actionName, parameters = Map(
+"triggerName" -> triggerName.toJson,
+"lifecycleEvent" -> "READ".toJson,
+"authKey" -> wp.authKey.toJson
+ ))
+
+ withActivation(wsk.activation, run) {
+activation =>
+ activation.response.success shouldBe true
+
+ inside (activation.response.result) {
+case Some(result) =>
+ val config =
result.getFields("config").head.asInstanceOf[JsObject].fields
+ val status =
result.getFields("status").head.asInstanceOf[JsObject].fields
+
+ config should contain("brokers" -> brokers)
Review comment:
Ex:
```
val expectedConfig = JsObject("isBinaryKey" -> false.toJson,
"isBinaryValue" -> false.toJson,
etc...)
config shouldBe(expectedConfig)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubeejw commented on a change in pull request #217: Add ability to get trigger configuration and status
dubeejw commented on a change in pull request #217: Add ability to get trigger
configuration and status
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/pull/217#discussion_r144406104
##
File path: action/lib/common.js
##
@@ -130,6 +130,30 @@ function deleteTrigger(endpoint, params, actionName) {
});
}
+function getTrigger(endpoint, params, actionName) {
+var options = {
+method: 'GET',
+url: getWebActionURL(endpoint, actionName),
+rejectUnauthorized: false,
Review comment:
What's `rejectUnauthorized` do?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubeejw commented on a change in pull request #217: Add ability to get trigger configuration and status
dubeejw commented on a change in pull request #217: Add ability to get trigger
configuration and status
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/pull/217#discussion_r144398796
##
File path: action/kafkaFeedWeb.js
##
@@ -61,6 +61,35 @@ function main(params) {
resolve(common.webResponse(statusCode, body));
});
+} else if (params.__ow_method === "get") {
+const triggerURL = common.getTriggerURL(params.authKey,
params.endpoint, params.triggerName);
+
+return common.verifyTriggerAuth(triggerURL)
+.then(() => {
+db = new Database(params.DB_URL, params.DB_NAME);
+return db.getTrigger(params.triggerName);
+})
+.then((triggerDoc) => {
+var body = {
+config: {
+triggerName: triggerDoc.triggerName,
+topic: triggerDoc.topic,
+isJSONData: triggerDoc.isJSONData,
+isBinaryValue: triggerDoc.isBinaryValue,
+isBinaryKey: triggerDoc.isBinaryKey,
+isMessageHub: triggerDoc.isMessageHub,
+brokers: triggerDoc.brokers,
+kafka_admin_url: triggerDoc.kafka_admin_url,
+username: triggerDoc.username,
+password: triggerDoc.password
Review comment:
Do we really want to return the password?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubeejw commented on a change in pull request #217: Add ability to get trigger configuration and status
dubeejw commented on a change in pull request #217: Add ability to get trigger
configuration and status
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/pull/217#discussion_r144398720
##
File path: action/kafkaFeedWeb.js
##
@@ -61,6 +61,35 @@ function main(params) {
resolve(common.webResponse(statusCode, body));
});
+} else if (params.__ow_method === "get") {
Review comment:
Code is the same as in messageHubFeedWeb.js. Should make it a shared method
between the two.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubeejw commented on a change in pull request #217: Add ability to get trigger configuration and status
dubeejw commented on a change in pull request #217: Add ability to get trigger
configuration and status
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/pull/217#discussion_r144405919
##
File path: tests/src/test/scala/system/packages/MessageHubFeedTests.scala
##
@@ -274,6 +274,67 @@ class MessageHubFeedTests
assert(matchingActivations.length == 0)
}
+ it should "return correct status and configuration" in
withAssetCleaner(wskprops) {
+val currentTime = s"${System.currentTimeMillis}"
+
+(wp, assetHelper) =>
+ val triggerName = s"/_/dummyMessageHubTrigger-$currentTime"
+ println(s"Creating trigger ${triggerName}")
+
+ val username = kafkaUtils.getAsJson("user")
+ val password = kafkaUtils.getAsJson("password")
+ val admin_url = kafkaUtils.getAsJson("kafka_admin_url")
+ val brokers = kafkaUtils.getAsJson("brokers")
+
+ createTrigger(assetHelper, triggerName, parameters = Map(
+"user" -> username,
+"password" -> password,
+"api_key" -> kafkaUtils.getAsJson("api_key"),
+"kafka_admin_url" -> admin_url,
+"kafka_brokers_sasl" -> brokers,
+"topic" -> topic.toJson,
+"isBinaryKey" -> false.toJson,
+"isBinaryValue" -> false.toJson
+ ))
+
+ val run = wsk.action.invoke(actionName, parameters = Map(
+"triggerName" -> triggerName.toJson,
+"lifecycleEvent" -> "READ".toJson,
+"authKey" -> wp.authKey.toJson
+ ))
+
+ withActivation(wsk.activation, run) {
+activation =>
+ activation.response.success shouldBe true
+
+ inside (activation.response.result) {
+case Some(result) =>
+ val config =
result.getFields("config").head.asInstanceOf[JsObject].fields
+ val status =
result.getFields("status").head.asInstanceOf[JsObject].fields
+
+ config should contain("brokers" -> brokers)
Review comment:
Ex:
```
val expectedConfig = JsObject("isBinaryKey" -> false.toJson, "isBinaryValue"
-> false.toJson, etc...)
config shouldBe(expectedConfig)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubeejw commented on a change in pull request #217: Add ability to get trigger configuration and status
dubeejw commented on a change in pull request #217: Add ability to get trigger
configuration and status
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/pull/217#discussion_r144405679
##
File path: tests/src/test/scala/system/packages/MessageHubFeedTests.scala
##
@@ -274,6 +274,67 @@ class MessageHubFeedTests
assert(matchingActivations.length == 0)
}
+ it should "return correct status and configuration" in
withAssetCleaner(wskprops) {
+val currentTime = s"${System.currentTimeMillis}"
+
+(wp, assetHelper) =>
+ val triggerName = s"/_/dummyMessageHubTrigger-$currentTime"
+ println(s"Creating trigger ${triggerName}")
+
+ val username = kafkaUtils.getAsJson("user")
+ val password = kafkaUtils.getAsJson("password")
+ val admin_url = kafkaUtils.getAsJson("kafka_admin_url")
+ val brokers = kafkaUtils.getAsJson("brokers")
+
+ createTrigger(assetHelper, triggerName, parameters = Map(
+"user" -> username,
+"password" -> password,
+"api_key" -> kafkaUtils.getAsJson("api_key"),
+"kafka_admin_url" -> admin_url,
+"kafka_brokers_sasl" -> brokers,
+"topic" -> topic.toJson,
+"isBinaryKey" -> false.toJson,
+"isBinaryValue" -> false.toJson
+ ))
+
+ val run = wsk.action.invoke(actionName, parameters = Map(
+"triggerName" -> triggerName.toJson,
+"lifecycleEvent" -> "READ".toJson,
+"authKey" -> wp.authKey.toJson
+ ))
+
+ withActivation(wsk.activation, run) {
+activation =>
+ activation.response.success shouldBe true
+
+ inside (activation.response.result) {
+case Some(result) =>
+ val config =
result.getFields("config").head.asInstanceOf[JsObject].fields
+ val status =
result.getFields("status").head.asInstanceOf[JsObject].fields
+
+ config should contain("brokers" -> brokers)
Review comment:
You should be able build a JsObject that has all these fields then do one or
two comparisons instead of several.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubeejw commented on a change in pull request #217: Add ability to get trigger configuration and status
dubeejw commented on a change in pull request #217: Add ability to get trigger
configuration and status
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/pull/217#discussion_r144398884
##
File path: tests/src/test/scala/system/packages/MessageHubFeedTests.scala
##
@@ -274,6 +274,67 @@ class MessageHubFeedTests
assert(matchingActivations.length == 0)
}
+ it should "return correct status and configuration" in
withAssetCleaner(wskprops) {
+val currentTime = s"${System.currentTimeMillis}"
+
+(wp, assetHelper) =>
+ val triggerName = s"/_/dummyMessageHubTrigger-$currentTime"
+ println(s"Creating trigger ${triggerName}")
+
+ val username = kafkaUtils.getAsJson("user")
+ val password = kafkaUtils.getAsJson("password")
+ val admin_url = kafkaUtils.getAsJson("kafka_admin_url")
+ val brokers = kafkaUtils.getAsJson("brokers")
+
+ createTrigger(assetHelper, triggerName, parameters = Map(
+"user" -> username,
+"password" -> password,
+"api_key" -> kafkaUtils.getAsJson("api_key"),
+"kafka_admin_url" -> admin_url,
+"kafka_brokers_sasl" -> brokers,
+"topic" -> topic.toJson,
+"isBinaryKey" -> false.toJson,
+"isBinaryValue" -> false.toJson
+ ))
+
+ val run = wsk.action.invoke(actionName, parameters = Map(
Review comment:
Should have a test to ensure this fails with an bad auth key.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] jcrossley3 commented on issue #68: Update counchdb image init script to avoid python package installatio?
jcrossley3 commented on issue #68: Update counchdb image init script to avoid python package installatio? URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/68#issuecomment-336243301 I ran into this, too. I fixed it slightly differently: `pip install --upgrade setuptools` I also changed the travis `build.sh` in our fork to build the image prior to applying the resource file: https://github.com/projectodd/incubator-openwhisk-deploy-kube/commit/71ad149dc547849f1f06b177671a914553b5dd9b Might be a good idea to do that for all the required docker images, especially the ones not tied to a specific version of a dependency, e.g. the ones that checkout openwhisk master. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alexkli commented on issue #2848: Support reading param.json from stdin #2837
alexkli commented on issue #2848: Support reading param.json from stdin #2837 URL: https://github.com/apache/incubator-openwhisk/pull/2848#issuecomment-336219864 Usage now says for all cases of `--param-file`: -P, --param-file FILE FILE containing parameter values in JSON format, use '-' to read from stdin Also added a [full example to docs/actions.md](https://github.com/alexkli/incubator-openwhisk/blob/4c058d9ca59d76e8d5aed0c6a85f8edda553e527/docs/actions.md#passing-parameters-to-an-action) (scroll down to 4.). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on issue #2854: Improve garbage collector out-out-memory handling and debugging
markusthoemmes commented on issue #2854: Improve garbage collector out-out-memory handling and debugging URL: https://github.com/apache/incubator-openwhisk/pull/2854#issuecomment-336178403 Does it make sense to use the very same settings for the Controller? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alexkli commented on issue #2848: Support reading param.json from stdin #2837
alexkli commented on issue #2848: Support reading param.json from stdin #2837 URL: https://github.com/apache/incubator-openwhisk/pull/2848#issuecomment-336175311 I think this needs a documentation/usage output change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sven-lange-last commented on issue #2854: Improve garbage collector out-out-memory handling and debugging
sven-lange-last commented on issue #2854: Improve garbage collector out-out-memory handling and debugging URL: https://github.com/apache/incubator-openwhisk/pull/2854#issuecomment-336159388 @markusthoemmes please attend to this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sven-lange-last opened a new pull request #2854: Improve garbage collector out-out-memory handling and debugging
sven-lange-last opened a new pull request #2854: Improve garbage collector out-out-memory handling and debugging URL: https://github.com/apache/incubator-openwhisk/pull/2854 The new options ensure that the JVM crashes if the garbage collector is no more able to free up space. The resulting error log is written into the `/logs` directory which is visible on the system hosting the invoker Docker container. The name of the error log file is fixed such that only one single file is kept even if multiple crashes occur. Consolidated all options in `deploy.yml` because `-XX:ErrorFile` refers to the `/logs` directory mounted into the container. If this directory is changed, `-XX:ErrorFile` must be updated as well. `-XX:+UseGCOverheadLimit` Enables the use of a policy that limits the proportion of time spent by the JVM on GC before an OutOfMemoryError exception is thrown. This option is enabled, by default and the parallel GC will throw an OutOfMemoryError if more than 98% of the total time is spent on garbage collection and less than 2% of the heap is recovered. When the heap is small, this feature can be used to prevent applications from running for long periods of time with little or no progress. To disable this option, specify -XX:-UseGCOverheadLimit. `-XX:+CrashOnOutOfMemoryError` If this option is enabled, when an out-of-memory error occurs, the JVM crashes and produces text and binary crash files (if core files are enabled). `-XX:ErrorFile=filename` Specifies the path and file name to which error data is written when an irrecoverable error occurs. By default, this file is created in the current working directory and named hs_err_pidpid.log where pid is the identifier of the process that caused the error. The following example shows how to set the default log file (note that the identifier of the process is specified as %p): -XX:ErrorFile=./hs_err_pid%p.log The following example shows how to set the error log to /var/log/java/java_error.log: -XX:ErrorFile=/var/log/java/java_error.log If the file cannot be created in the specified directory (due to insufficient space, permission problem, or another issue), then the file is created in the temporary directory for the operating system. The temporary directory is /tmp. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #2853: update kinds
csantanapr opened a new pull request #2853: update kinds URL: https://github.com/apache/incubator-openwhisk/pull/2853 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xingzhou opened a new pull request #68: Update counchdb image init script to avoid python package installatio?
xingzhou opened a new pull request #68: Update counchdb image init script to avoid python package installatio? URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/68 ?n error. Due to some package updates, the pip tool need to be updated before installing ansible 2.3. Use pip install -U pip to update the package to avoid package installation error during the start of couchdb container. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jeremiaswerner closed pull request #2818: Change logging backend from log4j to Logback
jeremiaswerner closed pull request #2818: Change logging backend from log4j to Logback URL: https://github.com/apache/incubator-openwhisk/pull/2818 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
