[GitHub] cbickel closed pull request #3393: Turn off Kafka auto-commits.
cbickel closed pull request #3393: Turn off Kafka auto-commits.
URL: https://github.com/apache/incubator-openwhisk/pull/3393
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/common/scala/src/main/resources/application.conf
b/common/scala/src/main/resources/application.conf
index 0c4f91a470..b1d1163e00 100644
--- a/common/scala/src/main/resources/application.conf
+++ b/common/scala/src/main/resources/application.conf
@@ -66,8 +66,7 @@ whisk {
consumer {
session-timeout-ms = 3
heartbeat-interval-ms = 1
-enable-auto-commit = true
-auto-commit-interval-ms = 1
+enable-auto-commit = false
auto-offset-reset = earliest
max-poll-interval = 36
// This value controls the server-side wait time which affects
polling latency.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr closed issue #258: Move Feed Test from BasicHealthTest to MessageHubFeedTests
csantanapr closed issue #258: Move Feed Test from BasicHealthTest to MessageHubFeedTests URL: https://github.com/apache/incubator-openwhisk-package-kafka/issues/258 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #259: Move Feed Update Test
csantanapr closed pull request #259: Move Feed Update Test
URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/259
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tests/src/test/scala/system/health/BasicHealthTest.scala
b/tests/src/test/scala/system/health/BasicHealthTest.scala
index 139ed21..c80458c 100644
--- a/tests/src/test/scala/system/health/BasicHealthTest.scala
+++ b/tests/src/test/scala/system/health/BasicHealthTest.scala
@@ -249,88 +249,4 @@ class BasicHealthTest
}
}
}
-
- it should "correctly update isJSONData, isBinaryValue, and isBinaryKey" in
withAssetCleaner(wskprops) {
-val currentTime = s"${System.currentTimeMillis}"
-
-(wp, assetHelper) =>
- val triggerName = s"/_/dummyMessageHubTrigger-$currentTime"
- println(s"Creating trigger $triggerName")
-
- val username = kafkaUtils.getAsJson("user")
- val password = kafkaUtils.getAsJson("password")
- val admin_url = kafkaUtils.getAsJson("kafka_admin_url")
- val brokers = kafkaUtils.getAsJson("brokers")
-
- val feedCreationResult = assetHelper.withCleaner(wsk.trigger,
triggerName) {
-(trigger, _) =>
- trigger.create(triggerName, feed = Some(actionName), parameters =
Map(
-"user" -> username,
-"password" -> password,
-"api_key" -> kafkaUtils.getAsJson("api_key"),
-"kafka_admin_url" -> admin_url,
-"kafka_brokers_sasl" -> brokers,
-"topic" -> topic.toJson,
-"isJSONData" -> true.toJson,
-"isBinaryKey" -> false.toJson,
-"isBinaryValue" -> false.toJson
- ))
- }
-
- withActivation(wsk.activation, feedCreationResult, initialWait = 5
seconds, totalWait = 60 seconds) {
-_.response.success shouldBe true
- }
-
- val readRunResult = wsk.action.invoke(actionName, parameters = Map(
-"triggerName" -> triggerName.toJson,
-"lifecycleEvent" -> "READ".toJson,
-"authKey" -> wp.authKey.toJson
- ))
-
- withActivation(wsk.activation, readRunResult) {
-activation =>
- activation.response.success shouldBe true
-
- inside (activation.response.result) {
-case Some(result) =>
- val config =
result.getFields("config").head.asInstanceOf[JsObject].fields
- config should contain("isBinaryKey" -> false.toJson)
- config should contain("isBinaryValue" -> false.toJson)
- config should contain("isJSONData" -> true.toJson)
- }
- }
-
- val updateRunResult = wsk.action.invoke(actionName, parameters = Map(
-"triggerName" -> triggerName.toJson,
-"lifecycleEvent" -> "UPDATE".toJson,
-"authKey" -> wp.authKey.toJson,
-"isBinaryValue" -> true.toJson,
-"isBinaryKey" -> true.toJson,
-"isJSONData" -> false.toJson
- ))
-
- withActivation(wsk.activation, updateRunResult) {
-activation =>
- activation.response.success shouldBe true
- }
-
- val run = wsk.action.invoke(actionName, parameters = Map(
-"triggerName" -> triggerName.toJson,
-"lifecycleEvent" -> "READ".toJson,
-"authKey" -> wp.authKey.toJson
- ))
-
- withActivation(wsk.activation, run) {
-activation =>
- activation.response.success shouldBe true
-
- inside (activation.response.result) {
-case Some(result) =>
- val config =
result.getFields("config").head.asInstanceOf[JsObject].fields
- config should contain("isBinaryKey" -> true.toJson)
- config should contain("isBinaryValue" -> true.toJson)
- config should contain("isJSONData" -> false.toJson)
- }
- }
- }
}
diff --git a/tests/src/test/scala/system/packages/MessageHubFeedTests.scala
b/tests/src/test/scala/system/packages/MessageHubFeedTests.scala
index 9cd1e2f..ba17e84 100644
--- a/tests/src/test/scala/system/packages/MessageHubFeedTests.scala
+++ b/tests/src/test/scala/system/packages/MessageHubFeedTests.scala
@@ -385,6 +385,90 @@ class MessageHubFeedTests
}
}
+ it should "correctly update isJSONData, isBinaryValue, and isBinaryKey" in
withAssetCleaner(wskprops) {
+val currentTime = s"${System.currentTimeMillis}"
+
+(wp, assetHelper) =>
+ val triggerName = s"/_/dummyMessageHubTrigger-$currentTime"
+ println(s"Creating trigger $triggerName")
+
+ val username = kafkaUtils.getAsJson("user")
+ val password = kafkaUtils.getAsJson("password")
+ val admin_url = kafkaUtils.getAsJson("kafka_admin_url")
+ val brokers = kafkaUtils.getAsJson("brokers")
+
+ val feedCreationResult = assetHelper.withCle
[GitHub] daisy-ycguo commented on issue #52: Add license verification document
daisy-ycguo commented on issue #52: Add license verification document URL: https://github.com/apache/incubator-openwhisk-release/pull/52#issuecomment-370726502 The document is ready for review. @mrutkows @houshengbo This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo commented on issue #53: Change to use RAT maven plugin to support ASF short format header
daisy-ycguo commented on issue #53: Change to use RAT maven plugin to support ASF short format header URL: https://github.com/apache/incubator-openwhisk-release/pull/53#issuecomment-370725972 @houshengbo Hi, in verify_source_code.sh, I use OPENWHISK_SOURCE_DIR instead of OPENWHISK_CLEANED_SOURCE_DIR because it doesn't work for me to use OPENWHISK_CLEANED_SOURCE_DIR when I run `./tool/travis/verify_source_code.sh` in my local machine. Please verify if the update makes sense. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo commented on issue #53: Change to use RAT maven plugin to support ASF short format header
daisy-ycguo commented on issue #53: Change to use RAT maven plugin to support ASF short format header URL: https://github.com/apache/incubator-openwhisk-release/pull/53#issuecomment-370725972 @houshengbo Hi, in `verify_source_code.sh`, I use OPENWHISK_SOURCE_DIR instead of OPENWHISK_CLEANED_SOURCE_DIR because it doesn't work for me to use OPENWHISK_CLEANED_SOURCE_DIR when I run `./tool/travis/verify_source_code.sh` in my local machine. Please verify if the update makes sense. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3391: Add namespace-blacklist to invoker.
markusthoemmes commented on a change in pull request #3391: Add
namespace-blacklist to invoker.
URL:
https://github.com/apache/incubator-openwhisk/pull/3391#discussion_r172450254
##
File path:
core/invoker/src/main/scala/whisk/core/invoker/NamespaceBlacklist.scala
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.invoker
+
+import whisk.common.TransactionId
+import whisk.core.database.StaleParameter
+import whisk.core.entity.{Identity, View}
+import whisk.core.entity.types.AuthStore
+
+import scala.concurrent.{ExecutionContext, Future}
+import spray.json.DefaultJsonProtocol._
+
+/**
+ * The Namespace blacklist gets all namespaces that are throttled to 0 from
the database.
+ * The caller is responsible for a periodically update of the blacklist with
`refreshBlacklist`.
+ *
+ * @param authStore Subjects database with the limit-documents.
+ */
+class NamespaceBlacklist(authStore: AuthStore) {
Review comment:
Not that I'm aware of. The controller already checks all of these limits
during its entitlement.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes closed issue #3376: Create PR checklist
markusthoemmes closed issue #3376: Create PR checklist URL: https://github.com/apache/incubator-openwhisk/issues/3376 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on issue #3394: fix deploy.yml
markusthoemmes commented on issue #3394: fix deploy.yml URL: https://github.com/apache/incubator-openwhisk/pull/3394#issuecomment-370709364 Please add a description describing what fails and how you fixed the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes closed pull request #3386: Add PR template.
markusthoemmes closed pull request #3386: Add PR template. URL: https://github.com/apache/incubator-openwhisk/pull/3386 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 00..49304b0c8a --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,42 @@ + + + +## Description + + + +## Related issue and scope + +- [ ] I opened an issue to propose and discuss this change (#) + +## My changes affect the following components + + +- [ ] API +- [ ] Controller +- [ ] Message Bus (e.g., Kafka) +- [ ] Loadbalancer +- [ ] Invoker +- [ ] Intrinsic actions (e.g., sequences, conductors) +- [ ] Data stores (e.g., CouchDB) +- [ ] Tests +- [ ] Deployment +- [ ] CLI +- [ ] General tooling +- [ ] Documentation + +## Types of changes + +- [ ] Bug fix (generally a non-breaking change which closes an issue). +- [ ] Enhancement or new feature (adds new functionality). +- [ ] Breaking change (a bug fix or enhancement which changes existing behavior). + +## Checklist: + + +- [ ] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). +- [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). +- [ ] I added tests to cover my changes. +- [ ] My changes require further changes to the documentation. +- [ ] I updated the documentation where necessary. + This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] RSulzmann opened a new pull request #3394: fix deploy.yml
RSulzmann opened a new pull request #3394: fix deploy.yml URL: https://github.com/apache/incubator-openwhisk/pull/3394 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new issue #768: Deployment reader "bind" functions should add missing annotations
mrutkows opened a new issue #768: Deployment reader "bind" functions should add missing annotations URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/768 Each of the "bind" routines in deploymentreader.go will "add" missing (input) parameters found in the deployment file, but have no name match/equivalent in the manifest file (as represented in the ServiceDeployer). However, Annotations in the deployment file that have no name match result in a "warning" being displayed. The consistent behavior SHOULD be that missing Annotations are also added, regardless if they have a name match in the manifest file. The spec. should also be updated to reflect BOTH these behaviors. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
