[GitHub] vcosqui commented on issue #208: Small change to make persistent-volumes work in GKE

[GitBox]

vcosqui commented on issue #208: Small change to make persistent-volumes work 
in GKE
URL: 
https://github.com/apache/incubator-openwhisk-deploy-kube/pull/208#issuecomment-393772249
 
 
   @dgrove-oss Dear David, my CLA has been accepted and my ID is now displayed 
in the list.
   Regards


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3713: WIP: Make JDK configurable

[GitBox]

codecov-io commented on issue #3713: WIP: Make JDK configurable
URL: 
https://github.com/apache/incubator-openwhisk/pull/3713#issuecomment-393582412
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713?src=pr&el=h1)
 Report
   > Merging 
[#3713](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/5f2dedb185216f7586e6b91de30866bcb50415a7?src=pr&el=desc)
 will **increase** coverage by `0.91%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713/graphs/tree.svg?width=650&height=150&src=pr&token=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3713  +/-   ##
   ==
   + Coverage   74.11%   75.02%   +0.91% 
   ==
 Files 127  127  
 Lines6038 6030   -8 
 Branches  390  388   -2 
   ==
   + Hits 4475 4524  +49 
   + Misses   1563 1506  -57
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...scala/whisk/core/containerpool/ContainerPool.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQb29sLnNjYWxh)
 | `85.88% <0%> (ø)` | :arrow_up: |
   | 
[...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...cala/src/main/scala/whisk/http/ErrorResponse.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvRXJyb3JSZXNwb25zZS5zY2FsYQ==)
 | `89.77% <0%> (+1.13%)` | :arrow_up: |
   | 
[...on/scala/src/main/scala/whisk/common/Logging.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Mb2dnaW5nLnNjYWxh)
 | `87.35% <0%> (+1.14%)` | :arrow_up: |
   | 
[...ain/scala/whisk/core/entity/ActivationResult.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0FjdGl2YXRpb25SZXN1bHQuc2NhbGE=)
 | `92.3% <0%> (+1.53%)` | :arrow_up: |
   | 
[.../scala/src/main/scala/whisk/core/entity/Size.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1NpemUuc2NhbGE=)
 | `97.82% <0%> (+1.82%)` | :arrow_up: |
   | 
[...in/scala/whisk/utils/ExecutionContextFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL3V0aWxzL0V4ZWN1dGlvbkNvbnRleHRGYWN0b3J5LnNjYWxh)
 | `100% <0%> (+7.69%)` | :arrow_up: |
   | 
[...rc/main/scala/whisk/core/entity/ExecManifest.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWNNYW5pZmVzdC5zY2FsYQ==)
 | `96.1% <0%> (+14.39%)` | :arrow_up: |
   | 
[...whisk/connector/kafka/KafkaConsumerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYUNvbnN1bWVyQ29ubmVjdG9yLnNjYWxh)
 | `58.33% <0%> (+22.91%)` | :arrow_up: |
   | 
[...whisk/connector/kafka/KafkaProducerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYVByb2R1Y2VyQ29ubmVjdG9yLnNjYWxh)
 | `58.33% <0%> (+36.11%)` | :arrow_up: |
   | ... and [1 
more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713?src=pr&el=footer).
 Last update 
[5f2dedb...f6d9241](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

-

[GitHub] houshengbo commented on a change in pull request #3504: use alpine-java base image (alpine 3.7 + oracle 8u162b12_server-jre)

[GitBox]

houshengbo commented on a change in pull request #3504: use alpine-java base 
image (alpine 3.7 + oracle 8u162b12_server-jre)
URL: 
https://github.com/apache/incubator-openwhisk/pull/3504#discussion_r192288509
 
 

 ##
 File path: common/scala/Dockerfile
 ##
 @@ -1,94 +1,15 @@
-#
-# Licensed to the Apache Software Foundation (ASF) under one or more 
contributor
-# license agreements.  See the NOTICE file distributed with this work for 
additional
-# information regarding copyright ownership.  The ASF licenses this file to you
-# under the Apache License, Version 2.0 (the # "License"); you may not use this
-# file except in compliance with the License.  You may obtain a copy of the 
License
-# at:
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software 
distributed
-# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
-# CONDITIONS OF ANY KIND, either express or implied.  See the License for the
-# specific language governing permissions and limitations under the License.
-#
-
-FROM alpine:3.6
+FROM openjdk:8u151-jdk-alpine
 
 Review comment:
   please add the license header .


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #167: API Gateway needs to build using OpenJDK instead of Oracle JDK8

[GitBox]

csantanapr commented on issue #167: API Gateway needs to build using OpenJDK 
instead of Oracle JDK8
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/167#issuecomment-393742664
 
 
   Java is used in gradle tests in Travis but apigateway doesn’t use java 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #167: API Gateway needs to build using OpenJDK instead of Oracle JDK8

[GitBox]

csantanapr commented on issue #167: API Gateway needs to build using OpenJDK 
instead of Oracle JDK8
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/167#issuecomment-393742584
 
 
   Apigateway doesn’t need a jdk 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] houshengbo commented on issue #167: API Gateway needs to build using OpenJDK instead of Oracle JDK8

[GitBox]

houshengbo commented on issue #167: API Gateway needs to build using OpenJDK 
instead of Oracle JDK8
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/167#issuecomment-393742330
 
 
   @mrutkows I did not find the line downloading the JDK, could you list the 
source code file here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #169: Allow user to change to use their chose JDK and document (multiple repos)

[GitBox]

csantanapr commented on issue #169: Allow user to change to use their chose JDK 
and document (multiple repos)
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/169#issuecomment-393740547
 
 
   @houshengbo can you post a PR to see how you switched to openjdk?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] houshengbo commented on issue #169: Allow user to change to use their chose JDK and document (multiple repos)

[GitBox]

houshengbo commented on issue #169: Allow user to change to use their chose JDK 
and document (multiple repos)
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/169#issuecomment-393739852
 
 
   @markusthoemmes @rabbah Do you know what could be the reason?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows opened a new issue #169: Allow user to change to use their chose JDK and document (multiple repos)

[GitBox]

mrutkows opened a new issue #169: Allow user to change to use their chose JDK 
and document (multiple repos)
URL: https://github.com/apache/incubator-openwhisk-release/issues/169
 
 
   We should provide a means for user to change the build to use a JDK of their 
choice; tat is, we need a means to configure the JDK location (dynamically or 
statically) and create user documentation telling them how to. These 
instructions and process should be the same for all repos. that use a JDK 
(e.g., main openwhisk, apigateway and runtime java).
   
   This problem surfaced and is related to issue: 
https://github.com/apache/incubator-openwhisk-release/issues/167


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] houshengbo closed issue #169: Allow user to change to use their chose JDK and document (multiple repos)

[GitBox]

houshengbo closed issue #169: Allow user to change to use their chose JDK and 
document (multiple repos)
URL: https://github.com/apache/incubator-openwhisk-release/issues/169
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds

[GitBox]

codecov-io commented on issue #3661: Restrict allowed namespaces when creating 
action of certain kinds
URL: 
https://github.com/apache/incubator-openwhisk/pull/3661#issuecomment-393731610
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3661?src=pr&el=h1)
 Report
   > Merging 
[#3661](https://codecov.io/gh/apache/incubator-openwhisk/pull/3661?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/8a3b4472d5ef420f0216cc8e42932d87f428ed30?src=pr&el=desc)
 will **increase** coverage by `0.62%`.
   > The diff coverage is `97.14%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3661/graphs/tree.svg?src=pr&token=l0YmsiSAso&width=650&height=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3661?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3661  +/-   ##
   ==
   + Coverage74.5%   75.12%   +0.62% 
   ==
 Files 126  127   +1 
 Lines5994 6055  +61 
 Branches  392  387   -5 
   ==
   + Hits 4466 4549  +83 
   + Misses   1528 1506  -22
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3661?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...cala/whisk/core/entitlement/LocalEntitlement.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3661/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXRsZW1lbnQvTG9jYWxFbnRpdGxlbWVudC5zY2FsYQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[...cala/whisk/core/entitlement/ActionCollection.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3661/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXRsZW1lbnQvQWN0aW9uQ29sbGVjdGlvbi5zY2FsYQ==)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[.../scala/src/main/scala/whisk/core/WhiskConfig.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3661/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvV2hpc2tDb25maWcuc2NhbGE=)
 | `92.3% <100%> (+0.05%)` | :arrow_up: |
   | 
[...r/src/main/scala/whisk/core/controller/Rules.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3661/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9SdWxlcy5zY2FsYQ==)
 | `89.26% <100%> (ø)` | :arrow_up: |
   | 
[...ain/scala/whisk/core/entitlement/Entitlement.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3661/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXRsZW1lbnQvRW50aXRsZW1lbnQuc2NhbGE=)
 | `78.19% <100%> (+1.77%)` | :arrow_up: |
   | 
[...isk/core/controller/actions/PrimitiveActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3661/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1ByaW1pdGl2ZUFjdGlvbnMuc2NhbGE=)
 | `87.02% <100%> (ø)` | :arrow_up: |
   | 
[...rc/main/scala/whisk/core/controller/Packages.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3661/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9QYWNrYWdlcy5zY2FsYQ==)
 | `89.32% <100%> (ø)` | :arrow_up: |
   | 
[...sk/core/controller/AuthorizedRouteDispatcher.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3661/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9BdXRob3JpemVkUm91dGVEaXNwYXRjaGVyLnNjYWxh)
 | `90.32% <100%> (ø)` | :arrow_up: |
   | 
[...src/main/scala/whisk/core/controller/Actions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3661/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9BY3Rpb25zLnNjYWxh)
 | `91.54% <90.9%> (+0.26%)` | :arrow_up: |
   | 
[.../scala/src/main/scala/whisk/core/entity/Size.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3661/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1NpemUuc2NhbGE=)
 | `96% <0%> (-1.83%)` | :arrow_down: |
   | ... and [15 
more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3661/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3661?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3661?src=pr&el=footer).
 Last update 
[8a3b447...536d7e8](https://codecov.io/gh/apache/incubator-openwhisk/pull/3661?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/

[GitHub] codecov-io commented on issue #3717: Update Travis to use ASF-Release.cfg.

[GitBox]

codecov-io commented on issue #3717: Update Travis to use ASF-Release.cfg.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3717#issuecomment-393729622
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3717?src=pr&el=h1)
 Report
   > Merging 
[#3717](https://codecov.io/gh/apache/incubator-openwhisk/pull/3717?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/c7de75dc4e62c2c2f139beeb012d092f2d9f0d8b?src=pr&el=desc)
 will **decrease** coverage by `0.5%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3717/graphs/tree.svg?width=650&token=l0YmsiSAso&height=150&src=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3717?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3717  +/-   ##
   ==
   - Coverage   74.07%   73.57%   -0.51% 
   ==
 Files 127  127  
 Lines6030 6194 +164 
 Branches  388  396   +8 
   ==
   + Hits 4467 4557  +90 
   - Misses   1563 1637  +74
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3717?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...scala/whisk/core/containerpool/ContainerPool.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3717/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQb29sLnNjYWxh)
 | `54.07% <0%> (-31.81%)` | :arrow_down: |
   | 
[.../scala/src/main/scala/whisk/core/entity/Size.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3717/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1NpemUuc2NhbGE=)
 | `79.48% <0%> (-18.34%)` | :arrow_down: |
   | 
[...rc/main/scala/whisk/core/entity/ExecManifest.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3717/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWNNYW5pZmVzdC5zY2FsYQ==)
 | `78.26% <0%> (-2.26%)` | :arrow_down: |
   | 
[...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3717/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...cala/src/main/scala/whisk/http/ErrorResponse.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3717/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvRXJyb3JSZXNwb25zZS5zY2FsYQ==)
 | `89.77% <0%> (+1.13%)` | :arrow_up: |
   | 
[...on/scala/src/main/scala/whisk/common/Logging.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3717/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Mb2dnaW5nLnNjYWxh)
 | `87.35% <0%> (+1.14%)` | :arrow_up: |
   | 
[...ain/scala/whisk/core/entity/ActivationResult.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3717/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0FjdGl2YXRpb25SZXN1bHQuc2NhbGE=)
 | `92.3% <0%> (+1.53%)` | :arrow_up: |
   | 
[...in/scala/whisk/utils/ExecutionContextFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3717/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL3V0aWxzL0V4ZWN1dGlvbkNvbnRleHRGYWN0b3J5LnNjYWxh)
 | `100% <0%> (+7.69%)` | :arrow_up: |
   | 
[...whisk/connector/kafka/KafkaConsumerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3717/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYUNvbnN1bWVyQ29ubmVjdG9yLnNjYWxh)
 | `58.33% <0%> (+22.91%)` | :arrow_up: |
   | 
[...whisk/connector/kafka/KafkaProducerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3717/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYVByb2R1Y2VyQ29ubmVjdG9yLnNjYWxh)
 | `58.33% <0%> (+36.11%)` | :arrow_up: |
   | ... and [1 
more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3717/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3717?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3717?src=pr&el=footer).
 Last update 
[c7de75d...ef72775](https://codecov.io/gh/apache/incubator-openwhisk/pull/3717?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

--

[GitHub] rabbah commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds

[GitBox]

rabbah commented on issue #3661: Restrict allowed namespaces when creating 
action of certain kinds
URL: 
https://github.com/apache/incubator-openwhisk/pull/3661#issuecomment-393726555
 
 
   I thought I’d mention that we do have a mechanism in place today related to 
quotas which is tied to the Identity. This is done by attaching a limits 
document to the subject. It has the advtange of being dynamically adaptable (eg 
wskadmin) vs a white list that’s configured once at deployment.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds

[GitBox]

rabbah commented on issue #3661: Restrict allowed namespaces when creating 
action of certain kinds
URL: 
https://github.com/apache/incubator-openwhisk/pull/3661#issuecomment-393726555
 
 
   I thought I’d mention that we do have a mechanism in place today related to 
quotas which is tied to the Identity. This is done by attachment a limits 
document to the subject. It has the advtange of being dynamically adaptable (eg 
wskadmin) vs a white list that’s configured once at deployment.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai closed issue #925: better error messages

[GitBox]

pritidesai closed issue #925: better error messages
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/925
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai commented on issue #925: better error messages

[GitBox]

pritidesai commented on issue #925: better error messages
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/925#issuecomment-393712357
 
 
   Closing it as its fixed now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai opened a new issue #947: Add Unit test for verifying wskdeploy producing help message when ran without any flags and without any manifest

[GitBox]

pritidesai opened a new issue #947: Add Unit test for verifying wskdeploy 
producing help message when ran without any flags and without any manifest
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/947
 
 
   Addressing @rabbah's comment here, please see if its possible to add unit 
test for this PR:
   
   https://github.com/apache/incubator-openwhisk-wskdeploy/pull/943


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai commented on issue #943: Add the help message, if manifest file is not accesible to wskdeploy and undeploy

[GitBox]

pritidesai commented on issue #943: Add the help message, if manifest file is 
not accesible to wskdeploy and undeploy
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/943#issuecomment-393712227
 
 
   Created separate low priority issue for the same, #947 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai commented on issue #944: API section doesn't support response-type

[GitBox]

pritidesai commented on issue #944: API section doesn't support response-type
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/944#issuecomment-393707637
 
 
   @brunogirin I am tracking this with issue #724 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai opened a new pull request #946: runtimes

[GitBox]

pritidesai opened a new pull request #946: runtimes
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/946
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] houshengbo commented on issue #169: Allow user to change to use their chose JDK and document (multiple repos)

[GitBox]

houshengbo commented on issue #169: Allow user to change to use their chose JDK 
and document (multiple repos)
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/169#issuecomment-393668146
 
 
   @mrutkows The oracle image is unable to replace with the open jdk. After I 
did it, the gradlew build works fine, but the controller image is unable to 
launch.
   
   Error by downloaing the OPEN jdk:
   ```
   Exception in thread "main" java/lang/UnsatisfiedLinkError: 
sun/management/FileSystemImpl.isAccessUserOnly0(Ljava/lang/String;)Z
at sun/management/FileSystemImpl.isAccessUserOnly 
(FileSystemImpl.java:41)
at sun/management/jmxremote/ConnectorBootstrap.checkPasswordFile 
(ConnectorBootstrap.java:575)
at 
sun/management/jmxremote/ConnectorBootstrap.startRemoteConnectorServer 
(ConnectorBootstrap.java:429)
at sun/management/Agent.startAgent (Agent.java:262)
at sun/management/Agent.startAgent (Agent.java:452)
at java/lang/System.startSNMPAgent (NativeMethod:4294967295)
at java/lang/Thread.completeInitialization (Thread.java:167)
at java/lang/J9VMInternals.completeInitialization 
(J9VMInternals.java:72)
   ```
   
   Error with the docker image FROM anapsix/alpine-java:8u172b11_jdk:
   ```
   [2018-05-31T22:24:56.782Z] [INFO] Initializing Kamon...
   [INFO] [05/31/2018 22:24:57.120] [main] [StatsDExtension(akka://kamon)] 
Starting the Kamon(StatsD) extension
   [2018-05-31T22:24:57.154Z] [INFO] Slf4jLogger started
   [2018-05-31T22:24:57.171Z] [INFO] Starting remoting
   [2018-05-31T22:24:57.264Z] [INFO] Remoting started; listening on addresses 
:[akka.tcp://controller-actor-system@172.17.0.1:8000]
   [2018-05-31T22:24:57.266Z] [INFO] Remoting now listens on addresses: 
[akka.tcp://controller-actor-system@172.17.0.1:8000]
   [2018-05-31T22:24:57.295Z] [INFO] Cluster Node 
[akka.tcp://controller-actor-system@172.17.0.1:8000] - Starting up...
   [2018-05-31T22:24:57.325Z] [INFO] Cluster Node 
[akka.tcp://controller-actor-system@172.17.0.1:8000] - Registered cluster JMX 
MBean [akka:type=Cluster]
   [2018-05-31T22:24:57.326Z] [INFO] Cluster Node 
[akka.tcp://controller-actor-system@172.17.0.1:8000] - Started up successfully
   [2018-05-31T22:24:57.352Z] [INFO] Cluster Node 
[akka.tcp://controller-actor-system@172.17.0.1:8000] - No seed-nodes 
configured, manual cluster join required
   [2018-05-31T22:24:57.496Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for limits.triggers.fires.perMinute
   [2018-05-31T22:24:57.497Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for limits.actions.sequence.maxLength
   [2018-05-31T22:24:57.497Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for limits.actions.invokes.concurrent
   [2018-05-31T22:24:57.498Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for controller.instances
   [2018-05-31T22:24:57.499Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for whisk.version.date
   [2018-05-31T22:24:57.499Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for whisk.version.buildno
   [2018-05-31T22:24:57.500Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for limits.actions.invokes.perMinute
   [2018-05-31T22:24:57.501Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for limits.actions.invokes.concurrentInSystem
   [2018-05-31T22:24:57.502Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for runtimes.manifest
   [2018-05-31T22:24:57.503Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for kafka.hosts
   [2018-05-31T22:24:57.504Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for port
   [2018-05-31T22:24:57.819Z] [ERROR] [#tid_sid_unknown] 
[KafkaMessagingProvider] ensureTopic for completed0 failed due to 
java.util.concurrent.ExecutionException: 
org.apache.kafka.common.errors.InvalidConfigurationException: Unknown topic 
config name: retention.LBytes
   [2018-05-31T22:24:57.829Z] [ERROR] [#tid_sid_unknown] [Controller] failure 
during msgProvider.ensureTopic for topic completed0
   [2018-05-31T22:24:57.835Z] [INFO] Shutting down remote daemon.
   [2018-05-31T22:24:57.836Z] [INFO] Remote daemon shut down; proceeding with 
flushing remote transports.
   [2018-05-31T22:24:57.853Z] [INFO] Remoting shut down
   [2018-05-31T22:24:57.854Z] [INFO] Remoting shut down.
   ```
   
   Error with the docker image 
adoptopenjdk/openjdk8-openj9:jdk8u162-b12_openj9-0.8.0-alpine:
   ```
   /bin/sh: exec: line 1: /init.sh: not found
   ```
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] houshengbo commented on issue #169: Allow user to change to use their chose JDK and document (multiple repos)

[GitBox]

houshengbo commented on issue #169: Allow user to change to use their chose JDK 
and document (multiple repos)
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/169#issuecomment-393668146
 
 
   @mrutkows The oracle image is unable to replace with the open jdk. After I 
did it, the gradlew build works fine, but the controller image is unable to 
launch.
   
   Error by downloaing the OPEN jdk:
   ```
   Exception in thread "main" java/lang/UnsatisfiedLinkError: 
sun/management/FileSystemImpl.isAccessUserOnly0(Ljava/lang/String;)Z
at sun/management/FileSystemImpl.isAccessUserOnly 
(FileSystemImpl.java:41)
at sun/management/jmxremote/ConnectorBootstrap.checkPasswordFile 
(ConnectorBootstrap.java:575)
at 
sun/management/jmxremote/ConnectorBootstrap.startRemoteConnectorServer 
(ConnectorBootstrap.java:429)
at sun/management/Agent.startAgent (Agent.java:262)
at sun/management/Agent.startAgent (Agent.java:452)
at java/lang/System.startSNMPAgent (NativeMethod:4294967295)
at java/lang/Thread.completeInitialization (Thread.java:167)
at java/lang/J9VMInternals.completeInitialization 
(J9VMInternals.java:72)
   ```
   
   Error with the docker image FROM anapsix/alpine-java:8u172b11_jdk:
   ```
   [2018-05-31T22:24:56.782Z] [INFO] Initializing Kamon...
   [INFO] [05/31/2018 22:24:57.120] [main] [StatsDExtension(akka://kamon)] 
Starting the Kamon(StatsD) extension
   [2018-05-31T22:24:57.154Z] [INFO] Slf4jLogger started
   [2018-05-31T22:24:57.171Z] [INFO] Starting remoting
   [2018-05-31T22:24:57.264Z] [INFO] Remoting started; listening on addresses 
:[akka.tcp://controller-actor-system@172.17.0.1:8000]
   [2018-05-31T22:24:57.266Z] [INFO] Remoting now listens on addresses: 
[akka.tcp://controller-actor-system@172.17.0.1:8000]
   [2018-05-31T22:24:57.295Z] [INFO] Cluster Node 
[akka.tcp://controller-actor-system@172.17.0.1:8000] - Starting up...
   [2018-05-31T22:24:57.325Z] [INFO] Cluster Node 
[akka.tcp://controller-actor-system@172.17.0.1:8000] - Registered cluster JMX 
MBean [akka:type=Cluster]
   [2018-05-31T22:24:57.326Z] [INFO] Cluster Node 
[akka.tcp://controller-actor-system@172.17.0.1:8000] - Started up successfully
   [2018-05-31T22:24:57.352Z] [INFO] Cluster Node 
[akka.tcp://controller-actor-system@172.17.0.1:8000] - No seed-nodes 
configured, manual cluster join required
   [2018-05-31T22:24:57.496Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for limits.triggers.fires.perMinute
   [2018-05-31T22:24:57.497Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for limits.actions.sequence.maxLength
   [2018-05-31T22:24:57.497Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for limits.actions.invokes.concurrent
   [2018-05-31T22:24:57.498Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for controller.instances
   [2018-05-31T22:24:57.499Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for whisk.version.date
   [2018-05-31T22:24:57.499Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for whisk.version.buildno
   [2018-05-31T22:24:57.500Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for limits.actions.invokes.perMinute
   [2018-05-31T22:24:57.501Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for limits.actions.invokes.concurrentInSystem
   [2018-05-31T22:24:57.502Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for runtimes.manifest
   [2018-05-31T22:24:57.503Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for kafka.hosts
   [2018-05-31T22:24:57.504Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for port
   [2018-05-31T22:24:57.819Z] [ERROR] [#tid_sid_unknown] 
[KafkaMessagingProvider] ensureTopic for completed0 failed due to 
java.util.concurrent.ExecutionException: 
org.apache.kafka.common.errors.InvalidConfigurationException: Unknown topic 
config name: retention.LBytes
   [2018-05-31T22:24:57.829Z] [ERROR] [#tid_sid_unknown] [Controller] failure 
during msgProvider.ensureTopic for topic completed0
   [2018-05-31T22:24:57.835Z] [INFO] Shutting down remote daemon.
   [2018-05-31T22:24:57.836Z] [INFO] Remote daemon shut down; proceeding with 
flushing remote transports.
   [2018-05-31T22:24:57.853Z] [INFO] Remoting shut down
   [2018-05-31T22:24:57.854Z] [INFO] Remoting shut down.
   ```
   
   Error with the docker image 
adoptopenjdk/openjdk8-openj9:jdk8u162-b12_openj9-0.8.0-alpine:
   ```
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] houshengbo commented on issue #169: Allow user to change to use their chose JDK and document (multiple repos)

[GitBox]

houshengbo commented on issue #169: Allow user to change to use their chose JDK 
and document (multiple repos)
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/169#issuecomment-393668146
 
 
   @mrutkows The oracle image is unable to replace with the open jdk. After I 
did it, the gradlew build works fine, but the controller image is unable to 
launch.
   
   Error by downloaing the OPEN jdk:
   ```
   Exception in thread "main" java/lang/UnsatisfiedLinkError: 
sun/management/FileSystemImpl.isAccessUserOnly0(Ljava/lang/String;)Z
at sun/management/FileSystemImpl.isAccessUserOnly 
(FileSystemImpl.java:41)
at sun/management/jmxremote/ConnectorBootstrap.checkPasswordFile 
(ConnectorBootstrap.java:575)
at 
sun/management/jmxremote/ConnectorBootstrap.startRemoteConnectorServer 
(ConnectorBootstrap.java:429)
at sun/management/Agent.startAgent (Agent.java:262)
at sun/management/Agent.startAgent (Agent.java:452)
at java/lang/System.startSNMPAgent (NativeMethod:4294967295)
at java/lang/Thread.completeInitialization (Thread.java:167)
at java/lang/J9VMInternals.completeInitialization 
(J9VMInternals.java:72)
   ```
   
   Error with the docker image FROM anapsix/alpine-java:8u172b11_jdk:
   ```
   [2018-05-31T22:24:56.782Z] [INFO] Initializing Kamon...
   [INFO] [05/31/2018 22:24:57.120] [main] [StatsDExtension(akka://kamon)] 
Starting the Kamon(StatsD) extension
   [2018-05-31T22:24:57.154Z] [INFO] Slf4jLogger started
   [2018-05-31T22:24:57.171Z] [INFO] Starting remoting
   [2018-05-31T22:24:57.264Z] [INFO] Remoting started; listening on addresses 
:[akka.tcp://controller-actor-system@172.17.0.1:8000]
   [2018-05-31T22:24:57.266Z] [INFO] Remoting now listens on addresses: 
[akka.tcp://controller-actor-system@172.17.0.1:8000]
   [2018-05-31T22:24:57.295Z] [INFO] Cluster Node 
[akka.tcp://controller-actor-system@172.17.0.1:8000] - Starting up...
   [2018-05-31T22:24:57.325Z] [INFO] Cluster Node 
[akka.tcp://controller-actor-system@172.17.0.1:8000] - Registered cluster JMX 
MBean [akka:type=Cluster]
   [2018-05-31T22:24:57.326Z] [INFO] Cluster Node 
[akka.tcp://controller-actor-system@172.17.0.1:8000] - Started up successfully
   [2018-05-31T22:24:57.352Z] [INFO] Cluster Node 
[akka.tcp://controller-actor-system@172.17.0.1:8000] - No seed-nodes 
configured, manual cluster join required
   [2018-05-31T22:24:57.496Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for limits.triggers.fires.perMinute
   [2018-05-31T22:24:57.497Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for limits.actions.sequence.maxLength
   [2018-05-31T22:24:57.497Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for limits.actions.invokes.concurrent
   [2018-05-31T22:24:57.498Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for controller.instances
   [2018-05-31T22:24:57.499Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for whisk.version.date
   [2018-05-31T22:24:57.499Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for whisk.version.buildno
   [2018-05-31T22:24:57.500Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for limits.actions.invokes.perMinute
   [2018-05-31T22:24:57.501Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for limits.actions.invokes.concurrentInSystem
   [2018-05-31T22:24:57.502Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for runtimes.manifest
   [2018-05-31T22:24:57.503Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for kafka.hosts
   [2018-05-31T22:24:57.504Z] [INFO] [#tid_sid_unknown] [Config] environment 
set value for port
   [2018-05-31T22:24:57.819Z] [ERROR] [#tid_sid_unknown] 
[KafkaMessagingProvider] ensureTopic for completed0 failed due to 
java.util.concurrent.ExecutionException: 
org.apache.kafka.common.errors.InvalidConfigurationException: Unknown topic 
config name: retention.LBytes
   [2018-05-31T22:24:57.829Z] [ERROR] [#tid_sid_unknown] [Controller] failure 
during msgProvider.ensureTopic for topic completed0
   [2018-05-31T22:24:57.835Z] [INFO] Shutting down remote daemon.
   [2018-05-31T22:24:57.836Z] [INFO] Remote daemon shut down; proceeding with 
flushing remote transports.
   [2018-05-31T22:24:57.853Z] [INFO] Remoting shut down
   [2018-05-31T22:24:57.854Z] [INFO] Remoting shut down.
   ```
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] houshengbo commented on issue #169: Allow user to change to use their chose JDK and document (multiple repos)

[GitBox]

houshengbo commented on issue #169: Allow user to change to use their chose JDK 
and document (multiple repos)
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/169#issuecomment-393668146
 
 
   @mrutkows The oracle image is unable to replace with the open jdk. After I 
did it, the gradlew build works fine, but the controller image is unable to 
launch.
   
   ```
   Exception in thread "main" java/lang/UnsatisfiedLinkError: 
sun/management/FileSystemImpl.isAccessUserOnly0(Ljava/lang/String;)Z
at sun/management/FileSystemImpl.isAccessUserOnly 
(FileSystemImpl.java:41)
at sun/management/jmxremote/ConnectorBootstrap.checkPasswordFile 
(ConnectorBootstrap.java:575)
at 
sun/management/jmxremote/ConnectorBootstrap.startRemoteConnectorServer 
(ConnectorBootstrap.java:429)
at sun/management/Agent.startAgent (Agent.java:262)
at sun/management/Agent.startAgent (Agent.java:452)
at java/lang/System.startSNMPAgent (NativeMethod:4294967295)
at java/lang/Thread.completeInitialization (Thread.java:167)
at java/lang/J9VMInternals.completeInitialization 
(J9VMInternals.java:72)
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3697: Add equals method to ensure that ByteSize instances satisfy Comparable contract

[GitBox]

codecov-io commented on issue #3697: Add equals method to ensure that ByteSize 
instances satisfy Comparable contract
URL: 
https://github.com/apache/incubator-openwhisk/pull/3697#issuecomment-391501095
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=h1)
 Report
   > Merging 
[#3697](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/5f2dedb185216f7586e6b91de30866bcb50415a7?src=pr&el=desc)
 will **increase** coverage by `0.95%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/graphs/tree.svg?token=l0YmsiSAso&width=650&height=150&src=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3697  +/-   ##
   ==
   + Coverage   74.11%   75.06%   +0.95% 
   ==
 Files 127  127  
 Lines6038 6040   +2 
 Branches  390  386   -4 
   ==
   + Hits 4475 4534  +59 
   + Misses   1563 1506  -57
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[.../scala/src/main/scala/whisk/core/entity/Size.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1NpemUuc2NhbGE=)
 | `96.15% <50%> (+0.15%)` | :arrow_up: |
   | 
[...cala/src/main/scala/whisk/http/ErrorResponse.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvRXJyb3JSZXNwb25zZS5zY2FsYQ==)
 | `89.77% <0%> (+1.13%)` | :arrow_up: |
   | 
[...on/scala/src/main/scala/whisk/common/Logging.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Mb2dnaW5nLnNjYWxh)
 | `87.35% <0%> (+1.14%)` | :arrow_up: |
   | 
[...ain/scala/whisk/core/entity/ActivationResult.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0FjdGl2YXRpb25SZXN1bHQuc2NhbGE=)
 | `92.3% <0%> (+1.53%)` | :arrow_up: |
   | 
[...in/scala/whisk/utils/ExecutionContextFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL3V0aWxzL0V4ZWN1dGlvbkNvbnRleHRGYWN0b3J5LnNjYWxh)
 | `100% <0%> (+7.69%)` | :arrow_up: |
   | 
[...rc/main/scala/whisk/core/entity/ExecManifest.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWNNYW5pZmVzdC5zY2FsYQ==)
 | `96.34% <0%> (+14.63%)` | :arrow_up: |
   | 
[...whisk/connector/kafka/KafkaConsumerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYUNvbnN1bWVyQ29ubmVjdG9yLnNjYWxh)
 | `58.33% <0%> (+22.91%)` | :arrow_up: |
   | 
[...whisk/connector/kafka/KafkaProducerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYVByb2R1Y2VyQ29ubmVjdG9yLnNjYWxh)
 | `58.33% <0%> (+36.11%)` | :arrow_up: |
   | 
[...whisk/connector/kafka/KafkaMessagingProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYU1lc3NhZ2luZ1Byb3ZpZGVyLnNjYWxh)
 | `88.46% <0%> (+65.38%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=footer).
 Last update 
[5f2dedb...1463d1a](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai closed pull request #45: Exclude gradle working directory.

[GitBox]

pritidesai closed pull request #45: Exclude gradle working directory.
URL: https://github.com/apache/incubator-openwhisk-utilities/pull/45
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/scancode/ASF-Release.cfg b/scancode/ASF-Release.cfg
index ec483db..1d72564 100644
--- a/scancode/ASF-Release.cfg
+++ b/scancode/ASF-Release.cfg
@@ -56,20 +56,26 @@ ASFMinifiedLicenseHeaderREM.txt
 .gitattributes
 .github
 .gitignore
+.gradle
 .jshintrc
 .profiling.*
 .pydevproject
 .rat-excludes
+.tox
 
-# 'vendor' and cache directory create by gograble build tool
+# Exclude cache and 'vendor' directories created by the `gogradle` build tool
 .gogradle
 vendor
 
-# Exclude performance test files (no significant content)
-incubator-openwhisk/tests/performance/wrk_tests
-incubator-openwhisk/tests/dat/actions
-incubator-openwhisk/docs/images
-incubator-openwhisk/bin
+# Exclude from incubator-openwhisk
+# Jenkins/test generated reports
+# Test data. Performance (post.lua) and Empty (empty.js)
+# Generated binary artifacts
+tests/build/reports
+tests/performance/wrk_tests
+tests/dat/actions
+docs/images
+bin
 
 # incubator-openwhisk-apigateway test dependency exclusions
 lua_install
diff --git a/scancode/scanCode.cfg b/scancode/scanCode.cfg
index 5666f8d..e75e80b 100644
--- a/scancode/scanCode.cfg
+++ b/scancode/scanCode.cfg
@@ -29,9 +29,18 @@ ASFMinifiedLicenseHeader.txt
 # List of paths (inclusive of subdirectories) to exlude from code scanning
 [Excludes]
 # General exclusions
-.tox
-.git
 .bin
+.dockerignore
+.git
+.gitattributes
+.github
+.gitignore
+.gradle
+.jshintrc
+.profiling.*
+.pydevproject
+.rat-excludes
+.tox
 
 # OpenWhisk binary artifact exclusion
 bin


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows commented on issue #724: API Gateway - Add support to specify response type in manifest file

[GitBox]

mrutkows commented on issue #724: API Gateway - Add support to specify response 
type in manifest file
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/724#issuecomment-393686791
 
 
   This is the PR that added the support to the CLI: 
https://github.com/apache/incubator-openwhisk-cli/pull/170
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah closed pull request #3716: Augment RuntimeManifest with stem cell configuration per kind.

[GitBox]

rabbah closed pull request #3716: Augment RuntimeManifest with stem cell 
configuration per kind.
URL: https://github.com/apache/incubator-openwhisk/pull/3716
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ansible/files/runtimes.json b/ansible/files/runtimes.json
index 1866b69195..44cb30f2c1 100644
--- a/ansible/files/runtimes.json
+++ b/ansible/files/runtimes.json
@@ -14,7 +14,11 @@
 "image": {
 "name": "nodejs6action"
 },
-"deprecated": false
+"deprecated": false,
+"stemCells": [{
+"count": 2,
+"memory": "256 MB"
+}]
 },
 {
 "kind": "nodejs:8",
diff --git a/common/scala/src/main/scala/whisk/core/entity/ExecManifest.scala 
b/common/scala/src/main/scala/whisk/core/entity/ExecManifest.scala
index 668ef609f6..7436d167f0 100644
--- a/common/scala/src/main/scala/whisk/core/entity/ExecManifest.scala
+++ b/common/scala/src/main/scala/whisk/core/entity/ExecManifest.scala
@@ -122,6 +122,7 @@ protected[core] object ExecManifest {
* @param requireMain true iff main entry point is not optional
* @param sentinelledLogs true iff the runtime generates stdout/stderr log 
sentinels after an activation
* @param image optional image name, otherwise inferred via fixed mapping 
(remove colons and append 'action')
+   * @param stemCells optional list of stemCells to be initialized by invoker 
per kind
*/
   protected[core] case class RuntimeManifest(kind: String,
  image: ImageName,
@@ -129,17 +130,17 @@ protected[core] object ExecManifest {
  default: Option[Boolean] = None,
  attached: Option[Attached] = None,
  requireMain: Option[Boolean] = 
None,
- sentinelledLogs: Option[Boolean] 
= None) {
-
-protected[entity] def toJsonSummary = {
-  JsObject(
-"kind" -> kind.toJson,
-"image" -> image.publicImageName.toJson,
-"deprecated" -> deprecated.getOrElse(false).toJson,
-"default" -> default.getOrElse(false).toJson,
-"attached" -> attached.isDefined.toJson,
-"requireMain" -> requireMain.getOrElse(false).toJson)
-}
+ sentinelledLogs: Option[Boolean] 
= None,
+ stemCells: Option[List[StemCell]] 
= None)
+
+  /**
+   * A stemcell configuration read from the manifest for a container image to 
be initialized by the container pool.
+   *
+   * @param count the number of stemcell containers to create
+   * @param memory the max memory this stemcell will allocate
+   */
+  protected[entity] case class StemCell(count: Int, memory: ByteSize) {
+require(count > 0, "count must be positive")
   }
 
   /**
@@ -240,6 +241,14 @@ protected[core] object ExecManifest {
 
 val knownContainerRuntimes: Set[String] = 
runtimes.flatMap(_.versions.map(_.kind))
 
+val manifests: Map[String, RuntimeManifest] = {
+  runtimes.flatMap {
+_.versions.map { m =>
+  m.kind -> m
+}
+  }.toMap
+}
+
 def skipDockerPull(image: ImageName): Boolean = {
   blackboxImages.contains(image) ||
   image.prefix.flatMap(p => bypassPullForLocalImages.map(_ == 
p)).getOrElse(false)
@@ -248,7 +257,16 @@ protected[core] object ExecManifest {
 def toJson: JsObject = {
   runtimes
 .map { family =>
-  family.name -> family.versions.map(_.toJsonSummary)
+  family.name -> family.versions.map {
+case rt =>
+  JsObject(
+"kind" -> rt.kind.toJson,
+"image" -> rt.image.publicImageName.toJson,
+"deprecated" -> rt.deprecated.getOrElse(false).toJson,
+"default" -> rt.default.getOrElse(false).toJson,
+"attached" -> rt.attached.isDefined.toJson,
+"requireMain" -> rt.requireMain.getOrElse(false).toJson)
+  }
 }
 .toMap
 .toJson
@@ -262,12 +280,17 @@ protected[core] object ExecManifest {
   }
 }
 
-val manifests: Map[String, RuntimeManifest] = {
-  runtimes.flatMap {
-_.versions.map { m =>
-  m.kind -> m
+/**
+ * Collects all runtimes for which there is a stemcell configuration 
defined
+ *
+ * @return list of runtime manifests with stemcell configurations
+ */
+def stemcells: Map[RuntimeManifest, List[StemCell]] = {
+  manifests
+.flatMap {
+  case (_, m) => m.stemCells.ma

[GitHub] dgrove-oss opened a new pull request #209: Kube container factory

[GitBox]

dgrove-oss opened a new pull request #209: Kube container factory
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/209
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai closed pull request #92: Update Travis to use ASF-Release.cfg.

[GitBox]

pritidesai closed pull request #92: Update Travis to use ASF-Release.cfg.
URL: https://github.com/apache/incubator-openwhisk-client-go/pull/92
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/tools/travis/build.sh b/tools/travis/build.sh
index c3cf047b..5ca2ad3a 100755
--- a/tools/travis/build.sh
+++ b/tools/travis/build.sh
@@ -25,4 +25,4 @@ UTILDIR="$ROOTDIR/../incubator-openwhisk-utilities"
 
 # run scancode using the ASF Release configuration
 cd $UTILDIR
-scancode/scanCode.py --config scancode/ASF-Release-v2.cfg $ROOTDIR
+scancode/scanCode.py --config scancode/ASF-Release.cfg $ROOTDIR


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai closed pull request #279: Update Travis to use ASF-Release.cfg

[GitBox]

pritidesai closed pull request #279: Update Travis to use ASF-Release.cfg
URL: https://github.com/apache/incubator-openwhisk-catalog/pull/279
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/tools/travis/build.sh b/tools/travis/build.sh
index 09f9b25..49a68dd 100755
--- a/tools/travis/build.sh
+++ b/tools/travis/build.sh
@@ -27,7 +27,7 @@ UTILDIR="$ROOTDIR/../incubator-openwhisk-utilities"
 
 # run scancode
 cd $UTILDIR
-scancode/scanCode.py --config scancode/ASF-Release-v2.cfg $ROOTDIR
+scancode/scanCode.py --config scancode/ASF-Release.cfg $ROOTDIR
 
 # run jshint
 cd $ROOTDIR/packages


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows opened a new pull request #45: Exclude gradle working directory.

[GitBox]

mrutkows opened a new pull request #45: Exclude gradle working directory.
URL: https://github.com/apache/incubator-openwhisk-utilities/pull/45
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] houshengbo commented on issue #169: Allow user to change to use their chose JDK and document (multiple repos)

[GitBox]

houshengbo commented on issue #169: Allow user to change to use their chose JDK 
and document (multiple repos)
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/169#issuecomment-393668146
 
 
   @mrutkows The oracle image is unable to replace with the open jdk. After I 
did it, the gradlew build works fine, but the controller image is unable to 
launch.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #3689: Enable extending environment variables of Controller and Invoker

[GitBox]

csantanapr commented on issue #3689: Enable extending environment variables of 
Controller and Invoker
URL: 
https://github.com/apache/incubator-openwhisk/pull/3689#issuecomment-393659683
 
 
   PG1 2974 ⌛️ 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3689: Enable extending environment variables of Controller and Invoker

[GitBox]

codecov-io commented on issue #3689: Enable extending environment variables of 
Controller and Invoker
URL: 
https://github.com/apache/incubator-openwhisk/pull/3689#issuecomment-391266601
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3689?src=pr&el=h1)
 Report
   > Merging 
[#3689](https://codecov.io/gh/apache/incubator-openwhisk/pull/3689?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/0134f784a0eae6fcb9d026f00843e989288e9a4b?src=pr&el=desc)
 will **increase** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3689/graphs/tree.svg?token=l0YmsiSAso&width=650&height=150&src=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3689?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3689  +/-   ##
   ==
   + Coverage  75%   75.02%   +0.01% 
   ==
 Files 127  127  
 Lines6030 6030  
 Branches  388  388  
   ==
   + Hits 4523 4524   +1 
   + Misses   1507 1506   -1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3689?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3689/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==)
 | `88.46% <0%> (+3.84%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3689?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3689?src=pr&el=footer).
 Last update 
[0134f78...8fec3f5](https://codecov.io/gh/apache/incubator-openwhisk/pull/3689?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #724: API Gateway - Add support to specify response type in manifest file

[GitBox]

csantanapr commented on issue #724: API Gateway - Add support to specify 
response type in manifest file
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/724#issuecomment-393641466
 
 
   I like the second better
   ```
   apis:
  book-club:
   club:
   books:
   getBooks:
   method: GET
   response: 
   postBooks:
   method: POST
   response: 
   putBooks:
   method: PUT
   response: 
   deleteBooks:
   method: DELETE
   response: 
   ```
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows opened a new pull request #308: Update Travis to use ASF-Release.cfg.

[GitBox]

mrutkows opened a new pull request #308: Update Travis to use ASF-Release.cfg.
URL: https://github.com/apache/incubator-openwhisk-cli/pull/308
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows opened a new pull request #92: Update Travis to use ASF-Release.cfg.

[GitBox]

mrutkows opened a new pull request #92: Update Travis to use ASF-Release.cfg.
URL: https://github.com/apache/incubator-openwhisk-client-go/pull/92
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows opened a new pull request #3717: Update Travis to use ASF-Release.cfg.

[GitBox]

mrutkows opened a new pull request #3717: Update Travis to use ASF-Release.cfg.
URL: https://github.com/apache/incubator-openwhisk/pull/3717
 
 
   
   
   ## Description
   
   
   
   ## Related issue and scope
   
   - [ ] I opened an issue to propose and discuss this change (#)
   
   ## My changes affect the following components
   
   
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   - [X] Apache Compiance
   
   ## Types of changes
   
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
behavior).
   
   ## Checklist:
   
   
   - [X] I signed an [Apache 
CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [ ] I reviewed the [style 
guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
 and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows opened a new pull request #279: Update Travis to use ASF-Release.cfg

[GitBox]

mrutkows opened a new pull request #279: Update Travis to use ASF-Release.cfg
URL: https://github.com/apache/incubator-openwhisk-catalog/pull/279
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows closed issue #110: Set up and document the header rules in OpenWhisk community

[GitBox]

mrutkows closed issue #110: Set up and document the header rules in OpenWhisk 
community
URL: https://github.com/apache/incubator-openwhisk-release/issues/110
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows commented on issue #110: Set up and document the header rules in OpenWhisk community

[GitBox]

mrutkows commented on issue #110: Set up and document the header rules in 
OpenWhisk community
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/110#issuecomment-393629090
 
 
   These license header rules are now documented on this page:
   
https://github.com/apache/incubator-openwhisk-release/blob/master/docs/license_compliance.md


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows commented on issue #118: Describe scanCode plus Apache RAT usage

[GitBox]

mrutkows commented on issue #118: Describe scanCode plus Apache RAT usage
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/118#issuecomment-393628912
 
 
   These tools and their usage are described in the page:
   
https://github.com/apache/incubator-openwhisk-release/blob/master/docs/license_compliance.md


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows closed issue #118: Describe scanCode plus Apache RAT usage

[GitBox]

mrutkows closed issue #118: Describe scanCode plus Apache RAT usage
URL: https://github.com/apache/incubator-openwhisk-release/issues/118
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr closed pull request #3700: allow to override vagrant box os with trusty

[GitBox]

csantanapr closed pull request #3700: allow to override vagrant box os with 
trusty
URL: https://github.com/apache/incubator-openwhisk/pull/3700
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/tools/vagrant/README.md b/tools/vagrant/README.md
index 4015d7cf22..127ec27248 100644
--- a/tools/vagrant/README.md
+++ b/tools/vagrant/README.md
@@ -282,6 +282,12 @@ the configuration to use trusted certificates instead.
 Don't use `vagrant resume`. See
 [here](https://github.com/mitchellh/vagrant/issues/6787) for related issue.
 
+## Override Vagrant Box
+By default the Vagrant VM will use `ubuntu/xenial64` if you want to use 
`ubuntu/trusty64` you can override with an environment variable `BOX_OS`.
+```
+BOX_OS="ubuntu/trusty64" ./hello
+```
+
 ## Using Vagrant VM in GUI mode (Optional)
 Create VM with Desktop GUI. The `username` and `password` are both set to
 `vagrant` by default.
diff --git a/tools/vagrant/Vagrantfile b/tools/vagrant/Vagrantfile
index ce7b143ebb..2494dd98a5 100644
--- a/tools/vagrant/Vagrantfile
+++ b/tools/vagrant/Vagrantfile
@@ -24,7 +24,7 @@
 # Don't use vagrant resume, it will run the provisioning a second producing 
errors
 # Use vagrant suspend and vagrant up (using up it skips provisioning)
 
-BOX = "ubuntu/xenial64"
+BOX = ENV['BOX_OS'] || "ubuntu/xenial64"
 BOX_MEMORY = ENV['BOX_MEMORY'] || '4096'
 BOX_CPUS = ENV['BOX_CPUS'] || '4'
 MACHINE_IP = ENV['MACHINE_IP'] || '192.168.33.16'


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows commented on issue #116: Review list of proposed ScanCode exclusions for default configuration.

[GitBox]

mrutkows commented on issue #116: Review list of proposed ScanCode exclusions 
for default configuration.
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/116#issuecomment-393628593
 
 
   @daisy Can you confirm that the .pom file and the ASF-Release.cfg are 
aligned to have the same exclusions?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows commented on issue #169: Allow user to change to use their chose JDK and document (multiple repos)

[GitBox]

mrutkows commented on issue #169: Allow user to change to use their chose JDK 
and document (multiple repos)
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/169#issuecomment-393627290
 
 
   Note: related to issues
   - [Change JDK used to build main OW to be "pluggable" for building Source 
(release) 
#153](https://github.com/apache/incubator-openwhisk-release/issues/153)
   - [JDK license issue for the runtime Java 
#137](https://github.com/apache/incubator-openwhisk-release/issues/137)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows commented on issue #169: Allow user to change to use their chose JDK and document (multiple repos)

[GitBox]

mrutkows commented on issue #169: Allow user to change to use their chose JDK 
and document (multiple repos)
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/169#issuecomment-393627290
 
 
   Note: related to issues
   - https://github.com/apache/incubator-openwhisk-release/issues/153
   - https://github.com/apache/incubator-openwhisk-release/issues/137


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows closed issue #131: license_compliance.md excludes "Gradle files" but rationale not sound

[GitBox]

mrutkows closed issue #131: license_compliance.md excludes "Gradle files" but 
rationale not sound
URL: https://github.com/apache/incubator-openwhisk-release/issues/131
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows commented on issue #169: Allow user to change to use their chose JDK and document (multiple repos)

[GitBox]

mrutkows commented on issue #169: Allow user to change to use their chose JDK 
and document (multiple repos)
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/169#issuecomment-393627290
 
 
   Note: related to issue 
https://github.com/apache/incubator-openwhisk-release/issues/153


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows commented on issue #131: license_compliance.md excludes "Gradle files" but rationale not sound

[GitBox]

mrutkows commented on issue #131: license_compliance.md excludes "Gradle files" 
but rationale not sound
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/131#issuecomment-393627519
 
 
   Agree to close this as long as we add license to *.gradle config files.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows commented on issue #159: Verify source code release TARs do not contain "ignore" and project tooling files.

[GitBox]

mrutkows commented on issue #159: Verify source code release TARs do not 
contain "ignore" and project tooling files.
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/159#issuecomment-393627003
 
 
   @houshengbo if you have confirmed this by inspection of a TAR you generated 
for the apigateway repo. then feel free to close this issue.  I would 
appreciate a link to the PR (and file) where you fixed (and configured) this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows commented on issue #161: Verify we do not include any tooling dot `.` configuration files in source release

[GitBox]

mrutkows commented on issue #161: Verify we do not include any tooling dot `.` 
configuration files in source release
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/161#issuecomment-393626895
 
 
   @houshengbo if you have confirmed this by inspection of a TARs you generated 
for the repos. then feel free to close this issue.  I would appreciate a link 
to the PR (and file) where you fixed (and configured) this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows commented on issue #171: Automate checks to verify 'tests' (and other files) are removed from source release TAR files

[GitBox]

mrutkows commented on issue #171: Automate checks to verify 'tests' (and other 
files) are removed from source release TAR files
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/171#issuecomment-393625825
 
 
   @houshengbo if you have confirmed this by inspection of a TAR you generated 
for the apigateway repo. then feel free to close this issue.  I would 
appreciate a link to the PR (and file) where you fixed (and configured) this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows commented on issue #168: Move scancode before Lua test dependencies are installed

[GitBox]

mrutkows commented on issue #168: Move scancode before Lua test dependencies 
are installed
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/168#issuecomment-393626421
 
 
   Tried to do this in PR 
https://github.com/apache/incubator-openwhisk-apigateway/pull/306 (closed), but 
the scan results do not appear (too early in logs) and it does not appear to 
stop "scripts" from running if an error occurs...  will need to revisit later.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows commented on issue #171: Automate checks to verify 'tests' (and other files) are removed from source release TAR files

[GitBox]

mrutkows commented on issue #171: Automate checks to verify 'tests' (and other 
files) are removed from source release TAR files
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/171#issuecomment-393625825
 
 
   @houshengbo if you have confirmed this by inspection of a TAR you generated 
for the apigateway repo. then feel free to close this issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] houshengbo commented on issue #163: Exclude "tests" directories in source code release archives from all repos.

[GitBox]

houshengbo commented on issue #163: Exclude "tests" directories in source code 
release archives from all repos.
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/163#issuecomment-393625085
 
 
   This issue is fixed by : 
https://github.com/apache/incubator-openwhisk-release/pull/172


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] houshengbo closed issue #163: Exclude "tests" directories in source code release archives from all repos.

[GitBox]

houshengbo closed issue #163: Exclude "tests" directories in source code 
release archives from all repos.
URL: https://github.com/apache/incubator-openwhisk-release/issues/163
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] houshengbo opened a new pull request #174: Add the file .dockerignore back to the release

[GitBox]

houshengbo opened a new pull request #174: Add the file .dockerignore back to 
the release
URL: https://github.com/apache/incubator-openwhisk-release/pull/174
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3700: allow to override vagrant box os with trusty

[GitBox]

codecov-io commented on issue #3700: allow to override vagrant box os with 
trusty
URL: 
https://github.com/apache/incubator-openwhisk/pull/3700#issuecomment-391790909
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3700?src=pr&el=h1)
 Report
   > Merging 
[#3700](https://codecov.io/gh/apache/incubator-openwhisk/pull/3700?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/cd2d9e2292c65a7d0bd6e303e7f37254b913a8e5?src=pr&el=desc)
 will **increase** coverage by `0.86%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3700/graphs/tree.svg?width=650&height=150&src=pr&token=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3700?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3700  +/-   ##
   ==
   + Coverage74.5%   75.37%   +0.86% 
   ==
 Files 126  127   +1 
 Lines5994 6566 +572 
 Branches  392  430  +38 
   ==
   + Hits 4466 4949 +483 
   - Misses   1528 1617  +89
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3700?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...src/main/scala/whisk/core/entity/WhiskAction.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3700/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1doaXNrQWN0aW9uLnNjYWxh)
 | `74.37% <0%> (-3.26%)` | :arrow_down: |
   | 
[...rc/main/scala/whisk/core/controller/ApiUtils.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3700/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9BcGlVdGlscy5zY2FsYQ==)
 | `66.03% <0%> (-0.63%)` | :arrow_down: |
   | 
[...e/loadBalancer/ShardingContainerPoolBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3700/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL1NoYXJkaW5nQ29udGFpbmVyUG9vbEJhbGFuY2VyLnNjYWxh)
 | `32.08% <0%> (-0.47%)` | :arrow_down: |
   | 
[...whisk/core/database/ConcurrentMapBackedCache.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3700/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQ29uY3VycmVudE1hcEJhY2tlZENhY2hlLnNjYWxh)
 | `90% <0%> (ø)` | |
   | 
[...re/database/MultipleReadersSingleWriterCache.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3700/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvTXVsdGlwbGVSZWFkZXJzU2luZ2xlV3JpdGVyQ2FjaGUuc2NhbGE=)
 | `94.89% <0%> (+0.16%)` | :arrow_up: |
   | 
[...ain/scala/whisk/core/containerpool/HttpUtils.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3700/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9IdHRwVXRpbHMuc2NhbGE=)
 | `92.85% <0%> (+0.35%)` | :arrow_up: |
   | 
[...in/scala/whisk/core/database/DocumentFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3700/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvRG9jdW1lbnRGYWN0b3J5LnNjYWxh)
 | `90.72% <0%> (+1.24%)` | :arrow_up: |
   | 
[...main/scala/whisk/core/entity/WhiskActivation.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3700/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1doaXNrQWN0aXZhdGlvbi5zY2FsYQ==)
 | `94.5% <0%> (+3.27%)` | :arrow_up: |
   | 
[...src/main/scala/whisk/core/entity/Attachments.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3700/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0F0dGFjaG1lbnRzLnNjYWxh)
 | `86.66% <0%> (+3.33%)` | :arrow_up: |
   | 
[...n/scala/whisk/core/database/CouchDbRestStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3700/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQ291Y2hEYlJlc3RTdG9yZS5zY2FsYQ==)
 | `75.28% <0%> (+5.53%)` | :arrow_up: |
   | ... and [2 
more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3700/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3700?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3700?src=pr&el=footer).
 Last update 
[cd2d9e2...41990fa](https://codecov.io/gh/apache/incubator-openwhisk/pull/3700?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codeco

[GitHub] pritidesai closed pull request #945: Update Travis to use ASF-Release.cfg

[GitBox]

pritidesai closed pull request #945: Update Travis to use ASF-Release.cfg
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/945
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/tools/travis/scancode.sh b/tools/travis/scancode.sh
index 0f4205ad..815573b4 100755
--- a/tools/travis/scancode.sh
+++ b/tools/travis/scancode.sh
@@ -24,4 +24,4 @@ UTILDIR="$ROOTDIR/../incubator-openwhisk-utilities"
 
 # run scancode using the ASF Release configuration
 cd $UTILDIR
-scancode/scanCode.py --config scancode/ASF-Release-v2.cfg $ROOTDIR
+scancode/scanCode.py --config scancode/ASF-Release.cfg $ROOTDIR


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows commented on issue #168: Move scancode before Lua test dependencies are installed

[GitBox]

mrutkows commented on issue #168: Move scancode before Lua test dependencies 
are installed
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/168#issuecomment-393613654
 
 
   This was not intended to be a gating issue for source release, but it is an 
issue that needs to be still addressed.  That is why it is marked low-priority.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows opened a new issue #168: Move scancode before Lua test dependencies are installed

[GitBox]

mrutkows opened a new issue #168: Move scancode before Lua test dependencies 
are installed
URL: https://github.com/apache/incubator-openwhisk-release/issues/168
 
 
   Currently scancode runs AFTER many Lua test dependencies are installed as 
part the ```install``` Travis step in "isntsall-deps.sh":
   
   
   install:
 - cd tests
   - ./install-deps.sh
   ```
   
   but, scancode runs in the later Travis step ```script``` which forces our 
ASF-Release.cfg having to exclude directories ```lua_install``` and 
```tests/lua_modules``` which we should not even be scanning. 
   
   We should try and move the invocation of "scancode" to right after we 
install it in the "setup.sh" travis script.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows commented on issue #168: Move scancode before Lua test dependencies are installed

[GitBox]

mrutkows commented on issue #168: Move scancode before Lua test dependencies 
are installed
URL: 
https://github.com/apache/incubator-openwhisk-release/issues/168#issuecomment-393613654
 
 
   This was not intended to be a gating issue for source release, but it is an 
issue that needs to be still addressed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr opened a new pull request #3700: allow to override vagrant box os with trusty

[GitBox]

csantanapr opened a new pull request #3700: allow to override vagrant box os 
with trusty
URL: https://github.com/apache/incubator-openwhisk/pull/3700
 
 
   ## Description
   allow to override vagrant box with trusty
   
   ## My changes affect the following components
   
   
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   - [x] Vagrant
   
   ## Types of changes
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [x] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
behavior).
   
   ## Checklist:
   - [x] I signed an [Apache 
CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [ ] I reviewed the [style 
guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
 and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr closed pull request #3700: allow to override vagrant box os with trusty

[GitBox]

csantanapr closed pull request #3700: allow to override vagrant box os with 
trusty
URL: https://github.com/apache/incubator-openwhisk/pull/3700
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/tools/vagrant/README.md b/tools/vagrant/README.md
index 4015d7cf22..127ec27248 100644
--- a/tools/vagrant/README.md
+++ b/tools/vagrant/README.md
@@ -282,6 +282,12 @@ the configuration to use trusted certificates instead.
 Don't use `vagrant resume`. See
 [here](https://github.com/mitchellh/vagrant/issues/6787) for related issue.
 
+## Override Vagrant Box
+By default the Vagrant VM will use `ubuntu/xenial64` if you want to use 
`ubuntu/trusty64` you can override with an environment variable `BOX_OS`.
+```
+BOX_OS="ubuntu/trusty64" ./hello
+```
+
 ## Using Vagrant VM in GUI mode (Optional)
 Create VM with Desktop GUI. The `username` and `password` are both set to
 `vagrant` by default.
diff --git a/tools/vagrant/Vagrantfile b/tools/vagrant/Vagrantfile
index ce7b143ebb..2494dd98a5 100644
--- a/tools/vagrant/Vagrantfile
+++ b/tools/vagrant/Vagrantfile
@@ -24,7 +24,7 @@
 # Don't use vagrant resume, it will run the provisioning a second producing 
errors
 # Use vagrant suspend and vagrant up (using up it skips provisioning)
 
-BOX = "ubuntu/xenial64"
+BOX = ENV['BOX_OS'] || "ubuntu/xenial64"
 BOX_MEMORY = ENV['BOX_MEMORY'] || '4096'
 BOX_CPUS = ENV['BOX_CPUS'] || '4'
 MACHINE_IP = ENV['MACHINE_IP'] || '192.168.33.16'


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows opened a new pull request #945: Update Travis to use ASF-Release.cfg

[GitBox]

mrutkows opened a new pull request #945: Update Travis to use ASF-Release.cfg
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/945
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows opened a new pull request #173: Fix exclusions for wskdeploy repo.

[GitBox]

mrutkows opened a new pull request #173: Fix exclusions for wskdeploy repo.
URL: https://github.com/apache/incubator-openwhisk-release/pull/173
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3713: WIP: Make JDK configurable

[GitBox]

codecov-io commented on issue #3713: WIP: Make JDK configurable
URL: 
https://github.com/apache/incubator-openwhisk/pull/3713#issuecomment-393582412
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713?src=pr&el=h1)
 Report
   > Merging 
[#3713](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/0134f784a0eae6fcb9d026f00843e989288e9a4b?src=pr&el=desc)
 will **increase** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713/graphs/tree.svg?width=650&token=l0YmsiSAso&height=150&src=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3713  +/-   ##
   ==
   + Coverage  75%   75.02%   +0.01% 
   ==
 Files 127  127  
 Lines6030 6030  
 Branches  388  388  
   ==
   + Hits 4523 4524   +1 
   + Misses   1507 1506   -1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==)
 | `88.46% <0%> (+3.84%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713?src=pr&el=footer).
 Last update 
[0134f78...99bdddc](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3713: WIP: Make JDK configurable

[GitBox]

codecov-io commented on issue #3713: WIP: Make JDK configurable
URL: 
https://github.com/apache/incubator-openwhisk/pull/3713#issuecomment-393582412
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713?src=pr&el=h1)
 Report
   > Merging 
[#3713](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/0134f784a0eae6fcb9d026f00843e989288e9a4b?src=pr&el=desc)
 will **increase** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713/graphs/tree.svg?height=150&width=650&token=l0YmsiSAso&src=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3713  +/-   ##
   ==
   + Coverage  75%   75.02%   +0.01% 
   ==
 Files 127  127  
 Lines6030 6030  
 Branches  388  388  
   ==
   + Hits 4523 4524   +1 
   + Misses   1507 1506   -1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==)
 | `88.46% <0%> (+3.84%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713?src=pr&el=footer).
 Last update 
[0134f78...99bdddc](https://codecov.io/gh/apache/incubator-openwhisk/pull/3713?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on a change in pull request #3689: Enable extending environment variables of Controller and Invoker

[GitBox]

csantanapr commented on a change in pull request #3689: Enable extending 
environment variables of Controller and Invoker
URL: 
https://github.com/apache/incubator-openwhisk/pull/3689#discussion_r192136706
 
 

 ##
 File path: ansible/roles/controller/tasks/deploy.yml
 ##
 @@ -236,6 +236,11 @@
 
   "CONFIG_whisk_transactions_header": "{{ transactions.header }}"
 
+- name: merge extra env variables
+  set_fact:
+controller_env: "{{ controller_env | default({}) | 
combine(controller.extraEnv) }}"
+  when: controller.extraEnv | default(false)
 
 Review comment:
   I see define the default `{}` and then drop the `when` I will give this a 
test and update


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on a change in pull request #3689: Enable extending environment variables of Controller and Invoker

[GitBox]

csantanapr commented on a change in pull request #3689: Enable extending 
environment variables of Controller and Invoker
URL: 
https://github.com/apache/incubator-openwhisk/pull/3689#discussion_r192136706
 
 

 ##
 File path: ansible/roles/controller/tasks/deploy.yml
 ##
 @@ -236,6 +236,11 @@
 
   "CONFIG_whisk_transactions_header": "{{ transactions.header }}"
 
+- name: merge extra env variables
+  set_fact:
+controller_env: "{{ controller_env | default({}) | 
combine(controller.extraEnv) }}"
+  when: controller.extraEnv | default(false)
 
 Review comment:
   I see define the default and then drop the `when` I will give this a test 
and update


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on a change in pull request #3689: Enable extending environment variables of Controller and Invoker

[GitBox]

csantanapr commented on a change in pull request #3689: Enable extending 
environment variables of Controller and Invoker
URL: 
https://github.com/apache/incubator-openwhisk/pull/3689#discussion_r192131671
 
 

 ##
 File path: ansible/roles/controller/tasks/deploy.yml
 ##
 @@ -236,6 +236,11 @@
 
   "CONFIG_whisk_transactions_header": "{{ transactions.header }}"
 
+- name: merge extra env variables
+  set_fact:
+controller_env: "{{ controller_env | default({}) | 
combine(controller.extraEnv) }}"
+  when: controller.extraEnv | default(false)
 
 Review comment:
   I assumed we need it the extra safety, your proposing just dropping the 
`when` line?
since in group_vars we already default to `default({})` and extra check is 
not need it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] style95 closed pull request #3663: Support SPI for ContainerPool and ContainerProxy

[GitBox]

style95 closed pull request #3663: Support SPI for ContainerPool and 
ContainerProxy
URL: https://github.com/apache/incubator-openwhisk/pull/3663
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/common/scala/src/main/resources/reference.conf 
b/common/scala/src/main/resources/reference.conf
index 35cf4f09a5..249ca24a25 100644
--- a/common/scala/src/main/resources/reference.conf
+++ b/common/scala/src/main/resources/reference.conf
@@ -7,4 +7,6 @@ whisk.spi {
   ContainerFactoryProvider = 
whisk.core.containerpool.docker.DockerContainerFactoryProvider
   LogStoreProvider = 
whisk.core.containerpool.logging.DockerToActivationLogStoreProvider
   LoadBalancerProvider = whisk.core.loadBalancer.ShardingContainerPoolBalancer
+  ContainerPoolProvider = whisk.core.containerpool.DefaultContainerPool
+  ContainerProxyProvider = whisk.core.containerpool.DefaultContainerProxy
 }
diff --git 
a/core/invoker/src/main/scala/whisk/core/containerpool/ContainerPool.scala 
b/core/invoker/src/main/scala/whisk/core/containerpool/ContainerPool.scala
index 183556942e..4a7089bdf7 100644
--- a/core/invoker/src/main/scala/whisk/core/containerpool/ContainerPool.scala
+++ b/core/invoker/src/main/scala/whisk/core/containerpool/ContainerPool.scala
@@ -17,274 +17,40 @@
 
 package whisk.core.containerpool
 
-import scala.collection.immutable
+import akka.actor.{ActorRef, ActorRefFactory, Props}
+import whisk.common.TransactionId
+import whisk.core.entity.ExecManifest.ImageName
+import whisk.core.entity._
+import whisk.spi.Spi
 
-import whisk.common.{AkkaLogging, LoggingMarkers, TransactionId}
+import scala.concurrent.Future
 
-import akka.actor.{Actor, ActorRef, ActorRefFactory, Props}
-
-import whisk.core.entity.ByteSize
-import whisk.core.entity.CodeExec
-import whisk.core.entity.EntityName
-import whisk.core.entity.ExecutableWhiskAction
-import whisk.core.entity.size._
-import whisk.core.connector.MessageFeed
-
-import scala.concurrent.duration._
-
-sealed trait WorkerState
-case object Busy extends WorkerState
-case object Free extends WorkerState
-
-case class WorkerData(data: ContainerData, state: WorkerState)
-
-/**
- * A pool managing containers to run actions on.
- *
- * This pool fulfills the other half of the ContainerProxy contract. Only
- * one job (either Start or Run) is sent to a child-actor at any given
- * time. The pool then waits for a response of that container, indicating
- * the container is done with the job. Only then will the pool send another
- * request to that container.
- *
- * Upon actor creation, the pool will start to prewarm containers according
- * to the provided prewarmConfig, iff set. Those containers will **not** be
- * part of the poolsize calculation, which is capped by the poolSize parameter.
- * Prewarm containers are only used, if they have matching arguments
- * (kind, memory) and there is space in the pool.
- *
- * @param childFactory method to create new container proxy actor
- * @param feed actor to request more work from
- * @param prewarmConfig optional settings for container prewarming
- * @param poolConfig config for the ContainerPool
- */
-class ContainerPool(childFactory: ActorRefFactory => ActorRef,
-feed: ActorRef,
-prewarmConfig: Option[PrewarmingConfig] = None,
-poolConfig: ContainerPoolConfig)
-extends Actor {
-  implicit val logging = new AkkaLogging(context.system.log)
-
-  var freePool = immutable.Map.empty[ActorRef, ContainerData]
-  var busyPool = immutable.Map.empty[ActorRef, ContainerData]
-  var prewarmedPool = immutable.Map.empty[ActorRef, ContainerData]
-  val logMessageInterval = 10.seconds
-
-  prewarmConfig.foreach { config =>
-logging.info(this, s"pre-warming ${config.count} ${config.exec.kind} 
containers")(TransactionId.invokerWarmup)
-(1 to config.count).foreach { _ =>
-  prewarmContainer(config.exec, config.memoryLimit)
-}
-  }
-
-  def logContainerStart(r: Run, containerState: String): Unit = {
-val namespaceName = r.msg.user.namespace.name
-val actionName = r.action.name.name
-val activationId = r.msg.activationId.toString
-
-r.msg.transid.mark(
-  this,
-  LoggingMarkers.INVOKER_CONTAINER_START(containerState),
-  s"containerStart containerState: $containerState action: $actionName 
namespace: $namespaceName activationId: $activationId",
-  akka.event.Logging.InfoLevel)
-  }
-
-  def receive: Receive = {
-// A job to run on a container
-//
-// Run messages are received either via the feed or from child containers 
which cannot process
-// their requests and send them back to the pool for rescheduling (this 
may happen if "docker" operations
-// fail for example, or a container has aged and was de

[GitHub] style95 opened a new pull request #3663: Support SPI for ContainerPool and ContainerProxy

[GitBox]

style95 opened a new pull request #3663: Support SPI for ContainerPool and 
ContainerProxy
URL: https://github.com/apache/incubator-openwhisk/pull/3663
 
 
   This closes #3662.
   
   ## Description
   It will apply SPI to `ContainerPool` and `ContainerProxy`.
   Current `ContainerPool` and `ContainerProxy` are renamed with `Default` 
prefix.
   
   ## Related issue and scope
   
   - [x] I opened an issue to propose and discuss this change (#3662)
   
   ## My changes affect the following components
   
   
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [x] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [x] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
behavior).
   
   ## Checklist:
   
   
   - [x] I signed an [Apache 
CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style 
guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
 and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubee closed pull request #307: Separate the source directories for different files to package

[GitBox]

dubee closed pull request #307: Separate the source directories for different 
files to package
URL: https://github.com/apache/incubator-openwhisk-cli/pull/307
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/build.gradle b/build.gradle
index d666bf09..aa26756f 100644
--- a/build.gradle
+++ b/build.gradle
@@ -241,11 +241,13 @@ task individualArchives(
 if (p.goOs == 'linux') { compression = Compression.GZIP }
 destinationDir = file(cliReleaseLocation)
 baseName = 
"${p.zipFileName}-${packageVersion}-${p.owOs}-${p.goArch}"
-from "${cliBuildLocation}/${p.goOs}-${p.goArch}/"
-include "${buildFileName}*"
-from "./"
-include "LICENSE.txt", "NOTICE.txt", "README.md"
-exclude "wski18n"
+from("${cliBuildLocation}/${p.goOs}-${p.goArch}/") {
+include "${buildFileName}*"
+}
+from("./") {
+include "LICENSE.txt", "NOTICE.txt", "README.md"
+exclude "wski18n"
+}
 }
 })
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3697: Add equals method to ensure that ByteSize instances satisfy Comparable contract

[GitBox]

codecov-io commented on issue #3697: Add equals method to ensure that ByteSize 
instances satisfy Comparable contract
URL: 
https://github.com/apache/incubator-openwhisk/pull/3697#issuecomment-391501095
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=h1)
 Report
   > Merging 
[#3697](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/0134f784a0eae6fcb9d026f00843e989288e9a4b?src=pr&el=desc)
 will **increase** coverage by `0.02%`.
   > The diff coverage is `83.33%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/graphs/tree.svg?width=650&src=pr&token=l0YmsiSAso&height=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3697  +/-   ##
   ==
   + Coverage  75%   75.03%   +0.02% 
   ==
 Files 127  127  
 Lines6030 6036   +6 
 Branches  388  389   +1 
   ==
   + Hits 4523 4529   +6 
 Misses   1507 1507
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[.../scala/src/main/scala/whisk/core/entity/Size.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1NpemUuc2NhbGE=)
 | `96.15% <83.33%> (-1.68%)` | :arrow_down: |
   | 
[...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==)
 | `88.46% <0%> (+3.84%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=footer).
 Last update 
[0134f78...3ee3937](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3697: Add equals method to ensure that ByteSize instances satisfy Comparable contract

[GitBox]

codecov-io commented on issue #3697: Add equals method to ensure that ByteSize 
instances satisfy Comparable contract
URL: 
https://github.com/apache/incubator-openwhisk/pull/3697#issuecomment-391501095
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=h1)
 Report
   > Merging 
[#3697](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/0134f784a0eae6fcb9d026f00843e989288e9a4b?src=pr&el=desc)
 will **increase** coverage by `0.02%`.
   > The diff coverage is `83.33%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/graphs/tree.svg?width=650&token=l0YmsiSAso&height=150&src=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3697  +/-   ##
   ==
   + Coverage  75%   75.03%   +0.02% 
   ==
 Files 127  127  
 Lines6030 6036   +6 
 Branches  388  389   +1 
   ==
   + Hits 4523 4529   +6 
 Misses   1507 1507
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[.../scala/src/main/scala/whisk/core/entity/Size.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1NpemUuc2NhbGE=)
 | `96.15% <83.33%> (-1.68%)` | :arrow_down: |
   | 
[...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==)
 | `88.46% <0%> (+3.84%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=footer).
 Last update 
[0134f78...3ee3937](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3697: Add equals method to ensure that ByteSize instances satisfy Comparable contract

[GitBox]

codecov-io commented on issue #3697: Add equals method to ensure that ByteSize 
instances satisfy Comparable contract
URL: 
https://github.com/apache/incubator-openwhisk/pull/3697#issuecomment-391501095
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=h1)
 Report
   > Merging 
[#3697](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/0134f784a0eae6fcb9d026f00843e989288e9a4b?src=pr&el=desc)
 will **increase** coverage by `0.02%`.
   > The diff coverage is `83.33%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/graphs/tree.svg?width=650&token=l0YmsiSAso&height=150&src=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3697  +/-   ##
   ==
   + Coverage  75%   75.03%   +0.02% 
   ==
 Files 127  127  
 Lines6030 6036   +6 
 Branches  388  389   +1 
   ==
   + Hits 4523 4529   +6 
 Misses   1507 1507
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[.../scala/src/main/scala/whisk/core/entity/Size.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1NpemUuc2NhbGE=)
 | `96.15% <83.33%> (-1.68%)` | :arrow_down: |
   | 
[...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==)
 | `88.46% <0%> (+3.84%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=footer).
 Last update 
[0134f78...3ee3937](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3697: Add equals method to ensure that ByteSize instances satisfy Comparable contract

[GitBox]

codecov-io commented on issue #3697: Add equals method to ensure that ByteSize 
instances satisfy Comparable contract
URL: 
https://github.com/apache/incubator-openwhisk/pull/3697#issuecomment-391501095
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=h1)
 Report
   > Merging 
[#3697](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/0134f784a0eae6fcb9d026f00843e989288e9a4b?src=pr&el=desc)
 will **increase** coverage by `0.02%`.
   > The diff coverage is `83.33%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/graphs/tree.svg?width=650&height=150&token=l0YmsiSAso&src=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3697  +/-   ##
   ==
   + Coverage  75%   75.03%   +0.02% 
   ==
 Files 127  127  
 Lines6030 6036   +6 
 Branches  388  389   +1 
   ==
   + Hits 4523 4529   +6 
 Misses   1507 1507
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[.../scala/src/main/scala/whisk/core/entity/Size.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1NpemUuc2NhbGE=)
 | `96.15% <83.33%> (-1.68%)` | :arrow_down: |
   | 
[...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==)
 | `88.46% <0%> (+3.84%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=footer).
 Last update 
[0134f78...3ee3937](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on a change in pull request #3715: Update wget to fix travis builds

[GitBox]

csantanapr commented on a change in pull request #3715: Update wget to fix 
travis builds
URL: 
https://github.com/apache/incubator-openwhisk/pull/3715#discussion_r192106949
 
 

 ##
 File path: common/scala/Dockerfile
 ##
 @@ -19,7 +19,7 @@ ENV PATH $JAVA_HOME/bin:$PATH
 
 
 RUN apk upgrade --update && \
-apk add --update libstdc++ curl ca-certificates bash sed && \
+apk add --update libstdc++ curl ca-certificates bash sed wget&& \
 
 Review comment:
   Hum no problem with not having a space in wget&& ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] brunogirin opened a new issue #944: API section doesn't support response-type

[GitBox]

brunogirin opened a new issue #944: API section doesn't support response-type
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/944
 
 
   According to the [API Gateway 
documentation](https://github.com/apache/incubator-openwhisk/blob/master/docs/apigateway.md),
 in order to have full control over the HTTP response, it is necessary to 
specify `--response-type http` when creating an API with `wsk`. The current 
`wskdeploy` manifest doesn't allow that parameter to be specified in the `api` 
section.
   
   ## Expected behaviour
   
   It should be possible to specify `response-type: http` in the manifest and 
create the corresponding API accordingly.
   
   ## Related issues
   
   This issue is related to #940 .


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #3715: Update wget to fix travis builds

[GitBox]

csantanapr commented on issue #3715: Update wget to fix travis builds
URL: 
https://github.com/apache/incubator-openwhisk/pull/3715#issuecomment-393535964
 
 
   Hum no problem with not having a space in `wget&&` ?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #3715: Update wget to fix travis builds

[GitBox]

csantanapr commented on issue #3715: Update wget to fix travis builds
URL: 
https://github.com/apache/incubator-openwhisk/pull/3715#issuecomment-393535964
 
 
   Hum no problem with not having a space in `wget&&` ?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai commented on issue #724: API Gateway - Add support to specify response type in manifest file

[GitBox]

pritidesai commented on issue #724: API Gateway - Add support to specify 
response type in manifest file
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/724#issuecomment-393535270
 
 
   Moving it to high priority as @brunogirin looking for this fix.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai commented on issue #724: API Gateway - Add support to specify response type in manifest file

[GitBox]

pritidesai commented on issue #724: API Gateway - Add support to specify 
response type in manifest file
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/724#issuecomment-393535020
 
 
   @brunogirin @csantanapr @mrutkows please provide your feedback for the 
design. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3716: Augment RuntimeManifest with stem cell configuration per kind.

[GitBox]

codecov-io commented on issue #3716: Augment RuntimeManifest with stem cell 
configuration per kind.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3716#issuecomment-393522499
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716?src=pr&el=h1)
 Report
   > Merging 
[#3716](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/0134f784a0eae6fcb9d026f00843e989288e9a4b?src=pr&el=desc)
 will **increase** coverage by `0.04%`.
   > The diff coverage is `84.21%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716/graphs/tree.svg?width=650&height=150&src=pr&token=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3716  +/-   ##
   ==
   + Coverage  75%   75.05%   +0.04% 
   ==
 Files 127  127  
 Lines6030 6038   +8 
 Branches  388  390   +2 
   ==
   + Hits 4523 4532   +9 
   + Misses   1507 1506   -1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...scala/whisk/core/containerpool/ContainerPool.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQb29sLnNjYWxh)
 | `85.88% <100%> (ø)` | :arrow_up: |
   | 
[...rc/main/scala/whisk/core/entity/ExecManifest.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWNNYW5pZmVzdC5zY2FsYQ==)
 | `96.34% <100%> (+0.23%)` | :arrow_up: |
   | 
[.../scala/src/main/scala/whisk/core/entity/Size.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1NpemUuc2NhbGE=)
 | `96% <75%> (-1.83%)` | :arrow_down: |
   | 
[...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==)
 | `88.46% <0%> (+3.84%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716?src=pr&el=footer).
 Last update 
[0134f78...1661974](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3697: Add equals method to ensure that ByteSize instances satisfy Comparable contract

[GitBox]

codecov-io commented on issue #3697: Add equals method to ensure that ByteSize 
instances satisfy Comparable contract
URL: 
https://github.com/apache/incubator-openwhisk/pull/3697#issuecomment-391501095
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=h1)
 Report
   > Merging 
[#3697](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/0134f784a0eae6fcb9d026f00843e989288e9a4b?src=pr&el=desc)
 will **increase** coverage by `0.02%`.
   > The diff coverage is `83.33%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/graphs/tree.svg?width=650&height=150&src=pr&token=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3697  +/-   ##
   ==
   + Coverage  75%   75.03%   +0.02% 
   ==
 Files 127  127  
 Lines6030 6036   +6 
 Branches  388  389   +1 
   ==
   + Hits 4523 4529   +6 
 Misses   1507 1507
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[.../scala/src/main/scala/whisk/core/entity/Size.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1NpemUuc2NhbGE=)
 | `96.15% <83.33%> (-1.68%)` | :arrow_down: |
   | 
[...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==)
 | `88.46% <0%> (+3.84%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=footer).
 Last update 
[0134f78...3ee3937](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3716: Augment RuntimeManifest with stem cell configuration per kind.

[GitBox]

codecov-io commented on issue #3716: Augment RuntimeManifest with stem cell 
configuration per kind.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3716#issuecomment-393522499
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716?src=pr&el=h1)
 Report
   > Merging 
[#3716](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/0134f784a0eae6fcb9d026f00843e989288e9a4b?src=pr&el=desc)
 will **increase** coverage by `0.04%`.
   > The diff coverage is `84.21%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716/graphs/tree.svg?height=150&width=650&src=pr&token=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3716  +/-   ##
   ==
   + Coverage  75%   75.05%   +0.04% 
   ==
 Files 127  127  
 Lines6030 6038   +8 
 Branches  388  390   +2 
   ==
   + Hits 4523 4532   +9 
   + Misses   1507 1506   -1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...scala/whisk/core/containerpool/ContainerPool.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQb29sLnNjYWxh)
 | `85.88% <100%> (ø)` | :arrow_up: |
   | 
[...rc/main/scala/whisk/core/entity/ExecManifest.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWNNYW5pZmVzdC5zY2FsYQ==)
 | `96.34% <100%> (+0.23%)` | :arrow_up: |
   | 
[.../scala/src/main/scala/whisk/core/entity/Size.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1NpemUuc2NhbGE=)
 | `96% <75%> (-1.83%)` | :arrow_down: |
   | 
[...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==)
 | `88.46% <0%> (+3.84%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716?src=pr&el=footer).
 Last update 
[0134f78...1661974](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3716: Augment RuntimeManifest with stem cell configuration per kind.

[GitBox]

codecov-io commented on issue #3716: Augment RuntimeManifest with stem cell 
configuration per kind.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3716#issuecomment-393522499
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716?src=pr&el=h1)
 Report
   > Merging 
[#3716](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/0134f784a0eae6fcb9d026f00843e989288e9a4b?src=pr&el=desc)
 will **increase** coverage by `0.04%`.
   > The diff coverage is `84.21%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716/graphs/tree.svg?width=650&height=150&src=pr&token=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3716  +/-   ##
   ==
   + Coverage  75%   75.05%   +0.04% 
   ==
 Files 127  127  
 Lines6030 6038   +8 
 Branches  388  390   +2 
   ==
   + Hits 4523 4532   +9 
   + Misses   1507 1506   -1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...rc/main/scala/whisk/core/entity/ExecManifest.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWNNYW5pZmVzdC5zY2FsYQ==)
 | `96.34% <100%> (+0.23%)` | :arrow_up: |
   | 
[...scala/whisk/core/containerpool/ContainerPool.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQb29sLnNjYWxh)
 | `85.88% <100%> (ø)` | :arrow_up: |
   | 
[.../scala/src/main/scala/whisk/core/entity/Size.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1NpemUuc2NhbGE=)
 | `96% <75%> (-1.83%)` | :arrow_down: |
   | 
[...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==)
 | `88.46% <0%> (+3.84%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716?src=pr&el=footer).
 Last update 
[0134f78...1661974](https://codecov.io/gh/apache/incubator-openwhisk/pull/3716?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] brunogirin commented on issue #899: wskdeploy export fails to export the `main` attribute for Java actions

[GitBox]

brunogirin commented on issue #899: wskdeploy export fails to export the `main` 
attribute for Java actions
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/899#issuecomment-393521042
 
 
   I get a 404 error when I try to export with the latest version downloaded 
today:
   
   ```
   $ ../../whisk/wskdeploy/wskdeploy export -m test-manifest.yml --projectname 
consideratehoteliers.com_dev
   Info: The API host is [openwhisk.eu-gb.bluemix.net], from .wskprops.
   Info: The auth key is set, from .wskprops.
   Info: The namespace is [_], from .wskprops.
   Info: The apigw access token is set, from .wskprops.
   Info: Unmarshal OpenWhisk runtimes from internet at 
https://openwhisk.eu-gb.bluemix.net.
   Error: The connection failed, or timed out. (HTTP status code 404)
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #3716: Augment RuntimeManifest with stem cell configuration per kind.

[GitBox]

rabbah commented on issue #3716: Augment RuntimeManifest with stem cell 
configuration per kind.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3716#issuecomment-393518590
 
 
   https://user-images.githubusercontent.com/4959922/40783031-33262f88-64af-11e8-8c52-362e704f7efa.png";>
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #3716: Augment RuntimeManifest with stem cell configuration per kind.

[GitBox]

rabbah commented on issue #3716: Augment RuntimeManifest with stem cell 
configuration per kind.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3716#issuecomment-393515439
 
 
   https://user-images.githubusercontent.com/4959922/40782475-70b72cbe-64ad-11e8-9ff8-5bb1b8a3ce68.png";>
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #3716: Augment RuntimeManifest with stem cell configuration per kind.

[GitBox]

rabbah commented on issue #3716: Augment RuntimeManifest with stem cell 
configuration per kind.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3716#issuecomment-393515439
 
 
   https://user-images.githubusercontent.com/4959922/40782475-70b72cbe-64ad-11e8-9ff8-5bb1b8a3ce68.png";>
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah opened a new pull request #3716: Augment RuntimeManifest with stem cell configuration per kind.

[GitBox]

rabbah opened a new pull request #3716: Augment RuntimeManifest with stem cell 
configuration per kind.
URL: https://github.com/apache/incubator-openwhisk/pull/3716
 
 
   This is a replay of https://github.com/apache/incubator-openwhisk/pull/3669 
with a proper commit message.
   
   Constructs prewarming configuration from runtime manifest and its stem cell 
declarations.
   As an example:
   
 "nodejs": [
   {
 "kind": "nodejs:6",
 "default": true,
 "image": {
   "name": "nodejs6action"
 },
 "deprecated": false,
 "stemCells": [{
   "count": 2,
   "memory": "256 MB"
 }]
   }
 ]
   
   The configuration is parsed so that the count must be positive and the 
memory size a valid instance of ByteSize.
   The invokers will create the stemcells for the runtimes as specified in the 
manifest.
   
   The stem cell details are not reported in the deployment manifest (i.e., 
curl https://apihost).
   
   ## Related issue and scope
   
   - [x] I opened an issue to propose and discuss this change (See #3669)
   
   ## My changes affect the following components
   
   
   - [ ] API
   - [x] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [x] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [x] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
behavior).
   
   ## Checklist:
   
   
   - [x] I signed an [Apache 
CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style 
guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
 and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows closed pull request #306: Invoke scancode earlier in Travis to avoid scanning lua_modules.

[GitBox]

mrutkows closed pull request #306: Invoke scancode earlier in Travis to avoid 
scanning lua_modules.
URL: https://github.com/apache/incubator-openwhisk-apigateway/pull/306
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/tools/travis/build.sh b/tools/travis/build.sh
index 29f9813..1f57257 100755
--- a/tools/travis/build.sh
+++ b/tools/travis/build.sh
@@ -28,8 +28,8 @@ UTILDIR="$HOMEDIR/incubator-openwhisk-utilities"
 export OPENWHISK_HOME=$WHISKDIR
 
 # run scancode util. against project source using the ASF strict configuration
-cd $UTILDIR
-scancode/scanCode.py --config scancode/ASF-Release.cfg $ROOTDIR
+#cd $UTILDIR
+#scancode/scanCode.py --config scancode/ASF-Release.cfg $ROOTDIR
 
 # Install OpenWhisk
 cd $OPENWHISK_HOME/ansible
@@ -53,12 +53,10 @@ $ANSIBLE_CMD apigateway.yml -e apigateway_local_build=true
 #Use dockerhub
 #$ANSIBLE_CMD apigateway.yml
 
-
 $ANSIBLE_CMD wipe.yml
 $ANSIBLE_CMD openwhisk.yml -e cli_installation_mode=remote -e 
controllerProtocolForSetup=http
 
 
-
 # Tests
 cd $OPENWHISK_HOME
 cat whisk.properties
diff --git a/tools/travis/setup.sh b/tools/travis/setup.sh
index 27d7b10..be05a74 100755
--- a/tools/travis/setup.sh
+++ b/tools/travis/setup.sh
@@ -18,6 +18,7 @@
 
 SCRIPTDIR=$(cd $(dirname "$0") && pwd)
 HOMEDIR="$SCRIPTDIR/../../.."
+UTILDIR="$HOMEDIR/incubator-openwhisk-utilities"
 
 sudo gpasswd -a travis docker
 sudo -E bash -c 'echo '\''DOCKER_OPTS="-H tcp://0.0.0.0:4243 -H 
unix:///var/run/docker.sock --storage-driver=overlay 
--userns-remap=default"'\'' > /etc/default/docker'
@@ -39,7 +40,12 @@ sudo npm install -g jshint
 cd $HOMEDIR
 git clone https://github.com/apache/incubator-openwhisk-utilities.git
 
+# run scancode util. against project source using the ASF strict configuration
+cd $UTILDIR
+scancode/scanCode.py --config scancode/ASF-Release.cfg $ROOTDIR
+
 # clone main openwhisk repo. for testing purposes
+cd $HOMEDIR
 git clone --depth=1 https://github.com/apache/incubator-openwhisk.git openwhisk
 cd openwhisk
 ./tools/travis/setup.sh


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] markusthoemmes closed pull request #3714: Revert "Make stemcells configurable by deployment (#3669)"

[GitBox]

markusthoemmes closed pull request #3714: Revert "Make stemcells configurable 
by deployment  (#3669)"
URL: https://github.com/apache/incubator-openwhisk/pull/3714
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ansible/files/runtimes.json b/ansible/files/runtimes.json
index 44cb30f2c1..1866b69195 100644
--- a/ansible/files/runtimes.json
+++ b/ansible/files/runtimes.json
@@ -14,11 +14,7 @@
 "image": {
 "name": "nodejs6action"
 },
-"deprecated": false,
-"stemCells": [{
-"count": 2,
-"memory": "256 MB"
-}]
+"deprecated": false
 },
 {
 "kind": "nodejs:8",
diff --git a/common/scala/src/main/scala/whisk/core/entity/ExecManifest.scala 
b/common/scala/src/main/scala/whisk/core/entity/ExecManifest.scala
index 7436d167f0..668ef609f6 100644
--- a/common/scala/src/main/scala/whisk/core/entity/ExecManifest.scala
+++ b/common/scala/src/main/scala/whisk/core/entity/ExecManifest.scala
@@ -122,7 +122,6 @@ protected[core] object ExecManifest {
* @param requireMain true iff main entry point is not optional
* @param sentinelledLogs true iff the runtime generates stdout/stderr log 
sentinels after an activation
* @param image optional image name, otherwise inferred via fixed mapping 
(remove colons and append 'action')
-   * @param stemCells optional list of stemCells to be initialized by invoker 
per kind
*/
   protected[core] case class RuntimeManifest(kind: String,
  image: ImageName,
@@ -130,17 +129,17 @@ protected[core] object ExecManifest {
  default: Option[Boolean] = None,
  attached: Option[Attached] = None,
  requireMain: Option[Boolean] = 
None,
- sentinelledLogs: Option[Boolean] 
= None,
- stemCells: Option[List[StemCell]] 
= None)
-
-  /**
-   * A stemcell configuration read from the manifest for a container image to 
be initialized by the container pool.
-   *
-   * @param count the number of stemcell containers to create
-   * @param memory the max memory this stemcell will allocate
-   */
-  protected[entity] case class StemCell(count: Int, memory: ByteSize) {
-require(count > 0, "count must be positive")
+ sentinelledLogs: Option[Boolean] 
= None) {
+
+protected[entity] def toJsonSummary = {
+  JsObject(
+"kind" -> kind.toJson,
+"image" -> image.publicImageName.toJson,
+"deprecated" -> deprecated.getOrElse(false).toJson,
+"default" -> default.getOrElse(false).toJson,
+"attached" -> attached.isDefined.toJson,
+"requireMain" -> requireMain.getOrElse(false).toJson)
+}
   }
 
   /**
@@ -241,14 +240,6 @@ protected[core] object ExecManifest {
 
 val knownContainerRuntimes: Set[String] = 
runtimes.flatMap(_.versions.map(_.kind))
 
-val manifests: Map[String, RuntimeManifest] = {
-  runtimes.flatMap {
-_.versions.map { m =>
-  m.kind -> m
-}
-  }.toMap
-}
-
 def skipDockerPull(image: ImageName): Boolean = {
   blackboxImages.contains(image) ||
   image.prefix.flatMap(p => bypassPullForLocalImages.map(_ == 
p)).getOrElse(false)
@@ -257,16 +248,7 @@ protected[core] object ExecManifest {
 def toJson: JsObject = {
   runtimes
 .map { family =>
-  family.name -> family.versions.map {
-case rt =>
-  JsObject(
-"kind" -> rt.kind.toJson,
-"image" -> rt.image.publicImageName.toJson,
-"deprecated" -> rt.deprecated.getOrElse(false).toJson,
-"default" -> rt.default.getOrElse(false).toJson,
-"attached" -> rt.attached.isDefined.toJson,
-"requireMain" -> rt.requireMain.getOrElse(false).toJson)
-  }
+  family.name -> family.versions.map(_.toJsonSummary)
 }
 .toMap
 .toJson
@@ -280,17 +262,12 @@ protected[core] object ExecManifest {
   }
 }
 
-/**
- * Collects all runtimes for which there is a stemcell configuration 
defined
- *
- * @return list of runtime manifests with stemcell configurations
- */
-def stemcells: Map[RuntimeManifest, List[StemCell]] = {
-  manifests
-.flatMap {
-  case (_, m) => m.stemCells.map(m -> _)
+val manifests: Map[String, RuntimeManifest] = {
+  runtimes.flatMap {
+_.versions.map { m =>
+   

[GitHub] codecov-io commented on issue #3714: Revert "Make stemcells configurable by deployment (#3669)"

[GitBox]

codecov-io commented on issue #3714: Revert "Make stemcells configurable by 
deployment  (#3669)"
URL: 
https://github.com/apache/incubator-openwhisk/pull/3714#issuecomment-393508779
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3714?src=pr&el=h1)
 Report
   > Merging 
[#3714](https://codecov.io/gh/apache/incubator-openwhisk/pull/3714?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/07cdffdf2d72ace371aded68a77ef3b3ebf0f055?src=pr&el=desc)
 will **decrease** coverage by `0.01%`.
   > The diff coverage is `80%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3714/graphs/tree.svg?width=650&token=l0YmsiSAso&height=150&src=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3714?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3714  +/-   ##
   ==
   - Coverage   75.04%   75.02%   -0.02% 
   ==
 Files 127  127  
 Lines6038 6030   -8 
 Branches  390  388   -2 
   ==
   - Hits 4531 4524   -7 
   + Misses   1507 1506   -1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3714?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[.../scala/src/main/scala/whisk/core/entity/Size.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3714/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1NpemUuc2NhbGE=)
 | `97.82% <ø> (+1.82%)` | :arrow_up: |
   | 
[...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3714/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...rc/main/scala/whisk/core/entity/ExecManifest.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3714/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWNNYW5pZmVzdC5zY2FsYQ==)
 | `96.1% <100%> (-0.24%)` | :arrow_down: |
   | 
[...scala/whisk/core/containerpool/ContainerPool.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3714/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQb29sLnNjYWxh)
 | `85.88% <100%> (ø)` | :arrow_up: |
   | 
[...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3714/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==)
 | `88.46% <0%> (+3.84%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3714?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3714?src=pr&el=footer).
 Last update 
[07cdffd...9d19637](https://codecov.io/gh/apache/incubator-openwhisk/pull/3714?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dgrove-oss commented on issue #208: Small change to make persistent-volumes work in GKE

[GitBox]

dgrove-oss commented on issue #208: Small change to make persistent-volumes 
work in GKE
URL: 
https://github.com/apache/incubator-openwhisk-deploy-kube/pull/208#issuecomment-393507168
 
 
   Thanks for the contribution!  Please submit an Apache CLA as described in 
https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dgrove-oss closed pull request #207: Update runtime manifest with stem cells.

[GitBox]

dgrove-oss closed pull request #207: Update runtime manifest with stem cells.
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/207
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.gitignore b/.gitignore
index 210a582..8daa723 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,2 +1,3 @@
 kubernetes/nginx/certs
 helm/mycluster.yaml
+*~
diff --git a/helm/runtimes.json b/helm/runtimes.json
index 5a81001..d0a2bd4 100644
--- a/helm/runtimes.json
+++ b/helm/runtimes.json
@@ -14,7 +14,11 @@
 "image": {
 "name": "nodejs6action"
 },
-"deprecated": false
+"deprecated": false,
+"stemCells": [{
+"count": 2,
+"memory": "256 MB"
+}]
 },
 {
 "kind": "nodejs:8",
diff --git a/kubernetes/cluster-setup/runtimes.json 
b/kubernetes/cluster-setup/runtimes.json
index 5a81001..d0a2bd4 100644
--- a/kubernetes/cluster-setup/runtimes.json
+++ b/kubernetes/cluster-setup/runtimes.json
@@ -14,7 +14,11 @@
 "image": {
 "name": "nodejs6action"
 },
-"deprecated": false
+"deprecated": false,
+"stemCells": [{
+"count": 2,
+"memory": "256 MB"
+}]
 },
 {
 "kind": "nodejs:8",


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services