[GitHub] daisy-ycguo closed pull request #228: only run deploy script for apache/incubator-openwhisk-deploy-kube:master
daisy-ycguo closed pull request #228: only run deploy script for apache/incubator-openwhisk-deploy-kube:master URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/228 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.travis.yml b/.travis.yml index da8d137..488f2de 100644 --- a/.travis.yml +++ b/.travis.yml @@ -36,3 +36,4 @@ deploy: script: ./tools/travis/deploy.sh on: branch: master +repo: apache/incubator-openwhisk-deploy-kube This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #229: Upon helm execution "an error occurred forwarding 39967 -> 44134"
csantanapr commented on issue #229: Upon helm execution "an error occurred forwarding 39967 -> 44134" URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/229#issuecomment-398975972 @nerdguru here is a blog that might have some help, check it out https://medium.com/openwhisk/deploying-openwhisk-on-kubernetes-3f55f781fbab This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #229: Upon helm execution "an error occurred forwarding 39967 -> 44134"
csantanapr commented on issue #229: Upon helm execution "an error occurred forwarding 39967 -> 44134" URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/229#issuecomment-398975826 Hi @nerdguru can you provide some versions What OS are you using? kubectl ``` kubectl version ``` minikube ``` minikube version ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #153: some minor test cleanup
csantanapr closed pull request #153: some minor test cleanup
URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/153
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tests/src/test/scala/system/packages/AlarmsFeedTests.scala
b/tests/src/test/scala/system/packages/AlarmsFeedTests.scala
index 131d52a..390f0e1 100644
--- a/tests/src/test/scala/system/packages/AlarmsFeedTests.scala
+++ b/tests/src/test/scala/system/packages/AlarmsFeedTests.scala
@@ -35,12 +35,11 @@ class AlarmsFeedTests
val wskprops = WskProps()
val wsk = new Wsk
-
val defaultAction = Some(TestUtils.getTestActionFilename("hello.js"))
behavior of "Alarms trigger service"
-it should "should disable after reaching max triggers" in
withAssetCleaner(wskprops) {
+it should "disable after reaching max triggers" in
withAssetCleaner(wskprops) {
(wp, assetHelper) =>
implicit val wskprops = wp // shadow global props and make implicit
val triggerName = s"dummyAlarmsTrigger-${System.currentTimeMillis}"
@@ -69,7 +68,7 @@ class AlarmsFeedTests
trigger.create(name, feed = Some(s"$packageName/alarm"),
parameters = Map(
"trigger_payload" -> "alarmTest".toJson,
"cron" -> "* * * * * *".toJson,
-"maxTriggers" -> 3.toJson))
+"maxTriggers" -> 1.toJson))
}
// create rule
@@ -78,9 +77,9 @@ class AlarmsFeedTests
}
// get activation list of the trigger
-val activations = wsk.activation.pollFor(N = 4, Some(triggerName),
retries = 30).length
+val activations = wsk.activation.pollFor(N = 2, Some(triggerName),
retries = 30).length
println(s"Found activation size: $activations")
-activations should be(3)
+activations should be(1)
}
it should "update cron, startDate and stopDate parameters" in
withAssetCleaner(wskprops) {
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] jasonpet opened a new pull request #153: some minor test cleanup
jasonpet opened a new pull request #153: some minor test cleanup URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/153 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #5: reduce clone and own in the test harness (applies to other repos also)
csantanapr closed issue #5: reduce clone and own in the test harness (applies to other repos also) URL: https://github.com/apache/incubator-openwhisk-runtime-php/issues/5 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #5: reduce clone and own in the test harness (applies to other repos also)
csantanapr commented on issue #5: reduce clone and own in the test harness (applies to other repos also) URL: https://github.com/apache/incubator-openwhisk-runtime-php/issues/5#issuecomment-398953215 This is nuked now This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #8: Some source files miss Apache license headers
csantanapr closed issue #8: Some source files miss Apache license headers URL: https://github.com/apache/incubator-openwhisk-runtime-php/issues/8 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #16: Update php runtime to push master tag to Docker after Travis builds
csantanapr closed issue #16: Update php runtime to push master tag to Docker after Travis builds URL: https://github.com/apache/incubator-openwhisk-runtime-php/issues/16 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #16: Update php runtime to push master tag to Docker after Travis builds
csantanapr commented on issue #16: Update php runtime to push master tag to Docker after Travis builds URL: https://github.com/apache/incubator-openwhisk-runtime-php/issues/16#issuecomment-398953036 This is complete now This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3760: Add API gateway to redo.
csantanapr commented on issue #3760: Add API gateway to redo. URL: https://github.com/apache/incubator-openwhisk/pull/3760#issuecomment-398948782 @mdeuser can you take this reviewed it, this might have impacts to our downstream CI for the ordering of `gateway.yml` playbook now needs to be done after `openwhisk.yml` Also apigateway repo would need to be adjusted here https://github.com/apache/incubator-openwhisk-apigateway/blob/master/tools/travis/build.sh#L51 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #3745: Remove runtime builds
csantanapr closed pull request #3745: Remove runtime builds URL: https://github.com/apache/incubator-openwhisk/pull/3745 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.gitignore b/.gitignore index 7a5367f33c..44a18f8ec9 100644 --- a/.gitignore +++ b/.gitignore @@ -84,3 +84,6 @@ ansible/roles/controller/files/*.p12 # dev intellij-run-config.groovy + +# VSCode +.vscode/ diff --git a/.travis.yml b/.travis.yml index a34a2a3e2a..859f29b469 100644 --- a/.travis.yml +++ b/.travis.yml @@ -29,7 +29,7 @@ services: env: global: - ANSIBLE_CMD="ansible-playbook -i environments/local -e docker_image_prefix=testing" -- GRADLE_PROJS_SKIP="-x :actionRuntimes:pythonAction:distDocker -x :actionRuntimes:python2Action:distDocker -x actionRuntimes:swift3.1.1Action:distDocker -x actionRuntimes:swift4.1Action:distDocker -x :actionRuntimes:javaAction:distDocker" +- GRADLE_PROJS_SKIP="" notifications: email: false diff --git a/actionRuntimes/actionProxy/build.gradle b/actionRuntimes/actionProxy/build.gradle deleted file mode 100644 index 80b022a49c..00 --- a/actionRuntimes/actionProxy/build.gradle +++ /dev/null @@ -1,19 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -ext.dockerImageName = 'dockerskeleton' -apply from: '../../gradle/docker.gradle' diff --git a/actionRuntimes/javaAction/Dockerfile b/actionRuntimes/javaAction/Dockerfile deleted file mode 100644 index 8c5c1acec3..00 --- a/actionRuntimes/javaAction/Dockerfile +++ /dev/null @@ -1,4 +0,0 @@ -# Licensed to the Apache Software Foundation (ASF) under one or more contributor -# license agreements; and to You under the Apache License, Version 2.0. - -FROM openwhisk/java8action:1.1.0 diff --git a/actionRuntimes/javaAction/build.gradle b/actionRuntimes/javaAction/build.gradle deleted file mode 100644 index 539efcf40c..00 --- a/actionRuntimes/javaAction/build.gradle +++ /dev/null @@ -1,19 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -ext.dockerImageName = 'java8action' -apply from: '../../gradle/docker.gradle' diff --git a/actionRuntimes/javaAction/delete-build-run.sh b/actionRuntimes/javaAction/delete-build-run.sh deleted file mode 100755 index 8765a319b8..00 --- a/actionRuntimes/javaAction/delete-build-run.sh +++ /dev/null @@ -1,31 +0,0 @@ -#!/usr/bin/env bash -# -# Licensed to the Apache Software Foundation (ASF) under one or more -# contributor license agreements. See the NOTICE file distributed with -# this work for additional information regarding copyright ownership. -# The ASF licenses this file to You under the Apache License, Version 2.0 -# (the "License"); you may not use this file except in compliance with -# the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. -# - -# Useful for local testing. -# USE WITH CAUTION !! - -# Removes all previously built
[GitHub] codecov-io edited a comment on issue #3745: Remove runtime builds
codecov-io edited a comment on issue #3745: Remove runtime builds URL: https://github.com/apache/incubator-openwhisk/pull/3745#issuecomment-396133122 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3745?src=pr=h1) Report > Merging [#3745](https://codecov.io/gh/apache/incubator-openwhisk/pull/3745?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/09d9a9153239d1f8f9fe3748adab9f4107b73042?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3745?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3745 +/- ## == - Coverage 74.92% 74.92% -0.01% == Files 132 132 Lines6182 6181 -1 Branches 384 385 +1 == - Hits 4632 4631 -1 Misses 1550 1550 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3745?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ain/scala/whisk/core/entitlement/Entitlement.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3745/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXRsZW1lbnQvRW50aXRsZW1lbnQuc2NhbGE=) | `76.42% <0%> (-0.2%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3745?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3745?src=pr=footer). Last update [09d9a91...4031526](https://codecov.io/gh/apache/incubator-openwhisk/pull/3745?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed pull request #3777: Avoid converting ByteString to bytes in attachment inlining flow
rabbah closed pull request #3777: Avoid converting ByteString to bytes in
attachment inlining flow
URL: https://github.com/apache/incubator-openwhisk/pull/3777
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/common/scala/src/main/resources/application.conf
b/common/scala/src/main/resources/application.conf
index 6aa1bbd890..3ceaab8b77 100644
--- a/common/scala/src/main/resources/application.conf
+++ b/common/scala/src/main/resources/application.conf
@@ -117,11 +117,7 @@ whisk {
# Size limit for inlined attachments. Attachments having size less
than this would
# be inlined with there content encoded in attachmentName
-max-inline-size = 0 k
-
-# Chunk sized for converting source of bytes to ByteString as part of
attachment
-# upload flow
-chunk-size = 8 k
+max-inline-size = 16 k
}
# CouchDB related configuration
diff --git
a/common/scala/src/main/scala/whisk/core/database/AttachmentInliner.scala
b/common/scala/src/main/scala/whisk/core/database/AttachmentInliner.scala
deleted file mode 100644
index 2369b1bf26..00
--- a/common/scala/src/main/scala/whisk/core/database/AttachmentInliner.scala
+++ /dev/null
@@ -1,117 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package whisk.core.database
-
-import java.util.Base64
-
-import akka.NotUsed
-import akka.http.scaladsl.model.Uri
-import akka.stream.Materializer
-import akka.stream.scaladsl.{Concat, Sink, Source}
-import akka.util.{ByteString, ByteStringBuilder}
-import whisk.core.database.AttachmentInliner.MemScheme
-import whisk.core.entity.ByteSize
-
-import scala.collection.immutable
-import scala.concurrent.Future
-
-object AttachmentInliner {
-
- /**
- * Scheme name for attachments which are inlined
- */
- val MemScheme: String = "mem"
-}
-
-case class InliningConfig(maxInlineSize: ByteSize, chunkSize: ByteSize)
-
-/**
- * Provides support for inlining small attachments. Inlined attachment
contents are encoded as part of attachment
- * name itself.
- */
-trait AttachmentInliner {
-
- /** Materializer required for stream processing */
- protected[core] implicit val materializer: Materializer
-
- protected[database] def inlineAndTail(
-docStream: Source[ByteString, _]): Future[(immutable.Seq[Byte],
Source[Byte, _])] = {
-docStream
- .mapConcat(_.seq)
- .prefixAndTail(maxInlineSize.toBytes.toInt)
- .runWith(Sink.head[(immutable.Seq[Byte], Source[Byte, _])])
- }
-
- protected[database] def uriOf(bytes: Seq[Byte], path: => String): Uri = {
-//For less than case its definitive that tail source would be empty
-//for equal case it cannot be determined if tail source is empty. Actual
max inline size
-//would be inlineSize - 1
-if (bytes.size < maxInlineSize.toBytes) {
- Uri.from(scheme = MemScheme, path = encode(bytes))
-} else {
- Uri.from(scheme = attachmentScheme, path = path)
-}
- }
-
- /**
- * Constructs a combined source based on attachment content read so far and
rest of unread content.
- * Emitted elements are up to `chunkSize` sized [[akka.util.ByteString]]
elements.
- */
- protected[database] def combinedSource(inlinedBytes: immutable.Seq[Byte],
- tailSource: Source[Byte, _]):
Source[ByteString, NotUsed] =
-Source
- .combine(Source(inlinedBytes), tailSource)(Concat[Byte])
- .batch[ByteStringBuilder](chunkSize.toBytes, b => { val bb = new
ByteStringBuilder(); bb += b })((bb, b) =>
-bb += b)
- .map(_.result())
-
- /**
- * Constructs a source from inlined attachment contents
- */
- protected[database] def memorySource(uri: Uri): Source[ByteString, NotUsed]
= {
-require(uri.scheme == MemScheme, s"URI $uri scheme is not $MemScheme")
-Source.single(ByteString(decode(uri)))
- }
-
- protected[database] def isInlined(uri: Uri): Boolean = uri.scheme ==
MemScheme
-
- protected[database] def digest(bytes:
[GitHub] rabbah closed issue #3770: Improve attachment inlining logic
rabbah closed issue #3770: Improve attachment inlining logic URL: https://github.com/apache/incubator-openwhisk/issues/3770 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3745: Remove runtime builds
csantanapr commented on issue #3745: Remove runtime builds URL: https://github.com/apache/incubator-openwhisk/pull/3745#issuecomment-398943994 >By the way can we restore the two files I commented on? @rabbah files are restored you get back `wskdev actionproxy` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3745: Remove runtime builds
rabbah commented on a change in pull request #3745: Remove runtime builds URL: https://github.com/apache/incubator-openwhisk/pull/3745#discussion_r196983391 ## File path: actionRuntimes/actionProxy/build.gradle ## @@ -1,19 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -ext.dockerImageName = 'dockerskeleton' Review comment: ok. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on a change in pull request #3745: Remove runtime builds
csantanapr commented on a change in pull request #3745: Remove runtime builds URL: https://github.com/apache/incubator-openwhisk/pull/3745#discussion_r196983168 ## File path: actionRuntimes/actionProxy/build.gradle ## @@ -1,19 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -ext.dockerImageName = 'dockerskeleton' Review comment: actionproxy This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #65: fix issue with travis repo misspelling
csantanapr closed pull request #65: fix issue with travis repo misspelling URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/65 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.travis.yml b/.travis.yml index 4950853..2c6dfd3 100644 --- a/.travis.yml +++ b/.travis.yml @@ -39,12 +39,12 @@ deploy: on: tags: true all_branches: true - repo: apache/openwhisk-incubator-runtime-nodejs + repo: apache/incubator-openwhisk-runtime-nodejs - provider: script script: "./tools/travis/publish.sh openwhisk 6 master && ./tools/travis/publish.sh openwhisk 8 master" on: branch: master - repo: apache/openwhisk-incubator-runtime-nodejs + repo: apache/incubator-openwhisk-runtime-nodejs env: global: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #67: add to travis.yml the runtime repo in the deploy block
csantanapr closed pull request #67: add to travis.yml the runtime repo in the deploy block URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/67 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.travis.yml b/.travis.yml index 60ba8e1..ba4eb4b 100644 --- a/.travis.yml +++ b/.travis.yml @@ -27,10 +27,12 @@ deploy: on: tags: true all_branches: true + repo: apache/incubator-openwhisk-runtime-swift - provider: script script: "./tools/travis/publish.sh openwhisk 4.1 master" on: branch: master + repo: apache/incubator-openwhisk-runtime-swift env: global: - secure: YqQG7kchpqrqYNCBHmoXs5QJFJQmtuy30WYQnQtudVuqZ1/PqsTJXy6+kNxQ88z5NoU4XZKClB61V8ZVHqGsbQd3lAsTy11QKxf+s4kfsGBuoRlow4eQmnUnnaF3E6KVV2nJ4oXro7RQhP3WwLjpsThrMk322B1ZtlSRALR9hK5wCit8Q1ifSJqmKLwuoNSNQzd7onlDF19Q9pyKkgVu9wLKU5epo76wuFkRfkbr1mB3fF2le2WRNXer2N8rL8McHousFPYA03IIdo6zdX27yGmqSW3teCiVYieGrqtaGhH0WCE7dcmoQ/gs7IBqn1K80wJSR1lbkKDiWzmb73FWScKuXmRn5c4HCq/wPya2I5JNUGyPg5YI0HyMDxGTJ/OdXv2Aizyh3hyNMFjtbjK4N6gz6kFAn8Uo6wFs441Bq+S3+ipLAQ41KIQ7E4/Di6ERSG8KKWKy+LlnA5Qy60CQHRIyJCg3+aqfTe7LUrI/mCclRelnLzUPApFOBI1zPB44+lJVRFfcAKhKIen1bdljTwhjP0xkmOS7rJKtEUl3BvIOAeHC9Dgts9LoqhcMjeXexasbgIpm/CEb8yBTSs+1/FG+8r/v0qGEI6+X/HRJaapQ3vsAKI3M+kbHIjrXhJaUlLWc4dk70B7Ee2eh057cPgInZYLXPi0ksNWy8wAtAJE= This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #30: add repo to deploy step, add master tag to docker
csantanapr closed pull request #30: add repo to deploy step, add master tag to docker URL: https://github.com/apache/incubator-openwhisk-runtime-python/pull/30 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.travis.yml b/.travis.yml index 9d363d6..4d92e08 100644 --- a/.travis.yml +++ b/.travis.yml @@ -19,10 +19,12 @@ deploy: on: tags: true all_branches: true + repo: apache/incubator-openwhisk-runtime-python - provider: script script: "./tools/travis/publish.sh openwhisk 2 master && ./tools/travis/publish.sh openwhisk 3 master" on: branch: master + repo: apache/incubator-openwhisk-runtime-python env: global: - secure: Ac7MlWUpsLwmbcjCigDf+vftiXAEJbf78FVm2QCd4IeFqlRiNbQm3bWRXOOW3Zqh4R4o/wSFpFq0qKPrI9WJjOcxD0GxFboq2iGWTegddfDbENV/IBmjurl6NzYY6dUB7GUSmHYy6tdKnxMhjHzZCn2m4OVWltcMtnOV0G+uYvbnre7vXfb67duzJF+mYpJJ7rC0wGh+N50bYvm0BTtPcQMYJibq6sDTY8Lr1b74QGdM/sODre69CbuiwAA7Ed0hajEcMkv8YnwY0De/PL7hthUyCWSD+i1AhtD+3odA64yX/pAbBzfCcqPoI0Nt5ZmAAUKLJ9pAHCc74dlmYzj9wj1z5TS0nLOE2l++vNvgsA3/c+lqrBv6hc9FmSKx4yfNdFCakVLEfdRJw/45ibIRN5dCW5tDdIx8aciBV8c0CyYgSLRvtVuvw5IX7fbwhHOZ8ftTRzCHS0Nd9zs4x3za+1aucWFQEyrkPtXZIiqeuV7yI4S7yYhGeJy/3KmuN7ljDiTElZb/W9W22ryw/UwCyyZBGnvhomAwInS3E51Jv8GuOU9FVliGzGs2yLuVQ1FjIZ25Au5W4TLTor/jE+dxOlH4u25neqsKBxzG4iyJs3AfJnycD8op7JbTG64OqpVvaB8A4N3P416IxGALSFVv2BWSLY4qWBRVKHbZAHn2tTg= This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #58: add to travis.yml the runtime repo in the deploy block
csantanapr closed pull request #58: add to travis.yml the runtime repo in the deploy block URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/58 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.travis.yml b/.travis.yml index 74ceb84..e9fda29 100644 --- a/.travis.yml +++ b/.travis.yml @@ -27,10 +27,12 @@ deploy: on: tags: true all_branches: true + repo: apache/incubator-openwhisk-runtime-java - provider: script script: "./tools/travis/publish.sh openwhisk 8 master" on: branch: master + repo: apache/incubator-openwhisk-runtime-java env: global: - secure: D4kU9O6bs63Myb4jaEgw1O2Kuy6aTAUKEX1qZ0eYMDouLnPOPnZaFWmpISKTrJyz7hJH7yY8Cj7xl5qwsLB6JZZMtqT6yj5J/jkUJjyLKdQH81PrYy22rH99xS2t5A1dsC0A/Bf39R/qNc5tx1wCMVDF4O2rFsUtn+8vE+rn0nXsiPeWhhZagk/Hrq8YbwzDJHOGHfWe1nZIcU8MORzTriX7J2VAF0AcirPandMxff4FgzNLk432DN2GvgZIlNtZGT1DWLtJV/Sp3unD9abXr5xqNDIW+fHrMq8j/JdHC6+PFtZRFrl0Vr6X8c61PkB/ELGF2MyzNgBTnEaJixl1pianr91WK4y0oLUwpSJCz4yoQGVimAAtqMgNXjEyFMcpLClzS5TjMXKaUfi9mBn9GMCwLi3VAuVtMtH2IRW03PxIPyxkbj1j8Nrd0jh408MuMpuzyECgb+E5ffbd+0YD5XUNlTkYLFi4sEh2xpzvjGrNbrTe99zFrHt3e+dbmoahmaCyDRsxD2CDI8b++HyN78z/jO9A7kFc2TAZbWa6Xygkj1nEpnR1y4TB6eqdDo7Y6W20dLjeSSF8rACw3bM3lJh+K4/nv4Nlo6pfblhvs7T53ftst+tHpxJoQy/gDC0TcuyBThrHTeI1j7k4HkQyN+NqezBdFN2ElufjQ74ds2c= This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eweiter opened a new pull request #65: fix issue with travis repo misspelling
eweiter opened a new pull request #65: fix issue with travis repo misspelling URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/65 There was a typo in the repo name in the .travis.yml , the repo 'incubator-openwhisk-runtime-nodejs' was incorrectly entered as 'openwhisk-incubator-runtime-nodejs' This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #3791: Refactor Elasticsearch log store config name
codecov-io edited a comment on issue #3791: Refactor Elasticsearch log store config name URL: https://github.com/apache/incubator-openwhisk/pull/3791#issuecomment-398910253 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3791?src=pr=h1) Report > Merging [#3791](https://codecov.io/gh/apache/incubator-openwhisk/pull/3791?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/071d841bc32f5b4a2712c416752d46488caead22?src=pr=desc) will **not change** coverage. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3791?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3791 +/- ## === Coverage 74.92% 74.92% === Files 132 132 Lines6181 6181 Branches 385 385 === Hits 4631 4631 Misses 1550 1550 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3791?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../containerpool/logging/ElasticSearchLogStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3791/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9sb2dnaW5nL0VsYXN0aWNTZWFyY2hMb2dTdG9yZS5zY2FsYQ==) | `96.15% <ø> (ø)` | :arrow_up: | | [.../scala/src/main/scala/whisk/core/WhiskConfig.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3791/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvV2hpc2tDb25maWcuc2NhbGE=) | `92% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3791?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3791?src=pr=footer). Last update [071d841...ec15373](https://codecov.io/gh/apache/incubator-openwhisk/pull/3791?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3791: Refactor Elasticsearch log store config name
codecov-io commented on issue #3791: Refactor Elasticsearch log store config name URL: https://github.com/apache/incubator-openwhisk/pull/3791#issuecomment-398910253 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3791?src=pr=h1) Report > Merging [#3791](https://codecov.io/gh/apache/incubator-openwhisk/pull/3791?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/071d841bc32f5b4a2712c416752d46488caead22?src=pr=desc) will **not change** coverage. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3791?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3791 +/- ## === Coverage 74.92% 74.92% === Files 132 132 Lines6181 6181 Branches 385 385 === Hits 4631 4631 Misses 1550 1550 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3791?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../containerpool/logging/ElasticSearchLogStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3791/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9sb2dnaW5nL0VsYXN0aWNTZWFyY2hMb2dTdG9yZS5zY2FsYQ==) | `96.15% <ø> (ø)` | :arrow_up: | | [.../scala/src/main/scala/whisk/core/WhiskConfig.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3791/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvV2hpc2tDb25maWcuc2NhbGE=) | `92% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3791?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3791?src=pr=footer). Last update [071d841...ec15373](https://codecov.io/gh/apache/incubator-openwhisk/pull/3791?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3790: Generic plugins for deployment
codecov-io commented on issue #3790: Generic plugins for deployment URL: https://github.com/apache/incubator-openwhisk/pull/3790#issuecomment-398908016 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3790?src=pr=h1) Report > Merging [#3790](https://codecov.io/gh/apache/incubator-openwhisk/pull/3790?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/071d841bc32f5b4a2712c416752d46488caead22?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3790?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3790 +/- ## === Coverage 74.92% 74.92% === Files 132 132 Lines6181 6181 Branches 385 385 === Hits 4631 4631 Misses 1550 1550 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3790?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3790?src=pr=footer). Last update [071d841...25c0dfe](https://codecov.io/gh/apache/incubator-openwhisk/pull/3790?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3745: Remove runtime builds
rabbah commented on issue #3745: Remove runtime builds URL: https://github.com/apache/incubator-openwhisk/pull/3745#issuecomment-398901515 By the way can we restore the two files I commented on? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3745: Remove runtime builds
rabbah commented on issue #3745: Remove runtime builds URL: https://github.com/apache/incubator-openwhisk/pull/3745#issuecomment-398901365 @csantanapr when you merge this you should get co-author credit. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes closed pull request #3786: Fixes EntitlementProvider to use SpiLoader
markusthoemmes closed pull request #3786: Fixes EntitlementProvider to use
SpiLoader
URL: https://github.com/apache/incubator-openwhisk/pull/3786
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core/controller/src/main/scala/whisk/core/entitlement/Entitlement.scala
b/core/controller/src/main/scala/whisk/core/entitlement/Entitlement.scala
index eaf08e9f03..23007f323f 100644
--- a/core/controller/src/main/scala/whisk/core/entitlement/Entitlement.scala
+++ b/core/controller/src/main/scala/whisk/core/entitlement/Entitlement.scala
@@ -28,7 +28,6 @@ import akka.http.scaladsl.model.StatusCodes.TooManyRequests
import whisk.core.entitlement.Privilege.ACTIVATE
import whisk.core.entitlement.Privilege.REJECT
import whisk.common.{Logging, TransactionId, UserEvents}
-import whisk.connector.kafka.KafkaMessagingProvider
import whisk.core.WhiskConfig
import whisk.core.connector.{EventMessage, Metric}
import whisk.core.controller.RejectRequest
@@ -37,6 +36,8 @@ import whisk.core.loadBalancer.{LoadBalancer,
ShardingContainerPoolBalancer}
import whisk.http.ErrorResponse
import whisk.http.Messages
import whisk.http.Messages._
+import whisk.core.connector.MessagingProvider
+import whisk.spi.SpiLoader
package object types {
type Entitlements = TrieMap[(Subject, String), Set[Privilege]]
@@ -143,7 +144,8 @@ protected[core] abstract class EntitlementProvider(
activationThrottleCalculator(config.actionInvokeConcurrentLimit.toInt,
_.limits.concurrentInvocations),
config.actionInvokeSystemOverloadLimit.toInt)
- private val eventProducer = KafkaMessagingProvider.getProducer(this.config)
+ private val messagingProvider = SpiLoader.get[MessagingProvider]
+ private val eventProducer = messagingProvider.getProducer(this.config)
/**
* Grants a subject the right to access a resources.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubee commented on issue #3791: Refactor Elasticsearch log store config name
dubee commented on issue #3791: Refactor Elasticsearch log store config name URL: https://github.com/apache/incubator-openwhisk/pull/3791#issuecomment-398900224 PG5 437 ⏳ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee opened a new pull request #3791: Refactor Elasticsearch log store config name
dubee opened a new pull request #3791: Refactor Elasticsearch log store config name URL: https://github.com/apache/incubator-openwhisk/pull/3791 Renames configuration name for `elasticSearch` to `logStoreElasticSearch` to prevent name clashes when future Elasticsearch configurations are provided. ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [ ] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes closed pull request #3787: Refactoring the load balancer with an overflow queue to reduce activation waiting time
markusthoemmes closed pull request #3787: Refactoring the load balancer with an overflow queue to reduce activation waiting time URL: https://github.com/apache/incubator-openwhisk/pull/3787 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on issue #3777: Avoid converting ByteString to bytes in attachment inlining flow
markusthoemmes commented on issue #3777: Avoid converting ByteString to bytes in attachment inlining flow URL: https://github.com/apache/incubator-openwhisk/pull/3777#issuecomment-398898691 PG3 2416 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #3790: Generic plugins for deployment
dubee commented on issue #3790: Generic plugins for deployment URL: https://github.com/apache/incubator-openwhisk/pull/3790#issuecomment-398898012 PG2 3292 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee opened a new pull request #3790: Make controller environment variable name generic
dubee opened a new pull request #3790: Make controller environment variable name generic URL: https://github.com/apache/incubator-openwhisk/pull/3790 Refactors `controller_env` to a generic name of `env` so that deploy script plugins can be used interchangeably for deploying other components. For instance, these changes allow the same plugin to be used for the controller and invoker if need be. Related to https://github.com/apache/incubator-openwhisk/pull/3785. ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [ ] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Ahmed-elsayed-mahmoud opened a new pull request #3789: Refactoring the load balancer with an overflow queue to reduce activation waiting time
Ahmed-elsayed-mahmoud opened a new pull request #3789: Refactoring the load balancer with an overflow queue to reduce activation waiting time URL: https://github.com/apache/incubator-openwhisk/pull/3789 ## Description ## Related issue and scope - [x] I opened an issue to propose and discuss this change (#3755) ## My changes affect the following components - [ ] API - [x] Controller - [ ] Message Bus (e.g., Kafka) - [x] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [x] Enhancement or new feature (adds new functionality). - [x] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #192: Prepare the release of 0.9.0-incubating rc1
houshengbo closed pull request #192: Prepare the release of 0.9.0-incubating rc1
URL: https://github.com/apache/incubator-openwhisk-release/pull/192
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tools/config.json b/tools/config.json
index 66fbf31..076299d 100644
--- a/tools/config.json
+++ b/tools/config.json
@@ -3,7 +3,7 @@
"stage_url": "https://dist.apache.org/repos/dist/dev/incubator/openwhisk;,
"release_url":
"https://dist.apache.org/repos/dist/release/incubator/openwhisk;,
"versioning": {
-"version": "incubator-0.9.0",
+"version": "0.9.0-incubating",
"pre_release_version": "rc1"
},
"RepoList": [
@@ -59,17 +59,17 @@
"branch": "master"
},
"openwhisk_runtime_nodejs": {
-"hash": "f87af49",
+"hash": "557c4bd",
"repository":
"https://github.com/apache/incubator-openwhisk-runtime-nodejs.git;,
"branch": "master"
},
"openwhisk_runtime_swift": {
-"hash": "f476907",
+"hash": "06c4972",
"repository":
"https://github.com/apache/incubator-openwhisk-runtime-swift.git;,
"branch": "master"
},
"openwhisk_runtime_php": {
-"hash": "86c0a91",
+"hash": "b0834a5",
"repository":
"https://github.com/apache/incubator-openwhisk-runtime-php.git;,
"branch": "master"
},
@@ -84,7 +84,7 @@
"branch": "master"
},
"openwhisk_runtime_python": {
-"hash": "36254cb",
+"hash": "a2098d9",
"repository":
"https://github.com/apache/incubator-openwhisk-runtime-python.git;,
"branch": "master"
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] houshengbo opened a new pull request #192: Prepare the release of 0.9.0-incubating rc1
houshengbo opened a new pull request #192: Prepare the release of 0.9.0-incubating rc1 URL: https://github.com/apache/incubator-openwhisk-release/pull/192 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3745: Remove runtime builds
csantanapr commented on issue #3745: Remove runtime builds URL: https://github.com/apache/incubator-openwhisk/pull/3745#issuecomment-398892117 PG1 3043 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nerdguru commented on issue #229: Upon helm execution "an error occurred forwarding 39967 -> 44134"
nerdguru commented on issue #229: Upon helm execution "an error occurred forwarding 39967 -> 44134" URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/229#issuecomment-398887555 Hi David, Thanks so much for the quick reply! Certainly understandable on the `cd`. Carlos warned me this was early stages but like I said, I love the direction here and thought I'd try it out. As instructed, here's my output: ``` $ kubectl get pods -n kube-system NAMEREADY STATUSRESTARTS AGE etcd-minikube 1/1 Running 1 16d kube-addon-manager-minikube 1/1 Running 1 16d kube-apiserver-minikube 1/1 Running 1 16d kube-controller-manager-minikube1/1 Running 1 16d kube-dns-86f4d74b45-58wqj 3/3 Running 2075 16d kube-proxy-lsrx41/1 Running 1 16d kube-scheduler-minikube 1/1 Running 1 16d kubernetes-dashboard-5498ccf677-mqvn9 1/1 Running 2 16d storage-provisioner 1/1 Running 2 16d tiller-deploy-f9b8476d-zkwfk1/1 Running 0 6h ``` The helm docs you provided were easy to find, actually. They're linked off the main Readme.md and I performed the permissions command on Step 5 there prior to trying the `helm install` that gave me troubles. If you'd like to get on a Webex or something on Thursday to make this easier to diagnose in real time, feel free to contact me at peter...@cisco.com with some times that work. My guess would be there's some versioning incompatibility or a missed step here somewhere. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #60: update nodejs 6 & 8 to latest security patch
csantanapr closed pull request #60: update nodejs 6 & 8 to latest security patch URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/60 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/core/nodejs6Action/CHANGELOG.md b/core/nodejs6Action/CHANGELOG.md index c5e7c3c..279d777 100644 --- a/core/nodejs6Action/CHANGELOG.md +++ b/core/nodejs6Action/CHANGELOG.md @@ -19,6 +19,11 @@ # NodeJS 6 OpenWhisk Runtime Container +## 1.9.2 +Change: Update Node.js + +Node.js version = 6.14.3 + ## 1.9.1 Change: Update Node.js diff --git a/core/nodejs6Action/Dockerfile b/core/nodejs6Action/Dockerfile index b38..c725e60 100644 --- a/core/nodejs6Action/Dockerfile +++ b/core/nodejs6Action/Dockerfile @@ -18,7 +18,7 @@ FROM nodejsactionbase # based on https://github.com/nodejs/docker-node -ENV NODE_VERSION 6.14.2 +ENV NODE_VERSION 6.14.3 RUN curl -SLO "https://nodejs.org/dist/v$NODE_VERSION/node-v$NODE_VERSION-linux-x64.tar.gz; \ && tar -xzf "node-v$NODE_VERSION-linux-x64.tar.gz" -C /usr/local --strip-components=1 \ && rm "node-v$NODE_VERSION-linux-x64.tar.gz" diff --git a/core/nodejs8Action/CHANGELOG.md b/core/nodejs8Action/CHANGELOG.md index f8c32ce..8533ef1 100644 --- a/core/nodejs8Action/CHANGELOG.md +++ b/core/nodejs8Action/CHANGELOG.md @@ -19,6 +19,11 @@ # NodeJS 8 OpenWhisk Runtime Container +## 1.6.2 +Change: Update Node.js + +Node.js version = 8.11.3 + ## 1.6.1 Change: Update Node.js diff --git a/core/nodejs8Action/Dockerfile b/core/nodejs8Action/Dockerfile index 8ee5d30..3f56b96 100644 --- a/core/nodejs8Action/Dockerfile +++ b/core/nodejs8Action/Dockerfile @@ -15,7 +15,7 @@ # limitations under the License. # -FROM node:8.11.2 +FROM node:8.11.3 RUN apt-get update && apt-get install -y \ imagemagick \ unzip \ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #50: update travis to push "master" tag to Docker on "master" branch merges
csantanapr closed pull request #50: update travis to push "master" tag to
Docker on "master" branch merges
URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/50
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index 06dfd7d..60ba8e1 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -5,9 +5,9 @@ sudo: required
group: deprecated-2017Q3
language: scala
scala:
-- 2.11.8
+ - 2.11.8
services:
-- docker
+ - docker
notifications:
email: false
@@ -17,16 +17,20 @@ notifications:
secure:
"hS4q3WH3dnXCZAJ/vH9SNQIMnu/AOfdmvSkOhFGgUQE8gUyxdCSwJwPTzOYrDaykXO9GKa5mnYiCarhpQ3TUuHa5X6Ei2M2cYveNED0fwVPahObUqvIW2RmsdXllR0Wrca4JaWsZOsdOcFYKaqOPUFTHL5VZvm01voHp0WerbtB45HxzmDKBDUIDbWe8i8rKFza+hEJqFUmep0Psr2YEmocWnN69GkAQ9Bzew7iFVjicXIh8I2L2sy1dgt0lXESvH51+HT6nfGTm61kjUThEJZ8Qo217rjNLYcoxgHtPMrq4EezfM0l1U2USidu0yyFKHUY4JXH6sfxLw/Rp4Wiphgj5scHiQZ7xbDnwNmwYSmfP6vQ3JwZ5oyckcCjnSryqaD56pUkZjvmxi+OfHTJDN9FrE0kwshWcYBPCww8Uo2nlwrzNpfkxp3bV07iEYAXUIRbFj5gkpzdrp/ZhGuWzCYwRGcpqg8B1sR1+PiBIL3pm//sF0r9jWqKIPRkdlClvTZ20g1ERCzKGPDTgvjskUD0AV8rf6Jp8BIOSTc5VEIDXqIfptdrzMDKOJd2pBRkMEQVwlax1jcpMgFb22sNWqMXNaUn+39U7ORNdmQO20/76ziHr20tktBRymifASBCjrOMy7BFIlbOnkxYfwI6zUruHtTtBBsvr8NcEvl8mHQU="
before_install:
-- "./tools/travis/setup.sh"
+ - "./tools/travis/setup.sh"
install: true
script:
-- "./tools/travis/build.sh && ./tools/travis/deploy.sh &&
./tools/travis/test.sh"
+ - "./tools/travis/build.sh && ./tools/travis/deploy.sh &&
./tools/travis/test.sh"
deploy:
-- provider: script
- script: "./tools/travis/publish.sh openwhisk ${TRAVIS_TAG%@*}
${TRAVIS_TAG##*@}"
- on:
-tags: true
-all_branches: true
+ - provider: script
+script: "./tools/travis/publish.sh openwhisk ${TRAVIS_TAG%@*}
${TRAVIS_TAG##*@}"
+on:
+ tags: true
+ all_branches: true
+ - provider: script
+script: "./tools/travis/publish.sh openwhisk 4.1 master"
+on:
+ branch: master
env:
global:
- secure:
YqQG7kchpqrqYNCBHmoXs5QJFJQmtuy30WYQnQtudVuqZ1/PqsTJXy6+kNxQ88z5NoU4XZKClB61V8ZVHqGsbQd3lAsTy11QKxf+s4kfsGBuoRlow4eQmnUnnaF3E6KVV2nJ4oXro7RQhP3WwLjpsThrMk322B1ZtlSRALR9hK5wCit8Q1ifSJqmKLwuoNSNQzd7onlDF19Q9pyKkgVu9wLKU5epo76wuFkRfkbr1mB3fF2le2WRNXer2N8rL8McHousFPYA03IIdo6zdX27yGmqSW3teCiVYieGrqtaGhH0WCE7dcmoQ/gs7IBqn1K80wJSR1lbkKDiWzmb73FWScKuXmRn5c4HCq/wPya2I5JNUGyPg5YI0HyMDxGTJ/OdXv2Aizyh3hyNMFjtbjK4N6gz6kFAn8Uo6wFs441Bq+S3+ipLAQ41KIQ7E4/Di6ERSG8KKWKy+LlnA5Qy60CQHRIyJCg3+aqfTe7LUrI/mCclRelnLzUPApFOBI1zPB44+lJVRFfcAKhKIen1bdljTwhjP0xkmOS7rJKtEUl3BvIOAeHC9Dgts9LoqhcMjeXexasbgIpm/CEb8yBTSs+1/FG+8r/v0qGEI6+X/HRJaapQ3vsAKI3M+kbHIjrXhJaUlLWc4dk70B7Ee2eh057cPgInZYLXPi0ksNWy8wAtAJE=
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr closed pull request #19: update travis to push "master" tag to Docker on "master" branch merges
csantanapr closed pull request #19: update travis to push "master" tag to
Docker on "master" branch merges
URL: https://github.com/apache/incubator-openwhisk-runtime-python/pull/19
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index 1a45230..9d363d6 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -7,18 +7,22 @@ language: scala
scala:
- 2.11.11
services:
-- docker
+ - docker
before_install:
-- "./tools/travis/setup.sh"
+ - "./tools/travis/setup.sh"
install: true
script:
-- "./tools/travis/build.sh && ./tools/travis/deploy.sh &&
./tools/travis/test.sh"
+ - "./tools/travis/build.sh && ./tools/travis/deploy.sh &&
./tools/travis/test.sh"
deploy:
-- provider: script
- script: "./tools/travis/publish.sh openwhisk ${TRAVIS_TAG%@*}
${TRAVIS_TAG##*@}"
- on:
-tags: true
-all_branches: true
+ - provider: script
+script: "./tools/travis/publish.sh openwhisk ${TRAVIS_TAG%@*}
${TRAVIS_TAG##*@}"
+on:
+ tags: true
+ all_branches: true
+ - provider: script
+script: "./tools/travis/publish.sh openwhisk 2 master &&
./tools/travis/publish.sh openwhisk 3 master"
+on:
+ branch: master
env:
global:
- secure:
Ac7MlWUpsLwmbcjCigDf+vftiXAEJbf78FVm2QCd4IeFqlRiNbQm3bWRXOOW3Zqh4R4o/wSFpFq0qKPrI9WJjOcxD0GxFboq2iGWTegddfDbENV/IBmjurl6NzYY6dUB7GUSmHYy6tdKnxMhjHzZCn2m4OVWltcMtnOV0G+uYvbnre7vXfb67duzJF+mYpJJ7rC0wGh+N50bYvm0BTtPcQMYJibq6sDTY8Lr1b74QGdM/sODre69CbuiwAA7Ed0hajEcMkv8YnwY0De/PL7hthUyCWSD+i1AhtD+3odA64yX/pAbBzfCcqPoI0Nt5ZmAAUKLJ9pAHCc74dlmYzj9wj1z5TS0nLOE2l++vNvgsA3/c+lqrBv6hc9FmSKx4yfNdFCakVLEfdRJw/45ibIRN5dCW5tDdIx8aciBV8c0CyYgSLRvtVuvw5IX7fbwhHOZ8ftTRzCHS0Nd9zs4x3za+1aucWFQEyrkPtXZIiqeuV7yI4S7yYhGeJy/3KmuN7ljDiTElZb/W9W22ryw/UwCyyZBGnvhomAwInS3E51Jv8GuOU9FVliGzGs2yLuVQ1FjIZ25Au5W4TLTor/jE+dxOlH4u25neqsKBxzG4iyJs3AfJnycD8op7JbTG64OqpVvaB8A4N3P416IxGALSFVv2BWSLY4qWBRVKHbZAHn2tTg=
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dgrove-oss closed pull request #32: Fix travis publish 72
dgrove-oss closed pull request #32: Fix travis publish 72
URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/32
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index aef492e..9e2ac3e 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -31,6 +31,11 @@ deploy:
on:
branch: master
repo: apache/incubator-openwhisk-runtime-php
+ - provider: script
+script: "./tools/travis/publish.sh openwhisk 7.2 master"
+on:
+ branch: master
+ repo: apache/incubator-openwhisk-runtime-php
env:
global:
- secure:
AJZRyRO/ZkStfywAZVN8bk1YmQLHOTD37QdjBsw77CdqnW9Y+a7V3+wZD3W+obQrEhNR9spkKlMh+biE2HFoRwr/AZ3Pl0frzhlyzZXaLUgJMK7wfQzuFVVgjODs4ld2PrJRv5LibFwco9cosDYHe9xlqQ+/Yg/QaWZPK0rBS1UFBxHh1cOcIJ0N80vDXgZbqmH9nuE7W5GvNGzDg9p16w+u48a6UF7UVzf+RU/uR13q7LrAq/FD7dtdiHpamIw4MiGWhW/GZQrwZpzovfGFr365uEVWu+ssQJld+sbeVoN9ED6kOrfYTFg+l7+8cvjhkZ9LUWELK/zVFCu4wYmuhk6utUreBD5rzsfVQmt0Ups7ANIqVS0874CW6WdxO+wPx5Me5k3azXbLgk6mPt4hL0+nlUZ1ycP2rEN/RnL2r8UJAN3vdvL1nXrTTulwNLwS8U3Lc+4yEV+YHQR9c9pYdw3VPx1vNVjEQ34djeoiVxROueBDroZfP3Ft5IazQx4sGPHWfFS1yH5JD58S7YYlz8QEope+Cby1Sj4MUJIjqlT9UgQXq1UydzAWmQPcn81scfITTAWzKHvIXxKrffiVPwkMG67uaUiobd9tDYr+CWpuKXckOSuOi0CwRuGJKyc7lGQvW2zVg7uC56bA9LMD91HYCsRUbNuOox9TXVLjGtM=
diff --git a/tools/travis/publish.sh b/tools/travis/publish.sh
index 1166a51..dfd5ab3 100755
--- a/tools/travis/publish.sh
+++ b/tools/travis/publish.sh
@@ -30,19 +30,13 @@ IMAGE_PREFIX=$1
RUNTIME_VERSION=$2
IMAGE_TAG=$3
-if [ ${RUNTIME_VERSION} == "7" ]; then
- RUNTIME="php7Action"
-elif [ ${RUNTIME_VERSION} == "7.1" ]; then
- RUNTIME="php7.1Action"
-fi
-
if [[ ! -z ${DOCKER_USER} ]] && [[ ! -z ${DOCKER_PASSWORD} ]]; then
docker login -u "${DOCKER_USER}" -p "${DOCKER_PASSWORD}"
fi
-if [[ ! -z ${RUNTIME} ]]; then
+if [[ ! -z ${RUNTIME_VERSION} ]]; then
TERM=dumb ./gradlew \
-:core:${RUNTIME}:distDocker \
+:core:php${RUNTIME_VERSION}Action:distDocker \
-PdockerRegistry=docker.io \
-PdockerImagePrefix=${IMAGE_PREFIX} \
-PdockerImageTag=${IMAGE_TAG}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dgrove-oss commented on issue #229: Upon helm execution "an error occurred forwarding 39967 -> 44134"
dgrove-oss commented on issue #229: Upon helm execution "an error occurred forwarding 39967 -> 44134" URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/229#issuecomment-398868631 Thanks for trying it out and the suggested improvements to the docs. I will add the `cd` command (missed that when I moved the instructions from helm/README.md to the top-level directory). Check to see if `tiller-deploy` is running in your minikube cluster via `kubectl get pods -n kube-system` When I restructured the READMEs, I may have made it to easy to overlook the commands you need to use configure helm/tiller by moving them into `docs/helm.md` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on a change in pull request #41: remove use of state in nodejs app
csantanapr commented on a change in pull request #41: remove use of state in
nodejs app
URL:
https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/41#discussion_r196913665
##
File path:
tests/src/test/scala/runtime/actionContainers/NodeJsActionContainerTests.scala
##
@@ -547,4 +547,42 @@ abstract class NodeJsActionContainerTests extends
BasicActionRunnerTests with Ws
e shouldBe empty
})
}
+
+ it should "allow running activations concurrently" in {
+val (out, err) = withNodeJsContainer { c =>
+ //this action will create a log entry, and only complete once all 3
activations have arrived and emitted logs
+ val code =
+s"""
+ | function main(args) {
+ | console.log("interleave me");
+ | return new Promise(function(resolve, reject) {
+ | setTimeout(function() {
+ | resolve({ args: args});
+ | }, 1);
+ |});
+ | }
+""".stripMargin
+
+ c.init(initPayload(code))._1 should be(200)
+
+ val payloads = Seq(JsObject("arg1" -> JsString("value1")),
JsObject("arg2" -> JsString("value2")))
+
+ val responses = c.runMultiple(payloads.map {
+runPayload(_)
+ })
+ payloads.foreach { a =>
+//responses should contain(200, Some(JsObject("args" -> a)))
Review comment:
Why is this commented?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr commented on a change in pull request #41: remove use of state in nodejs app
csantanapr commented on a change in pull request #41: remove use of state in
nodejs app
URL:
https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/41#discussion_r196913905
##
File path:
tests/src/test/scala/runtime/actionContainers/NodeJsActionContainerTests.scala
##
@@ -547,4 +547,42 @@ abstract class NodeJsActionContainerTests extends
BasicActionRunnerTests with Ws
e shouldBe empty
})
}
+
+ it should "allow running activations concurrently" in {
+val (out, err) = withNodeJsContainer { c =>
+ //this action will create a log entry, and only complete once all 3
activations have arrived and emitted logs
Review comment:
Why you mentioned 3 activations? I only see 2 below
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr commented on a change in pull request #41: remove use of state in nodejs app
csantanapr commented on a change in pull request #41: remove use of state in
nodejs app
URL:
https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/41#discussion_r196914380
##
File path:
tests/src/test/scala/runtime/actionContainers/NodeJsActionContainerTests.scala
##
@@ -547,4 +547,42 @@ abstract class NodeJsActionContainerTests extends
BasicActionRunnerTests with Ws
e shouldBe empty
})
}
+
+ it should "allow running activations concurrently" in {
+val (out, err) = withNodeJsContainer { c =>
+ //this action will create a log entry, and only complete once all 3
activations have arrived and emitted logs
+ val code =
+s"""
+ | function main(args) {
+ | console.log("interleave me");
+ | return new Promise(function(resolve, reject) {
+ | setTimeout(function() {
+ | resolve({ args: args});
+ | }, 1);
+ |});
+ | }
+""".stripMargin
+
+ c.init(initPayload(code))._1 should be(200)
+
+ val payloads = Seq(JsObject("arg1" -> JsString("value1")),
JsObject("arg2" -> JsString("value2")))
+
+ val responses = c.runMultiple(payloads.map {
+runPayload(_)
+ })
+ payloads.foreach { a =>
+//responses should contain(200, Some(JsObject("args" -> a)))
+ }
+}
+
+checkStreams(out, err, {
+ case (o, e) =>
+o.replaceAll("\n", "") shouldBe "interleave meinterleave me"
Review comment:
I don't see how are you testing that actions are actually running at the
same time, and also not in different containers.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dgrove-oss commented on issue #230: Zookeeper fails to start after restarting docker and/or minikube
dgrove-oss commented on issue #230: Zookeeper fails to start after restarting docker and/or minikube URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/230#issuecomment-398867241 referencing Slack discussion. this is caused by a bug in zookeeper.yaml mounting the zk-data volume twice. https://openwhisk-team.slack.com/archives/C3TPCAQG1/p1529505003000304?thread_ts=1529455515.000338=C3TPCAQG1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #61: WIP: Test Travis
csantanapr closed pull request #61: WIP: Test Travis URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/61 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/NOTICE.txt b/NOTICE.txt index ad5fa16..d714eea 100644 --- a/NOTICE.txt +++ b/NOTICE.txt @@ -3,3 +3,4 @@ Copyright 2016-2018 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). + This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #62: add to travis.yml the runtime repo to the deploy block
csantanapr closed pull request #62: add to travis.yml the runtime repo to the deploy block URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/62 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.travis.yml b/.travis.yml index 67dbb53..4950853 100644 --- a/.travis.yml +++ b/.travis.yml @@ -39,10 +39,12 @@ deploy: on: tags: true all_branches: true + repo: apache/openwhisk-incubator-runtime-nodejs - provider: script script: "./tools/travis/publish.sh openwhisk 6 master && ./tools/travis/publish.sh openwhisk 8 master" on: branch: master + repo: apache/openwhisk-incubator-runtime-nodejs env: global: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #190: Prepare the incubator-0.9.0 rc1 artifacts
houshengbo closed pull request #190: Prepare the incubator-0.9.0 rc1 artifacts
URL: https://github.com/apache/incubator-openwhisk-release/pull/190
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tools/config.json b/tools/config.json
index 961c089..66fbf31 100644
--- a/tools/config.json
+++ b/tools/config.json
@@ -3,7 +3,7 @@
"stage_url": "https://dist.apache.org/repos/dist/dev/incubator/openwhisk;,
"release_url":
"https://dist.apache.org/repos/dist/release/incubator/openwhisk;,
"versioning": {
-"version": "incubator-1.0.0",
+"version": "incubator-0.9.0",
"pre_release_version": "rc1"
},
"RepoList": [
@@ -22,18 +22,18 @@
"openwhisk-runtime-python"
],
"openwhisk": {
-"hash": "1d79fa3",
+"hash": "071d841",
"repository": "https://github.com/apache/incubator-openwhisk.git;,
"branch": "master"
},
"openwhisk_wskdeploy": {
-"hash": "18a9898",
+"hash": "7620ef7",
"repository":
"https://github.com/apache/incubator-openwhisk-wskdeploy.git;,
"branch": "master",
"binaries": "no"
},
"openwhisk_cli": {
-"hash": "a4ca79a",
+"hash": "461f94f",
"repository": "https://github.com/apache/incubator-openwhisk-cli.git;,
"branch": "master",
"binaries": "no"
@@ -49,42 +49,42 @@
"branch": "master"
},
"openwhisk_deploy_kube": {
-"hash": "9811fc7",
+"hash": "cb9c3f5",
"repository":
"https://github.com/apache/incubator-openwhisk-deploy-kube.git;,
"branch": "master"
},
"openwhisk_apigateway": {
-"hash": "8fbfb97",
+"hash": "2b87366",
"repository":
"https://github.com/apache/incubator-openwhisk-apigateway.git;,
"branch": "master"
},
"openwhisk_runtime_nodejs": {
-"hash": "b675151",
+"hash": "f87af49",
"repository":
"https://github.com/apache/incubator-openwhisk-runtime-nodejs.git;,
"branch": "master"
},
"openwhisk_runtime_swift": {
-"hash": "ffb8323",
+"hash": "f476907",
"repository":
"https://github.com/apache/incubator-openwhisk-runtime-swift.git;,
"branch": "master"
},
"openwhisk_runtime_php": {
-"hash": "22c59f2",
+"hash": "86c0a91",
"repository":
"https://github.com/apache/incubator-openwhisk-runtime-php.git;,
"branch": "master"
},
"openwhisk_runtime_java": {
-"hash": "77018ab",
+"hash": "b20f90e",
"repository":
"https://github.com/apache/incubator-openwhisk-runtime-java.git;,
"branch": "master"
},
"openwhisk_runtime_docker": {
-"hash": "135b94a",
+"hash": "650842a",
"repository":
"https://github.com/apache/incubator-openwhisk-runtime-docker.git;,
"branch": "master"
},
"openwhisk_runtime_python": {
-"hash": "c44d706",
+"hash": "36254cb",
"repository":
"https://github.com/apache/incubator-openwhisk-runtime-python.git;,
"branch": "master"
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] eweiter opened a new pull request #30: add repo to deploy step, add master tag to docker
eweiter opened a new pull request #30: add repo to deploy step, add master tag to docker URL: https://github.com/apache/incubator-openwhisk-runtime-python/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #32: Fix travis publish 72
csantanapr opened a new pull request #32: Fix travis publish 72 URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/32 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3777: Avoid converting ByteString to bytes in attachment inlining flow
markusthoemmes commented on a change in pull request #3777: Avoid converting
ByteString to bytes in attachment inlining flow
URL:
https://github.com/apache/incubator-openwhisk/pull/3777#discussion_r196890685
##
File path:
common/scala/src/main/scala/whisk/core/database/AttachmentSupport.scala
##
@@ -0,0 +1,190 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.database
+
+import java.util.Base64
+
+import akka.NotUsed
+import akka.http.scaladsl.model.{ContentType, Uri}
+import akka.stream.Materializer
+import akka.stream.scaladsl.{Sink, Source}
+import akka.util.ByteString
+import spray.json.DefaultJsonProtocol
+import whisk.common.TransactionId
+import whisk.core.database.AttachmentSupport.MemScheme
+import whisk.core.entity.Attachments.Attached
+import whisk.core.entity.{ByteSize, DocId, DocInfo, UUID}
+
+import scala.concurrent.{ExecutionContext, Future}
+
+object AttachmentSupport {
+
+ /**
+ * Scheme name for attachments which are inlined
+ */
+ val MemScheme: String = "mem"
+}
+
+case class InliningConfig(maxInlineSize: ByteSize)
+
+/**
+ * Provides support for inlining small attachments. Inlined attachment
contents are encoded as part of attachment
+ * name itself.
+ */
+trait AttachmentSupport[DocumentAbstraction <: DocumentSerializer] extends
DefaultJsonProtocol {
+
+ /** Materializer required for stream processing */
+ protected[core] implicit val materializer: Materializer
+
+ protected def executionContext: ExecutionContext
+
+ /**
+ * Attachment scheme name to use for non inlined attachments
+ */
+ protected def attachmentScheme: String
+
+ protected def inliningConfig: InliningConfig
+
+ /**
+ * Attachments having size less than this would be inlined
+ */
+ def maxInlineSize: ByteSize = inliningConfig.maxInlineSize
+
+ /**
+ * See {{ ArtifactStore#put }}
+ */
+ protected[database] def put(d: DocumentAbstraction)(implicit transid:
TransactionId): Future[DocInfo]
+
+ /**
+ * Given a ByteString source it determines if the source can be inlined or
not by returning an
+ * Either - Left(byteString) containing all the bytes from the source or
Right(Source[ByteString, _])
+ * if the source is large
+ */
+ protected[database] def inlineOrAttach(
+docStream: Source[ByteString, _],
+previousPrefix: ByteString = ByteString.empty): Future[Either[ByteString,
Source[ByteString, _]]] = {
+implicit val ec = executionContext
+docStream.prefixAndTail(1).runWith(Sink.head).flatMap {
+ case (Nil, _) =>
+Future.successful(Left(previousPrefix))
+ case (Seq(prefix), tail) =>
+val completePrefix = previousPrefix ++ prefix
+if (completePrefix.size < maxInlineSize.toBytes) {
+ inlineOrAttach(tail, completePrefix)
+} else {
+ Future.successful(Right(tail.prepend(Source.single(completePrefix
+}
+}
+ }
+
+ /**
+ * Constructs a URI for the attachment
+ *
+ * @param bytesOrSource either byteString or byteString source
+ * @param path function to generate the attachment name for non inlined case
+ * @return constructed uri. In case of inlined attachment the uri contains
base64 encoded inlined attachment content
+ */
+ protected[database] def uriOf(bytesOrSource: Either[ByteString,
Source[ByteString, _]], path: => String): Uri = {
+bytesOrSource match {
+ case Left(bytes) => Uri.from(scheme = MemScheme, path = encode(bytes))
+ case Right(_)=> Uri.from(scheme = attachmentScheme, path = path)
+}
+ }
+
+ /**
+ * Constructs a source from inlined attachment contents
+ */
+ protected[database] def memorySource(uri: Uri): Source[ByteString, NotUsed]
= {
+require(uri.scheme == MemScheme, s"URI $uri scheme is not $MemScheme")
+Source.single(ByteString(decode(uri)))
+ }
+
+ protected[database] def isInlined(uri: Uri): Boolean = uri.scheme ==
MemScheme
Review comment:
I think this method is now unused? Delete?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
[GitHub] markusthoemmes commented on a change in pull request #3777: Avoid converting ByteString to bytes in attachment inlining flow
markusthoemmes commented on a change in pull request #3777: Avoid converting
ByteString to bytes in attachment inlining flow
URL:
https://github.com/apache/incubator-openwhisk/pull/3777#discussion_r196890685
##
File path:
common/scala/src/main/scala/whisk/core/database/AttachmentSupport.scala
##
@@ -0,0 +1,190 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.database
+
+import java.util.Base64
+
+import akka.NotUsed
+import akka.http.scaladsl.model.{ContentType, Uri}
+import akka.stream.Materializer
+import akka.stream.scaladsl.{Sink, Source}
+import akka.util.ByteString
+import spray.json.DefaultJsonProtocol
+import whisk.common.TransactionId
+import whisk.core.database.AttachmentSupport.MemScheme
+import whisk.core.entity.Attachments.Attached
+import whisk.core.entity.{ByteSize, DocId, DocInfo, UUID}
+
+import scala.concurrent.{ExecutionContext, Future}
+
+object AttachmentSupport {
+
+ /**
+ * Scheme name for attachments which are inlined
+ */
+ val MemScheme: String = "mem"
+}
+
+case class InliningConfig(maxInlineSize: ByteSize)
+
+/**
+ * Provides support for inlining small attachments. Inlined attachment
contents are encoded as part of attachment
+ * name itself.
+ */
+trait AttachmentSupport[DocumentAbstraction <: DocumentSerializer] extends
DefaultJsonProtocol {
+
+ /** Materializer required for stream processing */
+ protected[core] implicit val materializer: Materializer
+
+ protected def executionContext: ExecutionContext
+
+ /**
+ * Attachment scheme name to use for non inlined attachments
+ */
+ protected def attachmentScheme: String
+
+ protected def inliningConfig: InliningConfig
+
+ /**
+ * Attachments having size less than this would be inlined
+ */
+ def maxInlineSize: ByteSize = inliningConfig.maxInlineSize
+
+ /**
+ * See {{ ArtifactStore#put }}
+ */
+ protected[database] def put(d: DocumentAbstraction)(implicit transid:
TransactionId): Future[DocInfo]
+
+ /**
+ * Given a ByteString source it determines if the source can be inlined or
not by returning an
+ * Either - Left(byteString) containing all the bytes from the source or
Right(Source[ByteString, _])
+ * if the source is large
+ */
+ protected[database] def inlineOrAttach(
+docStream: Source[ByteString, _],
+previousPrefix: ByteString = ByteString.empty): Future[Either[ByteString,
Source[ByteString, _]]] = {
+implicit val ec = executionContext
+docStream.prefixAndTail(1).runWith(Sink.head).flatMap {
+ case (Nil, _) =>
+Future.successful(Left(previousPrefix))
+ case (Seq(prefix), tail) =>
+val completePrefix = previousPrefix ++ prefix
+if (completePrefix.size < maxInlineSize.toBytes) {
+ inlineOrAttach(tail, completePrefix)
+} else {
+ Future.successful(Right(tail.prepend(Source.single(completePrefix
+}
+}
+ }
+
+ /**
+ * Constructs a URI for the attachment
+ *
+ * @param bytesOrSource either byteString or byteString source
+ * @param path function to generate the attachment name for non inlined case
+ * @return constructed uri. In case of inlined attachment the uri contains
base64 encoded inlined attachment content
+ */
+ protected[database] def uriOf(bytesOrSource: Either[ByteString,
Source[ByteString, _]], path: => String): Uri = {
+bytesOrSource match {
+ case Left(bytes) => Uri.from(scheme = MemScheme, path = encode(bytes))
+ case Right(_)=> Uri.from(scheme = attachmentScheme, path = path)
+}
+ }
+
+ /**
+ * Constructs a source from inlined attachment contents
+ */
+ protected[database] def memorySource(uri: Uri): Source[ByteString, NotUsed]
= {
+require(uri.scheme == MemScheme, s"URI $uri scheme is not $MemScheme")
+Source.single(ByteString(decode(uri)))
+ }
+
+ protected[database] def isInlined(uri: Uri): Boolean = uri.scheme ==
MemScheme
Review comment:
I think this method is now unused? Delete?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
[GitHub] markusthoemmes commented on a change in pull request #3788: Store and pass variant data in AuthKey
markusthoemmes commented on a change in pull request #3788: Store and pass
variant data in AuthKey
URL:
https://github.com/apache/incubator-openwhisk/pull/3788#discussion_r196834704
##
File path: common/scala/src/main/scala/whisk/core/entity/AuthKey.scala
##
@@ -17,24 +17,31 @@
package whisk.core.entity
+import akka.http.scaladsl.model.headers.{BasicHttpCredentials, HttpCredentials}
import spray.json._
import spray.json.DefaultJsonProtocol._
+trait AuthKeyEnv {
+ val authElements: Map[String, String]
+ def toEnvironment = authElements.toJson.asJsObject
+ def getCredentials: HttpCredentials
+}
+
/**
* Authentication key, consisting of a UUID and Secret.
*
- * It is a value type (hence == is .equals, immutable and cannot be assigned
null).
* The constructor is private so that argument requirements are checked and
normalized
* before creating a new instance.
*
* @param k (uuid, key) the uuid and key, assured to be non-null because both
types are values
*/
-protected[core] class AuthKey private (private val k: (UUID, Secret)) extends
AnyVal {
- def uuid: UUID = k._1
- def key: Secret = k._2
- def revoke = new AuthKey(uuid, Secret())
- def compact: String = s"$uuid:$key"
+protected[core] case class AuthKey private (authElements: Map[String, String])
extends AuthKeyEnv {
+ def uuid: UUID = UUID(this.authElements("api_key").split(":")(0))
+ def key: Secret = Secret(this.authElements("api_key").split(":")(1))
+ def revoke = AuthKey(uuid, Secret())
+ def compact: String = this.authElements("api_key")
override def toString: String = uuid.toString
+ override def getCredentials: HttpCredentials =
BasicHttpCredentials(uuid.asString, key.asString)
}
Review comment:
I feel like this class should stay mostly the same as today. In this
implementation, each call to `uuid` would (unsafely) get an element from the
map, split it, and (unsafely) get it's 0 index.
For an AuthKey, we can statically know, that it contains both UUID and
Secret at compile time.
```scala
protected[core] case class AuthKey private (private val k: (UUID, Secret))
extends AuthenticationCredentials {
def uuid: UUID = k._1
def key: Secret = k._2
def revoke = new AuthKey(uuid, Secret())
def compact: String = s"$uuid:$key"
override def toEnvironment = JsObject("api_key" ->
s"${uuid.asString}:${key.asString}".toJson)
override def getCredentials: HttpCredentials =
BasicHttpCredentials(uuid.asString, key.asString)
}
```
Would be the implementation then.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3788: Store and pass variant data in AuthKey
markusthoemmes commented on a change in pull request #3788: Store and pass
variant data in AuthKey
URL:
https://github.com/apache/incubator-openwhisk/pull/3788#discussion_r196834822
##
File path:
core/invoker/src/main/scala/whisk/core/containerpool/ContainerProxy.scala
##
@@ -354,16 +354,19 @@ class ContainerProxy(
.flatMap { initInterval =>
val parameters = job.msg.content getOrElse JsObject()
+val authkey = job.msg.user.authkey.toEnvironment
+
val environment = JsObject(
- "api_key" -> job.msg.user.authkey.compact.toJson,
"namespace" -> job.msg.user.namespace.name.toJson,
"action_name" -> job.msg.action.qualifiedNameWithLeadingSlash.toJson,
"activation_id" -> job.msg.activationId.toString.toJson,
// compute deadline on invoker side avoids discrepancies inside
container
// but potentially under-estimates actual deadline
"deadline" -> (Instant.now.toEpochMilli +
actionTimeout.toMillis).toString.toJson)
-container.run(parameters, environment,
actionTimeout)(job.msg.transid).map {
+logging.info(this, s"***MH env JSON: ${JsObject(authkey.fields ++
environment.fields)}")
Review comment:
Please remove this logline.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3788: Store and pass variant data in AuthKey
markusthoemmes commented on a change in pull request #3788: Store and pass
variant data in AuthKey
URL:
https://github.com/apache/incubator-openwhisk/pull/3788#discussion_r196835596
##
File path:
core/invoker/src/main/scala/whisk/core/containerpool/ContainerProxy.scala
##
@@ -354,16 +354,19 @@ class ContainerProxy(
.flatMap { initInterval =>
val parameters = job.msg.content getOrElse JsObject()
+val authkey = job.msg.user.authkey.toEnvironment
Review comment:
`val authEnvironment = ...`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3788: Store and pass variant data in AuthKey
markusthoemmes commented on a change in pull request #3788: Store and pass
variant data in AuthKey
URL:
https://github.com/apache/incubator-openwhisk/pull/3788#discussion_r196835878
##
File path:
tests/src/test/scala/whisk/core/containerpool/test/ContainerProxyTests.scala
##
@@ -761,7 +761,7 @@ class ContainerProxyTests
override def run(parameters: JsObject, environment: JsObject, timeout:
FiniteDuration)(
implicit transid: TransactionId): Future[(Interval, ActivationResponse)]
= {
runCount += 1
- environment.fields("api_key") shouldBe message.user.authkey.toJson
+ environment.fields("api_key") shouldBe
message.user.authkey.toEnvironment.fields("api_key")
Review comment:
Should this check if `environment` contains all keys + values from
`message.user.authkey.toEnvironment` for completeness?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3788: Store and pass variant data in AuthKey
markusthoemmes commented on a change in pull request #3788: Store and pass
variant data in AuthKey
URL:
https://github.com/apache/incubator-openwhisk/pull/3788#discussion_r196833607
##
File path: common/scala/src/main/scala/whisk/core/entity/AuthKey.scala
##
@@ -17,24 +17,31 @@
package whisk.core.entity
+import akka.http.scaladsl.model.headers.{BasicHttpCredentials, HttpCredentials}
import spray.json._
import spray.json.DefaultJsonProtocol._
+trait AuthKeyEnv {
+ val authElements: Map[String, String]
+ def toEnvironment = authElements.toJson.asJsObject
+ def getCredentials: HttpCredentials
+}
Review comment:
Since `authElements` is used nowhere, what do you think about narrowing this
interface to
```scala
trait AuthenticationCredentials {
def toEnvironment: JsObject
def credentials: HttpCredentials
}
```
Since the interface includes the `getCredentials` bit, I think `AuthKeyEnv`
doesn't transport the meaning of the class. After all this is about the
credentials being passed in.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mhenke1 opened a new pull request #3788: Store and pass variant data in AuthKey
mhenke1 opened a new pull request #3788: Store and pass variant data in AuthKey URL: https://github.com/apache/incubator-openwhisk/pull/3788 This PR allows to store variant data in the Authkey that is part of the use identity and pass this data to the user container via environment variables. ## Description This PR is preparing the introduction of a authentication SPI. One prerequisite for supporting different authorization mechanisms is the ability to pass the information contained in this authorization artifacts down to the user containers (e.g. to call out to other services using these artifacts). This ability is implemented by serializing the information into a JSON structure that is mixed in into environment available to the runtimes. [PG1:3042 succeded] ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [x] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [x] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [x] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sxnguyen opened a new issue #230: Zookeeper fails to start after restarting docker and/or minikube
sxnguyen opened a new issue #230: Zookeeper fails to start after restarting docker and/or minikube URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/230 The following error is thrown after minikube and/or docker is restarted in OW+minikube setup (https://github.com/apache/incubator-openwhisk-deploy-kube/tree/master/kubernetes) == 2018-06-04 17:44:42,769 [myid:] -ERROR [main:ZooKeeperServerMain@66] -Unexpected exception, exiting abnormallyorg.apache.zookeeper.server.persistence.FileTxnSnapLog$SnapDirContentCheckException: Snapshot directory has log files. Check if dataLogDir and dataDir configuration is correct.at org.apache.zookeeper.server.persistence.FileTxnSnapLog.checkSnapDir(FileTxnSnapLog.java:135)at org.apache.zookeeper.server.persistence.FileTxnSnapLog.(FileTxnSnapLog.java:108)at org.apache.zookeeper.server.ZooKeeperServerMain.runFromConfig(ZooKeeperServerMain.java:112)at org.apache.zookeeper.server.ZooKeeperServerMain.initializeAndRun(ZooKeeperServerMain.java:89)at org.apache.zookeeper.server.ZooKeeperServerMain.main(ZooKeeperServerMain.java:55)at org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:119)at org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:81) === This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mcdan commented on issue #3610: Fixes #3608 - Use --user flag to install locally for the current user
mcdan commented on issue #3610: Fixes #3608 - Use --user flag to install locally for the current user URL: https://github.com/apache/incubator-openwhisk/pull/3610#issuecomment-398789006 @rabbah We are setting up a new jenkins so I will get back to this next week, I will verify if we need any more and report back. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] drcariel closed pull request #95: add OS and CPU architecture to user agent header
drcariel closed pull request #95: add OS and CPU architecture to user agent
header
URL: https://github.com/apache/incubator-openwhisk-client-go/pull/95
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/whisk/client.go b/whisk/client.go
index 58a29b76..54e2b481 100644
--- a/whisk/client.go
+++ b/whisk/client.go
@@ -31,6 +31,7 @@ import (
"net/url"
"reflect"
"regexp"
+ "runtime"
"strings"
"time"
)
@@ -148,7 +149,7 @@ func NewClient(httpClient *http.Client, config_input
*Config) (*Client, error) {
}
if len(config.UserAgent) == 0 {
- config.UserAgent = "OpenWhisk-Go-Client"
+ config.UserAgent = "OpenWhisk-Go-Client " + runtime.GOOS + " "
+ runtime.GOARCH
}
c := {
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] drcariel opened a new pull request #95: add OS and CPU architecture to user agent header
drcariel opened a new pull request #95: add OS and CPU architecture to user agent header URL: https://github.com/apache/incubator-openwhisk-client-go/pull/95 companion to https://github.com/apache/incubator-openwhisk-cli/pull/344 @rabbah This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #3785: Refactor invoker roles
dubee commented on issue #3785: Refactor invoker roles URL: https://github.com/apache/incubator-openwhisk/pull/3785#issuecomment-398783187 PG3 2411 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] drcariel opened a new pull request #95: add OS and CPU architecture to user agent header
drcariel opened a new pull request #95: add OS and CPU architecture to user agent header URL: https://github.com/apache/incubator-openwhisk-client-go/pull/95 companion to https://github.com/apache/incubator-openwhisk-cli/pull/344 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nerdguru opened a new issue #229: Upon helm execution "an error occurred forwarding 39967 -> 44134"
nerdguru opened a new issue #229: Upon helm execution "an error occurred forwarding 39967 -> 44134" URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/229 Hi there, 7 days in, I may be the first person not on the development team to try this out and I'm a helm noob, so keep that in mind. I got through the Helm install and the "Initial setup" cleanly for an attempt at putting OpenWhisk on top of a minikube cluster. For the "Customize the Deployment" section, I first verified that nothing was already listening to 31001 (with netstat -no | grep 31001, which returned nothing) and I substituted my local IP address for the example in mycluster.yaml. First minor thing, the instructions don't tell you to cd into the helm directory, so the first time I tried to run "helm install . --namespace=openwhisk --name=owdev -f mycluster.yaml" in my home directory, helm complained that it couldn't find a Chart.yaml. As a helm noob, I assumed it would traverse my folders until it found one, but I guess not. After cd'ing to the helm directory that contains the Chart.yaml and copying the aforementioned mycluster.yaml into that directory, here's what I get: ``` $ helm install . --namespace=openwhisk --name=owdev -f mycluster.yaml E0620 10:37:57.405197 26380 portforward.go:331] an error occurred forwarding 39967 -> 44134: error forwarding port 44134 to pod 1fe0b89e31e42c806fef7c73a5393f4fcf41d76262e64500e7f1d73c44abc871, uid : unable to do port forwarding: socat not found. Error: transport is closing ``` I have no idea where to start troubleshooting that since none of the ports mentioned are in either the Chart.yaml or the mycluster.yaml. I had a prior OpenWhisk install attempt using the old instructions on this same minikube cluster, but removed all the pods/services/deployments. Not sure if that's impacting what I'm seeing here. Any clues/thoughts? I love the approach you're taking here and look forward to getting it running! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed issue #165: Add OS to User Agent Header
rabbah closed issue #165: Add OS to User Agent Header URL: https://github.com/apache/incubator-openwhisk-cli/issues/165 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed pull request #344: add OS and CPU architecture to user agent header
rabbah closed pull request #344: add OS and CPU architecture to user agent
header
URL: https://github.com/apache/incubator-openwhisk-cli/pull/344
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/commands/commands.go b/commands/commands.go
index 0e5f1158..6a7a070c 100644
--- a/commands/commands.go
+++ b/commands/commands.go
@@ -21,6 +21,7 @@ import (
"errors"
"net/http"
"os"
+ "runtime"
"github.com/apache/incubator-openwhisk-cli/wski18n"
"github.com/apache/incubator-openwhisk-client-go/whisk"
@@ -64,7 +65,7 @@ func SetupClientConfig(cmd *cobra.Command, args []string)
error {
Version: Properties.APIVersion,
Insecure: Flags.Global.Insecure,
Host: Properties.APIHost,
- UserAgent: UserAgent + "/1.0 (" + Properties.CLIVersion
+ ")",
+ UserAgent: UserAgent + "/1.0 (" + Properties.CLIVersion
+ ") " + runtime.GOOS + " " + runtime.GOARCH,
AdditionalHeaders: AdditionalHeaders,
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] drcariel commented on issue #344: add OS and CPU architecture to user agent header
drcariel commented on issue #344: add OS and CPU architecture to user agent header URL: https://github.com/apache/incubator-openwhisk-cli/pull/344#issuecomment-398780310 Updated user agent header looks like so: `"OpenWhisk-CLI/1.0 (2018-06-19T15:36:55.271-0500) darwin amd64"` Should be good to go! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] drcariel commented on issue #2941: Add api gateway test that uses custom package for action
drcariel commented on issue #2941: Add api gateway test that uses custom package for action URL: https://github.com/apache/incubator-openwhisk/pull/2941#issuecomment-398776342 @rabbah I can handle the addition to the cli repo This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #28: Add PHP 7.2.6 runtime
csantanapr closed pull request #28: Add PHP 7.2.6 runtime URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/28 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/README.md b/README.md index 5d66dcc..1833a8e 100644 --- a/README.md +++ b/README.md @@ -22,33 +22,54 @@ [](https://travis-ci.org/apache/incubator-openwhisk-runtime-php) +## PHP versions + +This runtime provides PHP 7.2 and 7.1. + ### Give it a try today To use as a docker action + +PHP 7.2: ``` -wsk action update myAction myAction.php --docker openwhisk/action-php-v7.1:1.0.0 +wsk action update myAction myAction.php --docker openwhisk/action-php-v7.2:latest ``` + +PHP 7.1: +``` +wsk action update myAction myAction.php --docker openwhisk/action-php-v7.1:latest +``` + This works on any deployment of Apache OpenWhisk ### To use on deployment that contains the rutime as a kind To use as a kind action + +PHP 7.2: +``` +wsk action update myAction myAction.php --kind php:7.2 +``` + +PHP 7.1: ``` wsk action update myAction myAction.php --kind php:7.1 ``` ### Local development ``` +./gradlew core:php7.2Action:distDocker ./gradlew core:php7.1Action:distDocker ``` -This will produce the image `whisk/action-php-v7.1` +This will produce the images `whisk/action-php-v7.2` & `whisk/action-php-v7.1` Build and Push image ``` docker login +./gradlew core:php7.2Action:distDocker -PdockerImagePrefix=$prefix-user -PdockerRegistry=docker.io ./gradlew core:php7.1Action:distDocker -PdockerImagePrefix=$prefix-user -PdockerRegistry=docker.io ``` -Deploy OpenWhisk using ansible environment that contains the kind `php:7.1` -Assuming you have OpenWhisk already deploy localy and `OPENWHISK_HOME` pointing to root directory of OpenWhisk core repository. +Deploy OpenWhisk using ansible environment that contains the kinds `php:7.2` & `php:7.1` +Assuming you have OpenWhisk already deploy locally and `OPENWHISK_HOME` pointing to root directory of OpenWhisk core repository. Set `ROOTDIR` to the root directory of this repository. @@ -71,12 +92,16 @@ wskdev fresh -t local-php To use as docker action push to your own dockerhub account ``` +docker tag whisk/php7.2Action $user_prefix/action-php-v7.2 +docker push $user_prefix/action-php-v7.2 +``` +``` docker tag whisk/php7.1Action $user_prefix/action-php-v7.1 docker push $user_prefix/action-php-v7.1 ``` Then create the action using your the image from dockerhub ``` -wsk action update myAction myAction.php --docker $user_prefix/action-php-v7.1 +wsk action update myAction myAction.php --docker $user_prefix/action-php-v7.2 ``` The `$user_prefix` is usually your dockerhub user id. diff --git a/ansible/environments/local/group_vars/all b/ansible/environments/local/group_vars/all index 1b3fe54..936316f 100755 --- a/ansible/environments/local/group_vars/all +++ b/ansible/environments/local/group_vars/all @@ -40,9 +40,15 @@ runtimes_manifest: deprecated: false php: - kind: "php:7.1" - default: true + default: false image: name: "action-php-v7.1" deprecated: false +php: +- kind: "php:7.2" + default: true + image: +name: "action-php-v7.2" + deprecated: false blackboxes: - name: "dockerskeleton" diff --git a/core/php7.2Action/CHANGELOG.md b/core/php7.2Action/CHANGELOG.md new file mode 100644 index 000..702b708 --- /dev/null +++ b/core/php7.2Action/CHANGELOG.md @@ -0,0 +1,38 @@ + + +## 1.0.0 +Initial release + +- Added: PHP: 7.2.6 +- Added: PHP extensions in addition to the standard ones: +- bcmath +- curl +- gd +- intl +- mbstring +- mysqli +- pdo_mysql +- pdo_pgsql +- pdo_sqlite +- soap +- zip +- Added: Composer packages: +- [guzzlehttp/guzzle](https://packagist.org/packages/guzzlehttp/guzzle): 6.3.3 +- [ramsey/uuid](https://packagist.org/packages/ramsey/uuid): 3.7.3 diff --git a/core/php7.2Action/Dockerfile b/core/php7.2Action/Dockerfile new file mode 100644 index 000..fb08b24 --- /dev/null +++ b/core/php7.2Action/Dockerfile @@ -0,0 +1,63 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed
[GitHub] baxtersa commented on issue #313: Fix awk command in init.sh generating resolvers.conf file
baxtersa commented on issue #313: Fix awk command in init.sh generating resolvers.conf file URL: https://github.com/apache/incubator-openwhisk-apigateway/pull/313#issuecomment-398772884 @mrutkows No problem! I submitted an Apache ICLA last week. I think I should be set on that front. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #345: Batch mode in CLI
rabbah commented on issue #345: Batch mode in CLI URL: https://github.com/apache/incubator-openwhisk-cli/issues/345#issuecomment-398771871 +1 We've discussed previously a `--raw` flag to strip any cli decoration but I cannot find the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #3777: Avoid converting ByteString to bytes in attachment inlining flow
codecov-io edited a comment on issue #3777: Avoid converting ByteString to bytes in attachment inlining flow URL: https://github.com/apache/incubator-openwhisk/pull/3777#issuecomment-398009157 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr=h1) Report > Merging [#3777](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/071d841bc32f5b4a2712c416752d46488caead22?src=pr=desc) will **increase** coverage by `0.22%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3777 +/- ## == + Coverage 74.92% 75.15% +0.22% == Files 132 132 Lines6181 6141 -40 Branches 385 374 -11 == - Hits 4631 4615 -16 + Misses 1550 1526 -24 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr=tree) | Coverage Δ | | |---|---|---| | [...isk/core/database/memory/MemoryArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvbWVtb3J5L01lbW9yeUFydGlmYWN0U3RvcmUuc2NhbGE=) | `99.18% <100%> (+2.73%)` | :arrow_up: | | [.../scala/whisk/core/database/AttachmentSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQXR0YWNobWVudFN1cHBvcnQuc2NhbGE=) | `100% <100%> (ø)` | | | [...k/core/database/memory/MemoryAttachmentStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvbWVtb3J5L01lbW9yeUF0dGFjaG1lbnRTdG9yZS5zY2FsYQ==) | `95% <100%> (+0.26%)` | :arrow_up: | | [...n/scala/whisk/core/database/CouchDbRestStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQ291Y2hEYlJlc3RTdG9yZS5zY2FsYQ==) | `73.23% <100%> (+2.45%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr=footer). Last update [071d841...39527be](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jeeteshchel opened a new issue #345: Batch mode in CLI
jeeteshchel opened a new issue #345: Batch mode in CLI URL: https://github.com/apache/incubator-openwhisk-cli/issues/345 Hello, Currently API returns part of response as plain english text and remaining in json. For example below. Can a general batch mode be added to commands so that tools using the CLI can expect valid JSON response.  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #3777: Avoid converting ByteString to bytes in attachment inlining flow
codecov-io edited a comment on issue #3777: Avoid converting ByteString to bytes in attachment inlining flow URL: https://github.com/apache/incubator-openwhisk/pull/3777#issuecomment-398009157 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr=h1) Report > Merging [#3777](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/071d841bc32f5b4a2712c416752d46488caead22?src=pr=desc) will **increase** coverage by `0.22%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3777 +/- ## == + Coverage 74.92% 75.15% +0.22% == Files 132 132 Lines6181 6141 -40 Branches 385 374 -11 == - Hits 4631 4615 -16 + Misses 1550 1526 -24 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr=tree) | Coverage Δ | | |---|---|---| | [...isk/core/database/memory/MemoryArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvbWVtb3J5L01lbW9yeUFydGlmYWN0U3RvcmUuc2NhbGE=) | `99.18% <100%> (+2.73%)` | :arrow_up: | | [...n/scala/whisk/core/database/CouchDbRestStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQ291Y2hEYlJlc3RTdG9yZS5zY2FsYQ==) | `73.23% <100%> (+2.45%)` | :arrow_up: | | [.../scala/whisk/core/database/AttachmentSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQXR0YWNobWVudFN1cHBvcnQuc2NhbGE=) | `100% <100%> (ø)` | | | [...k/core/database/memory/MemoryAttachmentStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvbWVtb3J5L01lbW9yeUF0dGFjaG1lbnRTdG9yZS5zY2FsYQ==) | `95% <100%> (+0.26%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr=footer). Last update [071d841...39527be](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #29: remove the test filter for 7.1
csantanapr closed pull request #29: remove the test filter for 7.1
URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/29
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tools/travis/test.sh b/tools/travis/test.sh
index 28da4fb..05d080e 100755
--- a/tools/travis/test.sh
+++ b/tools/travis/test.sh
@@ -28,7 +28,7 @@ export OPENWHISK_HOME=$WHISKDIR
cd ${ROOTDIR}
TERM=dumb ./gradlew :tests:checkScalafmtAll
-TERM=dumb ./gradlew :tests:test --tests *Php71*Tests
+TERM=dumb ./gradlew :tests:test
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr commented on issue #29: remove the test filter for 7.1
csantanapr commented on issue #29: remove the test filter for 7.1 URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/29#issuecomment-398766973 replace by #28 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Ahmed-elsayed-mahmoud opened a new pull request #3787: Refactoring the load balancer with an overflow queue to reduce activation waiting time
Ahmed-elsayed-mahmoud opened a new pull request #3787: Refactoring the load balancer with an overflow queue to reduce activation waiting time URL: https://github.com/apache/incubator-openwhisk/pull/3787 ## Description ## Related issue and scope - [x] I opened an issue to propose and discuss this change (#3755) ## My changes affect the following components - [ ] API - [x] Controller - [ ] Message Bus (e.g., Kafka) - [x] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [x] Enhancement or new feature (adds new functionality). - [x] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #313: Fix awk command in init.sh generating resolvers.conf file
mrutkows commented on issue #313: Fix awk command in init.sh generating resolvers.conf file URL: https://github.com/apache/incubator-openwhisk-apigateway/pull/313#issuecomment-398743808 @baxtersa Thanks for identifying this problem and addressing the script command. Out of curiosity, have you signed an Apache ICLA? If you have not, and wish to contribute more extensive code fixes, please consider it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] remore commented on a change in pull request #3725: Add Ruby2.5 runtime support
remore commented on a change in pull request #3725: Add Ruby2.5 runtime support
URL:
https://github.com/apache/incubator-openwhisk/pull/3725#discussion_r196757462
##
File path: ansible/files/runtimes.json
##
@@ -109,6 +109,16 @@
"name": "action-php-v7.1"
}
}
+],
+"ruby": [
+{
+"kind": "ruby:2.5",
+"default": true,
+"deprecated": false,
+"image": {
Review comment:
made a change as a result of #3680
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] remore commented on a change in pull request #3725: Add Ruby2.5 runtime support
remore commented on a change in pull request #3725: Add Ruby2.5 runtime support URL: https://github.com/apache/incubator-openwhisk/pull/3725#discussion_r196756315 ## File path: actionRuntimes/ruby2.5Action/build.gradle ## @@ -0,0 +1,2 @@ +ext.dockerImageName = 'action-ruby-v2.5' Review comment: Same comment as [this](https://github.com/apache/incubator-openwhisk/pull/3725#discussion_r196755418) applies here This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] remore commented on a change in pull request #3725: Add Ruby2.5 runtime support
remore commented on a change in pull request #3725: Add Ruby2.5 runtime support URL: https://github.com/apache/incubator-openwhisk/pull/3725#discussion_r196755418 ## File path: actionRuntimes/ruby2.5Action/Dockerfile ## @@ -0,0 +1 @@ +FROM openwhisk/action-ruby-v2.5 Review comment: I haven't canceled this change yet since it looks like Dockerfile and build.gradle files in the actionRuntime/ folder still remains for other language runtimes while #3680 has been merged This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3777: Avoid converting ByteString to bytes in attachment inlining flow
chetanmeh commented on issue #3777: Avoid converting ByteString to bytes in attachment inlining flow URL: https://github.com/apache/incubator-openwhisk/pull/3777#issuecomment-398712891 Need a PG for this This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3786: Fixes EntitlementProvider to use SpiLoader
codecov-io commented on issue #3786: Fixes EntitlementProvider to use SpiLoader URL: https://github.com/apache/incubator-openwhisk/pull/3786#issuecomment-398694232 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3786?src=pr=h1) Report > Merging [#3786](https://codecov.io/gh/apache/incubator-openwhisk/pull/3786?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/071d841bc32f5b4a2712c416752d46488caead22?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3786?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3786 +/- ## == + Coverage 74.92% 74.92% +<.01% == Files 132 132 Lines6181 6182 +1 Branches 385 384 -1 == + Hits 4631 4632 +1 Misses 1550 1550 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3786?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ain/scala/whisk/core/entitlement/Entitlement.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3786/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXRsZW1lbnQvRW50aXRsZW1lbnQuc2NhbGE=) | `76.61% <100%> (+0.19%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3786?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3786?src=pr=footer). Last update [071d841...efcb6c6](https://codecov.io/gh/apache/incubator-openwhisk/pull/3786?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kpavel opened a new pull request #3786: Fixes EntitlementProvider to use SpiLoader
kpavel opened a new pull request #3786: Fixes EntitlementProvider to use SpiLoader URL: https://github.com/apache/incubator-openwhisk/pull/3786 Fixes EntitlementProvider to use SpiLoader to find MessagingProvider ## Description Currently EntitlementProvider uses hardcoded KafkaMessagingProvider. This PR fixes it. ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [x ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ x] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [ x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [ x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #3767: introduce timeout factor to control invoker queue behavior
codecov-io edited a comment on issue #3767: introduce timeout factor to control invoker queue behavior URL: https://github.com/apache/incubator-openwhisk/pull/3767#issuecomment-397564811 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3767?src=pr=h1) Report > Merging [#3767](https://codecov.io/gh/apache/incubator-openwhisk/pull/3767?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/071d841bc32f5b4a2712c416752d46488caead22?src=pr=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3767?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3767 +/- ## == - Coverage 74.92% 74.89% -0.03% == Files 132 132 Lines6181 6182 +1 Branches 385 384 -1 == - Hits 4631 4630 -1 - Misses 1550 1552 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3767?src=pr=tree) | Coverage Δ | | |---|---|---| | [...e/loadBalancer/ShardingContainerPoolBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3767/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL1NoYXJkaW5nQ29udGFpbmVyUG9vbEJhbGFuY2VyLnNjYWxh) | `32.35% <0%> (-0.2%)` | :arrow_down: | | [...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3767/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `84.61% <0%> (-3.85%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3767?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3767?src=pr=footer). Last update [071d841...9b92e7b](https://codecov.io/gh/apache/incubator-openwhisk/pull/3767?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #3767: introduce timeout factor to control invoker queue behavior
codecov-io edited a comment on issue #3767: introduce timeout factor to control invoker queue behavior URL: https://github.com/apache/incubator-openwhisk/pull/3767#issuecomment-397564811 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3767?src=pr=h1) Report > Merging [#3767](https://codecov.io/gh/apache/incubator-openwhisk/pull/3767?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/071d841bc32f5b4a2712c416752d46488caead22?src=pr=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3767?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3767 +/- ## == - Coverage 74.92% 74.89% -0.03% == Files 132 132 Lines6181 6182 +1 Branches 385 384 -1 == - Hits 4631 4630 -1 - Misses 1550 1552 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3767?src=pr=tree) | Coverage Δ | | |---|---|---| | [...e/loadBalancer/ShardingContainerPoolBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3767/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL1NoYXJkaW5nQ29udGFpbmVyUG9vbEJhbGFuY2VyLnNjYWxh) | `32.35% <0%> (-0.2%)` | :arrow_down: | | [...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3767/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `84.61% <0%> (-3.85%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3767?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3767?src=pr=footer). Last update [071d841...9b92e7b](https://codecov.io/gh/apache/incubator-openwhisk/pull/3767?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #2282: Distributed tracing support #2192
codecov-io edited a comment on issue #2282: Distributed tracing support #2192 URL: https://github.com/apache/incubator-openwhisk/pull/2282#issuecomment-391308983 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282?src=pr=h1) Report > Merging [#2282](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/6dce8dfe2836690f094b478b9bc4ff686fc9b2e7?src=pr=desc) will **decrease** coverage by `0.47%`. > The diff coverage is `32.83%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282?src=pr=tree) ```diff @@Coverage Diff @@ ## master#2282 +/- ## == - Coverage 74.91% 74.44% -0.48% == Files 132 134 +2 Lines6180 6241 +61 Branches 384 404 +20 == + Hits 4630 4646 +16 - Misses 1550 1595 +45 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `0% <0%> (ø)` | :arrow_up: | | [...la/whisk/common/tracing/TracingCacheProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi90cmFjaW5nL1RyYWNpbmdDYWNoZVByb3ZpZGVyLnNjYWxh) | `0% <0%> (ø)` | | | [...la/src/main/scala/whisk/common/TransactionId.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9UcmFuc2FjdGlvbklkLnNjYWxh) | `93.33% <100%> (+0.35%)` | :arrow_up: | | [...isk/core/controller/actions/PrimitiveActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1ByaW1pdGl2ZUFjdGlvbnMuc2NhbGE=) | `87.59% <100%> (+0.09%)` | :arrow_up: | | [.../src/main/scala/whisk/core/connector/Message.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2Uuc2NhbGE=) | `25.49% <100%> (ø)` | :arrow_up: | | [.../scala/src/main/scala/whisk/core/WhiskConfig.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvV2hpc2tDb25maWcuc2NhbGE=) | `92.06% <100%> (+0.06%)` | :arrow_up: | | [...ala/whisk/common/tracing/OpenTracingProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi90cmFjaW5nL09wZW5UcmFjaW5nUHJvdmlkZXIuc2NhbGE=) | `21.27% <21.27%> (ø)` | | | [...whisk/connector/kafka/KafkaConsumerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYUNvbnN1bWVyQ29ubmVjdG9yLnNjYWxh) | `62.96% <0%> (+0.69%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282?src=pr=footer). Last update [6dce8df...813582d](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
