[GitHub] jasonpet closed pull request #274: Remove required access to the whole couchdb database.
jasonpet closed pull request #274: Remove required access to the whole couchdb
database.
URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/274
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/provider/database.py b/provider/database.py
index 817f3a7..bed6296 100644
--- a/provider/database.py
+++ b/provider/database.py
@@ -23,6 +23,7 @@
import time
from cloudant.client import CouchDB
+from cloudant.client import CouchDatabase
from cloudant.result import Result
from datetime import datetime
@@ -46,12 +47,13 @@ def __init__(self, timeout=None):
self.client = CouchDB(self.username, self.password, url=self.url,
timeout=timeout, auto_renew=True)
self.client.connect()
-if self.dbname in self.client.all_dbs():
+self.database = CouchDatabase(self.client, self.dbname)
+
+if self.database.exists():
logging.info('Database exists - connecting to it.')
-self.database = self.client[self.dbname]
else:
logging.warn('Database does not exist - creating it.')
-self.database = self.client.create_database(self.dbname)
+self.database.create()
def destroy(self):
if self.client is not None:
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] JiniousChoi commented on issue #3947: Building Invoker image failure due to ssl connection via wget
JiniousChoi commented on issue #3947: Building Invoker image failure due to ssl connection via wget URL: https://github.com/apache/incubator-openwhisk/issues/3947#issuecomment-411248515 Yeah, the issue is gone. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] JiniousChoi closed issue #3947: Building Invoker image failure due to ssl connection via wget
JiniousChoi closed issue #3947: Building Invoker image failure due to ssl connection via wget URL: https://github.com/apache/incubator-openwhisk/issues/3947 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] JiniousChoi commented on issue #3947: Building Invoker image failure due to ssl connection via wget
JiniousChoi commented on issue #3947: Building Invoker image failure due to ssl connection via wget URL: https://github.com/apache/incubator-openwhisk/issues/3947#issuecomment-411235641 @dgrove-oss Alpine linux might have updated its docker image for this issue. I will check if the issue is resolved within 3 hours. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #3941: to address #3918, reuse a container on applicationError
codecov-io edited a comment on issue #3941: to address #3918, reuse a container on applicationError URL: https://github.com/apache/incubator-openwhisk/pull/3941#issuecomment-410349503 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941?src=pr=h1) Report > Merging [#3941](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/8f1dc2e9c848deb9f72da5b636895cbc5c565adb?src=pr=desc) will **decrease** coverage by `4.69%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941?src=pr=tree) ```diff @@Coverage Diff@@ ## master#3941 +/- ## = - Coverage 85.47% 80.77% -4.7% = Files 146 146 Lines7056 7058 +2 Branches 422 424 +2 = - Hits 6031 5701-330 - Misses 1025 1357+332 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ain/scala/whisk/core/containerpool/Container.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXIuc2NhbGE=) | `80.3% <100%> (ø)` | :arrow_up: | | [...cala/whisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `93.78% <100%> (+0.03%)` | :arrow_up: | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-81.82%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-58.83%)` | :arrow_down: | | [...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | | [...whisk/connector/kafka/KafkaConsumerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYUNvbnN1bWVyQ29ubmVjdG9yLnNjYWxh) | `58.2% <0%> (-1.8%)` | :arrow_down: | | [...a/src/main/scala/whisk/http/BasicHttpService.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvQmFzaWNIdHRwU2VydmljZS5zY2FsYQ==) | `93.44% <0%> (+1.5%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941?src=pr=footer). Last update [8f1dc2e...1ecf6d8](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This
[GitHub] tysonnorris commented on a change in pull request #3941: to address #3918, reuse a container on applicationError
tysonnorris commented on a change in pull request #3941: to address #3918,
reuse a container on applicationError
URL:
https://github.com/apache/incubator-openwhisk/pull/3941#discussion_r208404784
##
File path:
tests/src/test/scala/whisk/core/containerpool/test/ContainerProxyTests.scala
##
@@ -385,6 +390,70 @@ class ContainerProxyTests
}
}
+ it should "complete the transaction and reuse the container on a failed run
IFF failure was applicationError" in within(
+timeout) {
+val container = new TestContainer {
+ override def run(parameters: JsObject, environment: JsObject, timeout:
FiniteDuration)(
+implicit transid: TransactionId): Future[(Interval,
ActivationResponse)] = {
+runCount += 1
+//every other run fails
+if (runCount % 2 == 0) {
+ Future.successful((runInterval, ActivationResponse.success()))
+} else {
+ Future.successful((errorInterval,
ActivationResponse.applicationError(("boom"
+}
+ }
+}
+val factory = createFactory(Future.successful(container))
+val acker = createAcker()
+val store = createStore
+val collector = createCollector()
+
+val machine =
+ childActorOf(
+ContainerProxy
+ .props(factory, acker, store, collector, InvokerInstanceId(0),
poolConfig, pauseGrace = timeout))
+registerCallback(machine)
+preWarm(machine)
+
+//first one will fail
+run(machine, Started)
+
+// Note that there are no intermediate state changes
+//second one will succeed
+run(machine, Ready)
+
+awaitAssert {
+ factory.calls should have size 1
+ container.initializeCount shouldBe 1
+ container.runCount shouldBe 2
+ collector.calls should have size 2
+ container.suspendCount shouldBe 0
+ acker.calls should have size 2
+ store.calls should have size 2
+
+ val initErrorActivation = acker.calls(0)._2
Review comment:
These are the same (except the first run failure) assertions as in the `run
an action and continue with a next run without pausing the container` test; I
added a comment to indicate this
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] tysonnorris commented on a change in pull request #3941: to address #3918, reuse a container on applicationError
tysonnorris commented on a change in pull request #3941: to address #3918,
reuse a container on applicationError
URL:
https://github.com/apache/incubator-openwhisk/pull/3941#discussion_r208404838
##
File path:
tests/src/test/scala/whisk/core/containerpool/test/ContainerProxyTests.scala
##
@@ -385,6 +390,70 @@ class ContainerProxyTests
}
}
+ it should "complete the transaction and reuse the container on a failed run
IFF failure was applicationError" in within(
+timeout) {
+val container = new TestContainer {
+ override def run(parameters: JsObject, environment: JsObject, timeout:
FiniteDuration)(
+implicit transid: TransactionId): Future[(Interval,
ActivationResponse)] = {
+runCount += 1
+//every other run fails
+if (runCount % 2 == 0) {
+ Future.successful((runInterval, ActivationResponse.success()))
+} else {
+ Future.successful((errorInterval,
ActivationResponse.applicationError(("boom"
+}
+ }
+}
+val factory = createFactory(Future.successful(container))
+val acker = createAcker()
+val store = createStore
+val collector = createCollector()
+
+val machine =
+ childActorOf(
+ContainerProxy
+ .props(factory, acker, store, collector, InvokerInstanceId(0),
poolConfig, pauseGrace = timeout))
+registerCallback(machine)
+preWarm(machine)
+
+//first one will fail
+run(machine, Started)
+
+// Note that there are no intermediate state changes
+//second one will succeed
+run(machine, Ready)
+
+awaitAssert {
+ factory.calls should have size 1
+ container.initializeCount shouldBe 1
+ container.runCount shouldBe 2
+ collector.calls should have size 2
+ container.suspendCount shouldBe 0
+ acker.calls should have size 2
+ store.calls should have size 2
Review comment:
Yes! done
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dgrove-oss commented on issue #3947: Building Invoker image failure due to ssl connection via wget
dgrove-oss commented on issue #3947: Building Invoker image failure due to ssl connection via wget URL: https://github.com/apache/incubator-openwhisk/issues/3947#issuecomment-411218441 transient problem? It seems to be working just fine for me now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3947: Building Invoker image failure due to ssl connection via wget
rabbah commented on issue #3947: Building Invoker image failure due to ssl connection via wget URL: https://github.com/apache/incubator-openwhisk/issues/3947#issuecomment-411207687 @dgrove-oss ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Juice10 opened a new issue #284: Add code highlighting
Juice10 opened a new issue #284: Add code highlighting URL: https://github.com/apache/incubator-openwhisk-website/issues/284 Add code highlighting to allow people to read the documentation much easier and scan through the code. The easiest & best syntax highlighter I could find was [Prism.js](https://prismjs.com). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #3886: Proposing Lean OpenWhisk
codecov-io edited a comment on issue #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886#issuecomment-406254669 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886?src=pr=h1) Report > Merging [#3886](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/da1b28b5473e03961ca15e91136dd81fc93a3996?src=pr=desc) will **decrease** coverage by `14.46%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3886 +/- ## === - Coverage 85.19% 70.72% -14.47% === Files 146 148+2 Lines7057 6955 -102 Branches 420 431 +11 === - Hits 6012 4919 -1093 - Misses 1045 2036 +991 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886?src=pr=tree) | Coverage Δ | | |---|---|---| | [...main/scala/whisk/connector/lean/LeanConsumer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9sZWFuL0xlYW5Db25zdW1lci5zY2FsYQ==) | `0% <0%> (ø)` | | | [...main/scala/whisk/connector/lean/LeanProducer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9sZWFuL0xlYW5Qcm9kdWNlci5zY2FsYQ==) | `0% <0%> (ø)` | | | [...a/whisk/connector/lean/LeanMessagingProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9sZWFuL0xlYW5NZXNzYWdpbmdQcm92aWRlci5zY2FsYQ==) | `0% <0%> (ø)` | | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...la/src/main/scala/whisk/http/BasicRasService.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvQmFzaWNSYXNTZXJ2aWNlLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...a/src/main/scala/whisk/http/BasicHttpService.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvQmFzaWNIdHRwU2VydmljZS5zY2FsYQ==) | `0% <0%> (-93.45%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [.../main/scala/whisk/core/controller/Controller.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9Db250cm9sbGVyLnNjYWxh) | `0% <0%> (-82.11%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-81.82%)` | :arrow_down: | | ... and [62 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886?src=pr=footer). Last update [da1b28b...da6a326](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated
[GitHub] codecov-io edited a comment on issue #3941: to address #3918, reuse a container on applicationError
codecov-io edited a comment on issue #3941: to address #3918, reuse a container on applicationError URL: https://github.com/apache/incubator-openwhisk/pull/3941#issuecomment-410349503 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941?src=pr=h1) Report > Merging [#3941](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/8f1dc2e9c848deb9f72da5b636895cbc5c565adb?src=pr=desc) will **decrease** coverage by `4.61%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3941 +/- ## == - Coverage 85.47% 80.85% -4.62% == Files 146 146 Lines7056 7058 +2 Branches 422 424 +2 == - Hits 6031 5707 -324 - Misses 1025 1351 +326 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941?src=pr=tree) | Coverage Δ | | |---|---|---| | [...cala/whisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `93.78% <100%> (+0.03%)` | :arrow_up: | | [...ain/scala/whisk/core/containerpool/Container.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXIuc2NhbGE=) | `80.3% <100%> (ø)` | :arrow_up: | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-81.82%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-58.83%)` | :arrow_down: | | [...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | | [...whisk/connector/kafka/KafkaConsumerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYUNvbnN1bWVyQ29ubmVjdG9yLnNjYWxh) | `58.2% <0%> (-1.8%)` | :arrow_down: | | [...a/src/main/scala/whisk/http/BasicHttpService.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvQmFzaWNIdHRwU2VydmljZS5zY2FsYQ==) | `93.44% <0%> (+1.5%)` | :arrow_up: | | ... and [1 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941?src=pr=footer). Last update [8f1dc2e...bbc8913](https://codecov.io/gh/apache/incubator-openwhisk/pull/3941?src=pr=lastupdated). Read the [comment
[GitHub] dubee commented on issue #3798: Allow for activation store to accept user and request information
dubee commented on issue #3798: Allow for activation store to accept user and request information URL: https://github.com/apache/incubator-openwhisk/pull/3798#issuecomment-411175890 @markusthoemmes, anything else on this one? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #3798: Allow for activation store to accept user and request information
dubee commented on issue #3798: Allow for activation store to accept user and request information URL: https://github.com/apache/incubator-openwhisk/pull/3798#issuecomment-411175837 PG2 3475 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3941: to address #3918, reuse a container on applicationError
rabbah commented on a change in pull request #3941: to address #3918, reuse a
container on applicationError
URL:
https://github.com/apache/incubator-openwhisk/pull/3941#discussion_r208352657
##
File path:
tests/src/test/scala/whisk/core/containerpool/test/ContainerProxyTests.scala
##
@@ -385,6 +390,70 @@ class ContainerProxyTests
}
}
+ it should "complete the transaction and reuse the container on a failed run
IFF failure was applicationError" in within(
+timeout) {
+val container = new TestContainer {
+ override def run(parameters: JsObject, environment: JsObject, timeout:
FiniteDuration)(
+implicit transid: TransactionId): Future[(Interval,
ActivationResponse)] = {
+runCount += 1
+//every other run fails
+if (runCount % 2 == 0) {
+ Future.successful((runInterval, ActivationResponse.success()))
+} else {
+ Future.successful((errorInterval,
ActivationResponse.applicationError(("boom"
+}
+ }
+}
+val factory = createFactory(Future.successful(container))
+val acker = createAcker()
+val store = createStore
+val collector = createCollector()
+
+val machine =
+ childActorOf(
+ContainerProxy
+ .props(factory, acker, store, collector, InvokerInstanceId(0),
poolConfig, pauseGrace = timeout))
+registerCallback(machine)
+preWarm(machine)
+
+//first one will fail
+run(machine, Started)
+
+// Note that there are no intermediate state changes
+//second one will succeed
+run(machine, Ready)
+
+awaitAssert {
+ factory.calls should have size 1
+ container.initializeCount shouldBe 1
+ container.runCount shouldBe 2
+ collector.calls should have size 2
+ container.suspendCount shouldBe 0
+ acker.calls should have size 2
+ store.calls should have size 2
+
+ val initErrorActivation = acker.calls(0)._2
Review comment:
what are you testing here? I don't follow the rest of the checks here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] pritidesai closed pull request #277: updates for index and layout on large sizes
pritidesai closed pull request #277: updates for index and layout on large sizes
URL: https://github.com/apache/incubator-openwhisk-website/pull/277
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/_includes/index/index.js b/_includes/index/index.js
index 4f274e5..a85cf49 100644
--- a/_includes/index/index.js
+++ b/_includes/index/index.js
@@ -4,15 +4,26 @@ function applyCollapsible() {
var coll = document.getElementsByClassName("collapsible-toggle");
var i;
+// Apply exapandable (arrows) to all menuitems with a sibling
for (i = 0; i < coll.length; i++) {
+ var sibling = coll[i].nextElementSibling;
+
+ if(sibling!==null){
+ coll[i].style.listStyleImage =
"url('../images/elements/arrow-right-12px.png')";
+ // (top right bottom left)
+ sibling.style.padding = "0px 0px 0px 20px";
+ }
+
+ // Set "click" event listener on all menuitems
coll[i].addEventListener("click", function() {
-this.classList.toggle("active");
var sibling = this.nextElementSibling;
-console.log(sibling)
+// alternate menu open/close states
if(sibling!==null){
if (sibling.style.display === "block") {
+this.style.listStyleImage =
"url('../images/elements/arrow-right-12px.png')";
sibling.style.display = "none";
} else {
+this.style.listStyleImage =
"url('../images/elements/arrow-down-12px.png')";
sibling.style.display = "block";
}
}
@@ -20,6 +31,17 @@ function applyCollapsible() {
}
}
+// If sizing of arrows becomes an issue, we can use background approach instead
+// li
+// {
+// background: url(../images/arrow_icon.gif) no-repeat 4px 4px transparent;
+// background-image: url("x.png");
+// list-style-type: none;
+// margin: 0;
+// padding: 2px;
+// vertical-align: middle;
+// }
+
function openIndex() {
console.log("openIndex")
document.getElementById("index").style.display = "block";
diff --git a/_layouts/community.html b/_layouts/community.html
index 79fe47f..1e4fb2b 100644
--- a/_layouts/community.html
+++ b/_layouts/community.html
@@ -40,16 +40,15 @@
-
-
-
-Community
-
-
- The Apache OpenWhisk community attempts to engage its users and
developers in as many channels as we are able. Please find and subscribe to the
ones that are right for you!
-
-
-
+
+
+
+ Community
+
+ The Apache OpenWhisk community attempts to engage its
users and developers in as many channels as we are able. Please find and
subscribe to the ones that are right for you!
+
+
+
diff --git a/_layouts/documentation.html b/_layouts/documentation.html
index 2c8352f..ab71544 100644
--- a/_layouts/documentation.html
+++ b/_layouts/documentation.html
@@ -103,14 +103,15 @@
-
-
-
-Documentation
-
- There are many resources for learning about OpenWhisk; this page
attempts to organize, describe, index and link to the essential information,
wherever it resides, to help users in getting started. In general, much of the
best information is in the actual project repositories and we encourage you to
seek detailed and in-depth information there.
+
+
+
+Documentation
+
+ There are many resources for learning about OpenWhisk; this
page attempts to organize, describe, index and link to the essential
information, wherever it resides, to help users in getting started. In
general, much of the best information is in the actual project repositories and
we encourage you to seek detailed and in-depth information there.
+
-
+
@@ -140,6 +141,7 @@ Operators
OpenWhisk Deployment
+
https://raw.githubusercontent.com/apache/incubator-openwhisk/master/docs/images/OpenWhisk_flow_of_processing.png;
alt="OpenWhisk Architecture"/>
The above diagram depicts the high-level architecture of
OpenWhisk. From Nginx to Kafka to Docker,
diff --git a/_layouts/downloads.html b/_layouts/downloads.html
index cd2c510..a82f243 100644
--- a/_layouts/downloads.html
+++ b/_layouts/downloads.html
@@ -26,14 +26,15 @@
-
-
-
- Downloads
-
-This page contains links to the official project source code
downloads by release.
-
-
+
+
+
+Downloads
[GitHub] pritidesai closed pull request #283: adding comments
pritidesai closed pull request #283: adding comments
URL: https://github.com/apache/incubator-openwhisk-website/pull/283
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/Gemfile b/Gemfile
index 1e77f81..360d215 100644
--- a/Gemfile
+++ b/Gemfile
@@ -1,5 +1,5 @@
source "https://rubygems.org;
-ruby RUBY_VERSION
+ruby RUBY_VERSION
# Hello! This is where you manage which Jekyll version is used to run.
# When you want to use a different version, change it below, save the
diff --git a/_scss/_base.scss b/_scss/_base.scss
index 56f5a22..031cf4b 100644
--- a/_scss/_base.scss
+++ b/_scss/_base.scss
@@ -1,5 +1,6 @@
/*
* Base stylesheet for small form factors
+ * less than tablets
*/
body {
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] pritidesai opened a new pull request #283: adding comments
pritidesai opened a new pull request #283: adding comments URL: https://github.com/apache/incubator-openwhisk-website/pull/283 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3942: make error count and percentage configurable for gatling tests
codecov-io commented on issue #3942: make error count and percentage configurable for gatling tests URL: https://github.com/apache/incubator-openwhisk/pull/3942#issuecomment-411161996 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3942?src=pr=h1) Report > Merging [#3942](https://codecov.io/gh/apache/incubator-openwhisk/pull/3942?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/23e926885afb75e6b8057ff191df6b175451a656?src=pr=desc) will **decrease** coverage by `4.67%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3942?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3942 +/- ## == - Coverage 85.44% 80.77% -4.68% == Files 146 146 Lines7058 7057 -1 Branches 423 420 -3 == - Hits 6031 5700 -331 - Misses 1027 1357 +330 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3942?src=pr=tree) | Coverage Δ | | |---|---|---| | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3942/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3942/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3942/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3942/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-81.82%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3942/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-58.83%)` | :arrow_down: | | [...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3942/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | | [...a/src/main/scala/whisk/http/BasicHttpService.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3942/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvQmFzaWNIdHRwU2VydmljZS5zY2FsYQ==) | `93.44% <0%> (+1.5%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3942?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3942?src=pr=footer). Last update [23e9268...0c05e36](https://codecov.io/gh/apache/incubator-openwhisk/pull/3942?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai opened a new pull request #282: Redesigning OpenWhisk Website
pritidesai opened a new pull request #282: Redesigning OpenWhisk Website URL: https://github.com/apache/incubator-openwhisk-website/pull/282 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai closed pull request #281: making dir openwhisk and added dir listing
pritidesai closed pull request #281: making dir openwhisk and added dir listing
URL: https://github.com/apache/incubator-openwhisk-website/pull/281
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tools/jenkins/website_build.groovy
b/tools/jenkins/website_build.groovy
index c58beed..c4cd5e7 100644
--- a/tools/jenkins/website_build.groovy
+++ b/tools/jenkins/website_build.groovy
@@ -41,11 +41,14 @@ node("git-websites") {
git checkout asf-site
git log asf-site -3
git status
-rm -rf /tmp/_site
-mv _site /tmp/
+mkdir -p /tmp/openwhisk/
+rm -rf /tmp/openwhisk/_site
+mv _site /tmp/openwhisk/
+ls -l /tmp/openwhisk/_site/
rm -rf *
git status
-mv /tmp/_site/* .
+mv /tmp/openwhisk/_site/* .
+ls -l .
git status
git diff
git add .
@@ -58,4 +61,4 @@ node("git-websites") {
'''
}
-}
\ No newline at end of file
+}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] pritidesai opened a new pull request #281: making dir openwhisk and added dir listing
pritidesai opened a new pull request #281: making dir openwhisk and added dir listing URL: https://github.com/apache/incubator-openwhisk-website/pull/281 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee closed pull request #3949: don't explicitly terminate actorSystem (let CoordinatedShutdown do it…
dubee closed pull request #3949: don't explicitly terminate actorSystem (let
CoordinatedShutdown do it…
URL: https://github.com/apache/incubator-openwhisk/pull/3949
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/common/scala/src/main/scala/whisk/http/BasicHttpService.scala
b/common/scala/src/main/scala/whisk/http/BasicHttpService.scala
index fa4c612200..38d2e3d099 100644
--- a/common/scala/src/main/scala/whisk/http/BasicHttpService.scala
+++ b/common/scala/src/main/scala/whisk/http/BasicHttpService.scala
@@ -188,7 +188,6 @@ object BasicHttpService {
implicit val executionContext = actorSystem.dispatcher
sys.addShutdownHook {
Await.result(binding.map(_.unbind()), 30.seconds)
- actorSystem.terminate()
Await.result(actorSystem.whenTerminated, 30.seconds)
}
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubee closed issue #3948: ActorSystem prematurely terminates; akka cluster nodes cannot leave gracefully
dubee closed issue #3948: ActorSystem prematurely terminates; akka cluster nodes cannot leave gracefully URL: https://github.com/apache/incubator-openwhisk/issues/3948 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #3798: Allow for activation store to accept user and request information
codecov-io edited a comment on issue #3798: Allow for activation store to accept user and request information URL: https://github.com/apache/incubator-openwhisk/pull/3798#issuecomment-399226990 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3798?src=pr=h1) Report > Merging [#3798](https://codecov.io/gh/apache/incubator-openwhisk/pull/3798?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/23e926885afb75e6b8057ff191df6b175451a656?src=pr=desc) will **decrease** coverage by `4.67%`. > The diff coverage is `96.96%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3798?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3798 +/- ## == - Coverage 85.44% 80.77% -4.68% == Files 146 146 Lines7058 7062 +4 Branches 423 424 +1 == - Hits 6031 5704 -327 - Misses 1027 1358 +331 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3798?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../whisk/core/database/ArtifactActivationStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3798/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQXJ0aWZhY3RBY3RpdmF0aW9uU3RvcmUuc2NhbGE=) | `92.85% <ø> (ø)` | :arrow_up: | | [...main/scala/whisk/core/controller/Activations.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3798/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9BY3RpdmF0aW9ucy5zY2FsYQ==) | `96.77% <100%> (+0.16%)` | :arrow_up: | | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3798/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `73.94% <100%> (ø)` | :arrow_up: | | [...hisk/core/controller/actions/SequenceActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3798/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1NlcXVlbmNlQWN0aW9ucy5zY2FsYQ==) | `94.44% <100%> (ø)` | :arrow_up: | | [...cala/whisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3798/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `93.75% <100%> (ø)` | :arrow_up: | | [...isk/core/controller/actions/PrimitiveActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3798/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1ByaW1pdGl2ZUFjdGlvbnMuc2NhbGE=) | `89.14% <80%> (ø)` | :arrow_up: | | [...rc/main/scala/whisk/core/controller/Triggers.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3798/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9UcmlnZ2Vycy5zY2FsYQ==) | `94.16% <96.29%> (+0.04%)` | :arrow_up: | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3798/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3798/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3798/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | ... and [3 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3798/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3798?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3798?src=pr=footer). Last update [23e9268...0a1dfd0](https://codecov.io/gh/apache/incubator-openwhisk/pull/3798?src=pr=lastupdated). Read the [comment
[GitHub] csantanapr commented on a change in pull request #73: Don't override runtime npm packages when user provides their own
csantanapr commented on a change in pull request #73: Don't override runtime npm packages when user provides their own URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/73#discussion_r208282550 ## File path: tools/travis/build.sh ## @@ -38,8 +38,16 @@ TERM=dumb ./gradlew install echo "openwhisk.home=$WHISKDIR" > whisk.properties echo "vcap.services.file=" >> whisk.properties -# Build runtime +# Build runtime and dependencies cd $ROOTDIR + +# Build runtime TERM=dumb ./gradlew \ :core:nodejs6Action:distDocker \ :core:nodejs8Action:distDocker + +# Build test dependency containers +docker build --tag nodejs6docker ./tests/dat/docker/nodejs6docker/ Review comment: you can create two project and include them, then just run `./gradlew distDocker` it will build all 4 images This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on a change in pull request #73: Don't override runtime npm packages when user provides their own
csantanapr commented on a change in pull request #73: Don't override runtime
npm packages when user provides their own
URL:
https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/73#discussion_r208282176
##
File path:
tests/src/test/scala/runtime/actionContainers/NodeJsActionContainerTests.scala
##
@@ -586,4 +589,44 @@ abstract class NodeJsActionContainerTests extends
BasicActionRunnerTests with Ws
})
}
+ it should "use user provided npm packages in a zip file" in {
+val datdir = "tests/dat/actions"
+val filePath = new File(datdir, "nodejs-test.zip").toString()
+val zipPath = new File(filePath).toPath
+val code = ResourceHelpers.readAsBase64(zipPath)
+withNodeJsContainer { c =>
+ c.init(initPayload(code))._1 should be(200)
+
+ val (runCode, runRes) = c.run(runPayload(JsObject()))
+ runRes.get.fields.get("message") shouldBe Some(JsString("success"))
+}
+ }
+
+ it should "use user provided packages in Docker Actions" in {
+withContainer(nodejsTestDockerImageName) { c =>
+ val code =
+"""
+ | function main(args) {
+ | var ow = require('openwhisk');
+ | // actions only exists on 2.* versions of openwhisk, not
3.*, so if this was 3.* it would throw an error,
+ | var actions = ow().actions;
+ |
+ | return { "message": "success" };
+ |}
+ """.stripMargin
+
+ val (initCode, err) = c.init(initPayload(code))
+
+ initCode should be(200)
+
+ // WHEN I run an action that requires ws and socket.io.client
Review comment:
I don't understand this comment about `ws` and `socket.io`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr commented on a change in pull request #73: Don't override runtime npm packages when user provides their own
csantanapr commented on a change in pull request #73: Don't override runtime npm packages when user provides their own URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/73#discussion_r208281086 ## File path: tools/travis/build.sh ## @@ -38,8 +38,16 @@ TERM=dumb ./gradlew install echo "openwhisk.home=$WHISKDIR" > whisk.properties echo "vcap.services.file=" >> whisk.properties -# Build runtime +# Build runtime and dependencies cd $ROOTDIR + +# Build runtime TERM=dumb ./gradlew \ :core:nodejs6Action:distDocker \ :core:nodejs8Action:distDocker + +# Build test dependency containers +docker build --tag nodejs6docker ./tests/dat/docker/nodejs6docker/ Review comment: Don't build the images manually use a gradle project and the `distDocker` task This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on a change in pull request #73: Don't override runtime npm packages when user provides their own
csantanapr commented on a change in pull request #73: Don't override runtime
npm packages when user provides their own
URL:
https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/73#discussion_r208280639
##
File path:
tests/src/test/scala/runtime/actionContainers/NodeJs8ActionContainerTests.scala
##
@@ -19,12 +19,13 @@ package runtime.actionContainers
import org.junit.runner.RunWith
import org.scalatest.junit.JUnitRunner
-import spray.json.JsObject
+import spray.json.{JsObject}
Review comment:
No need for `{}` if it's only one class
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] jeremiaswerner commented on issue #3942: make error count and percentage configurable for gatling tests
jeremiaswerner commented on issue #3942: make error count and percentage configurable for gatling tests URL: https://github.com/apache/incubator-openwhisk/pull/3942#issuecomment-411099989 @markusthoemmes thanks for the review. I've adopted the comments. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #3945: Treat action code as attachments
codecov-io edited a comment on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-410980593 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=h1) Report > Merging [#3945](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/23e926885afb75e6b8057ff191df6b175451a656?src=pr=desc) will **decrease** coverage by `4.64%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3945 +/- ## == - Coverage 85.44% 80.79% -4.65% == Files 146 146 Lines7058 7057 -1 Branches 423 424 +1 == - Hits 6031 5702 -329 - Misses 1027 1355 +328 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=tree) | Coverage Δ | | |---|---|---| | [...src/main/scala/whisk/core/entity/WhiskAction.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1doaXNrQWN0aW9uLnNjYWxh) | `86.09% <100%> (ø)` | :arrow_up: | | [.../scala/src/main/scala/whisk/core/entity/Exec.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWMuc2NhbGE=) | `84.96% <100%> (+0.55%)` | :arrow_up: | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-81.82%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-58.83%)` | :arrow_down: | | [...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | | [...rc/main/scala/whisk/common/ForcibleSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjaWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `92.3% <0%> (+3.84%)` | :arrow_up: | | ... and [1 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=footer). Last update [23e9268...c70724d](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure
[GitHub] codecov-io edited a comment on issue #3945: Treat action code as attachments
codecov-io edited a comment on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-410980593 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=h1) Report > Merging [#3945](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/23e926885afb75e6b8057ff191df6b175451a656?src=pr=desc) will **decrease** coverage by `4.66%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3945 +/- ## == - Coverage 85.44% 80.78% -4.67% == Files 146 146 Lines7058 7058 Branches 423 420 -3 == - Hits 6031 5702 -329 - Misses 1027 1356 +329 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=tree) | Coverage Δ | | |---|---|---| | [...src/main/scala/whisk/core/entity/WhiskAction.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1doaXNrQWN0aW9uLnNjYWxh) | `86.09% <100%> (ø)` | :arrow_up: | | [.../scala/src/main/scala/whisk/core/entity/Exec.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWMuc2NhbGE=) | `85.06% <100%> (+0.64%)` | :arrow_up: | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-81.82%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-58.83%)` | :arrow_down: | | [...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | | [...src/main/scala/whisk/core/entity/Attachments.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0F0dGFjaG1lbnRzLnNjYWxh) | `88.88% <0%> (+5.55%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=footer). Last update [23e9268...c70724d](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on a change in pull request #3945: Treat action code as attachments
chetanmeh commented on a change in pull request #3945: Treat action code as
attachments
URL:
https://github.com/apache/incubator-openwhisk/pull/3945#discussion_r208257099
##
File path: common/scala/src/main/scala/whisk/core/entity/Exec.scala
##
@@ -300,33 +300,28 @@ protected[core] object Exec extends ArgNormalizer[Exec]
with DefaultJsonProtocol
case None=> throw new DeserializationException(s"kind '$kind'
not in $runtimes")
}
+ manifest.attached.map { _ =>
+}
+
Review comment:
Aah ... missed checking prior to push. Fixed it now
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3945: Treat action code as attachments
markusthoemmes commented on a change in pull request #3945: Treat action code
as attachments
URL:
https://github.com/apache/incubator-openwhisk/pull/3945#discussion_r208251229
##
File path: common/scala/src/main/scala/whisk/core/entity/Exec.scala
##
@@ -300,33 +300,28 @@ protected[core] object Exec extends ArgNormalizer[Exec]
with DefaultJsonProtocol
case None=> throw new DeserializationException(s"kind '$kind'
not in $runtimes")
}
+ manifest.attached.map { _ =>
+}
+
Review comment:
Bad push, this is dead code (sorry I forgot to take that out of my patch)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] eweiter commented on issue #73: Don't override runtime npm packages when user provides their own
eweiter commented on issue #73: Don't override runtime npm packages when user provides their own URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/73#issuecomment-411071728 @csantanapr This should be ready, it has the 3 tests we talked about 1) (Already existing) , check that the "openwhisk" package is available 2) In a Docker file a user should be able to require an older version of the "openwhisk" package 3) In a .zip file a user should be able to require an older version of the "openwhisk" package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #3772: Update kubectl version in invoker Dockerfile
dgrove-oss commented on issue #3772: Update kubectl version in invoker Dockerfile URL: https://github.com/apache/incubator-openwhisk/pull/3772#issuecomment-411065689 the open deploy-kube project nominally supports Kube 1.8, 1.9, and 1.10. The kubectl embedded in the invoker image is only used in a couple of code paths in the KubernetesContainerFactory. We actually should get rid of it entirely, but it will take a little work in the KubernetesClient code used by the KubeContainerFactory. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sven-lange-last commented on issue #3772: Update kubectl version in invoker Dockerfile
sven-lange-last commented on issue #3772: Update kubectl version in invoker Dockerfile URL: https://github.com/apache/incubator-openwhisk/pull/3772#issuecomment-411062291 @dgrove-oss which Kube version are we targetting with the invoker image? IBM Cloud Kubernetes service is on Kube 1.10 at the moment... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #3772: Update kubectl version in invoker Dockerfile
dgrove-oss commented on issue #3772: Update kubectl version in invoker Dockerfile URL: https://github.com/apache/incubator-openwhisk/pull/3772#issuecomment-411060730 @bbrowning and @bwmcadams are you ok with the bump of kubectl in the invoker image to 1.8.x? If so, could you merge this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3942: make error count and percentage configurable for gatling tests
markusthoemmes commented on a change in pull request #3942: make error count
and percentage configurable for gatling tests
URL:
https://github.com/apache/incubator-openwhisk/pull/3942#discussion_r208202442
##
File path:
tests/performance/gatling_tests/src/gatling/scala/LatencySimulation.scala
##
@@ -91,14 +99,20 @@ class LatencySimulation extends Simulation {
.protocols(openWhiskProtocol)
actions
-.map { case (kind, _, _, _) => s"Warm $kind invocation" }
-.foldLeft(testSetup) { (agg, cur) =>
+.map { case (kind, _, _, _) => kind }
+.foldLeft(testSetup) { (agg, kind) =>
+ val cur = s"Warm $kind invocation"
// One failure will make the build yellow
+ val mrt : Int = sys.env.getOrElse(kind.split(":").head.toUpperCase + "_"
+ MEAN_RESPONSE_TIME, meanResponseTime.toString).toInt
+ val maxrt = sys.env.getOrElse(kind.split(":").head.toUpperCase + "_" +
MAX_MEAN_RESPONSE_TIME, maximalMeanResponseTime.toString).toInt
+ val maxerr = sys.env.getOrElse(kind.split(":").head.toUpperCase + "_" +
MAX_ERRORS_ALLOWED, maxErrorsAllowed.toString).toInt
+ val maxerrp = sys.env.getOrElse(kind.split(":").head.toUpperCase + "_" +
MAX_ERRORS_ALLOWED_PERCENTAGE, maxErrorsAllowedPercentage.toString).toDouble
Review comment:
Does it make sense to exclude this into a function to prevent duplication,
like:
```scala
def toKindSpecificKey(kind: String, suffix: String) =
kind.split(':').head.toUpperCase + "_" + suffix
```
To be used like:
```scala
val mrt: Int = sys.env.getOrElse(toKindSpecificKey(kind, MEAN_RESPONSE_TIME)
, meanResponseTime.toString).toInt
```
Also: No need to abbreviate the constant names here. Please make them "fully
qualified" to be readable more easily, like: `specificMeanResponseTime`,
`specificMaxResponseTime` etc.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3942: make error count and percentage configurable for gatling tests
markusthoemmes commented on a change in pull request #3942: make error count and percentage configurable for gatling tests URL: https://github.com/apache/incubator-openwhisk/pull/3942#discussion_r208200918 ## File path: tests/performance/README.md ## @@ -101,14 +103,20 @@ The comparison of the thresholds is against the mean response times of the warm Available environment variables: ``` -OPENWHISK_HOST (required) -API_KEY (required, format: UUID:KEY) -PAUSE_BETWEEN_INVOKES (default: 0) -MEAN_RESPONSE_TIME (required) -MAX_MEAN_RESPONSE_TIME (default: MEAN_RESPONSE_TIME) -EXCLUDED_KINDS (default: "", format: "python:default,java:default,swift:default") +OPENWHISK_HOST(required) +API_KEY (required, format: UUID:KEY) +PAUSE_BETWEEN_INVOKES (default: 0) +MEAN_RESPONSE_TIME(required) +MAX_MEAN_RESPONSE_TIME(default: MEAN_RESPONSE_TIME) +EXCLUDED_KINDS(default: "", format: "python:default,java:default,swift:default") +MAX_ERRORS_ALLOWED(default: 0) +MAX_ERRORS_ALLOWED_PERCENTAGE (default: 0) ``` +It is possible to override the `MEAN_RESPONSE_TIME`, `MAX_MEAN_RESPONSE_TIME`, `MAX_ERRORS_ALLOWED` and `MAX_ERRORS_ALLOWED_PERCENTAGE` +for each kind by adding the kind as perfix in upper case, like `JAVA_MEAN_RESPONSE_TIME`. Review comment: typo: prefix. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #3945: Treat action code as attachments
codecov-io edited a comment on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-410980593 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=h1) Report > Merging [#3945](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/23e926885afb75e6b8057ff191df6b175451a656?src=pr=desc) will **decrease** coverage by `4.65%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3945 +/- ## == - Coverage 85.44% 80.79% -4.66% == Files 146 146 Lines7058 7060 +2 Branches 423 420 -3 == - Hits 6031 5704 -327 - Misses 1027 1356 +329 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../scala/src/main/scala/whisk/core/entity/Exec.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWMuc2NhbGE=) | `85.25% <100%> (+0.84%)` | :arrow_up: | | [...src/main/scala/whisk/core/entity/WhiskAction.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1doaXNrQWN0aW9uLnNjYWxh) | `86.09% <100%> (ø)` | :arrow_up: | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-81.82%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-58.83%)` | :arrow_down: | | [...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | | [...src/main/scala/whisk/core/entity/Attachments.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0F0dGFjaG1lbnRzLnNjYWxh) | `88.88% <0%> (+5.55%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=footer). Last update [23e9268...963e732](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #3945: Treat action code as attachments
codecov-io edited a comment on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-410980593 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=h1) Report > Merging [#3945](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/23e926885afb75e6b8057ff191df6b175451a656?src=pr=desc) will **decrease** coverage by `4.65%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3945 +/- ## == - Coverage 85.44% 80.79% -4.66% == Files 146 146 Lines7058 7060 +2 Branches 423 420 -3 == - Hits 6031 5704 -327 - Misses 1027 1356 +329 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=tree) | Coverage Δ | | |---|---|---| | [...src/main/scala/whisk/core/entity/WhiskAction.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1doaXNrQWN0aW9uLnNjYWxh) | `86.09% <100%> (ø)` | :arrow_up: | | [.../scala/src/main/scala/whisk/core/entity/Exec.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWMuc2NhbGE=) | `85.25% <100%> (+0.84%)` | :arrow_up: | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-81.82%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-58.83%)` | :arrow_down: | | [...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | | [...src/main/scala/whisk/core/entity/Attachments.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0F0dGFjaG1lbnRzLnNjYWxh) | `88.88% <0%> (+5.55%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=footer). Last update [23e9268...963e732](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jeremiaswerner commented on issue #3942: make error count and percentage configurable for gatling tests
jeremiaswerner commented on issue #3942: make error count and percentage
configurable for gatling tests
URL:
https://github.com/apache/incubator-openwhisk/pull/3942#issuecomment-411029337
I've extended the PR to make all thresholds configurable via CLI invocation.
```
# API_KEY= OPENWHISK_HOST= USERS="10" REQUESTS_PER_SEC="10"
MEAN_RESPONSE_TIME="500" SWIFT_MEAN_RESPONSE_TIME="1000"
JAVA_MAX_ERRORS_ALLOWS=5 MAX_ERRORS_ALLOWED="1" ./gradlew
gatlingRun-LatencySimulation
```
Result looks like
```
Global Information
> request count412 (OK=412KO=0
)
> min response time174 (OK=174KO=-
)
> max response time823 (OK=823KO=-
)
> mean response time 199 (OK=199KO=-
)
> std deviation 69 (OK=69 KO=-
)
> response time 50th percentile180 (OK=180KO=-
)
> response time 75th percentile192 (OK=192KO=-
)
> response time 95th percentile302 (OK=302KO=-
)
> response time 99th percentile520 (OK=520KO=-
)
> mean requests/sec 4.964 (OK=4.964 KO=-
)
Response Time Distribution
> t < 800 ms 411 (100%)
> 800 ms < t < 1200 ms 1 ( 0%)
> t > 1200 ms0 ( 0%)
> failed 0 ( 0%)
Reports generated in 0s.
Please open the following file:
/Users/jerewern/repos/bluewhisk/open/tests/performance/gatling_tests/build/reports/gatling/latencysimulation-1533642179855/index.html
Warm nodejs:default invocation: mean of response time is less than or equal
to 500.0 : true
Warm nodejs:default invocation: mean of response time is less than 500.0 :
true
Warm nodejs:default invocation: count of failed requests is less than or
equal to 1.0 : true
Warm nodejs:default invocation: percentage of failed requests is less than
or equal to 0.1 : true
Warm python:default invocation: mean of response time is less than or equal
to 500.0 : true
Warm python:default invocation: mean of response time is less than 500.0 :
true
Warm python:default invocation: count of failed requests is less than or
equal to 1.0 : true
Warm python:default invocation: percentage of failed requests is less than
or equal to 0.1 : true
Warm swift:default invocation: mean of response time is less than or equal
to 1000.0 : true
Warm swift:default invocation: mean of response time is less than 500.0 :
true
Warm swift:default invocation: count of failed requests is less than or
equal to 1.0 : true
Warm swift:default invocation: percentage of failed requests is less than or
equal to 0.1 : true
Warm java:default invocation: mean of response time is less than or equal to
500.0 : true
Warm java:default invocation: mean of response time is less than 500.0 : true
Warm java:default invocation: count of failed requests is less than or equal
to 1.0 : true
Warm java:default invocation: percentage of failed requests is less than or
equal to 0.1 : true
BUILD SUCCESSFUL in 1m 25s
3 actionable tasks: 1 executed, 2 up-to-date
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3945: Treat action code as attachments
markusthoemmes commented on a change in pull request #3945: Treat action code
as attachments
URL:
https://github.com/apache/incubator-openwhisk/pull/3945#discussion_r208197974
##
File path: common/scala/src/main/scala/whisk/core/entity/WhiskAction.scala
##
@@ -333,23 +335,27 @@ object WhiskAction extends DocumentFactory[WhiskAction]
with WhiskEntityQueries[
require(doc != null, "doc undefined")
} map { _ =>
doc.exec match {
-case exec @ CodeExecAsAttachment(_, Inline(code), _) =>
+case exec @ CodeExecAsAttachment(_, Inline(code), _, binary) =>
implicit val logger = db.logging
implicit val ec = db.executionContext
- val stream = new
ByteArrayInputStream(Base64.getDecoder().decode(code))
- val manifest = exec.manifest.attached.get
+ val (bytes, attachmentType) = if (binary) {
+(Base64.getDecoder().decode(code),
ContentTypes.`application/octet-stream`)
+ } else {
+(code.getBytes("UTF-8"), ContentTypes.`text/plain(UTF-8)`)
Review comment:
Please replace "UTF-8" with `StandardCharsets.UTF_8`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] chetanmeh commented on issue #3945: Treat action code as attachments
chetanmeh commented on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-411022379 This PR is ready for review. One aspect which is still to be addressed is should we raise the default `max-inline-size` (defaults 16 KB) to some higher value to offset any potential perf impact on small function. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #3945: Treat action code as attachments
codecov-io edited a comment on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-410980593 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=h1) Report > Merging [#3945](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/23e926885afb75e6b8057ff191df6b175451a656?src=pr=desc) will **decrease** coverage by `4.65%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3945 +/- ## == - Coverage 85.44% 80.79% -4.66% == Files 146 146 Lines7058 7060 +2 Branches 423 420 -3 == - Hits 6031 5704 -327 - Misses 1027 1356 +329 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=tree) | Coverage Δ | | |---|---|---| | [...src/main/scala/whisk/core/entity/WhiskAction.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1doaXNrQWN0aW9uLnNjYWxh) | `86.09% <100%> (ø)` | :arrow_up: | | [.../scala/src/main/scala/whisk/core/entity/Exec.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWMuc2NhbGE=) | `85.25% <100%> (+0.84%)` | :arrow_up: | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-81.82%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-58.83%)` | :arrow_down: | | [...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | | [...src/main/scala/whisk/core/entity/Attachments.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0F0dGFjaG1lbnRzLnNjYWxh) | `88.88% <0%> (+5.55%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=footer). Last update [23e9268...0e3c043](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #3945: Treat action code as attachments
codecov-io edited a comment on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-410980593 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=h1) Report > Merging [#3945](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/23e926885afb75e6b8057ff191df6b175451a656?src=pr=desc) will **decrease** coverage by `14.21%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3945 +/- ## === - Coverage 85.44% 71.23% -14.22% === Files 146 146 Lines7058 7060+2 Branches 423 420-3 === - Hits 6031 5029 -1002 - Misses 1027 2031 +1004 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=tree) | Coverage Δ | | |---|---|---| | [...src/main/scala/whisk/core/entity/WhiskAction.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1doaXNrQWN0aW9uLnNjYWxh) | `80.13% <100%> (-5.97%)` | :arrow_down: | | [.../scala/src/main/scala/whisk/core/entity/Exec.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWMuc2NhbGE=) | `81.41% <100%> (-3.01%)` | :arrow_down: | | [...la/src/main/scala/whisk/http/BasicRasService.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvQmFzaWNSYXNTZXJ2aWNlLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...a/src/main/scala/whisk/http/BasicHttpService.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvQmFzaWNIdHRwU2VydmljZS5zY2FsYQ==) | `0% <0%> (-91.94%)` | :arrow_down: | | [.../main/scala/whisk/core/controller/Controller.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9Db250cm9sbGVyLnNjYWxh) | `0% <0%> (-82.11%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-81.82%)` | :arrow_down: | | [.../whisk/core/database/RemoteCacheInvalidation.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvUmVtb3RlQ2FjaGVJbnZhbGlkYXRpb24uc2NhbGE=) | `0% <0%> (-80%)` | :arrow_down: | | ... and [46 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=footer). Last update [23e9268...0e3c043](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[GitHub] jthomas closed pull request #33: Lots and lots and lots of updates...
jthomas closed pull request #33: Lots and lots and lots of updates... URL: https://github.com/apache/incubator-openwhisk-external-resources/pull/33 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/README.md b/README.md index 5ed8579..b3303b1 100644 --- a/README.md +++ b/README.md @@ -1,10 +1,10 @@ -# Awesome OpenWhisk [](https://github.com/sindresorhus/awesome) [https://raw.githubusercontent.com/openwhisk/openwhisk/master/docs/images/whisk_icon_full_color_with_tm_100x100-300dpi.png; width="100" align="right" alt="openwhisk">](https://github.com/openwhisk/openwhisk) +# Awesome Apache OpenWhisk [](https://github.com/sindresorhus/awesome) [https://raw.githubusercontent.com/openwhisk/openwhisk/master/docs/images/whisk_icon_full_color_with_tm_100x100-300dpi.png; width="100" align="right" alt="openwhisk">](https://github.com/openwhisk/openwhisk) -> Awesome [OpenWhisk](https://www.github.com/openwhisk/openwhisk) resources and tips. +> Awesome [Apache OpenWhisk](https://github.com/apache/incubator-openwhisk) resources and tips. -*OpenWhisk is a cloud-first distributed event-based programming service. It provides a programming model to upload event handlers to a cloud service, and register the handlers to respond to various events.* +*Apache OpenWhisk is a cloud-first distributed event-based programming service. It provides a programming model to upload event handlers to a cloud service, and register the handlers to respond to various events.* -*Learn more at [http://openwhisk.org](http://openwhisk.org) or try it on [IBM Bluemix OpenWhisk](https://bluemix.net).* +*Learn more at [http://openwhisk.org](http://openwhisk.org) or try it on [IBM Cloud Functions](https://console.bluemix.net/openwhisk/).* ## Contents @@ -21,82 +21,48 @@ ## Articles -*Articles, tutorials and blogs on building serverless applications using OpenWhisk.* -- [Five minute intro to open source serverless development with OpenWhisk](https://medium.com/openwhisk/five-minute-intro-to-open-source-serverless-development-with-openwhisk-328b0ebfa160). -- [Your business won't use a server in 5 years](https://blogs.adobe.com/conversations/2016/12/your-business-wont-use-a-server-in-5-years.html) - Blog post from Adobe on why they got involved with the Apache OpenWhisk project. -- [Squeezing the milliseconds: How to make serverless platforms blazing fast!](https://medium.com/openwhisk/squeezing-the-milliseconds-how-to-make-serverless-platforms-blazing-fast-aea0e9951bd0) - A follow up to "Uncovering the magic" below, this article takes a closer look at OpenWhisk performance characteristics. -- [Whisking the Weather!](https://medium.com/openwhisk/whisking-the-weather-74ecda4d7105) - How and why a mobile app developer developed a unique and fun weather app called Weather Gods with OpenWhisk. -- [Advanced debugging of OpenWhisk actions](https://medium.com/openwhisk/advanced-debugging-of-openwhisk-actions-518414636932) describes how to test an Apache OpenWhisk action locally using Docker and a helper Python script. -- [Extending OpenWhisk to the IoT Edge with Node-RED, Docker and resin.io](https://medium.com/openwhisk/extending-openwhisk-to-the-iot-edge-with-node-red-docker-and-resin-io-bec7f30ea2de) - Describes a sample application for a flexible edge platform using OpenWhisk, Node-RED and resin.io to manage provisioning and lifecycle of Docker-based applications on a fleet of IoT gateways, such as Raspberry Pi. -- [OpenWhisk and The Serverless Framework](https://medium.com/openwhisk/openwhisk-and-the-serverless-framework-b05ce569137a#.n1lyyw17v) - Build serverless apps with OpenWhisk and The Serverless Framework. +*Articles, tutorials and blogs on building serverless applications using Apache OpenWhisk.* - [Uncovering the magic: How serverless platforms really work!](https://medium.com/openwhisk/uncovering-the-magic-how-serverless-platforms-really-work-3cb127b05f71) - A step by step guide through the inner guts of OpenWhisk. -- [HTTP handlers with OpenWhisk](https://medium.com/openwhisk/serverless-http-handlers-with-openwhisk-90a986cc7cdd) - This blog post demonstrates the use of OpenWhisk web actions to write HTTP handlers. -- [What makes serverless architectures so attractive?](https://developer.ibm.com/opentech/2016/09/06/what-makes-serverless-attractive/) - Serverless is the hottest trend in cloud this year, and for good reason. +- [How to make serverless platforms blazing
[GitHub] codecov-io edited a comment on issue #3945: Treat action code as attachments
codecov-io edited a comment on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-410980593 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=h1) Report > Merging [#3945](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/23e926885afb75e6b8057ff191df6b175451a656?src=pr=desc) will **decrease** coverage by `4.67%`. > The diff coverage is `86.66%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3945 +/- ## == - Coverage 85.44% 80.77% -4.68% == Files 146 146 Lines7058 7064 +6 Branches 423 424 +1 == - Hits 6031 5706 -325 - Misses 1027 1358 +331 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=tree) | Coverage Δ | | |---|---|---| | [...src/main/scala/whisk/core/entity/WhiskAction.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1doaXNrQWN0aW9uLnNjYWxh) | `86.18% <100%> (+0.09%)` | :arrow_up: | | [.../scala/src/main/scala/whisk/core/entity/Exec.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWMuc2NhbGE=) | `84.27% <81.81%> (-0.14%)` | :arrow_down: | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-81.82%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-58.83%)` | :arrow_down: | | [...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | | [...src/main/scala/whisk/core/entity/Attachments.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0F0dGFjaG1lbnRzLnNjYWxh) | `88.88% <0%> (+5.55%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=footer). Last update [23e9268...5851f07](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3945: Treat action code as attachments
markusthoemmes commented on a change in pull request #3945: Treat action code
as attachments
URL:
https://github.com/apache/incubator-openwhisk/pull/3945#discussion_r208153927
##
File path: common/scala/src/main/scala/whisk/core/entity/Exec.scala
##
@@ -302,21 +309,29 @@ protected[core] object Exec extends ArgNormalizer[Exec]
with DefaultJsonProtocol
manifest.attached
.map { a =>
- val jar: Attachment[String] = {
-// java actions once stored the attachment in "jar" instead of
"code"
-obj.fields.get("code").orElse(obj.fields.get("jar"))
+ val code = obj.fields.get("code")
+ val binary: Boolean = code match {
+case Some(JsString(c)) => isBinaryCode(c)
+case _ =>
+ obj.fields.get("binary") match {
+case Some(JsBoolean(b)) => b
+case _ => false
+ }
+ }
+ val attachment: Attachment[String] = {
+code
Review comment:
Chatted with @chetanmeh, I was indeed missing something:
`code` can be a JsObject, that breaks my simplification of course.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3945: Treat action code as attachments
markusthoemmes commented on a change in pull request #3945: Treat action code
as attachments
URL:
https://github.com/apache/incubator-openwhisk/pull/3945#discussion_r208150487
##
File path: common/scala/src/main/scala/whisk/core/entity/Exec.scala
##
@@ -302,21 +309,29 @@ protected[core] object Exec extends ArgNormalizer[Exec]
with DefaultJsonProtocol
manifest.attached
.map { a =>
- val jar: Attachment[String] = {
-// java actions once stored the attachment in "jar" instead of
"code"
-obj.fields.get("code").orElse(obj.fields.get("jar"))
+ val code = obj.fields.get("code")
+ val binary: Boolean = code match {
+case Some(JsString(c)) => isBinaryCode(c)
+case _ =>
+ obj.fields.get("binary") match {
+case Some(JsBoolean(b)) => b
+case _ => false
+ }
+ }
+ val attachment: Attachment[String] = {
+code
Review comment:
If I read this correctly, an undefined `code` results in a
DeserializationException? If that's the case, why even bother checking for the
"binary" field above if code is `None`? The binary field also feels redundant,
is it ever used?
As I read it, this could be simplified to:
```scala
val (binary, attachment) = code match {
case Some(JsString(c)) =>
(isBinaryCode(c), attFmt[String].read(c))
case _ =>
throw new DeserializationException(s"'code' must be a string defined in
'exec' for '$kind' actions")
}
```
Am I missing something?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io commented on issue #3945: Treat action code as attachments
codecov-io commented on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-410980593 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=h1) Report > Merging [#3945](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/23e926885afb75e6b8057ff191df6b175451a656?src=pr=desc) will **decrease** coverage by `4.67%`. > The diff coverage is `86.66%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3945 +/- ## == - Coverage 85.44% 80.77% -4.68% == Files 146 146 Lines7058 7064 +6 Branches 423 429 +6 == - Hits 6031 5706 -325 - Misses 1027 1358 +331 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=tree) | Coverage Δ | | |---|---|---| | [...src/main/scala/whisk/core/entity/WhiskAction.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1doaXNrQWN0aW9uLnNjYWxh) | `86.18% <100%> (+0.09%)` | :arrow_up: | | [.../scala/src/main/scala/whisk/core/entity/Exec.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWMuc2NhbGE=) | `84.27% <81.81%> (-0.14%)` | :arrow_down: | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-81.82%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-58.83%)` | :arrow_down: | | [...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | | [...src/main/scala/whisk/core/entity/Attachments.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0F0dGFjaG1lbnRzLnNjYWxh) | `88.88% <0%> (+5.55%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=footer). Last update [23e9268...8791b35](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes closed pull request #3924: Fix CacheConcurrencyTest cleanup.
markusthoemmes closed pull request #3924: Fix CacheConcurrencyTest cleanup.
URL: https://github.com/apache/incubator-openwhisk/pull/3924
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/tests/src/test/scala/whisk/core/database/test/CacheConcurrencyTests.scala
b/tests/src/test/scala/whisk/core/database/test/CacheConcurrencyTests.scala
index ec5a3e6c4d..095a84cc87 100644
--- a/tests/src/test/scala/whisk/core/database/test/CacheConcurrencyTests.scala
+++ b/tests/src/test/scala/whisk/core/database/test/CacheConcurrencyTests.scala
@@ -33,7 +33,7 @@ import whisk.common.TransactionId
import whisk.utils.retry
@RunWith(classOf[JUnitRunner])
-class CacheConcurrencyTests extends FlatSpec with WskTestHelpers with
WskActorSystem with BeforeAndAfterEach {
+class CacheConcurrencyTests extends FlatSpec with WskTestHelpers with
BeforeAndAfterEach with WskActorSystem {
println(s"Running tests on # proc:
${Runtime.getRuntime.availableProcessors()}")
@@ -45,8 +45,11 @@ class CacheConcurrencyTests extends FlatSpec with
WskTestHelpers with WskActorSy
val nInternalIters = 5
val nThreads = nInternalIters * 30
+ val externalPool = new ForkJoinPool(nThreads)
+ val internalPool = new ForkJoinPool(nThreads)
+
val parallel = (1 to nInternalIters).par
- parallel.tasksupport = new ForkJoinTaskSupport(new ForkJoinPool(nThreads))
+ parallel.tasksupport = new ForkJoinTaskSupport(externalPool)
def run[W](phase: String)(block: String => W) = parallel.map { i =>
val name = s"testy${i}"
@@ -65,6 +68,12 @@ class CacheConcurrencyTests extends FlatSpec with
WskTestHelpers with WskActorSy
}
}
+ override def afterAll() = {
+externalPool.shutdown()
+internalPool.shutdown()
+super.afterAll()
+ }
+
for (n <- 1 to nExternalIters)
"the cache" should s"support concurrent CRUD without bogus residual cache
entries, iter ${n}" in {
val actionFile = TestUtils.getTestActionFilename("empty.js")
@@ -80,7 +89,7 @@ class CacheConcurrencyTests extends FlatSpec with
WskTestHelpers with WskActorSy
run("delete+get") { name =>
// run 30 operations in parallel: 15 get, 1 delete, 14 more get
val para = (1 to 30).par
-para.tasksupport = new ForkJoinTaskSupport(new ForkJoinPool(nThreads))
+para.tasksupport = new ForkJoinTaskSupport(internalPool)
para.map { i =>
if (i != 16) {
val rr = wsk.action.get(name, expectedExitCode = DONTCARE_EXIT)
@@ -118,7 +127,7 @@ class CacheConcurrencyTests extends FlatSpec with
WskTestHelpers with WskActorSy
run("update+get") { name =>
// run 30 operations in parallel: 15 get, 1 update, 14 more get
val para = (1 to 30).par
-para.tasksupport = new ForkJoinTaskSupport(new ForkJoinPool(nThreads))
+para.tasksupport = new ForkJoinTaskSupport(internalPool)
para.map { i =>
if (i != 16) {
wsk.action.get(name)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on issue #3924: Fix CacheConcurrencyTest cleanup.
markusthoemmes commented on issue #3924: Fix CacheConcurrencyTest cleanup. URL: https://github.com/apache/incubator-openwhisk/pull/3924#issuecomment-410958811 Closing as wontfix for now. Bigger This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #3880: Modify that web action in the bound package can be accessed.
codecov-io edited a comment on issue #3880: Modify that web action in the bound package can be accessed. URL: https://github.com/apache/incubator-openwhisk/pull/3880#issuecomment-405214016 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3880?src=pr=h1) Report > Merging [#3880](https://codecov.io/gh/apache/incubator-openwhisk/pull/3880?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/23e926885afb75e6b8057ff191df6b175451a656?src=pr=desc) will **decrease** coverage by `4.68%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3880?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3880 +/- ## == - Coverage 85.44% 80.76% -4.69% == Files 146 146 Lines7058 7049 -9 Branches 423 421 -2 == - Hits 6031 5693 -338 - Misses 1027 1356 +329 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3880?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../main/scala/whisk/core/controller/WebActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3880/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9XZWJBY3Rpb25zLnNjYWxh) | `92.71% <100%> (+1.3%)` | :arrow_up: | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3880/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3880/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3880/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3880/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-81.82%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3880/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-58.83%)` | :arrow_down: | | [...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3880/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | | [...ain/scala/whisk/core/entitlement/Entitlement.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3880/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXRsZW1lbnQvRW50aXRsZW1lbnQuc2NhbGE=) | `87.71% <0%> (-2.64%)` | :arrow_down: | | [...cala/src/main/scala/whisk/http/ErrorResponse.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3880/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvRXJyb3JSZXNwb25zZS5zY2FsYQ==) | `93.18% <0%> (+1.13%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3880?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3880?src=pr=footer). Last update [23e9268...91ec9bc](https://codecov.io/gh/apache/incubator-openwhisk/pull/3880?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git
[GitHub] codecov-io commented on issue #3949: don't explicitly terminate actorSystem (let CoordinatedShutdown do it…
codecov-io commented on issue #3949: don't explicitly terminate actorSystem (let CoordinatedShutdown do it… URL: https://github.com/apache/incubator-openwhisk/pull/3949#issuecomment-410944548 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3949?src=pr=h1) Report > Merging [#3949](https://codecov.io/gh/apache/incubator-openwhisk/pull/3949?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/23e926885afb75e6b8057ff191df6b175451a656?src=pr=desc) will **decrease** coverage by `4.67%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3949?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3949 +/- ## == - Coverage 85.44% 80.77% -4.68% == Files 146 146 Lines7058 7057 -1 Branches 423 420 -3 == - Hits 6031 5700 -331 - Misses 1027 1357 +330 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3949?src=pr=tree) | Coverage Δ | | |---|---|---| | [...a/src/main/scala/whisk/http/BasicHttpService.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3949/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvQmFzaWNIdHRwU2VydmljZS5zY2FsYQ==) | `93.44% <ø> (+1.5%)` | :arrow_up: | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3949/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3949/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3949/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3949/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-81.82%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3949/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-58.83%)` | :arrow_down: | | [...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3949/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3949?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3949?src=pr=footer). Last update [23e9268...e39bbd6](https://codecov.io/gh/apache/incubator-openwhisk/pull/3949?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
