[GitHub] style95 commented on issue #3977: Elasticsearch Activation Store

2018-08-30 Thread GitBox 
style95 commented on issue #3977: Elasticsearch Activation Store
URL: 
https://github.com/apache/incubator-openwhisk/pull/3977#issuecomment-417527586
 
 
   @dubee Thanks for the clear answer.
   BTW, is there any reason that storing activation in ES is not included in 
this PR?
   Is it because of the performance?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah closed pull request #3955: Add an variable to set the timezone for all of components

2018-08-30 Thread GitBox 
rabbah closed pull request #3955: Add an variable to set the timezone for all 
of components
URL: https://github.com/apache/incubator-openwhisk/pull/3955
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ansible/README.md b/ansible/README.md
index d9e4a87ebe..b1fd2365fb 100644
--- a/ansible/README.md
+++ b/ansible/README.md
@@ -368,3 +368,6 @@ limits:
 - The `limits.concurrentInvocations` represents the maximum concurrent 
invocations allowed per namespace.
 - The `limits.firesPerMinute` represents the allowed namespace trigger firings 
per minute.
 - The `limits.sequenceMaxLength` represents the maximum length of a sequence 
action.
+
+ Set the timezone for containers
+The default timezone for all system containers is UTC. The timezone may differ 
from your servers which could make it difficult to inspect logs. The timezone 
is configured globally in [group_vars/all](./group_vars/all#L280) or by passing 
an extra variable `-e docker_timezone=xxx` when you run an ansible-playbook.
diff --git a/ansible/group_vars/all b/ansible/group_vars/all
index ffc658ba6a..ad7e441937 100644
--- a/ansible/group_vars/all
+++ b/ansible/group_vars/all
@@ -275,6 +275,7 @@ docker:
   pull:
 retries: 10
 delay: 10
+  timezone: "{{ docker_timezone | default('UTC') }}"
 
 sdk:
   dir:
diff --git a/ansible/roles/apigateway/tasks/deploy.yml 
b/ansible/roles/apigateway/tasks/deploy.yml
index ff1973b987..67af893d85 100644
--- a/ansible/roles/apigateway/tasks/deploy.yml
+++ b/ansible/roles/apigateway/tasks/deploy.yml
@@ -16,6 +16,7 @@
   "REDIS_PORT": "{{ redis.port }}"
   "PUBLIC_MANAGEDURL_HOST": "{{ ansible_host }}"
   "PUBLIC_MANAGEDURL_PORT": "{{ apigateway.port.mgmt }}"
+  "TZ": "{{ docker.timezone }}"
 ports:
   - "{{ apigateway.port.mgmt }}:8080"
   - "{{ apigateway.port.api }}:9000"
diff --git a/ansible/roles/controller/tasks/deploy.yml 
b/ansible/roles/controller/tasks/deploy.yml
index d7f4f59fe8..a34bb9b39b 100644
--- a/ansible/roles/controller/tasks/deploy.yml
+++ b/ansible/roles/controller/tasks/deploy.yml
@@ -124,6 +124,7 @@
   "JMX_REMOTE": "{{ jmx.enabled }}"
 
   "PORT": 8080
+  "TZ": "{{ docker.timezone }}"
 
   "CONFIG_whisk_info_date": "{{ whisk.version.date }}"
   "CONFIG_whisk_info_buildNo": "{{ docker.image.tag }}"
diff --git a/ansible/roles/couchdb/tasks/deploy.yml 
b/ansible/roles/couchdb/tasks/deploy.yml
index 0bf5170919..2e3f640319 100644
--- a/ansible/roles/couchdb/tasks/deploy.yml
+++ b/ansible/roles/couchdb/tasks/deploy.yml
@@ -53,6 +53,7 @@
   COUCHDB_USER: "{{ db.credentials.admin.user }}"
   COUCHDB_PASSWORD: "{{ db.credentials.admin.pass }}"
   NODENAME: "{{ ansible_host }}"
+  TZ: "{{ docker.timezone }}"
 pull: "{{ couchdb.pull_couchdb | default(true) }}"
 
 - name: wait until CouchDB in this host is up and running
diff --git a/ansible/roles/invoker/tasks/deploy.yml 
b/ansible/roles/invoker/tasks/deploy.yml
index ba17b70ef4..706d5dcf7e 100644
--- a/ansible/roles/invoker/tasks/deploy.yml
+++ b/ansible/roles/invoker/tasks/deploy.yml
@@ -168,6 +168,7 @@
   "INVOKER_OPTS": "{{ invoker_args | default(invoker.arguments) }}"
   "JMX_REMOTE": "{{ jmx.enabled }}"
   "PORT": 8080
+  "TZ": "{{ docker.timezone }}"
   "KAFKA_HOSTS": "{{ kafka_connect_string }}"
   "CONFIG_whisk_kafka_replicationFactor": "{{ kafka.replicationFactor | 
default() }}"
   "CONFIG_whisk_kafka_topics_invoker_retentionBytes": "{{ 
kafka_topics_invoker_retentionBytes | default() }}"
diff --git a/ansible/roles/kafka/tasks/deploy.yml 
b/ansible/roles/kafka/tasks/deploy.yml
index b758c76341..f32948886a 100644
--- a/ansible/roles/kafka/tasks/deploy.yml
+++ b/ansible/roles/kafka/tasks/deploy.yml
@@ -25,6 +25,7 @@
   "KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR": "{{ 
kafka.offsetsTopicReplicationFactor }}"
   "KAFKA_AUTO_CREATE_TOPICS_ENABLE": "false"
   "KAFKA_NUM_NETWORK_THREADS": "{{ kafka.networkThreads }}"
+  "TZ": "{{ docker.timezone }}"
 
 - name: add kafka non-ssl vars
   when: kafka.protocol != 'SSL'
diff --git a/ansible/roles/nginx/tasks/deploy.yml 
b/ansible/roles/nginx/tasks/deploy.yml
index 281205160f..490f28972a 100644
--- a/ansible/roles/nginx/tasks/deploy.yml
+++ b/ansible/roles/nginx/tasks/deploy.yml
@@ -69,3 +69,5 @@
   - "{{ nginx.port.http }}:80"
   - "{{ nginx.port.api }}:443"
   - "{{ nginx.port.adminportal }}:8443"
+env:
+  TZ: "{{ docker.timezone }}"
diff --git a/ansible/roles/redis/tasks/deploy.yml 
b/ansible/roles/redis/tasks/deploy.yml
index 31b47e6a08..9110f43758 100644
--- a/ansible/roles/redis/tasks/deploy.yml
+++ b/ansible/roles/redis/tasks/deploy.yml
@@ -19,6 +19,8 @@
 restart_policy: "{{ docker.restart.policy }}"
 ports:
   -

[GitHub] codecov-io edited a comment on issue #3955: Add an variable to set the timezone for all of components

2018-08-30 Thread GitBox 
codecov-io edited a comment on issue #3955: Add an variable to set the timezone 
for all of components
URL: 
https://github.com/apache/incubator-openwhisk/pull/3955#issuecomment-411667536
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955?src=pr=h1)
 Report
   > Merging 
[#3955](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/fcd0e4b5bf4faf8a99f42868a898fa4e17616ec1?src=pr=desc)
 will **increase** coverage by `20.42%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955/graphs/tree.svg?width=650=l0YmsiSAso=150=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#3955   +/-   ##
   ===
   + Coverage   60.71%   81.14%   +20.42% 
   ===
 Files 146  146   
 Lines7095 7095   
 Branches  443  443   
   ===
   + Hits 4308 5757 +1449 
   + Misses   2787 1338 -1449
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[.../src/main/scala/whisk/core/entity/EntityPath.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0VudGl0eVBhdGguc2NhbGE=)
 | `100% <0%> (+1.88%)` | :arrow_up: |
   | 
[...isk/core/controller/actions/PrimitiveActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1ByaW1pdGl2ZUFjdGlvbnMuc2NhbGE=)
 | `89.62% <0%> (+2.22%)` | :arrow_up: |
   | 
[...a/src/main/scala/whisk/core/entity/Parameter.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1BhcmFtZXRlci5zY2FsYQ==)
 | `95.34% <0%> (+2.32%)` | :arrow_up: |
   | 
[...hisk/core/controller/actions/SequenceActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1NlcXVlbmNlQWN0aW9ucy5zY2FsYQ==)
 | `94.49% <0%> (+3.66%)` | :arrow_up: |
   | 
[...a/whisk/core/loadBalancer/InvokerSupervision.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL0ludm9rZXJTdXBlcnZpc2lvbi5zY2FsYQ==)
 | `95.58% <0%> (+3.67%)` | :arrow_up: |
   | 
[.../src/main/scala/whisk/core/connector/Message.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2Uuc2NhbGE=)
 | `35.29% <0%> (+3.92%)` | :arrow_up: |
   | 
[...tainerpool/docker/DockerClientWithFileAccess.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9kb2NrZXIvRG9ja2VyQ2xpZW50V2l0aEZpbGVBY2Nlc3Muc2NhbGE=)
 | `96% <0%> (+4%)` | :arrow_up: |
   | 
[...n/scala/whisk/core/connector/MessageConsumer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2VDb25zdW1lci5zY2FsYQ==)
 | `87.67% <0%> (+4.1%)` | :arrow_up: |
   | 
[...rc/main/scala/whisk/core/entity/ExecManifest.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWNNYW5pZmVzdC5zY2FsYQ==)
 | `97.87% <0%> (+4.25%)` | :arrow_up: |
   | 
[.../scala/whisk/core/database/CouchDbRestClient.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQ291Y2hEYlJlc3RDbGllbnQuc2NhbGE=)
 | `87.23% <0%> (+4.25%)` | :arrow_up: |
   | ... and [80 
more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955?src=pr=footer).
 Last update 
[fcd0e4b...53d5007](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955?src=pr=lastupdated).
 Read the [comment

[GitHub] rabbah commented on a change in pull request #3955: Add an variable to set the timezone for all of components

2018-08-30 Thread GitBox 
rabbah commented on a change in pull request #3955: Add an variable to set the 
timezone for all of components
URL: 
https://github.com/apache/incubator-openwhisk/pull/3955#discussion_r214210243
 
 

 ##
 File path: ansible/README.md
 ##
 @@ -359,3 +359,6 @@ limits:
 - The `limits.concurrentInvocations` represents the maximum concurrent 
invocations allowed per namespace.
 - The `limits.firesPerMinute` represents the allowed namespace trigger firings 
per minute.
 - The `limits.sequenceMaxLength` represents the maximum length of a sequence 
action.
+
+ Set the timezone for containers
+The default timezone for all system containers is UTC. The timezone may differ 
from your servers which could make it difficult to inspect logs. The timezone 
is configured globally in [group_vars/all](./group_vars/all#L280) or by passing 
an extra variable -e docker_timzone=xxx when you run an ansible-playbook.
 
 Review comment:
   typo: `-e docker_timzone=xxx` should be `-e docker_timezone=xxx` also use 
back ticks. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #3955: Add an variable to set the timezone for all of components

2018-08-30 Thread GitBox 
rabbah commented on issue #3955: Add an variable to set the timezone for all of 
components
URL: 
https://github.com/apache/incubator-openwhisk/pull/3955#issuecomment-417499979
 
 
   @csantanapr good now?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai opened a new pull request #973: Improving Usage message

2018-08-30 Thread GitBox 
pritidesai opened a new pull request #973: Improving Usage message
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/973
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Jbalkind commented on issue #3428: Broken resolvers config in apigateway container

2018-08-30 Thread GitBox 
Jbalkind commented on issue #3428: Broken resolvers config in apigateway 
container
URL: 
https://github.com/apache/incubator-openwhisk/issues/3428#issuecomment-417467503
 
 
   The most recent apigateway fixes this (as of commit 
2b873660d1931d504b9e17405fb99630533be6da ) but this repository has not been 
updated to point to a newer docker file for the apigateway.
   
   This can be fixed by changing `version` for apigateway in 
`ansible/group_vars/all` (see 
[here](https://github.com/apache/incubator-openwhisk/blob/master/ansible/group_vars/all#L251))
 to either `0.9.12` or `latest`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Jbalkind removed a comment on issue #3428: Broken resolvers config in apigateway container

2018-08-30 Thread GitBox 
Jbalkind removed a comment on issue #3428: Broken resolvers config in 
apigateway container
URL: 
https://github.com/apache/incubator-openwhisk/issues/3428#issuecomment-417414749
 
 
   Actually looking on the most recent apigateway, this has been fixed (edit: 
as of commit 2b873660d1931d504b9e17405fb99630533be6da ). My system was pointed 
to the old commit. It should be possible to close this now, I think.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io edited a comment on issue #3991: Provide Artifact with File Storage Activation Store

2018-08-30 Thread GitBox 
codecov-io edited a comment on issue #3991: Provide Artifact with File Storage 
Activation Store
URL: 
https://github.com/apache/incubator-openwhisk/pull/3991#issuecomment-416686553
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3991?src=pr=h1)
 Report
   > Merging 
[#3991](https://codecov.io/gh/apache/incubator-openwhisk/pull/3991?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/fcd0e4b5bf4faf8a99f42868a898fa4e17616ec1?src=pr=desc)
 will **increase** coverage by `19.81%`.
   > The diff coverage is `10%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3991/graphs/tree.svg?width=650=l0YmsiSAso=150=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3991?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#3991   +/-   ##
   ===
   + Coverage   60.71%   80.53%   +19.81% 
   ===
 Files 146  148+2 
 Lines7095 7151   +56 
 Branches  443  434-9 
   ===
   + Hits 4308 5759 +1451 
   + Misses   2787 1392 -1395
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3991?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...la/whisk/core/database/ActivationFileStorage.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3991/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQWN0aXZhdGlvbkZpbGVTdG9yYWdlLnNjYWxh)
 | `0% <0%> (ø)` | |
   | 
[...abase/ArtifactWithFileStorageActivationStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3991/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQXJ0aWZhY3RXaXRoRmlsZVN0b3JhZ2VBY3RpdmF0aW9uU3RvcmUuc2NhbGE=)
 | `0% <0%> (ø)` | |
   | 
[.../scala/src/main/scala/whisk/core/WhiskConfig.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3991/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvV2hpc2tDb25maWcuc2NhbGE=)
 | `94.26% <100%> (+0.09%)` | :arrow_up: |
   | 
[...src/main/scala/whisk/core/controller/Actions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3991/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9BY3Rpb25zLnNjYWxh)
 | `92.96% <100%> (+13.56%)` | :arrow_up: |
   | 
[...main/scala/whisk/core/controller/Activations.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3991/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9BY3RpdmF0aW9ucy5zY2FsYQ==)
 | `96.66% <100%> (+16.66%)` | :arrow_up: |
   | 
[...main/scala/whisk/core/entity/WhiskActivation.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3991/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1doaXNrQWN0aXZhdGlvbi5zY2FsYQ==)
 | `88.7% <20%> (+23.19%)` | :arrow_up: |
   | 
[.../src/main/scala/whisk/core/entity/EntityPath.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3991/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0VudGl0eVBhdGguc2NhbGE=)
 | `100% <0%> (+1.88%)` | :arrow_up: |
   | 
[...isk/core/controller/actions/PrimitiveActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3991/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1ByaW1pdGl2ZUFjdGlvbnMuc2NhbGE=)
 | `89.62% <0%> (+2.22%)` | :arrow_up: |
   | ... and [88 
more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3991/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3991?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3991?src=pr=footer).
 Last update 
[fcd0e4b...5e9ddd1](https://codecov.io/gh/apache/incubator-openwhisk/pull/3991?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Jbalkind edited a comment on issue #3428: Broken resolvers config in apigateway container

2018-08-30 Thread GitBox 
Jbalkind edited a comment on issue #3428: Broken resolvers config in apigateway 
container
URL: 
https://github.com/apache/incubator-openwhisk/issues/3428#issuecomment-417414749
 
 
   Actually looking on the most recent apigateway, this has been fixed (edit: 
as of commit 2b873660d1931d504b9e17405fb99630533be6da ). My system was pointed 
to the old commit. It should be possible to close this now, I think.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Jbalkind edited a comment on issue #3428: Broken resolvers config in apigateway container

2018-08-30 Thread GitBox 
Jbalkind edited a comment on issue #3428: Broken resolvers config in apigateway 
container
URL: 
https://github.com/apache/incubator-openwhisk/issues/3428#issuecomment-417414749
 
 
   Actually looking on the most recent apigateway, this has been fixed (edit: 
as of commit 2b873660d1931d504b9e17405fb99630533be6da). My system was pointed 
to the old commit. It should be possible to close this now, I think.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows commented on issue #235: Add Swift Runtime for 1.12.0

2018-08-30 Thread GitBox 
mrutkows commented on issue #235: Add Swift Runtime for 1.12.0
URL: 
https://github.com/apache/incubator-openwhisk-release/pull/235#issuecomment-417427701
 
 
   @houshengbo @pritidesai thanks for working together to move the runtimes 
forward to have the same baseline.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows commented on issue #236: Modify the version to 1.12.0 for runtimes

2018-08-30 Thread GitBox 
mrutkows commented on issue #236: Modify the version to 1.12.0 for runtimes
URL: 
https://github.com/apache/incubator-openwhisk-release/pull/236#issuecomment-417427050
 
 
   @houshengbo @daisy-ycguo thanks for keeping moving forward the releases of 
the runtimes!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Jbalkind commented on issue #3428: Broken resolvers config in apigateway container

2018-08-30 Thread GitBox 
Jbalkind commented on issue #3428: Broken resolvers config in apigateway 
container
URL: 
https://github.com/apache/incubator-openwhisk/issues/3428#issuecomment-417414749
 
 
   Actually looking on the most recent apigateway, this has been fixed. My 
system was pointed to the old commit. It should be possible to close this now, 
I think.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Jbalkind commented on issue #3428: Broken resolvers config in apigateway container

2018-08-30 Thread GitBox 
Jbalkind commented on issue #3428: Broken resolvers config in apigateway 
container
URL: 
https://github.com/apache/incubator-openwhisk/issues/3428#issuecomment-417413707
 
 
   I have been seeing this same problem, running OpenWhisk in an Ubuntu 18.04 
VM in Qemu. I figured out what's happening and it's not upstream alpine's fault.
   
   The `/etc/api-gateway/conf.d/includes/resolvers.conf` file is creaetd by the 
incubator-openwhisk-apigateway `init.sh` script, in particular the following 
line ([see 
inline](https://github.com/apache/incubator-openwhisk-apigateway/blob/master/init.sh#L58)):
   
   ```
   echo resolver $(awk 'BEGIN{ORS=" "} /nameserver/{print $2}' /etc/resolv.conf 
| sed "s/ $/;/g") > /etc/api-gateway/conf.d/includes/resolvers.conf
   ```
   
   At the face of it, this seems correct. The problem is that there are 
comments at the start of the file. They look like this on my system:
   
   ```
   # Dynamic resolv.conf(5) file for glibc resolver(3) generated by 
resolvconf(8)
   # DO NOT EDIT THIS FILE BY HAND -- YOUR CHANGES WILL BE OVERWRITTEN
   # 127.0.0.53 is the systemd-resolved stub resolver.
   # run "systemd-resolve --status" to see details about the actual nameservers.
   ```
   
   The last line of the comment matches the awk command as it contains 
`nameserver`. Then, as the awk command says, it prints the 2nd token on the 
line, which is the word `run`.
   
   This can be simply solved by changing the awk command to:
   ```
   awk 'BEGIN{ORS=" "} /^nameserver/{print $2}' /etc/resolv.conf
   ```
   or, for something more robust (in case there's space before `nameserver`), 
you could go for:
   ```
   awk 'BEGIN{ORS=" "} /^[[:space:]]*nameserver/{print $2}' /etc/resolv.conf
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubee commented on issue #3977: Elasticsearch Activation Store

2018-08-30 Thread GitBox 
dubee commented on issue #3977: Elasticsearch Activation Store
URL: 
https://github.com/apache/incubator-openwhisk/pull/3977#issuecomment-417381800
 
 
   @style95, these changes will write activations to file and will allow the 
activation API in OpenWhisk to fetch activations from Elasticsearch. Changes 
not included here are the need for setting up Elasticsearch and a forwarder 
that passes the activations stored in files to Elasticsearch.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] philwinder closed issue #291: How should I connect to nginx apiserver gateway using kubectl proxy?

2018-08-30 Thread GitBox 
philwinder closed issue #291: How should I connect to nginx apiserver gateway 
using kubectl proxy?
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/291
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io edited a comment on issue #3814: wskadmin scala db command to export and import

2018-08-30 Thread GitBox 
codecov-io edited a comment on issue #3814: wskadmin scala db command to export 
and import
URL: 
https://github.com/apache/incubator-openwhisk/pull/3814#issuecomment-400666862
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814?src=pr=h1)
 Report
   > Merging 
[#3814](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/fcd0e4b5bf4faf8a99f42868a898fa4e17616ec1?src=pr=desc)
 will **increase** coverage by `19.62%`.
   > The diff coverage is `57.37%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814/graphs/tree.svg?width=650=l0YmsiSAso=150=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#3814   +/-   ##
   ===
   + Coverage   60.71%   80.34%   +19.62% 
   ===
 Files 146  149+3 
 Lines7095 7345  +250 
 Branches  443  458   +15 
   ===
   + Hits 4308 5901 +1593 
   + Misses   2787 1444 -1343
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...rc/main/scala/whisk/core/cli/CommandMessages.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814/diff?src=pr=tree#diff-dG9vbHMvYWRtaW4vc3JjL21haW4vc2NhbGEvd2hpc2svY29yZS9jbGkvQ29tbWFuZE1lc3NhZ2VzLnNjYWxh)
 | `82.6% <40%> (+82.6%)` | :arrow_up: |
   | 
[...src/main/scala/whisk/core/cli/ProgressTicker.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814/diff?src=pr=tree#diff-dG9vbHMvYWRtaW4vc3JjL21haW4vc2NhbGEvd2hpc2svY29yZS9jbGkvUHJvZ3Jlc3NUaWNrZXIuc2NhbGE=)
 | `5% <5%> (ø)` | |
   | 
[...ols/admin/src/main/scala/whisk/core/cli/Main.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814/diff?src=pr=tree#diff-dG9vbHMvYWRtaW4vc3JjL21haW4vc2NhbGEvd2hpc2svY29yZS9jbGkvTWFpbi5zY2FsYQ==)
 | `27.84% <60%> (+27.84%)` | :arrow_up: |
   | 
[...isk/core/database/memory/MemoryArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvbWVtb3J5L01lbW9yeUFydGlmYWN0U3RvcmUuc2NhbGE=)
 | `97.61% <66.66%> (+97.61%)` | :arrow_up: |
   | 
[...la/whisk/core/database/CouchDBStreamingStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814/diff?src=pr=tree#diff-dG9vbHMvYWRtaW4vc3JjL21haW4vc2NhbGEvd2hpc2svY29yZS9kYXRhYmFzZS9Db3VjaERCU3RyZWFtaW5nU3RvcmUuc2NhbGE=)
 | `82.14% <82.14%> (ø)` | |
   | 
[...src/main/scala/whisk/core/database/DbCommand.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814/diff?src=pr=tree#diff-dG9vbHMvYWRtaW4vc3JjL21haW4vc2NhbGEvd2hpc2svY29yZS9kYXRhYmFzZS9EYkNvbW1hbmQuc2NhbGE=)
 | `84.73% <84.73%> (ø)` | |
   | ... and [90 
more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814?src=pr=footer).
 Last update 
[fcd0e4b...030af00](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] style95 commented on issue #3977: Elasticsearch Activation Store

2018-08-30 Thread GitBox 
style95 commented on issue #3977: Elasticsearch Activation Store
URL: 
https://github.com/apache/incubator-openwhisk/pull/3977#issuecomment-417251260
 
 
   Hey @dubee 
   Is this supposed to store all activations in Elasticsearch?
   As I remember your email, since we can configure ActivationStore in 
controller and invoker separately, you will work on this item to store and 
retrieve activations in/from ES in both controllers and invokers.
   
   If yes, this is the one I really need. :)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sandeep-paliwal opened a new pull request #163: Added support for Azure cosmosDB for alarms package

2018-08-30 Thread GitBox 
sandeep-paliwal opened a new pull request #163: Added support for Azure 
cosmosDB for alarms package
URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/163
 
 
   Added support for alarms package to use cosmos DB.
   All database interactions will now go through database.js which in turn will 
delegate to actual DB implementations (couchdb or cosmosdb) based on dbType. 
   There are some TODO comments and need to get better understanding on those.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] markusthoemmes commented on issue #3994: Optionally return a small portion of user logs for blocking invocations

2018-08-30 Thread GitBox 
markusthoemmes commented on issue #3994: Optionally return a small portion of 
user logs for blocking invocations
URL: 
https://github.com/apache/incubator-openwhisk/pull/3994#issuecomment-417207436
 
 
   I'd also like this to get to the dev-list first! There has been partial 
agreement on the need of ripping log processing out of the invoker entirely for 
various reasons. That will render this entirely defunct. It's unclear to me how 
this change fits into changes discussed on the dev-list (either regarding 
concurrent activation processing, logging in general or a general architectural 
overhaul)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services