date:20181019

[GitHub] dgrove-oss opened a new pull request #318: proper configuration of couchdb as a single node cluster

2018-10-19 Thread GitBox

dgrove-oss opened a new pull request #318: proper configuration of couchdb as a 
single node cluster
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/318
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jasonpet commented on issue #163: Added support for Azure cosmosDB for alarms package

2018-10-19 Thread GitBox

jasonpet commented on issue #163: Added support for Azure cosmosDB for alarms 
package
URL: 
https://github.com/apache/incubator-openwhisk-package-alarms/pull/163#issuecomment-431477539
 
 
   @sandeep-paliwal I also see some alarms functionality that exists with 
couchdb that was not made available with cosmosDB as part of this PR:
   -  The internal monitoring/health code that creates and deletes trigger db 
entries found in provider/lib/health.js 
   -  The trigger feed cleanup that occurs for the fire once alarm when the 
deleteAfterFire param is not set to false (see the handleFiredTriggers function 
in provider/lib/utils.js)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io edited a comment on issue #4073: Rename the package of controller and invoker

2018-10-19 Thread GitBox

codecov-io edited a comment on issue #4073: Rename the package of controller 
and invoker
URL: 
https://github.com/apache/incubator-openwhisk/pull/4073#issuecomment-431422409
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073?src=pr=h1)
 Report
   > Merging 
[#4073](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/0d6c01793af8245965aae96296b385791512fe06?src=pr=desc)
 will **decrease** coverage by `4.93%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/graphs/tree.svg?width=650=l0YmsiSAso=150=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4073  +/-   ##
   ==
   - Coverage   86.01%   81.08%   -4.94% 
   ==
 Files 147  147  
 Lines7180 7180  
 Branches  445  445  
   ==
   - Hits 6176 5822 -354 
   - Misses   1004 1358 +354
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...che/openwhisk/core/connector/MessageConsumer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2VDb25zdW1lci5zY2FsYQ==)
 | `87.67% <ø> (ø)` | |
   | 
[...org/apache/openwhisk/core/entity/MemoryLimit.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L01lbW9yeUxpbWl0LnNjYWxh)
 | `93.33% <ø> (ø)` | |
   | 
[...scala/org/apache/openwhisk/utils/TimeHelpers.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL3V0aWxzL1RpbWVIZWxwZXJzLnNjYWxh)
 | `50% <ø> (ø)` | |
   | 
[...openwhisk/common/tracing/OpenTracingProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi90cmFjaW5nL09wZW5UcmFjaW5nUHJvdmlkZXIuc2NhbGE=)
 | `21.15% <ø> (ø)` | |
   | 
[...apache/openwhisk/core/controller/Activations.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udHJvbGxlci9BY3RpdmF0aW9ucy5zY2FsYQ==)
 | `96.66% <ø> (ø)` | |
   | 
[.../scala/org/apache/openwhisk/core/entity/UUID.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1VVSUQuc2NhbGE=)
 | `90.9% <ø> (ø)` | |
   | 
[...cala/org/apache/openwhisk/core/entity/SemVer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1NlbVZlci5zY2FsYQ==)
 | `95.83% <ø> (ø)` | |
   | 
[...e/loadBalancer/ShardingContainerPoolBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvbG9hZEJhbGFuY2VyL1NoYXJkaW5nQ29udGFpbmVyUG9vbEJhbGFuY2VyLnNjYWxh)
 | `84.21% <ø> (ø)` | |
   | 
[...a/org/apache/openwhisk/core/entity/WhiskAuth.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1doaXNrQXV0aC5zY2FsYQ==)
 | `100% <ø> (ø)` | |
   | 
[...openwhisk/core/entitlement/PackageCollection.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXRsZW1lbnQvUGFja2FnZUNvbGxlY3Rpb24uc2NhbGE=)
 | `100% <ø> (ø)` | |
   | ... and [148 
more](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073?src=pr=footer).
 Last update 
[0d6c017...046e34f](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

[GitHub] jasonpet commented on issue #163: Added support for Azure cosmosDB for alarms package

2018-10-19 Thread GitBox

jasonpet commented on issue #163: Added support for Azure cosmosDB for alarms 
package
URL: 
https://github.com/apache/incubator-openwhisk-package-alarms/pull/163#issuecomment-431461518
 
 
   @sandeep-paliwal  Please run all tests to verify it works once you fix this 
issue.  The getDatabase function in alarmWebAction needs to be a promise that 
you wait on when you call it.  You are returning the database but only after 
you wait on the initDB.  The call to getDatabase right before you try to 
getWorkerID is undefined because you are not waiting on it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dailyworker opened a new issue #27: it doesn't work with python3??

2018-10-19 Thread GitBox

dailyworker opened a new issue #27: it doesn't work with python3??
URL: https://github.com/apache/incubator-openwhisk-tutorial/issues/27
 
 
   ## Environment details:
   * local deployment, Mac OS 10.14 (Mojave)
   * Docker version 18.06.1-ce
  Docker-compose version 1.22.0
  Using pyenv 1.2.7 & pyenv python 3.6.5
   
   I took a git clone of the report to use the OpenWisk-Tutorial and then ran 
the "pip install -r requirements.txt" as shown on README.md
   but error was shown below
   
   > from unipath.abstractpath import AbstractPath
 File 
"/Users/dailyworker/.pyenv/versions/3.6.5/Python.framework/Versions/3.6/lib/python3.6/site-packages/unipath/abstractpath.py",
 line 20, in 
   _base = os.path.supports_unicode_filenames and unicode or str
   NameError: name 'unicode' is not defined
   
   and then, I've identified a stack overflow answer to a similar error to mine.
   [https://stackoverflow.com/a/36110612](url)
   
   So I solved this problem by changing the Python version of the 
toturial-folder to 2.7.15 using pyenv. 
   Don't you have any plans to apply for Python 3 on this tutorial?
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jasonpet commented on issue #163: Added support for Azure cosmosDB for alarms package

2018-10-19 Thread GitBox

jasonpet commented on issue #163: Added support for Azure cosmosDB for alarms 
package
URL: 
https://github.com/apache/incubator-openwhisk-package-alarms/pull/163#issuecomment-431450448
 
 
   @sandeep-paliwal - have you tested this with couchdb?  fails for me 
   ```
   "namespace": "whisk.system",
   "name": "alarmWebAction",
   "version": "0.0.2",
   "subject": "whisk.system",
   "activationId": "5d9dfa5f98cb4f629dfa5f98cb2f6232",
   "start": 1539971896476,
   "end": 1539971896495,
   "duration": 19,
   "response": {
   "status": "application error",
   "statusCode": 0,
   "success": false,
   "result": {
   "error": {
   "message": "Cannot read property 'getWorkerID' of undefined",
   "stack": "TypeError: Cannot read property 'getWorkerID' of 
undefined\nat common.verifyTriggerAuth.then 
(/nodejsAction/dUGHWGoL/alarmWebAction.js:135:26)\nat process._tickCallback 
(internal/process/next_tick.js:109:7)"
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jasonpet closed pull request #164: added checksum verification for https://deb.nodesource.com/setup_8.x

2018-10-19 Thread GitBox

jasonpet closed pull request #164: added checksum verification for 
https://deb.nodesource.com/setup_8.x
URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/164
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/Dockerfile b/Dockerfile
index f823a5f..94e8cbf 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,6 +1,7 @@
 FROM ubuntu:14.04
 
 ENV DEBIAN_FRONTEND noninteractive
+ENV NODE_SETUP_DOWNLOAD_SHA 
30084249bdd56119cb61be682a56829a11a4c94e21c5d005d326dedb66776104
 
 # Initial update and some basics.
 # This odd double update seems necessary to get curl to download without 404 
errors.
@@ -10,7 +11,10 @@ RUN apt-get update --fix-missing && \
   apt-get install -y curl && \
   apt-get update && \
   apt-get remove -y nodejs && \
-  curl -sL https://deb.nodesource.com/setup_8.x | bash - && \
+  curl -sL https://deb.nodesource.com/setup_8.x -o setup_8.x && \ 
+  echo "${NODE_SETUP_DOWNLOAD_SHA}  setup_8.x" | sha256sum -c - && \
+  cat setup_8.x | bash - && \
+  rm setup_8.x && \
   apt-get install -y nodejs
 
 # only package.json


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io edited a comment on issue #4073: Rename the package of controller and invoker

2018-10-19 Thread GitBox

codecov-io edited a comment on issue #4073: Rename the package of controller 
and invoker
URL: 
https://github.com/apache/incubator-openwhisk/pull/4073#issuecomment-431422409
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073?src=pr=h1)
 Report
   > Merging 
[#4073](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/0d6c01793af8245965aae96296b385791512fe06?src=pr=desc)
 will **decrease** coverage by `50.34%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/graphs/tree.svg?width=650=l0YmsiSAso=150=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#4073   +/-   ##
   ===
   - Coverage   86.01%   35.66%   -50.35% 
   ===
 Files 147  147   
 Lines7180 7180   
 Branches  445  445   
   ===
   - Hits 6176 2561 -3615 
   - Misses   1004 4619 +3615
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...che/openwhisk/core/connector/MessageConsumer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2VDb25zdW1lci5zY2FsYQ==)
 | `69.86% <ø> (ø)` | |
   | 
[...org/apache/openwhisk/core/entity/MemoryLimit.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L01lbW9yeUxpbWl0LnNjYWxh)
 | `86.66% <ø> (ø)` | |
   | 
[...scala/org/apache/openwhisk/utils/TimeHelpers.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL3V0aWxzL1RpbWVIZWxwZXJzLnNjYWxh)
 | `50% <ø> (ø)` | |
   | 
[...openwhisk/common/tracing/OpenTracingProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi90cmFjaW5nL09wZW5UcmFjaW5nUHJvdmlkZXIuc2NhbGE=)
 | `17.3% <ø> (ø)` | |
   | 
[...apache/openwhisk/core/controller/Activations.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udHJvbGxlci9BY3RpdmF0aW9ucy5zY2FsYQ==)
 | `6.66% <ø> (ø)` | |
   | 
[.../scala/org/apache/openwhisk/core/entity/UUID.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1VVSUQuc2NhbGE=)
 | `90.9% <ø> (ø)` | |
   | 
[...cala/org/apache/openwhisk/core/entity/SemVer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1NlbVZlci5zY2FsYQ==)
 | `79.16% <ø> (ø)` | |
   | 
[...e/loadBalancer/ShardingContainerPoolBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvbG9hZEJhbGFuY2VyL1NoYXJkaW5nQ29udGFpbmVyUG9vbEJhbGFuY2VyLnNjYWxh)
 | `48.94% <ø> (ø)` | |
   | 
[...a/org/apache/openwhisk/core/entity/WhiskAuth.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1doaXNrQXV0aC5zY2FsYQ==)
 | `25% <ø> (ø)` | |
   | 
[...openwhisk/core/entitlement/PackageCollection.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXRsZW1lbnQvUGFja2FnZUNvbGxlY3Rpb24uc2NhbGE=)
 | `88.88% <ø> (ø)` | |
   | ... and [259 
more](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073?src=pr=footer).
 Last update 
[0d6c017...c58f25c](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

[GitHub] codecov-io commented on issue #4073: Rename the package of controller and invoker

2018-10-19 Thread GitBox

codecov-io commented on issue #4073: Rename the package of controller and 
invoker
URL: 
https://github.com/apache/incubator-openwhisk/pull/4073#issuecomment-431422409
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073?src=pr=h1)
 Report
   > Merging 
[#4073](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/0d6c01793af8245965aae96296b385791512fe06?src=pr=desc)
 will **decrease** coverage by `50.34%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/graphs/tree.svg?width=650=l0YmsiSAso=150=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#4073   +/-   ##
   ===
   - Coverage   86.01%   35.66%   -50.35% 
   ===
 Files 147  147   
 Lines7180 7180   
 Branches  445  445   
   ===
   - Hits 6176 2561 -3615 
   - Misses   1004 4619 +3615
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...che/openwhisk/core/connector/MessageConsumer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2VDb25zdW1lci5zY2FsYQ==)
 | `69.86% <ø> (ø)` | |
   | 
[...org/apache/openwhisk/core/entity/MemoryLimit.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L01lbW9yeUxpbWl0LnNjYWxh)
 | `86.66% <ø> (ø)` | |
   | 
[...scala/org/apache/openwhisk/utils/TimeHelpers.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL3V0aWxzL1RpbWVIZWxwZXJzLnNjYWxh)
 | `50% <ø> (ø)` | |
   | 
[...openwhisk/common/tracing/OpenTracingProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi90cmFjaW5nL09wZW5UcmFjaW5nUHJvdmlkZXIuc2NhbGE=)
 | `17.3% <ø> (ø)` | |
   | 
[...apache/openwhisk/core/controller/Activations.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udHJvbGxlci9BY3RpdmF0aW9ucy5zY2FsYQ==)
 | `6.66% <ø> (ø)` | |
   | 
[.../scala/org/apache/openwhisk/core/entity/UUID.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1VVSUQuc2NhbGE=)
 | `90.9% <ø> (ø)` | |
   | 
[...cala/org/apache/openwhisk/core/entity/SemVer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1NlbVZlci5zY2FsYQ==)
 | `79.16% <ø> (ø)` | |
   | 
[...e/loadBalancer/ShardingContainerPoolBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvbG9hZEJhbGFuY2VyL1NoYXJkaW5nQ29udGFpbmVyUG9vbEJhbGFuY2VyLnNjYWxh)
 | `48.94% <ø> (ø)` | |
   | 
[...a/org/apache/openwhisk/core/entity/WhiskAuth.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1doaXNrQXV0aC5zY2FsYQ==)
 | `25% <ø> (ø)` | |
   | 
[...openwhisk/core/entitlement/PackageCollection.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXRsZW1lbnQvUGFja2FnZUNvbGxlY3Rpb24uc2NhbGE=)
 | `88.88% <ø> (ø)` | |
   | ... and [259 
more](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073?src=pr=footer).
 Last update 
[0d6c017...e309b6b](https://codecov.io/gh/apache/incubator-openwhisk/pull/4073?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

[GitHub] codecov-io edited a comment on issue #4062: Switch to Scala 2.12.7

2018-10-19 Thread GitBox

codecov-io edited a comment on issue #4062: Switch to Scala 2.12.7
URL: 
https://github.com/apache/incubator-openwhisk/pull/4062#issuecomment-428823053
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4062?src=pr=h1)
 Report
   > Merging 
[#4062](https://codecov.io/gh/apache/incubator-openwhisk/pull/4062?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/c8054fa067ea0fbe9f18c96f738618f5da548fe0?src=pr=desc)
 will **decrease** coverage by `4.92%`.
   > The diff coverage is `78.94%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/4062/graphs/tree.svg?width=650=l0YmsiSAso=150=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/4062?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4062  +/-   ##
   ==
   - Coverage  86%   81.07%   -4.93% 
   ==
 Files 147  147  
 Lines7180 7043 -137 
 Branches  445  443   -2 
   ==
   - Hits 6175 5710 -465 
   - Misses   1005 1333 +328
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/4062?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...scala/whisk/core/mesos/MesosContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4062/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbWVzb3MvTWVzb3NDb250YWluZXJGYWN0b3J5LnNjYWxh)
 | `61.81% <ø> (ø)` | :arrow_up: |
   | 
[...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4062/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh)
 | `0% <0%> (-95.54%)` | :arrow_down: |
   | 
[...on/scala/src/main/scala/whisk/common/Logging.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4062/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Mb2dnaW5nLnNjYWxh)
 | `89.36% <0%> (-0.97%)` | :arrow_down: |
   | 
[...n/scala/whisk/core/database/CouchDbRestStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4062/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQ291Y2hEYlJlc3RTdG9yZS5zY2FsYQ==)
 | `73.23% <100%> (ø)` | :arrow_up: |
   | 
[...ala/whisk/core/database/s3/S3AttachmentStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4062/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvczMvUzNBdHRhY2htZW50U3RvcmUuc2NhbGE=)
 | `85.71% <100%> (ø)` | :arrow_up: |
   | 
[...rc/main/scala/whisk/core/database/StoreUtils.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4062/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvU3RvcmVVdGlscy5zY2FsYQ==)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[...cala/src/main/scala/whisk/core/entity/Limits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4062/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0xpbWl0cy5zY2FsYQ==)
 | `84.61% <100%> (ø)` | :arrow_up: |
   | 
[...core/controller/BasicAuthenticationDirective.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4062/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9CYXNpY0F1dGhlbnRpY2F0aW9uRGlyZWN0aXZlLnNjYWxh)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[...isk/core/database/memory/MemoryArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4062/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvbWVtb3J5L01lbW9yeUFydGlmYWN0U3RvcmUuc2NhbGE=)
 | `97.54% <83.33%> (-0.84%)` | :arrow_down: |
   | 
[...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4062/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh)
 | `0% <0%> (-100%)` | :arrow_down: |
   | ... and [25 
more](https://codecov.io/gh/apache/incubator-openwhisk/pull/4062/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4062?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4062?src=pr=footer).
 Last update 
[c8054fa...651f381](https://codecov.io/gh/apache/incubator-openwhisk/pull/4062?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

[GitHub] daisy-ycguo closed pull request #317: Documentation enhancements

2018-10-19 Thread GitBox

daisy-ycguo closed pull request #317: Documentation enhancements
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/317
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/README.md b/README.md
index 099559e..151115d 100644
--- a/README.md
+++ b/README.md
@@ -30,6 +30,7 @@ This repository can be used to deploy OpenWhisk to a 
Kubernetes cluster.
 * [Setting up Kubernetes and Helm](#setting-up-kubernetes-and-helm)
 * [Deploying OpenWhisk](#deploying-openwhisk)
 * [Deploying OpenWhisk Providers](#deploying-openwhisk-providers)
+* [Development and Testing](#development-and-testing)
 * [Cleanup](#cleanup)
 * [Issues](#issues)
 
@@ -59,15 +60,17 @@ available as part of the
 [Getting started](https://docs.docker.com/docker-for-mac/#kubernetes)
 documentation from Docker.
 
-In a nutshell, open the Docker preferences pane, switch to the
-Kubernetes panel, and check the box to enable Kubernetes.  You will
-want to use the `kubectl` cli that is installed by Docker in
-`/usr/local/bin`, so please make sure it is appears in your path
-before any `kubectl` you have installed on your machine.  Pick the
+In a nutshell, open the Docker preferences window, switch to the
+`Advanced` panel and make sure you have at least 4GB of Memory
+allocated to Docker. Then switch to the Kubernetes panel, and check
+the box to enable Kubernetes. It is recommended that you use the
+`kubectl` cli that is installed by Docker in `/usr/local/bin`, so
+please make sure it is appears in your path before any `kubectl` you
+might also have installed on your machine.  Finally, pick the
 `docker-for-desktop` config for `kubectl` by executing the command
 `kubectl config use-context docker-for-desktop`.
 
-Once nice feature of using Kubernetes in Docker, is that the
+One nice feature of using Kubernetes in Docker, is that the
 containers being run in Kubernetes are also directly
 visible/accessible via the usual Docker commands. Furthermore, it is
 straightforward to deploy local images by adding a stanza to your
@@ -80,9 +83,9 @@ controller:
   imagePullPolicy: "IfNotPresent"
 ```
 
-NOTE: Docker for Windows 18.06 and later also has similar built-in
-support for Kubernetes. We would be interested in any experience using
-it to run Apache OpenWhisk on the Windows platform.
+NOTE: Docker for Windows 18.06 and later has similar built-in support
+for Kubernetes. We would be interested in any experience using it to
+run Apache OpenWhisk on the Windows platform.
 
 ### Using kubeadm-dind-cluster
 On Linux, you can get a similar experience to using Kubernetes in
@@ -90,13 +93,14 @@ Docker for Mac via the
 [kubeadm-dind-cluster](https://github.com/kubernetes-sigs/kubeadm-dind-cluster)
 project.  In a nutshell, you can get started by doing
 ```shell
+# Get the script for the Kubernetes version you want
 wget 
https://cdn.rawgit.com/kubernetes-sigs/kubeadm-dind-cluster/master/fixed/dind-cluster-v1.10.sh
 chmod +x dind-cluster-v1.10.sh
 
 # start the cluster
 ./dind-cluster-v1.10.sh up
 
-# add kubectl directory to PATH
+# add kubectl directory to your PATH
 export PATH="$HOME/.kubeadm-dind-cluster:$PATH"
 ```
 
@@ -207,7 +211,7 @@ nginx:
 
 Beyond specifying the ingress, the `mycluster.yaml` file is also used
 to customize your OpenWhisk deployment by enabling optional features
-and controlling the replication factor of the various micro-services
+and controlling the replication factor of the various microservices
 that make up the OpenWhisk implementation. See the [configuration
 choices documentation](./docs/configurationChoices.md) for a
 discussion of the primary options.
@@ -287,6 +291,72 @@ Please see the `values.yaml` file and/or README.md in the 
individual
 charts for instructions on enabling any optional customizations of the
 providers.
 
+# Development and Testing
+
+This section outlines how common OpenWhisk development tasks are
+supported when OpenWhisk is deployed on Kubernetes using Helm.
+
+### Running OpenWhisk test cases
+
+Some key differences in a Kubernetes-based deployment of OpenWhisk are
+that deploying the system does not generate a `whisk.properties` file and
+that the various internal microservices (`invoker`, `controller`,
+etc.) are not directly accessible from the outside of the Kubernetes cluster.
+Therefore, although you can run full system tests against a
+Kubernetes-based deployment by giving some extra command line
+arguments, any unit tests that assume direct access to one of the internal
+microservices will fail.   The system tests can be executed in a
+batch-style as shown below, where WHISK_SERVER and WHISK_AUTH are
+replaced by the values returned by `wsk property get --apihost` and
+`wsk property get --auth` respectively.
+```shell
+cd $OPENWHISK_HOME
+./gradlew

[GitHub] codecov-io edited a comment on issue #4041: Send active-ack after log collection for nonblocking activations.

2018-10-19 Thread GitBox

codecov-io edited a comment on issue #4041: Send active-ack after log 
collection for nonblocking activations.
URL: 
https://github.com/apache/incubator-openwhisk/pull/4041#issuecomment-431318741
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041?src=pr=h1)
 Report
   > Merging 
[#4041](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/0d6c01793af8245965aae96296b385791512fe06?src=pr=desc)
 will **decrease** coverage by `4.87%`.
   > The diff coverage is `80%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/graphs/tree.svg?width=650=l0YmsiSAso=150=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4041  +/-   ##
   ==
   - Coverage   86.01%   81.13%   -4.88% 
   ==
 Files 147  147  
 Lines7180 7210  +30 
 Branches  445  444   -1 
   ==
   - Hits 6176 5850 -326 
   - Misses   1004 1360 +356
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...cala/whisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==)
 | `94.02% <100%> (+0.16%)` | :arrow_up: |
   | 
[...e/loadBalancer/ShardingContainerPoolBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL1NoYXJkaW5nQ29udGFpbmVyUG9vbEJhbGFuY2VyLnNjYWxh)
 | `84.07% <72%> (-0.14%)` | :arrow_down: |
   | 
[.../src/main/scala/whisk/core/connector/Message.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2Uuc2NhbGE=)
 | `64.38% <78.57%> (+2.47%)` | :arrow_up: |
   | 
[...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=)
 | `81.98% <85.71%> (+0.67%)` | :arrow_up: |
   | 
[...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh)
 | `0% <0%> (-100%)` | :arrow_down: |
   | 
[...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh)
 | `0% <0%> (-95.54%)` | :arrow_down: |
   | 
[...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh)
 | `0% <0%> (-92.6%)` | :arrow_down: |
   | 
[...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh)
 | `0% <0%> (-83.34%)` | :arrow_down: |
   | 
[...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=)
 | `0% <0%> (-58.83%)` | :arrow_down: |
   | 
[...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh)
 | `92% <0%> (-4%)` | :arrow_down: |
   | ... and [2 
more](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041?src=pr=footer).
 Last update

[GitHub] codecov-io commented on issue #4041: Send active-ack after log collection for nonblocking activations.

2018-10-19 Thread GitBox

codecov-io commented on issue #4041: Send active-ack after log collection for 
nonblocking activations.
URL: 
https://github.com/apache/incubator-openwhisk/pull/4041#issuecomment-431318741
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041?src=pr=h1)
 Report
   > Merging 
[#4041](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/0d6c01793af8245965aae96296b385791512fe06?src=pr=desc)
 will **decrease** coverage by `4.89%`.
   > The diff coverage is `79.24%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/graphs/tree.svg?width=650=l0YmsiSAso=150=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master#4041 +/-   ##
   =
   - Coverage   86.01%   81.12%   -4.9% 
   =
 Files 147  147 
 Lines7180 7210 +30 
 Branches  445  444  -1 
   =
   - Hits 6176 5849-327 
   - Misses   1004 1361+357
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...cala/whisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==)
 | `94.02% <100%> (+0.16%)` | :arrow_up: |
   | 
[...e/loadBalancer/ShardingContainerPoolBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL1NoYXJkaW5nQ29udGFpbmVyUG9vbEJhbGFuY2VyLnNjYWxh)
 | `84.07% <69.56%> (-0.14%)` | :arrow_down: |
   | 
[.../src/main/scala/whisk/core/connector/Message.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2Uuc2NhbGE=)
 | `64.38% <78.57%> (+2.47%)` | :arrow_up: |
   | 
[...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=)
 | `81.98% <85.71%> (+0.67%)` | :arrow_up: |
   | 
[...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh)
 | `0% <0%> (-100%)` | :arrow_down: |
   | 
[...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh)
 | `0% <0%> (-95.54%)` | :arrow_down: |
   | 
[...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh)
 | `0% <0%> (-92.6%)` | :arrow_down: |
   | 
[...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh)
 | `0% <0%> (-83.34%)` | :arrow_down: |
   | 
[...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=)
 | `0% <0%> (-58.83%)` | :arrow_down: |
   | 
[...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh)
 | `92% <0%> (-4%)` | :arrow_down: |
   | ... and [2 
more](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041?src=pr=footer).
 Last update 
[0d6c017...997ccd1](https://codecov.io/gh/apache/incubator-openwhisk/pull/4041?src=pr=lastupdated).

[GitHub] cbickel opened a new pull request #4041: Send active-ack after log collection for nonblocking activations.

2018-10-19 Thread GitBox

cbickel opened a new pull request #4041: Send active-ack after log collection 
for nonblocking activations.
URL: https://github.com/apache/incubator-openwhisk/pull/4041
 
 
   Until now, an active-ack is sent before logs of a container are collected. 
If one customer writes a lot of logs or if log-collection is slow for some 
other reason, the invoker already gets new activations, that are queueing up.
   This PR changes the behavior, to send the active-ack (for non-blocking) 
activations after log collection is finished. For blocking actions, there are 
two active acks now. One with the response for the user and one to free up the 
space in the bookkeeping of the loadbalancer.
   
   I've put this proposal on the dev-list for discussion: 
https://lists.apache.org/thread.html/726c802f38f3872d057f9adb6a52043eeb8fbd68b601c57bdb12d706@%3Cdev.openwhisk.apache.org%3E
   
   I'll continue work on this PR, if we come to a conclusion how to proceed 
with this issue.
   
   ## Related issue and scope
   - [ ] I opened an issue to propose and discuss this change (#)
   
   ## My changes affect the following components
   
   
   - [ ] API
   - [x] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [x] Loadbalancer
   - [x] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   
   - [x] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
behavior).
   
   ## Checklist:
   
   
   - [x] I signed an [Apache 
CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style 
guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
 and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dedene commented on issue #303: Nginx CrashLoopbackOff

2018-10-19 Thread GitBox

dedene commented on issue #303: Nginx CrashLoopbackOff
URL: 
https://github.com/apache/incubator-openwhisk-deploy-kube/issues/303#issuecomment-431287388
 
 
   I had the same `host not found in resolver "kube-dns.kube-system"` as 
kube-dns was replaced by https://coredns.io/
   
   Changing the nginx config in nginxConfigMap.yaml to use `resolver 
coredns.kube-system` solved this for me.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] upgle commented on issue #3880: Modify that web action in the bound package can be accessed.

2018-10-19 Thread GitBox

upgle commented on issue #3880: Modify that web action in the bound package can 
be accessed.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3880#issuecomment-431277851
 
 
   @ningyougang thank you, i'll rebase it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ningyougang commented on issue #3880: Modify that web action in the bound package can be accessed.

2018-10-19 Thread GitBox

ningyougang commented on issue #3880: Modify that web action in the bound 
package can be accessed.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3880#issuecomment-431276059
 
 
   @upgle ,can you rebase?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ningyougang opened a new pull request #4077: Fix bug of cal manged and blackboxes number

2018-10-19 Thread GitBox

ningyougang opened a new pull request #4077: Fix bug of cal manged and 
blackboxes number
URL: https://github.com/apache/incubator-openwhisk/pull/4077
 
 
   
   
   ## Description
   
   
   Actually, in most cases, there is no problem.
   But in some special cases, there has a little problem. e.g. if we assign 
`fraction = 0.99`
   ```
 val newSize = 1000
 val fraction = 0.99
 val managed = Math.max(1, Math.ceil(newSize.toDouble * (1 - 
fraction)).toInt)
 val blackboxes = Math.max(1, Math.floor(newSize.toDouble * fraction).toInt)
   ```
   The manged number in above codes will be `11`
   The blackboxes number will be `990`
   Obviously, the correct manged number should be `10`.
   
   ## Related issue and scope
   
   - [ ] I opened an issue to propose and discuss this change (#)
   
   ## My changes affect the following components
   
   
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [x] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   
   - [x] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
behavior).
   
   ## Checklist:
   
   
   - [x] I signed an [Apache 
CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style 
guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
 and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sven-lange-last commented on a change in pull request #4070: Diagnostic info + metrics for Docker command failures and timeouts

2018-10-19 Thread GitBox

sven-lange-last commented on a change in pull request #4070: Diagnostic info + 
metrics for Docker command failures and timeouts
URL: 
https://github.com/apache/incubator-openwhisk/pull/4070#discussion_r226552433
 
 

 ##
 File path: 
tests/src/test/scala/whisk/core/containerpool/docker/test/DockerClientTests.scala
 ##
 @@ -353,16 +349,39 @@ class DockerClientTests
   it should "fail with ProcessRunningException when run returns with exit code 
!=125 or no container ID" in {
 def runAndVerify(pre: ProcessRunningException, clue: String) = {
   val dc = dockerClient { Future.failed(pre) }
-  withClue(s"${clue} - exitCode = ${pre.exitCode}, stdout = 
'${pre.stdout}', stderr = '${pre.stderr}': ") {
+  withClue(s"${clue} - exitStatus = ${pre.exitStatus}, stdout = 
'${pre.stdout}', stderr = '${pre.stderr}': ") {
 the[ProcessRunningException] thrownBy await(dc.run("image", 
Seq.empty)) shouldBe pre
   }
 }
 
 Seq[(ProcessRunningException, String)](
-  (ProcessRunningException(126, id.asString, "Unknown command"), "Exit 
code not 125"),
-  (ProcessRunningException(125, "", "Unknown flag: --foo"), "No container 
ID"),
-  (ProcessRunningException(1, "", ""), "Exit code not 125 and no container 
ID")).foreach {
+  (ProcessRunningException(ExitStatus(127), id.asString, "Unknown 
command"), "Exit code not 125"),
 
 Review comment:
   Well, that's just a change for preciseness that does not really change 
semantics. Already before the change, the "idea" of this test was to exercise 
`unknown command`. According to 
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_08_02,
 `unknown command` means exit status 127 (new) instead of 126 (old).
   For the tested code, it's just of importance that the exit status is not 125.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ningyougang commented on issue #3629: [Feature requests] action protection

2018-10-19 Thread GitBox

ningyougang commented on issue #3629: [Feature requests] action protection
URL: 
https://github.com/apache/incubator-openwhisk/issues/3629#issuecomment-431264812
 
 
   @rabbah https://github.com/apache/incubator-openwhisk/pull/4058


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dgrove-oss opened a new pull request #318: proper configuration of couchdb as a single node cluster

[GitHub] jasonpet commented on issue #163: Added support for Azure cosmosDB for alarms package

[GitHub] codecov-io edited a comment on issue #4073: Rename the package of controller and invoker

[GitHub] jasonpet commented on issue #163: Added support for Azure cosmosDB for alarms package

[GitHub] dailyworker opened a new issue #27: it doesn't work with python3??

[GitHub] jasonpet commented on issue #163: Added support for Azure cosmosDB for alarms package

[GitHub] jasonpet closed pull request #164: added checksum verification for https://deb.nodesource.com/setup_8.x

[GitHub] codecov-io edited a comment on issue #4073: Rename the package of controller and invoker

[GitHub] codecov-io commented on issue #4073: Rename the package of controller and invoker

[GitHub] codecov-io edited a comment on issue #4062: Switch to Scala 2.12.7

[GitHub] daisy-ycguo closed pull request #317: Documentation enhancements

[GitHub] codecov-io edited a comment on issue #4041: Send active-ack after log collection for nonblocking activations.

[GitHub] codecov-io commented on issue #4041: Send active-ack after log collection for nonblocking activations.

[GitHub] cbickel opened a new pull request #4041: Send active-ack after log collection for nonblocking activations.

[GitHub] dedene commented on issue #303: Nginx CrashLoopbackOff

[GitHub] upgle commented on issue #3880: Modify that web action in the bound package can be accessed.

[GitHub] ningyougang commented on issue #3880: Modify that web action in the bound package can be accessed.

[GitHub] ningyougang opened a new pull request #4077: Fix bug of cal manged and blackboxes number

[GitHub] sven-lange-last commented on a change in pull request #4070: Diagnostic info + metrics for Docker command failures and timeouts

[GitHub] ningyougang commented on issue #3629: [Feature requests] action protection

20 matches

Site Navigation

Mail list logo

Footer information