[GitHub] TPei commented on a change in pull request #4254: Remove older runtimes
TPei commented on a change in pull request #4254: Remove older runtimes URL: https://github.com/apache/incubator-openwhisk/pull/4254#discussion_r254575987 ## File path: docs/actions-swift.md ## @@ -187,164 +187,7 @@ wsk action update helloSwiftly action-bin.zip --kind swift:4.2 wsk action invoke helloSwiftly -r ``` -## Compiling Swift 4.1 packaged actions Review comment: should this be removed or does it make sense to update this for 4.2? or maybe replace with https://github.com/apache/incubator-openwhisk-runtime-swift#packaging-an-action-as-a-swift-executable-using-swift-4x ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vvraskin commented on issue #4227: Enable publishing metrics to Prometheus
vvraskin commented on issue #4227: Enable publishing metrics to Prometheus URL: https://github.com/apache/incubator-openwhisk/pull/4227#issuecomment-461320048 @chetanmeh could you please resolve the conflict, I will give it another PG round and merge? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] TPei opened a new pull request #4254: Remove older runtimes
TPei opened a new pull request #4254: Remove older runtimes URL: https://github.com/apache/incubator-openwhisk/pull/4254 Removes some older runtimes (nodejs, python, swift, swift:3.1.1, swift:4.1, php:7.1, php:7.2) as proposed in #4246 and discussed in the Tech. Interchange Meeting ## Description ## Related issue and scope - [x] I opened an issue to propose and discuss this change (#4246) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [x] Tests - [x] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [x] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [x] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] upgle commented on issue #4228: [discussion] user can't know when entity was updated
upgle commented on issue #4228: [discussion] user can't know when entity was updated URL: https://github.com/apache/incubator-openwhisk/issues/4228#issuecomment-461291038 @rabbah Yes, that's right. what do you think of serializing the updated value? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr merged pull request #4252: Mount an optional html directory for serving static content.
csantanapr merged pull request #4252: Mount an optional html directory for serving static content. URL: https://github.com/apache/incubator-openwhisk/pull/4252 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr merged pull request #13: remove extra : in distDocker command
csantanapr merged pull request #13: remove extra : in distDocker command URL: https://github.com/apache/incubator-openwhisk-runtime-ballerina/pull/13 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #13: remove extra : in distDocker command
csantanapr opened a new pull request #13: remove extra : in distDocker command URL: https://github.com/apache/incubator-openwhisk-runtime-ballerina/pull/13 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #4186: Track activation counts in ContainerPool (not ContainerProxy)
dgrove-oss commented on issue #4186: Track activation counts in ContainerPool (not ContainerProxy) URL: https://github.com/apache/incubator-openwhisk/pull/4186#issuecomment-461261881 grasping at straws, but perhaps try rebasing to latest master and verify that the controller still deploys successfully in the travis run? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #4186: Track activation counts in ContainerPool (not ContainerProxy)
dgrove-oss commented on issue #4186: Track activation counts in ContainerPool (not ContainerProxy) URL: https://github.com/apache/incubator-openwhisk/pull/4186#issuecomment-461258134 I made 3 attempts at PG runs. All three failed in the deployment stage because the controller failed to start successfully. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new pull request #4253: Remove deadcode.
rabbah opened a new pull request #4253: Remove deadcode. URL: https://github.com/apache/incubator-openwhisk/pull/4253 Closes https://github.com/apache/incubator-openwhisk/issues/3861. ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [ ] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed issue #3937: Issue with vagrant build
rabbah closed issue #3937: Issue with vagrant build URL: https://github.com/apache/incubator-openwhisk/issues/3937 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3938: Update to latest NodeJS runtime which contains latest Openwhisk package, 3.16.0
rabbah commented on issue #3938: Update to latest NodeJS runtime which contains latest Openwhisk package, 3.16.0 URL: https://github.com/apache/incubator-openwhisk/issues/3938#issuecomment-461240918 https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/75 merged already. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed issue #3938: Update to latest NodeJS runtime which contains latest Openwhisk package, 3.16.0
rabbah closed issue #3938: Update to latest NodeJS runtime which contains latest Openwhisk package, 3.16.0 URL: https://github.com/apache/incubator-openwhisk/issues/3938 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3959: Validate API-level tests against Swagger spec
rabbah commented on issue #3959: Validate API-level tests against Swagger spec URL: https://github.com/apache/incubator-openwhisk/issues/3959#issuecomment-461240633 @mgencur @markusthoemmes how much more is left on this - can we document that here if any for future reference? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed issue #3966: Conductor action returns "application error" when continuation function throws an uncaught exception
rabbah closed issue #3966: Conductor action returns "application error" when continuation function throws an uncaught exception URL: https://github.com/apache/incubator-openwhisk/issues/3966 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #4002: Can I spawn action containers not only use docker?
rabbah commented on issue #4002: Can I spawn action containers not only use docker? URL: https://github.com/apache/incubator-openwhisk/issues/4002#issuecomment-461240172 @YellyYU i hope the above answered your question - please reopen if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #4002: Can I spawn action containers not only use docker?
rabbah commented on issue #4002: Can I spawn action containers not only use docker? URL: https://github.com/apache/incubator-openwhisk/issues/4002#issuecomment-461240277 @sven-lange-last it would be useful to document the assumptions - where is a good place to do that? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed issue #4002: Can I spawn action containers not only use docker?
rabbah closed issue #4002: Can I spawn action containers not only use docker? URL: https://github.com/apache/incubator-openwhisk/issues/4002 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed issue #4007: tid lost in invoker pause command
rabbah closed issue #4007: tid lost in invoker pause command URL: https://github.com/apache/incubator-openwhisk/issues/4007 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #4021: Update Ruby action doc on how to use Gem file to add dependencies
rabbah commented on issue #4021: Update Ruby action doc on how to use Gem file to add dependencies URL: https://github.com/apache/incubator-openwhisk/issues/4021#issuecomment-461239541 @Juice10 is this done? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #4024: Intermittent failure in WskRuleTests with multiple controllers
rabbah commented on issue #4024: Intermittent failure in WskRuleTests with multiple controllers URL: https://github.com/apache/incubator-openwhisk/issues/4024#issuecomment-461239383 @chetanmeh your explanation and understanding makes sense to me. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #4022: Status code '405 Method Not Allowed' was returned from ElasticSearchStore
rabbah commented on issue #4022: Status code '405 Method Not Allowed' was returned from ElasticSearchStore URL: https://github.com/apache/incubator-openwhisk/issues/4022#issuecomment-461238768 @dubee is this something you can fix? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed issue #4050: Verify checksums for downloaded software in Dockerfiles
rabbah closed issue #4050: Verify checksums for downloaded software in Dockerfiles URL: https://github.com/apache/incubator-openwhisk/issues/4050 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #4029: Add more information to DockerClientWithFileAccess errors
rabbah commented on issue #4029: Add more information to DockerClientWithFileAccess errors URL: https://github.com/apache/incubator-openwhisk/issues/4029#issuecomment-461238345 @dubee any ideas on what to add? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #4060: Docker compose install on Ubuntu 18.04 bare metal : Authenticated user does not have namespace 'guest'
rabbah commented on issue #4060: Docker compose install on Ubuntu 18.04 bare metal : Authenticated user does not have namespace 'guest' URL: https://github.com/apache/incubator-openwhisk/issues/4060#issuecomment-461237926 @Franzerfos is this still an issue? Please reopen if so. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed issue #4060: Docker compose install on Ubuntu 18.04 bare metal : Authenticated user does not have namespace 'guest'
rabbah closed issue #4060: Docker compose install on Ubuntu 18.04 bare metal : Authenticated user does not have namespace 'guest' URL: https://github.com/apache/incubator-openwhisk/issues/4060 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] silvasong removed a comment on issue #4189: invoker memory continues to rise
silvasong removed a comment on issue #4189: invoker memory continues to rise URL: https://github.com/apache/incubator-openwhisk/issues/4189#issuecomment-449278390 @chetanmeh thx , please wait on. it's time again to test. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] silvasong edited a comment on issue #4189: invoker memory continues to rise
silvasong edited a comment on issue #4189: invoker memory continues to rise
URL:
https://github.com/apache/incubator-openwhisk/issues/4189#issuecomment-450476962
@sven-lange-last two hours
actions details:
```
var showMem = function(type){
var mem = process.memoryUsage();
var format = function(bytes){
retrun (bytes/1024/1024).toFixed(2)+' MB';
}
}
var consumeTime = function(count){
var length = 0 ;
if(2===count){
length = 17000;
}else if(5 === count){
length = 28000;
}else if(10 === count){
length = 39000;
}
sortMethod(length);
}
function sortMethod(length){
var array = new Array(length);
for(var i=0;iarray[j+1]){
swap = array[j];
array[j] = array[j+1];
array[j+1]= swap;
}
}
}
}
var printLog = function(logType){
var times =0 ;
if("little" == logType){
times =50;
}else if ("normal"==logType){
times = 120;
}
for (var x = 0 ;x
[GitHub] rabbah commented on issue #4178: Controller cant't survive after VM reboots?
rabbah commented on issue #4178: Controller cant't survive after VM reboots? URL: https://github.com/apache/incubator-openwhisk/issues/4178#issuecomment-461236297 I've seen this - it has to do with the `/tmp` directory being wiped and then owned by root. I'm pretty sure it's because of the user mappings inside the container and the host. Suggested work around is to put the logs somewhere other than `/tmp` for now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #4179: how to enable zipkin tracing
rabbah commented on issue #4179: how to enable zipkin tracing URL: https://github.com/apache/incubator-openwhisk/issues/4179#issuecomment-461236026 @JayGee24 did you resolve the issue you were facing? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed issue #4133: Permission denied error when trying to execute `make quick-start` step
rabbah closed issue #4133: Permission denied error when trying to execute `make quick-start` step URL: https://github.com/apache/incubator-openwhisk/issues/4133 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #4133: Permission denied error when trying to execute `make quick-start` step
rabbah commented on issue #4133: Permission denied error when trying to execute `make quick-start` step URL: https://github.com/apache/incubator-openwhisk/issues/4133#issuecomment-461235776 Closing as abandoned - please reopen if problem persists. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #4169: tests:testSwaggerCodegen failing
rabbah commented on issue #4169: tests:testSwaggerCodegen failing URL: https://github.com/apache/incubator-openwhisk/issues/4169#issuecomment-461235590 We need to re-enable these tests before they rot. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #4181: Scala compilaiton failure when using Java11 JDK
rabbah commented on issue #4181: Scala compilaiton failure when using Java11 JDK URL: https://github.com/apache/incubator-openwhisk/issues/4181#issuecomment-461235408 closing as duplicate of #4217. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed issue #4181: Scala compilaiton failure when using Java11 JDK
rabbah closed issue #4181: Scala compilaiton failure when using Java11 JDK URL: https://github.com/apache/incubator-openwhisk/issues/4181 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #4194: the end field of trigger activations are always 0"
rabbah commented on issue #4194: the end field of trigger activations are always 0" URL: https://github.com/apache/incubator-openwhisk/issues/4194#issuecomment-461235206 This is by design - triggers have no duration so the `end` field is either not present in the db or always set to 0. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #4228: [discussion] user can't know when entity was updated
rabbah commented on issue #4228: [discussion] user can't know when entity was updated URL: https://github.com/apache/incubator-openwhisk/issues/4228#issuecomment-461234981 @upgle I think you're suggesting serializing the updated value in the db out in the action/trigger/etc response, is that right? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #4195: install chouchBD. The JDK doesnt work.
rabbah commented on issue #4195: install chouchBD. The JDK doesnt work. URL: https://github.com/apache/incubator-openwhisk/issues/4195#issuecomment-461234621 It looks like the Java installation failed indeed from the logs above - you can try to install JDK explicitly and skip using all.sh. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed issue #4231: if controller_activation_pollingFromDb is false, and invoker send a Left(activationId) to Kafka, the blocking invocation will wait until timeout
rabbah closed issue #4231: if controller_activation_pollingFromDb is false, and invoker send a Left(activationId) to Kafka, the blocking invocation will wait until timeout URL: https://github.com/apache/incubator-openwhisk/issues/4231 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #12: Publish image hash tag
csantanapr opened a new pull request #12: Publish image hash tag URL: https://github.com/apache/incubator-openwhisk-runtime-ballerina/pull/12 Publish image hash tag This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed issue #4235: Fail to deploy Distributed
rabbah closed issue #4235: Fail to deploy Distributed URL: https://github.com/apache/incubator-openwhisk/issues/4235 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #4235: Fail to deploy Distributed
rabbah commented on issue #4235: Fail to deploy Distributed URL: https://github.com/apache/incubator-openwhisk/issues/4235#issuecomment-461233365 I've now removed these playbooks. @axiqia I'm happy to help on slack if needed - I suggest trying the "local" playbooks but modifying the IPs for the various components to reflect your setup. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #2220: Ansible error while deploying to distributed environment
rabbah commented on issue #2220: Ansible error while deploying to distributed environment URL: https://github.com/apache/incubator-openwhisk/issues/2220#issuecomment-461230657 We have removed these playbooks since they aren't tested and maintained. We'll need to rethink the setup infra setup, but for a distributed deployment, adapting the environment in `local` should suffice. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah edited a comment on issue #3733: Distributed deployment: export | unreachable
rabbah edited a comment on issue #3733: Distributed deployment: export | unreachable URL: https://github.com/apache/incubator-openwhisk/issues/3733#issuecomment-461230432 We have removed these playbooks since they aren't tested and maintained. We'll need to rethink the setup infra setup, but for a distributed deployment, adapting the environment in `local` should suffice. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed issue #2220: Ansible error while deploying to distributed environment
rabbah closed issue #2220: Ansible error while deploying to distributed environment URL: https://github.com/apache/incubator-openwhisk/issues/2220 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed issue #3733: Distributed deployment: export | unreachable
rabbah closed issue #3733: Distributed deployment: export | unreachable URL: https://github.com/apache/incubator-openwhisk/issues/3733 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3989: error when following guide for ansible distributed installation with openstack provisioning step using ansible 2.5.2 on an Ubuntu 16 Xenial VM
rabbah commented on issue #3989: error when following guide for ansible distributed installation with openstack provisioning step using ansible 2.5.2 on an Ubuntu 16 Xenial VM URL: https://github.com/apache/incubator-openwhisk/issues/3989#issuecomment-461230200 This closed PR might be of help for future reference https://github.com/apache/incubator-openwhisk/pull/4107, although we have removed these playbooks since they aren't tested and maintained. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3733: Distributed deployment: export | unreachable
rabbah commented on issue #3733: Distributed deployment: export | unreachable URL: https://github.com/apache/incubator-openwhisk/issues/3733#issuecomment-461230432 We have removed these playbooks since they aren't tested and maintained. We'll need to rethink the setup infra setup, but for a distribute deployment, adapting the environment in `local` should suffice. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed issue #3989: error when following guide for ansible distributed installation with openstack provisioning step using ansible 2.5.2 on an Ubuntu 16 Xenial VM
rabbah closed issue #3989: error when following guide for ansible distributed installation with openstack provisioning step using ansible 2.5.2 on an Ubuntu 16 Xenial VM URL: https://github.com/apache/incubator-openwhisk/issues/3989 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed pull request #4107: Enable Deploying Distributed OpenWhisk on Ubuntu 16.04 Cluster
rabbah closed pull request #4107: Enable Deploying Distributed OpenWhisk on Ubuntu 16.04 Cluster URL: https://github.com/apache/incubator-openwhisk/pull/4107 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #4107: Enable Deploying Distributed OpenWhisk on Ubuntu 16.04 Cluster
rabbah commented on issue #4107: Enable Deploying Distributed OpenWhisk on Ubuntu 16.04 Cluster URL: https://github.com/apache/incubator-openwhisk/pull/4107#issuecomment-461229859 Thanks @chen116 for this addition - because these playbooks aren't tested and not maintained, we've decided to remove them (See https://github.com/apache/incubator-openwhisk/pull/4245). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #4232: update for ansible command error
rabbah commented on issue #4232: update for ansible command error URL: https://github.com/apache/incubator-openwhisk/pull/4232#issuecomment-461229576 I've removed these playbooks in https://github.com/apache/incubator-openwhisk/pull/4245. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed pull request #4232: update for ansible command error
rabbah closed pull request #4232: update for ansible command error URL: https://github.com/apache/incubator-openwhisk/pull/4232 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #4251: Remove older runtimes.
rabbah commented on issue #4251: Remove older runtimes. URL: https://github.com/apache/incubator-openwhisk/pull/4251#issuecomment-461227107 @TPei will take a crack at this so closing accordingly. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed pull request #4251: Remove older runtimes.
rabbah closed pull request #4251: Remove older runtimes. URL: https://github.com/apache/incubator-openwhisk/pull/4251 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr merged pull request #4245: Remove unsupported distributed playbooks.
csantanapr merged pull request #4245: Remove unsupported distributed playbooks. URL: https://github.com/apache/incubator-openwhisk/pull/4245 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #4227: Enable publishing metrics to Prometheus
chetanmeh commented on issue #4227: Enable publishing metrics to Prometheus URL: https://github.com/apache/incubator-openwhisk/pull/4227#issuecomment-461184232 Idea here was to have it disabled by default and enable it via config (see PR description on config details) Currently we do not have a good way to document such config as most docs are around documenting the ansible flags. So currently it's documented in conf file itself This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4202: Bump ephemeral couchdb to v2.3
codecov-io commented on issue #4202: Bump ephemeral couchdb to v2.3 URL: https://github.com/apache/incubator-openwhisk/pull/4202#issuecomment-461180354 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4202?src=pr=h1) Report > Merging [#4202](https://codecov.io/gh/apache/incubator-openwhisk/pull/4202?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/cb02bdb775b23a97ba224ebc49f06f514074?src=pr=desc) will **decrease** coverage by `7.92%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/4202?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4202 +/- ## == - Coverage 86.21% 78.28% -7.93% == Files 152 156 +4 Lines7275 8314+1039 Branches 477 561 +84 == + Hits 6272 6509 +237 - Misses 1003 1805 +802 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/4202?src=pr=tree) | Coverage Δ | | |---|---|---| | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4202/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...n/scala/org/apache/openwhisk/common/CausedBy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4202/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9DYXVzZWRCeS5zY2FsYQ==) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4202/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.54%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4202/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4202/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-83.34%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4202/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-62.5%)` | :arrow_down: | | [...penwhisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4202/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `57.5% <0%> (-38.5%)` | :arrow_down: | | [...apache/openwhisk/core/database/LimitsCommand.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4202/diff?src=pr=tree#diff-dG9vbHMvYWRtaW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9vcGVud2hpc2svY29yZS9kYXRhYmFzZS9MaW1pdHNDb21tYW5kLnNjYWxh) | `63.82% <0%> (-34.54%)` | :arrow_down: | | [...containerpool/kubernetes/KubernetesContainer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4202/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL0t1YmVybmV0ZXNDb250YWluZXIuc2NhbGE=) | `64.28% <0%> (-30.46%)` | :arrow_down: | | [.../containerpool/ApacheBlockingContainerClient.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4202/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9BcGFjaGVCbG9ja2luZ0NvbnRhaW5lckNsaWVudC5zY2FsYQ==) | `48.14% <0%> (-22.77%)` | :arrow_down: | | ... and [29 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/4202/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4202?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by
[GitHub] rabbah commented on issue #4202: Bump ephemeral couchdb to v2.3
rabbah commented on issue #4202: Bump ephemeral couchdb to v2.3 URL: https://github.com/apache/incubator-openwhisk/pull/4202#issuecomment-461170445 @jonpspri not sure if #4250 is related - do you mind taking a look? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #4227: Enable publishing metrics to Prometheus
rabbah commented on a change in pull request #4227: Enable publishing metrics
to Prometheus
URL:
https://github.com/apache/incubator-openwhisk/pull/4227#discussion_r254432546
##
File path:
tests/src/test/scala/org/apache/openwhisk/common/PrometheusTests.scala
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.openwhisk.common
+import akka.http.scaladsl.coding.Gzip
+import akka.http.scaladsl.model.{HttpCharsets, HttpResponse}
+import akka.http.scaladsl.model.headers.HttpEncodings.gzip
+import akka.http.scaladsl.model.headers.{`Accept-Encoding`,
`Content-Encoding`, HttpEncoding, HttpEncodings}
+import akka.http.scaladsl.testkit.ScalatestRouteTest
+import akka.http.scaladsl.unmarshalling.Unmarshal
+import com.typesafe.config.ConfigFactory
+import kamon.Kamon
+import org.junit.runner.RunWith
+import org.scalatest.concurrent.ScalaFutures
+import org.scalatest.junit.JUnitRunner
+import org.scalatest.matchers.Matcher
+import org.scalatest.{BeforeAndAfterAll, FlatSpec, Matchers}
+
+import scala.concurrent.duration._
+
+@RunWith(classOf[JUnitRunner])
+class PrometheusTests extends FlatSpec with Matchers with ScalatestRouteTest
with BeforeAndAfterAll with ScalaFutures {
+ behavior of "Prometheus"
+
+ override protected def beforeAll(): Unit = {
+super.beforeAll()
+//Modify Kamon to have a very small tick interval
+val newConfig = ConfigFactory.parseString("""kamon {
+ | metric {
+ |tick-interval = 50 ms
+ |optimistic-tick-alignment = no
+ | }
+ |}""".stripMargin).withFallback(ConfigFactory.load())
+Kamon.reconfigure(newConfig)
+ }
+
+ override protected def afterAll(): Unit = {
+super.afterAll()
+Kamon.reconfigure(ConfigFactory.load())
+ }
+
+ it should "respond to /metrics" in {
+val api = new KamonPrometheus
+Kamon.counter("foo_bar").increment(42)
+
+//Sleep to ensure that Kamon metrics are pushed to reporters
+Thread.sleep(2.seconds.toMillis)
+Get("/metrics") ~> `Accept-Encoding`(gzip) ~> api.route ~> check {
+ // Check that response confirms to what Prometheus scrapper accepts
+ contentType.charsetOption shouldBe Some(HttpCharsets.`UTF-8`)
+ contentType.mediaType.params("version") shouldBe "0.0.4"
+ response should haveContentEncoding(gzip)
+
+ val responseText =
Unmarshal(Gzip.decodeMessage(response)).to[String].futureValue
+ withClue(responseText) {
+responseText should include("foo_bar")
+ }
+}
+api.close()
+ }
+
+ it should "not be enabled by default" in {
+Get("/metrics") ~> MetricsRoute() ~> check {
+ handled shouldBe false
Review comment:
will subsequent PRs make this route available via configuration?
are there docs on how to use this?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #4227: Enable publishing metrics to Prometheus
rabbah commented on a change in pull request #4227: Enable publishing metrics
to Prometheus
URL:
https://github.com/apache/incubator-openwhisk/pull/4227#discussion_r254432546
##
File path:
tests/src/test/scala/org/apache/openwhisk/common/PrometheusTests.scala
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.openwhisk.common
+import akka.http.scaladsl.coding.Gzip
+import akka.http.scaladsl.model.{HttpCharsets, HttpResponse}
+import akka.http.scaladsl.model.headers.HttpEncodings.gzip
+import akka.http.scaladsl.model.headers.{`Accept-Encoding`,
`Content-Encoding`, HttpEncoding, HttpEncodings}
+import akka.http.scaladsl.testkit.ScalatestRouteTest
+import akka.http.scaladsl.unmarshalling.Unmarshal
+import com.typesafe.config.ConfigFactory
+import kamon.Kamon
+import org.junit.runner.RunWith
+import org.scalatest.concurrent.ScalaFutures
+import org.scalatest.junit.JUnitRunner
+import org.scalatest.matchers.Matcher
+import org.scalatest.{BeforeAndAfterAll, FlatSpec, Matchers}
+
+import scala.concurrent.duration._
+
+@RunWith(classOf[JUnitRunner])
+class PrometheusTests extends FlatSpec with Matchers with ScalatestRouteTest
with BeforeAndAfterAll with ScalaFutures {
+ behavior of "Prometheus"
+
+ override protected def beforeAll(): Unit = {
+super.beforeAll()
+//Modify Kamon to have a very small tick interval
+val newConfig = ConfigFactory.parseString("""kamon {
+ | metric {
+ |tick-interval = 50 ms
+ |optimistic-tick-alignment = no
+ | }
+ |}""".stripMargin).withFallback(ConfigFactory.load())
+Kamon.reconfigure(newConfig)
+ }
+
+ override protected def afterAll(): Unit = {
+super.afterAll()
+Kamon.reconfigure(ConfigFactory.load())
+ }
+
+ it should "respond to /metrics" in {
+val api = new KamonPrometheus
+Kamon.counter("foo_bar").increment(42)
+
+//Sleep to ensure that Kamon metrics are pushed to reporters
+Thread.sleep(2.seconds.toMillis)
+Get("/metrics") ~> `Accept-Encoding`(gzip) ~> api.route ~> check {
+ // Check that response confirms to what Prometheus scrapper accepts
+ contentType.charsetOption shouldBe Some(HttpCharsets.`UTF-8`)
+ contentType.mediaType.params("version") shouldBe "0.0.4"
+ response should haveContentEncoding(gzip)
+
+ val responseText =
Unmarshal(Gzip.decodeMessage(response)).to[String].futureValue
+ withClue(responseText) {
+responseText should include("foo_bar")
+ }
+}
+api.close()
+ }
+
+ it should "not be enabled by default" in {
+Get("/metrics") ~> MetricsRoute() ~> check {
+ handled shouldBe false
Review comment:
will subsequent PRs make this route available via configuration?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah merged pull request #4230: Complete blocking activations immediately
rabbah merged pull request #4230: Complete blocking activations immediately URL: https://github.com/apache/incubator-openwhisk/pull/4230 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #4186: Track activation counts in ContainerPool (not ContainerProxy)
dgrove-oss commented on issue #4186: Track activation counts in ContainerPool (not ContainerProxy) URL: https://github.com/apache/incubator-openwhisk/pull/4186#issuecomment-461163274 PG3 3293 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #4246: remove older runtimes
rabbah commented on issue #4246: remove older runtimes URL: https://github.com/apache/incubator-openwhisk/issues/4246#issuecomment-461159162 Sorry @TPei I didn't see your note - you'll see that PR fails tests because there's actually some dependence on the actual manifest used for deployment and what the tests are assuming. It turns out we have to add a separate manifest for the test. I'm happy to close my PR if you would like to take this one. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tardieu commented on issue #19: composer.parallel not available in openwhisk-composer@0.9.0
tardieu commented on issue #19: composer.parallel not available in openwhisk-composer@0.9.0 URL: https://github.com/apache/incubator-openwhisk-composer/issues/19#issuecomment-461127161 npm supports pulling a module directly from github so you could use that for now. There are only a few minor fixes needed before the next release (doc, ssl certificate, public compilation api) so I am hoping to start the release process in a few days. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4250: Allow persisted couchdb directory mount.
codecov-io commented on issue #4250: Allow persisted couchdb directory mount. URL: https://github.com/apache/incubator-openwhisk/pull/4250#issuecomment-461123771 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4250?src=pr=h1) Report > Merging [#4250](https://codecov.io/gh/apache/incubator-openwhisk/pull/4250?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/abe2d33fc876df011687c9ed43571684b6eaefe5?src=pr=desc) will **decrease** coverage by `4.77%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/4250?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4250 +/- ## == - Coverage 86.07% 81.29% -4.78% == Files 156 156 Lines7481 7481 Branches 480 480 == - Hits 6439 6082 -357 - Misses 1042 1399 +357 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/4250?src=pr=tree) | Coverage Δ | | |---|---|---| | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4250/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4250/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.6%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4250/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4250/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-83.34%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4250/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `4.54% <0%> (-45.46%)` | :arrow_down: | | [...in/scala/org/apache/openwhisk/common/Counter.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4250/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Db3VudGVyLnNjYWxh) | `40% <0%> (-20%)` | :arrow_down: | | [...nwhisk/core/database/cosmosdb/CosmosDBConfig.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4250/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJDb25maWcuc2NhbGE=) | `93.75% <0%> (-6.25%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4250?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4250?src=pr=footer). Last update [abe2d33...99446f0](https://codecov.io/gh/apache/incubator-openwhisk/pull/4250?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4249: Add revoke key feature to wskadmin
codecov-io commented on issue #4249: Add revoke key feature to wskadmin URL: https://github.com/apache/incubator-openwhisk/pull/4249#issuecomment-461120766 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4249?src=pr=h1) Report > Merging [#4249](https://codecov.io/gh/apache/incubator-openwhisk/pull/4249?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/abe2d33fc876df011687c9ed43571684b6eaefe5?src=pr=desc) will **decrease** coverage by `4.75%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/4249?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4249 +/- ## == - Coverage 86.07% 81.31% -4.76% == Files 156 156 Lines7481 7481 Branches 480 480 == - Hits 6439 6083 -356 - Misses 1042 1398 +356 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/4249?src=pr=tree) | Coverage Δ | | |---|---|---| | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4249/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4249/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.6%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4249/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4249/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-83.34%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4249/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `4.54% <0%> (-45.46%)` | :arrow_down: | | [...in/scala/org/apache/openwhisk/common/Counter.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4249/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Db3VudGVyLnNjYWxh) | `40% <0%> (-20%)` | :arrow_down: | | [...nwhisk/core/database/cosmosdb/CosmosDBConfig.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4249/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJDb25maWcuc2NhbGE=) | `93.75% <0%> (-6.25%)` | :arrow_down: | | [...rg/apache/openwhisk/common/ForcibleSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4249/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Gb3JjaWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `92.3% <0%> (+3.84%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4249?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4249?src=pr=footer). Last update [abe2d33...5672528](https://codecov.io/gh/apache/incubator-openwhisk/pull/4249?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cheukchuen opened a new issue #19: composer.parallel not available in openwhisk-composer@0.9.0
cheukchuen opened a new issue #19: composer.parallel not available in openwhisk-composer@0.9.0 URL: https://github.com/apache/incubator-openwhisk-composer/issues/19 I've tried using the `composer.parallel` combinator that was introduced recently, but it returns `TypeError: composer.parallel is not a function`. I assume they are not packaged into the latest version of `openwhisk-composer`? May I know the estimated time when the module in npm will be updated to include those combinators? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #4186: Track activation counts in ContainerPool (not ContainerProxy)
chetanmeh commented on issue #4186: Track activation counts in ContainerPool (not ContainerProxy) URL: https://github.com/apache/incubator-openwhisk/pull/4186#issuecomment-461099545 @csantanapr @cbickel Can we get a PG run for this PR. Would like to merge this one now This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #4250: Allow persisted couchdb directory mount.
rabbah commented on issue #4250: Allow persisted couchdb directory mount. URL: https://github.com/apache/incubator-openwhisk/pull/4250#issuecomment-461096107 @style95 I think this is something you might be interested in from PR history --- you tried to do something with this some time back. I could be missing something and would appreciate your insight. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] TPei edited a comment on issue #4246: remove older runtimes
TPei edited a comment on issue #4246: remove older runtimes URL: https://github.com/apache/incubator-openwhisk/issues/4246#issuecomment-461095548 ~From a development perspective, this would mean adapting the runtime.json, swagger, docs and test/dat files? I feel this might be somewhat beginner-friendly, so I'd like to express an interest in working on that :)~ Too late I guess :D This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] TPei commented on issue #4246: remove older runtimes
TPei commented on issue #4246: remove older runtimes URL: https://github.com/apache/incubator-openwhisk/issues/4246#issuecomment-461095548 From a development perspective, this would mean adapting the runtime.json, swagger, docs and test/dat files? I feel this might be somewhat beginner-friendly, so I'd like to express an interest in working on that :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new pull request #4252: Mount an optional html directory for serving static content.
rabbah opened a new pull request #4252: Mount an optional html directory for serving static content. URL: https://github.com/apache/incubator-openwhisk/pull/4252 Allows a host path to be served from nginx as static content as discussed on Zoom community call. ## Description ## Related issue and scope - [x] I opened an issue to propose and discuss this change (#4248) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [x] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [x] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new pull request #4250: Allow persisted couchdb directory mount.
rabbah opened a new pull request #4250: Allow persisted couchdb directory mount. URL: https://github.com/apache/incubator-openwhisk/pull/4250 For example: `wskdev couchdb -d -e"db_persist_path=/home/couchd/openwhisk"` ## Description ## Related issue and scope - [x] I opened an issue to propose and discuss this change (#4247) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [x] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [x] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new pull request #4249: Add revoke key feature to wskadmin
rabbah opened a new pull request #4249: Add revoke key feature to wskadmin URL: https://github.com/apache/incubator-openwhisk/pull/4249 A small enhancement to wskadmin to revoke a key. This already exists in wskadmin-next but recently has an experience where running the new tool was too slow and took several seconds (it was not a very powerful CPU) and running the python version was faster. I could add a test for this reusing what's there for wskadmin-next. @chetanmeh thoughts? (I also added a "generate only" feature to get a new uuid:key without actually storing them, was handy for testing without affecting the database. I can add this to -next.) ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4245: Remove unsupported distributed playbooks.
codecov-io commented on issue #4245: Remove unsupported distributed playbooks. URL: https://github.com/apache/incubator-openwhisk/pull/4245#issuecomment-461075849 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4245?src=pr=h1) Report > Merging [#4245](https://codecov.io/gh/apache/incubator-openwhisk/pull/4245?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/abe2d33fc876df011687c9ed43571684b6eaefe5?src=pr=desc) will **decrease** coverage by `4.63%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/4245?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4245 +/- ## == - Coverage 86.07% 81.43% -4.64% == Files 156 156 Lines7481 7481 Branches 480 480 == - Hits 6439 6092 -347 - Misses 1042 1389 +347 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/4245?src=pr=tree) | Coverage Δ | | |---|---|---| | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4245/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4245/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.6%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4245/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4245/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-83.34%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4245/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `4.54% <0%> (-45.46%)` | :arrow_down: | | [...in/scala/org/apache/openwhisk/common/Counter.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4245/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Db3VudGVyLnNjYWxh) | `40% <0%> (-20%)` | :arrow_down: | | [...nwhisk/core/database/cosmosdb/CosmosDBConfig.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4245/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJDb25maWcuc2NhbGE=) | `93.75% <0%> (-6.25%)` | :arrow_down: | | [...che/openwhisk/core/database/CouchDbRestStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4245/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvQ291Y2hEYlJlc3RTdG9yZS5zY2FsYQ==) | `73.73% <0%> (+0.5%)` | :arrow_up: | | [...pache/openwhisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4245/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `82.24% <0%> (+0.93%)` | :arrow_up: | | [...rg/apache/openwhisk/common/ForcibleSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4245/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Gb3JjaWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `92.3% <0%> (+3.84%)` | :arrow_up: | | ... and [2 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/4245/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4245?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by
[GitHub] rabbah opened a new issue #4248: allow nginx to serve static html from a directory
rabbah opened a new issue #4248: allow nginx to serve static html from a directory URL: https://github.com/apache/incubator-openwhisk/issues/4248 When one deploys OpenWhisk and hits the API end point, you get the API response from the controller. I'm proposing that we extend our nginx routes to allow serving of a static html page (or more) to provide tutorial or docs that might be useful for a deployment. Specifically, I'm proposing adding a `/ui` route and allowing for a host file path to be mounted into the container to serve the raw content. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new issue #4247: allow couchdb container to mount persisted filesystem path
rabbah opened a new issue #4247: allow couchdb container to mount persisted filesystem path URL: https://github.com/apache/incubator-openwhisk/issues/4247 in #4245 one of the capabilities that will be lost is having a persisted volume for the db - I propose adding this back to the cleaned couchdb playbook so that it's possible to keep the db bits from one deployment to the next (wipe and init playbooks will work as expected, but in this case removing the files that are persisted and re-initializing them). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #4236: create '_users' database for singleton mode:"The database could not be created, the file already exists.
rabbah commented on issue #4236: create '_users' database for singleton mode:"The database could not be created, the file already exists. URL: https://github.com/apache/incubator-openwhisk/issues/4236#issuecomment-461072648 I found a potential problem with the couch playbook and will propose a patch that should address this symptom. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new issue #4246: remove older runtimes
rabbah opened a new issue #4246: remove older runtimes URL: https://github.com/apache/incubator-openwhisk/issues/4246 The runtimes manifest includes some stale/deprecated runtimes: - nodejs (node 4) - python (alias for python 2) - swift 2?, 3, 3.1.1., 4.1 - php 7.1, 7.2 I propose cleaning up the manifest to remove these older runtimes, and to make node 10 the default or node actions and python 3 for python actions. cc @akrabat @csantanapr This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new pull request #4245: Remove unsupported distributed playbooks.
rabbah opened a new pull request #4245: Remove unsupported distributed playbooks. URL: https://github.com/apache/incubator-openwhisk/pull/4245 Removing a number of playbooks for setting up a distributed deployment, including provisioning and setup of VMs (with openstack). The instructions and playbooks have not been touched - for the most part - since their introduction, are untested, and have various bits of rot. I am proposing that we remove them with this PR (as also shared on the dev list). For a distributed deployment with ansible, modifying the local environment's host file should suffice. Further, for swarm or kubernetes the deployment is entirely different also. I am proposing that we remove these files since there's clearly no effort to keep them up to date. As further evidence of rot, there are several open issues dating back to 2016, two open PRs with little attention, and one abandoned PR (closed for reasons cited above). open PRs: https://github.com/apache/incubator-openwhisk/pull/4232 https://github.com/apache/incubator-openwhisk/pull/4107 closed/abandoned PR: https://github.com/apache/incubator-openwhisk/pull/2915 open issues: https://github.com/apache/incubator-openwhisk/issues/3989 https://github.com/apache/incubator-openwhisk/issues/3733 https://github.com/apache/incubator-openwhisk/issues/2220 https://github.com/apache/incubator-openwhisk/issues/4235 ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [x] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #4244: Error when deploying: Failed to initialize reactive invoker
dgrove-oss commented on issue #4244: Error when deploying: Failed to initialize reactive invoker URL: https://github.com/apache/incubator-openwhisk/issues/4244#issuecomment-461055398 Also take a look at https://github.com/apache/incubator-openwhisk-deploy-kube/blob/master/docs/k8s-aws.md. Its been a few months since I actually deployed openwhisk following these instructions, but hopefully they still work. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
