[GitHub] allen-servedio commented on issue #735: Add support for credentials for private git repo dependencies
allen-servedio commented on issue #735: Add support for credentials for private git repo dependencies URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/735#issuecomment-365496411 Where can we add the docs for this fix? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] allen-servedio commented on issue #735: Add support for credentials for private git repo dependencies
allen-servedio commented on issue #735: Add support for credentials for private git repo dependencies URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/735#issuecomment-365482729 Further, this should allow valid urls such as `https://username:passw...@example.com`. This includes alternate hosts such as: `gitlab.com` or `github.ibm.com` (there certainly could be more). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] allen-servedio commented on issue #735: Add support for credentials for private git repo dependencies
allen-servedio commented on issue #735: Add support for credentials for private git repo dependencies URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/735#issuecomment-365480155 At a suggestion from @csantanapr , I tried to add a username + API token to the repo URL. Unfortunately the code to check if it is a github location does not account for this and so you get this error: ``` Error: manifestreader.go [73]: [ERROR_YAML_FILE_FORMAT_ERROR]: File: [manifest.yaml]: ==> Dependency type is unknown. wskdeploy only supports /whisk.system bindings or github.com packages. ==> ``` That, actually, looks easy to fix... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
