[GitHub] chetanmeh commented on a change in pull request #3945: Treat action code as attachments

[GitBox]

chetanmeh commented on a change in pull request #3945: Treat action code as 
attachments
URL: 
https://github.com/apache/incubator-openwhisk/pull/3945#discussion_r209908932
 
 

 ##
 File path: ansible/files/runtimes.json
 ##
 @@ -115,8 +155,8 @@
 },
 "deprecated": false,
 "attached": {
-"attachmentName": "jarfile",
-"attachmentType": "application/java-archive"
+"attachmentName": "codefile",
+"attachmentType": "text/plain"
 
 Review comment:
   Yes `attachmentName` and `attachmentType` are not used in actual flow. 
ContentType is just stored but not interpreted so far for any purpose


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] chetanmeh commented on a change in pull request #3945: Treat action code as attachments

[GitBox]

chetanmeh commented on a change in pull request #3945: Treat action code as 
attachments
URL: 
https://github.com/apache/incubator-openwhisk/pull/3945#discussion_r208257099
 
 

 ##
 File path: common/scala/src/main/scala/whisk/core/entity/Exec.scala
 ##
 @@ -300,33 +300,28 @@ protected[core] object Exec extends ArgNormalizer[Exec] 
with DefaultJsonProtocol
 case None=> throw new DeserializationException(s"kind '$kind' 
not in $runtimes")
   }
 
+  manifest.attached.map { _ =>
+}
+
 
 Review comment:
   Aah ... missed checking prior to push. Fixed it now


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services