[GitHub] chetanmeh commented on issue #3945: Treat action code as attachments
chetanmeh commented on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-413795573 @dubee Is there anything else to be addressed in this PR? Would like to have this merged early next week as there are 3 more PR to be done after this to complete #3944 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3945: Treat action code as attachments
chetanmeh commented on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-413110603 @dubee Good point. Update php runtime entry also to use attachment This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3945: Treat action code as attachments
chetanmeh commented on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-412835996 > you may want to alert the dev-list about this change as it is rather significant. I have sent a mail [on dev][1] sometime back about this change ... would that be ok?. I can also highlight this on wednesday call > have you run performance tests against this to detect any cold start regressions that may arise from the double database fetch? @dubee I modified the `ColdBlockingInvokeSimulation` to support tweaking the code size. So one can run this like below which would result in using a 100kb code size and thus use of attachmentMode. Note that default `max-inline-size` is 16kb so we need a value higher than that default size ``` OPENWHISK_HOST="server" USERS="1" REQUESTS_PER_SEC="1" SECONDS="30" CODE_SIZE="10" ./gradlew gatlingRun-ColdBlockingInvokeSimulation ``` I tried to run the tests but the numbers are not stable | Pre Change | Post Change | |---|---| ||| Numbers for * 1MB code * 30 sec run Below is aggregated stats https://user-images.githubusercontent.com/664531/44088129-a16e683c-9fdf-11e8-9d5f-0c70cdc8c510.png";> As these are run on a local setup with all OpenWhisk component running on same host (client on another) they would not convey any real value. To get true sense of impact we would need to run same test on a more prod like setup where CouchDB is remote and also bit populated otherwise it would be streaming stuff from memory! Unfortunately I do not have access to such a setup so would not be able to get such numbers. [1]: https://lists.apache.org/thread.html/290fbc7cfa54071754afdb62b383018a52586a0953bddebcde500072@%3Cdev.openwhisk.apache.org%3E This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3945: Treat action code as attachments
chetanmeh commented on issue #3945: Treat action code as attachments
URL:
https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-412055273
@dubee new actions would be stored with `code` as object. That format was
already being used by Java actions so should work fine.
```json
{
"code": {
"attachmentName": "couch:f41be90d-5656-47f5-9be9-0d5656f7f555",
"attachmentType": "application/java-archive",
"length": 32768,
"digest":
"sha256-5a373715b8cdcd608059debe9dae2ad95087eb5322321d1d0b862f8330a0e54d"
}
}
```
Is that you were looking for or you meant something else?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] chetanmeh commented on issue #3945: Treat action code as attachments
chetanmeh commented on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-411022379 This PR is ready for review. One aspect which is still to be addressed is should we raise the default `max-inline-size` (defaults 16 KB) to some higher value to offset any potential perf impact on small function. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
