[GitHub] codecov-io commented on issue #3507: allow use of string for controller id
codecov-io commented on issue #3507: allow use of string for controller id URL: https://github.com/apache/incubator-openwhisk/pull/3507#issuecomment-390280747 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=h1) Report > Merging [#3507](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/7bd64743717e12000402600a9079a8579e2da8de?src=pr&el=desc) will **increase** coverage by `0.03%`. > The diff coverage is `53.33%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#3507 +/- ## == + Coverage 75% 75.04% +0.03% == Files 128 128 Lines6081 6086 +5 Branches 398 404 +6 == + Hits 4561 4567 +6 + Misses 1520 1519 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...erpool/kubernetes/KubernetesContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL0t1YmVybmV0ZXNDb250YWluZXJGYWN0b3J5LnNjYWxh) | `0% <ø> (ø)` | :arrow_up: | | [.../src/main/scala/whisk/core/connector/Message.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2Uuc2NhbGE=) | `25.49% <ø> (ø)` | :arrow_up: | | [...isk/core/controller/actions/PrimitiveActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1ByaW1pdGl2ZUFjdGlvbnMuc2NhbGE=) | `87.02% <ø> (ø)` | :arrow_up: | | [.../containerpool/docker/DockerContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9kb2NrZXIvRG9ja2VyQ29udGFpbmVyRmFjdG9yeS5zY2FsYQ==) | `26.66% <ø> (ø)` | :arrow_up: | | [...scala/whisk/core/mesos/MesosContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbWVzb3MvTWVzb3NDb250YWluZXJGYWN0b3J5LnNjYWxh) | `61.81% <ø> (ø)` | :arrow_up: | | [...cala/whisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `91.81% <ø> (ø)` | :arrow_up: | | [...cala/whisk/core/entitlement/LocalEntitlement.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXRsZW1lbnQvTG9jYWxFbnRpdGxlbWVudC5zY2FsYQ==) | `100% <ø> (ø)` | :arrow_up: | | [...la/whisk/core/containerpool/ContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJGYWN0b3J5LnNjYWxh) | `100% <ø> (ø)` | :arrow_up: | | [...n/scala/whisk/core/loadBalancer/LoadBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL0xvYWRCYWxhbmNlci5zY2FsYQ==) | `50% <ø> (ø)` | :arrow_up: | | [...rc/main/scala/whisk/core/controller/RestAPIs.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9SZXN0QVBJcy5zY2FsYQ==) | `46.83% <ø> (ø)` | :arrow_up: | | ... and [10 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=footer). Last update [7bd6474...012bcce](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=lastupdated). Read the [comment docs](https://docs.cod
[GitHub] codecov-io commented on issue #3507: allow use of string for controller id
codecov-io commented on issue #3507: allow use of string for controller id URL: https://github.com/apache/incubator-openwhisk/pull/3507#issuecomment-390280747 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=h1) Report > Merging [#3507](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/7082e947cedafe35bac90df7f54fbce98596d853?src=pr&el=desc) will **increase** coverage by `0.81%`. > The diff coverage is `60.71%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#3507 +/- ## == + Coverage74.5% 75.32% +0.81% == Files 126 128 +2 Lines5994 6087 +93 Branches 392 396 +4 == + Hits 4466 4585 +119 + Misses 1528 1502 -26 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...rc/main/scala/whisk/core/controller/RestAPIs.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9SZXN0QVBJcy5zY2FsYQ==) | `46.83% <ø> (ø)` | :arrow_up: | | [...erpool/kubernetes/KubernetesContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL0t1YmVybmV0ZXNDb250YWluZXJGYWN0b3J5LnNjYWxh) | `0% <ø> (ø)` | :arrow_up: | | [.../src/main/scala/whisk/core/connector/Message.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2Uuc2NhbGE=) | `25.49% <ø> (ø)` | :arrow_up: | | [...n/scala/whisk/core/loadBalancer/LoadBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL0xvYWRCYWxhbmNlci5zY2FsYQ==) | `50% <ø> (ø)` | :arrow_up: | | [...isk/core/controller/actions/PrimitiveActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1ByaW1pdGl2ZUFjdGlvbnMuc2NhbGE=) | `87.02% <ø> (ø)` | :arrow_up: | | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `0% <ø> (ø)` | :arrow_up: | | [.../containerpool/docker/DockerContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9kb2NrZXIvRG9ja2VyQ29udGFpbmVyRmFjdG9yeS5zY2FsYQ==) | `26.66% <ø> (ø)` | :arrow_up: | | [...cala/whisk/core/entitlement/LocalEntitlement.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXRsZW1lbnQvTG9jYWxFbnRpdGxlbWVudC5zY2FsYQ==) | `100% <ø> (ø)` | :arrow_up: | | [...scala/whisk/core/mesos/MesosContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbWVzb3MvTWVzb3NDb250YWluZXJGYWN0b3J5LnNjYWxh) | `61.81% <ø> (ø)` | :arrow_up: | | [...la/whisk/core/containerpool/ContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJGYWN0b3J5LnNjYWxh) | `100% <ø> (ø)` | :arrow_up: | | ... and [29 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=footer). Last update [7082e94...4b193ad](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs
[GitHub] codecov-io commented on issue #3507: allow use of string for controller id
codecov-io commented on issue #3507: allow use of string for controller id URL: https://github.com/apache/incubator-openwhisk/pull/3507#issuecomment-390280747 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=h1) Report > Merging [#3507](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/7082e947cedafe35bac90df7f54fbce98596d853?src=pr&el=desc) will **increase** coverage by `0.81%`. > The diff coverage is `60.71%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#3507 +/- ## == + Coverage74.5% 75.32% +0.81% == Files 126 128 +2 Lines5994 6087 +93 Branches 392 396 +4 == + Hits 4466 4585 +119 + Misses 1528 1502 -26 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...rc/main/scala/whisk/core/controller/RestAPIs.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9SZXN0QVBJcy5zY2FsYQ==) | `46.83% <ø> (ø)` | :arrow_up: | | [...scala/whisk/core/mesos/MesosContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbWVzb3MvTWVzb3NDb250YWluZXJGYWN0b3J5LnNjYWxh) | `61.81% <ø> (ø)` | :arrow_up: | | [...erpool/kubernetes/KubernetesContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL0t1YmVybmV0ZXNDb250YWluZXJGYWN0b3J5LnNjYWxh) | `0% <ø> (ø)` | :arrow_up: | | [...cala/whisk/core/entitlement/LocalEntitlement.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXRsZW1lbnQvTG9jYWxFbnRpdGxlbWVudC5zY2FsYQ==) | `100% <ø> (ø)` | :arrow_up: | | [.../src/main/scala/whisk/core/connector/Message.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2Uuc2NhbGE=) | `25.49% <ø> (ø)` | :arrow_up: | | [...cala/whisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `91.81% <ø> (ø)` | :arrow_up: | | [...isk/core/controller/actions/PrimitiveActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1ByaW1pdGl2ZUFjdGlvbnMuc2NhbGE=) | `87.02% <ø> (ø)` | :arrow_up: | | [...n/scala/whisk/core/loadBalancer/LoadBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL0xvYWRCYWxhbmNlci5zY2FsYQ==) | `50% <ø> (ø)` | :arrow_up: | | [...la/whisk/core/containerpool/ContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJGYWN0b3J5LnNjYWxh) | `100% <ø> (ø)` | :arrow_up: | | [.../containerpool/docker/DockerContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9kb2NrZXIvRG9ja2VyQ29udGFpbmVyRmFjdG9yeS5zY2FsYQ==) | `26.66% <ø> (ø)` | :arrow_up: | | ... and [29 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=footer). Last update [7082e94...4b193ad](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=lastupdated). Read the [comment docs](https://docs.cod
[GitHub] codecov-io commented on issue #3507: allow use of string for controller id
codecov-io commented on issue #3507: allow use of string for controller id URL: https://github.com/apache/incubator-openwhisk/pull/3507#issuecomment-390280747 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=h1) Report > Merging [#3507](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/7082e947cedafe35bac90df7f54fbce98596d853?src=pr&el=desc) will **increase** coverage by `0.59%`. > The diff coverage is `59.25%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#3507 +/- ## == + Coverage74.5% 75.09% +0.59% == Files 126 127 +1 Lines5994 6048 +54 Branches 392 385 -7 == + Hits 4466 4542 +76 + Misses 1528 1506 -22 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...scala/whisk/core/mesos/MesosContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbWVzb3MvTWVzb3NDb250YWluZXJGYWN0b3J5LnNjYWxh) | `61.81% <ø> (ø)` | :arrow_up: | | [...cala/whisk/core/entitlement/LocalEntitlement.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXRsZW1lbnQvTG9jYWxFbnRpdGxlbWVudC5zY2FsYQ==) | `100% <ø> (ø)` | :arrow_up: | | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `0% <ø> (ø)` | :arrow_up: | | [...rc/main/scala/whisk/core/controller/RestAPIs.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9SZXN0QVBJcy5zY2FsYQ==) | `46.83% <ø> (ø)` | :arrow_up: | | [...la/whisk/core/containerpool/ContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJGYWN0b3J5LnNjYWxh) | `100% <ø> (ø)` | :arrow_up: | | [.../src/main/scala/whisk/core/connector/Message.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2Uuc2NhbGE=) | `25.49% <ø> (ø)` | :arrow_up: | | [.../containerpool/docker/DockerContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9kb2NrZXIvRG9ja2VyQ29udGFpbmVyRmFjdG9yeS5zY2FsYQ==) | `26.66% <ø> (ø)` | :arrow_up: | | [...cala/whisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `91.81% <ø> (ø)` | :arrow_up: | | [...erpool/kubernetes/KubernetesContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL0t1YmVybmV0ZXNDb250YWluZXJGYWN0b3J5LnNjYWxh) | `0% <ø> (ø)` | :arrow_up: | | [...n/scala/whisk/core/loadBalancer/LoadBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL0xvYWRCYWxhbmNlci5zY2FsYQ==) | `50% <ø> (ø)` | :arrow_up: | | ... and [26 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=footer). Last update [7082e94...d7520e1](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-reques
[GitHub] codecov-io commented on issue #3507: allow use of string for controller id
codecov-io commented on issue #3507: allow use of string for controller id URL: https://github.com/apache/incubator-openwhisk/pull/3507#issuecomment-390280747 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=h1) Report > Merging [#3507](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/7082e947cedafe35bac90df7f54fbce98596d853?src=pr&el=desc) will **increase** coverage by `0.59%`. > The diff coverage is `59.25%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#3507 +/- ## == + Coverage74.5% 75.09% +0.59% == Files 126 127 +1 Lines5994 6048 +54 Branches 392 385 -7 == + Hits 4466 4542 +76 + Misses 1528 1506 -22 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `0% <ø> (ø)` | :arrow_up: | | [.../containerpool/docker/DockerContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9kb2NrZXIvRG9ja2VyQ29udGFpbmVyRmFjdG9yeS5zY2FsYQ==) | `26.66% <ø> (ø)` | :arrow_up: | | [...isk/core/controller/actions/PrimitiveActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1ByaW1pdGl2ZUFjdGlvbnMuc2NhbGE=) | `87.02% <ø> (ø)` | :arrow_up: | | [...cala/whisk/core/entitlement/LocalEntitlement.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXRsZW1lbnQvTG9jYWxFbnRpdGxlbWVudC5zY2FsYQ==) | `100% <ø> (ø)` | :arrow_up: | | [...cala/whisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `91.81% <ø> (ø)` | :arrow_up: | | [...la/whisk/core/containerpool/ContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJGYWN0b3J5LnNjYWxh) | `100% <ø> (ø)` | :arrow_up: | | [.../src/main/scala/whisk/core/connector/Message.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2Uuc2NhbGE=) | `25.49% <ø> (ø)` | :arrow_up: | | [...rc/main/scala/whisk/core/controller/RestAPIs.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9SZXN0QVBJcy5zY2FsYQ==) | `46.83% <ø> (ø)` | :arrow_up: | | [...scala/whisk/core/mesos/MesosContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbWVzb3MvTWVzb3NDb250YWluZXJGYWN0b3J5LnNjYWxh) | `61.81% <ø> (ø)` | :arrow_up: | | [...n/scala/whisk/core/loadBalancer/LoadBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL0xvYWRCYWxhbmNlci5zY2FsYQ==) | `50% <ø> (ø)` | :arrow_up: | | ... and [26 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=footer). Last update [7082e94...d7520e1](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[GitHub] codecov-io commented on issue #3507: allow use of string for controller id
codecov-io commented on issue #3507: allow use of string for controller id URL: https://github.com/apache/incubator-openwhisk/pull/3507#issuecomment-390280747 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=h1) Report > Merging [#3507](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/7082e947cedafe35bac90df7f54fbce98596d853?src=pr&el=desc) will **increase** coverage by `0.59%`. > The diff coverage is `52.38%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#3507 +/- ## == + Coverage74.5% 75.09% +0.59% == Files 126 127 +1 Lines5994 6048 +54 Branches 392 385 -7 == + Hits 4466 4542 +76 + Misses 1528 1506 -22 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...cala/whisk/core/entitlement/LocalEntitlement.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXRsZW1lbnQvTG9jYWxFbnRpdGxlbWVudC5zY2FsYQ==) | `100% <ø> (ø)` | :arrow_up: | | [...rc/main/scala/whisk/core/controller/RestAPIs.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9SZXN0QVBJcy5zY2FsYQ==) | `46.83% <ø> (ø)` | :arrow_up: | | [...n/scala/whisk/core/loadBalancer/LoadBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL0xvYWRCYWxhbmNlci5zY2FsYQ==) | `50% <ø> (ø)` | :arrow_up: | | [...cala/whisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `91.81% <ø> (ø)` | :arrow_up: | | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `0% <ø> (ø)` | :arrow_up: | | [.../src/main/scala/whisk/core/connector/Message.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2Uuc2NhbGE=) | `25.49% <ø> (ø)` | :arrow_up: | | [...isk/core/controller/actions/PrimitiveActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1ByaW1pdGl2ZUFjdGlvbnMuc2NhbGE=) | `87.02% <ø> (ø)` | :arrow_up: | | [...e/loadBalancer/ShardingContainerPoolBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL1NoYXJkaW5nQ29udGFpbmVyUG9vbEJhbGFuY2VyLnNjYWxh) | `32.54% <0%> (ø)` | :arrow_up: | | [.../main/scala/whisk/core/controller/Controller.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9Db250cm9sbGVyLnNjYWxh) | `0% <0%> (ø)` | :arrow_up: | | [.../whisk/core/database/RemoteCacheInvalidation.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvUmVtb3RlQ2FjaGVJbnZhbGlkYXRpb24uc2NhbGE=) | `0% <0%> (ø)` | :arrow_up: | | ... and [20 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=footer). Last update [7082e94...3d90005](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[GitHub] codecov-io commented on issue #3507: allow use of string for controller id
codecov-io commented on issue #3507: allow use of string for controller id URL: https://github.com/apache/incubator-openwhisk/pull/3507#issuecomment-390280747 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=h1) Report > Merging [#3507](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/7082e947cedafe35bac90df7f54fbce98596d853?src=pr&el=desc) will **increase** coverage by `0.03%`. > The diff coverage is `52.38%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#3507 +/- ## == + Coverage74.5% 74.54% +0.03% == Files 126 126 Lines5994 5999 +5 Branches 392 379 -13 == + Hits 4466 4472 +6 + Misses 1528 1527 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...ain/scala/whisk/core/entitlement/Entitlement.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXRsZW1lbnQvRW50aXRsZW1lbnQuc2NhbGE=) | `76.42% <ø> (ø)` | :arrow_up: | | [...rc/main/scala/whisk/core/controller/RestAPIs.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9SZXN0QVBJcy5zY2FsYQ==) | `46.83% <ø> (ø)` | :arrow_up: | | [...isk/core/controller/actions/PrimitiveActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1ByaW1pdGl2ZUFjdGlvbnMuc2NhbGE=) | `87.02% <ø> (ø)` | :arrow_up: | | [.../src/main/scala/whisk/core/connector/Message.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2Uuc2NhbGE=) | `25.49% <ø> (ø)` | :arrow_up: | | [...cala/whisk/core/entitlement/LocalEntitlement.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXRsZW1lbnQvTG9jYWxFbnRpdGxlbWVudC5zY2FsYQ==) | `100% <ø> (ø)` | :arrow_up: | | [...cala/whisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `91.81% <ø> (ø)` | :arrow_up: | | [...n/scala/whisk/core/loadBalancer/LoadBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL0xvYWRCYWxhbmNlci5zY2FsYQ==) | `50% <ø> (ø)` | :arrow_up: | | [...e/loadBalancer/ShardingContainerPoolBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL1NoYXJkaW5nQ29udGFpbmVyUG9vbEJhbGFuY2VyLnNjYWxh) | `32.54% <0%> (ø)` | :arrow_up: | | [...on/scala/src/main/scala/whisk/common/Logging.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Mb2dnaW5nLnNjYWxh) | `87.35% <0%> (ø)` | :arrow_up: | | [.../main/scala/whisk/core/controller/Controller.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9Db250cm9sbGVyLnNjYWxh) | `0% <0%> (ø)` | :arrow_up: | | ... and [4 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=footer). Last update [7082e94...4f2f357](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --
