[GitHub] dgrove-oss commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes
dgrove-oss commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes URL: https://github.com/apache/incubator-openwhisk/pull/3412#issuecomment-375922506 it won't help with the KubernetesContainerFactory because in that architecture we don't run an invoker on every node. (We run a smaller number of invokers as a StatefulSet + an agent (small & slim; written in Go) on every worker node that handles the interactions with docker. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes
dgrove-oss commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes URL: https://github.com/apache/incubator-openwhisk/pull/3412#issuecomment-375390061 As long as we leave the redundant defaults in application.conf so that kube deploy won't suddenly break, I'm ok with staging things and having duplication for a couple of weeks while the changes flow through. fwiw, in the kube deployments, the pulls are done by an init container that runs before the main invoker container starts. it does the pulls by reading (a duplicated... 😬 ) runtimes.json file. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes
dgrove-oss commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes URL: https://github.com/apache/incubator-openwhisk/pull/3412#issuecomment-374607395 I'd like to have just one place to get these defaults. I like @chetanmeh's suggestion of parsing application.conf into ansible so we could make application.conf available to the non-Scala parts of the system. @markusthoemmes any thoughts? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes
dgrove-oss commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes URL: https://github.com/apache/incubator-openwhisk/pull/3412#issuecomment-374577087 I thought we decided to move the misc defaults to pureconfig (https://github.com/apache/incubator-openwhisk/blob/8fb3a6fda1700b8cde1de300492b1461a176df15/common/scala/src/main/resources/application.conf#L131-#L137) and removed them from ansible. Why do they need to move back to ansible? (we don't use ansible to deploy on kube, which was why moving the defaults out of ansible was desirable) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes
dgrove-oss commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes URL: https://github.com/apache/incubator-openwhisk/pull/3412#issuecomment-374577087 I thought we decided to move the misc defaults to pureconfig (https://github.com/apache/incubator-openwhisk/blob/8fb3a6fda1700b8cde1de300492b1461a176df15/common/scala/src/main/resources/application.conf#L131-#L137) and removed them from ansible. Why do they need to move back to ansible (we don't use ansible to deploy on kube, which was why moving the defaults out of ansible was desirable). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes
dgrove-oss commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes URL: https://github.com/apache/incubator-openwhisk/pull/3412#issuecomment-374577087 I thought we decided to move the misc defaults to pureconfig (https://github.com/apache/incubator-openwhisk/blob/8fb3a6fda1700b8cde1de300492b1461a176df15/common/scala/src/main/resources/application.conf#L131-#L137) and removed them from ansible. Why do they need to move back to ansible (we don't use ansible to deploy on kube, which was why moving the defaults out of ansible was desirable)? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
