[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-321041935 Rebased for API experimental removal conflicts. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320978156 @mdeuser, anything else on this one? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320834166 PG3 976 ? . This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320804315 PG3 976. ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320804315 PG3 975. ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320675253 @mdeuser, any review comments? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320454465 @akrabat, @csantanapr, current code in the PR to has the described functionality. Just needs a final review. Feel free to test it out. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320374587 PG2 1909 ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320375177 @mdeuser, take another look. Made some updates to keep the current semantics in place. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320374587 PG2 1909 ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320043982 With the implementation from this PR action1 will have annotations for key1, key2 and the web annotations when the following commands are executed. `wsk action create action1 --annotation key1 value1` `wsk action update action1 --web true --annotation key2 value2` Without the web flag, the following action would only have they key2 annotation `wsk action create action1 --annotation key1 value1` `wsk action update action1 --annotation key2 value2` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320043982 With the implementation from this PR action1 will have annotations for key1, key2 and the web annotations when the following commands are executed. `wsk action create action1 --annotation key1 value1` `wsk action update action1 --web true --annotation key2 value2` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320042920 What is here works and will fix the issue. Problem is that the action update command with the web flag specified will behave differently than a normal action update as it keeps all existing annotations that action has. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-312331317 @mdeuser, @rabbah, the alternative here would be to always pass in a value of `false` into this line: https://github.com/apache/incubator-openwhisk/blob/master/tools/cli/go-whisk-cli/commands/action.go#L402. Eventually we can allow all the update commands to preserve all annotations/parameters and add a special flag to delete annotations/parameters as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-312331317 @mdeuser, @rabbah, the alternative here would be to always pass in a value of `false` into this line: https://github.com/apache/incubator-openwhisk/blob/master/tools/cli/go-whisk-cli/commands/action.go#L402. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-312299689 @rabbah, recent a change went in that flipped the update flag to `true` for action updates (https://github.com/apache/incubator-openwhisk/commit/9c1f77fdb1e4a7339634434dc90c45026d6a43d2#diff-41c5935cb68718d73fa6ef611c927cc4R100). This enabled the ability to get action annotations that already exist and append new annotations to that list when updating a web action. However, preserving annotations that already exist is not a feature that is synced across commands (package update, trigger update, etc...). As per a conversation with @mdeuser, we are thinking about flipping the update flag back to `flase` so that the same update functionality is used across commands. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
