[GitHub] jonpspri commented on a change in pull request #3358: Update to tools/ubuntu-setup to support xenial and later Ubuntu releases

[GitBox]

jonpspri commented on a change in pull request #3358: Update to 
tools/ubuntu-setup to support xenial and later Ubuntu releases
URL: 
https://github.com/apache/incubator-openwhisk/pull/3358#discussion_r171272313
 
 

 ##
 File path: tools/ubuntu-setup/java8.sh
 ##
 @@ -2,8 +2,10 @@
 set -e
 set -x
 
-sudo apt-get install -y software-properties-common
-sudo add-apt-repository -y ppa:webupd8team/java
-sudo apt-get update -y
-echo oracle-java8-installer shared/accepted-oracle-license-v1-1 select true | 
sudo /usr/bin/debconf-set-selections
-sudo apt-get install -y oracle-java8-installer
+if [ "$(lsb_release -cs)" == "trusty" ]; then
 
 Review comment:
   Just hoping 'jonathonf' keeps his PPA up-to-date until trusty goes EOL.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jonpspri commented on a change in pull request #3358: Update to tools/ubuntu-setup to support xenial and later Ubuntu releases

[GitBox]

jonpspri commented on a change in pull request #3358: Update to 
tools/ubuntu-setup to support xenial and later Ubuntu releases
URL: 
https://github.com/apache/incubator-openwhisk/pull/3358#discussion_r171272124
 
 

 ##
 File path: tools/ubuntu-setup/all.sh
 ##
 @@ -1,4 +1,12 @@
 #!/bin/bash
+
+#  This script can be tested for validity by doing something like:
+#
+#  docker run -v "${OPENWHISK_HOME}:/openwhisk" ubuntu:trusty \
+#sh -c 'apt-get update && apt-get -y install sudo && 
/openwhisk/tools/ubuntu-setup/all.sh'
 
 Review comment:
   Yeah.  It took me a little time to line everything up, but it makes for many 
fewer breaks in production.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jonpspri commented on a change in pull request #3358: Update to tools/ubuntu-setup to support xenial and later Ubuntu releases

[GitBox]

jonpspri commented on a change in pull request #3358: Update to 
tools/ubuntu-setup to support xenial and later Ubuntu releases
URL: 
https://github.com/apache/incubator-openwhisk/pull/3358#discussion_r171019319
 
 

 ##
 File path: tools/ubuntu-setup/all.sh
 ##
 @@ -10,15 +18,35 @@ echo "*** installing basics"
 echo "*** installing python dependences"
 "$SCRIPTDIR/pip.sh"
 
-echo "*** installing java"
-"$SCRIPTDIR/java8.sh"
-
-echo "*** install scala"
-"$SCRIPTDIR/scala.sh"
+u_release="$(lsb_release -rs)"
 
-echo "*** installing docker"
-"$SCRIPTDIR/docker.sh"
+echo "*** installing java"
 
 Review comment:
   Unfortunately, OpenJDK 8 is not available in trusty without jumping through 
the same hoops as 'java.sh' already does.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services