[GitHub] jonpspri commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes
jonpspri commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes URL: https://github.com/apache/incubator-openwhisk/pull/3412#issuecomment-376146865 @dgrove-oss Hmm... so maybe we should eventually factor out an invoker-helper that runs in the worker pods and manages the associated image-space. Or perhaps we defer the whole docker-caching problem up to kube? We can't be the only kube users with that concern... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jonpspri commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes
jonpspri commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes URL: https://github.com/apache/incubator-openwhisk/pull/3412#issuecomment-375919366 @dgrove-oss Yeah, ansible is doing the pulls based on runtimes.json as well, hence some of this stuff. If we get invoker to do its own pulls, does that let you cut out a container? I'm working on the extra Java class now -- probably will have something on Monday. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jonpspri commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes
jonpspri commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes URL: https://github.com/apache/incubator-openwhisk/pull/3412#issuecomment-375385063 I like that approach, _assuming_ we need to continue to pre-pull Docker images in ansible. My preferred approach would be for Invoker to pre-pull its needed images on startup. I’m opening the covers on invoker in my next PR, so can we table this conversation until then? I’m referring #3407 here so we track this conversation. I’ll also add a TODO to the Ansible files where the suspect variables are defined and used so we don’t build in more dependencies. We can disappear them over the next few weeks while the JARs are open. This PRs intention was to do pre-JAR work. Deal? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jonpspri commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes
jonpspri commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes URL: https://github.com/apache/incubator-openwhisk/pull/3412#issuecomment-374627781 I was thinking about something along @chetanmeh ‘s way of thinking. Although I’d rather go the other way... a JSON or YAML config file that is used for configuration of the scala code. Then we’re less likely to run into synchronization problems and edits/overrides are understood. I expect that’s a non-starter from an effort standpoint. Can we leave gradle out of this solution? Ideally in this scenery, one would use ‘shell:’ to invoke an entry point in the invoker jar to dump the JSON to stdout. That way we avoid all sorts of build out-of-sync issues. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jonpspri commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes
jonpspri commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes URL: https://github.com/apache/incubator-openwhisk/pull/3412#issuecomment-374580802 Hi @dgrove-oss, I missed that memo, so forgive me if I’m catching up. Currently there’s logic in the ansible deploy that pre-fetches the images listed in ‘runtime_manifest.json’ and therefore needs to know the defaults as defined in application.conf. Unfortunately, ansible doesn’t natively support parsing application.conf (one of several reasons I dislike the pure config approach). For the time being, that means I do have to keep that separate list of overrides in group_vars/all. Ideally, I’d want to do away with the pre-loading because Controller/Invoker were smart enough to initialize their own runtimes space, but I don’t think we’re there yet. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jonpspri commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes
jonpspri commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes URL: https://github.com/apache/incubator-openwhisk/pull/3412#issuecomment-371650603 ^^^ Rebased in case a fix to the Kafka heisenbug has been committed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
