[GitHub] mgencur commented on a change in pull request #3951: Docs fixes for action invocations
mgencur commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208949464 ## File path: docs/actions.md ## @@ -233,8 +240,11 @@ Each action invocation results in an activation record which contains the follow - `response`: A dictionary that defines the following keys - `status`: The activation result, which might be one of the following values: - *"success"*: the action invocation completed successfully. -- *"application error"*: the action invocation was successful, but the action returned an error value on purpose, for instance because a precondition on the arguments was not met. -- *"action developer error"*: the action was invoked, but it completed abnormally, for instance the action did not detect an exception, or a syntax error existed. +- *"application error"*: the action was invoked, but returned an error value on purpose, for instance because a precondition on the arguments was not met. This status code is also returned under specific conditions such as: + - action timed out Review comment: ok This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mgencur commented on a change in pull request #3951: Docs fixes for action invocations
mgencur commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208949514 ## File path: docs/actions.md ## @@ -233,8 +240,11 @@ Each action invocation results in an activation record which contains the follow - `response`: A dictionary that defines the following keys - `status`: The activation result, which might be one of the following values: - *"success"*: the action invocation completed successfully. -- *"application error"*: the action invocation was successful, but the action returned an error value on purpose, for instance because a precondition on the arguments was not met. -- *"action developer error"*: the action was invoked, but it completed abnormally, for instance the action did not detect an exception, or a syntax error existed. +- *"application error"*: the action was invoked, but returned an error value on purpose, for instance because a precondition on the arguments was not met. This status code is also returned under specific conditions such as: + - action timed out +- *"action developer error"*: the action was invoked, but it completed abnormally, for instance the action did not detect an exception, or a syntax error existed. This status code is also returned under specific conditions such as: + - wrong docker container name + - initialization of a function failed Review comment: ok This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mgencur commented on a change in pull request #3951: Docs fixes for action invocations
mgencur commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208948995 ## File path: docs/actions.md ## @@ -216,10 +216,17 @@ ok: invoked /whisk.system/samples/greeting with id 5975c24de0114ef2b5c24de0118ef A blocking invocation request will _wait_ for the activation result to be available. The wait period is the lesser of 60 seconds or the action's configured [time limit](reference.md#per-action-timeout-ms-default-60s). -The result of the activation is returned if it is available within the wait period. + +The result of the activation is returned if it is available within the blocking wait period (this wait period is by default 60 seconds as well). Otherwise, the activation continues processing in the system and an activation ID is returned so that one may check for the result later, as with non-blocking requests (see [here](#watching-action-output) for tips on monitoring activations). +If execution of the action exceeds the action's configured time limit within the blocking wait period +the result of the invocation is an error caused by the action timeout and the response status is _application error_. Review comment: Could be. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mgencur commented on a change in pull request #3951: Docs fixes for action invocations
mgencur commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208948137 ## File path: docs/actions.md ## @@ -216,10 +216,17 @@ ok: invoked /whisk.system/samples/greeting with id 5975c24de0114ef2b5c24de0118ef A blocking invocation request will _wait_ for the activation result to be available. The wait period is the lesser of 60 seconds or the action's configured [time limit](reference.md#per-action-timeout-ms-default-60s). -The result of the activation is returned if it is available within the wait period. + +The result of the activation is returned if it is available within the blocking wait period (this wait period is by default 60 seconds as well). Otherwise, the activation continues processing in the system and an activation ID is returned so that one may check for the result later, as with non-blocking requests (see [here](#watching-action-output) for tips on monitoring activations). +If execution of the action exceeds the action's configured time limit within the blocking wait period Review comment: Unless the configured time limit is longer than 60 seconds and the blocking wait time is the default. In this case it returns 202 as you said previously? Curious... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mgencur commented on a change in pull request #3951: Docs fixes for action invocations
mgencur commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208947806 ## File path: docs/actions.md ## @@ -216,10 +216,17 @@ ok: invoked /whisk.system/samples/greeting with id 5975c24de0114ef2b5c24de0118ef A blocking invocation request will _wait_ for the activation result to be available. The wait period is the lesser of 60 seconds or the action's configured [time limit](reference.md#per-action-timeout-ms-default-60s). -The result of the activation is returned if it is available within the wait period. + +The result of the activation is returned if it is available within the blocking wait period (this wait period is by default 60 seconds as well). Review comment: AFAIK, the action default timeout is 60 seconds, the blocking wait timeout is by default 60 as well. It could certainly be worded differently but I think it's good as it is. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mgencur commented on a change in pull request #3951: Docs fixes for action invocations
mgencur commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208511709 ## File path: docs/actions.md ## @@ -216,10 +216,11 @@ ok: invoked /whisk.system/samples/greeting with id 5975c24de0114ef2b5c24de0118ef A blocking invocation request will _wait_ for the activation result to be available. The wait period is the lesser of 60 seconds or the action's configured [time limit](reference.md#per-action-timeout-ms-default-60s). -The result of the activation is returned if it is available within the wait period. -Otherwise, the activation continues processing in the system and an activation ID is returned -so that one may check for the result later, as with non-blocking requests -(see [here](#watching-action-output) for tips on monitoring activations). +The result of the action is successfully returned if it is available within the wait period. +Otherwise, the result is an error caused by the action timeout and the response status is _application error_. Review comment: I see. Let me rephrase it then. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mgencur commented on a change in pull request #3951: Docs fixes for action invocations
mgencur commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208507708 ## File path: docs/actions.md ## @@ -233,7 +234,10 @@ Each action invocation results in an activation record which contains the follow - `response`: A dictionary that defines the following keys - `status`: The activation result, which might be one of the following values: - *"success"*: the action invocation completed successfully. -- *"application error"*: the action invocation was successful, but the action returned an error value on purpose, for instance because a precondition on the arguments was not met. +- *"application error"*: the action was invoked, but returned an error value on purpose, for instance because a precondition on the arguments was not met. This status code is also returned under specific conditions such as: + - wrong docker container name + - initialization of a function failed + - action timed out Review comment: OK. Will change it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mgencur commented on a change in pull request #3951: Docs fixes for action invocations
mgencur commented on a change in pull request #3951: Docs fixes for action
invocations
URL:
https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208507380
##
File path: docs/actions.md
##
@@ -216,10 +216,11 @@ ok: invoked /whisk.system/samples/greeting with id
5975c24de0114ef2b5c24de0118ef
A blocking invocation request will _wait_ for the activation result to be
available. The wait period
is the lesser of 60 seconds or the action's configured
[time limit](reference.md#per-action-timeout-ms-default-60s).
-The result of the activation is returned if it is available within the wait
period.
-Otherwise, the activation continues processing in the system and an activation
ID is returned
-so that one may check for the result later, as with non-blocking requests
-(see [here](#watching-action-output) for tips on monitoring activations).
+The result of the action is successfully returned if it is available within
the wait period.
+Otherwise, the result is an error caused by the action timeout and the
response status is _application error_.
Review comment:
This is about blocking invocation. Here's my test:
`wsk action create sleep tests/dat/actions/sleep.js -t 100`
`wsk action invoke sleep --param sleepTimeInMs 1100 --blocking`
The response code is 502 and response itself is:
`ok: invoked /guest/sleep with id 75043a3d2eec4556843a3d2eec855620
{
"activationId": "75043a3d2eec4556843a3d2eec855620",
"annotations": [
{
"key": "path",
"value": "guest/sleep"
},
{
"key": "waitTime",
"value": 1014
},
{
"key": "kind",
"value": "nodejs:6"
},
{
"key": "limits",
"value": {
"logs": 10,
"memory": 256,
"timeout": 100
}
},
{
"key": "initTime",
"value": 152
}
],
"duration": 255,
"end": 1533718832936,
"logs": [],
"name": "sleep",
"namespace": "guest",
"publish": false,
"response": {
"result": {
"error": "The action exceeded its time limits of 100
milliseconds."
},
"status": "application error",
"success": false
},
"start": 1533718832681,
"subject": "guest",
"version": "0.0.1"
}
`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
