[GitHub] rabbah commented on a change in pull request #2582: Use non-blocking techniques when interfacing to Kafka.

2017-08-07 Thread git 
rabbah commented on a change in pull request #2582: Use non-blocking techniques 
when interfacing to Kafka.
URL: 
https://github.com/apache/incubator-openwhisk/pull/2582#discussion_r131738939
 
 

 ##
 File path: 
common/scala/src/main/scala/whisk/connector/kafka/KafkaConsumerConnector.scala
 ##
 @@ -31,6 +31,10 @@ import 
org.apache.kafka.common.serialization.ByteArrayDeserializer
 
 import whisk.common.Logging
 import whisk.core.connector.MessageConsumer
+import org.apache.kafka.clients.consumer.OffsetCommitCallback
+import org.apache.kafka.clients.consumer.OffsetAndMetadata
+import scala.concurrent.Promise
+import org.apache.kafka.common.TopicPartition
 
 Review comment:
   small nit can we sort these imports
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on a change in pull request #2582: Use non-blocking techniques when interfacing to Kafka.

2017-08-07 Thread git 
rabbah commented on a change in pull request #2582: Use non-blocking techniques 
when interfacing to Kafka.
URL: 
https://github.com/apache/incubator-openwhisk/pull/2582#discussion_r131738939
 
 

 ##
 File path: 
common/scala/src/main/scala/whisk/connector/kafka/KafkaConsumerConnector.scala
 ##
 @@ -31,6 +31,10 @@ import 
org.apache.kafka.common.serialization.ByteArrayDeserializer
 
 import whisk.common.Logging
 import whisk.core.connector.MessageConsumer
+import org.apache.kafka.clients.consumer.OffsetCommitCallback
+import org.apache.kafka.clients.consumer.OffsetAndMetadata
+import scala.concurrent.Promise
+import org.apache.kafka.common.TopicPartition
 
 Review comment:
   small nit can we sort these imports
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services