[GitHub] rabbah commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo
rabbah commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo URL: https://github.com/apache/incubator-openwhisk/pull/3467#issuecomment-395131289 @csantanapr I rebased this PR and resolved the conflict. I believe the latest changes address your concerns as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo
rabbah commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo URL: https://github.com/apache/incubator-openwhisk/pull/3467#issuecomment-376338579 actually I think tests/src/test/scala/actionContainers/ActionProxyContainerTests.scala can be made more generic and moved to the common package. The idea being that if one wants to test a specific runtime, they can specify the docker image name and some code samples, leaving the rest of the suite the same. I can work with you seperately on making this trait the base of all the other runtime tests. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo
rabbah commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo URL: https://github.com/apache/incubator-openwhisk/pull/3467#issuecomment-375418860 @jonpspri can you clarify: where will the canonical common code be located after this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo
rabbah commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo URL: https://github.com/apache/incubator-openwhisk/pull/3467#issuecomment-375410482 > Too many repos _blame_ @csantanapr 😅 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo
rabbah commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo URL: https://github.com/apache/incubator-openwhisk/pull/3467#issuecomment-374605804 We will need to designate a single place as the canonical root for the common code. Maybe it can still be this repo. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
