[GitHub] rabbah commented on issue #3507: allow use of string for controller id

2018-06-22 Thread GitBox
rabbah commented on issue #3507: allow use of string for controller id
URL: 
https://github.com/apache/incubator-openwhisk/pull/3507#issuecomment-399611681
 
 
   🤦‍♂️ i thought we merged this already.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rabbah commented on issue #3507: allow use of string for controller id

2018-06-10 Thread GitBox
rabbah commented on issue #3507: allow use of string for controller id
URL: 
https://github.com/apache/incubator-openwhisk/pull/3507#issuecomment-396118741
 
 
   @tysonnorris for the sake of expedience, I rebased your PR and added my 
proposed change.  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rabbah commented on issue #3507: allow use of string for controller id

2018-06-07 Thread GitBox
rabbah commented on issue #3507: allow use of string for controller id
URL: 
https://github.com/apache/incubator-openwhisk/pull/3507#issuecomment-395581898
 
 
   should get a PG.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rabbah commented on issue #3507: allow use of string for controller id

2018-06-05 Thread GitBox
rabbah commented on issue #3507: allow use of string for controller id
URL: 
https://github.com/apache/incubator-openwhisk/pull/3507#issuecomment-394890455
 
 
   I’ll take it. 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rabbah commented on issue #3507: allow use of string for controller id

2018-04-02 Thread GitBox
rabbah commented on issue #3507: allow use of string for controller id
URL: 
https://github.com/apache/incubator-openwhisk/pull/3507#issuecomment-377961536
 
 
   @cbickel's pr to factor out the TID to NGINX is probably better and avoid 
some of the underlying issue (see #3199).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services