[GitHub] underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI
underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI URL: https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-321377908 PG1 1938 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI
underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI URL: https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-321589687 PG1 1939 - Passed This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI
underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI URL: https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-321589607 Update: added code to allow `wsk list` and `wsk namespace get` to properly print rule status. Inadvertently closes #2598. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI
underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI URL: https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-321536578 @dubeejw - please confirm that the issue you raised with the ToHeaderString() functions have been addressed properly? Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI
underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI URL: https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-321532534 @rabbah, test has been moved to `WskBasicUsageTests`. Please confirm where I put it in the test is satisfactory, and if so, I'll tag Carlos for merging. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI
underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI URL: https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-321532534 @rabbah, test has been moved to `WskBasicUsageTests`. Please confirm where I put it in the test is satisfactory, and if so, I'll tag Carlos for merging. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI
underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI URL: https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-321377908 PG2 1931 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI
underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI URL: https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-321321359 Update on latest design: the description of functionality for this PR has been updated in the top comment, but in short: per discussions with @mdeuser, @dubeejw, and @csantanapr, sorting by latest updated time has been made default again, and sorting alphabetically is now done with the flag `--name-sort` or `-n`. On top of working on the review issues raised by @rabbah, I recently removed some unnecessary variable passing and cleaned up a few comments. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI
underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI URL: https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-321251388 PG3 985 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI
underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI URL: https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-320663489 @dubeejw: Sorry for the confusion - @mdeuser and I discussed it in person and over slack last week, and my understanding was to use the flag @rabbah suggested for `--time`, and have lists sort alphabetically by default. This question might still be up in the air? I can switch it back fairly easily, if we need to continue that conversation. :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI
underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI URL: https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-320663489 @dubeejw: Sorry for the confusion - @mdeuser and I discussed it in person and over slack last week, and my understanding was to use the flag @rabbah suggested for `--time`, and have lists sort alphabetically by default. This question might still be up in the air? I can switch it back fairly easily, if we need to continue that conversation. :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI
underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI URL: https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-320644274 @rabbah, @mdeuser, @dubeejw: I've made changes to Alphabetize (reflected in the top comment) as Mark helped me to better understand what we were looking for with this PR last week. I am going in to temporarily remove the `-t` flag from APIs, as we don't necessarily know if they are being returned in order of creation time or not, but other than that (and a few tab errors that I have fixed), Alphabetize has passed PG2 1908. I'm sure that another PG will need to be run after I adjust APIs, but what other feedback could you suggest that I could work on to get Alphabetize merge-ready? Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI
underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI URL: https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-320644274 @rabbah, @mdeuser, @dubeejw: I've made changes to Alphabetize (reflected in the top comment) as Mark helped me to better understand what we were looking for with this PR last week. I am going in to temporarily remove the `-t` flag from APIs, as we don't necessarily know if they are being returned in order of creation time or not, but other than that (and a few tab errors that I have fixed), Alphabetize has passed PG2 #1908. I'm sure that another PG will need to be run after I adjust APIs, but what other feedback could you suggest that I could work on to get Alphabetize merge-ready? Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI
underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI URL: https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-319177053 @rabbah, @mdeuser, @dubeejw : I have a suggested change for Alphabetize. Currently, to order alphabetically, we use the order flag as a bool: `wsk action list --order`. However, with APIs in particular, you have to qualify if you want to sort by action name, or by `Base path`/`Rel path`/`Verb`. This means an additional flag: either something like `wsk api list --order --orderAction`, or `wsk api list --orderAction` for action names, and `wsk api list --order` for the normal sorting. We think we can get more mileage out of passing a string through the `--order` flag instead of it being a bool. Example: `wsk api list --order Alpha` or `wsk api list --order A` to sort alphabetically the usual way, versus `wsk api list --order AlphaAction` or `wsk api list --order N` to sort alphabetically by action name. What were your thoughts on this? In particular: is this a good idea, and if so, what proper naming convention should we set? This could be beneficial later on to have this in place when we want to expand how users could sort a list. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI
underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI URL: https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-319177053 @rabbah, @mdeuser, @dubeejw : I have a suggested change for Alphabetize. Currently, to order alphabetically, we use the order flag as a bool: `wsk action list --order`. However, with APIs in particular, you have to qualify if you want to sort by action name, or by `Base path`/`Rel path`/`Verb`. This means an additional flag: either something like `wsk api list --order --orderAction`, or `wsk api list --orderAction` for action names, and `wsk api list --order` for the normal sorting. We think we can get more mileage out of passing a string through the `--order` flag instead of it being a bool. Example: 'wsk api list --order Alpha' or `wsk api list --order A` to sort alphabetically the usual way, versus `wsk api list --order AlphaAction` or `wsk api list --order N` to sort alphabetically by action name. What were your thoughts on this, in particular with if this is even a good idea, and if so, what proper naming convention should be? This could be beneficial later on to have this in place when we want to expand how users could sort a list. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI
underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI URL: https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-317431813 PG3 918 - failed PG4 594 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI
underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI URL: https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-317497441 PG4 594 Passed This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI
underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI URL: https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-317028556 PG1 1840 - failed PG1 1841 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI
underwoodb-sd-ibm commented on issue #2326: Alphabetize listings in CLI URL: https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-317431813 PG3 918 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
