Re: [PR] HDDS-10517. Recon - Add a UI component for showing DN decommissioning detailed status and info [ozone]
smitajoshi12 commented on PR #6724: URL: https://github.com/apache/ozone/pull/6724#issuecomment-2182061047 @dombizita @devabhishekpal Hi Zita and Abhishek Could you review this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
Re: [PR] HDDS-10517. Recon - Add a UI component for showing DN decommissioning detailed status and info [ozone]
smitajoshi12 commented on PR #6724: URL: https://github.com/apache/ozone/pull/6724#issuecomment-2182055176 > @smitajoshi12 kindly resolve the conflicts in your code. @devmadhuu Hi Devesh Resolved conflicts and merged master with all changes and did testing and pushed changes in latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
Re: [PR] HDDS-10517. Recon - Add a UI component for showing DN decommissioning detailed status and info [ozone]
smitajoshi12 commented on PR #6724: URL: https://github.com/apache/ozone/pull/6724#issuecomment-2175801551 > > > @smitajoshi12 we shouldn't show the initial tool tip from datanodes page "`It is going to decommission soon!!!`". Rather we should call decommission info API and match with what all datanodes are in decommissioning and update their status on UI. Behavior should be consistent across all UI pages for same entity. And also you need to call the decommission info API once , not multiple times as user land up on datanodes page. > > > > > > @devmadhuu Issue with Calling decommision API once is datanode api is called after 1 min if we call decommission API only once then we will not get updated values so checking UUIDs from decommission API and comparision will give incorrect results as i checked with Cluster data. It is going to decommmission soon msg is updated after calling decommision API and datanode API as we discussed previously datanode api is taking time to update records. > > @smitajoshi12 As discussed, pls change the operational state column value based on decommission info API on datanodes page. Showing tooltip is wrong because datanode decommissioning has already started. @devmadhuu I have done changes suggested by you update column manually as comparing uuids from decommission api. If one api fails it will not block other apis attached screenshots. 2 Apis handled synchronously. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
Re: [PR] HDDS-10517. Recon - Add a UI component for showing DN decommissioning detailed status and info [ozone]
devmadhuu commented on PR #6724: URL: https://github.com/apache/ozone/pull/6724#issuecomment-2164559827 > > @smitajoshi12 we shouldn't show the initial tool tip from datanodes page "`It is going to decommission soon!!!`". Rather we should call decommission info API and match with what all datanodes are in decommissioning and update their status on UI. Behavior should be consistent across all UI pages for same entity. And also you need to call the decommission info API once , not multiple times as user land up on datanodes page. > > @devmadhuu Issue with Calling decommision API once is datanode api is called after 1 min if we call decommission API only once then we will not get updated values so checking UUIDs from decommission API and comparision will give incorrect results as i checked with Cluster data. It is going to decommmission soon msg is updated after calling decommision API and datanode API as we discussed previously datanode api is taking time to update records. @smitajoshi12 As discussed, pls change the operational state column value based on decommission info API on datanodes page. Showing tooltip is wrong because datanode decommissioning has already started. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
Re: [PR] HDDS-10517. Recon - Add a UI component for showing DN decommissioning detailed status and info [ozone]
smitajoshi12 commented on PR #6724: URL: https://github.com/apache/ozone/pull/6724#issuecomment-2164510574 > @smitajoshi12 we shouldn't show the initial tool tip from datanodes page "`It is going to decommission soon!!!`". Rather we should call decommission info API and match with what all datanodes are in decommissioning and update their status on UI. Behavior should be consistent across all UI pages for same entity. And also you need to call the decommission info API once , not multiple times as user land up on datanodes page. @devmadhuu Issue with Calling decommision API once is datanode api is called after 1 min if we call decommission API only once then we will not get updated values so checking UUIDs from decommission API and comparision will give incorrect results as i checked with Cluster data. It is going to decommmission soon msg is updated after calling decommision API and datanode API as we discussed previously datanode api is taking time to update records. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
Re: [PR] HDDS-10517. Recon - Add a UI component for showing DN decommissioning detailed status and info [ozone]
devmadhuu commented on PR #6724: URL: https://github.com/apache/ozone/pull/6724#issuecomment-2162146038 @smitajoshi12 we shouldn't show the initial tool tip from datanodes page "`It is going to decommission soon!!!`". Rather we should call decommission info API and match with what all datanodes are in decommissioning and update their status on UI. Behavior should be consistent across all UI pages for same entity. And also you need to call the decommission info API once , not multiple times as user land up on datanodes page. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
Re: [PR] HDDS-10517. Recon - Add a UI component for showing DN decommissioning detailed status and info [ozone]
smitajoshi12 commented on code in PR #6724:
URL: https://github.com/apache/ozone/pull/6724#discussion_r1634522275
##
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/datanodes/decommissionSummary.tsx:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import React from 'react';
+import { Descriptions, Popover, Tooltip, Icon } from 'antd';
+import { withRouter } from 'react-router-dom';
+import { RouteComponentProps } from 'react-router';
+import axios from 'axios';
+import { showDataFetchError } from 'utils/common';
+
+interface IDecommissionSummaryProps extends RouteComponentProps {
Review Comment:
@ArafatKhan2198
Datanodes.tsx is parent component and DecommsionSummary.tsx is child
component as we are passing data from parent to child
Child Component DecommissionSummary extends
React.Component which internally extending parent
class RouteComponent Props in type script so we are defining all props needed
for Decommission summary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
Re: [PR] HDDS-10517. Recon - Add a UI component for showing DN decommissioning detailed status and info [ozone]
smitajoshi12 commented on code in PR #6724:
URL: https://github.com/apache/ozone/pull/6724#discussion_r1634501779
##
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/db.json:
##
@@ -22,7 +22,7 @@
"datanodes": [
{
"hostname": "localhost2.storage.enterprise.com",
-"uuid": "b590734e-a5f2-11ea-bb37-0242ac130002",
+"uuid": "4712ba3d-4bb2-477a-9211-d9b50c013055",
Review Comment:
@ArafatKhan2198 This for Mock Data in Local to show Tooltip as it is going
to decommission soon or local testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
Re: [PR] HDDS-10517. Recon - Add a UI component for showing DN decommissioning detailed status and info [ozone]
ArafatKhan2198 commented on code in PR #6724:
URL: https://github.com/apache/ozone/pull/6724#discussion_r1634421718
##
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/db.json:
##
@@ -742,55 +742,55 @@
"leaderNode": "localhost1.storage.enterprise.com",
"datanodes": [
{
- "level": 0,
- "parent": null,
- "cost": 0,
- "uuid": "9e4e92da-4abd-461d-b042-dc4fe72e8727",
- "uuidString": "9e4e92da-4abd-461d-b042-dc4fe72e8727",
- "ipAddress": "172.22.0.5",
- "hostName": "ozone_datanode_1.ozone_default",
- "ports": [
-{
- "name": "REPLICATION",
- "value": 9886
-},
-{
- "name": "RATIS",
- "value": 9858
-},
-{
- "name": "RATIS_ADMIN",
- "value": 9857
-},
-{
- "name": "RATIS_SERVER",
- "value": 9856
-},
-{
- "name": "RATIS_DATASTREAM",
- "value": 9855
-},
-{
- "name": "STANDALONE",
- "value": 9859
-}
+"level": 0,
+"parent": null,
+"cost": 0,
+"uuid": "9e4e92da-4abd-461d-b042-dc4fe72e8727",
+"uuidString": "9e4e92da-4abd-461d-b042-dc4fe72e8727",
+"ipAddress": "172.22.0.5",
+"hostName": "ozone_datanode_1.ozone_default",
Review Comment:
Could you please revert these changes from the code.
The changes show only tab spaces being added.
##
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/db.json:
##
@@ -22,7 +22,7 @@
"datanodes": [
{
"hostname": "localhost2.storage.enterprise.com",
-"uuid": "b590734e-a5f2-11ea-bb37-0242ac130002",
+"uuid": "4712ba3d-4bb2-477a-9211-d9b50c013055",
Review Comment:
Why did we change the UUID's here?
##
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/datanodes/decommissionSummary.tsx:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import React from 'react';
+import { Descriptions, Popover, Tooltip, Icon } from 'antd';
+import { withRouter } from 'react-router-dom';
+import { RouteComponentProps } from 'react-router';
+import axios from 'axios';
+import { showDataFetchError } from 'utils/common';
+
+interface IDecommissionSummaryProps extends RouteComponentProps {
Review Comment:
Could you please provide a short usage summary of why this is added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
