[GitHub] [phoenix-connectors] stoty opened a new pull request #45: PHOENIX-6253 Change shaded connector jar naming convention
stoty opened a new pull request #45: URL: https://github.com/apache/phoenix-connectors/pull/45 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6253) Change shaded connector jar naming convention
[ https://issues.apache.org/jira/browse/PHOENIX-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247756#comment-17247756 ] ASF GitHub Bot commented on PHOENIX-6253: - stoty opened a new pull request #45: URL: https://github.com/apache/phoenix-connectors/pull/45 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Change shaded connector jar naming convention > - > > Key: PHOENIX-6253 > URL: https://issues.apache.org/jira/browse/PHOENIX-6253 > Project: Phoenix > Issue Type: Improvement > Components: connectors >Affects Versions: connectors-6.0.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > Currently we distinguish the shaded and unshaded connector JARs by moving the > version about. I.e phoenix5-hive-6.0.0 jar is the unshaded JAR, while > phoenix5-6.0.0-hive.jar is the shaded one. > This is unintuitive, and we have already dropped this convention in core. > We could use something like: > phoenix5-spark-6.0.0.jar: the unshaded connector JAR > phoenix5-spark-connector-6.0.0.jar : the default shaded connector JAR > phoenix5-spark-connector-byo-hbase-6.0.0.jar : alternative shaded connector > JAR. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6253) Change shaded connector jar naming convention
[ https://issues.apache.org/jira/browse/PHOENIX-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247757#comment-17247757 ] Istvan Toth commented on PHOENIX-6253: -- I ended up going with the default maven naming conventions in the patch. It's up for discussion of course. > Change shaded connector jar naming convention > - > > Key: PHOENIX-6253 > URL: https://issues.apache.org/jira/browse/PHOENIX-6253 > Project: Phoenix > Issue Type: Improvement > Components: connectors >Affects Versions: connectors-6.0.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > Currently we distinguish the shaded and unshaded connector JARs by moving the > version about. I.e phoenix5-hive-6.0.0 jar is the unshaded JAR, while > phoenix5-6.0.0-hive.jar is the shaded one. > This is unintuitive, and we have already dropped this convention in core. > We could use something like: > phoenix5-spark-6.0.0.jar: the unshaded connector JAR > phoenix5-spark-connector-6.0.0.jar : the default shaded connector JAR > phoenix5-spark-connector-byo-hbase-6.0.0.jar : alternative shaded connector > JAR. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix-connectors] stoty commented on pull request #44: PHOENIX-6261 Reorganise project structure to make mvn versions:set work
stoty commented on pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44#issuecomment-743067734 I've just checked, and there is no need for phoenix-base. Simply reparenting the compatibility modules to phoenix-connectors works just fine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work
[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247765#comment-17247765 ] ASF GitHub Bot commented on PHOENIX-6261: - stoty commented on pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44#issuecomment-743067734 I've just checked, and there is no need for phoenix-base. Simply reparenting the compatibility modules to phoenix-connectors works just fine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reorganise project structure to make mvn versions:set work > -- > > Key: PHOENIX-6261 > URL: https://issues.apache.org/jira/browse/PHOENIX-6261 > Project: Phoenix > Issue Type: Task > Components: connectors, core >Reporter: Richard Antal >Assignee: Richard Antal >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6262) Bulk Load have a bug in lowercase tablename
[
https://issues.apache.org/jira/browse/PHOENIX-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247775#comment-17247775
]
huajie huang commented on PHOENIX-6262:
---
i met the same question :)
> Bulk Load have a bug in lowercase tablename
> ---
>
> Key: PHOENIX-6262
> URL: https://issues.apache.org/jira/browse/PHOENIX-6262
> Project: Phoenix
> Issue Type: Improvement
> Components: core
>Affects Versions: 5.1.0-cdh
>Reporter: zhengjiewen
>Priority: Major
>
> h1. Bulk Load in lowercase tablename
> {color:#172b4d}when I use phoenix bulk load command to import csv file to
> phoenix table，{color} there{color:#172b4d} are get error.{color}
> {code:java}
> //代码占位符
> Exception in thread "main" java.lang.IllegalArgumentException: Table
> "test"."ods_om_om_order_test" not foundException in thread "main"
> java.lang.IllegalArgumentException: Table "test"."ods_om_om_order_test" not
> found at
> org.apache.phoenix.util.SchemaUtil.generateColumnInfo(SchemaUtil.java:956) at
> org.apache.phoenix.mapreduce.AbstractBulkLoadTool.buildImportColumns(AbstractBulkLoadTool.java:377)
> at
> org.apache.phoenix.mapreduce.AbstractBulkLoadTool.loadData(AbstractBulkLoadTool.java:211)
> at
> org.apache.phoenix.mapreduce.AbstractBulkLoadTool.run(AbstractBulkLoadTool.java:180)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) at
> org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90) at
> org.apache.phoenix.mapreduce.CsvBulkLoadTool.main(CsvBulkLoadTool.java:109)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498) at
> org.apache.hadoop.util.RunJar.run(RunJar.java:313) at
> org.apache.hadoop.util.RunJar.main(RunJar.java:227)
> {code}
> my command is ：
> {code:java}
> hadoop jar
> /opt/cloudera/parcels/CDH/lib/hbase/lib/phoenix-5.0.0-cdh6.2.0-client.jar
> org.apache.phoenix.mapreduce.CsvBulkLoadTool -s \"\"test\"\" -t
> \"\"ods_om_om_order_test\"\" -i
> /tmp/phoenix/ods_om_om_order_test5/data.csv{code}
> {color:#172b4d}And I found the source code have a bug in
> *org.apache.phoenix.jdbc.PhoenixDatabaseMetaData#*{color}*getColumns.*
> This method splices the tableName and schemaName into SQL statements to query
> the System.catalog. but if your tableName or schemaName is lowercase，that
> would be the *'"test"'* and *'"ods_om_om_order_test5"'* so that will can not
> query the result and then return table not found exception.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix-connectors] richardantal commented on pull request #44: PHOENIX-6261 Reorganise project structure to make mvn versions:set work
richardantal commented on pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44#issuecomment-743078766 As @stoty pointed out, we don't need to create a common ancestor module here, everything should work fine if we just change the parents of the phoenix-connectors-compat modules. This way the change size can be a reduced by a significant amount. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6262) Bulk Load have a bug in lowercase tablename
[
https://issues.apache.org/jira/browse/PHOENIX-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247779#comment-17247779
]
Fan Zhang commented on PHOENIX-6262:
(y)
> Bulk Load have a bug in lowercase tablename
> ---
>
> Key: PHOENIX-6262
> URL: https://issues.apache.org/jira/browse/PHOENIX-6262
> Project: Phoenix
> Issue Type: Improvement
> Components: core
>Affects Versions: 5.1.0-cdh
>Reporter: zhengjiewen
>Priority: Major
>
> h1. Bulk Load in lowercase tablename
> {color:#172b4d}when I use phoenix bulk load command to import csv file to
> phoenix table，{color} there{color:#172b4d} are get error.{color}
> {code:java}
> //代码占位符
> Exception in thread "main" java.lang.IllegalArgumentException: Table
> "test"."ods_om_om_order_test" not foundException in thread "main"
> java.lang.IllegalArgumentException: Table "test"."ods_om_om_order_test" not
> found at
> org.apache.phoenix.util.SchemaUtil.generateColumnInfo(SchemaUtil.java:956) at
> org.apache.phoenix.mapreduce.AbstractBulkLoadTool.buildImportColumns(AbstractBulkLoadTool.java:377)
> at
> org.apache.phoenix.mapreduce.AbstractBulkLoadTool.loadData(AbstractBulkLoadTool.java:211)
> at
> org.apache.phoenix.mapreduce.AbstractBulkLoadTool.run(AbstractBulkLoadTool.java:180)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) at
> org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90) at
> org.apache.phoenix.mapreduce.CsvBulkLoadTool.main(CsvBulkLoadTool.java:109)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498) at
> org.apache.hadoop.util.RunJar.run(RunJar.java:313) at
> org.apache.hadoop.util.RunJar.main(RunJar.java:227)
> {code}
> my command is ：
> {code:java}
> hadoop jar
> /opt/cloudera/parcels/CDH/lib/hbase/lib/phoenix-5.0.0-cdh6.2.0-client.jar
> org.apache.phoenix.mapreduce.CsvBulkLoadTool -s \"\"test\"\" -t
> \"\"ods_om_om_order_test\"\" -i
> /tmp/phoenix/ods_om_om_order_test5/data.csv{code}
> {color:#172b4d}And I found the source code have a bug in
> *org.apache.phoenix.jdbc.PhoenixDatabaseMetaData#*{color}*getColumns.*
> This method splices the tableName and schemaName into SQL statements to query
> the System.catalog. but if your tableName or schemaName is lowercase，that
> would be the *'"test"'* and *'"ods_om_om_order_test5"'* so that will can not
> query the result and then return table not found exception.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work
[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247780#comment-17247780 ] ASF GitHub Bot commented on PHOENIX-6261: - richardantal commented on pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44#issuecomment-743078766 As @stoty pointed out, we don't need to create a common ancestor module here, everything should work fine if we just change the parents of the phoenix-connectors-compat modules. This way the change size can be a reduced by a significant amount. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reorganise project structure to make mvn versions:set work > -- > > Key: PHOENIX-6261 > URL: https://issues.apache.org/jira/browse/PHOENIX-6261 > Project: Phoenix > Issue Type: Task > Components: connectors, core >Reporter: Richard Antal >Assignee: Richard Antal >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix-connectors] richardantal edited a comment on pull request #44: PHOENIX-6261 Reorganise project structure to make mvn versions:set work
richardantal edited a comment on pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44#issuecomment-743078766 As @stoty pointed out, we don't need to create a common ancestor module here, everything should work fine if we just change the parents of the phoenix-connectors-compat modules. This way the change size can be a reduced by a significant amount. Nice catch, thank you Istvan! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work
[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247782#comment-17247782 ] ASF GitHub Bot commented on PHOENIX-6261: - richardantal edited a comment on pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44#issuecomment-743078766 As @stoty pointed out, we don't need to create a common ancestor module here, everything should work fine if we just change the parents of the phoenix-connectors-compat modules. This way the change size can be a reduced by a significant amount. Nice catch, thank you Istvan! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reorganise project structure to make mvn versions:set work > -- > > Key: PHOENIX-6261 > URL: https://issues.apache.org/jira/browse/PHOENIX-6261 > Project: Phoenix > Issue Type: Task > Components: connectors, core >Reporter: Richard Antal >Assignee: Richard Antal >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix] stoty opened a new pull request #1013: PHOENIX-6261 Reorganise project structure to make mvn versions:set work
stoty opened a new pull request #1013: URL: https://github.com/apache/phoenix/pull/1013 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work
[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247792#comment-17247792 ] ASF GitHub Bot commented on PHOENIX-6261: - stoty opened a new pull request #1013: URL: https://github.com/apache/phoenix/pull/1013 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reorganise project structure to make mvn versions:set work > -- > > Key: PHOENIX-6261 > URL: https://issues.apache.org/jira/browse/PHOENIX-6261 > Project: Phoenix > Issue Type: Task > Components: connectors, core >Reporter: Richard Antal >Assignee: Richard Antal >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix] richardantal commented on pull request #1011: PHOENIX-6261 Reorganise project structure to make mvn versions:set work
richardantal commented on pull request #1011: URL: https://github.com/apache/phoenix/pull/1011#issuecomment-743092985 Changing the parent of the the compat modules works here as well as @stoty pointed out. I am closing it as He has a much smaller change. https://github.com/apache/phoenix/pull/1013 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix] richardantal closed pull request #1011: PHOENIX-6261 Reorganise project structure to make mvn versions:set work
richardantal closed pull request #1011: URL: https://github.com/apache/phoenix/pull/1011 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work
[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247795#comment-17247795 ] ASF GitHub Bot commented on PHOENIX-6261: - richardantal commented on pull request #1011: URL: https://github.com/apache/phoenix/pull/1011#issuecomment-743092985 Changing the parent of the the compat modules works here as well as @stoty pointed out. I am closing it as He has a much smaller change. https://github.com/apache/phoenix/pull/1013 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reorganise project structure to make mvn versions:set work > -- > > Key: PHOENIX-6261 > URL: https://issues.apache.org/jira/browse/PHOENIX-6261 > Project: Phoenix > Issue Type: Task > Components: connectors, core >Reporter: Richard Antal >Assignee: Richard Antal >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work
[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247797#comment-17247797 ] ASF GitHub Bot commented on PHOENIX-6261: - richardantal closed pull request #1011: URL: https://github.com/apache/phoenix/pull/1011 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reorganise project structure to make mvn versions:set work > -- > > Key: PHOENIX-6261 > URL: https://issues.apache.org/jira/browse/PHOENIX-6261 > Project: Phoenix > Issue Type: Task > Components: connectors, core >Reporter: Richard Antal >Assignee: Richard Antal >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6262) Bulk Load have a bug in lowercase tablename
[
https://issues.apache.org/jira/browse/PHOENIX-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247803#comment-17247803
]
chenyuansheng commented on PHOENIX-6262:
How to solve this problem？
> Bulk Load have a bug in lowercase tablename
> ---
>
> Key: PHOENIX-6262
> URL: https://issues.apache.org/jira/browse/PHOENIX-6262
> Project: Phoenix
> Issue Type: Improvement
> Components: core
>Affects Versions: 5.1.0-cdh
>Reporter: zhengjiewen
>Priority: Major
>
> h1. Bulk Load in lowercase tablename
> {color:#172b4d}when I use phoenix bulk load command to import csv file to
> phoenix table，{color} there{color:#172b4d} are get error.{color}
> {code:java}
> //代码占位符
> Exception in thread "main" java.lang.IllegalArgumentException: Table
> "test"."ods_om_om_order_test" not foundException in thread "main"
> java.lang.IllegalArgumentException: Table "test"."ods_om_om_order_test" not
> found at
> org.apache.phoenix.util.SchemaUtil.generateColumnInfo(SchemaUtil.java:956) at
> org.apache.phoenix.mapreduce.AbstractBulkLoadTool.buildImportColumns(AbstractBulkLoadTool.java:377)
> at
> org.apache.phoenix.mapreduce.AbstractBulkLoadTool.loadData(AbstractBulkLoadTool.java:211)
> at
> org.apache.phoenix.mapreduce.AbstractBulkLoadTool.run(AbstractBulkLoadTool.java:180)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) at
> org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90) at
> org.apache.phoenix.mapreduce.CsvBulkLoadTool.main(CsvBulkLoadTool.java:109)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498) at
> org.apache.hadoop.util.RunJar.run(RunJar.java:313) at
> org.apache.hadoop.util.RunJar.main(RunJar.java:227)
> {code}
> my command is ：
> {code:java}
> hadoop jar
> /opt/cloudera/parcels/CDH/lib/hbase/lib/phoenix-5.0.0-cdh6.2.0-client.jar
> org.apache.phoenix.mapreduce.CsvBulkLoadTool -s \"\"test\"\" -t
> \"\"ods_om_om_order_test\"\" -i
> /tmp/phoenix/ods_om_om_order_test5/data.csv{code}
> {color:#172b4d}And I found the source code have a bug in
> *org.apache.phoenix.jdbc.PhoenixDatabaseMetaData#*{color}*getColumns.*
> This method splices the tableName and schemaName into SQL statements to query
> the System.catalog. but if your tableName or schemaName is lowercase，that
> would be the *'"test"'* and *'"ods_om_om_order_test5"'* so that will can not
> query the result and then return table not found exception.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6251) Fix ConcurrentMutationsExtendedIT.testConcurrentUpsertsWithNoIndexedColumns timout issue
[
https://issues.apache.org/jira/browse/PHOENIX-6251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247805#comment-17247805
]
Hadoop QA commented on PHOENIX-6251:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
36s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 12m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 2m
49s{color} | {color:blue} phoenix-core in master has 967 extant spotbugs
warnings. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} spotbugs {color} | {color:green} 3m
0s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}104m 43s{color}
| {color:red} phoenix-core in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
27s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}136m 2s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | phoenix.end2end.IndexVerificationOldDesignIT |
| | phoenix.end2end.join.SubqueryUsingSortMergeJoinIT |
| | phoenix.end2end.SystemTablesCreationOnConnectionIT |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/291/artifact/patchprocess/Dockerfile
|
| JIRA Issue | PHOENIX-6251 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/13016909/PHOENIX-6251.master.000.patch
|
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux dedab52daeff 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 338578b |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| unit |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/291/artifact/patchprocess/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/291/testReport/ |
| Max. process+thread count | 7098 (vs. ulimit of 3) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/291/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was auto
[GitHub] [phoenix-connectors] stoty commented on pull request #45: PHOENIX-6253 Change shaded connector jar naming convention
stoty commented on pull request #45: URL: https://github.com/apache/phoenix-connectors/pull/45#issuecomment-743106065 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 9s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 8m 41s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 22m 50s | master passed | | +1 :green_heart: | compile | 3m 50s | master passed | | +1 :green_heart: | javadoc | 2m 29s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 20m 16s | the patch passed | | +1 :green_heart: | compile | 2m 29s | the patch passed | | +1 :green_heart: | javac | 2m 29s | the patch passed | | -1 :x: | whitespace | 0m 0s | The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | +1 :green_heart: | xml | 0m 12s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 2m 19s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 13m 35s | root in the patch failed. | | +1 :green_heart: | asflicense | 1m 0s | The patch does not generate ASF License warnings. | | | | 82m 9s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-45/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix-connectors/pull/45 | | Optional Tests | dupname asflicense javac javadoc unit xml compile | | uname | Linux fd410b3f225e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-connectors-personality.sh | | git revision | master / 22fe0ce | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-45/1/artifact/yetus-general-check/output/whitespace-eol.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-45/1/artifact/yetus-general-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-45/1/testReport/ | | Max. process+thread count | 1650 (vs. ulimit of 3) | | modules | C: phoenix-hive-base phoenix-pig-base phoenix-kafka-base phoenix-spark-base phoenix4-connectors-assembly phoenix5-connectors-assembly . U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-45/1/console | | versions | git=2.7.4 maven=3.3.9 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6253) Change shaded connector jar naming convention
[ https://issues.apache.org/jira/browse/PHOENIX-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247811#comment-17247811 ] ASF GitHub Bot commented on PHOENIX-6253: - stoty commented on pull request #45: URL: https://github.com/apache/phoenix-connectors/pull/45#issuecomment-743106065 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 9s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 8m 41s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 22m 50s | master passed | | +1 :green_heart: | compile | 3m 50s | master passed | | +1 :green_heart: | javadoc | 2m 29s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 20m 16s | the patch passed | | +1 :green_heart: | compile | 2m 29s | the patch passed | | +1 :green_heart: | javac | 2m 29s | the patch passed | | -1 :x: | whitespace | 0m 0s | The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | +1 :green_heart: | xml | 0m 12s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 2m 19s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 13m 35s | root in the patch failed. | | +1 :green_heart: | asflicense | 1m 0s | The patch does not generate ASF License warnings. | | | | 82m 9s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-45/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix-connectors/pull/45 | | Optional Tests | dupname asflicense javac javadoc unit xml compile | | uname | Linux fd410b3f225e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-connectors-personality.sh | | git revision | master / 22fe0ce | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-45/1/artifact/yetus-general-check/output/whitespace-eol.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-45/1/artifact/yetus-general-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-45/1/testReport/ | | Max. process+thread count | 1650 (vs. ulimit of 3) | | modules | C: phoenix-hive-base phoenix-pig-base phoenix-kafka-base phoenix-spark-base phoenix4-connectors-assembly phoenix5-connectors-assembly . U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-45/1/console | | versions | git=2.7.4 maven=3.3.9 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Change shaded connector jar naming convention > - > > Key: PHOENIX-6253 > URL: https://issues.apache.org/jira/browse/PHOENIX-6253 > Project: Phoenix > Issue Type: Improvement > Components: connectors >Affects Versions: connectors-6.0.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > Currently we distinguish the shaded and unshaded connector JARs by moving the > version about. I.e phoenix5-hive-6.0.0 jar is the unshaded JAR, while > phoenix5-6.0.0-hive.jar is the shaded one. > This is unintuitive, and we have already dropped this convention in core. > We could
[GitHub] [phoenix] stoty opened a new pull request #1014: PHOENIX-6261 Reorganise project structure to make mvn versions:set work
stoty opened a new pull request #1014: URL: https://github.com/apache/phoenix/pull/1014 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work
[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247816#comment-17247816 ] ASF GitHub Bot commented on PHOENIX-6261: - stoty opened a new pull request #1014: URL: https://github.com/apache/phoenix/pull/1014 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reorganise project structure to make mvn versions:set work > -- > > Key: PHOENIX-6261 > URL: https://issues.apache.org/jira/browse/PHOENIX-6261 > Project: Phoenix > Issue Type: Task > Components: connectors, core >Reporter: Richard Antal >Assignee: Richard Antal >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6251) Fix ConcurrentMutationsExtendedIT.testConcurrentUpsertsWithNoIndexedColumns timout issue
[
https://issues.apache.org/jira/browse/PHOENIX-6251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247817#comment-17247817
]
Hadoop QA commented on PHOENIX-6251:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
39s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
1s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} 4.x Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m
53s{color} | {color:green} 4.x passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} 4.x passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
27s{color} | {color:green} 4.x passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} 4.x passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 2m
55s{color} | {color:blue} phoenix-core in 4.x has 951 extant spotbugs warnings.
{color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} spotbugs {color} | {color:green} 3m
7s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}135m 55s{color}
| {color:red} phoenix-core in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
31s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}164m 13s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | phoenix.end2end.index.MutableIndexReplicationIT |
| | phoenix.end2end.index.SaltedIndexIT |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/290/artifact/patchprocess/Dockerfile
|
| JIRA Issue | PHOENIX-6251 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/13016908/PHOENIX-6251.4.x.000.patch
|
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux 0dfe4630aaeb 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / a3b6d0b |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| unit |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/290/artifact/patchprocess/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/290/testReport/ |
| Max. process+thread count | 6839 (vs. ulimit of 3) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/290/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> Fix ConcurrentMutationsExtendedIT.testConcurrentUpsertsWithNoIndexe
[GitHub] [phoenix-connectors] stoty commented on pull request #44: PHOENIX-6261 Reorganise project structure to make mvn versions:set work
stoty commented on pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44#issuecomment-743119197 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 4s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 42 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 8m 18s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 16m 46s | master passed | | +1 :green_heart: | compile | 2m 25s | master passed | | +1 :green_heart: | checkstyle | 2m 29s | master passed | | +1 :green_heart: | javadoc | 5m 7s | master passed | | -1 :x: | scaladoc | 0m 7s | phoenix-connectors-phoenix4-compat in master failed. | | -1 :x: | scaladoc | 0m 7s | phoenix-connectors-phoenix5-compat in master failed. | | -1 :x: | scaladoc | 0m 8s | phoenix-hive-base in master failed. | | -1 :x: | scaladoc | 0m 8s | phoenix-flume-base in master failed. | | -1 :x: | scaladoc | 0m 8s | phoenix-pig-base in master failed. | | -1 :x: | scaladoc | 0m 7s | phoenix4-pig in master failed. | | -1 :x: | scaladoc | 0m 7s | phoenix5-pig in master failed. | | -1 :x: | scaladoc | 0m 8s | phoenix-kafka-base in master failed. | | -1 :x: | scaladoc | 0m 8s | root in master failed. | | -1 :x: | scaladoc | 0m 7s | phoenix4-connectors-assembly in master failed. | | -1 :x: | scaladoc | 0m 8s | phoenix5-connectors-assembly in master failed. | | -1 :x: | scaladoc | 0m 7s | phoenix4-flume in master failed. | | -1 :x: | scaladoc | 0m 8s | phoenix5-flume in master failed. | | -1 :x: | scaladoc | 0m 7s | phoenix4-hive in master failed. | | -1 :x: | scaladoc | 0m 8s | phoenix5-hive in master failed. | | -1 :x: | scaladoc | 0m 7s | phoenix4-kafka in master failed. | | -1 :x: | scaladoc | 0m 8s | phoenix5-kafka in master failed. | | +0 :ok: | spotbugs | 1m 33s | phoenix-hive-base in master has 46 extant spotbugs warnings. | | +0 :ok: | spotbugs | 1m 5s | phoenix-flume-base in master has 9 extant spotbugs warnings. | | +0 :ok: | spotbugs | 1m 0s | phoenix-pig-base in master has 18 extant spotbugs warnings. | | +0 :ok: | spotbugs | 1m 0s | phoenix-kafka-base in master has 3 extant spotbugs warnings. | | +0 :ok: | spotbugs | 1m 59s | phoenix-spark-base in master has 40 extant spotbugs warnings. | | +0 :ok: | spotbugs | 3m 19s | root in master has 116 extant spotbugs warnings. | | +0 :ok: | spotbugs | 0m 41s | phoenix-hive-base/phoenix4-hive in master has 46 extant spotbugs warnings. | | +0 :ok: | spotbugs | 0m 50s | phoenix-hive-base/phoenix5-hive in master has 45 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 16m 23s | the patch passed | | +1 :green_heart: | compile | 2m 17s | the patch passed | | +1 :green_heart: | javac | 2m 17s | the patch passed | | +1 :green_heart: | scalac | 2m 17s | the patch passed | | -1 :x: | checkstyle | 4m 35s | root: The patch generated 4404 new + 4352 unchanged - 26 fixed = 8756 total (was 4378) | | +1 :green_heart: | markdownlint | 0m 3s | There were no new markdownlint issues. | | -1 :x: | whitespace | 0m 1s | The patch has 370 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | -1 :x: | whitespace | 0m 1s | The patch 1025 line(s) with tabs. | | -1 :x: | xml | 0m 42s | The patch has 3 ill-formed XML file(s). | | -1 :x: | javadoc | 0m 48s | phoenix-connectors-base generated 20 new + 0 unchanged - 0 fixed = 20 total (was 0) | | -1 :x: | javadoc | 0m 21s | phoenix-connectors-base_phoenix-hive-base generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0) | | -1 :x: | javadoc | 0m 14s | phoenix-connectors-base_phoenix-hive-base_phoenix4-hive generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) | | -1 :x: | javadoc | 0m 15s | phoenix-connectors-base_phoenix-hive-base_phoenix5-hive generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) | | -1 :x: | javadoc | 0m 16s | phoenix-connectors-base_phoenix-pig-base generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) | | -1 :x: | ja
[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work
[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247830#comment-17247830 ] ASF GitHub Bot commented on PHOENIX-6261: - stoty commented on pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44#issuecomment-743119197 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 4s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 42 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 8m 18s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 16m 46s | master passed | | +1 :green_heart: | compile | 2m 25s | master passed | | +1 :green_heart: | checkstyle | 2m 29s | master passed | | +1 :green_heart: | javadoc | 5m 7s | master passed | | -1 :x: | scaladoc | 0m 7s | phoenix-connectors-phoenix4-compat in master failed. | | -1 :x: | scaladoc | 0m 7s | phoenix-connectors-phoenix5-compat in master failed. | | -1 :x: | scaladoc | 0m 8s | phoenix-hive-base in master failed. | | -1 :x: | scaladoc | 0m 8s | phoenix-flume-base in master failed. | | -1 :x: | scaladoc | 0m 8s | phoenix-pig-base in master failed. | | -1 :x: | scaladoc | 0m 7s | phoenix4-pig in master failed. | | -1 :x: | scaladoc | 0m 7s | phoenix5-pig in master failed. | | -1 :x: | scaladoc | 0m 8s | phoenix-kafka-base in master failed. | | -1 :x: | scaladoc | 0m 8s | root in master failed. | | -1 :x: | scaladoc | 0m 7s | phoenix4-connectors-assembly in master failed. | | -1 :x: | scaladoc | 0m 8s | phoenix5-connectors-assembly in master failed. | | -1 :x: | scaladoc | 0m 7s | phoenix4-flume in master failed. | | -1 :x: | scaladoc | 0m 8s | phoenix5-flume in master failed. | | -1 :x: | scaladoc | 0m 7s | phoenix4-hive in master failed. | | -1 :x: | scaladoc | 0m 8s | phoenix5-hive in master failed. | | -1 :x: | scaladoc | 0m 7s | phoenix4-kafka in master failed. | | -1 :x: | scaladoc | 0m 8s | phoenix5-kafka in master failed. | | +0 :ok: | spotbugs | 1m 33s | phoenix-hive-base in master has 46 extant spotbugs warnings. | | +0 :ok: | spotbugs | 1m 5s | phoenix-flume-base in master has 9 extant spotbugs warnings. | | +0 :ok: | spotbugs | 1m 0s | phoenix-pig-base in master has 18 extant spotbugs warnings. | | +0 :ok: | spotbugs | 1m 0s | phoenix-kafka-base in master has 3 extant spotbugs warnings. | | +0 :ok: | spotbugs | 1m 59s | phoenix-spark-base in master has 40 extant spotbugs warnings. | | +0 :ok: | spotbugs | 3m 19s | root in master has 116 extant spotbugs warnings. | | +0 :ok: | spotbugs | 0m 41s | phoenix-hive-base/phoenix4-hive in master has 46 extant spotbugs warnings. | | +0 :ok: | spotbugs | 0m 50s | phoenix-hive-base/phoenix5-hive in master has 45 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 16m 23s | the patch passed | | +1 :green_heart: | compile | 2m 17s | the patch passed | | +1 :green_heart: | javac | 2m 17s | the patch passed | | +1 :green_heart: | scalac | 2m 17s | the patch passed | | -1 :x: | checkstyle | 4m 35s | root: The patch generated 4404 new + 4352 unchanged - 26 fixed = 8756 total (was 4378) | | +1 :green_heart: | markdownlint | 0m 3s | There were no new markdownlint issues. | | -1 :x: | whitespace | 0m 1s | The patch has 370 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | -1 :x: | whitespace | 0m 1s | The patch 1025 line(s) with tabs. | | -1 :x: | xml | 0m 42s | The patch has 3 ill-formed XML file(s). | | -1 :x: | javadoc | 0m 48s | phoenix-connectors-base generated 20 new + 0 unchanged - 0 fixed = 20 total (was 0) | | -1 :x: | javadoc | 0m 21s | phoenix-connectors-base_phoenix-hive-base generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0) | | -1 :x: | javadoc | 0m 14s | phoenix-connectors-base_phoenix-hive-base_phoenix4-hive generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) | | -1 :x: | javadoc | 0m 15s | phoenix-connect
[GitHub] [phoenix-connectors] virajjasani commented on pull request #44: PHOENIX-6261 Reorganise project structure to make mvn versions:set work
virajjasani commented on pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44#issuecomment-743120231 Nice cleanup, one question: `hbase-common` is not required for `phoenix-connectors-phoenix4-compat`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-connectors] virajjasani edited a comment on pull request #44: PHOENIX-6261 Reorganise project structure to make mvn versions:set work
virajjasani edited a comment on pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44#issuecomment-743120231 Nice cleanup, one question: `hbase-common` is not required as `provided` dependency for `phoenix-connectors-phoenix4-compat`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work
[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247833#comment-17247833 ] ASF GitHub Bot commented on PHOENIX-6261: - virajjasani edited a comment on pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44#issuecomment-743120231 Nice cleanup, one question: `hbase-common` is not required as `provided` dependency for `phoenix-connectors-phoenix4-compat`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reorganise project structure to make mvn versions:set work > -- > > Key: PHOENIX-6261 > URL: https://issues.apache.org/jira/browse/PHOENIX-6261 > Project: Phoenix > Issue Type: Task > Components: connectors, core >Reporter: Richard Antal >Assignee: Richard Antal >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work
[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247832#comment-17247832 ] ASF GitHub Bot commented on PHOENIX-6261: - virajjasani commented on pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44#issuecomment-743120231 Nice cleanup, one question: `hbase-common` is not required for `phoenix-connectors-phoenix4-compat`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reorganise project structure to make mvn versions:set work > -- > > Key: PHOENIX-6261 > URL: https://issues.apache.org/jira/browse/PHOENIX-6261 > Project: Phoenix > Issue Type: Task > Components: connectors, core >Reporter: Richard Antal >Assignee: Richard Antal >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix-connectors] richardantal commented on pull request #44: PHOENIX-6261 Reorganise project structure to make mvn versions:set work
richardantal commented on pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44#issuecomment-743126134 > Nice cleanup, one question: `hbase-common` is not required as `provided` dependency for `phoenix-connectors-phoenix4-compat`? No, it is not. hbase-common is requireed only for the phoenix5 as we import org.apache.hadoop.hbase.TableName; there but in phoenix 4 it is not imported. maven-dependency-plugin:analyze-only marked it as an unused dependency in some of the earlier iterations. I think it did not run earlier on that module so we did not notice it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work
[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247842#comment-17247842 ] ASF GitHub Bot commented on PHOENIX-6261: - richardantal commented on pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44#issuecomment-743126134 > Nice cleanup, one question: `hbase-common` is not required as `provided` dependency for `phoenix-connectors-phoenix4-compat`? No, it is not. hbase-common is requireed only for the phoenix5 as we import org.apache.hadoop.hbase.TableName; there but in phoenix 4 it is not imported. maven-dependency-plugin:analyze-only marked it as an unused dependency in some of the earlier iterations. I think it did not run earlier on that module so we did not notice it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reorganise project structure to make mvn versions:set work > -- > > Key: PHOENIX-6261 > URL: https://issues.apache.org/jira/browse/PHOENIX-6261 > Project: Phoenix > Issue Type: Task > Components: connectors, core >Reporter: Richard Antal >Assignee: Richard Antal >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix-connectors] stoty commented on pull request #44: PHOENIX-6261 Reorganise project structure to make mvn versions:set work
stoty commented on pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44#issuecomment-743145493 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 36s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 8m 1s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 22m 3s | master passed | | +1 :green_heart: | compile | 0m 33s | master passed | | +1 :green_heart: | javadoc | 0m 21s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 20m 13s | the patch passed | | +1 :green_heart: | compile | 0m 36s | the patch passed | | +1 :green_heart: | javac | 0m 36s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 0m 22s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 23s | phoenix-connectors-phoenix4-compat in the patch passed. | | +1 :green_heart: | unit | 0m 27s | phoenix-connectors-phoenix5-compat in the patch passed. | | +1 :green_heart: | asflicense | 0m 17s | The patch does not generate ASF License warnings. | | | | 57m 38s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/7/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix-connectors/pull/44 | | Optional Tests | dupname asflicense javac javadoc unit xml compile | | uname | Linux 144d83357e9d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-connectors-personality.sh | | git revision | master / 22fe0ce | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/7/testReport/ | | Max. process+thread count | 83 (vs. ulimit of 3) | | modules | C: phoenix-connectors-phoenix4-compat phoenix-connectors-phoenix5-compat U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/7/console | | versions | git=2.7.4 maven=3.3.9 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work
[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247861#comment-17247861 ] ASF GitHub Bot commented on PHOENIX-6261: - stoty commented on pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44#issuecomment-743145493 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 36s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 8m 1s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 22m 3s | master passed | | +1 :green_heart: | compile | 0m 33s | master passed | | +1 :green_heart: | javadoc | 0m 21s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 20m 13s | the patch passed | | +1 :green_heart: | compile | 0m 36s | the patch passed | | +1 :green_heart: | javac | 0m 36s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 0m 22s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 23s | phoenix-connectors-phoenix4-compat in the patch passed. | | +1 :green_heart: | unit | 0m 27s | phoenix-connectors-phoenix5-compat in the patch passed. | | +1 :green_heart: | asflicense | 0m 17s | The patch does not generate ASF License warnings. | | | | 57m 38s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/7/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix-connectors/pull/44 | | Optional Tests | dupname asflicense javac javadoc unit xml compile | | uname | Linux 144d83357e9d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-connectors-personality.sh | | git revision | master / 22fe0ce | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/7/testReport/ | | Max. process+thread count | 83 (vs. ulimit of 3) | | modules | C: phoenix-connectors-phoenix4-compat phoenix-connectors-phoenix5-compat U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/7/console | | versions | git=2.7.4 maven=3.3.9 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reorganise project structure to make mvn versions:set work > -- > > Key: PHOENIX-6261 > URL: https://issues.apache.org/jira/browse/PHOENIX-6261 > Project: Phoenix > Issue Type: Task > Components: connectors, core >Reporter: Richard Antal >Assignee: Richard Antal >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix-connectors] stoty closed pull request #44: PHOENIX-6261 Reorganise project structure to make mvn versions:set work
stoty closed pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work
[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247903#comment-17247903 ] ASF GitHub Bot commented on PHOENIX-6261: - stoty closed pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reorganise project structure to make mvn versions:set work > -- > > Key: PHOENIX-6261 > URL: https://issues.apache.org/jira/browse/PHOENIX-6261 > Project: Phoenix > Issue Type: Task > Components: connectors, core >Reporter: Richard Antal >Assignee: Richard Antal >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work
[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247905#comment-17247905 ] Istvan Toth commented on PHOENIX-6261: -- Committed the phoenix-connectors change (minus the gerrit change id) Thanks for the patch and for bringing attention to problem [~RichardAntal] . > Reorganise project structure to make mvn versions:set work > -- > > Key: PHOENIX-6261 > URL: https://issues.apache.org/jira/browse/PHOENIX-6261 > Project: Phoenix > Issue Type: Task > Components: connectors, core >Reporter: Richard Antal >Assignee: Richard Antal >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix] stoty commented on pull request #1013: PHOENIX-6261 Reorganise project structure to make mvn versions:set work
stoty commented on pull request #1013: URL: https://github.com/apache/phoenix/pull/1013#issuecomment-743186057 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 3m 0s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 11m 32s | master passed | | +1 :green_heart: | compile | 1m 25s | master passed | | +1 :green_heart: | javadoc | 2m 32s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 9m 12s | the patch passed | | +1 :green_heart: | compile | 1m 24s | the patch passed | | +1 :green_heart: | javac | 1m 24s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 6s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 2m 35s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 170m 36s | root in the patch failed. | | +1 :green_heart: | asflicense | 1m 35s | The patch does not generate ASF License warnings. | | | | 208m 9s | | | Reason | Tests | |---:|:--| | Failed junit tests | phoenix.end2end.SystemTablesCreationOnConnectionIT | | | phoenix.end2end.IndexVerificationOldDesignIT | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1013/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1013 | | Optional Tests | dupname asflicense javac javadoc unit xml compile | | uname | Linux 1219f27da190 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / 338578b | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1013/1/artifact/yetus-general-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1013/1/testReport/ | | Max. process+thread count | 6164 (vs. ulimit of 3) | | modules | C: phoenix-hbase-compat-2.3.0 phoenix-hbase-compat-2.2.1 phoenix-hbase-compat-2.1.6 phoenix-core . U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1013/1/console | | versions | git=2.7.4 maven=3.3.9 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work
[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247921#comment-17247921 ] ASF GitHub Bot commented on PHOENIX-6261: - stoty commented on pull request #1013: URL: https://github.com/apache/phoenix/pull/1013#issuecomment-743186057 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 3m 0s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 11m 32s | master passed | | +1 :green_heart: | compile | 1m 25s | master passed | | +1 :green_heart: | javadoc | 2m 32s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 9m 12s | the patch passed | | +1 :green_heart: | compile | 1m 24s | the patch passed | | +1 :green_heart: | javac | 1m 24s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 6s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 2m 35s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 170m 36s | root in the patch failed. | | +1 :green_heart: | asflicense | 1m 35s | The patch does not generate ASF License warnings. | | | | 208m 9s | | | Reason | Tests | |---:|:--| | Failed junit tests | phoenix.end2end.SystemTablesCreationOnConnectionIT | | | phoenix.end2end.IndexVerificationOldDesignIT | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1013/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1013 | | Optional Tests | dupname asflicense javac javadoc unit xml compile | | uname | Linux 1219f27da190 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / 338578b | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1013/1/artifact/yetus-general-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1013/1/testReport/ | | Max. process+thread count | 6164 (vs. ulimit of 3) | | modules | C: phoenix-hbase-compat-2.3.0 phoenix-hbase-compat-2.2.1 phoenix-hbase-compat-2.1.6 phoenix-core . U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1013/1/console | | versions | git=2.7.4 maven=3.3.9 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reorganise project structure to make mvn versions:set work > -- > > Key: PHOENIX-6261 > URL: https://issues.apache.org/jira/browse/PHOENIX-6261 > Project: Phoenix > Issue Type: Task > Components: connectors, core >Reporter: Richard Antal >Assignee: Richard Antal >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix-connectors] stoty commented on pull request #45: PHOENIX-6253 Change shaded connector jar naming convention
stoty commented on pull request #45: URL: https://github.com/apache/phoenix-connectors/pull/45#issuecomment-743213150 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 10m 20s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 17m 19s | master passed | | +1 :green_heart: | compile | 2m 15s | master passed | | +1 :green_heart: | javadoc | 2m 20s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 17m 2s | the patch passed | | +1 :green_heart: | compile | 2m 23s | the patch passed | | +1 :green_heart: | javac | 2m 23s | the patch passed | | -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | +1 :green_heart: | xml | 0m 12s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 2m 29s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 10m 17s | root in the patch failed. | | +1 :green_heart: | asflicense | 0m 58s | The patch does not generate ASF License warnings. | | | | 67m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-45/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix-connectors/pull/45 | | Optional Tests | dupname asflicense javac javadoc unit xml compile | | uname | Linux 8acdac3e4279 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-connectors-personality.sh | | git revision | master / aff86a2 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-45/2/artifact/yetus-general-check/output/whitespace-eol.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-45/2/artifact/yetus-general-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-45/2/testReport/ | | Max. process+thread count | 1707 (vs. ulimit of 3) | | modules | C: phoenix-hive-base phoenix-pig-base phoenix-kafka-base phoenix-spark-base phoenix4-connectors-assembly phoenix5-connectors-assembly . U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-45/2/console | | versions | git=2.7.4 maven=3.3.9 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6253) Change shaded connector jar naming convention
[ https://issues.apache.org/jira/browse/PHOENIX-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247941#comment-17247941 ] ASF GitHub Bot commented on PHOENIX-6253: - stoty commented on pull request #45: URL: https://github.com/apache/phoenix-connectors/pull/45#issuecomment-743213150 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 10m 20s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 17m 19s | master passed | | +1 :green_heart: | compile | 2m 15s | master passed | | +1 :green_heart: | javadoc | 2m 20s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 17m 2s | the patch passed | | +1 :green_heart: | compile | 2m 23s | the patch passed | | +1 :green_heart: | javac | 2m 23s | the patch passed | | -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | +1 :green_heart: | xml | 0m 12s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 2m 29s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 10m 17s | root in the patch failed. | | +1 :green_heart: | asflicense | 0m 58s | The patch does not generate ASF License warnings. | | | | 67m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-45/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix-connectors/pull/45 | | Optional Tests | dupname asflicense javac javadoc unit xml compile | | uname | Linux 8acdac3e4279 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-connectors-personality.sh | | git revision | master / aff86a2 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-45/2/artifact/yetus-general-check/output/whitespace-eol.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-45/2/artifact/yetus-general-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-45/2/testReport/ | | Max. process+thread count | 1707 (vs. ulimit of 3) | | modules | C: phoenix-hive-base phoenix-pig-base phoenix-kafka-base phoenix-spark-base phoenix4-connectors-assembly phoenix5-connectors-assembly . U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-45/2/console | | versions | git=2.7.4 maven=3.3.9 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Change shaded connector jar naming convention > - > > Key: PHOENIX-6253 > URL: https://issues.apache.org/jira/browse/PHOENIX-6253 > Project: Phoenix > Issue Type: Improvement > Components: connectors >Affects Versions: connectors-6.0.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > Currently we distinguish the shaded and unshaded connector JARs by moving the > version about. I.e phoenix5-hive-6.0.0 jar is the unshaded JAR, while > phoenix5-6.0.0-hive.jar is the shaded one. > This is unintuitive, and we have already dropped this convention in core. > We could
[jira] [Commented] (PHOENIX-6207) Paged server side grouped aggregate operations
[ https://issues.apache.org/jira/browse/PHOENIX-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248160#comment-17248160 ] Kadir OZDEMIR commented on PHOENIX-6207: [~comnetwork], I have posted the design doc for server paging at PHOENIX-6211. You can also review the PR there. I would like to acknowledge that I have followed your suggestion and set the default the page time to 90% of the HBase RPC timeout. I look forward to your feedback. Thanks! > Paged server side grouped aggregate operations > -- > > Key: PHOENIX-6207 > URL: https://issues.apache.org/jira/browse/PHOENIX-6207 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 5.0.0, 4.14.3 >Reporter: Kadir OZDEMIR >Assignee: Kadir OZDEMIR >Priority: Major > Fix For: 4.16.0 > > Attachments: PHOENIX-6207.4.x.001.patch, PHOENIX-6207.4.x.002.patch, > PHOENIX-6207.4.x.003.patch, PHOENIX-6207.4.x.004.patch, > PHOENIX-6207.4.x.005.patch, PHOENIX-6207.4.x.006.patch, > PHOENIX-6207.master.001.patch, PHOENIX-6207.master.002.patch > > > Phoenix provides the option of performing query operations on the client or > server side. This is decided by the Phoenix optimizer based on configuration > parameters. For the server side option, the table operation is parallelized > such that multiple table regions are scanned. However, currently there is no > paging capability and the server side operation can take long enough lead to > HBase client timeouts. Putting a limit on the processing time within a single > RPC call (i.e., the next operation time on the aggregate scanner) on the > server side using a Phoenix level paging is highly desirable. A similar > paging mechanism has been already implemented for index rebuild and > verification operations and proven to be effective to prevent timeouts. This > Jira is for implementing this paging for the server side grouped aggregate > operations. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (PHOENIX-6207) Paged server side grouped aggregate operations
[ https://issues.apache.org/jira/browse/PHOENIX-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248160#comment-17248160 ] Kadir OZDEMIR edited comment on PHOENIX-6207 at 12/11/20, 8:28 PM: --- [~comnetwork], I have posted the design doc for server paging at PHOENIX-6211. You can also review the PR there. I would like to acknowledge that I have followed your suggestion and set the default page time to 90% of the HBase RPC timeout. I look forward to your feedback. Thanks! was (Author: kozdemir): [~comnetwork], I have posted the design doc for server paging at PHOENIX-6211. You can also review the PR there. I would like to acknowledge that I have followed your suggestion and set the default the page time to 90% of the HBase RPC timeout. I look forward to your feedback. Thanks! > Paged server side grouped aggregate operations > -- > > Key: PHOENIX-6207 > URL: https://issues.apache.org/jira/browse/PHOENIX-6207 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 5.0.0, 4.14.3 >Reporter: Kadir OZDEMIR >Assignee: Kadir OZDEMIR >Priority: Major > Fix For: 4.16.0 > > Attachments: PHOENIX-6207.4.x.001.patch, PHOENIX-6207.4.x.002.patch, > PHOENIX-6207.4.x.003.patch, PHOENIX-6207.4.x.004.patch, > PHOENIX-6207.4.x.005.patch, PHOENIX-6207.4.x.006.patch, > PHOENIX-6207.master.001.patch, PHOENIX-6207.master.002.patch > > > Phoenix provides the option of performing query operations on the client or > server side. This is decided by the Phoenix optimizer based on configuration > parameters. For the server side option, the table operation is parallelized > such that multiple table regions are scanned. However, currently there is no > paging capability and the server side operation can take long enough lead to > HBase client timeouts. Putting a limit on the processing time within a single > RPC call (i.e., the next operation time on the aggregate scanner) on the > server side using a Phoenix level paging is highly desirable. A similar > paging mechanism has been already implemented for index rebuild and > verification operations and proven to be effective to prevent timeouts. This > Jira is for implementing this paging for the server side grouped aggregate > operations. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6250) Fix ViewMetadataIT test flapper
[
https://issues.apache.org/jira/browse/PHOENIX-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248184#comment-17248184
]
Xinyi Yan commented on PHOENIX-6250:
hi [~ckulkarni],
[https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/288/] is the last
Hadoop QA run trigged by me.
> Fix ViewMetadataIT test flapper
> ---
>
> Key: PHOENIX-6250
> URL: https://issues.apache.org/jira/browse/PHOENIX-6250
> Project: Phoenix
> Issue Type: Improvement
>Reporter: Xinyi Yan
>Priority: Major
> Fix For: 4.16.0
>
> Attachments: PHOENIX-6250.4.x.v2.patch
>
>
> ViewMetadataIT failed multi-times at 4.x branch.
> Here is the logging:
> {code:java}
> 17:32:58 [ERROR] Tests run: 25, Failures: 1, Errors: 0, Skipped: 0, Time
> elapsed: 353.71 s <<< FAILURE! - in org.apache.phoenix.end2end.ViewMetadataIT
> 17:32:58 [ERROR]
> testRepeatedCreateAndDropCascadeTableWorks(org.apache.phoenix.end2end.ViewMetadataIT)
> Time elapsed: 11.52 s <<< FAILURE!
> 17:32:58 java.lang.AssertionError: View SCHEMA2.N74 should have been
> deleted when parent was dropped
> 17:32:58 at org.junit.Assert.fail(Assert.java:89)
> 17:32:58 at
> org.apache.phoenix.end2end.ViewMetadataIT.validateViewDoesNotExist(ViewMetadataIT.java:1373)
> 17:32:58 at
> org.apache.phoenix.end2end.ViewMetadataIT.testRepeatedCreateAndDropCascadeTableWorks(ViewMetadataIT.java:818)
> 17:32:58 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 17:32:58 at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 17:32:58 at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 17:32:58 at java.lang.reflect.Method.invoke(Method.java:498)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6252) Fix BackwardCompatibilityIT test flapper
[ https://issues.apache.org/jira/browse/PHOENIX-6252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248187#comment-17248187 ] Xinyi Yan commented on PHOENIX-6252: [https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/287/] for the master patch > Fix BackwardCompatibilityIT test flapper > > > Key: PHOENIX-6252 > URL: https://issues.apache.org/jira/browse/PHOENIX-6252 > Project: Phoenix > Issue Type: Improvement >Reporter: Xinyi Yan >Assignee: Xinyi Yan >Priority: Major > Fix For: 4.16.0 > > Attachments: PHOENIX-6252.4.x.v1.patch, PHOENIX-6252.master.v2.patch > > > BackwardCompatibilityIT failed 4 out of the last 10 runs. > > [https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-mulitbranch/job/4.x/135/testReport/org.apache.phoenix.end2end/BackwardCompatibilityIT/MatrixBuild___Matrix___HBASE_PROFILE1_4BuildAndTest___testSystemTaskCreationWithIndexAsyncRebuild_BackwardCompatibilityIT_compatibleClientVersion_4_15_0_HBase_1_4_/] > https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-mulitbranch/job/4.x/128/testReport/org.apache.phoenix.end2end/BackwardCompatibilityIT/MatrixBuild___Matrix___HBASE_PROFILE1_4BuildAndTest___testSystemTaskCreationWithIndexAsyncRebuild_BackwardCompatibilityIT_compatibleClientVersion_4_15_0_HBase_1_4_/ > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix] gjacoby126 commented on a change in pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata
gjacoby126 commented on a change in pull request #913:
URL: https://github.com/apache/phoenix/pull/913#discussion_r541345592
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java
##
@@ -400,7 +400,6 @@ protected boolean isRegionObserverFor(Scan scan) {
* Used for an aggregate query in which the key order does not necessarily
match the group by
* key order. In this case, we must collect all distinct groups within a
region into a map,
* aggregating as we go.
- * @param limit TODO
Review comment:
Removed the params from the Javadoc as they were Javadoc errors.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata
[
https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248209#comment-17248209
]
ASF GitHub Bot commented on PHOENIX-5435:
-
gjacoby126 commented on a change in pull request #913:
URL: https://github.com/apache/phoenix/pull/913#discussion_r541345592
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java
##
@@ -400,7 +400,6 @@ protected boolean isRegionObserverFor(Scan scan) {
* Used for an aggregate query in which the key order does not necessarily
match the group by
* key order. In this case, we must collect all distinct groups within a
region into a map,
* aggregating as we go.
- * @param limit TODO
Review comment:
Removed the params from the Javadoc as they were Javadoc errors.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Annotate HBase WALs with Phoenix Metadata
> -
>
> Key: PHOENIX-5435
> URL: https://issues.apache.org/jira/browse/PHOENIX-5435
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: Geoffrey Jacoby
>Assignee: Geoffrey Jacoby
>Priority: Major
> Attachments: PHOENIX-5435-4.x.patch
>
>
> HBase write-ahead-logs (WALs) drive not only failure recovery, but HBase
> replication and some HBase backup frameworks. The WALs contain HBase-level
> metadata such as table and region, but lack Phoenix-level metadata. That
> means that it's quite difficult to build correct logic that needs to know
> about Phoenix-level constructs such as multi-tenancy, views, or indexes.
> HBASE-22622 and HBASE-22623 add the capacity for coprocessors to annotate
> extra key/value pairs of metadata into the HBase WAL. We should have the
> option to annotate the tuple , or
> some hashed way to reconstruct that tuple into the WAL. It should have a
> feature toggle so operators who don't need it don't bear the slight extra
> storage cost.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix] gjacoby126 commented on a change in pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata
gjacoby126 commented on a change in pull request #913: URL: https://github.com/apache/phoenix/pull/913#discussion_r541346794 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java ## @@ -1160,6 +1169,12 @@ private PTable getTable(RegionScanner scanner, long clientTimeStamp, long tableT null : PLong.INSTANCE.getCodec().decodeLong(lastDDLTimestampKv.getValueArray(), lastDDLTimestampKv.getValueOffset(), SortOrder.getDefault()); +Cell changeDetectionEnabledKv = tableKeyValues[CHANGE_DETECTION_ENABLED_INDEX]; +boolean isChangeDetectionEnabled = changeDetectionEnabledKv != null Review comment: Since it's an optional field in the protobuf and the old client won't even know to deserialize it I don't think it would cause a problem. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix] gjacoby126 commented on a change in pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata
gjacoby126 commented on a change in pull request #913: URL: https://github.com/apache/phoenix/pull/913#discussion_r541347335 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionScanner.java ## @@ -64,6 +64,7 @@ import org.apache.phoenix.cache.GlobalCache; import org.apache.phoenix.cache.TenantCache; import org.apache.phoenix.exception.DataExceedsCapacityException; +import org.apache.phoenix.execute.MutationState; Review comment: removed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata
[ https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248211#comment-17248211 ] ASF GitHub Bot commented on PHOENIX-5435: - gjacoby126 commented on a change in pull request #913: URL: https://github.com/apache/phoenix/pull/913#discussion_r541346794 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java ## @@ -1160,6 +1169,12 @@ private PTable getTable(RegionScanner scanner, long clientTimeStamp, long tableT null : PLong.INSTANCE.getCodec().decodeLong(lastDDLTimestampKv.getValueArray(), lastDDLTimestampKv.getValueOffset(), SortOrder.getDefault()); +Cell changeDetectionEnabledKv = tableKeyValues[CHANGE_DETECTION_ENABLED_INDEX]; +boolean isChangeDetectionEnabled = changeDetectionEnabledKv != null Review comment: Since it's an optional field in the protobuf and the old client won't even know to deserialize it I don't think it would cause a problem. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Annotate HBase WALs with Phoenix Metadata > - > > Key: PHOENIX-5435 > URL: https://issues.apache.org/jira/browse/PHOENIX-5435 > Project: Phoenix > Issue Type: Sub-task >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Attachments: PHOENIX-5435-4.x.patch > > > HBase write-ahead-logs (WALs) drive not only failure recovery, but HBase > replication and some HBase backup frameworks. The WALs contain HBase-level > metadata such as table and region, but lack Phoenix-level metadata. That > means that it's quite difficult to build correct logic that needs to know > about Phoenix-level constructs such as multi-tenancy, views, or indexes. > HBASE-22622 and HBASE-22623 add the capacity for coprocessors to annotate > extra key/value pairs of metadata into the HBase WAL. We should have the > option to annotate the tuple , or > some hashed way to reconstruct that tuple into the WAL. It should have a > feature toggle so operators who don't need it don't bear the slight extra > storage cost. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata
[ https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248212#comment-17248212 ] ASF GitHub Bot commented on PHOENIX-5435: - gjacoby126 commented on a change in pull request #913: URL: https://github.com/apache/phoenix/pull/913#discussion_r541347335 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionScanner.java ## @@ -64,6 +64,7 @@ import org.apache.phoenix.cache.GlobalCache; import org.apache.phoenix.cache.TenantCache; import org.apache.phoenix.exception.DataExceedsCapacityException; +import org.apache.phoenix.execute.MutationState; Review comment: removed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Annotate HBase WALs with Phoenix Metadata > - > > Key: PHOENIX-5435 > URL: https://issues.apache.org/jira/browse/PHOENIX-5435 > Project: Phoenix > Issue Type: Sub-task >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Attachments: PHOENIX-5435-4.x.patch > > > HBase write-ahead-logs (WALs) drive not only failure recovery, but HBase > replication and some HBase backup frameworks. The WALs contain HBase-level > metadata such as table and region, but lack Phoenix-level metadata. That > means that it's quite difficult to build correct logic that needs to know > about Phoenix-level constructs such as multi-tenancy, views, or indexes. > HBASE-22622 and HBASE-22623 add the capacity for coprocessors to annotate > extra key/value pairs of metadata into the HBase WAL. We should have the > option to annotate the tuple , or > some hashed way to reconstruct that tuple into the WAL. It should have a > feature toggle so operators who don't need it don't bear the slight extra > storage cost. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix] gjacoby126 commented on a change in pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata
gjacoby126 commented on a change in pull request #913:
URL: https://github.com/apache/phoenix/pull/913#discussion_r541349997
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionScanner.java
##
@@ -609,6 +613,9 @@ public boolean next(List resultsToReturn) throws
IOException {
} while (hasMore &&
(EnvironmentEdgeManager.currentTimeMillis() - startTime) < pageSizeInMs);
if (!mutations.isEmpty()) {
+if (isDelete || isUpsert) {
+annotateDataMutations(mutations, scan);
+}
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix] gjacoby126 commented on a change in pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata
gjacoby126 commented on a change in pull request #913:
URL: https://github.com/apache/phoenix/pull/913#discussion_r541350748
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionScanner.java
##
@@ -644,4 +651,33 @@ public boolean next(List resultsToReturn) throws
IOException {
public long getMaxResultSize() {
return scan.getMaxResultSize();
}
+
+private void
annotateDataMutations(UngroupedAggregateRegionObserver.MutationList
mutationsList,
+ Scan scan) {
+byte[] tenantId = null;
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata
[
https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248214#comment-17248214
]
ASF GitHub Bot commented on PHOENIX-5435:
-
gjacoby126 commented on a change in pull request #913:
URL: https://github.com/apache/phoenix/pull/913#discussion_r541349997
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionScanner.java
##
@@ -609,6 +613,9 @@ public boolean next(List resultsToReturn) throws
IOException {
} while (hasMore &&
(EnvironmentEdgeManager.currentTimeMillis() - startTime) < pageSizeInMs);
if (!mutations.isEmpty()) {
+if (isDelete || isUpsert) {
+annotateDataMutations(mutations, scan);
+}
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Annotate HBase WALs with Phoenix Metadata
> -
>
> Key: PHOENIX-5435
> URL: https://issues.apache.org/jira/browse/PHOENIX-5435
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: Geoffrey Jacoby
>Assignee: Geoffrey Jacoby
>Priority: Major
> Attachments: PHOENIX-5435-4.x.patch
>
>
> HBase write-ahead-logs (WALs) drive not only failure recovery, but HBase
> replication and some HBase backup frameworks. The WALs contain HBase-level
> metadata such as table and region, but lack Phoenix-level metadata. That
> means that it's quite difficult to build correct logic that needs to know
> about Phoenix-level constructs such as multi-tenancy, views, or indexes.
> HBASE-22622 and HBASE-22623 add the capacity for coprocessors to annotate
> extra key/value pairs of metadata into the HBase WAL. We should have the
> option to annotate the tuple , or
> some hashed way to reconstruct that tuple into the WAL. It should have a
> feature toggle so operators who don't need it don't bear the slight extra
> storage cost.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata
[
https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248215#comment-17248215
]
ASF GitHub Bot commented on PHOENIX-5435:
-
gjacoby126 commented on a change in pull request #913:
URL: https://github.com/apache/phoenix/pull/913#discussion_r541350748
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionScanner.java
##
@@ -644,4 +651,33 @@ public boolean next(List resultsToReturn) throws
IOException {
public long getMaxResultSize() {
return scan.getMaxResultSize();
}
+
+private void
annotateDataMutations(UngroupedAggregateRegionObserver.MutationList
mutationsList,
+ Scan scan) {
+byte[] tenantId = null;
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Annotate HBase WALs with Phoenix Metadata
> -
>
> Key: PHOENIX-5435
> URL: https://issues.apache.org/jira/browse/PHOENIX-5435
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: Geoffrey Jacoby
>Assignee: Geoffrey Jacoby
>Priority: Major
> Attachments: PHOENIX-5435-4.x.patch
>
>
> HBase write-ahead-logs (WALs) drive not only failure recovery, but HBase
> replication and some HBase backup frameworks. The WALs contain HBase-level
> metadata such as table and region, but lack Phoenix-level metadata. That
> means that it's quite difficult to build correct logic that needs to know
> about Phoenix-level constructs such as multi-tenancy, views, or indexes.
> HBASE-22622 and HBASE-22623 add the capacity for coprocessors to annotate
> extra key/value pairs of metadata into the HBase WAL. We should have the
> option to annotate the tuple , or
> some hashed way to reconstruct that tuple into the WAL. It should have a
> feature toggle so operators who don't need it don't bear the slight extra
> storage cost.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix] gjacoby126 commented on a change in pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata
gjacoby126 commented on a change in pull request #913:
URL: https://github.com/apache/phoenix/pull/913#discussion_r541362377
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java
##
@@ -682,6 +687,49 @@ private void generateMutations(final TableRef tableRef,
final long mutationTimes
values.putAll(modifiedValues);
}
+public static void annotateMutationsWithMetadata(PTable table,
List rowMutations) {
+//only annotate if the change detection flag is on the table and HBase
supports
+// preWALAppend coprocs server-side
+if (table == null || !table.isChangeDetectionEnabled()
+|| !HbaseCompatCapabilities.hasPreWALAppend()) {
+return;
+}
+//annotate each mutation with enough metadata so that anyone
interested can
+// deterministically figure out exactly what Phoenix schema object
created the mutation
+// Server-side we can annotate the HBase WAL with these.
+for (Mutation mutation : rowMutations) {
+annotateMutationWithMetadata(table, mutation);
+}
+
+}
+
+public static void annotateMutationWithMetadata(PTable table, Mutation
mutation) {
Review comment:
Switched to private
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata
[
https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248221#comment-17248221
]
ASF GitHub Bot commented on PHOENIX-5435:
-
gjacoby126 commented on a change in pull request #913:
URL: https://github.com/apache/phoenix/pull/913#discussion_r541362377
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java
##
@@ -682,6 +687,49 @@ private void generateMutations(final TableRef tableRef,
final long mutationTimes
values.putAll(modifiedValues);
}
+public static void annotateMutationsWithMetadata(PTable table,
List rowMutations) {
+//only annotate if the change detection flag is on the table and HBase
supports
+// preWALAppend coprocs server-side
+if (table == null || !table.isChangeDetectionEnabled()
+|| !HbaseCompatCapabilities.hasPreWALAppend()) {
+return;
+}
+//annotate each mutation with enough metadata so that anyone
interested can
+// deterministically figure out exactly what Phoenix schema object
created the mutation
+// Server-side we can annotate the HBase WAL with these.
+for (Mutation mutation : rowMutations) {
+annotateMutationWithMetadata(table, mutation);
+}
+
+}
+
+public static void annotateMutationWithMetadata(PTable table, Mutation
mutation) {
Review comment:
Switched to private
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Annotate HBase WALs with Phoenix Metadata
> -
>
> Key: PHOENIX-5435
> URL: https://issues.apache.org/jira/browse/PHOENIX-5435
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: Geoffrey Jacoby
>Assignee: Geoffrey Jacoby
>Priority: Major
> Attachments: PHOENIX-5435-4.x.patch
>
>
> HBase write-ahead-logs (WALs) drive not only failure recovery, but HBase
> replication and some HBase backup frameworks. The WALs contain HBase-level
> metadata such as table and region, but lack Phoenix-level metadata. That
> means that it's quite difficult to build correct logic that needs to know
> about Phoenix-level constructs such as multi-tenancy, views, or indexes.
> HBASE-22622 and HBASE-22623 add the capacity for coprocessors to annotate
> extra key/value pairs of metadata into the HBase WAL. We should have the
> option to annotate the tuple , or
> some hashed way to reconstruct that tuple into the WAL. It should have a
> feature toggle so operators who don't need it don't bear the slight extra
> storage cost.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix] gjacoby126 commented on a change in pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata
gjacoby126 commented on a change in pull request #913:
URL: https://github.com/apache/phoenix/pull/913#discussion_r541362722
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java
##
@@ -682,6 +687,49 @@ private void generateMutations(final TableRef tableRef,
final long mutationTimes
values.putAll(modifiedValues);
}
+private void annotateMutationsWithMetadata(PTable table, List
rowMutations) {
+//only annotate if the change detection flag is on the table and HBase
supports
+// preWALAppend coprocs server-side
+if (table == null || !table.isChangeDetectionEnabled()
+|| !HbaseCompatCapabilities.hasPreWALAppend()) {
+return;
+}
+//annotate each mutation with enough metadata so that anyone
interested can
+// deterministically figure out exactly what Phoenix schema object
created the mutation
+// Server-side we can annotate the HBase WAL with these.
+for (Mutation mutation : rowMutations) {
+annotateMutationWithMetadata(table, mutation);
+}
+
+}
+
+public static void annotateMutationWithMetadata(PTable table, Mutation
mutation) {
Review comment:
Consolidated in WALAnnotationUtil as @ChinmaySKulkarni suggested.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix] gjacoby126 commented on a change in pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata
gjacoby126 commented on a change in pull request #913: URL: https://github.com/apache/phoenix/pull/913#discussion_r541363956 ## File path: phoenix-core/src/main/java/org/apache/phoenix/index/GlobalIndexChecker.java ## @@ -50,11 +53,19 @@ import org.apache.hadoop.hbase.filter.FilterList; import org.apache.hadoop.hbase.filter.PageFilter; import org.apache.hadoop.hbase.io.ImmutableBytesWritable; +import org.apache.hadoop.hbase.regionserver.MiniBatchOperationInProgress; import org.apache.hadoop.hbase.regionserver.Region; import org.apache.hadoop.hbase.regionserver.RegionScanner; import org.apache.hadoop.hbase.regionserver.ScannerContext; +import org.apache.hadoop.hbase.regionserver.wal.WALEdit; import org.apache.hadoop.hbase.util.Bytes; +import org.apache.hadoop.hbase.wal.WALKey; +import org.apache.phoenix.compat.hbase.HbaseCompatCapabilities; +import org.apache.phoenix.compat.hbase.coprocessor.CompatGlobalIndexChecker; +import org.apache.phoenix.compat.hbase.coprocessor.CompatIndexRegionObserver; import org.apache.phoenix.coprocessor.BaseScannerRegionObserver; +import org.apache.phoenix.execute.MutationState; +import org.apache.phoenix.hbase.index.IndexRegionObserver; Review comment: Fixed -- lots were remnants from when we annotated indexes This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata
[
https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248222#comment-17248222
]
ASF GitHub Bot commented on PHOENIX-5435:
-
gjacoby126 commented on a change in pull request #913:
URL: https://github.com/apache/phoenix/pull/913#discussion_r541362722
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java
##
@@ -682,6 +687,49 @@ private void generateMutations(final TableRef tableRef,
final long mutationTimes
values.putAll(modifiedValues);
}
+private void annotateMutationsWithMetadata(PTable table, List
rowMutations) {
+//only annotate if the change detection flag is on the table and HBase
supports
+// preWALAppend coprocs server-side
+if (table == null || !table.isChangeDetectionEnabled()
+|| !HbaseCompatCapabilities.hasPreWALAppend()) {
+return;
+}
+//annotate each mutation with enough metadata so that anyone
interested can
+// deterministically figure out exactly what Phoenix schema object
created the mutation
+// Server-side we can annotate the HBase WAL with these.
+for (Mutation mutation : rowMutations) {
+annotateMutationWithMetadata(table, mutation);
+}
+
+}
+
+public static void annotateMutationWithMetadata(PTable table, Mutation
mutation) {
Review comment:
Consolidated in WALAnnotationUtil as @ChinmaySKulkarni suggested.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Annotate HBase WALs with Phoenix Metadata
> -
>
> Key: PHOENIX-5435
> URL: https://issues.apache.org/jira/browse/PHOENIX-5435
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: Geoffrey Jacoby
>Assignee: Geoffrey Jacoby
>Priority: Major
> Attachments: PHOENIX-5435-4.x.patch
>
>
> HBase write-ahead-logs (WALs) drive not only failure recovery, but HBase
> replication and some HBase backup frameworks. The WALs contain HBase-level
> metadata such as table and region, but lack Phoenix-level metadata. That
> means that it's quite difficult to build correct logic that needs to know
> about Phoenix-level constructs such as multi-tenancy, views, or indexes.
> HBASE-22622 and HBASE-22623 add the capacity for coprocessors to annotate
> extra key/value pairs of metadata into the HBase WAL. We should have the
> option to annotate the tuple , or
> some hashed way to reconstruct that tuple into the WAL. It should have a
> feature toggle so operators who don't need it don't bear the slight extra
> storage cost.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix] gjacoby126 commented on a change in pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata
gjacoby126 commented on a change in pull request #913:
URL: https://github.com/apache/phoenix/pull/913#discussion_r541364364
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/index/GlobalIndexChecker.java
##
@@ -93,10 +106,11 @@
* the verified version that is masked by the unverified version(s).
*
*/
-public class GlobalIndexChecker extends BaseRegionObserver {
+public class GlobalIndexChecker extends CompatGlobalIndexChecker {
Review comment:
We don't need CompatGlobalIndexChecker now that we don't annotate
indexes so I removed it
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata
[
https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248224#comment-17248224
]
ASF GitHub Bot commented on PHOENIX-5435:
-
gjacoby126 commented on a change in pull request #913:
URL: https://github.com/apache/phoenix/pull/913#discussion_r541364364
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/index/GlobalIndexChecker.java
##
@@ -93,10 +106,11 @@
* the verified version that is masked by the unverified version(s).
*
*/
-public class GlobalIndexChecker extends BaseRegionObserver {
+public class GlobalIndexChecker extends CompatGlobalIndexChecker {
Review comment:
We don't need CompatGlobalIndexChecker now that we don't annotate
indexes so I removed it
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Annotate HBase WALs with Phoenix Metadata
> -
>
> Key: PHOENIX-5435
> URL: https://issues.apache.org/jira/browse/PHOENIX-5435
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: Geoffrey Jacoby
>Assignee: Geoffrey Jacoby
>Priority: Major
> Attachments: PHOENIX-5435-4.x.patch
>
>
> HBase write-ahead-logs (WALs) drive not only failure recovery, but HBase
> replication and some HBase backup frameworks. The WALs contain HBase-level
> metadata such as table and region, but lack Phoenix-level metadata. That
> means that it's quite difficult to build correct logic that needs to know
> about Phoenix-level constructs such as multi-tenancy, views, or indexes.
> HBASE-22622 and HBASE-22623 add the capacity for coprocessors to annotate
> extra key/value pairs of metadata into the HBase WAL. We should have the
> option to annotate the tuple , or
> some hashed way to reconstruct that tuple into the WAL. It should have a
> feature toggle so operators who don't need it don't bear the slight extra
> storage cost.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata
[ https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248223#comment-17248223 ] ASF GitHub Bot commented on PHOENIX-5435: - gjacoby126 commented on a change in pull request #913: URL: https://github.com/apache/phoenix/pull/913#discussion_r541363956 ## File path: phoenix-core/src/main/java/org/apache/phoenix/index/GlobalIndexChecker.java ## @@ -50,11 +53,19 @@ import org.apache.hadoop.hbase.filter.FilterList; import org.apache.hadoop.hbase.filter.PageFilter; import org.apache.hadoop.hbase.io.ImmutableBytesWritable; +import org.apache.hadoop.hbase.regionserver.MiniBatchOperationInProgress; import org.apache.hadoop.hbase.regionserver.Region; import org.apache.hadoop.hbase.regionserver.RegionScanner; import org.apache.hadoop.hbase.regionserver.ScannerContext; +import org.apache.hadoop.hbase.regionserver.wal.WALEdit; import org.apache.hadoop.hbase.util.Bytes; +import org.apache.hadoop.hbase.wal.WALKey; +import org.apache.phoenix.compat.hbase.HbaseCompatCapabilities; +import org.apache.phoenix.compat.hbase.coprocessor.CompatGlobalIndexChecker; +import org.apache.phoenix.compat.hbase.coprocessor.CompatIndexRegionObserver; import org.apache.phoenix.coprocessor.BaseScannerRegionObserver; +import org.apache.phoenix.execute.MutationState; +import org.apache.phoenix.hbase.index.IndexRegionObserver; Review comment: Fixed -- lots were remnants from when we annotated indexes This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Annotate HBase WALs with Phoenix Metadata > - > > Key: PHOENIX-5435 > URL: https://issues.apache.org/jira/browse/PHOENIX-5435 > Project: Phoenix > Issue Type: Sub-task >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Attachments: PHOENIX-5435-4.x.patch > > > HBase write-ahead-logs (WALs) drive not only failure recovery, but HBase > replication and some HBase backup frameworks. The WALs contain HBase-level > metadata such as table and region, but lack Phoenix-level metadata. That > means that it's quite difficult to build correct logic that needs to know > about Phoenix-level constructs such as multi-tenancy, views, or indexes. > HBASE-22622 and HBASE-22623 add the capacity for coprocessors to annotate > extra key/value pairs of metadata into the HBase WAL. We should have the > option to annotate the tuple , or > some hashed way to reconstruct that tuple into the WAL. It should have a > feature toggle so operators who don't need it don't bear the slight extra > storage cost. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix] gjacoby126 commented on a change in pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata
gjacoby126 commented on a change in pull request #913:
URL: https://github.com/apache/phoenix/pull/913#discussion_r541364685
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java
##
@@ -1257,7 +1261,11 @@ public ImmutableBytesPtr getEmptyKeyValueFamily() {
// If if there are no covered columns, we know it's our default name
return emptyKeyValueCFPtr;
}
-
+
+public String getLogicalIndexName() {
+return logicalIndexName;
Review comment:
Correct. Will add a comment.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata
[
https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248225#comment-17248225
]
ASF GitHub Bot commented on PHOENIX-5435:
-
gjacoby126 commented on a change in pull request #913:
URL: https://github.com/apache/phoenix/pull/913#discussion_r541364685
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java
##
@@ -1257,7 +1261,11 @@ public ImmutableBytesPtr getEmptyKeyValueFamily() {
// If if there are no covered columns, we know it's our default name
return emptyKeyValueCFPtr;
}
-
+
+public String getLogicalIndexName() {
+return logicalIndexName;
Review comment:
Correct. Will add a comment.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Annotate HBase WALs with Phoenix Metadata
> -
>
> Key: PHOENIX-5435
> URL: https://issues.apache.org/jira/browse/PHOENIX-5435
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: Geoffrey Jacoby
>Assignee: Geoffrey Jacoby
>Priority: Major
> Attachments: PHOENIX-5435-4.x.patch
>
>
> HBase write-ahead-logs (WALs) drive not only failure recovery, but HBase
> replication and some HBase backup frameworks. The WALs contain HBase-level
> metadata such as table and region, but lack Phoenix-level metadata. That
> means that it's quite difficult to build correct logic that needs to know
> about Phoenix-level constructs such as multi-tenancy, views, or indexes.
> HBASE-22622 and HBASE-22623 add the capacity for coprocessors to annotate
> extra key/value pairs of metadata into the HBase WAL. We should have the
> option to annotate the tuple , or
> some hashed way to reconstruct that tuple into the WAL. It should have a
> feature toggle so operators who don't need it don't bear the slight extra
> storage cost.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix] gjacoby126 commented on a change in pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata
gjacoby126 commented on a change in pull request #913:
URL: https://github.com/apache/phoenix/pull/913#discussion_r541367097
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/util/WALAnnotationUtil.java
##
@@ -0,0 +1,49 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.util;
+
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.client.Mutation;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.hbase.wal.WALKey;
+import org.apache.phoenix.compat.hbase.coprocessor.CompatIndexRegionObserver;
+import org.apache.phoenix.execute.MutationState;
+import org.apache.phoenix.hbase.index.IndexRegionObserver;
+
+import java.util.Map;
+
+/**
+ * Utility functions shared between IndexRegionObserver and GlobalIndexChecker
for annotating the
+ * HBase WAL with Phoenix-level metadata about mutations.
+ */
+public class WALAnnotationUtil {
Review comment:
It's not specific to indexing.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata
[
https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248226#comment-17248226
]
ASF GitHub Bot commented on PHOENIX-5435:
-
gjacoby126 commented on a change in pull request #913:
URL: https://github.com/apache/phoenix/pull/913#discussion_r541367097
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/util/WALAnnotationUtil.java
##
@@ -0,0 +1,49 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.util;
+
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.client.Mutation;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.hbase.wal.WALKey;
+import org.apache.phoenix.compat.hbase.coprocessor.CompatIndexRegionObserver;
+import org.apache.phoenix.execute.MutationState;
+import org.apache.phoenix.hbase.index.IndexRegionObserver;
+
+import java.util.Map;
+
+/**
+ * Utility functions shared between IndexRegionObserver and GlobalIndexChecker
for annotating the
+ * HBase WAL with Phoenix-level metadata about mutations.
+ */
+public class WALAnnotationUtil {
Review comment:
It's not specific to indexing.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Annotate HBase WALs with Phoenix Metadata
> -
>
> Key: PHOENIX-5435
> URL: https://issues.apache.org/jira/browse/PHOENIX-5435
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: Geoffrey Jacoby
>Assignee: Geoffrey Jacoby
>Priority: Major
> Attachments: PHOENIX-5435-4.x.patch
>
>
> HBase write-ahead-logs (WALs) drive not only failure recovery, but HBase
> replication and some HBase backup frameworks. The WALs contain HBase-level
> metadata such as table and region, but lack Phoenix-level metadata. That
> means that it's quite difficult to build correct logic that needs to know
> about Phoenix-level constructs such as multi-tenancy, views, or indexes.
> HBASE-22622 and HBASE-22623 add the capacity for coprocessors to annotate
> extra key/value pairs of metadata into the HBase WAL. We should have the
> option to annotate the tuple , or
> some hashed way to reconstruct that tuple into the WAL. It should have a
> feature toggle so operators who don't need it don't bear the slight extra
> storage cost.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix] gjacoby126 commented on a change in pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata
gjacoby126 commented on a change in pull request #913:
URL: https://github.com/apache/phoenix/pull/913#discussion_r541382620
##
File path: phoenix-core/src/main/java/org/apache/phoenix/util/ScanUtil.java
##
@@ -1239,4 +1239,21 @@ public static boolean isDummy(List result) {
Cell cell = result.get(0);
return CellUtil.matchingColumn(cell, EMPTY_BYTE_ARRAY,
EMPTY_BYTE_ARRAY);
}
+
+public static void setWALAnnotationAttributes(PTable table, Scan scan) {
Review comment:
Added comments to the Utility methods in ScanUtil and WALAnnotationUtil
to avoid duplication
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata
[
https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248232#comment-17248232
]
ASF GitHub Bot commented on PHOENIX-5435:
-
gjacoby126 commented on a change in pull request #913:
URL: https://github.com/apache/phoenix/pull/913#discussion_r541382620
##
File path: phoenix-core/src/main/java/org/apache/phoenix/util/ScanUtil.java
##
@@ -1239,4 +1239,21 @@ public static boolean isDummy(List result) {
Cell cell = result.get(0);
return CellUtil.matchingColumn(cell, EMPTY_BYTE_ARRAY,
EMPTY_BYTE_ARRAY);
}
+
+public static void setWALAnnotationAttributes(PTable table, Scan scan) {
Review comment:
Added comments to the Utility methods in ScanUtil and WALAnnotationUtil
to avoid duplication
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Annotate HBase WALs with Phoenix Metadata
> -
>
> Key: PHOENIX-5435
> URL: https://issues.apache.org/jira/browse/PHOENIX-5435
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: Geoffrey Jacoby
>Assignee: Geoffrey Jacoby
>Priority: Major
> Attachments: PHOENIX-5435-4.x.patch
>
>
> HBase write-ahead-logs (WALs) drive not only failure recovery, but HBase
> replication and some HBase backup frameworks. The WALs contain HBase-level
> metadata such as table and region, but lack Phoenix-level metadata. That
> means that it's quite difficult to build correct logic that needs to know
> about Phoenix-level constructs such as multi-tenancy, views, or indexes.
> HBASE-22622 and HBASE-22623 add the capacity for coprocessors to annotate
> extra key/value pairs of metadata into the HBase WAL. We should have the
> option to annotate the tuple , or
> some hashed way to reconstruct that tuple into the WAL. It should have a
> feature toggle so operators who don't need it don't bear the slight extra
> storage cost.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix] gjacoby126 commented on a change in pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata
gjacoby126 commented on a change in pull request #913:
URL: https://github.com/apache/phoenix/pull/913#discussion_r541383107
##
File path:
phoenix-hbase-compat-1.5.0/src/main/java/org/apache/phoenix/compat/hbase/coprocessor/CompatGlobalIndexChecker.java
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.compat.hbase.coprocessor;
+
+import org.apache.hadoop.hbase.coprocessor.BaseRegionObserver;
+
+public class CompatGlobalIndexChecker extends BaseRegionObserver {
+//HBase 1.5+ has preWALAppend already declared in BaseRegionObserver, so
this class is only
Review comment:
This particular file no longer exists, but I fixed some of these as I
found them. The reason why is just that I usually don't type a space when I
start a one-line comment, and when I find I need to make it multi-line the IDE
fixes the spacing on subsequent lines but not the first one. :-)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata
[
https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248234#comment-17248234
]
ASF GitHub Bot commented on PHOENIX-5435:
-
gjacoby126 commented on a change in pull request #913:
URL: https://github.com/apache/phoenix/pull/913#discussion_r541383107
##
File path:
phoenix-hbase-compat-1.5.0/src/main/java/org/apache/phoenix/compat/hbase/coprocessor/CompatGlobalIndexChecker.java
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.compat.hbase.coprocessor;
+
+import org.apache.hadoop.hbase.coprocessor.BaseRegionObserver;
+
+public class CompatGlobalIndexChecker extends BaseRegionObserver {
+//HBase 1.5+ has preWALAppend already declared in BaseRegionObserver, so
this class is only
Review comment:
This particular file no longer exists, but I fixed some of these as I
found them. The reason why is just that I usually don't type a space when I
start a one-line comment, and when I find I need to make it multi-line the IDE
fixes the spacing on subsequent lines but not the first one. :-)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Annotate HBase WALs with Phoenix Metadata
> -
>
> Key: PHOENIX-5435
> URL: https://issues.apache.org/jira/browse/PHOENIX-5435
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: Geoffrey Jacoby
>Assignee: Geoffrey Jacoby
>Priority: Major
> Attachments: PHOENIX-5435-4.x.patch
>
>
> HBase write-ahead-logs (WALs) drive not only failure recovery, but HBase
> replication and some HBase backup frameworks. The WALs contain HBase-level
> metadata such as table and region, but lack Phoenix-level metadata. That
> means that it's quite difficult to build correct logic that needs to know
> about Phoenix-level constructs such as multi-tenancy, views, or indexes.
> HBASE-22622 and HBASE-22623 add the capacity for coprocessors to annotate
> extra key/value pairs of metadata into the HBase WAL. We should have the
> option to annotate the tuple , or
> some hashed way to reconstruct that tuple into the WAL. It should have a
> feature toggle so operators who don't need it don't bear the slight extra
> storage cost.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6218) Rows deleted count for client side deletes is incorrect for immutable tables with indexes
[
https://issues.apache.org/jira/browse/PHOENIX-6218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248271#comment-17248271
]
Hadoop QA commented on PHOENIX-6218:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
56s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 11m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 3m
50s{color} | {color:blue} phoenix-core in master has 967 extant spotbugs
warnings. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
10s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
45s{color} | {color:red} phoenix-core: The patch generated 9 new + 380
unchanged - 11 fixed = 389 total (was 391) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} spotbugs {color} | {color:green} 3m
53s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}107m 0s{color}
| {color:red} phoenix-core in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
25s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}143m 24s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | phoenix.end2end.SystemTablesCreationOnConnectionIT |
| | phoenix.end2end.IndexVerificationOldDesignIT |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/292/artifact/patchprocess/Dockerfile
|
| JIRA Issue | PHOENIX-6218 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/13016964/PHOENIX-6218-master.v1.patch
|
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux 329223f13781 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 16b0565 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/292/artifact/patchprocess/diff-checkstyle-phoenix-core.txt
|
| unit |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/292/artifact/patchprocess/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/292/testReport/ |
| Max. process+thread count | 6630 (vs. ulimit of 3) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/292/cons
[GitHub] [phoenix] stoty commented on pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata
stoty commented on pull request #913: URL: https://github.com/apache/phoenix/pull/913#issuecomment-743673616 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. | ||| _ 4.x Compile Tests _ | | +0 :ok: | mvndep | 0m 31s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 10m 58s | 4.x passed | | +1 :green_heart: | compile | 1m 21s | 4.x passed | | +1 :green_heart: | checkstyle | 9m 47s | 4.x passed | | +1 :green_heart: | javadoc | 2m 24s | 4.x passed | | +0 :ok: | spotbugs | 0m 27s | phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings. | | +0 :ok: | spotbugs | 0m 24s | phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings. | | +0 :ok: | spotbugs | 0m 23s | phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings. | | +0 :ok: | spotbugs | 4m 9s | root in 4.x has 1005 extant spotbugs warnings. | | +0 :ok: | spotbugs | 2m 44s | phoenix-core in 4.x has 951 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 6m 13s | the patch passed | | +1 :green_heart: | compile | 1m 30s | the patch passed | | +1 :green_heart: | cc | 1m 30s | the patch passed | | +1 :green_heart: | javac | 1m 30s | the patch passed | | -1 :x: | checkstyle | 9m 15s | root: The patch generated 474 new + 23163 unchanged - 157 fixed = 23637 total (was 23320) | | +1 :green_heart: | prototool | 0m 1s | There were no new prototool issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 2m 35s | the patch passed | | -1 :x: | spotbugs | 3m 19s | phoenix-core generated 2 new + 951 unchanged - 0 fixed = 953 total (was 951) | | -1 :x: | spotbugs | 4m 30s | root generated 2 new + 1005 unchanged - 0 fixed = 1007 total (was 1005) | ||| _ Other Tests _ | | -1 :x: | unit | 128m 30s | root in the patch failed. | | +1 :green_heart: | asflicense | 2m 30s | The patch does not generate ASF License warnings. | | | | 198m 43s | | | Reason | Tests | |---:|:--| | FindBugs | module:phoenix-core | | | Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing At FilteredKeyValueScanner.java:where default case is missing At FilteredKeyValueScanner.java:[lines 84-101] | | | org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.CHANGE_DETECTION_ENABLED_BYTES is a mutable array At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 336] | | FindBugs | module:root | | | Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing At FilteredKeyValueScanner.java:where default case is missing At FilteredKeyValueScanner.java:[lines 84-101] | | | org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.CHANGE_DETECTION_ENABLED_BYTES is a mutable array At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 336] | | Failed junit tests | phoenix.end2end.index.ViewIndexIT | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/12/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/913 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool xml | | uname | Linux fbce87f802cf 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / d43c362 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/12/artifact/yetus-general-check/output/diff-checkstyle-root.txt | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix
[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata
[ https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248278#comment-17248278 ] ASF GitHub Bot commented on PHOENIX-5435: - stoty commented on pull request #913: URL: https://github.com/apache/phoenix/pull/913#issuecomment-743673616 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. | ||| _ 4.x Compile Tests _ | | +0 :ok: | mvndep | 0m 31s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 10m 58s | 4.x passed | | +1 :green_heart: | compile | 1m 21s | 4.x passed | | +1 :green_heart: | checkstyle | 9m 47s | 4.x passed | | +1 :green_heart: | javadoc | 2m 24s | 4.x passed | | +0 :ok: | spotbugs | 0m 27s | phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings. | | +0 :ok: | spotbugs | 0m 24s | phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings. | | +0 :ok: | spotbugs | 0m 23s | phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings. | | +0 :ok: | spotbugs | 4m 9s | root in 4.x has 1005 extant spotbugs warnings. | | +0 :ok: | spotbugs | 2m 44s | phoenix-core in 4.x has 951 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 6m 13s | the patch passed | | +1 :green_heart: | compile | 1m 30s | the patch passed | | +1 :green_heart: | cc | 1m 30s | the patch passed | | +1 :green_heart: | javac | 1m 30s | the patch passed | | -1 :x: | checkstyle | 9m 15s | root: The patch generated 474 new + 23163 unchanged - 157 fixed = 23637 total (was 23320) | | +1 :green_heart: | prototool | 0m 1s | There were no new prototool issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 2m 35s | the patch passed | | -1 :x: | spotbugs | 3m 19s | phoenix-core generated 2 new + 951 unchanged - 0 fixed = 953 total (was 951) | | -1 :x: | spotbugs | 4m 30s | root generated 2 new + 1005 unchanged - 0 fixed = 1007 total (was 1005) | ||| _ Other Tests _ | | -1 :x: | unit | 128m 30s | root in the patch failed. | | +1 :green_heart: | asflicense | 2m 30s | The patch does not generate ASF License warnings. | | | | 198m 43s | | | Reason | Tests | |---:|:--| | FindBugs | module:phoenix-core | | | Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing At FilteredKeyValueScanner.java:where default case is missing At FilteredKeyValueScanner.java:[lines 84-101] | | | org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.CHANGE_DETECTION_ENABLED_BYTES is a mutable array At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 336] | | FindBugs | module:root | | | Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing At FilteredKeyValueScanner.java:where default case is missing At FilteredKeyValueScanner.java:[lines 84-101] | | | org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.CHANGE_DETECTION_ENABLED_BYTES is a mutable array At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 336] | | Failed junit tests | phoenix.end2end.index.ViewIndexIT | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/12/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/913 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool xml | | uname | Linux fbce87f802cf 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / d43c362 | | Default Java | Private Build-1.8.0_2
[jira] [Commented] (PHOENIX-6250) Fix ViewMetadataIT test flapper
[
https://issues.apache.org/jira/browse/PHOENIX-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248287#comment-17248287
]
Hadoop QA commented on PHOENIX-6250:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 10s{color}
| {color:red} PHOENIX-6250 does not apply to master. Rebase required? Wrong
Branch? See
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | PHOENIX-6250 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/13016972/PHOENIX-6250.master.v1.patch
|
| Console output |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/293/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> Fix ViewMetadataIT test flapper
> ---
>
> Key: PHOENIX-6250
> URL: https://issues.apache.org/jira/browse/PHOENIX-6250
> Project: Phoenix
> Issue Type: Improvement
>Reporter: Xinyi Yan
>Assignee: Xinyi Yan
>Priority: Major
> Fix For: 4.16.0
>
> Attachments: PHOENIX-6250.master.v1.patch
>
>
> ViewMetadataIT failed multi-times at 4.x branch.
> Here is the logging:
> {code:java}
> 17:32:58 [ERROR] Tests run: 25, Failures: 1, Errors: 0, Skipped: 0, Time
> elapsed: 353.71 s <<< FAILURE! - in org.apache.phoenix.end2end.ViewMetadataIT
> 17:32:58 [ERROR]
> testRepeatedCreateAndDropCascadeTableWorks(org.apache.phoenix.end2end.ViewMetadataIT)
> Time elapsed: 11.52 s <<< FAILURE!
> 17:32:58 java.lang.AssertionError: View SCHEMA2.N74 should have been
> deleted when parent was dropped
> 17:32:58 at org.junit.Assert.fail(Assert.java:89)
> 17:32:58 at
> org.apache.phoenix.end2end.ViewMetadataIT.validateViewDoesNotExist(ViewMetadataIT.java:1373)
> 17:32:58 at
> org.apache.phoenix.end2end.ViewMetadataIT.testRepeatedCreateAndDropCascadeTableWorks(ViewMetadataIT.java:818)
> 17:32:58 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 17:32:58 at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 17:32:58 at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 17:32:58 at java.lang.reflect.Method.invoke(Method.java:498)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix] virajjasani commented on pull request #1012: PHOENIX-6256: Fix MaxConcurrentConnectionsIT test flapper
virajjasani commented on pull request #1012: URL: https://github.com/apache/phoenix/pull/1012#issuecomment-743719665 > TaskRO never gets scheduled at all due to the initial wait being set to Long.MAX_VALUE In that case, only `TASK_HANDLING_INITIAL_DELAY_MS_ATTRIB` is sufficient since it is init delay so that first Scan never happens? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6256) Fix MaxConcurrentConnectionsIT test flapper
[ https://issues.apache.org/jira/browse/PHOENIX-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248308#comment-17248308 ] ASF GitHub Bot commented on PHOENIX-6256: - virajjasani commented on pull request #1012: URL: https://github.com/apache/phoenix/pull/1012#issuecomment-743719665 > TaskRO never gets scheduled at all due to the initial wait being set to Long.MAX_VALUE In that case, only `TASK_HANDLING_INITIAL_DELAY_MS_ATTRIB` is sufficient since it is init delay so that first Scan never happens? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix MaxConcurrentConnectionsIT test flapper > --- > > Key: PHOENIX-6256 > URL: https://issues.apache.org/jira/browse/PHOENIX-6256 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.15.0 >Reporter: Xinyi Yan >Assignee: Chinmay Kulkarni >Priority: Major > Fix For: 4.16.0 > > > MaxConcurrentConnectionsIT failed 3 out of last 10 runs. > > h3. Error Message > Found 1 connections still open. expected:<0> but was:<1> > h3. Stacktrace > java.lang.AssertionError: Found 1 connections still open. expected:<0> but > was:<1> at org.junit.Assert.fail(Assert.java:89) at > org.junit.Assert.failNotEquals(Assert.java:835) at > org.junit.Assert.assertEquals(Assert.java:647) at > org.apache.phoenix.query.MaxConcurrentConnectionsIT.testDeleteRuntimeFailureClosesConnections(MaxConcurrentConnectionsIT.java:122) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at > org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) > at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at > org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at > org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at > org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at > org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54) at > org.junit.rules.RunRules.evaluate(RunRules.java:20) at > org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at > org.junit.runners.ParentRunner.run(ParentRunner.java:413) at > org.junit.runners.Suite.runChild(Suite.java:128) at > org.junit.runners.Suite.runChild(Suite.java:27) at > org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at > org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at > org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at > org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at > org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at > org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at > org.junit.runners.ParentRunner.run(ParentRunner.java:413) at > org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:55) at > org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:137) > at > org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeEager(JUnitCoreWrapper.java:107) > at > org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:83) > at > org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:75) > at > org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(JUnitCoreProvider.java:158) > at > org.apache.maven.surefire.booter.ForkedBooter.invokeProvid
