[jira] [Commented] (PHOENIX-7014) CDC query complier and optimizer
[
https://issues.apache.org/jira/browse/PHOENIX-7014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799902#comment-17799902
]
ASF GitHub Bot commented on PHOENIX-7014:
-
tkhurana commented on code in PR #1766:
URL: https://github.com/apache/phoenix/pull/1766#discussion_r1435279079
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/CDCMiscIT.java:
##
@@ -269,4 +273,109 @@ public void testDropCDCIndex () throws SQLException {
}
}
+private void assertResultSet(ResultSet rs) throws Exception{
+Gson gson = new Gson();
+assertEquals(true, rs.next());
+assertEquals(1, rs.getInt(2));
+assertEquals(new HashMap(){{put("V1", 100d);}},
gson.fromJson(rs.getString(3),
+HashMap.class));
+assertEquals(true, rs.next());
+assertEquals(2, rs.getInt(2));
+assertEquals(new HashMap(){{put("V1", 200d);}},
gson.fromJson(rs.getString(3),
+HashMap.class));
+assertEquals(true, rs.next());
+assertEquals(1, rs.getInt(2));
+assertEquals(new HashMap(){{put("V1", 101d);}},
gson.fromJson(rs.getString(3),
+HashMap.class));
+assertEquals(false, rs.next());
+rs.close();
+}
+
+@Test
+public void testSelectCDC() throws Exception {
+Properties props = new Properties();
+props.put(QueryServices.TASK_HANDLING_INTERVAL_MS_ATTRIB,
Long.toString(Long.MAX_VALUE));
+props.put("hbase.client.scanner.timeout.period", "600");
+props.put("phoenix.query.timeoutMs", "600");
+props.put("zookeeper.session.timeout", "600");
+props.put("hbase.rpc.timeout", "600");
+Connection conn = DriverManager.getConnection(getUrl(), props);
+String tableName = generateUniqueName();
+conn.createStatement().execute(
+"CREATE TABLE " + tableName + " ( k INTEGER PRIMARY KEY," + "
v1 INTEGER)");
+conn.createStatement().execute("UPSERT INTO " + tableName + " (k, v1)
VALUES (1, 100)");
+conn.createStatement().execute("UPSERT INTO " + tableName + " (k, v1)
VALUES (2, 200)");
+conn.commit();
+Thread.sleep(1000);
+conn.createStatement().execute("UPSERT INTO " + tableName + " (k, v1)
VALUES (1, 101)");
+conn.commit();
+String cdcName = generateUniqueName();
+String cdc_sql = "CREATE CDC " + cdcName
Review Comment:
OK, we can tackle that in a separate PR.
> CDC query complier and optimizer
>
>
> Key: PHOENIX-7014
> URL: https://issues.apache.org/jira/browse/PHOENIX-7014
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: Viraj Jasani
>Assignee: Hari Krishna Dara
>Priority: Major
>
> For CDC table type, the query optimizer should be able to query from the
> uncovered global index table with data table associated with the given CDC
> table.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] PHOENIX-7014: Query compiler/optimizer changes along with some PHOENIX-7015 changes [phoenix]
tkhurana commented on code in PR #1766:
URL: https://github.com/apache/phoenix/pull/1766#discussion_r1435279079
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/CDCMiscIT.java:
##
@@ -269,4 +273,109 @@ public void testDropCDCIndex () throws SQLException {
}
}
+private void assertResultSet(ResultSet rs) throws Exception{
+Gson gson = new Gson();
+assertEquals(true, rs.next());
+assertEquals(1, rs.getInt(2));
+assertEquals(new HashMap(){{put("V1", 100d);}},
gson.fromJson(rs.getString(3),
+HashMap.class));
+assertEquals(true, rs.next());
+assertEquals(2, rs.getInt(2));
+assertEquals(new HashMap(){{put("V1", 200d);}},
gson.fromJson(rs.getString(3),
+HashMap.class));
+assertEquals(true, rs.next());
+assertEquals(1, rs.getInt(2));
+assertEquals(new HashMap(){{put("V1", 101d);}},
gson.fromJson(rs.getString(3),
+HashMap.class));
+assertEquals(false, rs.next());
+rs.close();
+}
+
+@Test
+public void testSelectCDC() throws Exception {
+Properties props = new Properties();
+props.put(QueryServices.TASK_HANDLING_INTERVAL_MS_ATTRIB,
Long.toString(Long.MAX_VALUE));
+props.put("hbase.client.scanner.timeout.period", "600");
+props.put("phoenix.query.timeoutMs", "600");
+props.put("zookeeper.session.timeout", "600");
+props.put("hbase.rpc.timeout", "600");
+Connection conn = DriverManager.getConnection(getUrl(), props);
+String tableName = generateUniqueName();
+conn.createStatement().execute(
+"CREATE TABLE " + tableName + " ( k INTEGER PRIMARY KEY," + "
v1 INTEGER)");
+conn.createStatement().execute("UPSERT INTO " + tableName + " (k, v1)
VALUES (1, 100)");
+conn.createStatement().execute("UPSERT INTO " + tableName + " (k, v1)
VALUES (2, 200)");
+conn.commit();
+Thread.sleep(1000);
+conn.createStatement().execute("UPSERT INTO " + tableName + " (k, v1)
VALUES (1, 101)");
+conn.commit();
+String cdcName = generateUniqueName();
+String cdc_sql = "CREATE CDC " + cdcName
Review Comment:
OK, we can tackle that in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (PHOENIX-7115) Create separate handler thread pool for invalidating server metadata cache
[ https://issues.apache.org/jira/browse/PHOENIX-7115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799880#comment-17799880 ] ASF GitHub Bot commented on PHOENIX-7115: - shahrs87 commented on PR #1748: URL: https://github.com/apache/phoenix/pull/1748#issuecomment-1867884278 All the 3 failing tests are known flappers. ``` org.apache.phoenix.end2end.QueryTimeoutIT.testQueryTimeout org.apache.phoenix.jdbc.LoggingHAConnectionLimiterIT.testActivityLogsOnUpsertWhenFailures org.apache.phoenix.jdbc.ParallelPhoenixConnectionIT.testMetrics ``` I am merging this patch since all the review comments are addressed. Thank you @jpisaac @palashc for the reviews. > Create separate handler thread pool for invalidating server metadata cache > -- > > Key: PHOENIX-7115 > URL: https://issues.apache.org/jira/browse/PHOENIX-7115 > Project: Phoenix > Issue Type: Sub-task >Reporter: Rushabh Shah >Assignee: Rushabh Shah >Priority: Major > > MutableIndexFailureIT#testIndexWriteFailure is failing. See > [this|https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1726/9/#showFailuresLink] > build for reference. > Currently all the invalidateServerMetadataCache invocations are handled by > default RPC handler threads. We have 5 default handler threads configured in > tests. > This test makes sure that write to index table fails and since > disableIndexOnWriteFailure is set to true, it will disable the index. We use > around 10 different threads on the client side to write to base table and > index table, so we use all the 5 handler threads to serve writes. > Since writes to index fails, within the handler threads it will try to update > the index state to DISABLE. > On receiving the updateIndexState rpc, MetadataEndpointImpl will try to > invalidate the server metadata cache on all the regionservers. The > regionserver hosting index table doesn't have any available handler threads > to serve invalidateServerMetadataCache requests. Hence the test fails. > The root cause is all the read/write operations and invalidate server > metadata cache operations share the same RPC handler pool. We need to have > separate thread pool for > invalidate server metadata cache operations -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] PHOENIX-7115 Create separate handler thread pool for invalidating server metadata cache [phoenix]
shahrs87 commented on PR #1748: URL: https://github.com/apache/phoenix/pull/1748#issuecomment-1867884278 All the 3 failing tests are known flappers. ``` org.apache.phoenix.end2end.QueryTimeoutIT.testQueryTimeout org.apache.phoenix.jdbc.LoggingHAConnectionLimiterIT.testActivityLogsOnUpsertWhenFailures org.apache.phoenix.jdbc.ParallelPhoenixConnectionIT.testMetrics ``` I am merging this patch since all the review comments are addressed. Thank you @jpisaac @palashc for the reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-7115) Create separate handler thread pool for invalidating server metadata cache
[ https://issues.apache.org/jira/browse/PHOENIX-7115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799882#comment-17799882 ] ASF GitHub Bot commented on PHOENIX-7115: - shahrs87 merged PR #1748: URL: https://github.com/apache/phoenix/pull/1748 > Create separate handler thread pool for invalidating server metadata cache > -- > > Key: PHOENIX-7115 > URL: https://issues.apache.org/jira/browse/PHOENIX-7115 > Project: Phoenix > Issue Type: Sub-task >Reporter: Rushabh Shah >Assignee: Rushabh Shah >Priority: Major > > MutableIndexFailureIT#testIndexWriteFailure is failing. See > [this|https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1726/9/#showFailuresLink] > build for reference. > Currently all the invalidateServerMetadataCache invocations are handled by > default RPC handler threads. We have 5 default handler threads configured in > tests. > This test makes sure that write to index table fails and since > disableIndexOnWriteFailure is set to true, it will disable the index. We use > around 10 different threads on the client side to write to base table and > index table, so we use all the 5 handler threads to serve writes. > Since writes to index fails, within the handler threads it will try to update > the index state to DISABLE. > On receiving the updateIndexState rpc, MetadataEndpointImpl will try to > invalidate the server metadata cache on all the regionservers. The > regionserver hosting index table doesn't have any available handler threads > to serve invalidateServerMetadataCache requests. Hence the test fails. > The root cause is all the read/write operations and invalidate server > metadata cache operations share the same RPC handler pool. We need to have > separate thread pool for > invalidate server metadata cache operations -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] PHOENIX-7115 Create separate handler thread pool for invalidating server metadata cache [phoenix]
shahrs87 merged PR #1748: URL: https://github.com/apache/phoenix/pull/1748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-7014) CDC query complier and optimizer
[
https://issues.apache.org/jira/browse/PHOENIX-7014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799815#comment-17799815
]
ASF GitHub Bot commented on PHOENIX-7014:
-
haridsv commented on code in PR #1766:
URL: https://github.com/apache/phoenix/pull/1766#discussion_r1435014971
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/CDCMiscIT.java:
##
@@ -269,4 +273,109 @@ public void testDropCDCIndex () throws SQLException {
}
}
+private void assertResultSet(ResultSet rs) throws Exception{
+Gson gson = new Gson();
+assertEquals(true, rs.next());
+assertEquals(1, rs.getInt(2));
+assertEquals(new HashMap(){{put("V1", 100d);}},
gson.fromJson(rs.getString(3),
+HashMap.class));
+assertEquals(true, rs.next());
+assertEquals(2, rs.getInt(2));
+assertEquals(new HashMap(){{put("V1", 200d);}},
gson.fromJson(rs.getString(3),
+HashMap.class));
+assertEquals(true, rs.next());
+assertEquals(1, rs.getInt(2));
+assertEquals(new HashMap(){{put("V1", 101d);}},
gson.fromJson(rs.getString(3),
+HashMap.class));
+assertEquals(false, rs.next());
+rs.close();
+}
+
+@Test
+public void testSelectCDC() throws Exception {
+Properties props = new Properties();
+props.put(QueryServices.TASK_HANDLING_INTERVAL_MS_ATTRIB,
Long.toString(Long.MAX_VALUE));
+props.put("hbase.client.scanner.timeout.period", "600");
+props.put("phoenix.query.timeoutMs", "600");
+props.put("zookeeper.session.timeout", "600");
+props.put("hbase.rpc.timeout", "600");
+Connection conn = DriverManager.getConnection(getUrl(), props);
+String tableName = generateUniqueName();
+conn.createStatement().execute(
+"CREATE TABLE " + tableName + " ( k INTEGER PRIMARY KEY," + "
v1 INTEGER)");
+conn.createStatement().execute("UPSERT INTO " + tableName + " (k, v1)
VALUES (1, 100)");
+conn.createStatement().execute("UPSERT INTO " + tableName + " (k, v1)
VALUES (2, 200)");
+conn.commit();
+Thread.sleep(1000);
+conn.createStatement().execute("UPSERT INTO " + tableName + " (k, v1)
VALUES (1, 101)");
+conn.commit();
+String cdcName = generateUniqueName();
+String cdc_sql = "CREATE CDC " + cdcName
Review Comment:
> I didn't quite understand what you mean by index status here ?
I was referring to the async index creation lifecycle, which should be
attributed to the CDC so that user can query and know when it is done.
> CDC query complier and optimizer
>
>
> Key: PHOENIX-7014
> URL: https://issues.apache.org/jira/browse/PHOENIX-7014
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: Viraj Jasani
>Assignee: Hari Krishna Dara
>Priority: Major
>
> For CDC table type, the query optimizer should be able to query from the
> uncovered global index table with data table associated with the given CDC
> table.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] PHOENIX-7014: Query compiler/optimizer changes along with some PHOENIX-7015 changes [phoenix]
haridsv commented on code in PR #1766:
URL: https://github.com/apache/phoenix/pull/1766#discussion_r1435014971
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/CDCMiscIT.java:
##
@@ -269,4 +273,109 @@ public void testDropCDCIndex () throws SQLException {
}
}
+private void assertResultSet(ResultSet rs) throws Exception{
+Gson gson = new Gson();
+assertEquals(true, rs.next());
+assertEquals(1, rs.getInt(2));
+assertEquals(new HashMap(){{put("V1", 100d);}},
gson.fromJson(rs.getString(3),
+HashMap.class));
+assertEquals(true, rs.next());
+assertEquals(2, rs.getInt(2));
+assertEquals(new HashMap(){{put("V1", 200d);}},
gson.fromJson(rs.getString(3),
+HashMap.class));
+assertEquals(true, rs.next());
+assertEquals(1, rs.getInt(2));
+assertEquals(new HashMap(){{put("V1", 101d);}},
gson.fromJson(rs.getString(3),
+HashMap.class));
+assertEquals(false, rs.next());
+rs.close();
+}
+
+@Test
+public void testSelectCDC() throws Exception {
+Properties props = new Properties();
+props.put(QueryServices.TASK_HANDLING_INTERVAL_MS_ATTRIB,
Long.toString(Long.MAX_VALUE));
+props.put("hbase.client.scanner.timeout.period", "600");
+props.put("phoenix.query.timeoutMs", "600");
+props.put("zookeeper.session.timeout", "600");
+props.put("hbase.rpc.timeout", "600");
+Connection conn = DriverManager.getConnection(getUrl(), props);
+String tableName = generateUniqueName();
+conn.createStatement().execute(
+"CREATE TABLE " + tableName + " ( k INTEGER PRIMARY KEY," + "
v1 INTEGER)");
+conn.createStatement().execute("UPSERT INTO " + tableName + " (k, v1)
VALUES (1, 100)");
+conn.createStatement().execute("UPSERT INTO " + tableName + " (k, v1)
VALUES (2, 200)");
+conn.commit();
+Thread.sleep(1000);
+conn.createStatement().execute("UPSERT INTO " + tableName + " (k, v1)
VALUES (1, 101)");
+conn.commit();
+String cdcName = generateUniqueName();
+String cdc_sql = "CREATE CDC " + cdcName
Review Comment:
> I didn't quite understand what you mean by index status here ?
I was referring to the async index creation lifecycle, which should be
attributed to the CDC so that user can query and know when it is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (PHOENIX-7014) CDC query complier and optimizer
[
https://issues.apache.org/jira/browse/PHOENIX-7014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799816#comment-17799816
]
ASF GitHub Bot commented on PHOENIX-7014:
-
haridsv commented on code in PR #1766:
URL: https://github.com/apache/phoenix/pull/1766#discussion_r1435015447
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/CDCMiscIT.java:
##
@@ -269,4 +273,109 @@ public void testDropCDCIndex () throws SQLException {
}
}
+private void assertResultSet(ResultSet rs) throws Exception{
+Gson gson = new Gson();
+assertEquals(true, rs.next());
+assertEquals(1, rs.getInt(2));
+assertEquals(new HashMap(){{put("V1", 100d);}},
gson.fromJson(rs.getString(3),
+HashMap.class));
+assertEquals(true, rs.next());
+assertEquals(2, rs.getInt(2));
+assertEquals(new HashMap(){{put("V1", 200d);}},
gson.fromJson(rs.getString(3),
+HashMap.class));
+assertEquals(true, rs.next());
+assertEquals(1, rs.getInt(2));
+assertEquals(new HashMap(){{put("V1", 101d);}},
gson.fromJson(rs.getString(3),
+HashMap.class));
+assertEquals(false, rs.next());
+rs.close();
+}
+
+@Test
+public void testSelectCDC() throws Exception {
+Properties props = new Properties();
+props.put(QueryServices.TASK_HANDLING_INTERVAL_MS_ATTRIB,
Long.toString(Long.MAX_VALUE));
+props.put("hbase.client.scanner.timeout.period", "600");
+props.put("phoenix.query.timeoutMs", "600");
+props.put("zookeeper.session.timeout", "600");
+props.put("hbase.rpc.timeout", "600");
+Connection conn = DriverManager.getConnection(getUrl(), props);
+String tableName = generateUniqueName();
+conn.createStatement().execute(
+"CREATE TABLE " + tableName + " ( k INTEGER PRIMARY KEY," + "
v1 INTEGER)");
+conn.createStatement().execute("UPSERT INTO " + tableName + " (k, v1)
VALUES (1, 100)");
+conn.createStatement().execute("UPSERT INTO " + tableName + " (k, v1)
VALUES (2, 200)");
+conn.commit();
+Thread.sleep(1000);
+conn.createStatement().execute("UPSERT INTO " + tableName + " (k, v1)
VALUES (1, 101)");
+conn.commit();
+String cdcName = generateUniqueName();
+String cdc_sql = "CREATE CDC " + cdcName
Review Comment:
@tkhurana In any case, I am not planning to address these as part of this
PR, so are you OK to merge this as is?
> CDC query complier and optimizer
>
>
> Key: PHOENIX-7014
> URL: https://issues.apache.org/jira/browse/PHOENIX-7014
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: Viraj Jasani
>Assignee: Hari Krishna Dara
>Priority: Major
>
> For CDC table type, the query optimizer should be able to query from the
> uncovered global index table with data table associated with the given CDC
> table.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] PHOENIX-7014: Query compiler/optimizer changes along with some PHOENIX-7015 changes [phoenix]
haridsv commented on code in PR #1766:
URL: https://github.com/apache/phoenix/pull/1766#discussion_r1435015447
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/CDCMiscIT.java:
##
@@ -269,4 +273,109 @@ public void testDropCDCIndex () throws SQLException {
}
}
+private void assertResultSet(ResultSet rs) throws Exception{
+Gson gson = new Gson();
+assertEquals(true, rs.next());
+assertEquals(1, rs.getInt(2));
+assertEquals(new HashMap(){{put("V1", 100d);}},
gson.fromJson(rs.getString(3),
+HashMap.class));
+assertEquals(true, rs.next());
+assertEquals(2, rs.getInt(2));
+assertEquals(new HashMap(){{put("V1", 200d);}},
gson.fromJson(rs.getString(3),
+HashMap.class));
+assertEquals(true, rs.next());
+assertEquals(1, rs.getInt(2));
+assertEquals(new HashMap(){{put("V1", 101d);}},
gson.fromJson(rs.getString(3),
+HashMap.class));
+assertEquals(false, rs.next());
+rs.close();
+}
+
+@Test
+public void testSelectCDC() throws Exception {
+Properties props = new Properties();
+props.put(QueryServices.TASK_HANDLING_INTERVAL_MS_ATTRIB,
Long.toString(Long.MAX_VALUE));
+props.put("hbase.client.scanner.timeout.period", "600");
+props.put("phoenix.query.timeoutMs", "600");
+props.put("zookeeper.session.timeout", "600");
+props.put("hbase.rpc.timeout", "600");
+Connection conn = DriverManager.getConnection(getUrl(), props);
+String tableName = generateUniqueName();
+conn.createStatement().execute(
+"CREATE TABLE " + tableName + " ( k INTEGER PRIMARY KEY," + "
v1 INTEGER)");
+conn.createStatement().execute("UPSERT INTO " + tableName + " (k, v1)
VALUES (1, 100)");
+conn.createStatement().execute("UPSERT INTO " + tableName + " (k, v1)
VALUES (2, 200)");
+conn.commit();
+Thread.sleep(1000);
+conn.createStatement().execute("UPSERT INTO " + tableName + " (k, v1)
VALUES (1, 101)");
+conn.commit();
+String cdcName = generateUniqueName();
+String cdc_sql = "CREATE CDC " + cdcName
Review Comment:
@tkhurana In any case, I am not planning to address these as part of this
PR, so are you OK to merge this as is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (PHOENIX-7157) Upgrade to phoenix-thirdparty 2.1.0
[
https://issues.apache.org/jira/browse/PHOENIX-7157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799803#comment-17799803
]
ASF GitHub Bot commented on PHOENIX-7157:
-
NihalJain commented on PR #1772:
URL: https://github.com/apache/phoenix/pull/1772#issuecomment-1867583328
This is a backport of https://github.com/apache/phoenix/pull/1771.
Created this to let jenkins build/test the change and ensure no error.
> Upgrade to phoenix-thirdparty 2.1.0
> ---
>
> Key: PHOENIX-7157
> URL: https://issues.apache.org/jira/browse/PHOENIX-7157
> Project: Phoenix
> Issue Type: Improvement
> Components: core
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
>
> Phoenix-thirdparty has been released, see
> [https://www.mail-archive.com/user@phoenix.apache.org/msg08204.html]
> {quote}The recent release has upgraded Guava to version 32.1.3-jre from the
> previous 31.0.1-android version. Initially, the 4.x branch maintained
> compatibility with Java 7, necessitating the use of the Android variant of
> Guava. However, with the end-of-life (EOL) status of the 4.x branch, the move
> to the standard JRE version of Guava signifies a shift in compatibility
> standards
> {quote}
> It's time we bump up. Also, now PHOENIX-7116 is in place so we can pull this
> to branch 5.1.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] PHOENIX-7157 Upgrade to phoenix-thirdparty 2.1.0 [phoenix]
NihalJain commented on PR #1772: URL: https://github.com/apache/phoenix/pull/1772#issuecomment-1867583328 This is a backport of https://github.com/apache/phoenix/pull/1771. Created this to let jenkins build/test the change and ensure no error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799802#comment-17799802 ] ASF GitHub Bot commented on PHOENIX-7130: - NihalJain commented on PR #1745: URL: https://github.com/apache/phoenix/pull/1745#issuecomment-1867582477 Please donot push this to 5.1, have raised another PR for 5.1 as code is a bit different. > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] PHOENIX-7130 Support skipping of shade sources jar creation [phoenix]
NihalJain commented on PR #1745: URL: https://github.com/apache/phoenix/pull/1745#issuecomment-1867582477 Please donot push this to 5.1, have raised another PR for 5.1 as code is a bit different. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799801#comment-17799801 ] ASF GitHub Bot commented on PHOENIX-7130: - NihalJain commented on PR #1773: URL: https://github.com/apache/phoenix/pull/1773#issuecomment-1867581510 This is a backport of https://github.com/apache/phoenix/pull/1745 > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799800#comment-17799800 ] ASF GitHub Bot commented on PHOENIX-7130: - NihalJain opened a new pull request, #1773: URL: https://github.com/apache/phoenix/pull/1773 (no comment) > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] PHOENIX-7130 Support skipping of shade sources jar creation [phoenix]
NihalJain commented on PR #1773: URL: https://github.com/apache/phoenix/pull/1773#issuecomment-1867581510 This is a backport of https://github.com/apache/phoenix/pull/1745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] PHOENIX-7130 Support skipping of shade sources jar creation [phoenix]
NihalJain opened a new pull request, #1773: URL: https://github.com/apache/phoenix/pull/1773 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] PHOENIX-7158 Update Connectors to phoenix-thirdparty 2.1.0 [phoenix-connectors]
stoty commented on PR #125: URL: https://github.com/apache/phoenix-connectors/pull/125#issuecomment-1867577116 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 12s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | -1 :x: | mvninstall | 0m 12s | root in master failed. | | -1 :x: | compile | 0m 6s | root in master failed. | | -1 :x: | javadoc | 0m 6s | root in master failed. | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 0m 6s | root in the patch failed. | | -1 :x: | compile | 0m 6s | root in the patch failed. | | -1 :x: | javac | 0m 6s | root in the patch failed. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | -1 :x: | javadoc | 0m 6s | root in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 0m 6s | root in the patch failed. | | +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. | | | | 7m 38s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-125/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix-connectors/pull/125 | | Optional Tests | dupname asflicense javac javadoc unit xml compile | | uname | Linux e60d81ed8364 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-connectors-personality.sh | | git revision | master / 80abdb4 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-125/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-125/1/artifact/yetus-general-check/output/branch-compile-root.txt | | javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-125/1/artifact/yetus-general-check/output/branch-javadoc-root.txt | | mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-125/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-125/1/artifact/yetus-general-check/output/patch-compile-root.txt | | javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-125/1/artifact/yetus-general-check/output/patch-compile-root.txt | | javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-125/1/artifact/yetus-general-check/output/patch-javadoc-root.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-125/1/artifact/yetus-general-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-125/1/testReport/ | | Max. process+thread count | 52 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-125/1/console | | versions | git=2.7.4 maven=3.3.9 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-7158) Update Connectors to phoenix-thirdparty 2.1.0
[ https://issues.apache.org/jira/browse/PHOENIX-7158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799797#comment-17799797 ] ASF GitHub Bot commented on PHOENIX-7158: - stoty commented on PR #125: URL: https://github.com/apache/phoenix-connectors/pull/125#issuecomment-1867577116 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 12s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | -1 :x: | mvninstall | 0m 12s | root in master failed. | | -1 :x: | compile | 0m 6s | root in master failed. | | -1 :x: | javadoc | 0m 6s | root in master failed. | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 0m 6s | root in the patch failed. | | -1 :x: | compile | 0m 6s | root in the patch failed. | | -1 :x: | javac | 0m 6s | root in the patch failed. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | -1 :x: | javadoc | 0m 6s | root in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 0m 6s | root in the patch failed. | | +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. | | | | 7m 38s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-125/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix-connectors/pull/125 | | Optional Tests | dupname asflicense javac javadoc unit xml compile | | uname | Linux e60d81ed8364 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-connectors-personality.sh | | git revision | master / 80abdb4 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-125/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-125/1/artifact/yetus-general-check/output/branch-compile-root.txt | | javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-125/1/artifact/yetus-general-check/output/branch-javadoc-root.txt | | mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-125/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-125/1/artifact/yetus-general-check/output/patch-compile-root.txt | | javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-125/1/artifact/yetus-general-check/output/patch-compile-root.txt | | javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-125/1/artifact/yetus-general-check/output/patch-javadoc-root.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-125/1/artifact/yetus-general-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-125/1/testReport/ | | Max. process+thread count | 52 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-125/1/console | | versions | git=2.7.4 maven=3.3.9 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. > Update Connectors to phoenix-thirdparty 2.1.0 > - > > Key: PHOENIX-7158 > URL: https://issues.apache.org/jira/browse/PHOENIX-7158 > Project: Phoenix > Issue Type: Improvement > Components: connectors >Reporter: Nihal Jain >Assignee: Nihal Jain >
[jira] [Commented] (PHOENIX-7130) Add maven profile to support skipping of shade sources jar creation
[
https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799795#comment-17799795
]
ASF GitHub Bot commented on PHOENIX-7130:
-
NihalJain commented on code in PR #1745:
URL: https://github.com/apache/phoenix/pull/1745#discussion_r1434976744
##
pom.xml:
##
@@ -1887,6 +1888,17 @@
@{jacocoArgLine}
+
Review Comment:
Hi @stoty Removed the profile as suggested by you.
> Add maven profile to support skipping of shade sources jar creation
> ---
>
> Key: PHOENIX-7130
> URL: https://issues.apache.org/jira/browse/PHOENIX-7130
> Project: Phoenix
> Issue Type: Improvement
> Components: phoenix
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
>
> Shade sources jar creation takes a lot of time and we do not want to do this
> for every dev build (in our internal phoenix jenkins). Hence with this Jira,
> will add a profile to disable shade jar creation optionally by running with
> '-PskipShadeSources'.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] PHOENIX-7130 Add maven profile to support skipping of shade sources j… [phoenix]
NihalJain commented on code in PR #1745:
URL: https://github.com/apache/phoenix/pull/1745#discussion_r1434976744
##
pom.xml:
##
@@ -1887,6 +1888,17 @@
@{jacocoArgLine}
+
Review Comment:
Hi @stoty Removed the profile as suggested by you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (PHOENIX-7158) Update Connectors to phoenix-thirdparty 2.1.0
[
https://issues.apache.org/jira/browse/PHOENIX-7158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799792#comment-17799792
]
ASF GitHub Bot commented on PHOENIX-7158:
-
NihalJain opened a new pull request, #125:
URL: https://github.com/apache/phoenix-connectors/pull/125
(no comment)
> Update Connectors to phoenix-thirdparty 2.1.0
> -
>
> Key: PHOENIX-7158
> URL: https://issues.apache.org/jira/browse/PHOENIX-7158
> Project: Phoenix
> Issue Type: Improvement
> Components: connectors
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
>
> Phoenix-thirdparty has been released, see
> [https://www.mail-archive.com/user@phoenix.apache.org/msg08204.html]
> {quote}The recent release has upgraded Guava to version 32.1.3-jre from the
> previous 31.0.1-android version. Initially, the 4.x branch maintained
> compatibility with Java 7, necessitating the use of the Android variant of
> Guava. However, with the end-of-life (EOL) status of the 4.x branch, the move
> to the standard JRE version of Guava signifies a shift in compatibility
> standards
> {quote}
> It's time we bump up. Also, now PHOENIX-7116 is in place so we can pull this
> to branch 5.1.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] PHOENIX-7158 Update Connectors to phoenix-thirdparty 2.1.0 [phoenix-connectors]
NihalJain opened a new pull request, #125: URL: https://github.com/apache/phoenix-connectors/pull/125 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-7157) Upgrade to phoenix-thirdparty 2.1.0
[
https://issues.apache.org/jira/browse/PHOENIX-7157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799788#comment-17799788
]
ASF GitHub Bot commented on PHOENIX-7157:
-
NihalJain opened a new pull request, #1772:
URL: https://github.com/apache/phoenix/pull/1772
(no comment)
> Upgrade to phoenix-thirdparty 2.1.0
> ---
>
> Key: PHOENIX-7157
> URL: https://issues.apache.org/jira/browse/PHOENIX-7157
> Project: Phoenix
> Issue Type: Improvement
> Components: core
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
>
> Phoenix-thirdparty has been released, see
> [https://www.mail-archive.com/user@phoenix.apache.org/msg08204.html]
> {quote}The recent release has upgraded Guava to version 32.1.3-jre from the
> previous 31.0.1-android version. Initially, the 4.x branch maintained
> compatibility with Java 7, necessitating the use of the Android variant of
> Guava. However, with the end-of-life (EOL) status of the 4.x branch, the move
> to the standard JRE version of Guava signifies a shift in compatibility
> standards
> {quote}
> It's time we bump up. Also, now PHOENIX-7116 is in place so we can pull this
> to branch 5.1.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] PHOENIX-7157 Upgrade to phoenix-thirdparty 2.1.0 [phoenix]
NihalJain opened a new pull request, #1772: URL: https://github.com/apache/phoenix/pull/1772 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6588) Update to phoenix-thirdparty 2.0.0
[ https://issues.apache.org/jira/browse/PHOENIX-6588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799785#comment-17799785 ] ASF GitHub Bot commented on PHOENIX-6588: - NihalJain opened a new pull request, #1771: URL: https://github.com/apache/phoenix/pull/1771 (no comment) > Update to phoenix-thirdparty 2.0.0 > -- > > Key: PHOENIX-6588 > URL: https://issues.apache.org/jira/browse/PHOENIX-6588 > Project: Phoenix > Issue Type: Improvement > Components: core >Affects Versions: 5.2.0 > Environment: Phoenix-thirparty now includes the upstream 1.5.0 > release instead of a patched 1.4 release. > The upstream 1.5.0 has the same option to fix parsing double quotes as the > patched 1.4 used previously, but uses a different API to activate it. > This is a breaking API change. >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 4.17.0, 5.2.0 > > > In phoenix-thirdparty 1.1 we've added a patch to fix CLI-254 which has been > plagueing Phoenix since forever. > commons-cli 1.5.0 includes the same fix, but uses a different API to enable > it. > PHOENIX-6575 tracks the commons-cli update in phoenix-thirdparty, and this > ticket tracks the API update in phoenix. > This requires bumping the phoenix-thirdparty version as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] PHOENIX-6588 Update to phoenix-thirdparty 2.0.0 [phoenix]
NihalJain opened a new pull request, #1771: URL: https://github.com/apache/phoenix/pull/1771 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OMID-254 Upgrade to phoenix-thirdparty 2.1.0 [phoenix-omid]
chrajeshbabu commented on PR #151: URL: https://github.com/apache/phoenix-omid/pull/151#issuecomment-1867419622 +lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OMID-254 Upgrade to phoenix-thirdparty 2.1.0 [phoenix-omid]
NihalJain commented on PR #151: URL: https://github.com/apache/phoenix-omid/pull/151#issuecomment-1867416988 Built code locally and ran tests.: ``` mvn clean install -Dhbase.version=2.5.6-hadoop3 -DskipTests mvn verify -Dsurefire.rerunFailingTestsCount=5 -Dhbase.version=2.5.6-hadoop3 ``` FYI @chrajeshbabu , @stoty , @gjacoby126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] OMID-254 Upgrade to phoenix-thirdparty 2.1.0 [phoenix-omid]
NihalJain opened a new pull request, #151: URL: https://github.com/apache/phoenix-omid/pull/151 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
