Re: [PR] PHOENIX-7237 Pherf unit tests PherfTest and ResourceTest are failing [phoenix]
ddupg commented on PR #1835: URL: https://github.com/apache/phoenix/pull/1835#issuecomment-1968517106 > I don't like this, as this is very brittle, and we will have the same problem again soon. (The previous patch has the same problem) > > The real problem is that pherf seems to try to load its test config from anywhere on the classpath. > > I would prefer that the logic in getResourcesPath is fixed so that it does not recursively search the whole classpath. > > https://github.com/apache/phoenix/blob/bc1e2e7bea40c7d03940748e8f1d9f6b23339867/phoenix-pherf/src/main/java/org/apache/phoenix/pherf/util/ResourceList.java#L103 Thanks @stoty for reviewing and opinion, I'll try to fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] PHOENIX-7237 Pherf unit tests PherfTest and ResourceTest are failing [phoenix]
stoty commented on PR #1835: URL: https://github.com/apache/phoenix/pull/1835#issuecomment-1968288626 I don't like this, as this is very brittle, and we will have the same problem again soon. (The previous patch has the same problem) The real problem is that pherf seems to try to load its test config from anywhere on the classpath. I would prefer that the logic in getResourcesPath is fixed so that it does not recursively search the whole classpath. https://github.com/apache/phoenix/blob/bc1e2e7bea40c7d03940748e8f1d9f6b23339867/phoenix-pherf/src/main/java/org/apache/phoenix/pherf/util/ResourceList.java#L103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] PHOENIX-7237 Pherf unit tests PherfTest and ResourceTest are failing [phoenix]
ddupg opened a new pull request, #1835: URL: https://github.com/apache/phoenix/pull/1835 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
